tadams

    public int score() {
        int score = 0;
        int frameIndex = 0;
        for (int frame = 0; frame < 10; frame++) {

            if (isStrike(frameIndex)) {
              score += 10 + rolls[frameIndex+1] + rolls[frameIndex+2];
              frameIndex++;

            } else if (isSpare(frameIndex)) {

tadams

    public enum FrameType {
        STRIKE,
        SPARE,
        OPEN;

        public static FrameType classifyFrame(int firstRoll, int secondRoll) {
            if (firstRoll == MAX_PINS) {
                return STRIKE;
            }
            if (firstRoll + secondRoll == MAX_PINS) {

tadams

    public enum FrameType {
        STRIKE {
            public int scoreFrame(int rolls[], int frameIndex) {
                return MAX_PINS + rolls[frameIndex+1] + rolls[frameIndex+2];
            }
        },
        SPARE {...},
        OPEN {...};

        public static FrameType classifyFrame(int firstRoll, int secondRoll) {...}

tadams

public class BowlingGame {

    public static final int MAX_PINS = 10;

    public enum FrameType {
        STRIKE {
            public int scoreFrame(int rolls[], int frameIndex) {
                return MAX_PINS + rolls[frameIndex+1] + rolls[frameIndex+2];
            }
            public int rollsInFrame() {

tadams

public enum FrameType {
    STRIKE {
        public int scoreFrame(int rolls[], int frameIndex) {
            return MAX_PINS + rolls[frameIndex+1] + rolls[frameIndex+2];
        }
        public int rollsInFrame() {
            return 1;
        }
    },
    SPARE {

tadams

public enum FrameType {
    STRIKE((rolls, frameIndex) -> MAX_PINS + rolls[frameIndex+1] + rolls[frameIndex+2],
           1),
    SPARE((rolls, frameIndex) -> MAX_PINS + rolls[frameIndex+2],
           2),
    OPEN((rolls, frameIndex) -> rolls[frameIndex] + rolls[frameIndex+1],
           2);

    private BiFunction<int[], Integer, Integer> scoreFunction;

tadams

public class UnknownJobRole extends JobRole {

    @Override
    public boolean isUnderSalaryBand() {
        return false;
    }

    @Override
    public boolean isHighTurnOverRole() {
        return false;

tadams

public enum VendorType {
    MANUFACTURER,
    DISTRIBUTOR,
    UNKNOWN;
}

tadams

public class Employee {

    JobRole jobRole;

    public boolean isRaiseDue() {
        return jobRole.isUnderSalaryBand() ||
               jobRole.isHighTurnOverRole();
    }
}

tadams

  public void validateCity(String cityCode) {
        Optional<City> city = findCity(cityCode);
        if (city.isPresent()) {
            return;
        }
        setError(CITY_INVALID, cityCode);
    }

    public Optional<City> findCity(String cityCode) {
        City city = cityRepository.get(cityCode);