Skip to content

Instantly share code, notes, and snippets.

View timmc-edx's full-sized avatar

Tim McCormack timmc-edx

View GitHub Profile
  • Why did [mistaken action] seem like the correct action at the time?
  • Why was the problem not detected automatically?
    • Why was the mistake caught late, not early?
  • Why was the problem not fixed automatically?
    • Why did this require manual intervention?
    • Why did this require human detection?
  • Were any of the contributing factors already known problems?
    • Why were they not addressed earlier?
    • Have we seen these in previous RCAs?
@timmc-edx
timmc-edx / pr-checklist.md
Last active January 27, 2021 14:14
Code review checklist, edX version

Have the following been addressed in the branch, if appropriate?

  • Tests (unit, API, integration)
  • Docs (source comments, doc directory, elsewhere)
  • Changelog
  • Compatibility with previous versions (calls, shared files or DBs, data formats -- backward and forward compatibility)
  • Rollback friendly?
  • Feature switches?

edX-specific considerations:

@timmc-edx
timmc-edx / first.py
Last active June 2, 2020 13:50
terrible scope example in python
# python3 ./first.py
import second
import builtins
builtins.magic = "wow"
second.some_func()