yiwu-arbug

2019/06/22-23:47:35.165822 7f4c9a6b1a40 [db/db_impl_open.cc:1314] DB pointer 0x55e337c5fdc0
2019/06/22-23:47:35.165918 7f4c9a6b1a40 [c/db_impl.cc:224] Titan DB open.
2019/06/22-23:47:35.165930 7f4c9a6b1a40 TitanDBOptions.dirname                : /tmp/rocksdbtest-0/titandb
2019/06/22-23:47:35.165940 7f4c9a6b1a40 TitanDBOptions.disable_background_gc  : 0
2019/06/22-23:47:35.165949 7f4c9a6b1a40 TitanDBOptions.max_background_gc      : 0
2019/06/22-23:47:35.165959 7f4c9a6b1a40 Column family [default], options:
2019/06/22-23:47:35.165969 7f4c9a6b1a40 TitanCFOptions.min_blob_size                : 32
2019/06/22-23:47:35.165980 7f4c9a6b1a40 TitanCFOptions.blob_file_compression        : kLZ4Compression
2019/06/22-23:47:35.165990 7f4c9a6b1a40 TitanCFOptions.blob_file_target_size        : 268435456
2019/06/22-23:47:35.166000 7f4c9a6b1a40 TitanCFOptions.blob_cache                   : (nil)

yiwu-arbug

Logging: ./mysql-test-run  --mysqld=--default-storage-engine=rocksdb --mysqld=--skip-innodb --mysqld=--default-tmp-storage-engine=MyISAM --mysqld=--rocksdb -- rocksdb.group_min_max
[Note] Global variable initial value (from cmd line) @@datadir = '/tmp/PYRvhhqEbm'
[Note] Global variable initial value (from cmd line) @@secure_file_priv = ''
[Note] Global variable initial value (from cmd line) @@lc_messages_dir = '/data/mysql-5.6/sql/share'
2019-06-17 00:52:09 0 [Warning] Insecure configuration for --secure-file-priv: Current value does not restrict location of generated files. Consider setting it to a valid, non-empty path.
2019-06-17 00:52:09 0 [Note] Setting num_sharded_locks=1 as sharding is OFF
2019-06-17 00:52:09 0 [Note] /data/mysql-5.6/sql/mysqld (mysqld 5.6.35-debug) starting as process 95932 ...
2019-06-17 00:52:09 95932 [Note] Flashcache bypass: disabled
2019-06-17 00:52:09 95932 [Note] Flashcache setup error is : open flash device failed

yiwu-arbug

# with move_files=true

root@docker:/data/tmp/sync_test > echo "x ==> y" | ./ldb_sync write_extern_sst --create_if_missing --db=./tmp ./tmp.sst
external SST file written to ./tmp.sst
root@docker:/data/tmp/sync_test > strace -ye fsync,fdatasync ./ldb_sync ingest_extern_sst --create_if_missing --db=./tmp --move_files ./tmp.sst
fdatasync(7</data/tmp/sync_test/tmp/MANIFEST-000012>) = 0
fdatasync(8</data/tmp/sync_test/tmp/000012.dbtmp>) = 0
fsync(4</data/tmp/sync_test/tmp>)       = 0
fsync(9</data/tmp/sync_test/tmp/OPTIONS-000014.dbtmp>) = 0
fdatasync(7</data/tmp/sync_test/tmp/MANIFEST-000012>) = 0

yiwu-arbug

root@docker:/data/rocksdb > make env/env_test.o -j12
$DEBUG_LEVEL is 1
Makefile:168: Warning: Compiling in debug mode. Don't use the resulting binary in production
  GEN      util/build_version.cc
$DEBUG_LEVEL is 1
Makefile:168: Warning: Compiling in debug mode. Don't use the resulting binary in production
  GEN      util/build_version.cc
  CC       env/env_test.o
env/env_test.cc: In member function 'virtual void rocksdb::EnvPosixTestWithParam_MultiRead_Test::TestBody()':
env/env_test.cc:1126:76: error: type qualifiers ignored on cast result type [-Werror=ignored-qualifiers]

yiwu-arbug

root@docker:/data/rocksdb > cmake . -DWITH_ZLIB=ON
CMake Error at CMakeLists.txt:95 (find_package):
  By not providing "Findzlib.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "zlib", but
  CMake did not find one.

  Could not find a package configuration file provided by "zlib" with any of
  the following names:

    zlibConfig.cmake

yiwu-arbug

TEST_P(BlockBasedTableTest, SeekShortKey) {
  TableConstructor c(BytewiseComparator(), true /*convert_to_internal_key*/);
  c.Add("a", "v");
  std::vector<std::string> keys;
  stl_wrappers::KVMap kvmap;
  Options options;
  BlockBasedTableOptions table_opt(GetBlockBasedTableOptions());
  options.table_factory.reset(NewBlockBasedTableFactory(table_opt));
  const ImmutableCFOptions ioptions(options);
  const MutableCFOptions moptions(options);

yiwu-arbug

diff --git a/db/dbformat.cc b/db/dbformat.cc
index b34b04ca4..843167b01 100644
--- a/db/dbformat.cc
+++ b/db/dbformat.cc
@@ -117,7 +117,6 @@ int InternalKeyComparator::Compare(const ParsedInternalKey& a,
   //    decreasing sequence number
   //    decreasing type (though sequence# should be enough to disambiguate)
   int r = user_comparator_->Compare(a.user_key, b.user_key);
-  PERF_COUNTER_ADD(user_key_comparison_count, 1);
   if (r == 0) {

yiwu-arbug

compression type: kSnappyCompression
input size       block_size=64k            block_size=32k            block_size=16k             block_size=8k             block_size=4k input file
      4227      3491  82.59% --      3491  82.59% 100.00%      3491  82.59% 100.00%      3491  82.59% 100.00%      3739  88.46% 107.10% cantrbry/xargs.1
      3721      2775  74.58% --      2775  74.58% 100.00%      2775  74.58% 100.00%      2775  74.58% 100.00%      2866  77.02% 103.28% cantrbry/grammar.lsp
   1029744    470447  45.69% --    474361  46.07% 100.83%    481165  46.73% 102.28%    497415  48.30% 105.73%    526737  51.15% 111.97% cantrbry/kennedy.xls
     38240     22073  57.72% --     23533  61.54% 106.61%     23754  62.12% 107.62%     25200  65.90% 114.17%     26618  69.61% 120.59% cantrbry/sum
    125179     86804  69.34% --     89451  71.46% 103.05%     92846  74.17% 106.96%     97111  77.58% 111.87%    102269  81.70% 117.82% cantrbry/asyoulik.txt
    513216    117189  22.83% --    118771  23.14% 101.35%    12135

yiwu-arbug

diff --git a/Makefile b/Makefile
index 7030eb48d..71c50701d 100644
--- a/Makefile
+++ b/Makefile
@@ -1086,6 +1086,9 @@ librocksdb_env_basic_test.a: env/env_basic_test.o $(LIBOBJECTS) $(TESTHARNESS)
 	$(AM_V_AR)rm -f $@
 	$(AM_V_at)$(AR) $(ARFLAGS) $@ $^
 
+compression_bench: tools/compression_bench.o $(BENCHTOOLOBJECTS)
+	$(AM_LINK)

yiwu-arbug

diff --git a/db/version_set.cc b/db/version_set.cc
index 12c7754b19..630ad19f2e 100644
--- a/db/version_set.cc
+++ b/db/version_set.cc
@@ -395,17 +395,21 @@ void DoGenerateLevelFilesBrief(LevelFilesBrief* file_level,
     Slice largest_key = files[i]->largest.Encode();
 
     // Copy key slice to sequential memory
+    /*
     size_t smallest_size = smallest_key.size();