Skip to content

Instantly share code, notes, and snippets.

@Aaronik
Created September 9, 2019 17:58
Show Gist options
  • Save Aaronik/f3af2cba71900eb8f7cc6e6c86ecde03 to your computer and use it in GitHub Desktop.
Save Aaronik/f3af2cba71900eb8f7cc6e6c86ecde03 to your computer and use it in GitHub Desktop.
  • After a PR is reviewed and approved (like this one is) by someone other than the PR author (usually me right now), then
  • PR Author merges into master
  • PR Author supervises what should be an automatic deploy to https://dashboard.heroku.com/apps/conserve-dev
  • If deploy is not successful, debug and/or roll back the heroku app to a working commit and probably revert the PR commit on master branch too until it can be re-proposed
  • If deploy is successful, PR author verifies the fix is deployed and working as intended in this test environment
  • If all looks good in the test environment, leave a comment on the GitHub Issue that the PR was working toward like: "Hey, I deployed a change for this at {url}. Please try it out and verify it resolves your issue".
  • If the Issue itself is assigned to you, but now you've done all the coding you think makes sense to resolve it, assign the Issue back to the Issue Author since the ball is now in their court to test make sure they got what they wanted, or otherwise make further change requests, which might lead to further PRs, and this loops again.
  • If no more changes/PRs are required to fulfill the issue, the Issue Author might close the issue or keep it open but add a "Needs Prod Deployment" label or something to help them keep track of the fact that they want to verify it in prod too. Or they can click "Deploy master to production" and verify the fix and roll back if necessary, none of which requires being too technical.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment