Created
July 20, 2017 15:03
-
-
Save Aniketh01/b0bb469cf1642bbbe12a84f4799896f2 to your computer and use it in GitHub Desktop.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<aniketh___> Aniketh Girish Also, there is a bug in the resource manager, https://bugs.kde.org/show_bug.cgi?id=359854 | |
5:27 PM got any work around to fix this thing? | |
5:27 PM The delete machanism is actually working, but the bundles duplicated due to this bug is causing an issue | |
5:27 PM S<scottyp_mobile> Scott petrovic Is that the resource manager? How do you edit a brush there | |
5:28 PM A preset is just a brush, not a bundle | |
5:28 PM A<aniketh___> Aniketh Girish I think the reporter might have mentioned about bundles I guess | |
5:28 PM or I send you the wrong bug report link | |
5:28 PM let me check | |
5:29 PM S<scottyp_mobile> Scott petrovic I don't see the word bundle in that report | |
5:29 PM A<aniketh___> Aniketh Girish yeah! | |
5:29 PM that's the bug report only | |
5:29 PM I tried with the resource manager, the same thing | |
5:30 PM similar bug exist there as well | |
5:30 PM after creating a bundle and editing it again after sometime and reopening the bundle manager creates a duplicate bundle with different name rather than overwritting the existing bundle | |
5:32 PM S<scottyp_mobile> Scott petrovic Was that the biggest bug with bundles? | |
5:33 PM A<aniketh___> Aniketh Girish I didn't get you, what do you mean? | |
5:34 PM S<scottyp_mobile> Scott petrovic Do you have a list of bugs? | |
5:34 PM That you are working off of | |
5:35 PM A<aniketh___> Aniketh Girish filtered search of bug.kde.org gave me this | |
5:35 PM https://bugs.kde.org/buglist.cgi?bug_status=UNCONFIRMED&bug_status=CONFIRMED&bug_status=ASSIGNED&bug_status=REOPENED&component=Resource%20Management&product=krita&query_format=advanced | |
5:35 PM here, all that are associated with the resource manager, I'm trying to solve it. | |
5:36 PM Deleting functionality wasn't there, So adding that | |
5:36 PM search method is also being added, | |
5:36 PM S<scottyp_mobile> Scott petrovic Maybe you need more direction | |
5:36 PM Woops. Let me read what you said | |
5:37 PM A<aniketh___> Aniketh Girish Yes! that would be great :) | |
5:38 PM oh! okay :) | |
5:38 PM S<scottyp_mobile> Scott petrovic The first three issues have to do with tags, so I would start there. You can ask Wolthera too. She is very familiar with that area | |
5:39 PM She might have good areas to look at | |
5:39 PM A<aniketh___> Aniketh Girish okay! But was the tagging section a part of the project? | |
5:39 PM I thought, it was only the resource manager/bundle manager | |
5:40 PM S<scottyp_mobile> Scott petrovic If the resource manager is having a hard time with tags, I would say it is part of it | |
5:41 PM A<aniketh___> Aniketh Girish okay! Will dig into that as well :) | |
5:41 PM S<scottyp_mobile> Scott petrovic You can see if wolthera thinks there is something more important | |
5:41 PM A<aniketh___> Aniketh Girish yeah! Sure. | |
5:42 PM I will have to look into tagging sections code base before and understand | |
5:42 PM I haven't went there | |
5:43 PM S<scottyp_mobile> Scott petrovic It always takes a bit of time getting familiar with a new code area | |
5:45 PM A<aniketh___> Aniketh Girish I know right | |
5:46 PM But, will look into that | |
5:47 PM let me get the functions that, I am working right now | |
5:48 PM I will move like this, complete the new feature functions -> bugs in the resource manager -> UI -> tagging bugs/features | |
5:50 PM until this time, I should get sufficient time to look into its code base. | |
5:52 PM S<scottyp_mobile> Scott petrovic What do you mean until this time. Do you know what your next task is? | |
5:52 PM That should help you know what part of the code to study | |
5:53 PM The first task will just take longer as it requires study. It is still good to have a task as it will help drive you to solve a problem | |
5:54 PM You might get distracted while looking through the code, but it is good to have a direction | |
5:54 PM A<aniketh___> Aniketh Girish I meant not like that! I meant that doing the other things like fixing bugs in resource manager and doing UI, I will use some time in between to look in to tagging's code base as well before I dig in. After understanding that, I will start working on it. | |
5:55 PM yes! I completely understand that. | |
5:55 PM S<scottyp_mobile> Scott petrovic Alright. We might be mixing up philosophies at this point | |
5:56 PM A<aniketh___> Aniketh Girish Would you suggest me which path I should follow? How should I move on? | |
5:56 PM S<scottyp_mobile> Scott petrovic Your task is to improve the resource manager correct? | |
5:56 PM A<aniketh___> Aniketh Girish yes | |
5:57 PM I would like myself to finish some work I am doing in the resource manager before second review phase. | |
5:58 PM S<scottyp_mobile> Scott petrovic With the bug search, half of the bugs look related to tags, so that would make the most improvement there. I would also ask Wolthera what she thinks needs the most improvement. Do one of the two things | |
5:58 PM A<aniketh___> Aniketh Girish okay | |
6:00 PM S<scottyp_mobile> Scott petrovic That would be my direction | |
6:01 PM A<aniketh___> Aniketh Girish okay. I will finish the functions I am writting for the delete and search methods, since small work is left. | |
6:01 PM Then I will start reading the taggging section | |
6:02 PM S<scottyp_mobile> Scott petrovic Did Wolthera_laptop agree? | |
6:02 PM A<aniketh___> Aniketh Girish any documentation for the tagging section available? | |
6:02 PM I haven't pinged her yet | |
6:03 PM can you start the topic in the channel? | |
6:03 PM S<scottyp_mobile> Scott petrovic She might know better things. There really aren't that many bug reports for that | |
6:03 PM A<aniketh___> Aniketh Girish okay! | |
6:03 PM S<scottyp_mobile> Scott petrovic Just pm her like you are me | |
6:03 PM A<aniketh___> Aniketh Girish No, I meant documentations for the codebase and tutorials on tagging and all | |
6:03 PM okay, I will ask her that | |
6:03 PM S<scottyp_mobile> Scott petrovic Documentation like how tagging works in the UI? | |
6:04 PM There might be a bit on docs.krita.org | |
6:04 PM A<aniketh___> Aniketh Girish like, documentation on what certain classes and functions of that do | |
6:04 PM S<scottyp_mobile> Scott petrovic That is what code comments are for | |
6:05 PM If you don't see comments, it will just be slower. Make sure to add comments as you figure things out | |
6:06 PM some programmers don't like to add comments, so it makes some parts of the code hard to get in | |
6:06 PM A<aniketh___> Aniketh Girish I meant something like this: https://userbase.kde.org/Krita/Manual/Resources/ResourcesOverview, https://api.kde.org/bundled-apps-api/calligra-apidocs/krita/html/ | |
6:07 PM S<scottyp_mobile> Scott petrovic Ahh. So how they work in the application, not classes and functions like you said | |
6:08 PM A<aniketh___> Aniketh Girish Yes, I do agree with that. I faced that issue with KNewStuff and KNSCore for the other part of the project we were dealing with. That's why I helped lenir to get documentation done in KNS framework | |
6:08 PM https://api.kde.org/bundled-apps-api/calligra-apidocs/krita/html/, this gives the later part | |
6:08 PM S<scottyp_mobile> Scott petrovic Docs.krita.org and probably that page are the best | |
6:09 PM I am not very familiar with the inner workings of the resource manager | |
6:09 PM <aniketh___> Aniketh Girish Docs.krita.org and https://userbase.kde.org/Krita/Manual/Resources/ResourcesOverview this shows the same doc though | |
6:09 PM S<scottyp_mobile> Scott petrovic I guess knowing how bundles are created, edited, and deleted would be a good start | |
6:09 PM A<aniketh___> Aniketh Girish Yeah! | |
6:09 PM S<scottyp_mobile> Scott petrovic That is all we have then | |
6:10 PM A<aniketh___> Aniketh Girish I was working on that only at the moment | |
6:10 PM I'm creating a delete button to delete the bundles at the moment | |
6:11 PM it takes away the item from the list, then it blacklists the data item, the I manually delete it. | |
6:11 PM That's how it works at the moment | |
6:12 PM S<scottyp_mobile> Scott petrovic Sounds like you are learning about it then. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment