Skip to content

Instantly share code, notes, and snippets.

@Aokromes
Last active September 8, 2019 08:31
Show Gist options
  • Save Aokromes/6e0416670325114dfd52e612a910a4a2 to your computer and use it in GitHub Desktop.
Save Aokromes/6e0416670325114dfd52e612a910a4a2 to your computer and use it in GitHub Desktop.
cherry picks to 4.3.4
<<<< here starts the mess <<<<
303f0a4430 (<chaodhib@gmail.com>) Fix MSG_MOVE_SET_* opcodes. The GUID of the concerned unit was missing from the packet.
c498966d23 (<joschiwald.trinity@gmail.com>) Core/Spells: cleanup raise ally code
052603a7e8 (<joschiwald.trinity@gmail.com>) fixed build
e6afebd150 (<joschiwald.trinity@gmail.com>) fixed warning
2dda0ed36a (<joschiwald.trinity@gmail.com>) fixed warning again :(
a463a704f2 (<dnpd.dd@gmail.com>) Core/Player: Remove a TC_LOG_ERROR copy paste mistake...
c136af8463 (<r00ty-tc@users.noreply.github.com>) Adjustments to spell facing - Adjusted HaveAtClient to accept Object* (still accepts all subordinates) - Use grid searcher to find players in visibility range for unit - Use client cache instead of "See or Detect" to decide who to send updates to - Adjusted SendUpdateToPlayer to send createobject packet only if not known to client
8a050c574f (<treeston.mmoc@gmail.com>) Merge pull request #16839 from chaodhib/spell_facing_fix
1cf1d4a1ea (<treeston.mmoc@gmail.com>) - Clean up spell facing behavior a bit. Visual target behavior should now be a lot smoother.
fcbbc60b93 (<fakepotato@yandex.ru>) Core/Players: Fix flight form & fall damage (#16955)
64675dc03a (<joschiwald.trinity@gmail.com>) Merge pull request #16876 from chaodhib/move_chase_follow_repositioning_fix
9064968a4d (<ovitnez@gmail.com>) Core/PacketsIO: Send correct messages about server first achievements depending on faction.
4b15369378 (<treeston.mmoc@gmail.com>) Core/Spells: Check TRIGGERED_DONT_REPORT_CAST_ERROR flag in SendCastResult rather than CheckCast.
2ae85d86d3 (<treeston.mmoc@gmail.com>) Merge pull request #17037 from Keader/TargetedMovementGeneratorFix
cherry pick together
1e1fcd6847 (<shauren.trinity@gmail.com>) Core/Auras: Fixed cooldowns for procs calling PreventDefaultAction() in aura proc script
9612ac0e27 (<shauren.trinity@gmail.com>) Core/Spells: Fixed Eclipse after recent proc cooldown changes
cherry pick together
c0cc4f7c68 (<treeston.mmoc@gmail.com>) Merge remote-tracking branch 'Golrag/LoS_object_size' into 3.3.5 (PR #15807)
07a8a35a46 (<snapperryen@gmail.com>) Core/Spells: fix client crash caused by pressing ESC after using spells Neural Needle and Flaming Arrow.
19aac66bc2 (<joschiwald.trinity@gmail.com>) Core/Movement: enable item use and spell cast when dismounting
7c25f3cffd (<michele.roscelli@gmail.com>) Merge pull request #16969 from tkrokli/cant_do_this_while_moving
19fa504ff5 (<treeston.mmoc@gmail.com>) Entities/Unit: Fix speed update packets if player is being moved by something else.
3d31e2a157 (<michele.roscelli@gmail.com>) Core/Spells: fix issue with Illumination talent (broken in #17122) (#17350)
e881afcd1c (<ariel-@users.noreply.github.com>) Core/Spell: Fix eviscerate AP coefficient, should be fixed, not random (#17085)
d7460887c8 (<elecyb@hotmail.com>) Core/Entities: Moved PITCH movement flags into TURNING mask (they do not cause movement in any direction alone, only combined with forward/backward/strafe)
3213e4712c (<robin.schriever.hude@web.de>) Core/Spells: Rewrite Steady Shot damage to deal correct damage when using Heirloom Weapons (#17481)
bc358fc381 (<robin.schriever.hude@web.de>) Core/Spell: Sheath of Light should add remaining ticks to healing done when refreshed (#17583)
6988407b43 (<ariel-@users.noreply.github.com>) Core/Spells: Fix Roar of Sacrifice damage part (#17519)
ef85d01746 (<ariel-@users.noreply.github.com>) Core/Entities: Readded check removed in d7460887c84107c9c83a9dd5259c8ab398928711, caused flying ghost players to not move if they died during a root effect, root flag was never cleared clientside and impeded movement.
22c4e87ebb (<forester.manv@gmail.com>) Core/Entities: add missing null pointer checks in HandleProcTriggerSpell. CID 1356245 (#17629)
03bef35500 (<treeston.mmoc@gmail.com>) Core/Spell: Quick readability change. Functionality not altered.
837caa0534 (<treeston.mmoc@gmail.com>) Merge remote-tracking branch 'Treeston/3.3.5-spellcastresult' into 3.3.5 (PR #17112)
330e5b0ebc (<shauren.trinity@gmail.com>) Core/DataStores: Reduce differences between branches - rename achievement related dbc fields
5b81f55141 (<ariel-@users.noreply.github.com>) Update SpellEffects.cpp
fe3a0bf7e1 (<ariel-@users.noreply.github.com>) Typo fix
fc858d1428 (<ghostrider@gmail.com>) Core/Battlefield: Fix buff unstack from horde team when new player join WG Close issues: #17977
4a38773e3e Core/Auras: Increase number of auras sent to client except for group updates (#17604)
9cdbf903e2 Core/BattlegroundMgr: Update Battlegrounds each second instead of every tick (just like Battlefield).
4073cc510a (<giacomopoz@gmail.com>) Core/Packets: Port packet handling rework from 6.x branch (#17777)
f5a0342913 (<ariel-@users.noreply.github.com>) Core/Spell: Calculate GO rotation for SPELL_EFFECT_TRANS_DOOR
5b81f55141 (<ariel-@users.noreply.github.com>) Update SpellEffects.cpp
14445d2202 (<ariel-@users.noreply.github.com>) Core/Misc: calculate rotation fields from orientation in some places it's impossible to get:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment