Skip to content

Instantly share code, notes, and snippets.

@Arcnor
Created November 3, 2011 15:38
Show Gist options
  • Save Arcnor/1336800 to your computer and use it in GitHub Desktop.
Save Arcnor/1336800 to your computer and use it in GitHub Desktop.
Bad addProperty
def addProperty(property : String, value : AnyRef) {
val propName = property.trim().toUpperCase();
var list = if (!(_props contains propName)) _props(propName) else {
var list = new ListBuffer[AnyRef]();
_props.put(propName, list);
list;
}
value -> list;
}
@drdozer
Copy link

drdozer commented Nov 3, 2011

var _props: Map[String, List[AnyVal]] = Map.empty()

def addProperty(property: String, value: AnyRef) {
val propName = property.trim.toUpperCase // don't need the () or ; here
val list = _props get property match {
case None => Nil // no item? return the empty list
case Some(items) => items // some items? return them
}
_props += (property -> value::list)
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment