Skip to content

Instantly share code, notes, and snippets.

@Ashoat

Ashoat/contributing.md

Created March 7, 2018 16:28
Show Gist options
  • Save Ashoat/643224612ef9080d269009a5f99fa1b7 to your computer and use it in GitHub Desktop.
Save Ashoat/643224612ef9080d269009a5f99fa1b7 to your computer and use it in GitHub Desktop.
Download ZIP
Raw
contributing.md

Contributing to the React Navigation Flow libdef

Please do not make changes directly to the libdef file in flow-typed without first submitting a PR to the libdef within the react-navigation repo. After your PR has been accepted in react-navigation, you can go ahead and submit a PR on flow-typed.

We admittedly have a slightly unusual system for maintaing our Flow types. We used to host Flow types directly in-package, but that prevented us from simultaneously supporting multiple React Native versions. To enable that support, we've moved our libdef to flow-typed, but we still want to (1) have our CI typecheck the libdef against our example projects, and (2) re view any changes to the libdef.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment