Created
May 2, 2014 21:45
-
-
Save BanzaiMan/86e677988dfb699cc49f to your computer and use it in GitHub Desktop.
travis-ci/travis-build/67 comments
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| [ | |
| { | |
| "url": "https://api.github.com/repos/travis-ci/travis-build/issues/comments/12843020", | |
| "html_url": "https://github.com/travis-ci/travis-build/issues/67#issuecomment-12843020", | |
| "issue_url": "https://api.github.com/repos/travis-ci/travis-build/issues/67", | |
| "id": 12843020, | |
| "user": { | |
| "login": "henrikhodne", | |
| "id": 24421, | |
| "avatar_url": "https://avatars.githubusercontent.com/u/24421?", | |
| "gravatar_id": "d036be96167a38393d657c66a25ec85c", | |
| "url": "https://api.github.com/users/henrikhodne", | |
| "html_url": "https://github.com/henrikhodne", | |
| "followers_url": "https://api.github.com/users/henrikhodne/followers", | |
| "following_url": "https://api.github.com/users/henrikhodne/following{/other_user}", | |
| "gists_url": "https://api.github.com/users/henrikhodne/gists{/gist_id}", | |
| "starred_url": "https://api.github.com/users/henrikhodne/starred{/owner}{/repo}", | |
| "subscriptions_url": "https://api.github.com/users/henrikhodne/subscriptions", | |
| "organizations_url": "https://api.github.com/users/henrikhodne/orgs", | |
| "repos_url": "https://api.github.com/users/henrikhodne/repos", | |
| "events_url": "https://api.github.com/users/henrikhodne/events{/privacy}", | |
| "received_events_url": "https://api.github.com/users/henrikhodne/received_events", | |
| "type": "User", | |
| "site_admin": false | |
| }, | |
| "created_at": "2013-01-29T16:24:15Z", | |
| "updated_at": "2013-01-29T16:24:15Z", | |
| "body": "Looking at the documentation, I see nothing about multiple script entries at all. A quick fix would be to change it to `script-a && script-b && script-c …`.\r\n\r\nSince the behaviour here is undocumented (and therefore undefined), I think we should figure out whether the original implementation was bugged or this implementation. To be honest, this is how I though Travis worked all the time (only consider last script)." | |
| }, | |
| { | |
| "url": "https://api.github.com/repos/travis-ci/travis-build/issues/comments/12843425", | |
| "html_url": "https://github.com/travis-ci/travis-build/issues/67#issuecomment-12843425", | |
| "issue_url": "https://api.github.com/repos/travis-ci/travis-build/issues/67", | |
| "id": 12843425, | |
| "user": { | |
| "login": "weierophinney", | |
| "id": 25943, | |
| "avatar_url": "https://avatars.githubusercontent.com/u/25943?", | |
| "gravatar_id": "bda768a042bd034f3f8090401aa77935", | |
| "url": "https://api.github.com/users/weierophinney", | |
| "html_url": "https://github.com/weierophinney", | |
| "followers_url": "https://api.github.com/users/weierophinney/followers", | |
| "following_url": "https://api.github.com/users/weierophinney/following{/other_user}", | |
| "gists_url": "https://api.github.com/users/weierophinney/gists{/gist_id}", | |
| "starred_url": "https://api.github.com/users/weierophinney/starred{/owner}{/repo}", | |
| "subscriptions_url": "https://api.github.com/users/weierophinney/subscriptions", | |
| "organizations_url": "https://api.github.com/users/weierophinney/orgs", | |
| "repos_url": "https://api.github.com/users/weierophinney/repos", | |
| "events_url": "https://api.github.com/users/weierophinney/events{/privacy}", | |
| "received_events_url": "https://api.github.com/users/weierophinney/received_events", | |
| "type": "User", | |
| "site_admin": false | |
| }, | |
| "created_at": "2013-01-29T16:31:31Z", | |
| "updated_at": "2013-01-29T16:31:31Z", | |
| "body": "@henrikhodne We've been using Travis for around a year now; it has _always_ behaved in the way I described (if any command in `script` has a non-zero status, build is reported as failure). \r\n\r\nUsing `&&` does not work for us, as we really need to see if there are multiple vectors for failure -- in other words, if there are both test failures _and_ CS failures, we want to know all of that information.\r\n\r\nWe could definitely write an alternate script that does all of these things and sends an exit code itself -- but that leads to more room for error in our build process." | |
| }, | |
| { | |
| "url": "https://api.github.com/repos/travis-ci/travis-build/issues/comments/12856524", | |
| "html_url": "https://github.com/travis-ci/travis-build/issues/67#issuecomment-12856524", | |
| "issue_url": "https://api.github.com/repos/travis-ci/travis-build/issues/67", | |
| "id": 12856524, | |
| "user": { | |
| "login": "weierophinney", | |
| "id": 25943, | |
| "avatar_url": "https://avatars.githubusercontent.com/u/25943?", | |
| "gravatar_id": "bda768a042bd034f3f8090401aa77935", | |
| "url": "https://api.github.com/users/weierophinney", | |
| "html_url": "https://github.com/weierophinney", | |
| "followers_url": "https://api.github.com/users/weierophinney/followers", | |
| "following_url": "https://api.github.com/users/weierophinney/following{/other_user}", | |
| "gists_url": "https://api.github.com/users/weierophinney/gists{/gist_id}", | |
| "starred_url": "https://api.github.com/users/weierophinney/starred{/owner}{/repo}", | |
| "subscriptions_url": "https://api.github.com/users/weierophinney/subscriptions", | |
| "organizations_url": "https://api.github.com/users/weierophinney/orgs", | |
| "repos_url": "https://api.github.com/users/weierophinney/repos", | |
| "events_url": "https://api.github.com/users/weierophinney/events{/privacy}", | |
| "received_events_url": "https://api.github.com/users/weierophinney/received_events", | |
| "type": "User", | |
| "site_admin": false | |
| }, | |
| "created_at": "2013-01-29T20:38:30Z", | |
| "updated_at": "2013-01-29T20:38:30Z", | |
| "body": "@hoochie-coochie Cannot do that -- look at the scripts I pasted above. Several are using output redirection already." | |
| }, | |
| { | |
| "url": "https://api.github.com/repos/travis-ci/travis-build/issues/comments/12887924", | |
| "html_url": "https://github.com/travis-ci/travis-build/issues/67#issuecomment-12887924", | |
| "issue_url": "https://api.github.com/repos/travis-ci/travis-build/issues/67", | |
| "id": 12887924, | |
| "user": { | |
| "login": "lsmith77", | |
| "id": 300279, | |
| "avatar_url": "https://avatars.githubusercontent.com/u/300279?", | |
| "gravatar_id": "54787afbd0e7c30936101c2fa84bd89b", | |
| "url": "https://api.github.com/users/lsmith77", | |
| "html_url": "https://github.com/lsmith77", | |
| "followers_url": "https://api.github.com/users/lsmith77/followers", | |
| "following_url": "https://api.github.com/users/lsmith77/following{/other_user}", | |
| "gists_url": "https://api.github.com/users/lsmith77/gists{/gist_id}", | |
| "starred_url": "https://api.github.com/users/lsmith77/starred{/owner}{/repo}", | |
| "subscriptions_url": "https://api.github.com/users/lsmith77/subscriptions", | |
| "organizations_url": "https://api.github.com/users/lsmith77/orgs", | |
| "repos_url": "https://api.github.com/users/lsmith77/repos", | |
| "events_url": "https://api.github.com/users/lsmith77/events{/privacy}", | |
| "received_events_url": "https://api.github.com/users/lsmith77/received_events", | |
| "type": "User", | |
| "site_admin": false | |
| }, | |
| "created_at": "2013-01-30T12:45:00Z", | |
| "updated_at": "2013-01-30T12:45:00Z", | |
| "body": "@github autocomplete gone wrong? :)\r\n\r\nbtw just FYI .. this is the solution that the TYPO3 Flow guys took for CS sniffing:\r\nhttps://github.com/typo3-ci/TYPO3-CodeSniffer\r\n\r\nnot sure if this is a viable approach for you guys." | |
| }, | |
| { | |
| "url": "https://api.github.com/repos/travis-ci/travis-build/issues/comments/12897956", | |
| "html_url": "https://github.com/travis-ci/travis-build/issues/67#issuecomment-12897956", | |
| "issue_url": "https://api.github.com/repos/travis-ci/travis-build/issues/67", | |
| "id": 12897956, | |
| "user": { | |
| "login": "svenfuchs", | |
| "id": 2208, | |
| "avatar_url": "https://avatars.githubusercontent.com/u/2208?", | |
| "gravatar_id": "2f042f300d1249917adf6f13d3f698b2", | |
| "url": "https://api.github.com/users/svenfuchs", | |
| "html_url": "https://github.com/svenfuchs", | |
| "followers_url": "https://api.github.com/users/svenfuchs/followers", | |
| "following_url": "https://api.github.com/users/svenfuchs/following{/other_user}", | |
| "gists_url": "https://api.github.com/users/svenfuchs/gists{/gist_id}", | |
| "starred_url": "https://api.github.com/users/svenfuchs/starred{/owner}{/repo}", | |
| "subscriptions_url": "https://api.github.com/users/svenfuchs/subscriptions", | |
| "organizations_url": "https://api.github.com/users/svenfuchs/orgs", | |
| "repos_url": "https://api.github.com/users/svenfuchs/repos", | |
| "events_url": "https://api.github.com/users/svenfuchs/events{/privacy}", | |
| "received_events_url": "https://api.github.com/users/svenfuchs/received_events", | |
| "type": "User", | |
| "site_admin": false | |
| }, | |
| "created_at": "2013-01-30T16:27:39Z", | |
| "updated_at": "2013-01-30T16:27:39Z", | |
| "body": "@weierophinney It seems you've indeed relied on an undocumented feature there :)\r\n\r\nSince this has been in production for so long i think we should just restore the old behaviour. I'm going to give this a try.\r\n\r\nTo confirm: am i correct that it previously still executed all the scripts you have even if an early one exited with non-zero? and then it accumulated the status of all scripts?\r\n\r\n" | |
| }, | |
| { | |
| "url": "https://api.github.com/repos/travis-ci/travis-build/issues/comments/12898097", | |
| "html_url": "https://github.com/travis-ci/travis-build/issues/67#issuecomment-12898097", | |
| "issue_url": "https://api.github.com/repos/travis-ci/travis-build/issues/67", | |
| "id": 12898097, | |
| "user": { | |
| "login": "weierophinney", | |
| "id": 25943, | |
| "avatar_url": "https://avatars.githubusercontent.com/u/25943?", | |
| "gravatar_id": "bda768a042bd034f3f8090401aa77935", | |
| "url": "https://api.github.com/users/weierophinney", | |
| "html_url": "https://github.com/weierophinney", | |
| "followers_url": "https://api.github.com/users/weierophinney/followers", | |
| "following_url": "https://api.github.com/users/weierophinney/following{/other_user}", | |
| "gists_url": "https://api.github.com/users/weierophinney/gists{/gist_id}", | |
| "starred_url": "https://api.github.com/users/weierophinney/starred{/owner}{/repo}", | |
| "subscriptions_url": "https://api.github.com/users/weierophinney/subscriptions", | |
| "organizations_url": "https://api.github.com/users/weierophinney/orgs", | |
| "repos_url": "https://api.github.com/users/weierophinney/repos", | |
| "events_url": "https://api.github.com/users/weierophinney/events{/privacy}", | |
| "received_events_url": "https://api.github.com/users/weierophinney/received_events", | |
| "type": "User", | |
| "site_admin": false | |
| }, | |
| "created_at": "2013-01-30T16:29:53Z", | |
| "updated_at": "2013-01-30T16:29:53Z", | |
| "body": "@svenfuchs Yes -- all commands in the \"scripts\" section were run, and if any given one returned a non-zero exit status, the build was marked as failed (vs. using the exit status of the last script).\r\n\r\nGlad I saw the blog post today and read through it carefully -- I see the _why_ behind the change now!" | |
| }, | |
| { | |
| "url": "https://api.github.com/repos/travis-ci/travis-build/issues/comments/12898555", | |
| "html_url": "https://github.com/travis-ci/travis-build/issues/67#issuecomment-12898555", | |
| "issue_url": "https://api.github.com/repos/travis-ci/travis-build/issues/67", | |
| "id": 12898555, | |
| "user": { | |
| "login": "svenfuchs", | |
| "id": 2208, | |
| "avatar_url": "https://avatars.githubusercontent.com/u/2208?", | |
| "gravatar_id": "2f042f300d1249917adf6f13d3f698b2", | |
| "url": "https://api.github.com/users/svenfuchs", | |
| "html_url": "https://github.com/svenfuchs", | |
| "followers_url": "https://api.github.com/users/svenfuchs/followers", | |
| "following_url": "https://api.github.com/users/svenfuchs/following{/other_user}", | |
| "gists_url": "https://api.github.com/users/svenfuchs/gists{/gist_id}", | |
| "starred_url": "https://api.github.com/users/svenfuchs/starred{/owner}{/repo}", | |
| "subscriptions_url": "https://api.github.com/users/svenfuchs/subscriptions", | |
| "organizations_url": "https://api.github.com/users/svenfuchs/orgs", | |
| "repos_url": "https://api.github.com/users/svenfuchs/repos", | |
| "events_url": "https://api.github.com/users/svenfuchs/events{/privacy}", | |
| "received_events_url": "https://api.github.com/users/svenfuchs/received_events", | |
| "type": "User", | |
| "site_admin": false | |
| }, | |
| "created_at": "2013-01-30T16:37:17Z", | |
| "updated_at": "2013-01-30T16:37:17Z", | |
| "body": "Thanks for the quick feedback, @weierophinney. I'm gonna take a stab.\r\n\r\nAs a little bit of context, we've had a round of public review, beta testing with a good number of selected users and incremental rollout (also see https://github.com/travis-ci/travis-build/pull/60), but still you've been the first person to notice this change :)\r\n\r\nAgain, sorry about the issues." | |
| }, | |
| { | |
| "url": "https://api.github.com/repos/travis-ci/travis-build/issues/comments/13007268", | |
| "html_url": "https://github.com/travis-ci/travis-build/issues/67#issuecomment-13007268", | |
| "issue_url": "https://api.github.com/repos/travis-ci/travis-build/issues/67", | |
| "id": 13007268, | |
| "user": { | |
| "login": "svenfuchs", | |
| "id": 2208, | |
| "avatar_url": "https://avatars.githubusercontent.com/u/2208?", | |
| "gravatar_id": "2f042f300d1249917adf6f13d3f698b2", | |
| "url": "https://api.github.com/users/svenfuchs", | |
| "html_url": "https://github.com/svenfuchs", | |
| "followers_url": "https://api.github.com/users/svenfuchs/followers", | |
| "following_url": "https://api.github.com/users/svenfuchs/following{/other_user}", | |
| "gists_url": "https://api.github.com/users/svenfuchs/gists{/gist_id}", | |
| "starred_url": "https://api.github.com/users/svenfuchs/starred{/owner}{/repo}", | |
| "subscriptions_url": "https://api.github.com/users/svenfuchs/subscriptions", | |
| "organizations_url": "https://api.github.com/users/svenfuchs/orgs", | |
| "repos_url": "https://api.github.com/users/svenfuchs/repos", | |
| "events_url": "https://api.github.com/users/svenfuchs/events{/privacy}", | |
| "received_events_url": "https://api.github.com/users/svenfuchs/received_events", | |
| "type": "User", | |
| "site_admin": false | |
| }, | |
| "created_at": "2013-02-01T18:32:57Z", | |
| "updated_at": "2013-02-01T18:32:57Z", | |
| "body": "@weierophinney sorry, got bogged down by the rubygems security issues over the last two days.\r\n\r\nWanna review https://github.com/travis-ci/travis-build/pull/72 ? I believe this should fix the issue." | |
| }, | |
| { | |
| "url": "https://api.github.com/repos/travis-ci/travis-build/issues/comments/13007385", | |
| "html_url": "https://github.com/travis-ci/travis-build/issues/67#issuecomment-13007385", | |
| "issue_url": "https://api.github.com/repos/travis-ci/travis-build/issues/67", | |
| "id": 13007385, | |
| "user": { | |
| "login": "weierophinney", | |
| "id": 25943, | |
| "avatar_url": "https://avatars.githubusercontent.com/u/25943?", | |
| "gravatar_id": "bda768a042bd034f3f8090401aa77935", | |
| "url": "https://api.github.com/users/weierophinney", | |
| "html_url": "https://github.com/weierophinney", | |
| "followers_url": "https://api.github.com/users/weierophinney/followers", | |
| "following_url": "https://api.github.com/users/weierophinney/following{/other_user}", | |
| "gists_url": "https://api.github.com/users/weierophinney/gists{/gist_id}", | |
| "starred_url": "https://api.github.com/users/weierophinney/starred{/owner}{/repo}", | |
| "subscriptions_url": "https://api.github.com/users/weierophinney/subscriptions", | |
| "organizations_url": "https://api.github.com/users/weierophinney/orgs", | |
| "repos_url": "https://api.github.com/users/weierophinney/repos", | |
| "events_url": "https://api.github.com/users/weierophinney/events{/privacy}", | |
| "received_events_url": "https://api.github.com/users/weierophinney/received_events", | |
| "type": "User", | |
| "site_admin": false | |
| }, | |
| "created_at": "2013-02-01T18:35:23Z", | |
| "updated_at": "2013-02-01T18:35:23Z", | |
| "body": "@svenfuchs The solution in #72 looks solid after a quick glance. How would you like me to test?" | |
| }, | |
| { | |
| "url": "https://api.github.com/repos/travis-ci/travis-build/issues/comments/13009427", | |
| "html_url": "https://github.com/travis-ci/travis-build/issues/67#issuecomment-13009427", | |
| "issue_url": "https://api.github.com/repos/travis-ci/travis-build/issues/67", | |
| "id": 13009427, | |
| "user": { | |
| "login": "svenfuchs", | |
| "id": 2208, | |
| "avatar_url": "https://avatars.githubusercontent.com/u/2208?", | |
| "gravatar_id": "2f042f300d1249917adf6f13d3f698b2", | |
| "url": "https://api.github.com/users/svenfuchs", | |
| "html_url": "https://github.com/svenfuchs", | |
| "followers_url": "https://api.github.com/users/svenfuchs/followers", | |
| "following_url": "https://api.github.com/users/svenfuchs/following{/other_user}", | |
| "gists_url": "https://api.github.com/users/svenfuchs/gists{/gist_id}", | |
| "starred_url": "https://api.github.com/users/svenfuchs/starred{/owner}{/repo}", | |
| "subscriptions_url": "https://api.github.com/users/svenfuchs/subscriptions", | |
| "organizations_url": "https://api.github.com/users/svenfuchs/orgs", | |
| "repos_url": "https://api.github.com/users/svenfuchs/repos", | |
| "events_url": "https://api.github.com/users/svenfuchs/events{/privacy}", | |
| "received_events_url": "https://api.github.com/users/svenfuchs/received_events", | |
| "type": "User", | |
| "site_admin": false | |
| }, | |
| "created_at": "2013-02-01T19:19:47Z", | |
| "updated_at": "2013-02-01T19:19:47Z", | |
| "body": "@weierophinney awesome, thanks for the quick review. \r\n\r\nWe'll need to provision this to the staging workers first and have a test run. I'll poke @joshk later today." | |
| }, | |
| { | |
| "url": "https://api.github.com/repos/travis-ci/travis-build/issues/comments/13048142", | |
| "html_url": "https://github.com/travis-ci/travis-build/issues/67#issuecomment-13048142", | |
| "issue_url": "https://api.github.com/repos/travis-ci/travis-build/issues/67", | |
| "id": 13048142, | |
| "user": { | |
| "login": "joshk", | |
| "id": 8701, | |
| "avatar_url": "https://avatars.githubusercontent.com/u/8701?", | |
| "gravatar_id": "21b21efe14359ec323f9a70464b91e39", | |
| "url": "https://api.github.com/users/joshk", | |
| "html_url": "https://github.com/joshk", | |
| "followers_url": "https://api.github.com/users/joshk/followers", | |
| "following_url": "https://api.github.com/users/joshk/following{/other_user}", | |
| "gists_url": "https://api.github.com/users/joshk/gists{/gist_id}", | |
| "starred_url": "https://api.github.com/users/joshk/starred{/owner}{/repo}", | |
| "subscriptions_url": "https://api.github.com/users/joshk/subscriptions", | |
| "organizations_url": "https://api.github.com/users/joshk/orgs", | |
| "repos_url": "https://api.github.com/users/joshk/repos", | |
| "events_url": "https://api.github.com/users/joshk/events{/privacy}", | |
| "received_events_url": "https://api.github.com/users/joshk/received_events", | |
| "type": "User", | |
| "site_admin": false | |
| }, | |
| "created_at": "2013-02-03T15:08:21Z", | |
| "updated_at": "2013-02-03T15:08:21Z", | |
| "body": "Deployed to Org PPP and Common workers, will be rolled out to JVM and Pro over the next couple of days.\r\n\r\n<3<3<3 for reporting this." | |
| }, | |
| { | |
| "url": "https://api.github.com/repos/travis-ci/travis-build/issues/comments/13073573", | |
| "html_url": "https://github.com/travis-ci/travis-build/issues/67#issuecomment-13073573", | |
| "issue_url": "https://api.github.com/repos/travis-ci/travis-build/issues/67", | |
| "id": 13073573, | |
| "user": { | |
| "login": "svenfuchs", | |
| "id": 2208, | |
| "avatar_url": "https://avatars.githubusercontent.com/u/2208?", | |
| "gravatar_id": "2f042f300d1249917adf6f13d3f698b2", | |
| "url": "https://api.github.com/users/svenfuchs", | |
| "html_url": "https://github.com/svenfuchs", | |
| "followers_url": "https://api.github.com/users/svenfuchs/followers", | |
| "following_url": "https://api.github.com/users/svenfuchs/following{/other_user}", | |
| "gists_url": "https://api.github.com/users/svenfuchs/gists{/gist_id}", | |
| "starred_url": "https://api.github.com/users/svenfuchs/starred{/owner}{/repo}", | |
| "subscriptions_url": "https://api.github.com/users/svenfuchs/subscriptions", | |
| "organizations_url": "https://api.github.com/users/svenfuchs/orgs", | |
| "repos_url": "https://api.github.com/users/svenfuchs/repos", | |
| "events_url": "https://api.github.com/users/svenfuchs/events{/privacy}", | |
| "received_events_url": "https://api.github.com/users/svenfuchs/received_events", | |
| "type": "User", | |
| "site_admin": false | |
| }, | |
| "created_at": "2013-02-04T12:02:45Z", | |
| "updated_at": "2013-02-04T12:02:45Z", | |
| "body": "@weierophinney should be in production on travis-ci.org now. does this fix the issue?" | |
| }, | |
| { | |
| "url": "https://api.github.com/repos/travis-ci/travis-build/issues/comments/13133087", | |
| "html_url": "https://github.com/travis-ci/travis-build/issues/67#issuecomment-13133087", | |
| "issue_url": "https://api.github.com/repos/travis-ci/travis-build/issues/67", | |
| "id": 13133087, | |
| "user": { | |
| "login": "weierophinney", | |
| "id": 25943, | |
| "avatar_url": "https://avatars.githubusercontent.com/u/25943?", | |
| "gravatar_id": "bda768a042bd034f3f8090401aa77935", | |
| "url": "https://api.github.com/users/weierophinney", | |
| "html_url": "https://github.com/weierophinney", | |
| "followers_url": "https://api.github.com/users/weierophinney/followers", | |
| "following_url": "https://api.github.com/users/weierophinney/following{/other_user}", | |
| "gists_url": "https://api.github.com/users/weierophinney/gists{/gist_id}", | |
| "starred_url": "https://api.github.com/users/weierophinney/starred{/owner}{/repo}", | |
| "subscriptions_url": "https://api.github.com/users/weierophinney/subscriptions", | |
| "organizations_url": "https://api.github.com/users/weierophinney/orgs", | |
| "repos_url": "https://api.github.com/users/weierophinney/repos", | |
| "events_url": "https://api.github.com/users/weierophinney/events{/privacy}", | |
| "received_events_url": "https://api.github.com/users/weierophinney/received_events", | |
| "type": "User", | |
| "site_admin": false | |
| }, | |
| "created_at": "2013-02-05T15:04:15Z", | |
| "updated_at": "2013-02-05T15:04:15Z", | |
| "body": "@svenfuchs and @joshk Yes, indeed -- works great!\r\n\r\nI created an actual build script for ZF2 last week, as we really needed insight into the builds. However, a few other small projects of mine were still using the original notation I raised this issue about. I've pushed some changes to those today, and it's working beautifully!\r\n\r\nThanks again -- you folks rock!" | |
| } | |
| ] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment