Last active
August 29, 2015 14:25
-
-
Save BanzaiMan/c6f00138e7354b37fd66 to your computer and use it in GitHub Desktop.
Comments from https://github.com/travis-ci/casher/issues/6
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| [ | |
| { | |
| "url": "https://api.github.com/repos/travis-ci/casher/issues/comments/52886423", | |
| "html_url": "https://github.com/travis-ci/casher/issues/6#issuecomment-52886423", | |
| "issue_url": "https://api.github.com/repos/travis-ci/casher/issues/6", | |
| "id": 52886423, | |
| "user": { | |
| "login": "rkh", | |
| "id": 30442, | |
| "avatar_url": "https://avatars.githubusercontent.com/u/30442?v=3", | |
| "gravatar_id": "", | |
| "url": "https://api.github.com/users/rkh", | |
| "html_url": "https://github.com/rkh", | |
| "followers_url": "https://api.github.com/users/rkh/followers", | |
| "following_url": "https://api.github.com/users/rkh/following{/other_user}", | |
| "gists_url": "https://api.github.com/users/rkh/gists{/gist_id}", | |
| "starred_url": "https://api.github.com/users/rkh/starred{/owner}{/repo}", | |
| "subscriptions_url": "https://api.github.com/users/rkh/subscriptions", | |
| "organizations_url": "https://api.github.com/users/rkh/orgs", | |
| "repos_url": "https://api.github.com/users/rkh/repos", | |
| "events_url": "https://api.github.com/users/rkh/events{/privacy}", | |
| "received_events_url": "https://api.github.com/users/rkh/received_events", | |
| "type": "User", | |
| "site_admin": false | |
| }, | |
| "created_at": "2014-08-21T07:18:52Z", | |
| "updated_at": "2014-08-21T07:18:52Z", | |
| "body": "Yes, appending to (or overriding) the cache slug would be the right thing to do.\r\n\r\nThe code for generating the cache slug is in travis-build, btw." | |
| }, | |
| { | |
| "url": "https://api.github.com/repos/travis-ci/casher/issues/comments/52895750", | |
| "html_url": "https://github.com/travis-ci/casher/issues/6#issuecomment-52895750", | |
| "issue_url": "https://api.github.com/repos/travis-ci/casher/issues/6", | |
| "id": 52895750, | |
| "user": { | |
| "login": "joshk", | |
| "id": 8701, | |
| "avatar_url": "https://avatars.githubusercontent.com/u/8701?v=3", | |
| "gravatar_id": "", | |
| "url": "https://api.github.com/users/joshk", | |
| "html_url": "https://github.com/joshk", | |
| "followers_url": "https://api.github.com/users/joshk/followers", | |
| "following_url": "https://api.github.com/users/joshk/following{/other_user}", | |
| "gists_url": "https://api.github.com/users/joshk/gists{/gist_id}", | |
| "starred_url": "https://api.github.com/users/joshk/starred{/owner}{/repo}", | |
| "subscriptions_url": "https://api.github.com/users/joshk/subscriptions", | |
| "organizations_url": "https://api.github.com/users/joshk/orgs", | |
| "repos_url": "https://api.github.com/users/joshk/repos", | |
| "events_url": "https://api.github.com/users/joshk/events{/privacy}", | |
| "received_events_url": "https://api.github.com/users/joshk/received_events", | |
| "type": "User", | |
| "site_admin": false | |
| }, | |
| "created_at": "2014-08-21T09:08:31Z", | |
| "updated_at": "2014-08-21T09:08:31Z", | |
| "body": "@rkh how do you think the slug overridding should work?\r\n\r\nSomething similar to what was suggested for the `matrix: include` section?" | |
| }, | |
| { | |
| "url": "https://api.github.com/repos/travis-ci/casher/issues/comments/52902209", | |
| "html_url": "https://github.com/travis-ci/casher/issues/6#issuecomment-52902209", | |
| "issue_url": "https://api.github.com/repos/travis-ci/casher/issues/6", | |
| "id": 52902209, | |
| "user": { | |
| "login": "rkh", | |
| "id": 30442, | |
| "avatar_url": "https://avatars.githubusercontent.com/u/30442?v=3", | |
| "gravatar_id": "", | |
| "url": "https://api.github.com/users/rkh", | |
| "html_url": "https://github.com/rkh", | |
| "followers_url": "https://api.github.com/users/rkh/followers", | |
| "following_url": "https://api.github.com/users/rkh/following{/other_user}", | |
| "gists_url": "https://api.github.com/users/rkh/gists{/gist_id}", | |
| "starred_url": "https://api.github.com/users/rkh/starred{/owner}{/repo}", | |
| "subscriptions_url": "https://api.github.com/users/rkh/subscriptions", | |
| "organizations_url": "https://api.github.com/users/rkh/orgs", | |
| "repos_url": "https://api.github.com/users/rkh/repos", | |
| "events_url": "https://api.github.com/users/rkh/events{/privacy}", | |
| "received_events_url": "https://api.github.com/users/rkh/received_events", | |
| "type": "User", | |
| "site_admin": false | |
| }, | |
| "created_at": "2014-08-21T10:18:43Z", | |
| "updated_at": "2014-08-21T10:18:43Z", | |
| "body": "I don't know. I'm not very happy with how you define jobs in the\r\n.travis.yml.\r\n\r\n\r\nOn Thu, Aug 21, 2014 at 11:08 AM, Josh Kalderimis <notifications@github.com>\r\nwrote:\r\n\r\n> @rkh <https://github.com/rkh> how do you think the slug overridding\r\n> should work?\r\n>\r\n> Something similar to what was suggested for the matrix: include section?\r\n>\r\n> —\r\n> Reply to this email directly or view it on GitHub\r\n> <https://github.com/travis-ci/casher/issues/6#issuecomment-52895750>.\r\n>" | |
| }, | |
| { | |
| "url": "https://api.github.com/repos/travis-ci/casher/issues/comments/52902281", | |
| "html_url": "https://github.com/travis-ci/casher/issues/6#issuecomment-52902281", | |
| "issue_url": "https://api.github.com/repos/travis-ci/casher/issues/6", | |
| "id": 52902281, | |
| "user": { | |
| "login": "joshk", | |
| "id": 8701, | |
| "avatar_url": "https://avatars.githubusercontent.com/u/8701?v=3", | |
| "gravatar_id": "", | |
| "url": "https://api.github.com/users/joshk", | |
| "html_url": "https://github.com/joshk", | |
| "followers_url": "https://api.github.com/users/joshk/followers", | |
| "following_url": "https://api.github.com/users/joshk/following{/other_user}", | |
| "gists_url": "https://api.github.com/users/joshk/gists{/gist_id}", | |
| "starred_url": "https://api.github.com/users/joshk/starred{/owner}{/repo}", | |
| "subscriptions_url": "https://api.github.com/users/joshk/subscriptions", | |
| "organizations_url": "https://api.github.com/users/joshk/orgs", | |
| "repos_url": "https://api.github.com/users/joshk/repos", | |
| "events_url": "https://api.github.com/users/joshk/events{/privacy}", | |
| "received_events_url": "https://api.github.com/users/joshk/received_events", | |
| "type": "User", | |
| "site_admin": false | |
| }, | |
| "created_at": "2014-08-21T10:19:41Z", | |
| "updated_at": "2014-08-21T10:19:41Z", | |
| "body": "Tell me more!\r\n\r\n\r\n\r\n\r\nWhat makes you not happy? How can we make you happy?\r\n\r\nOn Thu, Aug 21, 2014 at 12:18 PM, Konstantin Haase\r\n<notifications@github.com> wrote:\r\n\r\n> I don't know. I'm not very happy with how you define jobs in the\r\n> .travis.yml.\r\n> On Thu, Aug 21, 2014 at 11:08 AM, Josh Kalderimis <notifications@github.com>\r\n> wrote:\r\n>> @rkh <https://github.com/rkh> how do you think the slug overridding\r\n>> should work?\r\n>>\r\n>> Something similar to what was suggested for the matrix: include section?\r\n>>\r\n>> —\r\n>> Reply to this email directly or view it on GitHub\r\n>> <https://github.com/travis-ci/casher/issues/6#issuecomment-52895750>.\r\n>>\r\n> ---\r\n> Reply to this email directly or view it on GitHub:\r\n> https://github.com/travis-ci/casher/issues/6#issuecomment-52902209" | |
| }, | |
| { | |
| "url": "https://api.github.com/repos/travis-ci/casher/issues/comments/52913939", | |
| "html_url": "https://github.com/travis-ci/casher/issues/6#issuecomment-52913939", | |
| "issue_url": "https://api.github.com/repos/travis-ci/casher/issues/6", | |
| "id": 52913939, | |
| "user": { | |
| "login": "rkh", | |
| "id": 30442, | |
| "avatar_url": "https://avatars.githubusercontent.com/u/30442?v=3", | |
| "gravatar_id": "", | |
| "url": "https://api.github.com/users/rkh", | |
| "html_url": "https://github.com/rkh", | |
| "followers_url": "https://api.github.com/users/rkh/followers", | |
| "following_url": "https://api.github.com/users/rkh/following{/other_user}", | |
| "gists_url": "https://api.github.com/users/rkh/gists{/gist_id}", | |
| "starred_url": "https://api.github.com/users/rkh/starred{/owner}{/repo}", | |
| "subscriptions_url": "https://api.github.com/users/rkh/subscriptions", | |
| "organizations_url": "https://api.github.com/users/rkh/orgs", | |
| "repos_url": "https://api.github.com/users/rkh/repos", | |
| "events_url": "https://api.github.com/users/rkh/events{/privacy}", | |
| "received_events_url": "https://api.github.com/users/rkh/received_events", | |
| "type": "User", | |
| "site_admin": false | |
| }, | |
| "created_at": "2014-08-21T12:40:55Z", | |
| "updated_at": "2014-08-21T12:40:55Z", | |
| "body": "Not to side track this, but the `include` syntax is similar to what I'd like to see, except you also need to define an `exclude: { }` to remove the default job.\r\n\r\nSo something like:\r\n\r\n``` yaml\r\njobs:\r\n- ruby: 2.0.0\r\n env: FOO=1\r\n- ruby: 1.9.3\r\n env: FOO=1\r\n- ruby: 2.0.0\r\n env: FOO=2\r\n```\r\n\r\nEspecially considering the complexity if we should ever have job groups. I can't see how you could define those with out current matrix generation without going insane.\r\n\r\nNote that this way to define it could be completely encapsulated in travis-yaml once it is used to generate the matrix, which in turn would possibly allow us to try it out (with feature flags etc).\r\n\r\nJust brainstorming here, also, should maybe be a separate issue." | |
| }, | |
| { | |
| "url": "https://api.github.com/repos/travis-ci/casher/issues/comments/52932010", | |
| "html_url": "https://github.com/travis-ci/casher/issues/6#issuecomment-52932010", | |
| "issue_url": "https://api.github.com/repos/travis-ci/casher/issues/6", | |
| "id": 52932010, | |
| "user": { | |
| "login": "theuni", | |
| "id": 417043, | |
| "avatar_url": "https://avatars.githubusercontent.com/u/417043?v=3", | |
| "gravatar_id": "", | |
| "url": "https://api.github.com/users/theuni", | |
| "html_url": "https://github.com/theuni", | |
| "followers_url": "https://api.github.com/users/theuni/followers", | |
| "following_url": "https://api.github.com/users/theuni/following{/other_user}", | |
| "gists_url": "https://api.github.com/users/theuni/gists{/gist_id}", | |
| "starred_url": "https://api.github.com/users/theuni/starred{/owner}{/repo}", | |
| "subscriptions_url": "https://api.github.com/users/theuni/subscriptions", | |
| "organizations_url": "https://api.github.com/users/theuni/orgs", | |
| "repos_url": "https://api.github.com/users/theuni/repos", | |
| "events_url": "https://api.github.com/users/theuni/events{/privacy}", | |
| "received_events_url": "https://api.github.com/users/theuni/received_events", | |
| "type": "User", | |
| "site_admin": false | |
| }, | |
| "created_at": "2014-08-21T14:58:20Z", | |
| "updated_at": "2014-08-21T14:58:20Z", | |
| "body": "If each job generated some unique ID, there would be no need to have to define these manually, so the syntax complexity wouldn't be an issue. For ex:\r\n```\r\nmatrix:\r\n include:\r\n - compiler: c\r\n env: FOO=foo BAR=bar\r\n - compiler: c++\r\n env: FOO=bar BAR=foo\r\n```\r\npseudocode:\r\njobid1 = cut(sha256sum(\"my/repo,mybranch,compiler: c,FOO=foo BAR=bar\"),8) = 69c673dc\r\njobid2 = cut(sha256sum(\"my/repo,mybranch,compiler: c,FOO=bar BAR=foo\"),8) = fe343593\r\n\r\nThose unique IDs could be used to form the cache slug, and I'm sure they would have plenty of other uses as well if exposed to the .yml's as env vars." | |
| }, | |
| { | |
| "url": "https://api.github.com/repos/travis-ci/casher/issues/comments/52990098", | |
| "html_url": "https://github.com/travis-ci/casher/issues/6#issuecomment-52990098", | |
| "issue_url": "https://api.github.com/repos/travis-ci/casher/issues/6", | |
| "id": 52990098, | |
| "user": { | |
| "login": "rkh", | |
| "id": 30442, | |
| "avatar_url": "https://avatars.githubusercontent.com/u/30442?v=3", | |
| "gravatar_id": "", | |
| "url": "https://api.github.com/users/rkh", | |
| "html_url": "https://github.com/rkh", | |
| "followers_url": "https://api.github.com/users/rkh/followers", | |
| "following_url": "https://api.github.com/users/rkh/following{/other_user}", | |
| "gists_url": "https://api.github.com/users/rkh/gists{/gist_id}", | |
| "starred_url": "https://api.github.com/users/rkh/starred{/owner}{/repo}", | |
| "subscriptions_url": "https://api.github.com/users/rkh/subscriptions", | |
| "organizations_url": "https://api.github.com/users/rkh/orgs", | |
| "repos_url": "https://api.github.com/users/rkh/repos", | |
| "events_url": "https://api.github.com/users/rkh/events{/privacy}", | |
| "received_events_url": "https://api.github.com/users/rkh/received_events", | |
| "type": "User", | |
| "site_admin": false | |
| }, | |
| "created_at": "2014-08-21T21:51:01Z", | |
| "updated_at": "2014-08-21T21:51:01Z", | |
| "body": "But then even changing an env var would invalidate the cache." | |
| }, | |
| { | |
| "url": "https://api.github.com/repos/travis-ci/casher/issues/comments/53060944", | |
| "html_url": "https://github.com/travis-ci/casher/issues/6#issuecomment-53060944", | |
| "issue_url": "https://api.github.com/repos/travis-ci/casher/issues/6", | |
| "id": 53060944, | |
| "user": { | |
| "login": "joshk", | |
| "id": 8701, | |
| "avatar_url": "https://avatars.githubusercontent.com/u/8701?v=3", | |
| "gravatar_id": "", | |
| "url": "https://api.github.com/users/joshk", | |
| "html_url": "https://github.com/joshk", | |
| "followers_url": "https://api.github.com/users/joshk/followers", | |
| "following_url": "https://api.github.com/users/joshk/following{/other_user}", | |
| "gists_url": "https://api.github.com/users/joshk/gists{/gist_id}", | |
| "starred_url": "https://api.github.com/users/joshk/starred{/owner}{/repo}", | |
| "subscriptions_url": "https://api.github.com/users/joshk/subscriptions", | |
| "organizations_url": "https://api.github.com/users/joshk/orgs", | |
| "repos_url": "https://api.github.com/users/joshk/repos", | |
| "events_url": "https://api.github.com/users/joshk/events{/privacy}", | |
| "received_events_url": "https://api.github.com/users/joshk/received_events", | |
| "type": "User", | |
| "site_admin": false | |
| }, | |
| "created_at": "2014-08-22T13:37:27Z", | |
| "updated_at": "2014-08-22T13:37:27Z", | |
| "body": "I would favour the `cache_id` approach at first as the unique ids approach is a bit complex and has a few edge cases." | |
| }, | |
| { | |
| "url": "https://api.github.com/repos/travis-ci/casher/issues/comments/53077585", | |
| "html_url": "https://github.com/travis-ci/casher/issues/6#issuecomment-53077585", | |
| "issue_url": "https://api.github.com/repos/travis-ci/casher/issues/6", | |
| "id": 53077585, | |
| "user": { | |
| "login": "theuni", | |
| "id": 417043, | |
| "avatar_url": "https://avatars.githubusercontent.com/u/417043?v=3", | |
| "gravatar_id": "", | |
| "url": "https://api.github.com/users/theuni", | |
| "html_url": "https://github.com/theuni", | |
| "followers_url": "https://api.github.com/users/theuni/followers", | |
| "following_url": "https://api.github.com/users/theuni/following{/other_user}", | |
| "gists_url": "https://api.github.com/users/theuni/gists{/gist_id}", | |
| "starred_url": "https://api.github.com/users/theuni/starred{/owner}{/repo}", | |
| "subscriptions_url": "https://api.github.com/users/theuni/subscriptions", | |
| "organizations_url": "https://api.github.com/users/theuni/orgs", | |
| "repos_url": "https://api.github.com/users/theuni/repos", | |
| "events_url": "https://api.github.com/users/theuni/events{/privacy}", | |
| "received_events_url": "https://api.github.com/users/theuni/received_events", | |
| "type": "User", | |
| "site_admin": false | |
| }, | |
| "created_at": "2014-08-22T15:47:21Z", | |
| "updated_at": "2014-08-22T15:47:21Z", | |
| "body": "@rkh In our case that would be exactly what we'd want, but after some thought, we're surely the exception rather than the rule there." | |
| }, | |
| { | |
| "url": "https://api.github.com/repos/travis-ci/casher/issues/comments/121780023", | |
| "html_url": "https://github.com/travis-ci/casher/issues/6#issuecomment-121780023", | |
| "issue_url": "https://api.github.com/repos/travis-ci/casher/issues/6", | |
| "id": 121780023, | |
| "user": { | |
| "login": "BanzaiMan", | |
| "id": 25666, | |
| "avatar_url": "https://avatars.githubusercontent.com/u/25666?v=3", | |
| "gravatar_id": "", | |
| "url": "https://api.github.com/users/BanzaiMan", | |
| "html_url": "https://github.com/BanzaiMan", | |
| "followers_url": "https://api.github.com/users/BanzaiMan/followers", | |
| "following_url": "https://api.github.com/users/BanzaiMan/following{/other_user}", | |
| "gists_url": "https://api.github.com/users/BanzaiMan/gists{/gist_id}", | |
| "starred_url": "https://api.github.com/users/BanzaiMan/starred{/owner}{/repo}", | |
| "subscriptions_url": "https://api.github.com/users/BanzaiMan/subscriptions", | |
| "organizations_url": "https://api.github.com/users/BanzaiMan/orgs", | |
| "repos_url": "https://api.github.com/users/BanzaiMan/repos", | |
| "events_url": "https://api.github.com/users/BanzaiMan/events{/privacy}", | |
| "received_events_url": "https://api.github.com/users/BanzaiMan/received_events", | |
| "type": "User", | |
| "site_admin": false | |
| }, | |
| "created_at": "2015-07-15T23:59:28Z", | |
| "updated_at": "2015-07-15T23:59:28Z", | |
| "body": "Replicated as https://github.com/travis-ci/travis-ci/issues/4393.\r\n\r\nI'm closing this, and disabling \"issues\" on this repository afterwards, so that we can track the issues in the central spot." | |
| } | |
| ] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment