Skip to content

Instantly share code, notes, and snippets.

@BenjaminPoncet
Last active March 29, 2024 10:11
Show Gist options
  • Save BenjaminPoncet/bbef9edc1d0800528813e75c1669e57e to your computer and use it in GitHub Desktop.
Save BenjaminPoncet/bbef9edc1d0800528813e75c1669e57e to your computer and use it in GitHub Desktop.
Synology VideoStation ffmpeg wrapper with DTS, EAC3 and TrueHD support. This project is no longer maintained: Please see the following projects: https://github.com/darknebular/Wrapper_VideoStation/ - https://github.com/AlexPresso/VideoStation-FFMPEG-Patcher
#!/bin/bash
rev="12"
_log(){
echo "$(date '+%Y-%m-%d %H:%M:%S') - ${streamid} - $1" >> /tmp/ffmpeg.log
}
_log_para(){
echo "$1" | fold -w 120 | sed "s/^.*$/$(date '+%Y-%m-%d %H:%M:%S') - ${streamid} - = &/" >> /tmp/ffmpeg.log
}
_term(){
rm /tmp/ffmpeg-${streamid}.stderr
_log "*** KILLCHILD ***"
kill -TERM "$childpid" 2>/dev/null
}
trap _term SIGTERM
arch=`uname -a | sed 's/.*synology_//' | cut -d '_' -f 1`
nas=`uname -a | sed 's/.*synology_//' | cut -d '_' -f 2`
pid=$$
paramvs=$@
stream="${@: -1}"
streamid="FFM$pid"
bin1=/var/packages/ffmpeg/target/bin/ffmpeg
bin2=/var/packages/VideoStation/target/bin/ffmpeg.orig
args=()
vcodec="KO"
while [[ $# -gt 0 ]]
do
case "$1" in
-i)
shift
movie="$1"
args+=("-i" "$1")
;;
-hwaccel)
shift
hwaccel="$1"
args+=("-hwaccel" "$1")
;;
-scodec)
shift
scodec="$1"
args+=("-scodec" "$1")
;;
-f)
shift
fcodec="$1"
args+=("-f" "$1")
;;
-map)
shift
args+=("-map" "$1")
idmap=`echo $1 | cut -d : -f 2`
if [ "$vcodec" = "KO" ]; then
vcodec=`/var/packages/ffmpeg/target/bin/ffprobe -v error -select_streams $idmap -show_entries stream=codec_name -of default=noprint_wrappers=1:nokey=1 "$movie" | head -n 1`
vcodecprofile=`/var/packages/ffmpeg/target/bin/ffprobe -v error -select_streams $idmap -show_entries stream=profile -of default=noprint_wrappers=1:nokey=1 "$movie" | head -n 1`
else
acodec=`/var/packages/ffmpeg/target/bin/ffprobe -v error -select_streams $idmap -show_entries stream=codec_name -of default=noprint_wrappers=1:nokey=1 "$movie" | head -n 1`
fi
;;
*)
args+=("$1")
;;
esac
shift
done
_log "*** PROCESS START REV $rev DS$nas ($arch) PID $pid ***"
streamdir=`dirname "$stream"`
device=`cat ${streamdir}/video_metadata | jq -r '.device'`
_log "DEVICE = $device"
_log "MOVIE = $movie"
set -- "${args[@]}"
argsnew=()
args1sv=()
args2sv=()
args1vs=()
args2vs=()
while [[ $# -gt 0 ]]
do
case "$1" in
-ss)
shift
argsnew+=("-ss" "$1")
args1sv+=("-ss" "$1")
args1sv+=("-noaccurate_seek")
args1vs+=("-ss" "$1")
args1vs+=("-noaccurate_seek")
args2sv+=("-analyzeduration" "10000000")
args2vs+=("-analyzeduration" "10000000")
;;
-i)
shift
argsnew+=("-i" "$1")
args1sv+=("-i" "$1")
args2sv+=("-i" "pipe:0" "-map" "0")
args1vs+=("-i" "$1")
args2vs+=("-i" "pipe:0" "-map" "0")
;;
-vf)
shift
if [ "$hwaccel" = "vaapi" ] && [ "$vcodecprofile" = "Main 10" ]; then
scale_w=`echo "${1}" | sed -e 's/.*=w=//g' | sed -e 's/:h=.*//g'`
scale_h=`echo "${1}" | sed -e 's/.*:h=//g'`
if let ${scale_w} AND let ${scale_h}; then
argsnew+=("-vf" "scale_vaapi=w=${scale_w}:h=${scale_h}:format=nv12,hwupload,setsar=sar=1")
else
argsnew+=("-vf" "scale_vaapi=format=nv12,hwupload,setsar=sar=1")
fi
else
argsnew+=("-vf" "$1")
fi
args2sv+=("-vf" "$1")
args1vs+=("-vf" "$1")
;;
-vcodec)
shift
argsnew+=("-vcodec" "$1")
args1sv+=("-vcodec" "copy")
args2sv+=("-vcodec" "$1")
args1vs+=("-vcodec" "$1")
args2vs+=("-vcodec" "copy")
;;
-acodec)
shift
if [ "$1" = "libfaac" ]; then
argsnew+=("-acodec" "aac")
args1sv+=("-acodec" "aac")
args2vs+=("-acodec" "aac")
else
argsnew+=("-acodec" "$1")
args1sv+=("-acodec" "$1")
args2vs+=("-acodec" "$1")
fi
args2sv+=("-acodec" "copy")
args1vs+=("-acodec" "copy")
;;
-ab)
shift
argsnew+=("-ab" "$1")
args1sv+=("-ab" "$1")
args2vs+=("-ab" "$1")
;;
-ac)
shift
argsnew+=("-ac" "$1")
args1sv+=("-ac" "$1")
args2vs+=("-ac" "$1")
;;
-f)
shift
argsnew+=("-f" "$1")
args1sv+=("-f" "mpegts")
args2sv+=("-f" "$1")
args1vs+=("-f" "mpegts")
args2vs+=("-f" "$1")
;;
-segment_format)
shift
argsnew+=("-segment_format" "$1")
args2vs+=("-segment_format" "$1")
args2sv+=("-segment_format" "$1")
;;
-segment_list_type)
shift
argsnew+=("-segment_list_type" "$1")
args2vs+=("-segment_list_type" "$1")
args2sv+=("-segment_list_type" "$1")
;;
-hls_seek_time)
shift
argsnew+=("-hls_seek_time" "$1")
args2vs+=("-hls_seek_time" "$1")
args2sv+=("-hls_seek_time" "$1")
;;
-segment_time)
shift
argsnew+=("-segment_time" "$1")
args2vs+=("-segment_time" "$1")
args2sv+=("-segment_time" "$1")
;;
-segment_time_delta)
shift
argsnew+=("-segment_time_delta" "$1")
args2vs+=("-segment_time_delta" "$1")
args2sv+=("-segment_time_delta" "$1")
;;
-segment_start_number)
shift
argsnew+=("-segment_start_number" "$1")
args2vs+=("-segment_start_number" "$1")
args2sv+=("-segment_start_number" "$1")
;;
-individual_header_trailer)
shift
argsnew+=("-individual_header_trailer" "$1")
args2vs+=("-individual_header_trailer" "$1")
args2sv+=("-individual_header_trailer" "$1")
;;
-avoid_negative_ts)
shift
argsnew+=("-avoid_negative_ts" "$1")
args2vs+=("-avoid_negative_ts" "$1")
args2sv+=("-avoid_negative_ts" "$1")
;;
-break_non_keyframes)
shift
argsnew+=("-break_non_keyframes" "$1")
args2vs+=("-break_non_keyframes" "$1")
args2sv+=("-break_non_keyframes" "$1")
;;
-max_muxing_queue_size)
shift
args2vs+=("-max_muxing_queue_size" "$1")
args2sv+=("-max_muxing_queue_size" "$1")
;;
-map)
shift
argsnew+=("-map" "$1")
args1sv+=("-map" "$1")
args1vs+=("-map" "$1")
;;
*)
argsnew+=("$1")
if [ "$stream" = "$1" ]; then
args1sv+=("-bufsize" "1024k" "pipe:1")
args2sv+=("$1")
args1vs+=("-bufsize" "1024k" "pipe:1")
args2vs+=("$1")
else
args2sv+=("$1")
args1vs+=("$1")
fi
;;
esac
shift
done
sed -i -e "s/{\"PID\":${pid},\"hardware_transcode\":true,/{\"PID\":${pid},\"hardware_transcode\":false,/" /tmp/VideoStation/enabled
startexectime=`date +%s`
if [ "$scodec" = "subrip" ]; then
_log "FFMPEG = $bin2"
_log "CODEC = $scodec"
_log "PARAMVS ="
_log_para "$paramvs"
$bin2 "${args[@]}" &> /tmp/ffmpeg-${streamid}.stderr &
elif [ "$fcodec" = "mjpeg" ]; then
_log "FFMPEG = $bin2"
_log "CODEC = $fcodec"
_log "PARAMVS ="
_log_para "$paramvs"
$bin2 "${args[@]}" &> /tmp/ffmpeg-${streamid}.stderr &
else
_log "VCODEC = $vcodec ($vcodecprofile)"
_log "ACODEC = $acodec"
_log "PARAMVS ="
_log_para "$paramvs"
_log "MODE = WRAP"
_log "FFMPEG = $bin1"
_log "PARAMWP ="
param1=${argsnew[@]}
_log_para "$param1"
$bin1 "${argsnew[@]}" &> /tmp/ffmpeg-${streamid}.stderr &
fi
childpid=$!
_log "CHILDPID = $childpid"
wait $childpid
if grep "Conversion failed!" /tmp/ffmpeg-${streamid}.stderr || grep "Error opening filters!" /tmp/ffmpeg-${streamid}.stderr || grep "Unrecognized option" /tmp/ffmpeg-${streamid}.stderr || grep "Invalid data found when processing input" /tmp/ffmpeg-${streamid}.stderr; then
_log "*** CHILD END ***"
startexectime=`date +%s`
_log "STDOUT ="
_log_para "`tail -n 15 /tmp/ffmpeg-${streamid}.stderr`"
_log "MODE = PIPE SV"
_log "FFMPEG1 = $bin1"
_log "FFMPEG2 = $bin2"
_log "PARAM1 ="
param1=${args1sv[@]}
_log_para "$param1"
_log "PARAM2 ="
param2=${args2sv[@]}
_log_para "$param2"
$bin1 "${args1sv[@]}" | $bin2 "${args2sv[@]}" &> /tmp/ffmpeg-${streamid}.stderr &
childpid=$!
_log "CHILDPID = $childpid"
wait $childpid
fi
if grep "Conversion failed!" /tmp/ffmpeg-${streamid}.stderr || grep "Error opening filters!" /tmp/ffmpeg-${streamid}.stderr || grep "Unrecognized option" /tmp/ffmpeg-${streamid}.stderr || grep "Invalid data found when processing input" /tmp/ffmpeg-${streamid}.stderr; then
_log "*** CHILD END ***"
startexectime=`date +%s`
_log "STDOUT ="
_log_para "`tail -n 15 /tmp/ffmpeg-${streamid}.stderr`"
_log "MODE = PIPE VS"
_log "FFMPEG1 = $bin2"
_log "FFMPEG2 = $bin1"
_log "PARAM1 ="
param1=${args1vs[@]}
_log_para "$param1"
_log "PARAM2 ="
param2=${args2vs[@]}
_log_para "$param2"
$bin2 "${args1vs[@]}" | $bin1 "${args2vs[@]}" &> /tmp/ffmpeg-${streamid}.stderr &
childpid=$!
_log "CHILDPID = $childpid"
wait $childpid
fi
if grep "Conversion failed!" /tmp/ffmpeg-${streamid}.stderr || grep "Error opening filters!" /tmp/ffmpeg-${streamid}.stderr || grep "Unrecognized option" /tmp/ffmpeg-${streamid}.stderr || grep "Invalid data found when processing input" /tmp/ffmpeg-${streamid}.stderr; then
_log "*** CHILD END ***"
startexectime=`date +%s`
_log "STDOUT ="
_log_para "`tail -n 15 /tmp/ffmpeg-${streamid}.stderr`"
_log "MODE = ORIG"
_log "FFMPEG = $bin2"
$bin2 "${args[@]}" &> /tmp/ffmpeg-${streamid}.stderr &
childpid=$!
_log "CHILDPID = $childpid"
wait $childpid
fi
stopexectime=`date +%s`
if test $((stopexectime-startexectime)) -lt 10; then
_log "STDOUT ="
_log_para "`tail -n 15 /tmp/ffmpeg-${streamid}.stderr`"
fi
_log "*** CHILD END ***"
_log "*** PROCESS END ***"
rm /tmp/ffmpeg-${streamid}.stderr
@AlexPresso
Copy link

AlexPresso commented Jun 23, 2022

Yes, I recently fixed an issue related to chromecast, you need to use the new wrapper, which removes all the useless scripting done in the current wrapper (and that sometimes failed with aac):

If you're already using my wrapper, you can use the following to install the new wrapper:

  • curl https://raw.githubusercontent.com/AlexPresso/VideoStation-FFMPEG-Patcher/main/patcher.sh | bash -s -- -unpatch
  • curl https://raw.githubusercontent.com/AlexPresso/VideoStation-FFMPEG-Patcher/main/patcher.sh | bash -s -- -patch

if you're not already using my wrapper, you need to uninstall + reinstall both VideoStation and Advanced Media Extensions, then you can run the following:

  • curl https://raw.githubusercontent.com/AlexPresso/VideoStation-FFMPEG-Patcher/main/patcher.sh | bash -s -- -patch

More infos in the repo readme: https://github.com/AlexPresso/VideoStation-FFMPEG-Patcher

[Edit] You may also need to enable "passthrough AC3" in the VideoStation options

@KidWar75
Copy link

Hey @AlexPresso, thx for the quick reply.

I did a proper "reinstall" ;
This is what I put in Putty :

root@xxx:~# curl https://raw.githubusercontent.com/AlexPresso/VideoStation- FFMPEG-Patcher/main/patcher.sh | bash -s -- -patch % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 4128 100 4128 0 0 15577 0 --:--:-- --:--:-- --:--:-- 15636 bash: illegal option -- p usage: bash [-a patch|unpatch] [-b branch]

When I launch a video I got the message : "failed to play the video because the file format, bla bla bla".
It's like the patch didn't work :(

@AlexPresso
Copy link

AlexPresso commented Jun 23, 2022

Oh my bad, I'm tired and forgot I changed the params, there you go:
curl https://raw.githubusercontent.com/AlexPresso/VideoStation-FFMPEG-Patcher/main/patcher.sh | bash -s -- -a patch

@KidWar75
Copy link

@AlexPresso
Works like a charm !
Thank you very much ! :)))

@darknebular
Copy link

darknebular commented Jun 24, 2022

Good logging script, But the active wrapper, Where is it?

And Why you change ffmpeg33 and ffmpeg27 in the CodecPack path? It´s not necessary for streaming movies via DS Video.
Why you change ffmpeg in the VideoStation Path? It´s not necessary, you can let it original.
For example, with my wrapper, you will have untouch the ffmpeg in VideoStation path, look:
image

This is the new Alex ´s Wrapper Script:

image

ONLY IT´S LOGGING. WTF? HOW THIS LINES ARE WORKING WITH DTS?

@AlexPresso
Copy link

AlexPresso commented Jun 25, 2022

You are wrong in everything you say.
As I said before, I spent a lot of time on reversing the libsynovte.so, VideoStation does use the following ffmpeg (depending if you have CodecPack or not, which is needed for HEVC and AAC):

  • VideoStation's ffmpeg
  • CodecPack's ffmpeg27, ffmpeg33 and ffmpeg41 (41 is not always present depending on the architecture).

The reason everything is working without previous processing is because the ffmpeg version distributed by SynoCommunity includes patches that handle the VideoStation's custom ffmpeg args.
It works the same way as the custom args I'm adding to the (coming soon) GStreamer SynoCommunity package, that is also needed by CodecPack on some architectures.

DTS and other formats are simply hard coded in libsynovte.so, to prevent VideoStation to decode it, once you patch it (inversing codec names so they're not checkable by the if conditions), if ffmpeg is compiled with support, it can handle it, simple as that.

@darknebular
Copy link

darknebular commented Jun 29, 2022

You can install CodecPack in any synology.
ffmpeg 27 is for surveillance station.
The other ffmpeg is for Synology Photos.

Nowdays, your wrapper only is logging the arguments, don´t derive to the SynoCommunity´s ffmpeg... It´s weird that with these logging lines, you can do DTS decoding...

@Johan303
Copy link

@AlexPresso
Magic! Worked like a charm. Thanks for your work!

@AlexPresso
Copy link

@darknebular

You can install CodecPack in any synology.

You can, but it's not mandatory in latest DSM version (since DSM 7, installing VideoStation doesn't force you to install CodecPack anymore), you only need it for HEVC + AAC, that's why you also need to patch de VideoStation's ffmpeg, in case CodecPack is not installed. It makes the script working in any case.

ffmpeg 27 is for surveillance station.

Again, you are wrong. Here are the ffmpeg versions by the libsynovte.so code: https://user-images.githubusercontent.com/15526962/143856786-1039b49f-1841-44ee-9679-dd380f63a8d7.png. In the version compiled for my architecture, you can clearly see it uses ffmpeg, ffmpeg27 and ffmpeg41 (also ffmpeg33 on some architectures).
The ffmpeg version used by surveillance station is now named ffmpegXX-for-surveillance, and ffmpeg used by AudioStation is named ffmpegXX-for-audio: https://imgur.com/a/4PyeG8u

The other ffmpeg is for Synology Photos.

That is obviously a "no" again.

Nowdays, your wrapper only is logging the arguments, don´t derive to the SynoCommunity´s ffmpeg... It´s weird that with these logging lines, you can do DTS decoding...

It's not weird, it's logic. My new wrapper is only here to log potential errors, so I can easily help people having issues in the future. How (and why) it's working is all explained in my last comment, I can't explain it better than that and because you're annoying me since the beggining, I won't help you understand it. It's all up on you, because you're an "Experto en seguridad informática".

don´t derive to the SynoCommunity´s ffmpeg

https://github.com/AlexPresso/VideoStation-FFMPEG-Patcher/blob/main/ffmpeg-wrapper.sh#L48 Now please stop, I'm done with you.

@AlexPresso
Copy link

@Johan303 you're welcome, feel free to ask if you need any help :)

@darknebular
Copy link

You can, but it's not mandatory in latest DSM version (since DSM 7, installing VideoStation doesn't force you to install CodecPack anymore), you only need it for HEVC + AAC, that's why you also need to patch de VideoStation's ffmpeg, in case CodecPack is not installed. It makes the script working in any case.

OK, Perfect. Thanks for your answer.

@darknebular
Copy link

darknebular commented Jun 29, 2022

I can't explain it better than that and because you're annoying

I'm glad you stopped using my version of the wrapper.
The tone of arrogance, you better keep it to yourself.

Best Regards A.H.

@darknebular
Copy link

https://github.com/AlexPresso/VideoStation-FFMPEG-Patcher/blob/main/ffmpeg-wrapper.sh#L48 Now please stop, I'm done with you.

You are using ALWAYS the Community´s ffmpeg, ohhh!!!

Well, don´t tell me anything more, ASSHOLE.

@darknebular
Copy link

darknebular commented Jun 29, 2022

@Johan303 you're welcome, feel free to ask if you need any help :)

Mr. arrogance or @AlexPresso , I wouldn't have been so upset with you, if in addition to thanking Benjamin, you had mentioned me too. You made use of a version of my wrapper without mentioning me.
When I said: "don´t derive to the SynoCommunity´s ffmpeg" I meant that there is really no criteria to push the videos to the original ffmpeg or to the SynoCommunity´s ffmpeg, because what you do is push EVERYTHING without a care. THERE ARE NO DERIVATIONS.

Now, you've done a wrapper by the easiest way, by tearing EVERYTHING to SynoCommunity's ffmpeg. You should say that with your wrapper, there is now no hardware acceleration.. NO, there isn´t full hardware acceleration with your "oh yeah! wrapper type"..

You should also say that now with your new wrapper you have no control over any arguments that are sent to any ffmpeg.

With my wrapper (Benjamin´s one with fixes), you can have that control, it predominates the use of the original ffmpeg that has hardware acceleration and only uses the SynoCommunity ffmpeg when it is 100% necessary. (few times).
Continue with your "reverse engineering" and touching more and more system´s files... "This is the way"...

I'm done with you too.

@AlexPresso
Copy link

AlexPresso commented Jun 29, 2022

I wouldn't have been so upset with you, if in addition to thanking Benjamin, you had mentioned me too. You made use of a version of my wrapper without mentioning me.

We already talked about it long time ago, I have nothing more to add.

When I said: "don´t derive to the SynoCommunity´s ffmpeg" I meant that there is really no criteria to push the videos to the original ffmpeg or to the SynoCommunity´s ffmpeg, because what you do is push EVERYTHING without a care. THERE ARE NO DERIVATIONS.

Now, you've done a wrapper by the easiest way, by tearing EVERYTHING to SynoCommunity's ffmpeg. You should say that with your wrapper, there is now no hardware acceleration.. NO, there isn´t full hardware acceleration with your "oh yeah! wrapper type"..

The SynoCommunity's ffmpeg is built with hardware acceleration support: https://github.com/SynoCommunity/spksrc/blob/master/cross/ffmpeg/Makefile#L51. Th0ma7 did a huge work on that, if you're running on an Intel CPU, the service-setup.sh script (https://github.com/SynoCommunity/spksrc/blob/master/spk/ffmpeg/src/service-setup.sh#L11), called when installing ffmpeg is checking if you're having a geminilake or an appollolake architecture, and then enables the iHD driver. If you're not running on a geminilake or appollolake architecture, you're still having hardware acceleration, through the legacy driver: i965 (Intel QuickSync), ffmpeg automatically falls back to it.

You should also say that now with your new wrapper you have no control over any arguments that are sent to any ffmpeg.

Of course you don't have control over any arguments but lambda people don't need it. Custom args are for advanced users, that are free to fork and/or directly customize the wrapper to their needs.

Continue with your "reverse engineering" and touching more and more system´s files... "This is the way"...

Of course I'll do... I won't stop until everything will work :) Currently Gstreamer (used by both VideoStation and CodecPack) doesn't support DTS when used with HEVC (that's why people can't make your wrapper work sometimes).

@KidWar75
Copy link

KidWar75 commented Jun 30, 2022

@Johan303 you're welcome, feel free to ask if you need any help :)

Mr. arrogance or @AlexPresso , I wouldn't have been so upset with you, if in addition to thanking Benjamin, you had mentioned me too. You made use of a version of my wrapper without mentioning me. When I said: "don´t derive to the SynoCommunity´s ffmpeg" I meant that there is really no criteria to push the videos to the original ffmpeg or to the SynoCommunity´s ffmpeg, because what you do is push EVERYTHING without a care. THERE ARE NO DERIVATIONS.

Now, you've done a wrapper by the easiest way, by tearing EVERYTHING to SynoCommunity's ffmpeg. You should say that with your wrapper, there is now no hardware acceleration.. NO, there isn´t full hardware acceleration with your "oh yeah! wrapper type"..

You should also say that now with your new wrapper you have no control over any arguments that are sent to any ffmpeg.

With my wrapper (Benjamin´s one with fixes), you can have that control, it predominates the use of the original ffmpeg that has hardware acceleration and only uses the SynoCommunity ffmpeg when it is 100% necessary. (few times). Continue with your "reverse engineering" and touching more and more system´s files... "This is the way"...

I'm done with you too.

Jesus christ, you're just a toxic person.
Unbelievable.

@darknebular
Copy link

EAC-3 is the same flow in my wrapper as DTS codec, both of them are not originally supported, DTS and EAC-3 with HEVC are working for me:
image

image

And, NO, you haven´t full hardware acceleration, now with SynoCommunity´s ffmpeg you have hardware acceleration (yes, but...) , but in MIXED mode, not FULL.
Decoding a movie with the original ffmpeg do around 9-10 minutes and with the SynoCommunity´s ffmpeg yo will have around 30-40 minutes in offline transcoding.

I remember to you that you was using a OLD version of my script and in this times DTS + HEVC doesn´t supported. Nowadays with 12.3.X version this is not a problem.

If you don't use my scripts again without mentioning me, everything will be fine with me.

@AlexPresso
Copy link

AlexPresso commented Jul 1, 2022

HEVC and EAC3 are working because your architecture (probably an intel CPU) doesn't use GStreamer (and also doesn't need it). Realtek CPUs use GStreamer (and LibOMX) to transcode HEVC. Yours is only using ffmpeg that's why.

Even with your wrapper, Realtek CPUs will never, ever, be able to transcode HEVC + DTS, until we finish to work on the SynoCommunity's GStreamer.

I remember to you that you was using a OLD version of my script and in this times DTS + HEVC doesn´t supported. Nowadays with 12.3.X version this is not a problem.

DTS and EAC3 were supported since Benjamin's version, but only for ffmpeg...

@darknebular
Copy link

darknebular commented Jul 2, 2022

HEVC and EAC3 are working because your architecture (probably an intel CPU) doesn't use GStreamer

I check it out With a DS120J (this is a Entry level NAS and It hasn´t intel CPU)...

HEVC + EAC3 and/or DTS is working fine with this version of my wrapper (AME_12.3.X) in this system (DS120J).

It´s working because my wrapper (from last versions 12.2 and later) tries to use the most original config as possible and original files, and only use ffmpeg from SynoCommunity for the audio (NOT SUPPORTED ORIGINALLY), in this case EAC3 or DTS...
Again, HEVC + DTS or EAC3 is working fine in all platforms.
HEVC is full supported in all synology nas from 7.0 and later firmwares. In my wrapper, HEVC is decoded using all original path, files and configurations and only It will use SynoCommunity´s ffmpeg for the audio channel in case that the codec are: DTS, EACS, TrueHD, if is another codec, all will be in full original and full hardware acceleration if the NAS is capable of it...

All cases are working. I tested again in:
DS120J, DS420, DS214play, DS218+,DS918+

@AlexPresso
Copy link

AlexPresso commented Jul 3, 2022

Yes, I understand what you did there (that's mostly all Benjamin's work but, whatever.), but it's only working on architectures where VideoStation and CodecPack are only using ffmpeg. On architectures using GStreamer (like a DS218Play), it won't work only by wrapping ffmpeg. No change in the wrapper will make it work because VideoStation directly launches both ffmpeg (for the audio) and GStreamer (with libOMX, for the video), if one of the processes fails to launch (like the default GStreamer because there is no SynoCommunity version at this time), the whole video decoding is canceled (because the gstreamer output is directly piped to the ffmpeg process). GStreamer needs a SynoCommunity version and also needs to be wrapped. That's what we're working on with Th0ma7.

By the way there's something I don't understand in your comment, if you mean that it's the wrapper that makes DTS and EAC3 working on VideoStation, you are (partially) wrong, the only thing that makes it work is calling the SynoCommunity ffmpeg (you could do a plain ln -s to the SynoCommunity ffmpeg it would work). The two only reasons why VideoStation is not able to decode DTS (and other licenced codecs) is because there's a if condition in the VideoStation's code preventing it to work AND the default ffmpeg is not compiled with DTS and other codecs support. Once you do sed -i -e 's/eac3/3cae/' -e 's/dts/std/' -e 's/truehd/dheurt/' "$libsynovte_path", you change the VideoStation's code to bypass the if conditions preventing it to call ffmpeg with DTS, EAC3 and TrueHD. Now calling directly SynoCommunity's ffmpeg (compiled with DTS support) with the generated args is sufficient to make it all work.
All the args processing done in the Benjamin's wrapper were made before the SynoCommunity's ffmpeg were able to handle VideoStation's custom args, there's no processing needed anymore.

In my opinion, and that's why I don't want to separate / wrap the audio and the video decoding using two different versions of ffmpeg is because the SynoCommunity one is running in a higher version and compiled with more support of codecs/new techs and also has some optimizations not present in the default ffmpeg: https://github.com/SynoCommunity/spksrc/tree/master/cross/ffmpeg/patches.

At this point, there's, in my opinion, no reason to keep using the default one as I always had better performances when using the SynoCommunity one rather than the default one.

@KidWar75
Copy link

KidWar75 commented Jul 5, 2022

Hoy @AlexPresso !
I made the mistake to update Advance Media Extensions… videos aren’t working anymore. Should I just repatch with your wrapper?
Cheers!

@AlexPresso
Copy link

Hi,
The best would be to unpatch and repatch, so it patches the new Advanced Media Extensions:

  • curl https://raw.githubusercontent.com/AlexPresso/VideoStation-FFMPEG-Patcher/main/patcher.sh | bash -s -- -a unpatch
  • curl https://raw.githubusercontent.com/AlexPresso/VideoStation-FFMPEG-Patcher/main/patcher.sh | bash -s -- -a patch

@KidWar75
Copy link

KidWar75 commented Jul 6, 2022

@AlexPresso as usual, works like a charm ! :D
Cheers !

@KidWar75
Copy link

KidWar75 commented Jul 6, 2022

@AlexPresso sorry for the spam but by any chance, could the update of Advance Media Extensions make the streaming of video slower?
I find it very slow to buffer.

@AlexPresso
Copy link

No worries :)
Hm... The update is not likely to be the reason because it always uses SynoCommunity ffmpeg when it calls the ffmpeg in AME (only the ffmpeg versions used by VideoStation).
Could you please open an issue on the repository and follow the steps to give me the log files, so we can have a look ? :)

@KidWar75
Copy link

KidWar75 commented Jul 7, 2022

No worries :) Hm... The update is not likely to be the reason because it always uses SynoCommunity ffmpeg when it calls the ffmpeg in AME (only the ffmpeg versions used by VideoStation). Could you please open an issue on the repository and follow the steps to give me the log files, so we can have a look ? :)

Noob question : do you have the link of the repository ?

@AlexPresso
Copy link

@va3lim
Copy link

va3lim commented Jul 19, 2022

Great job, Alex & Benjamin, for making it possible to play EAC3 on Video Station. I installed SynCommunity ffmpeg and Video-FFMPEG-Patcher on DSM 7.x, it is working wonderfully.

Do we have to re-run the patcher everytime VideoStation, Advanced Media Extensions or DSM is updated? Thank you so much.

@AlexPresso
Copy link

I'm glad it works great on your system :)

Do we have to re-run the patcher everytime VideoStation, Advanced Media Extensions or DSM is updated? Thank you so much.

Yes, because updating a package does change the ffmpeg files to the original ones, you need to unpatch and repatch it everytime you update VideoStation and Advanced Media Extensions. In some rare cases, you may also need to repatch when you update DSM, because doing it may automatically upgrade VS and AME packages.

@va3lim
Copy link

va3lim commented Jul 21, 2022

Thanks, Alex. I've disabled the auto-update on VideoStation & Advanced Media Extensions on my Synology, so I have better control when to patch ffmpeg wrapper.

@akvamassa
Copy link

Hello AlexPresso, maybe you know, is there a way to make the similar fix for MediaServer package?
I tried your solution from https://raw.githubusercontent.com/AlexPresso/VideoStation-FFMPEG-Patcher/main/patcher.sh and it worked fine with VideoStation. But I didn't like VideoStation, because it doesn't stream DLNA itself and I need PC or application for this. I like to choose and watch movies direct from my TV.
With MediaServer I have a problem that my TV doesn't recognize DTS. So would be great to tell Synology MediaServer to transcode DTS to another format when I am watching movies from TV on DLNA. I enabled transcoding for MediaServer in package settings (I have Synology DS420+) and made same things with ffmpeg and libsynovte.so which you do in your script. But after this TV says that movie file is not recognized :))) I am here beginner and no way to handle it myself.

@AlexPresso
Copy link

AlexPresso commented Jul 23, 2022

Hi, Yes, there's an opened issue for MediaServer on the repository, I'll have a look at it when I have time, but this will probably be made in another repository :)

@darknebular
Copy link

@akvamassa
I have this wrapper:
https://github.com/darknebular/Wrapper_VideoStation

With this wrapper, you only need to check this options in DLNA server y voila, It will working fine in your TV.
image

Best regards.

@darknebular
Copy link

darknebular commented Aug 8, 2022

@akvamassa

I just check it out right now with a DS420+, a DS216, with a DS918+ and DS920+ and a Panasonic VT30 (42) and a LG LED S8 (55) with my wrapper for DSM7.1 12.3.3, checking these options in DLNA server and all It´s working fine. I haven´t any error or messages saying "The file is not recognized".

I can confirm you that in DS120J is working too the DLNA.

Please,
Could you please delete the wrapper you currently have and then Could you try my wrapper?
https://github.com/darknebular/Wrapper_VideoStation

Best regards.

@akvamassa
Copy link

@darknebular, thanks a lot for your reply (replies :)). I didn't have time to check your solution on my device, but I will do it on next days and write here some feedback. It will be wonderful if this will work!

@darknebular
Copy link

@darknebular, thanks a lot for your reply (replies :)). I didn't have time to check your solution on my device, but I will do it on next days and write here some feedback. It will be wonderful if this will work!

Please, clear all changes after the install of my wrapper.
It´s a manual installation steps, but It´s not difficult.

If you have DSM 7.1 please go to 12.3.3 version. ([ffmpeg41-wrapper-DSM7_1] file)

Best regards.

@Godtux
Copy link

Godtux commented Aug 12, 2022

Bonjour,
Merci pour le partage.
Je viens de faire l'installation sur un 918+ qui a toutes les dernières mises à jour.
Ca fonctionne avec des films en codec AC3, mais avec des films en codec EAC3, le film ne se lance pas, il reste avec une boucle infinie de l'indicateur de chargement.
Bien cordialement
un grenoblois.

@Tevike
Copy link

Tevike commented Aug 12, 2022 via email

@AlexPresso
Copy link

@darknebular
Copy link

Bonjour,
Merci pour le partage.
Je viens de faire l'installation sur un 918+ qui a toutes les dernières mises à jour.
Ca fonctionne avec des films en codec AC3, mais avec des films en codec EAC3, le film ne se lance pas, il reste avec une boucle infinie de l'indicateur de chargement.
Bien cordialement
un grenoblois.

Exactly what wrapper has you installed?

Regards.

@Godtux
Copy link

Godtux commented Aug 12, 2022

Hello @darknebular
This is my first time trying this mod.
I have a stock (and up to date) DSM + ffmepg from synocommunity
Today, I launched the script in the first comment, and re started DSVideo.
V

@akvamassa
Copy link

akvamassa commented Aug 12, 2022

@darknebular hello again! Today I tried your wrapper.
I have DSM 7.1, newest MediaServer package, newest VideoStation package, newest Advanced Media Extensions, and ffmpeg 4.4.2-44 from SynoCommunity. I've enabled transcoding in MediaServer as you shown.

What is the result?
1)Files with DTS track are playable in the VideoStation through the browser and I hear it, but when I send them to the TV over DLNA my TV says "audiotrack is not supported" (and that's correct, my TV doesn't accept DTS so I need transcoding for audio).
2)When I try to access them from internal TV's DLNA player, DTS track is not visible/accessible, and one of my files is "unrecognized".

Here is content of my CodecPack and VideoStation directories:
image
Maybe I should copy "patched" libsynovte.so from VideoStation to MediaServer dir to fix p.2?

Answering my question. Yes. I made actions 5-8 from your list to patch the file libsynovte.so but in /var/packages/MediaServer/target/lib/ directory and now my TV is playing movie with DTS with its internal player!!!

Here one thing which I noticed and maybe you know how to improve it: if movie has 2 audio tracks (first is English AC3 and second is non-English DTS) then I see on the TV 2 tracks: first is non-English "MPEG" (2.1) and second is non-English in AAC(5.1). So English audio is lost :)

P.S. Thank you for your work and the result which I have already, I like very much! :)

@AlexPresso
Copy link

None of these vanilla patch will work in your case (I mean without editing them), because they're only patching VideoStation. I suppose the reason why it works on your TV DarkNebular, is because it can directly decode the codecs without transcoding, when using DLNA on a Samsung Smart TV, I'm unable to play videos having DTS audio.

In my opinion, the best way would be to make another patch only for the DLNA server's ffmpeg, but the reason I haven't done one for now is because I needed to check if the DLNA protocol is actually using the ffmpeg in the Media Server app or if it is only sending the file chunks to the TV and the TV decodes / transcodes it herself

@SoZee
Copy link

SoZee commented Aug 16, 2022

Hello,

I have try to install your script with the "manual installation" but this method fail.
And i have read comments, and wahhh... The patcher done the job so easely.

Thank you very much!

To help with the "compatibility" here is my information:

Synology RS815+ (INTEL Atom C2538)
DSM 7.0.1-42218 Update 4
Video Station version 3.0.2-2072
Media Server 2.0.1-3041
Advanced Media Extensions version 1.1.1-0202
FFMPEG version 4.4.2-44

(Up-to-date for OS/all packet).

@darknebular
Copy link

darknebular commented Aug 16, 2022

@darknebular hello again! Today I tried your wrapper. I have DSM 7.1, newest MediaServer package, newest VideoStation package, newest Advanced Media Extensions, and ffmpeg 4.4.2-44 from SynoCommunity. I've enabled transcoding in MediaServer as you shown.

What is the result? 1)Files with DTS track are playable in the VideoStation through the browser and I hear it, but when I send them to the TV over DLNA my TV says "audiotrack is not supported" (and that's correct, my TV doesn't accept DTS so I need transcoding for audio). 2)When I try to access them from internal TV's DLNA player, DTS track is not visible/accessible, and one of my files is "unrecognized".

Here is content of my CodecPack and VideoStation directories: image Maybe I should copy "patched" libsynovte.so from VideoStation to MediaServer dir to fix p.2?

Answering my question. Yes. I made actions 5-8 from your list to patch the file libsynovte.so but in /var/packages/MediaServer/target/lib/ directory and now my TV is playing movie with DTS with its internal player!!!

Here one thing which I noticed and maybe you know how to improve it: if movie has 2 audio tracks (first is English AC3 and second is non-English DTS) then I see on the TV 2 tracks: first is non-English "MPEG" (2.1) and second is non-English in AAC(5.1). So English audio is lost :)

P.S. Thank you for your work and the result which I have already, I like very much! :)

### I'm glad it finally worked for you.

Only take the first audio or the default one (In your case should be the English track) and converts it to MP3 2.0 and AAC 5.1. You must to have 2 audio streams from the same English track.
The first stream is MP3 2.0 (because Chromecast only accept 2.0 and 1 track) and the other audio stream only visible in players with multi audio support you will see another stream AAC 5.1.

Best regards.

@darknebular
Copy link

darknebular commented Aug 16, 2022

@akvamassa

Thanks to you, I write all steps in the manual installation manual. I forget the DLNA steps:

These 13 steps are ALL steps neccesary in order to have DTS, EAC3, TrueHD in VideoStation and DLNA:

Wrapper_VideoStation for ffmpeg-wrapper and for DLNA Media Server. Standard version:

Synology VideoStation ffmpeg wrapper with DTS, EAC3 and TrueHD support. It enables hardware transcoding from Synology´s ffmpeg for video and transcoding DTS, HEVC, EAC3, AAC, True HD from the ffmpeg of the SynoCommunity. When you use this SynoCommunity´s ffmpeg, you will have AAC 5.1 512kbps Surround and another audio track 2.0 MP3 Stereo for Chromecast or GoogleTV or other clients that don´t accept 5.1 AAC.

Works fine the OffLine transcoding and the streaming of tipical extensions like: MKV, MP4, AVI ...

This wrapper is a fork of BenjaminPoncet rev.12 with a few changes, fixes and some improvements in his code.


For DSM 7.1: (VERSION 12.3.3 NOW WITH 5.1 AAC and Multi Audio Streams)

INSTALL: Wrapper for Advance Codec Pack 2.0.X installed with ffmpeg41-wrapper-DSM7_1-12.3.3 file


With this wrapper (ffmpeg41-wrapper_DSM7_1-12.3.3 file) you will be with the original Synology´s ffmpeg almost time and only you will use the ffmpeg 4.4.2-44 when is 100% necessary. You will need Putty or other SSH Client in order to connect.

  1. cd /var/packages/CodecPack/target/pack/bin

  2. sudo mv /var/packages/CodecPack/target/pack/bin/ffmpeg41 /var/packages/CodecPack/target/pack/bin/ffmpeg41.orig

You must select 3.a or 3.b steps:

3.a) sudo vi ffmpeg41

----Push "i" key and then PASTE (right-click) the content of the file called ffmpeg41-wrapper-DSM7_1-12.3.3

----"ESC" key and then write :wq

(Or you can do this if you don´t want to use VI command:)

3.b) sudo touch ffmpeg41 | sudo wget https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/ffmpeg41-wrapper-DSM7_1-12.3.3 -O /var/packages/CodecPack/target/pack/bin/ffmpeg41

  1. sudo chmod 755 /var/packages/CodecPack/target/pack/bin/ffmpeg41

Save VideoStation's libsynovte.so and DLNA Media server´s libsynovte.so

  1. sudo cp -n /var/packages/VideoStation/target/lib/libsynovte.so /var/packages/VideoStation/target/lib/libsynovte.so.orig

  2. sudo chown VideoStation:VideoStation /var/packages/VideoStation/target/lib/libsynovte.so.orig

  3. sudo cp -n /var/packages/MediaServer/target/lib/libsynovte.so /var/packages/MediaServer/target/lib/libsynovte.so.orig

  4. sudo chown MediaServer:MediaServer /var/packages/MediaServer/target/lib/libsynovte.so.orig

  5. sudo chmod 644 libsynovte.so.orig

Patch libsynovte.so to authorize DTS, EAC3 and TrueHD

  1. sudo sed -i -e 's/eac3/3cae/' -e 's/dts/std/' -e 's/truehd/dheurt/' /var/packages/VideoStation/target/lib/libsynovte.so

  2. sudo sed -i -e 's/eac3/3cae/' -e 's/dts/std/' -e 's/truehd/dheurt/' /var/packages/MediaServer/target/lib/libsynovte.so

  3. sudo synopkg restart VideoStation

  4. ¡¡¡¡¡ENJOY!!!!!

The link to the last wrapper is: https://github.com/darknebular/Wrapper_VideoStation/blob/main/ffmpeg41-wrapper-DSM7_1-12.3.3

@darknebular
Copy link

I suppose the reason why it works on your TV DarkNebular, is because it can directly decode the codecs without transcoding,

The reason why it works on my TV is because my wrapper works on DLNA and my TV need transcoding for eac3 and DTS.
Stop mentioning me or my wrapper.

Please, spend your time checking system files and making another noob´s wrapper for DLNA that does logging, the mine is working fine.

Thanks.

@Godtux
Copy link

Godtux commented Aug 16, 2022

Hello

I used @darknebular patch on top of what i did previously.
I now have sound with an EAC3 encoded film, thanks !

Some remarks :
During install 3b failed because ffmpeg41 was missing (i used touch to create it, then ok)
I can not see a difference between line 10 and 11 ?

@darknebular
Copy link

darknebular commented Aug 16, 2022

@Godtux I am glad you have EAC3 working fine now.
Yes, you are right, 3.b step will fail if there isn't ffmpeg41 file.
10 and 11 Steps are differents.

Just added the correct command in the 3.b step:
sudo touch ffmpeg41 | sudo wget https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/ffmpeg41-wrapper-DSM7_1-12.3.3 -O /var/packages/CodecPack/target/pack/bin/ffmpeg41

Thanks guy. ;-)

Best regards.

@darknebular
Copy link

darknebular commented Aug 16, 2022

@akvamassa Well, the wrapper takes the first audio track or the default one. If there is another audio track in the movie using DTS, EAC3 or TrueHD It will doing as commented.

I suggest to you to use: MKVToolNix GUI

Then, open your .mkv and delete the non-english tracks or try with selecting English 5.1 AC3 and mark this audio track as DEFAULT and first one.

I hope this helps you.

Best regards.

@akvamassa
Copy link

@darknebular, thanks for clarification - in my case it works as you described.
I don't know which possibilities we have with ffmpeg, but maybe you know. Is it possible to "forward" all tracks to the TV, and to decode just DTS into stereo/5.1? Then noone will need to edit movie files. Or this behavior is handled by Synology Media Server and here is no chance to improve logic by your wrapper?

@darknebular
Copy link

@darknebular, thanks for clarification - in my case it works as you described. I don't know which possibilities we have with ffmpeg, but maybe you know. Is it possible to "forward" all tracks to the TV, and to decode just DTS into stereo/5.1? Then noone will need to edit movie files. Or this behavior is handled by Synology Media Server and here is no chance to improve logic by your wrapper?

Hello, It´s possible to take all tracks with the wrapper, but I will need to improve it a little. I didn´t it because It´s a waste of resources. When the wrapper take the default or first one track, It do 1) 2.0 MP3 and 2) AAC 5.1.

Can you try to change the order and default audio track in MKVToolNix?

Best regards.

@darknebular
Copy link

image

@AlexPresso
Copy link

If someone is interested, here is :

another noob´s wrapper for DLNA
— Darknebullar

https://github.com/AlexPresso/MediaServer-ffmpeg-patcher

Haven't tested the audio track selection, feel free to open an issue if it doesn't work.

@darknebular
Copy link

darknebular commented Aug 19, 2022

If someone is interested, here is :

another noob´s wrapper for DLNA
— Darknebullar

https://github.com/AlexPresso/MediaServer-ffmpeg-patcher

Haven't tested the audio track selection, feel free to open an issue if it doesn't work.

Oh, your deep investigations incoming... You told us that It´s not possible with DLNA and you will need create another noob´s script...
Great that you copy the solution while you are doing awesomes things...

The GPU accelerated support of your wrapper is not 100%, champion!!! You only have 100% of the Syno´s GPU using the native ffmpeg.
CHAMPION!!!!

@darknebular
Copy link

@AlexPresso

Stop mentioning me or my wrapper. ASSHOLE!!!

@darknebular
Copy link

darknebular commented Aug 19, 2022

  1. You copied my script version 12.1 and don´t mentions to me. Nowadays you have a wrapper that only logging and derives all files to the Community´s ffmpeg.
  2. you insulted to me and menospreciate my work
  3. I did these modification in order to have DLNA transcoding in the past (December 2021), I don´t publish here because I fraid that you copy my work. You was "working" in another "awesome" DLNA patch months ago without results (until now)...
  4. You told us that with this "traditional wrappers" is impossible to have working transcoding in DLNA and now you did the same, patch the libsynovte.so of MediaServer...
  5. You told us that My TV is working because I don´t need transcoding, when my TV really is needing the transcoding for DTS and EAC3.
  6. You told us that my wrapper doesn´t run in other platforms. The reality is: It´s working fine in: DS120J, DS214play, DS216, DS218+,DS918+, DS420, DS920+...
  7. How do you handle the Gstream wrapper? Will you finish it in a year?

All of your comments and you are fakes.

@KidWar75
Copy link

@AlexPresso

Stop mentioning me or my wrapper. ASSHOLE!!!

Just so you know, you have been reported.

@darknebular
Copy link

darknebular commented Aug 19, 2022

REVIEW of WRAPPERS###

Possibility of override parameters:

  1. With DarkNebular´s wrappers you will have full control and you can modify each parameter in the same wrapper.
  2. With Alex´s wrapper you can´t do it, the parameters are sending by default and can´t modify anything.

System´s resources using wrapper and same machine:

  1. With DarkNebular´s wrapper transcoding a movie:
    image

  2. With Alex´s wrapper transcoding the same movie:
    image

This is because the native Syno´s ffmpeg has 100% full hardware acceleration and use really the full GPU, with the community´s ffmpeg you only have 80-90% of hardware acceleration really (all acceleration commands supported but It´s another history, really derives to the CPU around 10-20% of some accelerations commands or mathematical calculations). With DarkNebular´s wrapper you will be using the native ffmpeg one and only you will are using Community´s ffmpeg in audio track and only when is neccesary.

Offline transcoding:

  1. with DarkNebular´s wrapper: (Original quality and audio track by default)
    image

  2. with Alex´s wrapper: (Original quality and audio track by default)
    image

When is necessary do transcoding what happens with multi tracks movies:

  1. When is neccesary transcode the audio track, the DarkNebular´s wrapper takes this track (first or default one is showed) and send two streams of the same track: a. 256Kbps MP3 2.0 and b. 512kbps AAC 5.1. It´s a lot better than using the default transcoding profiles and you only can do this doing override in the same wrapper. DON´T NEED to change another system file like: /var/packages/VideoStation/target/etc/TransProfiles

  2. Using the Alex´s wrapper you will have only 1 audio stream per track MP3 96kbps 2.0 (90% time) or 128 kbps 2.0 (10% time). If you want to change this you will NEED TO MODIFY ANOTHER system file located in: /var/packages/VideoStation/target/etc/TransProfiles
    With the Alex´s wrapper you NEVER WILL HAVE 5.1.

You choose... Both of them are working fine, both have PROS and CONS... It´s your deccision...

Regards.

@darknebular
Copy link

darknebular commented Aug 19, 2022

@AlexPresso
Stop mentioning me or my wrapper. ASSHOLE!!!

Just so you know, you have been reported.

Go kiss the ass of your little friend named Alex.

Just so you know, you have been blocked "por llorica".

@darknebular
Copy link

darknebular commented Aug 19, 2022

@akvamassa

I check it out, with my wrapper it will select the first or default audio track, BUT you can select the audio track that you need in DS Video mobile and VideoStation using a Browser, for example, you can select Spanish or English audio track, look:
image
image
image

When you select one of them, if this track need to be transcoded, my wrapper will generates two audio streams: a. 256 kbps 2.0 MP3 and b. 512kbps 5.1 AAC. When you are using a player with multi audio stream support you will be seeing 2 audio tracks (streams) from the SAME audio track that you selected before, look:
image
image

NOTE: As you can see, there are 3 "tracks", first #1 It´s the video, the "tracks" #2 and #3 are the two audio streams (#2 is the 2.0 MP3 "1" and #3 is 5.1 AAC "2")....if you see this image you will understand:

image

"Pista de audio #2" is the second audio stream from the track selected before (AAC 512kbps 5.1, not the other language audio track) and is was present like #3 track in the info panel, remember that #1 always is the video...

Now, you must can select the audio track (English one) or that you want, and then you will be receive 2 audio stream from the same audio track selected.

Best regards.

@SoZee
Copy link

SoZee commented Aug 19, 2022

@akvamassa

Thanks to you, I write all steps in the manual installation manual. I forget the DLNA steps:

These 13 steps are ALL steps neccesary in order to have DTS, EAC3, TrueHD in VideoStation and DLNA:

Wrapper_VideoStation for ffmpeg-wrapper and for DLNA Media Server. Standard version:

Synology VideoStation ffmpeg wrapper with DTS, EAC3 and TrueHD support. It enables hardware transcoding from Synology´s ffmpeg for video and transcoding DTS, HEVC, EAC3, AAC, True HD from the ffmpeg of the SynoCommunity. When you use this SynoCommunity´s ffmpeg, you will have AAC 5.1 512kbps Surround and another audio track 2.0 MP3 Stereo for Chromecast or GoogleTV or other clients that don´t accept 5.1 AAC.

Works fine the OffLine transcoding and the streaming of tipical extensions like: MKV, MP4, AVI ...

This wrapper is a fork of BenjaminPoncet rev.12 with a few changes, fixes and some improvements in his code.

For DSM 7.1: (VERSION 12.3.3 NOW WITH 5.1 AAC and Multi Audio Track)

INSTALL: Wrapper for Advance Codec Pack 2.0.X installed with ffmpeg41-wrapper-DSM7_1 file

With this wrapper (ffmpeg41-wrapper_DSM7_1 file) you will be with the original Synology´s ffmpeg almost time and only you will use the ffmpeg 4.4.2-44 when is 100% necessary. You will need Putty or other SSH Client in order to connect.

  1. cd /var/packages/CodecPack/target/pack/bin
  2. sudo mv /var/packages/CodecPack/target/pack/bin/ffmpeg41 /var/packages/CodecPack/target/pack/bin/ffmpeg41.orig

You must select 3.a or 3.b steps:

3.a) sudo vi ffmpeg41

----Push "i" key and then PASTE (right-click) the content of the file called ffmpeg41-wrapper-DSM7_1

----"ESC" key and then write :wq

(Or you can do this if you don´t want to use VI command:)

3.b) sudo touch ffmpeg41 | sudo wget https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/ffmpeg41-wrapper-DSM7_1 -O /var/packages/CodecPack/target/pack/bin/ffmpeg41

  1. sudo chmod 755 /var/packages/CodecPack/target/pack/bin/ffmpeg41

Save VideoStation's libsynovte.so and DLNA Media server´s libsynovte.so

  1. sudo cp -n /var/packages/VideoStation/target/lib/libsynovte.so /var/packages/VideoStation/target/lib/libsynovte.so.orig
  2. sudo chown VideoStation:VideoStation /var/packages/VideoStation/target/lib/libsynovte.so.orig
  3. sudo cp -n /var/packages/MediaServer/target/lib/libsynovte.so /var/packages/MediaServer/target/lib/libsynovte.so.orig
  4. sudo chown MediaServer:MediaServer /var/packages/MediaServer/target/lib/libsynovte.so.orig
  5. sudo chmod 644 libsynovte.so.orig

Patch libsynovte.so to authorize DTS, EAC3 and TrueHD

  1. sudo sed -i -e 's/eac3/3cae/' -e 's/dts/std/' -e 's/truehd/dheurt/' /var/packages/VideoStation/target/lib/libsynovte.so
  2. sudo sed -i -e 's/eac3/3cae/' -e 's/dts/std/' -e 's/truehd/dheurt/' /var/packages/MediaServer/target/lib/libsynovte.so
  3. sudo synopkg restart VideoStation
  4. ¡¡¡¡¡ENJOY!!!!!

The link to the last wrapper is: https://github.com/darknebular/Wrapper_VideoStation/blob/main/ffmpeg41-wrapper-DSM7_1

Hello,

It's possible to script that for easy deploy? :-)
With uninstall and reinstall properly?

Thank you. Bye.

@darknebular
Copy link

darknebular commented Aug 21, 2022

@akvamassa
I know now what is your problem. Your TV hasn´t got support for multi audio stream, due to this when you choose another track you really are selecting another track not another audio stream from the SAME track.

The first audio stream must be MP3 2.0 for compatibility for Chromecast and some Browsers that only accepts 2.0.

Well, knowing now your problem with your TV, you have two ways in order to have 5.1 via DLNA:

  1. Modify the ffmpeg in the media server folder (ask me and I help to you to have always 5.1 via DLNA and 2.0-5.1 in VideoStation)
  2. If you haven´t got chromecast, you can modify the order of the codecs in my actual wrapper (ask me and I will tell to you the lines that you must change for having always AAC 5.1 via DLNA and VideoStation) (remember that with this solution you will have problems with some browsers and Chromecast)

Please tell me what solution will you need and I post the step and I will help to you.
Look, when you have a TV with Multi audio Stream support you will have two audio modes (2.0 MP3 256kbps and second 5.1 AAC 512kbps) from the SAME audio track (SPANISH ONE in this example). The audio dual change the language audio track not the audio stream:
image
image
image

In this case, via DLNA, in order to consume less system´s resources the wrapper will send via DLNA the first or default audio track, only ONE track and TWO audio Modes (2 audio streams from the same language audio track), due to this via DLNA you will not be able to change language track if It is needed to be transcoded. Due to this I suggested to you use MKVToolNix APP for change the default language audio track.

Best regards.

@darknebular
Copy link

It's possible to script that for easy deploy? :-)

The steps are Copy-Paste, I think they are easy commands. What is exactly your problem with them?
Perhaps I will do a installation script in the future.

Regards.

@darknebular
Copy link

I changed the name of the files on my repository, I updated these name changes in the installation steps:

Wrapper_VideoStation for ffmpeg-wrapper and for DLNA Media Server. Standard version:

Synology VideoStation ffmpeg wrapper with DTS, EAC3 and TrueHD support. It enables hardware transcoding from Synology´s ffmpeg for video and transcoding DTS, HEVC, EAC3, AAC, True HD from the ffmpeg of the SynoCommunity. When you use this SynoCommunity´s ffmpeg, you will have AAC 5.1 512kbps Surround and another audio track 2.0 MP3 Stereo for Chromecast or GoogleTV or other clients that don´t accept 5.1 AAC.

Works fine the OffLine transcoding and the streaming of tipical extensions like: MKV, MP4, AVI ...

This wrapper is a fork of BenjaminPoncet rev.12 with a few changes, fixes and some improvements in his code.


For DSM 7.1: (VERSION 12.3.3 NOW WITH 5.1 AAC and Multi Audio Streams)

INSTALL: Wrapper for Advance Codec Pack 2.0.X installed with ffmpeg41-wrapper-DSM7_1-12.3.3 file


With this wrapper (ffmpeg41-wrapper_DSM7_1-12.3.3 file) you will be with the original Synology´s ffmpeg almost time and only you will use the ffmpeg 4.4.2-XX when is 100% necessary. You will need Putty or other SSH Client in order to connect.

  1. cd /var/packages/CodecPack/target/pack/bin

  2. sudo mv /var/packages/CodecPack/target/pack/bin/ffmpeg41 /var/packages/CodecPack/target/pack/bin/ffmpeg41.orig

You must select 3.a or 3.b steps:

3.a) sudo vi ffmpeg41

----Push "i" key and then PASTE (right-click) the content of the file called ffmpeg41-wrapper-DSM7_1-12.3.3

----"ESC" key and then write :wq

(Or you can do this if you don´t want to use VI command:)

3.b) sudo touch ffmpeg41 | sudo wget https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/ffmpeg41-wrapper-DSM7_1-12.3.3 -O /var/packages/CodecPack/target/pack/bin/ffmpeg41

  1. sudo chmod 755 /var/packages/CodecPack/target/pack/bin/ffmpeg41

Save VideoStation's libsynovte.so and DLNA Media server´s libsynovte.so

  1. sudo cp -n /var/packages/VideoStation/target/lib/libsynovte.so /var/packages/VideoStation/target/lib/libsynovte.so.orig

  2. sudo chown VideoStation:VideoStation /var/packages/VideoStation/target/lib/libsynovte.so.orig

  3. sudo cp -n /var/packages/MediaServer/target/lib/libsynovte.so /var/packages/MediaServer/target/lib/libsynovte.so.orig

  4. sudo chown MediaServer:MediaServer /var/packages/MediaServer/target/lib/libsynovte.so.orig

  5. sudo chmod 644 libsynovte.so.orig

Patch libsynovte.so to authorize DTS, EAC3 and TrueHD

  1. sudo sed -i -e 's/eac3/3cae/' -e 's/dts/std/' -e 's/truehd/dheurt/' /var/packages/VideoStation/target/lib/libsynovte.so

  2. sudo sed -i -e 's/eac3/3cae/' -e 's/dts/std/' -e 's/truehd/dheurt/' /var/packages/MediaServer/target/lib/libsynovte.so

  3. sudo synopkg restart VideoStation

  4. ¡¡¡¡¡ENJOY!!!!!

The link to the last wrapper is: https://github.com/darknebular/Wrapper_VideoStation/blob/main/ffmpeg41-wrapper-DSM7_1-12.3.3

@darknebular
Copy link

darknebular commented Aug 25, 2022

@SoZee
I just finish a installer. It´s the first version 1.0 of the automatic installer.
Please, uninstall the old wrapper and try with this:

bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/testing_news.sh")"

Best regards.

@darknebular
Copy link

darknebular commented Aug 25, 2022

AUTOMATIC INSTALL SCRIPT 1.0 FOR VideoStation and MediaServer using my wrapper with 5.1 support.

https://github.com/darknebular/Wrapper_VideoStation

The installer is funtional but It´s a beta, I need to improve a little bit the code.

Best regards my friends.

@darknebular
Copy link

darknebular commented Aug 26, 2022

VideoStation and DLNA MediaServer FFMPEG-Wrapper, now with Installer and Codecs CONFIGURATOR:

  • Connect to your NAS using SSH (admin user required) (help)
  • Use the command sudo -i to switch to root user
  • Enter your admin password in the sudo -i command

Usage

Basic command:
bash <(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")

You directly can install or uninstall putting this flag in the command:

bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s install

bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s uninstall

If you have already installed the wrapper you can directly go to configure the order of the audio´s streams doing this:

bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s config

You will can change the order of the audio codecs in the wrapper, install the most advanced wrapper with 5.1 or the simplest one (using option C in config-menu), patch DLNA MediaServer and VideoStation, all in the SAME SCRIPT.

https://github.com/darknebular/Wrapper_VideoStation

ENJOY!!!!!

BEST REGARDS MY FRIENDS.

@darknebular
Copy link

darknebular commented Aug 26, 2022

In the next release I will do the ideal config:

Using DLNA you will have 5.1 and 2.0
Using VideoStation and not lost the compatibility with Chromecast or some Browsers let the default order: 2.0 and 5.1

With this config, if you have clients using google TV, Browsers, Chromecast etc. They will can hear the movies and you, with your Hi-Fi system will have 5.1 via DLNA.

Best regards.

@darknebular
Copy link

darknebular commented Aug 26, 2022

Just FINISH The Script version 1.6 doing this special configuration. NOW YOU WILL HAVE:

When the Wrapper needs to transcoding you will have 2 audio´s streams from the SAME track:
**

  • In MediaServer DLNA = [1) AAC 5.1 512kbps AND 2) MP3 2.0 256kbps.]
  • In VIDEO-STATION = [1) MP3 2.0 256kbp AND 2) AAC 5.1 512kbps.]**

(For Chromecast or GoogleTV or other clients that don´t accept 5.1 AAC neigther multi audio´s stream support, the MP3 2.0 is the first audio stream in VIDEO-STATION).
Enter: sudo -i

Enter: bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s install

Check it out.

BEST REGARDS.

@darknebular
Copy link

darknebular commented Aug 26, 2022

@akvamassa
@Godtux
@findstevehere
Your solution for DLNA and no need to change in your TV the track for enable 5.1 is in the last comment.

Regards.

@darknebular
Copy link

darknebular commented Aug 27, 2022

Launched The Installer´s Script version 1.8.

@Gideon75
Copy link

Fantastic work!
Simple, automatic, ignorant proof

@darknebular
Copy link

darknebular commented Aug 28, 2022

Thanks!!

If you like it, give me a start.
Now, enjoy it!!
XD

@darknebular
Copy link

darknebular commented Aug 29, 2022

JUST FINISH The Installer´s Script version 1.8.

Fully tested, fully stable, fully configurable using the Advanced Wrapper.

NOW YOU WILL HAVE:

  • In MediaServer DLNA = [1) AAC 5.1 512kbps AND 2) MP3 2.0 256kbps.] (by default)
  • In VIDEO-STATION = [1) MP3 2.0 256kbp AND 2) AAC 5.1 512kbps.] (by default)
  • You now can change the 5.1 audio´s codec from AAC 512kbps to AC3 640kbps independently of its audio´s streams order in VIDEO-STATION and DLNA MediaServer using the configurator tool embedded into the installer.sh. (AC3 is more compatible with legacy 5.1 devices).

ADD-ONs FROM 1.7:

  • Improvements in Universal uninstaller of olds or other wrappers of internet during installation for ensure a fresh and clean installation.
  • Tested and working fine in a lot of Synology´s models.
  • Ensuring that the Configurator Tool doesn´t modify any system file or other wrapper except the Advanced Wrapper itself.
  • Check if the user is using root account.
  • Added the possibility that someone change TransProfiles in VideoStation.
  • Fixed a bucle in old Uninstall process.

Check It out:
Connect using SSH and then:

Enter:
sudo -i

And then:

INSTALL / UNINSTALL:

Enter:
bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s install

Or (for uninstall it...)

Enter:
bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s uninstall

CONFIGURATOR TOOL:

Enter:
bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s config

https://github.com/darknebular/Wrapper_VideoStation

Please give a star in my repository if you like my wrapper. Thanks...

BEST REGARDS.

@patgit78
Copy link

a possibility to work with DSM 7.1.1 ?
just modifiy your script to use it with this version ? or there is some issues with this version ?

@KipiKland
Copy link

KipiKland commented Aug 29, 2022 via email

@patgit78
Copy link

Installed that script yesterday on last DSM 7 version and worked flawlessly

On 29 Aug 2022, at 17:34, patgit78 @.> wrote: @. commented on this gist. a possibility to work with DSM 7.1.1 ? just modifiy your script to use it with this version ? or there is some issues with this version ? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.

doesn't works with 7.1.1 RC
the script check the version of DSM and working with 7.0 and 7.1 but not with 7.1.1
th last official version is 7.1

@AlexPresso
Copy link

That's because he stupidly copied most of my code and hasn't noticed I only check for > 7.1 versions and do not check for subversions. Meh.

@KidWar75
Copy link

That's because he stupidly copied most of my code and hasn't noticed I only check for > 7.1 versions and do not check for subversions. Meh.

lol, I can't verify this, but if what you tell is the truth, this is just the cherry on top of the cake... :')
But don't forget @AlexPresso, you're the asshole that took his code and didn't mention him...

@AlexPresso
Copy link

Ahaha

@patgit78
Copy link

so i have an issue
my codec pack is : /var/packages/CodecPack/target/bin
and the script looking for : /var/packages/CodecPack/target/pack/bin

DSM 7.1.1 RC
VS 3.0.3-2084
FFMPEG 4.4.2-44

@AlexPresso
Copy link

AlexPresso commented Aug 29, 2022

you won't have that issue using my script, I check for the /pack/bin path to exists instead of using the DSM version

@darknebular
Copy link

darknebular commented Aug 29, 2022

a possibility to work with DSM 7.1.1 ?

I will check it out.

Regards.

@darknebular
Copy link

That's because he stupidly copied most of my code and hasn't noticed I only check for > 7.1 versions and do not check for subversions. Meh.

Your stupid code doesn´t show all dependencies in one time.

@darknebular
Copy link

darknebular commented Aug 29, 2022

That's because he stupidly copied most of my code and hasn't noticed I only check for > 7.1 versions and do not check for subversions. Meh.

lol, I can't verify this, but if what you tell is the truth, this is just the cherry on top of the cake... :') But don't forget @AlexPresso, you're the asshole that took his code and didn't mention him...

Enjoy with MP3 2.0 128KBPS.

@darknebular
Copy link

you won't have that issue using my script, I check for the /pack/bin path to exists instead of using the DSM version

Your script doesn´t do this:
image

@darknebular
Copy link

darknebular commented Aug 29, 2022

so i have an issue my codec pack is : /var/packages/CodecPack/target/bin and the script looking for : /var/packages/CodecPack/target/pack/bin

DSM 7.1.1 RC VS 3.0.3-2084 FFMPEG 4.4.2-44

Please, can you enter this command in this path:??
cd /var/packages/CodecPack/target/bin/
ls -la

Thanks.

@darknebular
Copy link

darknebular commented Aug 29, 2022

That's because he stupidly copied most of my code and hasn't noticed I only check for > 7.1 versions and do not check for subversions. Meh.

You only know menospreciate the work of others...
I did in 5 days more than you in 18 months...

Your "awesome" script doesn't control anything. If you do a install and then repeat, your script will be doing a installation again.
It will work in 7.1.1 like a champ as with 7.0 and 7.1

Your wrapper can be configurable?
Your script has a configuration tool?

I don't know why @BenjaminPoncet mantain the links to yours repositories when you project is a new one and NOT a fork from Benjamin really...

@darknebular
Copy link

darknebular commented Aug 29, 2022

That's because he stupidly copied most of my code and hasn't noticed I only check for > 7.1 versions and do not check for subversions. Meh.

lol, I can't verify this, but if what you tell is the truth, this is just the cherry on top of the cake... :') But don't forget @AlexPresso, you're the asshole that took his code and didn't mention him...

Yeah, I spent a lot of hours troubleshooting the Benjamin's code.
I fix the offline transcodifications.
I change the order of the use of the binaries, looks like trivial but It's the key for fixing a anothers things.
I fix the thumbnails empty in VS.
I fix a problem with the logging too.

I would like that Alex had mentioned to me.
But blablabla...

Now, please enjoy with his wrapper without any possibility to change nothing and have 2.0 128 kbps,

Now, I did a script with a ingnorants proof, you can't install the wrapper, right troll??

@darknebular
Copy link

@AlexPresso
Now, you have near 700 lines of code in mi script for ...

@AlexPresso
Copy link

hm

@darknebular
Copy link

you won't have that issue using my script, I check for the /pack/bin path to exists instead of using the DSM version

I did this because:

  • In 7.1 has these two paths:
    -1)/var/packages/CodecPack/target/bin
    -2)/var/packages/CodecPack/target/pack/bin

Both exists. But in 7.1 the path /var/packages/CodecPack/target/bin doesn't contains the binaries really, only links.

My wrapper don't derive all parameters like yours and needs a consistency of the locations of the binaries.

Insists, I don't know why @BenjaminPoncet is linking to your wrapper when this is a new one and not a, fork from him...

@darknebular
Copy link

hm
JEJEJEJE

Thanks my troll!!!

@KidWar75
Copy link

Jesus christ, what a toxic kid...

@darknebular
Copy link

Jesus christ, what a toxic kid...

Other troll...

@findstevehere
Copy link

thanks for all your work, very much appreciated but.... always so difficult to actually get working through terminal commands etc....finally got the "remote host ID has changed" error to go away in Terminal and it looks like it it ran, but soooo many errors with commands and files not found, yet says at the end: Installation of the Advanced Wrapper: COMPLETE. I doubt it.... and no surprise VS doesnt play eac3 audio etc.

What is the actual installation process? I shut down VS but there is no way to stop ffmpeg from running... so how does it wrap and change while it's running? Does VS have to be unistalled and reintalled or something and how does one know this is actually patching?

get alot of this so not helpful:

"p: /var/packages/MediaServer/target/lib/libsynovte.so: No such file or directory
\u001b[32m[2022-08-29 23:32:46] \u001b[36mINFO: \u001b[33m\u001b[33mFixing permissions of /var/packages/MediaServer/target/lib/libsynovte.so.orig
chown: MediaServer: illegal group name
chmod: /var/packages/MediaServer/target/lib/libsynovte.so.orig: No such file or directory
\u001b[32m[2022-08-29 23:32:46] \u001b[36mINFO: \u001b[33m\u001b[33mPatching /var/packages/MediaServer/target/lib/libsynovte.so for compatibility with DTS, EAC3 and TrueHD
sed: -e: No such file or directo......"

thanks

@findstevehere
Copy link

everything missing huh?

==================== ¡¡¡¡¡ENJOY!!!!! ====================

\u001b[32m[2022-08-30 00:44:28] \u001b[31mERROR: \u001b[31mMISSING VideoStation Package.
\u001b[32m[2022-08-30 00:44:28] \u001b[31mERROR: \u001b[31mMISSING ffmpeg Package.
\u001b[32m[2022-08-30 00:44:28] \u001b[31mERROR: \u001b[31mMISSING CodecPack Package.
\u001b[32m[2022-08-30 00:44:28] \u001b[31mERROR: \u001b[31mMISSING MediaServer Package.

@AlexPresso
Copy link

AlexPresso commented Aug 30, 2022

It also makes no sense of having to install MediaServer if you only want to patch VideoStation...

@patgit78
Copy link

cd /var/packages/CodecPack/target/bin/
ls -la

root@diskstation:/var/packages/CodecPack/target/bin# ls -la
total 324
drwxr-xr-x 1 CodecPack CodecPack 154 Aug 29 18:44 .
drwxr-xr-x 1 CodecPack CodecPack 58 Jul 5 12:35 ..
lrwxrwxrwx 1 CodecPack CodecPack 30 Jun 27 08:59 ffmpeg33-for-audio -> ../pack/bin/ffmpeg33-for-audio
lrwxrwxrwx 1 CodecPack CodecPack 37 Jun 27 08:59 ffmpeg33-for-surveillance -> ../pack/bin/ffmpeg33-for-surveillance
-rwxr-xr-x 1 root root 263016 Aug 29 18:44 ffmpeg41
-rwxr-xr-x 1 root root 11380 Aug 29 18:42 ffmpeg41.orig
-rwxr-xr-x 1 CodecPack CodecPack 42105 Jun 27 08:59 synocodectool

@patgit78
Copy link

you won't have that issue using my script, I check for the /pack/bin path to exists instead of using the DSM version

it doesn't works with your script (no ffmpeg process when i'm trying to transcode a MKV)

same issue with darknebular script

@AlexPresso
Copy link

You need to reinstall VideoStation and Advanced Media Extensions to clean them before running the patch. Also there's a special case depending on your architecture where it won't work with any of the wrappers. The case is when AME uses Gstreamer with OMX and pipes the stream to ffmpeg. I'm working on it in a PR.

@patgit78
Copy link

forget to uninstall AME, but when i'm using your script, i'm getting a choice of audio channel, but when i'm select play, nothing is done

@AlexPresso
Copy link

Please open an issue on my repository with all infos so I can find out why it doesn't work. But I'm pretty sure it's because of Gstreamer that os not currently supported

@patgit78
Copy link

@darknebular

when i'm using your script the file : libsynovte.so is not patched !

install log :
Fixing permissions of /var/packages/VideoStation/target/lib/libsynovte.so.orig
[2022-08-30 11:31:05] INFO: Patching /var/packages/VideoStation/target/lib/libsynovte.so for compatibility with DTS, EAC3 and TrueHD
[2022-08-30 11:31:05] INFO: Modified correctly the file /var/packages/VideoStation/target/lib/libsynovte.so

files in directory :
-rw------- 1 VideoStation VideoStation 401915 Aug 30 11:31 libsynovte.so.orig
-rw-r--r-- 1 VideoStation VideoStation 401915 Aug 30 11:31 libsynovte.so
root@diskstation:/var/packages/VideoStation/target/lib# diff libsynovte.so libsynovte.so.orig
Binary files libsynovte.so and libsynovte.so.orig differ

@darknebular
Copy link

darknebular commented Aug 30, 2022

REVIEW of INSTALLERS###

Running:

  1. With DarkNebular´s Installer looks like cooler than the other installer:
    image

  2. With Alex´s installer, you have a boring process:
    image

What´s happen when you try to do a install again:

  1. With DarkNebular´s installer you can´t do a installation if you already have installed a wrapper. (This minimize the possibility of losing original binaries or miss configurations):
    image

  2. With Alex´s installer doesn´t check if you already have installed a wrapper. (This maximize the possibility of losing original binaries):
    image

Here we go again, without checking anything and without care...

Can you Configure the wrapper to use 5.1 or change the audio's codecs for the wrapper from AAC to AC3?:

  1. With DarkNebular´s installer you can change the Audio's streams order and the Audio's Codecs:
    image

  2. With Alex´s installer you can't change anything, ah yes, here we go again, re-installing...
    image

What´s happen when you try to do a uninstall again:

  1. With DarkNebular´s installer, if you haven't a wrapper installed, the installer STOP. (This minimize the possibility of losing original binaries):
    image

2)With Alex´s installer doesn´t check if you already have uninstalled a wrapper. (This maximize the possibility of losing original binaries):
image

Here we go again, without checking anything and without care...

What´s happen when you have installed ANOTHER OLD WRAPPER?:

  1. With DarkNebular´s installer, for ensuring a fresh and clean installation, It has a uninstaller old wrapper embedded into de installer.
    image

  2. With Alex´s installer is "HERE WE GO AGAIN GUYS" Without any care: (Fresh and clean install...What´s this?)
    image

How detailed is the installation process?:

  1. With DarkNebular´s installer is more detailed:
    image

  2. With Alex´s installer is meh:
    image

What´s happen when you try use the Configurator tool when you have another wrapper installed or no wrapper?:

  1. With DarkNebular´s installer will STOP for ensuring no touch anything of the system:
    image

  2. With Alex´s installer:
    image

What´s happen when you try running the script without being root user?:

  1. With DarkNebular´s installer tells you that you must be ROOT and STOP:
    image

  2. With Alex´s installer: (HERE WE GO GUYS AGAIN). It try to install without permissions... Without care
    image

Can you install other wrappers?:

  1. With DarkNebular´s installer permits to you install the Simplest one or the Advanced wrapper in the same installer.

  2. With Alex´s installer only permits install one.

What´s happen when you haven´t the dependencies packages installed?:

  1. With DarkNebular´s installer tells you at once time ALL the missing packages:
    image

  2. With Alex´s installer tells you only one item missing each time, needed to run the (HERE WE GO SCRIPT) n times:
    image

NOW, YOU CHOOSE INSTALLER.

Best regards.

@darknebular
Copy link

darknebular commented Aug 30, 2022

Please open an issue on my repository with all infos so I can find out why it doesn't work. But I'm pretty sure it's because of Gstreamer that os not currently supported

When you patch CodecPack's ffmpeg and not the VideoStation's one, you will have the video to Gstreamer and the audio to the ffmpeg from CodecPack.
If you patch VideoStation 's ffmpeg, you break this behaviour and doesn´t will work...

@darknebular
Copy link

VS but there is no way to stop ffmpeg from running..

You don´t need to stop anything. Thanks.
Only sudo-i
and launch the basic command.

Thanks.

@darknebular
Copy link

ls -la

the binaries really are in :/var/packages/CodecPack/target/PACK/bin

Please use the 1.9 version...

@KipiKland
Copy link

KipiKland commented Aug 30, 2022 via email

@darknebular
Copy link

darknebular commented Aug 30, 2022

I had to install media server to use the new script and since I am also using minim server I find this rather useless. However I love what you did for VS that script is so cool, any chance that you consider modifications for the ppl who don’t need DLNA from media server at all ? Thanks a lot for you work

On 30 Aug 2022, at 13:34, darknebular @.> wrote: @. commented on this gist. VS but there is no way to stop ffmpeg from running.. You don´t need to stop anything. Thanks. Only sudo-i and launch the basic command. Thanks. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.

OK, I will study this possibility...
It looks like easy to do. If you can wait few days I will change this requisite.

Thanks for the advice.

@darknebular
Copy link

JUST FINISH The Installer´s Script version 1.9.

Fully tested, fully stable, fully configurable using the Advanced Wrapper.

NOW YOU WILL HAVE:

  • In MediaServer DLNA = [1) AAC 5.1 512kbps AND 2) MP3 2.0 256kbps.] (by default)
  • In VIDEO-STATION = [1) MP3 2.0 256kbp AND 2) AAC 5.1 512kbps.] (by default)
  • You now can change the 5.1 audio´s codec from AAC 512kbps to AC3 640kbps independently of its audio´s streams order in VIDEO-STATION and DLNA MediaServer using the configurator tool embedded into the installer.sh. (AC3 is more compatible with legacy 5.1 devices).

ADD-ONs FROM 1.8:

  • Improvements in the dependecies function
  • Tested and working fine in a lot of Synology´s models.
  • Open the compatibility to future releases as 7.1.1 and above. (Inspired in a comment from Alex).

Check It out:
Connect using SSH and then:

Enter:
sudo -i

And then:

INSTALL / UNINSTALL:

Enter:
bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s install

Or (for uninstall it...)

Enter:
bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s uninstall

CONFIGURATOR TOOL:

Enter:
bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s config

https://github.com/darknebular/Wrapper_VideoStation

...

Please give a star in my repository if you like my wrapper. Thanks...

BEST REGARDS.

@patgit78
Copy link

Binary files libsynovte.so and libsynovte.so.orig differ

If It is not paching, Why they differ?

sorry no difference : files are same

@patgit78
Copy link

Just an info : libsynovte.so is a binary file and in your script you are doing SED command ?!

@AlexPresso
Copy link

Having them being the same size does't mean they are the same. Even in a binary a char (and a string) remains a string, you can literally "cat" the binary and use grep on it if you want.
Having them the same size is really important, otherwise it would move the pointers addresses and break the code flow.

That's why we use sed to rewrite some strings in and inverted order, it keeps the same byte size and pointers offsets

@patgit78
Copy link

libsynovte.so seems to be correctly patched.
if i'm using the ori file it tell me that the DTS channel cannot be supported and with the patched file i have not message but nothing it's played...
ps -ef don't show anyffmpeg process running

@AlexPresso
Copy link

Do you have a gstreamer binary in the CodecPack directory ?

@patgit78
Copy link

i found the issue
i do a manual copy of ffmpeg

cd /var/packages/VideoStation/target/bin/
cp /var/packages/ffmpeg/target/bin/ffmpeg .
chown root:VideoStation ffmpeg
chmod g+x ffmpeg

and it's working, i think there is an issue in the install script

@darknebular
Copy link

@patgit78
You run a modified script of mine?
My script NEVER will write /var/packages/CodecPack/target/bin
When It exists /var/packages/CodecPack/target/PACK/bin...

@patgit78
Copy link

no but it's working for me....

@darknebular
Copy link

Great...

Best regards.

@AlexPresso
Copy link

AlexPresso commented Aug 30, 2022

Oh by the way, haven't seen your comparison in the previous post, my bad, I blocked you long time ago and didn't have the notification.

About the possibility to lose original binaries, I don't need to check for it because the code was thought to work in any cases (and was also tested that way). Just try by yourself :).

Also, what you call the "simplest script" is a full copy of the one I made, you didn't even tried to hide it ahah, feel free to continue copying, I'm glad to know that even if you try your best to hide it, you secretly like my work ;)

@darknebular
Copy link

Salvo que a diferencia de ti, TE HE MENCIONADO.

Tú no lo hiciste!

Es la diferencia entre ser un "listo de la vida" y una persona educada.

@darknebular
Copy link

The ffmpeg binary of the DLNA send all to CodecPack...

Then, nowadays if you want to have 5.1 in DLNA you must to change the config en VideoStation too...

@darknebular
Copy link

darknebular commented Aug 30, 2022

I know that you don't modify the originals, but I prefer minimize odds...

  ## I prefer do a fresh and clean installation all times. YOU DON´T.
  ## I prefer can to change the audio codecs. YOU DON´T.
  ## I prefer check if my installer is running as root. YOU DON'T
  ## I prefer try to have 5.1 when It needs transcoding something and not conform with having 2.0 96kbps. YOU DON´T.
  ## I prefer that my script tells me all missing dependencies at once during installation process. YOU DON´T.
  ## I prefer not try to install something that It has been installed previously. YOU DON´T.
  ## I prefer not try to uninstall something that It has been uninstalled previously. YOU DON´T.
  ## I prefer have 9,999% of certain that my script don´t make something bad and you conform with only 99%.

We know that you are "the most clever" "the most smart" of this world.

I am trying to do the best, If you will be help you will be welcome, if not, please shut up.

@darknebular
Copy link

And yes, if you take the simplest you will see your nick there in comments...
I don't hide anything...

You didn't with my version 12.1...
This is because I am a polite man.

@darknebular
Copy link

I am investigating how have 5.1 in DLNA independent of VideoStation...

@darknebular
Copy link

I had to install media server to use the new script and since I am also using minim server I find this rather useless. However I love what you did for VS that script is so cool, any chance that you consider modifications for the ppl who don’t need DLNA from media server at all ? Thanks a lot for you work

@KipiKland

I did the SCPT_1.10 without the dependency of MediaServer DLNA.

@KipiKland
Copy link

Thank you very much ! i will test and advise, just to be sure:

  • i will:
  1. uninstall wrapper 1.9
  2. uninstall Media Server
  3. reinstall with latest wrapper 1.10
    correct ?

@darknebular
Copy link

darknebular commented Aug 31, 2022

Thank you very much ! i will test and advise, just to be sure:

  • i will:
  1. uninstall wrapper 1.9
  2. uninstall Media Server
  3. reinstall with latest wrapper 1.10
    correct ?

Don´t worry, my Script 1.10 during installation will be doing the uninstall of old wrappers installed.
And yes, if you want, please, now you can uninstall MediaServer without problems.

And now, you can view the possible errors during installation in /tmp/wrapper_ffmpeg.log.

The Configurator Tool will tell you that there are some options (DLNA´s ones) that you will not be able to change them.

@KipiKland
Copy link

so i gave it a try, uninstalled media server and launched script.
log shows:
root@KPNAS:/tmp# cat wrapper_ffmpeg.log
====================FFMPEG WRAPPER INSTALLER FOR DSM 7.0 and above by Dark Nebular.====================
[2022-08-31 14:22:31] INFO: ==================== Installation of the Advanced Wrapper: START ====================
[2022-08-31 14:23:16] INFO: ==================== Installation of the Advanced Wrapper: COMPLETE ====================

when i try to select (C) for config
Please, What option wish to use? C
[2022-08-31 14:15:12] INFO: Actually You HAVEN'T ANY WRAPPER INSTALLED and this codec Configurator CAN'T change anything.
[2022-08-31 14:15:12] INFO: Please, Install the Advanced Wrapper first and then you will can change the audio's streams order.

@darknebular
Copy link

darknebular commented Aug 31, 2022

Umm let me check it out. I did this change very quickly...
AGGGGG I forget a line...

@darknebular
Copy link

when i try to select (C) for config

wait, I can do it more elegant and show only the options than you need for the Configuration tool.
Enjoy the wrapper and wait a few in order to change this for the configurator tool. Can you wait?

Thanks in advance.

@darknebular
Copy link

when i try to select (C) for config

Please try again, Thanks for all!!!

@darknebular
Copy link

JUST FINISH The Installer´s Script version 1.10.

Fully tested, fully stable, fully configurable using the Advanced Wrapper.

NOW YOU WILL HAVE:

  • In MediaServer DLNA = [1) AAC 5.1 512kbps AND 2) MP3 2.0 256kbps.] (by default) (If exists) **
  • In VIDEO-STATION = [1) MP3 2.0 256kbp AND 2) AAC 5.1 512kbps.] (by default)
  • You now can change the 5.1 audio´s codec from AAC 512kbps to AC3* 640kbps independently of its audio´s streams order in VIDEO-STATION and DLNA MediaServer using the configurator tool embedded into the installer.sh.

*(AC3 is more compatible with legacy 5.1 devices).
**(Tried to make independent Media Server from Video Station ffmpeg.)

ADD-ONs FROM 1.9:

  • Now the Installer Script is independent of the existence of DLNA Media Server, DLNA MediaServer is a optional package.
  • Now You can see the installation logs and the Wrapper logs in: /tmp/wrapper_ffmpeg.log.
  • Tested and working fine in a lot of Synology´s models.

Check It out:
Connect using SSH and then:

Enter:
sudo -i

And then:

INSTALL / UNINSTALL:

Enter:
bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s install

Or (for uninstall it...)

Enter:
bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s uninstall

CONFIGURATOR TOOL:

Enter:
bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s config

https://github.com/darknebular/Wrapper_VideoStation

...

Please give a star in my repository if you like my wrapper. Thanks...

BEST REGARDS.

@darknebular
Copy link

darknebular commented Aug 31, 2022

@KipiKland
Can you send me a capture of the Configurator Tool menu?
In the log file, there isn't any installation error. Perfect.

Thanks for all.

@KipiKland
Copy link

KipiKland commented Aug 31, 2022

@darknebular : sure , did a retry and same issue:

[2022-08-31 16:21:33] INFO: Actually You HAVEN'T ANY WRAPPER INSTALLED and this codec Configurator CAN'T change anything.
[2022-08-31 16:21:33] INFO: Please, Install the Advanced Wrapper first and then you will can change the audio's streams order.

Then:

  • uninstalled & reinstalled AME
  • restarted with script install:
  • same issue:
    [2022-08-31 16:26:22] INFO: Actually You HAVEN'T ANY WRAPPER INSTALLED and this codec Configurator CAN'T change anything.

root@KPNAS:/tmp# cat wrapper_ffmpeg.log
[2022-08-31 16:25:24] INFO: ==================== Installation of the Advanced Wrapper: START ====================
[2022-08-31 16:26:16] INFO: ==================== Installation of the Advanced Wrapper: COMPLETE ====================

Then :

  • uninstalled AME / VIDEO STATION (keeping DB)
  • installed VS/AME
  • restarted with script install:

root@KPNAS:/tmp# rm wrapper_ffmpeg.log
root@KPNAS:/tmp# bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s install

image
image

still no luck,

[EDIT] config menu may not be accessible and msg wrong , but i was able to play HEVC + EAC3 file.
and the wrapper log here:

[2022-08-31 16:33:18] INFO: ==================== Installation of the Advanced Wrapper: START ====================
[2022-08-31 16:34:19] INFO: ==================== Installation of the Advanced Wrapper: COMPLETE ====================
2022-08-31 16:37:05 - FFM26849 - *** PROCESS START REV AME_12.3.3 DS920+ (geminilake) PID 26849 ***
2022-08-31 16:37:05 - FFM26849 - MOVIE = /volume1/video/Movies/Thriller/Death on the Nile (2022) Hybrid MULTi VFF 2160p 10bit 4KLight DOLBY VISION BluRay DDP 7.1 x265-QTZ.mkv
2022-08-31 16:37:05 - FFM26849 - VCODEC = hevc (Main 10)
2022-08-31 16:37:05 - FFM26849 - ACODEC = eac3
2022-08-31 16:37:05 - FFM26849 - PARAMVS =
2022-08-31 16:37:05 - FFM26849 - = -ss 0.000 -vaapi_device /dev/dri/renderD128 -hwaccel vaapi -hwaccel_output_format vaapi -noautorotate -i /volume1/video/
2022-08-31 16:37:05 - FFM26849 - = Movies/Thriller/Death on the Nile (2022) Hybrid MULTi VFF 2160p 10bit 4KLight DOLBY VISION BluRay DDP 7.1 x265-QTZ.mkv -
2022-08-31 16:37:05 - FFM26849 - = r 24 -vcodec h264_vaapi -vf format=nv12|vaapi,hwupload,scale_vaapi=w=1920:h=800,scale_vaapi=format=nv12 -vsync 2 -bf 0 -
2022-08-31 16:37:05 - FFM26849 - = vb 15000000 -acodec libmp3lame -ab 128K -ac 2 -f ssegment -pix_fmt yuv420p -segment_format mpegts -segment_list_type m3u
2022-08-31 16:37:05 - FFM26849 - = 8 -hls_seek_time 0 -segment_time 5 -segment_time_delta 0.000 -segment_start_number 00000 -avoid_negative_ts 0 -break_non
2022-08-31 16:37:05 - FFM26849 - = _keyframes 1 -max_muxing_queue_size 1024 -map 0:0 -map 0:1 /tmp/VideoStation/HLS/fe99729deec7b6d27488f2bedcd5d512_nqr61F
2022-08-31 16:37:05 - FFM26849 - = in/slice-%05d.ts
2022-08-31 16:37:05 - FFM26849 - MODE = ORIG
2022-08-31 16:37:05 - FFM26849 - FFMPEG = /var/packages/CodecPack/target/pack/bin/ffmpeg41.orig
2022-08-31 16:37:05 - FFM26849 - PARAMWP =
2022-08-31 16:37:05 - FFM26849 - = -ss 0.000 -vaapi_device /dev/dri/renderD128 -hwaccel vaapi -hwaccel_output_format vaapi -noautorotate -i /volume1/video/
2022-08-31 16:37:05 - FFM26849 - = Movies/Thriller/Death on the Nile (2022) Hybrid MULTi VFF 2160p 10bit 4KLight DOLBY VISION BluRay DDP 7.1 x265-QTZ.mkv -
2022-08-31 16:37:05 - FFM26849 - = r 24 -vcodec h264_vaapi -vf format=nv12|vaapi,hwupload,scale_vaapi=w=1920:h=800,scale_vaapi=format=nv12 -vsync 2 -bf 0 -
2022-08-31 16:37:05 - FFM26849 - = vb 15000000 -acodec libmp3lame -ab 128K -ac 2 -f ssegment -pix_fmt yuv420p -segment_format mpegts -segment_list_type m3u
2022-08-31 16:37:05 - FFM26849 - = 8 -hls_seek_time 0 -segment_time 5 -segment_time_delta 0.000 -segment_start_number 00000 -avoid_negative_ts 0 -break_non
2022-08-31 16:37:05 - FFM26849 - = _keyframes 1 -max_muxing_queue_size 1024 -map 0:0 -map 0:1 /tmp/VideoStation/HLS/fe99729deec7b6d27488f2bedcd5d512_nqr61F
2022-08-31 16:37:05 - FFM26849 - = in/slice-%05d.ts
2022-08-31 16:37:05 - FFM26849 - CHILDPID = 26940
2022-08-31 16:37:06 - FFM26849 - *** CHILD END ***
2022-08-31 16:37:06 - FFM26849 - STDOUT =
2022-08-31 16:37:06 - FFM26849 - = NUMBER_OF_BYTES : 33762532
2022-08-31 16:37:06 - FFM26849 - = _STATISTICS_WRITING_APP: mkvmerge v66.0.0 ('Josie') 64-bit
2022-08-31 16:37:06 - FFM26849 - = _STATISTICS_WRITING_DATE_UTC: 2022-04-05 08:37:48
2022-08-31 16:37:06 - FFM26849 - = _STATISTICS_TAGS: BPS DURATION NUMBER_OF_FRAMES NUMBER_OF_BYTES
2022-08-31 16:37:06 - FFM26849 - = Stream #0:8(eng): Subtitle: hdmv_pgs_subtitle
2022-08-31 16:37:06 - FFM26849 - = Metadata:
2022-08-31 16:37:06 - FFM26849 - = title : ENG Full SDH : PGS
2022-08-31 16:37:06 - FFM26849 - = BPS : 49410
2022-08-31 16:37:06 - FFM26849 - = DURATION : 01:58:58.506000000
2022-08-31 16:37:06 - FFM26849 - = NUMBER_OF_FRAMES: 4110
2022-08-31 16:37:06 - FFM26849 - = NUMBER_OF_BYTES : 44089978
2022-08-31 16:37:06 - FFM26849 - = _STATISTICS_WRITING_APP: mkvmerge v66.0.0 ('Josie') 64-bit
2022-08-31 16:37:06 - FFM26849 - = _STATISTICS_WRITING_DATE_UTC: 2022-04-05 08:37:48
2022-08-31 16:37:06 - FFM26849 - = _STATISTICS_TAGS: BPS DURATION NUMBER_OF_FRAMES NUMBER_OF_BYTES
2022-08-31 16:37:06 - FFM26849 - = Stream mapping:
2022-08-31 16:37:06 - FFM26849 - = Stream #0:0 -> #0:0 (hevc (native) -> h264 (h264_vaapi))
2022-08-31 16:37:06 - FFM26849 - = Stream #0:1 -> #0:1 (? (?) -> mp3 (libmp3lame))
2022-08-31 16:37:06 - FFM26849 - = Decoder (codec eac3) not found for input stream #0:1
2022-08-31 16:37:06 - FFM26849 - MODE = PIPE V_ORIG-A_WRAP
2022-08-31 16:37:06 - FFM26849 - FFMPEG1 = /var/packages/CodecPack/target/pack/bin/ffmpeg41.orig
2022-08-31 16:37:06 - FFM26849 - FFMPEG2 = /var/packages/ffmpeg/target/bin/ffmpeg
2022-08-31 16:37:06 - FFM26849 - PARAM1 =
2022-08-31 16:37:06 - FFM26849 - = -ss 0.000 -noaccurate_seek -vaapi_device /dev/dri/renderD128 -hwaccel vaapi -hwaccel_output_format vaapi -noautorotate -
2022-08-31 16:37:06 - FFM26849 - = i /volume1/video/Movies/Thriller/Death on the Nile (2022) Hybrid MULTi VFF 2160p 10bit 4KLight DOLBY VISION BluRay DDP 7
2022-08-31 16:37:06 - FFM26849 - = .1 x265-QTZ.mkv -r 24 -vcodec h264_vaapi -vf format=nv12|vaapi,hwupload,scale_vaapi=w=1920:h=800,scale_vaapi=format=nv12
2022-08-31 16:37:06 - FFM26849 - = -vsync 2 -bf 0 -vb 15000000 -acodec copy -f mpegts -pix_fmt yuv420p -map 0:0 -map 0:1 -bufsize 8192k pipe:1
2022-08-31 16:37:06 - FFM26849 - PARAM2 =
2022-08-31 16:37:06 - FFM26849 - = -analyzeduration 10000000 -vaapi_device /dev/dri/renderD128 -hwaccel vaapi -hwaccel_output_format vaapi -noautorotate -i
2022-08-31 16:37:06 - FFM26849 - = pipe:0 -map 0:0 -map 0:1 -map 0:1 -r 24 -vcodec copy -vsync 2 -bf 0 -vb 15000000 -c:a:0 libmp3lame -c:a:1 libfdk_aac -b
2022-08-31 16:37:06 - FFM26849 - = :a:0 256k -b:a:1 512k -ac:1 2 -ac:2 6 -f ssegment -pix_fmt yuv420p -segment_format mpegts -segment_list_type m3u8 -hls_s
2022-08-31 16:37:06 - FFM26849 - = eek_time 0 -segment_time 5 -segment_time_delta 0.000 -segment_start_number 00000 -avoid_negative_ts 0 -break_non_keyfram
2022-08-31 16:37:06 - FFM26849 - = es 1 -max_muxing_queue_size 1024 /tmp/VideoStation/HLS/fe99729deec7b6d27488f2bedcd5d512_nqr61Fin/slice-%05d.ts
2022-08-31 16:37:06 - FFM26849 - CHILDPID = 27003
2022-08-31 16:37:18 - FFM26849 - *** KILLCHILD ***
2022-08-31 16:37:18 - FFM26849 - *** CHILD END ***
2022-08-31 16:37:18 - FFM26849 - *** PROCESS END ***

@darknebular
Copy link

Well, the installation complete without errors.
First I am try to investigate your config menu problem
Has you tried to re launch the script erasing -install flag with the flag -config ?

The other thing is another problem, i don't have a 7.1 movie for testing and I will take its time to resolve.
Please Open a issue in my repository and will investigate it.

Thanks.

@KipiKland
Copy link

Well, the installation complete without errors. First I am try to investigate your config menu problem Has you tried to re launch the script erasing -install flag with the flag -config ?

Yes and it will display the same : Actually You HAVEN'T ANY WRAPPER INSTALLED and this codec Configurator CAN'T change anything
However i believe it is installed.

The other thing is another problem, i don't have a 7.1 movie for testing and I will take its time to resolve. Please Open a issue in my repository and will investigate it.
Thanks.

Movie is playing fine, where do you see an issue ?

@darknebular
Copy link

However i believe it is installed.

YES YES. IT´S INSTALLED.
I don´t know why doesn´t compare two strings in my script...I will check it out later

Best regards my friend and sorry.

@darknebular
Copy link

Movie is playing fine, where do you see an issue ?

Because you said that you not...ahhhh

don´t worry..

Ok is FINE.

The problem is with the configurator menu in your case, nothing more.

@KipiKland
Copy link

KipiKland commented Aug 31, 2022 via email

@darknebular
Copy link

darknebular commented Sep 1, 2022

@KipiKland
Hi my friend,

I just fixed the Configurator menu when It isn't installed MediaServer, look:

  1. If you haven't installed MediaServer you will see the configurator menu in this way:
    image

NOTE: Yellow is due a partial config of this option, Red is forbiden in this case

  1. If you have installed MediaServer you will see the configurator menu in this way:
    image

In the next release SCPT_1.11 I will add more loggings lines and clean a little bit the code.

BEST REGARDS!!!!

@darknebular
Copy link

darknebular commented Sep 1, 2022

I will investigate the independence of the audio codecs between Media Server and VideoStation further...

@darknebular
Copy link

darknebular commented Sep 1, 2022

What's happen when you HAVEN'T the licence loaded in Advanced Media extension?

Well, without the LICENCE loaded in AME you will not have the path /var/packages/CodecPack/target/pack/bin

If you use a "HERE WE GO" Script, you will be running into a future problems.
Now, in SCPT_1.11 My installer check the existence of this licence.

image

Best regards.

@darknebular
Copy link

darknebular commented Sep 1, 2022

TESTING IN VERY LOW POWERED NAS: DS-120J WITH A MONSTER OF MOVIE:

image

image

(Only permits the remux of the audio)
image
image
image
image
image

@darknebular
Copy link

darknebular commented Sep 1, 2022

JUST FINISH The Installer´s Script version 1.11.

Fully tested, fully stable, fully configurable using the Advanced Wrapper.

NOW YOU WILL HAVE: (Only when It´s necessary to activate my wrapper. This means DTS, EAC3 and TrueHD.)

  • In MediaServer DLNA = [1) AAC 5.1 512kbps AND 2) MP3 2.0 256kbps.] (by default) (If exists) **
  • In VIDEO-STATION = [1) MP3 2.0 256kbp AND 2) AAC 5.1 512kbps.] (by default)
  • You now can change the 5.1 audio´s codec from AAC 512kbps to AC3* 640kbps independently of its audio´s streams order in VIDEO-STATION and DLNA MediaServer using the configurator tool embedded into the installer.sh.

*(AC3 is more compatible with legacy 5.1 devices).
**(Tried to make independent Media Server from Video Station ffmpeg.)

ADD-ONs FROM 1.10:

  • Improvements in the Configurator menu when It's launched if you haven't MediaServer Installed.
  • Now You can see the installation logs with expanded detail and the Wrapper logs in: /tmp/wrapper_ffmpeg.log.
  • Tested and working fine in a lot of Synology´s models.
  • Added a checker of the existence of a licence in AME Package.

Check It out:
Connect using SSH and then:

Enter:
sudo -i

And then:

INSTALL / UNINSTALL:

Enter:
bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s install

Or (for uninstall it...)

Enter:
bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s uninstall

CONFIGURATOR TOOL:

Enter:
bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s config

https://github.com/darknebular/Wrapper_VideoStation

...

Please give a star in my repository if you like my wrapper. Thanks...

BEST REGARDS.

@akvamassa
Copy link

akvamassa commented Sep 1, 2022

Hi @darknebular, you made so big work and I wanted to test newest version and give you feedback.
I made installation of all packages (AME, MS, VS, ffmpeg) from scratch, and then installed wrapper with auto-installer. It works really good!

If you remember, I don't use Video Station, just watch movies from TV (Media Server DLNA).
At first I launched a movie with DTS and I noticed that first audio track it MP3, second is AAC.
I thought "strange". And selected in Wrapper Configurator variant B. After this AAC became first and MP3 second. Good.
Then in Wrapper Configurator I selected variant C to change AAC 512kbps to AC3 640kbps. This also worked well. You are awesome :)

But after this I launched movie where there is no DTS audiotrack (it is already AAC 5.1). And unfortunately I've seen on my Yamaha receiver that audio is stereo. It seems that it is transcoded from 5.1 to stereo. And there is no audiotrack selection on the TV (it's the only track).
Then in Wrapper Configurator I selected variant D - "maybe it will help?" But this didn't help :)
Can you check do you have the same situation with movies without DTS audio if you use Media Server DLNA?

@darknebular
Copy link

darknebular commented Sep 2, 2022

I have verified that no wrapper is needed in MediaStation and VideoStation folder. only in CodecPack.

In the end, I'm going to leave it as I had it 1 year ago, just modify the libsynovte.so file.

In the Configurator tool I am going to change the words VIDEO-STATION to CODEC-PACK.

I am studying the possibility of MediaStation being 100% independent of the CodecPack, if I succeed I will leave the wrapper, otherwise I will only touch the mentioned file and I will change the Configurator tool menu.

LOOK, I RENAME THE BINARY FFMPEG FROM MEDIASERVER, THEN THERE ISN´T ANY WRAPPER OR FFMPEG IN MEDIASERVER FOLDER, AND STILL WORKING, Because all It is redirected to CodecPack:
image
image

Best regards.

@darknebular
Copy link

darknebular commented Sep 2, 2022

@akvamassa

Well you only will have two audio's streams from the same audio's track when It´s necessary to transcode. This means DTS, EAC3 and TrueHD.
Playing other audio's codecs the wrapper doesn´t active and acting the default synology transprofiles.

For bypass this behaviour:
Then, if you have a A/V receiver, I recommend you to disable transcoding in Media Server. Don't worry, you will can play DTS, EAC3 and TrueHD and will be send in native mode.

Best Regards.

@darknebular
Copy link

WELL I FOUND A SOLUTION FOR HAVING INDEPENDECE FROM CODECPACK.

Now I don´t know if change the actual 1.11 (I love the 11 number jejeje) or do 1.12 version of SCPT.

@akvamassa
Copy link

akvamassa commented Sep 2, 2022

Then, if you have a A/V receiver, I recommend you to disable transcoding in Media Server. Don't worry, you will can play DTS, EAC3 and TrueHD and will be send in native mode.

Hello, unfortunately not. Receiver is taking audio signal from TV (via HDMI ARC) so I need the transcoding - in this case TV can "recognize DTS".

Playing other audio's codecs the wrapper doesn´t active and acting the default synology transprofiles.

Okay, I'll try to disable audio-transcoding, because default "Synology Transprofiles" convert 5.1 to stereo.

But I have not much time for it. Maybe I will wait for your new implementation ;)

@KipiKland
Copy link

@KipiKland Hi my friend,

I just fixed the Configurator menu when It isn't installed MediaServer, look:

  1. If you haven't installed MediaServer you will see the configurator menu in this way:
    image

NOTE: Yellow is due a partial config of this option, Red is forbiden in this case

  1. If you have installed MediaServer you will see the configurator menu in this way:
    image

In the next release SCPT_1.11 I will add more loggings lines and clean a little bit the code.

BEST REGARDS!!!!

Works like a charm, you rock, thanks a lot !

@darknebular
Copy link

You are welcome.

I am testing the new wrapper beta-version (AME_12.3.4). In the next release I will put this version of the wrapper in CodecPack and I don't touch any ffmpeg file in VideoStation or MediaServer. It´s useless there...
In this way, the file TransProfiles will be native, without touch...

More clean, less touching, better...

Best regards.

@darknebular
Copy link

darknebular commented Sep 3, 2022

The new version has been released:

ENJOY!!!!

@darknebular
Copy link

darknebular commented Sep 3, 2022

@KipiKland Hi my friend,
IN DLNA WHILE I HAVE 2.0 IN VIDEO STATION:

image

@darknebular
Copy link

JUST FINISH The Installer´s Script version 1.12.

Fully tested, fully stable, fully configurable using the Advanced Wrapper.

NOW YOU WILL HAVE: (Only when It´s necessary to activate my wrapper. This means DTS, EAC3 and TrueHD.)

  • In MediaServer DLNA = [1) AAC 5.1 512kbps AND 2) MP3 2.0 256kbps.] (by default) (If exists)
  • In VIDEO-STATION = [1) MP3 2.0 256kbp AND 2) AAC 5.1 512kbps.] (by default)
  • You now can change the 5.1 audio´s codec from AAC 512kbps to AC3* 640kbps independently of its audio´s streams order in VIDEO-STATION and DLNA MediaServer using the configurator tool embedded into the installer.sh.

*(AC3 is more compatible with legacy 5.1 devices).

ADD-ONs FROM 1.11:

  • Tested and working fine in a lot of Synology´s models.
    - Now the audio's codecs are independent between VideoStation and Media Station in Configurator TOOL.
  • Added the new wrapper in the installer. It´s mandatory to install this version of the wrapper using the new installer.

Check It out:
Connect using SSH and then:

Enter:
sudo -i

And then:

INSTALL / UNINSTALL:

Enter:
bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s install

Or (for uninstall it...)

Enter:
bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s uninstall

CONFIGURATOR TOOL:

Enter:
bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s config

https://github.com/darknebular/Wrapper_VideoStation

...

Please give a star in my repository if you like my wrapper. Thanks...

BEST REGARDS.

@darknebular
Copy link

If someone donate a DS with Gstreamer I will fix it in one week.

@akvamassa
Copy link

Hello @darknebular , I've installed last version of the wrapper and it works nice with DTS movies (DS420+)!
I wanted to change it for my needs (a) remux movies without DTS, with all audiotracks and b) transcode only audio in DTS movies and remux video), so I have a look into log file wrapper_ffmpeg.log. It helped me a lot to understand how the wrapper works. Thanks a lot for this too.
I want to give you a small idea- would great if you will add logging of params which you are using in WRAPPER_SINGLE-VS mode, because it's missing in log :)
And I want to inform about stange thing - mode PIPE V_WRAP-A_WRAP-MS is never used in my case (and I am using only MediaServer from my TV) - maybe it will be useful for you to know. If you want I can share with you small log file to analyze. I tried launch 2 movies (with DTS and without DTS) when I was researching how it works)

@darknebular
Copy link

NOW, IF YOU HAVE A LOW POWERED NAS, YOU CAN CHANGE THE CONFIG IN ORDER TO HAVE AN UNIQUE AUDIO STREAM FOR SAVING SYSTEM RESOURCES.

Look:

By default:
image

Only ONE audio stream using MP3 2.0:
image

Only ONE audio stream using AAC 5.1:
image

BEST REGARDS.

@darknebular
Copy link

darknebular commented Sep 4, 2022

JUST FINISH The Installer´s Script version 1.14.

Fully tested, fully stable, fully configurable using the Advanced Wrapper.

NOW YOU WILL HAVE: (Only when It´s necessary to activate my wrapper. This means DTS, EAC3 and TrueHD.)

  • In MediaServer DLNA = [1) AAC 5.1 512kbps AND 2) MP3 2.0 256kbps.] (by default) (If exists)
  • In VIDEO-STATION = [1) MP3 2.0 256kbp AND 2) AAC 5.1 512kbps.] (by default)
  • You now can change the 5.1 audio´s codec from AAC 512kbps to AC3* 640kbps independently of its audio´s streams order in VIDEO-STATION and DLNA MediaServer using the configurator tool embedded into the installer.sh.

*(AC3 is more compatible with legacy 5.1 devices).

ADD-ONs FROM 1.12:

  • Tested and working fine in a lot of Synology´s models.
  • Added the new wrapper in the installer SCPT_1.12. It´s mandatory to install this version of the wrapper using the installer SCPT_1.12 or above to use the news.
  • Fixed aesthetic flaws in the texts of Configurator Tool Menu.
  • Added two new options in Configurator Tool, now you can change to use an unique audio's stream for low powered devices.

Check It out:
Connect using SSH and then:

Enter:
sudo -i

And then:

INSTALL / UNINSTALL:

Enter:
bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s install

Or (for uninstall it...)

Enter:
bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s uninstall

CONFIGURATOR TOOL:

Enter:
bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s config

https://github.com/darknebular/Wrapper_VideoStation

...

Please give a star in my repository if you like my wrapper. Thanks...

BEST REGARDS.

@darknebular
Copy link

darknebular commented Sep 4, 2022

image

@Gideon75
Copy link

Gideon75 commented Sep 4, 2022

Videostation (on Frestik) continually interrupt the video after a few minutes.
Where do I find the logs to understand what doesn't work?
DSM 7.1 on Synology 1019+
Thanks

@darknebular
Copy link

darknebular commented Sep 4, 2022

cat /tmp/wrapper_ffmpeg.log

Please, try to uninstall and then reinstall again...It's possible that you have any remnant of an old wrapper.

Best regards.

@darknebular
Copy link

darknebular commented Sep 4, 2022

If you had another wrapper installed, please try to select I (Install option) and then write Y o YES for uninstall an old or other wrapper.
This will uninstall other wrappers.
image

@darknebular
Copy link

PIPE V_WRAP-A_WRAP-MS

This only activated when using DLNA via pipe:6, using a DLNA client via UPnP through UDP It will use this.

@zesenzhang
Copy link

只需完成安装程序脚本版本 1.14。

使用 Advanced Wrapper 完全测试、完全稳定、完全可配置。

**现在您将拥有:(**仅当需要激活我的包装器时。这意味着 DTS、EAC3 和 TrueHD。)

  • 在 MediaServer DLNA = [1) AAC 5.1 512kbps AND 2) MP3 2.0 256kbps.](默认)(如果存在)
  • 在 VIDEO-STATION = [1) MP3 2.0 256kbp 和 2) AAC 5.1 512kbps.](默认)
  • 您现在可以使用嵌入在 installer.sh 中的配置工具将 5.1 音频的编解码器从 AAC 512kbps 更改为 AC3* 640kbps,而与 VIDEO-STATION 和 DLNA MediaServer 中的音频流顺序无关。

*(AC3 与旧版 5.1 设备更兼容)。

1.12 的附加组件:

  • 在许多 Synology 的型号中测试并运行良好。
  • 在安装程序 SCPT_1.12 中添加了新包装器。必须使用安装程序 SCPT_1.12 或更高版本安装此版本的包装器才能使用新闻。
  • 修复了配置工具菜单文本中的美学缺陷。
  • 在配置器工具中添加了两个新选项,现在您可以更改为对低功率设备使用独特的音频流。

检查一下: 使用 SSH 连接,然后:

进入: sudo -i

接着:

安装/卸载:

进入: bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s install

或者(卸载它...)

进入: bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s uninstall

配置工具:

进入: bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s config

https://github.com/darknebular/Wrapper_VideoStation

...

如果您喜欢我的包装器,请在我的存储库中给一颗星。谢谢...

此致。

root@Z_NAS:~# bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s install
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
curl: (60) SSL: no alternative certificate subject name matches target host name 'raw.githubusercontent.com'
More details here: https://curl.se/docs/sslcerts.html

curl failed to verify the legitimacy of the server and therefore could not
establish a secure connection to it. To learn more about this situation and
how to fix it, please visit the web page mentioned above.

Can you help me figure out why this is happening? Thank you very much.

@KidWar75
Copy link

KidWar75 commented Sep 5, 2022

Hey @AlexPresso, does the new update of VS (AME 3.0 compatibility & AAC audio) affect your wrapper ?

@darknebular
Copy link

@akvamassa

I just added the new Wrapper with this missing logging option in WRAPPER_SINGLE-VS mode. THANKS!!!
I prioritize the use of native ffmpeg in Video Station in the wrapper, I did a missconfiguration there.

If you would like to have this logging option using this mode, please reinstall the wrapper using the installer. Sorry for that.

Best regards.

@darknebular
Copy link

darknebular commented Sep 5, 2022

Can you help me figure out why this is happening? Thank you very much.

It´s possible that GitHub had changed the certificate in its hosting. It didn't.
It´s possible that you are being behing a proxy with SSL Inspection, and this is changing the certificate.

In your case I would try with this:

bash -c "$(curl -k "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")"

I don't want to change the script for working behind a Proxy with SSL-Inspection. Then in your case, please download the script with:

curl -k "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh" -o installer.sh

Then change the line 614 from:
wget -q $repo_url/main/ffmpeg41-wrapper-DSM7_$injector -O ${cp_bin_path}/ffmpeg41 2>> $logfile

TO:
wget -q --no-check-certificate $repo_url/main/ffmpeg41-wrapper-DSM7_$injector -O ${cp_bin_path}/ffmpeg41 2>> $logfile

And change the line 997 from:
wget -q $repo_url/main/simplest_wrapper -O ${cp_bin_path}/ffmpeg41 2>> $logfile

TO:

wget -q --no-check-certificate $repo_url/main/simplest_wrapper -O ${cp_bin_path}/ffmpeg41 2>> $logfile

THEN ENTER:
./installer.sh

Best regards.

@darknebular
Copy link

darknebular commented Sep 5, 2022

JUST FINISH The Installer´s Script version 1.15.

Fully tested, fully stable, fully configurable using the Advanced Wrapper.

NOW YOU WILL HAVE: (Only when It´s necessary to activate my wrapper. This means DTS, EAC3 and TrueHD.)

  • In MediaServer DLNA = [1) AAC 5.1 512kbps AND 2) MP3 2.0 256kbps.] (by default) (If exists)
  • In VIDEO-STATION = [1) MP3 2.0 256kbp AND 2) AAC 5.1 512kbps.] (by default)
  • You now can change the 5.1 audio´s codec from AAC 512kbps to AC3* 640kbps independently of its audio´s streams order in VIDEO-STATION and DLNA MediaServer using the configurator tool embedded into the installer.sh.

*(AC3 is more compatible with legacy 5.1 devices).

ADD-ONs FROM 1.14:

  • Tested and working fine in a lot of Synology´s models.
  • Added the new wrapper into the installer SCPT_1.15. The wrapper changed in SCPT_1.12 and NOW in SCPT_1.15.
  • If you would like to use the news of the wrapper (have independence of the config between VideoStation and MediaStation, new logging add-ons, etc.), you must re-install again the wrapper using this installer version or above. Sorry for that.

Check It out:
Connect using SSH and then:

Enter:
sudo -i

And then:

INSTALL / UNINSTALL:

Enter:
bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s install

Or (for uninstall it...)

Enter:
bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s uninstall

CONFIGURATOR TOOL:

Enter:
bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s config

https://github.com/darknebular/Wrapper_VideoStation

...

Please give a star in my repository if you like my wrapper. Thanks...

BEST REGARDS.

@darknebular
Copy link

test_results

test_installers

@AlexPresso
Copy link

AlexPresso commented Sep 5, 2022

Hey @AlexPresso, does the new update of VS (AME 3.0 compatibility & AAC audio) affect your wrapper ?

@KidWar75 The wrapper works on every VS versions (even previous one), you just need to reinstall it when you update one of the following packages:

  • VideoStation
  • Advanced Media Extensions
  • DSM itself (only because it may auto-update some packages during the update process)

:)

@AlexPresso
Copy link

AlexPresso commented Sep 5, 2022

By the way, much thanks to @th0ma7, we'll soon have a GStreamer SynoCommunity package, so I'll be able to merge AlexPresso/VideoStation-FFMPEG-Patcher#33 it will fix the issue on some NAS (depending on the architecture) where you cannot play DTS + HEVC movies because the stream is piped from GStreamer to FFMPEG (and actually fails in GStreamer because it was not built with some required libs).

Currently this scenario (where AME uses GStreamer + FFMPEG) is not working on any wrapper at all (even if someone seems to say so).

@KidWar75
Copy link

KidWar75 commented Sep 6, 2022

Hey @AlexPresso, does the new update of VS (AME 3.0 compatibility & AAC audio) affect your wrapper ?

@KidWar75 The wrapper works on every VS versions (even previous one), you just need to reinstall it when you update one of the following packages:

  • VideoStation
  • Advanced Media Extensions
  • DSM itself (only because it may auto-update some packages during the update process)

:)

Oh ye my bad, you already told me that... ;)
Cheers !

@darknebular
Copy link

darknebular commented Sep 6, 2022

SCPT_1.15 is Fully compatible with the new release of Video Station and AME 3.0.

@darknebular
Copy link

If you pipe the bin1 (for video) using Gstreamer and bin2 (for audio) in CodecPack, It should work fine.
Only need to ensure that only pass the video options arguments in the binary1...

@AlexPresso
Copy link

AlexPresso commented Sep 6, 2022

Yes, but problem is AME GStreamer is missing libraries to transcode some codecs, we need a SynoCommunity one for that, otherwise it would require to make a parser that translates all gstreamer args into ffmpeg one and make a fake loop so it doesn't kill the VideoStation process.

I prefer to wait on a SC Gstreamer and make a simple clean wrapper for it

@darknebular
Copy link

darknebular commented Sep 6, 2022

I prefer to wait on a SC Gstreamer and make a simple clean wrapper for it

me too.
IT´s better. The fake loop to ffmpeg will work fine, but It´s dirty.

But, I thought that Gstreamer was only used for video, right? Then the audio's codecs are sending to ffmpeg, correct or I am wrong with this?

@darknebular
Copy link

I need a person with a DS21X_Play for try to do a GStreamer Wrapper. THANKS!!!

@zesenzhang
Copy link

你能帮我弄清楚为什么会这样吗?非常感谢。

GitHub 可能在其托管中更改了证书。它没有。 您可能正在成为 SSL 检查的代理,这正在更改证书。

在你的情况下,我会尝试这个:

bash -c "$(curl -k "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")"

我不想更改使用 SSL-Inspection 在代理后面工作的脚本。然后在您的情况下,请下载脚本:

curl -k "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh" -o installer.sh

然后将第614行从: wget -q $repo_url/main/ffmpeg41-wrapper-DSM7_$injector -O ${cp_bin_path}/ffmpeg41 2>> $logfile

至: wget -q --no-check-certificate $repo_url/main/ffmpeg41-wrapper-DSM7_$injector -O ${cp_bin_path}/ffmpeg41 2>> $logfile

并将第997行从: wget -q $repo_url/main/simplest_wrapper -O ${cp_bin_path}/ffmpeg41 2>> $logfile

至:

wget -q --no-check-certificate $repo_url/main/simplest_wrapper -O ${cp_bin_path}/ffmpeg41 2>> $logfile

然后输入: ./installer.sh

此致。

[2022-09-06 22:48:10] INFO: ==================== Installation of the Advanced Wrapper: START ====================

[2022-09-06 22:48:10] INFO: You are running DSM 7.1.1
[2022-09-06 22:48:10] INFO: DSM 7.1.1 is supported for this installer and the installer will tuned for your DSM
[2022-09-06 22:48:10] INFO: DSM 7.1.1 is using this path: /var/packages/CodecPack/target/bin
[2022-09-06 22:48:10] INFO: DSM 7.1.1 is using this injector: 0-12.2.4
[2022-09-06 22:48:10] INFO: Backup the original ffmpeg41 as ffmpeg41.orig.
[2022-09-06 22:48:10] INFO: Creating the esqueleton of the ffmpeg41
[2022-09-06 22:48:10] INFO: Injection of the ffmpeg41 wrapper using this injector: 0-12.2.4.
[2022-09-06 22:48:10] INFO: Waiting for consolidate the download of the wrapper.
[2022-09-06 22:48:13] INFO: Fixing permissions of the ffmpeg41 wrapper.
[2022-09-06 22:48:13] INFO: Ensuring the existence of the new log file wrapper_ffmpeg and its access.
[2022-09-06 22:48:13] INFO: Installed correctly the wrapper41 in /var/packages/CodecPack/target/bin
[2022-09-06 22:48:13] INFO: Backup the original libsynovte.so in VideoStation as libsynovte.so.orig.
[2022-09-06 22:48:13] INFO: Fixing permissions of /var/packages/VideoStation/target/lib/libsynovte.so.orig
[2022-09-06 22:48:13] INFO: Patching /var/packages/VideoStation/target/lib/libsynovte.so for compatibility with DTS, EAC3 and TrueHD
[2022-09-06 22:48:13] INFO: Modified correctly the file /var/packages/VideoStation/target/lib/libsynovte.so
[2022-09-06 22:48:13] INFO: Installed correctly the Advanced Wrapper in VideoStation.
[2022-09-06 22:48:13] INFO: Adding of the KEY of this Wrapper in DLNA MediaServer.
[2022-09-06 22:48:13] INFO: Installed correctly the Wrapper in /var/packages/MediaServer/target/bin
[2022-09-06 22:48:13] INFO: Backup the original libsynovte.so in MediaServer as libsynovte.so.orig.
[2022-09-06 22:48:13] INFO: Fixing permissions of /var/packages/MediaServer/target/lib/libsynovte.so.orig
[2022-09-06 22:48:13] INFO: Patching /var/packages/MediaServer/target/lib/libsynovte.so for compatibility with DTS, EAC3 and TrueHD
[2022-09-06 22:48:13] INFO: Modified correctly the file /var/packages/MediaServer/target/lib/libsynovte.so
[2022-09-06 22:48:13] INFO: Installed correctly the Advanced Wrapper in Media Server.
[2022-09-06 22:48:13] INFO: Restarting CodecPack...
restart package [CodecPack] successfully
[2022-09-06 22:48:16] INFO: Restarting VideoStation...
restart package [VideoStation] successfully
[2022-09-06 22:48:19] INFO: Restarting MediaServer...
restart package [MediaServer] successfully
[2022-09-06 22:48:22] INFO: ==================== Installation of the Advanced Wrapper: COMPLETE ====================

Thanks a lot, it's finally working.
Let me propose a toast to。

But the Video station does not seem to play DTS and EAC3 properly. Do I need to restart the NAS?
My version of the DSM: DSM 7.1.1-42951

@darknebular
Copy link

darknebular commented Sep 6, 2022

Thanks a lot, it's finally working.

What NAS have you got?
Have you got other wrapper installed before? There are some installers in Internet that the originals binaries are changed to .bak and not to .orig...

It is possible that the license checker is not correct for DSM 7.1.1. Have you activated the license in Advanced Media Extension?

If you didn't have loaded this license, please Uninstall all, LOAD the license and then TRY AGAIN. Thanks!!!

Best regards.

@darknebular
Copy link

darknebular commented Sep 6, 2022

Please can you send me these commands?

cd /var/packages/CodecPack/target/bin

and then:
ls -la

cd /var/packages/CodecPack/

and then:
ls -la

After confirm the license in Advanced Media Extension package, could you enter these commands?

cd /var/packages/CodecPack/target/pack/bin

and then:
ls -la

The 7.1.1 must be using /var/packages/CodecPack/target/pack/bin and not /var/packages/CodecPack/target/bin.

@zesenzhang
Copy link

root@Z_NAS:~# cd /var/packages/CodecPack/target/bin
root@Z_NAS:/var/packages/CodecPack/target/bin# ls -la
total 60
drwxr-xr-x 1 CodecPack CodecPack 154 Sep 6 22:47 .
drwxr-xr-x 1 CodecPack CodecPack 58 Sep 6 22:46 ..
lrwxrwxrwx 1 CodecPack CodecPack 30 Jun 27 14:59 ffmpeg33-for-audio -> ../pack/bin/ffmpeg33-for-audio
lrwxrwxrwx 1 CodecPack CodecPack 37 Jun 27 14:59 ffmpeg33-for-surveillance -> ../pack/bin/ffmpeg33-for-surveillance
-rwxr-xr-x 1 root root 543 Sep 5 02:14 ffmpeg41
lrwxrwxrwx 1 CodecPack CodecPack 20 Jun 27 14:59 ffmpeg41.orig -> ../pack/bin/ffmpeg41
-rwxr-xr-x 1 CodecPack CodecPack 42105 Jun 27 14:59 synocodectool
root@Z_NAS:/var/packages/CodecPack/target/bin#

DSM 7.1.1-42951 DS3622xs+
I don't have an Advanced Media Extension license

@zesenzhang
Copy link

你能把这个命令发给我吗?

cd /var/packages/CodecPack/target/bin

评价: ls -la

确认 Advanced Media Extension 包中的许可之后,可以输入这些命令吗?

cd /var/packages/CodecPack/target/pack/bin

评价: ls -la

7.1.1 必须使用 /var/packages/CodecPack/target/pack/bin 而不是 /var/packages/CodecPack/target/bin。

root@Z_NAS:# cd /var/packages/CodecPack/target/pack/bin
-ash: cd: /var/packages/CodecPack/target/pack/bin: No such file or directory
root@Z_NAS:
#
No such file or directory

@darknebular
Copy link

No such file or directory

I know, in 7.1.X must be using /var/packages/CodecPack/target/pack/bin after load the LICENSE in AME.

Can you send me the other two paths?

Thanks.

@zesenzhang
Copy link

image
I installed this kit

@darknebular
Copy link

lrwxrwxrwx 1 CodecPack CodecPack 20 Jun 27 14:59 ffmpeg41.orig -> ../pack/bin/ffmpeg41

You need to open the Advanced Media Extension and load the license. After of that, the complete path will be generated.

@darknebular
Copy link

image I installed this kit

This one:
image

@zesenzhang
Copy link

cd /var/packages/CodecPack/target/pack/bin

image
Another path hint could not be found

@zesenzhang
Copy link

图片我安装了这个套件

这个: 图片

image

@darknebular
Copy link

Another path hint could not be found
Please send me this:

cd /var/packages/CodecPack/

and then
ls -la

Best regards.

@zesenzhang
Copy link

I don't have a permit.

@zesenzhang
Copy link

image

@darknebular
Copy link

darknebular commented Sep 6, 2022

@zesenzhang Please, UNINSTALL the wrapper right now using the installer.

Then, CLICK in the blue button in AME for LOAD THE LICENSE and then TRY again with the installer. You must be signed in in your Synology's account for download the license file.

Thanks for all.

@zesenzhang
Copy link

@zesenzhang Please, UNINSTALL the wrapper right now using the installer.

Then, CLICK in the blue button in AME for LOAD THE LICENSE and then TRY again with the installer. You must be signed in in your Synology's account.

Thanks for all.

Ttttthank you for your patience,I'm just a fresh bird in this area. But still have a question: is AEM license necessary?

@darknebular
Copy link

But still have a question: is AEM license necessary?

YES, It´s mandatory, If you don't load this license in AME, the CORRECT PATH to: /var/packages/Codec Pack/target/pack/bin will not be generated.

Regards.

@zesenzhang
Copy link

But still have a question: is AEM license necessary?

YES, It´s mandatory, If you don't load this license in AME, the CORRECT PATH to: /var/packages/Codec Pack/target/pack/bin will not be generated.

Regards.

Ok, What you told me has helped me a lot. Thanks again!

Best wishes.

@darknebular
Copy link

Best wishes.

You too. What's is the problem for load the license in AME there?
If you don't load the license and try to install a wrapper, It will have a lot of problems in the future, because you really don't be patching the binaries, but the link files

@darknebular
Copy link

darknebular commented Sep 6, 2022

If you have a fake SERIAL NUMBER, I will try this .sh:
https://github.com/dmc31a42/synocodectool-patch

Regards.

@darknebular
Copy link

@zesenzhang
Please, Can you send me the result of this command?
I will try to enable your license...
cat /usr/syno/etc/codec/activation.conf

Regards.

@darknebular
Copy link

With this script that I sended to you, You will be able to generated a fake license token for activation of the codecs...123456789, look:
image

@darknebular
Copy link

我安装了这个套件

Here, you can obtain info in order to activate the AME license in you NAS "de chatarrero".
https://xpenology.com/forum/topic/60005-advanced-media-extension-will-not-activate-dsm71-42661/page/2/

Best regards.

@darknebular
Copy link

darknebular commented Sep 7, 2022

I did improvements in the Licence Checker.
I will put again the conditionals of the S.O. I prefer 1000 times have a error saying "No exist this directory" than trying to patch links and not binaries.

@darknebular
Copy link

JUST FINISH The Installer´s Script version 1.16.

Fully tested, fully stable, fully configurable using the Advanced Wrapper.

NOW YOU WILL HAVE: (Only when It´s necessary to activate my wrapper. This means DTS, EAC3 and TrueHD.)

  • In MediaServer DLNA = [1) AAC 5.1 512kbps AND 2) MP3 2.0 256kbps.] (by default) (If exists)
  • In VIDEO-STATION = [1) MP3 2.0 256kbp AND 2) AAC 5.1 512kbps.] (by default)
  • You now can change the 5.1 audio´s codec from AAC 512kbps to AC3* 640kbps independently of its audio´s streams order in VIDEO-STATION and DLNA MediaServer using the configurator tool embedded into the installer.sh.

*(AC3 is more compatible with legacy 5.1 devices).

ADD-ONs FROM 1.15:

  • Tested and working fine in a lot of Synology´s models.
  • Improvement in the Licence checker of the AME.
  • Ensuring that the Installer will only patching DSM 7.0.X and 7.1.X legit.

Check It out:
Connect using SSH and then:

Enter:
sudo -i

And then:

INSTALL / UNINSTALL:

Enter:
bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s install

Or (for uninstall it...)

Enter:
bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s uninstall

CONFIGURATOR TOOL:

Enter:
bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s config

https://github.com/darknebular/Wrapper_VideoStation

...

Please give a star in my repository if you like my wrapper. Thanks...

BEST REGARDS.

@darknebular
Copy link

darknebular commented Sep 7, 2022

Move to down...

@KidWar75
Copy link

KidWar75 commented Sep 9, 2022

@AlexPresso Hey!
I just saw your repo on the MediaServer Patcher.
I tried it because... why not :D and here is what I got :
issue

@darknebular
Copy link

@KidWar75
You can use mi Installer with option: S

With this option you will install a fork of Alex's Wrapper.

@AlexPresso
Copy link

@AlexPresso Hey! I just saw your repo on the MediaServer Patcher. I tried it because... why not :D and here is what I got : issue

@KidWar75, you missed the curl before the URL while copy-pasting ;)

@AlexPresso
Copy link

With this option you will install a fork of Alex's Wrapper.

Please note that I won't provide any support to people installing "my" wrapper using another installer.

@darknebular
Copy link

JAJAJAJA
The simplest only.
Don't worry about that...

@darknebular
Copy link

darknebular commented Sep 11, 2022

JUST FINISH The Installer´s Script version 2.3.

Fully tested, fully stable, fully configurable using the Advanced Wrapper.

NOW YOU WILL HAVE: (Only when It´s necessary to activate my wrapper. This means DTS, EAC3 and TrueHD.)

  • In MediaServer DLNA = [1) AAC 5.1 512kbps AND 2) MP3 2.0 256kbps.] (by default) (If exists)
  • In VIDEO-STATION = [1) MP3 2.0 256kbp AND 2) AAC 5.1 512kbps.] (by default)
  • You now can change the 5.1 audio´s codec from AAC 512kbps to AC3* 640kbps independently of its audio´s streams order in VIDEO-STATION and DLNA MediaServer using the configurator tool embedded into the installer.sh.

*(AC3 is more compatible with legacy 5.1 devices).

ADD-ONs FROM 1.16:

  • Tested and working fine in a lot of Synology´s models.
    - Added Multi-Language Support (English, Spanish, Portuguese, French, German, Italian).
  • Aesthetic improvements in the logging of the Wrappers.
  • Adding a ASCII Intro.
  • Added new info texts.
  • Improvements in the AME'S License checker.

Check It out:
Connect using SSH and then:

Enter:
sudo -i

And then:

INSTALL / UNINSTALL:

Enter:
bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s install

Or (for uninstall it...)

Enter:
bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s uninstall

CONFIGURATOR TOOL:

Enter:
bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s config

https://github.com/darknebular/Wrapper_VideoStation

...

Please give a star in my repository if you like my wrapper. Thanks...

BEST REGARDS.

@darknebular
Copy link

test_results

image

@AlexPresso
Copy link

AlexPresso commented Sep 12, 2022

Probably you'd make a good salesman by pointing out what others are missing and adding complex stuff / imaginary features just to show that you have that one more thing.

Still, your comparison is highly biased.
I.e: all those red marks around "checks" are random (and it's kinda funny) because you're not considering implied checks done by the mv -n and cp -n. Even if the console says so, if the file is already present it's not overridden.

Checking for the license is (in my opinion) useless because if you have a real Synology NAS (not a Crackology), you have one when you install AME.

"Logging of the installation / uninstallation process" ?! I won't be sure about that one, you may have to run the script again to check :) and if you mean "storing in a logfile", why would you store any execution log if they're already printed in the console ? patching / unpatching is a one time step, it's like eating space for nothing... Of course I don't do it...

But for the root check and to print all missing dependencies at once, you are right, I'll add it, thanks for the review :)

@KidWar75
Copy link

@AlexPresso don’t feed the troll…
You’re better than that.
He is just a toxic kid who tries to show how big is dick is. Just let him.
In the end, his wrapper seems to be helping some people, and that’s all that matters.

Not that I indulge him, but this project and everything you guys are doing is to make us, plebs, enjoy our NAS even more ;)

Keep up the good work lad!

@darknebular
Copy link

darknebular commented Sep 13, 2022

you have one when you install AME.
why would you store any execution log if they're already printed in the console ?

Because if someone needs my help, I will know what type of wrapper was installed o what kind of configurations were did it.
Of course, I know that you do not care about giving quality in your support and you will not log...

No, there was someone that tried to install my wrapper in a Crackology. If you don't install this license, the correct path to: /var/packages/Codec Pack/target/pack/bin will not be generated.
If you haven't the license, you will be patching links not binaries...I don't think is useless.

In my opinion, trying to uninstall or install something that previously was uninstalled/installed is useless. I know that you prefer a "Here we go guys" script... I prefer check these because I want to ensure that my wrapper will be installed in a perfectly fresh and clean system, you don't care about this...

Please, "imaging" these features too or shut up:

NO, your wrapper CAN'T BE CONFIGURED.
NO, your wrapper hasn't 5.1 support
NO, your installer hasn't multilanguage support

NO, your installer doesn't care to install its wrapper in a changed and dirty system.

Having the AME package properly licensed makes it useless to patch VideoStation and MediaServer paths. You can put there a fucking (sorry) piece of shit (sorry again) with a 0KB dummy file and It still working fine, because all is redirected to the AME binaries.

@KidWar75 what's wrong with you? Enjoy with the MP3 2.0 96 kbps and leave me alone.

@darknebular
Copy link

You can configure this with my wrapper:
image

@darknebular
Copy link

darknebular commented Sep 13, 2022

Perhaps, the people need these screenshots to understand why is better:

VIA VIDEO STATION, PLAYING A MOVIE WITH DTS, EAC3 and TrueHD:

USING DARKNEBULAR'S WRAPPER: 1) MP3 2.0 256 kbps and 2) audio stream AAC 5.1 512kbps (or AC3 5.1 640kbps)

image
image

But I don't want AAC 5.1 512kbps, WELL, NOW YOU CAN CHANGE IT TO AC3 5.1 640 kbps, look:
image

Well, but I am a noob and I am not English speaker and I am not sure what change. WELL, YOU NOW CAN CHANGE THE LANGUAGE, LOOK:
image

AND HAVING THE CONFIGURATOR TOOL IN YOUR LANGUAGE: (Here a example in SPANISH)
image

But I don't want 2 audio streams. WELL YOU CAN USE THE CONFIGURATOR TOOL TO PUT ONLY ONE AUDIO STREAM WITH BETTER PERFORMANCE AND QUALITY THAN THE ALEX'S ONE.

USING ALEX'S WRAPPER: ONLY ONE AUDIO STREAM = MP3 2.0 96 kbps

image

VIA DLNA, PLAYING A MOVIE WITH DTS, EAC3 and TrueHD WHEN IT NEEDS TO BE TRANSCODED:

USING DARKNEBULAR'S WRAPPER: 1) audio stream AAC 5.1 512kbps (or AC3 5.1 640kbps) and 2) MP3 2.0 256 kbps

image

USING ALEX'S WRAPPER: ONLY ONE AUDIO STREAM = MP3 2.0 192 kbps

image

@AlexPresso
Copy link

NO, your wrapper CAN'T BE CONFIGURED.
NO, your wrapper hasn't 5.1 support
NO, your installer hasn't multilanguage support

Yes, I aggree on that but that's pretty all you can compare, everything else like the checks is bullshit and you know it.

He is just a toxic kid who tries to show how big is dick is. Just let him.

Yeah, I'm trying but sometimes I can't when I think about people that may trust these lies

@KidWar75
Copy link

@AlexPresso I feel you pal, but you can't reason someone like him. He will keep on pushing no matter what. He just needs the attention.
Your wrapper may lack some features & stuff, but I'm willing to be patient & wait for your work to be updated ;)

@AlexPresso
Copy link

Thank you for your support, I highly appreciate it :)

I haven't planned to add his features, I'll only focus on bringing gstreamer support and then global optimizing

@KidWar75
Copy link

Seems good to me ;)

@darknebular
Copy link

trust these lies

Exactly what lies?
Please, listen, I don't need any war with you. I am trying to do the best. I don't think that these checks are bullshit, I explained before.
Let the people to choose, if someone is looking for a 5.1 in his Wrapper, or have the possibility of changing some config, well There is my wrapper, if not there is yours. I think that It´s easy to understand it.

I can forget all past if you can, If It's ok for you I will do and then peace.
I don't need to measure my dick with anyone. I have a Wrapper, with a Installer. My wrapper has a strengs and your wrapper I think that too.

Enjoy with this, choose your wrapper and test them.

I only ask you not to underestimate my wrapper and my work, I promise to you do the same.

It´s easy, there are two Wrappers now, let the people choose. And STOP underestimate my wrapper and my work, if not I will can compare a lot of thing with yours.

Regards.

@AlexPresso
Copy link

I only ask you not to underestimate my wrapper and my work, I promise to you do the same.

That I'd never do, but you are when sending these comparison images, not all informations in these are lies, but the file checks I told you about earlier and the fact you say you can play HEVC + [DTS , ...] in all cases. You must specify that Gstreamer is not handled.

@darknebular
Copy link

darknebular commented Sep 13, 2022

In the comparison images I wrote OTHERS not your installer. Why did you think I was talking about your script?
You told about mv -n and cp -n but this checking is done by the O.S. not from your installer.

nevermind, I'm going to smoke the pipe of peace...

Regards.

@darknebular
Copy link

I think if you take all parameters from Gstreamer, parse only the audio ones and quit them, and then you pipe these audio's parameters or arguments to the ffmpeg, It will be able to play DTS,EAC3 and TrueHD with Gstreamer. It only needs to send video to Gstreamer (without error because you don't send audio's codec to gstreamer) and send audio to ffmpeg (without errors because ffmpeg has these audio's codecs).

If someone with a DS21x_Play Synology wants to help me to try this theory I will be thanksfully.

Regards.

@AlexPresso
Copy link

You told about mv -n and cp -n but this checking is done by the O.S. not from your installer.

Everything even a if condition in a script is runned by the OS, not having a if in the script doesn't mean it's not checked, that's what I'm saying. It's implied by the command and without needing it, does the same job than a if condition.

Why did you think I was talking about your script?

I don't see any other installer around... It's not really honest from you to say that...

I did try a lot of things on my DS218Play, the only stable way is to have a SC Gstreamer package, that is on the way.

@darknebular
Copy link

darknebular commented Sep 14, 2022

In the comparision chart put Others installers...
I did these checkers because I want to do a fresh and clean installation everytime. Nothing more...

Don't take it as attack to you.

@darknebular
Copy link

I did try a lot of things on my DS218Play

You tried parse the audio parameters from Gstreamer and converts these to ffmpeg and then pipe both binaries?

It hasn't easy solution...umm

@AlexPresso
Copy link

I did these checkers because I want to do a fresh and clean installation everytime. Nothing more.

I know exactly why you do it. I'm doing it with mv -n and cp -n for the exact same reason. The issue there is not the reason why you check for the files to exist. It's actually that you're lying in your comparison by saying "other installers" are not checking for it.

Don't take it as attack to you.

Man, there only are two installers, if your not attacking me then please tell us on which "other installers" you are basing your comparison...

You tried parse the audio parameters from Gstreamer and converts these to ffmpeg and then pipe both binaries?

Yea, that and multiple other things like patching the VideoStation library with trampoline functions to get rid of GStreamer. I had it working but it had really bad performances unfortunately, these NAS models really needs to rely on the Synology LibOMX, embedded in their GStreamer.

@darknebular
Copy link

No man, I know 5 installers.

@darknebular
Copy link

darknebular commented Sep 15, 2022

Your installer check when the wrapper was installed previously, yes or not?
I think that not, your installer tries to install or uninstall something that was previously installed or uninstalled again and again and...

Yeah, don't worry about it because the command has -n flag, but honestly It's not elegant.
The mine do it:

1663253073573

This isn't a lie.

And here you have a example of other installer

https://git.os-guru.de/philipp-s/videostation-ffmpeg-wrapper-setup-dsm7.1/commit/f549b7c5aa5e4a30a08761a9715248c7a3a616c2?style=split&whitespace=

@darknebular
Copy link

Insist, Don't take it as attack to you.
Thanks.

@darknebular
Copy link

JUST FINISH The Installer´s Script version 2.4.

Fully tested, fully stable, fully configurable using the Advanced Wrapper.

NOW YOU WILL HAVE: (Only when It´s necessary to activate my wrapper. This means DTS, EAC3 and TrueHD.)

  • In MediaServer DLNA = [1) AAC 5.1 512kbps AND 2) MP3 2.0 256kbps.] (by default) (If exists)
  • In VIDEO-STATION = [1) MP3 2.0 256kbp AND 2) AAC 5.1 512kbps.] (by default)
  • You now can change the 5.1 audio´s codec from AAC 512kbps to AC3* 640kbps independently of its audio´s streams order in VIDEO-STATION and DLNA MediaServer using the configurator tool embedded into the installer.sh.

*(AC3 is more compatible with legacy 5.1 devices).

ADD-ONs FROM 2.3:

  • Tested and working fine in a lot of Synology´s models.
  • Save space in the script.
  • Consider the possibility that another installer has made links in CodecPack path. This is applied in the Uninstaller Old.

Check It out:
Connect using SSH and then:

Enter:
sudo -i

And then:

INSTALL / UNINSTALL:

Enter:
bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s install

Or (for uninstall it...)

Enter:
bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s uninstall

CONFIGURATOR TOOL:

Enter:
bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s config

https://github.com/darknebular/Wrapper_VideoStation

...

Please give a star in my repository if you like my wrapper. Thanks...

BEST REGARDS.

@KidWar75
Copy link

@AlexPresso, weirdly, subtitles doesn’t show up anymore on DS Video (iPhone). It’s working well on VideoStation on my PC. Any clue??

@AlexPresso
Copy link

AlexPresso commented Sep 25, 2022

I haven't experienced the issue myself, but I'll try to reproduce it on my android phone, could you open an issue on the repo so I can keep track of it please :)

And so you can give me the logs of this particular movie

@KidWar75
Copy link

I haven't experienced the issue myself, but I'll try to reproduce it on my android phone, could you open an issue on the repo so I can keep track of it please :)

And so you can give me the logs of this particular movie

Not a particular movie, it's all movies/TVshow...
I've deleted & reinstalled DS Video but it's not doing anything :(

@darknebular
Copy link

subtitles doesn’t show up anymore on DS Video (iPhone). It’s working well on VideoStation on my PC. Any clue??

I can see the subtitles perfectly in Windows, in Android, Apple TV, IPAD and in Iphone. I am using my Wrapper, latest VideoStation version.
I have MX Player in mobile installed, have you tried to install all these?

@KidWar75
Copy link

subtitles doesn’t show up anymore on DS Video (iPhone). It’s working well on VideoStation on my PC. Any clue??

I can see the subtitles perfectly in Windows, in Android, Apple TV, IPAD and in Iphone. I am using my Wrapper, latest VideoStation version. I have MX Player in mobile installed, have you tried to install all these?

My girlfriend doesn't have this problem on her iPhone neither...
I have another video player on my iPhone and subtitles are working fine.

It seems this issue affects only my user via DS Video for iPhone : it suddently doesn't show subtitles anymore.
I've tried to resinstall DS Video, change the color of the subs, switch subtitles, ...

I don't know what "event" caused this... :(

@AlexPresso
Copy link

Seems like I also have the issue on my android phone, I'm investigating

@darknebular
Copy link

My girlfriend doesn't have this problem on her iPhone neither...

Ummm It´s weird. Same IOS version in both IPhones?

@KidWar75
Copy link

My girlfriend doesn't have this problem on her iPhone neither...

Ummm It´s weird. Same IOS version in both IPhones?

Nop, she is not up to date on here iOS (I'm tho)

@darknebular
Copy link

I can view the subtitles in the last firmware in iOS using DS-Video and my wrapper.

I am using .SRT subtitles format. What are your format?
Have you try without any wrapper installed?

@darknebular
Copy link

Nop, she is not up to date on here iOS (I'm tho)

I am thinking that your subtitle format is not compatible with the new iOS. Can you activate this option?
image

This will download the subtitles in your movies and It will be compatible with the new iOS.

@KidWar75
Copy link

KidWar75 commented Oct 5, 2022

Nop, she is not up to date on here iOS (I'm tho)

I am thinking that your subtitle format is not compatible with the new iOS. Can you activate this option? image

This will download the subtitles in your movies and It will be compatible with the new iOS.

They are usually embedded in the file (mkv).
Not using .srt much.

@KidWar75
Copy link

KidWar75 commented Oct 5, 2022

I tried with a .srt, same issue :(

@KidWar75
Copy link

KidWar75 commented Oct 7, 2022

@AlexPresso Any clues about the issue on your end ?

@AlexPresso
Copy link

AlexPresso commented Oct 7, 2022

Currently don't have time to look at it. Also I'm asking you again to please open an issue on the repo, it will be easier for you to track progress if any and easier for me aswell because for now I have no tech infos related to your issue, and it's tiring to always ask for it when there's an issue template made for it.

@KidWar75
Copy link

KidWar75 commented Oct 9, 2022

Currently don't have time to look at it. Also I'm asking you again to please open an issue on the repo, it will be easier for you to track progress if any and easier for me aswell because for now I have no tech infos related to your issue, and it's tiring to always ask for it when there's an issue template made for it.

Ye, you're right. Sorry about that.
It's done :)

@darknebular
Copy link

Ye, you're right. Sorry about that.
It's done :)

You are using a patch that is patching a wrong path nowdays...
This is because you will need install in you iOS the DS FILE.
This weird subtitle issue where it won’t find subtitles if the DS File iOS app is not installed on the same device will be present in this escenario.

Please install DS File iOS app in your situation.

@darknebular
Copy link

If you want, you can use my wrapper (the advanced one) and change the audio codec from AAC to AC3 this will fix your problem too.

@KidWar75
Copy link

Ye, you're right. Sorry about that.
It's done :)

You are using a patch that is patching a wrong path nowdays... This is because you will need install in you iOS the DS FILE. This weird subtitle issue where it won’t find subtitles if the DS File iOS app is not installed on the same device will be present in this escenario.

Please install DS File iOS app in your situation.

I already have the DS File app since the beginning unfortunatly...

@AlexPresso
Copy link

And the patch is patching the right paths.

@darknebular
Copy link

darknebular commented Oct 11, 2022

And the patch is patching the right paths.

NO, It was the correct path in the past, nowadays It isn't the ideal path.
For the process jumping and the flow in the internal system, is better patch the codecpack.

@AlexPresso
Copy link

Notice the s into paths, both VideoStation's ffmpeg and CodecPack's are patched.
And if you seem to know the difference between "wrong" and "not ideal", why do you keep using confusing words ? Nevermind I know exactky why.

@AlexPresso
Copy link

By the way, for everyone else in that gist: I'm really sorry that you guys had to handle this whole discussion, but I'm pretty sure it will end today.

For my own sanity, I decided I won't ever take part into this discussion again. I'll continue working on my own, on the wrappers hosted at:

As well as helping and fixing issues, but only in issues posted in the above repositories.

Thanks again to Benjamin Poncet, Vincent Fortier, SynoCommunity and all of you who helped us continue this project.

Best wishes,
Alex'

@darknebular
Copy link

Notice the s into paths, both VideoStation's ffmpeg and CodecPack's are patched.

NO, It's wrong patching VideoStation's ffmpeg and Codecpack's one...

And not ideal patching only VideoStation's ffmpeg.

@darknebular
Copy link

darknebular commented Nov 3, 2022

If you want to try other wrapper:

The Installer´s Script version 2.4. Wrapper with 5.1 and Configurator Tool:

Fully tested, fully stable, fully configurable using the Advanced Wrapper.

NOW YOU WILL HAVE: (Only when It´s necessary to activate my wrapper. This means DTS, EAC3 and TrueHD.)

  • In MediaServer DLNA = [1) AAC 5.1 512kbps AND 2) MP3 2.0 256kbps.] (by default) (If exists)
  • In VIDEO-STATION = [1) MP3 2.0 256kbp AND 2) AAC 5.1 512kbps.] (by default)
  • You now can change the 5.1 audio´s codec from AAC 512kbps to AC3* 640kbps independently of its audio´s streams order in VIDEO-STATION and DLNA MediaServer using the configurator tool embedded into the installer.sh.

*(AC3 is more compatible with legacy 5.1 devices).

ADD-ONs FROM 2.3:

  • Tested and working fine in a lot of Synology´s models.
  • Save space in the script.
  • Consider the possibility that another installer has made links in CodecPack path. This is applied in the Uninstaller Old.

Check It out:
Connect using SSH and then:

Enter:
sudo -i

And then:

INSTALL / UNINSTALL:

Enter:
bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s install

Or (for uninstall it...)

Enter:
bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s uninstall

CONFIGURATOR TOOL:

Enter:
bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s config

https://github.com/darknebular/Wrapper_VideoStation

...

Please give a star in my repository if you like my wrapper. Thanks...

BEST REGARDS.

@KidWar75
Copy link

KidWar75 commented Nov 7, 2022

If you want to try other wrapper:

The Installer´s Script version 2.4. Wrapper with 5.1 and Configurator Tool:

Fully tested, fully stable, fully configurable using the Advanced Wrapper.

NOW YOU WILL HAVE: (Only when It´s necessary to activate my wrapper. This means DTS, EAC3 and TrueHD.)

  • In MediaServer DLNA = [1) AAC 5.1 512kbps AND 2) MP3 2.0 256kbps.] (by default) (If exists)
  • In VIDEO-STATION = [1) MP3 2.0 256kbp AND 2) AAC 5.1 512kbps.] (by default)
  • You now can change the 5.1 audio´s codec from AAC 512kbps to AC3* 640kbps independently of its audio´s streams order in VIDEO-STATION and DLNA MediaServer using the configurator tool embedded into the installer.sh.

*(AC3 is more compatible with legacy 5.1 devices).

ADD-ONs FROM 2.3:

  • Tested and working fine in a lot of Synology´s models.
  • Save space in the script.
  • Consider the possibility that another installer has made links in CodecPack path. This is applied in the Uninstaller Old.

Check It out: Connect using SSH and then:

Enter: sudo -i

And then:

INSTALL / UNINSTALL:

Enter: bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s install

Or (for uninstall it...)

Enter: bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s uninstall

CONFIGURATOR TOOL:

Enter: bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s config

https://github.com/darknebular/Wrapper_VideoStation

...

Please give a star in my repository if you like my wrapper. Thanks...

BEST REGARDS.

FYI, I tried with your wrapper as well. Doesn't work either.

@darknebular
Copy link

Doesn't work either.

It´s working perfectly using ffmpeg.

You must be the unique person in this world that this doesn´t work. Can you tell me why do you say that my wrapper is not working? Can you send me the log file? What kind of movie has you tried? What's exactly doesn't work?

@KidWar75
Copy link

KidWar75 commented Nov 7, 2022

It's not a matter of ffmpeg.
It's just not working on my iPhone 14pro with the latest iOS.
This bug appeared when I updated to the last iOS. It worked perfectly before.
Apparently it's a VS bug and not related to Alex's or your wrapper.

@darknebular
Copy link

darknebular commented Nov 7, 2022

Apparently it's a VS bug and not related to Alex's or your wrapper.

Yeah, I think so, I think that this problem is not with these wrappers.

Regards.

@LiloBzH
Copy link

LiloBzH commented Nov 8, 2022

Hi

Wraper are broken with last version (3.0.5) of video station isn t it ?

@pjaudeie
Copy link

pjaudeie commented Nov 8, 2022

So for reference, I have installed the wrapper (many thanks darknebular) per instruction with no issue and tested config changes with no issues occurring. My system installation is as below:
Model DS2413+
DSM 7.1.1-42962 Update 2
Video Station 3.0.5-2503
Media Server 2.0.3-3105
Advanced Media Extensions 3.0.1-2004
ffmpeg (Vincent Fortier @ SynoCommunity) 4.4.2-46

@darknebular
Copy link

Hi

Wraper are broken with last version (3.0.5) of video station isn t it ?

You will need to reinstall wrapper after of upgrade the Video Station. In my installer is the "I" option, and then, write "Y or Yes" in order to uninstall the previously installed wrapper and then the installer will do a clean installation.

Best regards.

@darknebular
Copy link

So for reference, I have installed the wrapper (many thanks darknebular) per instruction with no issue and tested config changes with no issues occurring

You are welcome. Thanks for the feedback.

@Gideon75
Copy link

Gideon75 commented Nov 25, 2022

work fine with videostation on web browser, but not in the firestik (HVEC file)
"Try to install a third -party reader"
any solution for Frestik (Frestik 4k and 4K Max?
Thanks

@darknebular
Copy link

work fine with videostation on web browser, but not in the firestik (HVEC file)

Can you send the log file in /tmp/wrapper_ffmpeg.log ?
Or you can send me the result of this command:

cat /tmp/wrapper_ffmpeg.log

Regards.

@darknebular
Copy link

H265 It´s not oficially supported in FireStick:

image

@darknebular
Copy link

any solution for Frestik (Frestik 4k and 4K Max?

Your solution is install in your FireStick the MX Player.
Here you can view the steps for install this in your firestick:
https://troypoint.com/mx-player/

Best Regards.

@Gideon75
Copy link

Gideon75 commented Nov 29, 2022

Firestik 4k
Supported format:

Video: Dolby Vision, HDR10, HDR10+, HLG, H.265, H.264, VP9. Audio: AAC-LC, AC3, eAC3 (Dolby Digital Plus), FLAC, MP3, PCM/Wave, Vorbis, Dolby Atmos (EC3_JOC). Foto: JPEG, PNG, GIF, BMP.

Supported resolution

2160p, 1080p e 720p fino a 60 fps.

Thanks

@pjaudeie
Copy link

pjaudeie commented Nov 29, 2022

(Commenting as an interested observer here, having had past involvement in automated STB testing.....)
Rather than throwing about spec's in comments with no common reference, just to keep things well grounded, here is the official Amazon 'Device Specification' reference page for all Fire TV devices followed by the Fire TV Stick 4K Max:
https://developer.amazon.com/docs/fire-tv/device-specifications.html
https://developer.amazon.com/docs/fire-tv/device-specifications-fire-tv-streaming-media-player.html
Information more technical than what is offerred by these pages is not readily available.

@darknebular
Copy link

Have you tried the MX Player?

@patgit78
Copy link

i have an issue
try to uninstall/reinstall videostation / codec pack / ffmpeg

still get this error : Decoder (codec eac3) not found for input stream #0:0

@darknebular
Copy link

still get this error : Decoder (codec eac3) not found for input stream #0:0

It's normal, It isn't a error, then the wrapper finally will change to other methods like:
PIPE V_WRAP-A_WRAP-MS
or
PIPE V_ORIG-A_WRAP-VS

and so on.

Have you any problem in order to see a movie with this codec?

Best regards.

@patgit78
Copy link

still get this error : Decoder (codec eac3) not found for input stream #0:0

It's normal, It isn't a error, then the wrapper finally will change to other methods like: PIPE V_WRAP-A_WRAP-MS or PIPE V_ORIG-A_WRAP-VS

and so on.

Have you any problem in order to see a movie with this codec?

Best regards.

It worked before the update of DSM I think
Workaround using Mxplayer

@darknebular
Copy link

darknebular commented Dec 16, 2022

Workaround using Mxplayer

The Wrapper must be re-installed every time that you update DSM, CodecPack, Video Station or Media Server.
Have you try to re-install the wrapper?
Best Regards.

@patgit78
Copy link

Workaround using Mxplayer

The Wrapper must be re-installed every time that you update DSM, CodecPack, Video Station or Media Server. Have you try to re-install the wrapper? Best Regards.

Yes several times !

@darknebular
Copy link

darknebular commented Dec 22, 2022

Exactly What is your error?
Can you send me the result of this command?

cat /tmp/wrapper_ffmpeg.log

@patgit78
Copy link

patgit78 commented Dec 22, 2022

Exactly What is your error? Can you send me the result of this command?

cat /tmp/wrapper_ffmpeg.log

error : Decoder (codec eac3) not found for input stream #0:0

2022-12-22 18:12:52 - FFM27877 - *** PROCESS START REV AME_12.3.6 DS918+ (apollolake) PID 27877 ***
2022-12-22 18:12:52 - FFM27877 - MOVIE = /volume1/data/Films_4K/test.mkv
2022-12-22 18:12:52 - FFM27877 - VCODEC = hevc (Main 10)
2022-12-22 18:12:52 - FFM27877 - ACODEC = eac3
2022-12-22 18:12:52 - FFM27877 - PARAMVS =
2022-12-22 18:12:52 - FFM27877 - = -ss 0.000 -vaapi_device /dev/dri/renderD128 -hwaccel vaapi -hwaccel_output_format vaapi -noautorotate -i /volume1/data/F
2022-12-22 18:12:52 - FFM27877 - = ilms_4K/test.mkv -r 24 -vcodec h264
2022-12-22 18:12:52 - FFM27877 - = _vaapi -vf format=nv12|vaapi,hwupload,scale_vaapi=w=1920:h=1024,scale_vaapi=format=nv12 -vsync 2 -bf 0 -vb 15000000 -aco
2022-12-22 18:12:52 - FFM27877 - = dec libmp3lame -ab 128K -ac 2 -f ssegment -pix_fmt yuv420p -segment_format mpegts -segment_list_type m3u8 -hls_seek_time
2022-12-22 18:12:52 - FFM27877 - = 0 -segment_time 5 -segment_time_delta 0.000 -segment_start_number 00000 -individual_header_trailer 0 -avoid_negative_ts
2022-12-22 18:12:52 - FFM27877 - = 0 -break_non_keyframes 1 -max_muxing_queue_size 1024 -map 0:3 -map 0:0 /tmp/VideoStation/HLS/2a6bbe898169a7aa9f81f5e771
2022-12-22 18:12:52 - FFM27877 - = 26cc10_CHilCwqg/slice-%05d.ts
2022-12-22 18:12:52 - FFM27877 - MODE = ORIG-VSMS
2022-12-22 18:12:52 - FFM27877 - FFMPEG = /var/packages/CodecPack/target/pack/bin/ffmpeg41.orig
2022-12-22 18:12:52 - FFM27877 - PARAMWP =
2022-12-22 18:12:52 - FFM27877 - = -ss 0.000 -vaapi_device /dev/dri/renderD128 -hwaccel vaapi -hwaccel_output_format vaapi -noautorotate -i /volume1/data/F
2022-12-22 18:12:52 - FFM27877 - = ilms_4K/test.mkv -r 24 -vcodec h264
2022-12-22 18:12:52 - FFM27877 - = _vaapi -vf format=nv12|vaapi,hwupload,scale_vaapi=w=1920:h=1024,scale_vaapi=format=nv12 -vsync 2 -bf 0 -vb 15000000 -aco
2022-12-22 18:12:52 - FFM27877 - = dec libmp3lame -ab 128K -ac 2 -f ssegment -pix_fmt yuv420p -segment_format mpegts -segment_list_type m3u8 -hls_seek_time
2022-12-22 18:12:52 - FFM27877 - = 0 -segment_time 5 -segment_time_delta 0.000 -segment_start_number 00000 -individual_header_trailer 0 -avoid_negative_ts
2022-12-22 18:12:52 - FFM27877 - = 0 -break_non_keyframes 1 -max_muxing_queue_size 1024 -map 0:3 -map 0:0 /tmp/VideoStation/HLS/2a6bbe898169a7aa9f81f5e771
2022-12-22 18:12:52 - FFM27877 - = 26cc10_CHilCwqg/slice-%05d.ts
2022-12-22 18:12:52 - FFM27877 - CHILDPID = 27965
2022-12-22 18:12:52 - FFM27877 - *** CHILD END ***
2022-12-22 18:12:52 - FFM27877 - STDOUT =
2022-12-22 18:12:52 - FFM27877 - = NUMBER_OF_FRAMES: 187362
2022-12-22 18:12:52 - FFM27877 - = NUMBER_OF_BYTES : 14554099021
2022-12-22 18:12:52 - FFM27877 - = _STATISTICS_WRITING_APP: mkvmerge v64.0.0 ('Willows') 64-bit
2022-12-22 18:12:52 - FFM27877 - = _STATISTICS_WRITING_DATE_UTC: 2022-08-22 22:37:17
2022-12-22 18:12:52 - FFM27877 - = _STATISTICS_TAGS: BPS DURATION NUMBER_OF_FRAMES NUMBER_OF_BYTES
2022-12-22 18:12:52 - FFM27877 - = Stream #0:4(eng): Audio: eac3, 48000 Hz, 5.1
2022-12-22 18:12:52 - FFM27877 - = Metadata:
2022-12-22 18:12:52 - FFM27877 - = BPS : 640000
2022-12-22 18:12:52 - FFM27877 - = DURATION : 02:10:14.592000000
2022-12-22 18:12:52 - FFM27877 - = NUMBER_OF_FRAMES: 244206
2022-12-22 18:12:52 - FFM27877 - = NUMBER_OF_BYTES : 625167360
2022-12-22 18:12:52 - FFM27877 - = _STATISTICS_WRITING_APP: mkvmerge v64.0.0 ('Willows') 64-bit
2022-12-22 18:12:52 - FFM27877 - = _STATISTICS_WRITING_DATE_UTC: 2022-08-22 22:37:17
2022-12-22 18:12:52 - FFM27877 - = _STATISTICS_TAGS: BPS DURATION NUMBER_OF_FRAMES NUMBER_OF_BYTES
2022-12-22 18:12:52 - FFM27877 - = Stream mapping:
2022-12-22 18:12:52 - FFM27877 - = Stream #0:3 -> #0:0 (hevc (native) -> h264 (h264_vaapi))
2022-12-22 18:12:52 - FFM27877 - = Stream #0:0 -> #0:1 (? (?) -> mp3 (libmp3lame))
2022-12-22 18:12:52 - FFM27877 - = Decoder (codec eac3) not found for input stream #0:0
2022-12-22 18:12:52 - FFM27877 - MODE = PIPE V_ORIG-A_WRAP-VS
2022-12-22 18:12:52 - FFM27877 - FFMPEG1 = /var/packages/CodecPack/target/pack/bin/ffmpeg41.orig
2022-12-22 18:12:52 - FFM27877 - FFMPEG2 = /var/packages/ffmpeg/target/bin/ffmpeg
2022-12-22 18:12:52 - FFM27877 - PARAM1 =
2022-12-22 18:12:52 - FFM27877 - = -ss 0.000 -noaccurate_seek -vaapi_device /dev/dri/renderD128 -hwaccel vaapi -hwaccel_output_format vaapi -noautorotate -
2022-12-22 18:12:52 - FFM27877 - = i /volume1/data/Films_4K/test.mkv -
2022-12-22 18:12:52 - FFM27877 - = r 24 -vcodec h264_vaapi -vf format=nv12|vaapi,hwupload,scale_vaapi=w=1920:h=1024,scale_vaapi=format=nv12 -vsync 2 -bf 0
2022-12-22 18:12:52 - FFM27877 - = -vb 15000000 -acodec copy -f mpegts -pix_fmt yuv420p -map 0:3 -map 0:0 -bufsize 8192k pipe:1
2022-12-22 18:12:52 - FFM27877 - PARAM2 =
2022-12-22 18:12:52 - FFM27877 - = -analyzeduration 10000000 -vaapi_device /dev/dri/renderD128 -hwaccel vaapi -hwaccel_output_format vaapi -noautorotate -i
2022-12-22 18:12:52 - FFM27877 - = pipe:0 -map 0:0 -map 0:1 -map 0:1 -r 24 -vcodec copy -vsync 2 -bf 0 -vb 15000000 -c:a:0 libmp3lame -c:a:1 libfdk_aac -b
2022-12-22 18:12:52 - FFM27877 - = :a:0 256k -b:a:1 512k -ac:1 2 -ac:2 6 -f ssegment -pix_fmt yuv420p -segment_format mpegts -segment_list_type m3u8 -hls_s
2022-12-22 18:12:52 - FFM27877 - = eek_time 0 -segment_time 5 -segment_time_delta 0.000 -segment_start_number 00000 -individual_header_trailer 0 -avoid_neg
2022-12-22 18:12:52 - FFM27877 - = ative_ts 0 -break_non_keyframes 1 -max_muxing_queue_size 1024 /tmp/VideoStation/HLS/2a6bbe898169a7aa9f81f5e77126cc10_CHi
2022-12-22 18:12:52 - FFM27877 - = lCwqg/slice-%05d.ts
2022-12-22 18:12:52 - FFM27877 - CHILDPID = 27993
2022-12-22 18:13:03 - FFM27877 - *** KILLCHILD ***
2022-12-22 18:13:03 - FFM27877 - *** CHILD END ***
2022-12-22 18:13:03 - FFM27877 - *** PROCESS END ***

@darknebular
Copy link

darknebular commented Dec 23, 2022

error : Decoder (codec eac3) not found for input stream #0:0

As I told you, It's NORMAL. It's because the wrapper tries to use native ffmpeg (ORIG-VSMS) first of all, but this ffmpeg hasn't got eac3 codec, due to this the wrapper then tries with the ffmpeg of the community using ffmpeg from native for the video stream only, this is called PIPE V_ORIG-A_WRAP-VS.

THYERE ISN'T ANY ERROR., It's NORMAL!!!

The movie was played correctly. When you update the CodecPack, Video Station, DSM you must to reinstall the wrapper. Nothing more...

Don't worry about this "error". It's fully normal.

Regards.

@darknebular
Copy link

The Installer´s Script version 2.9. Wrapper with 5.1 and Configurator Tool:

Fully tested, fully stable, fully configurable using the Advanced Wrapper.

NOW YOU WILL HAVE: (Only when It´s necessary to activate my wrapper. This means DTS, EAC3 and TrueHD.)

  • In MediaServer DLNA = [1) AAC 5.1 512kbps AND 2) MP3 2.0 256kbps.] (by default) (If exists)
  • In VIDEO-STATION = [1) MP3 2.0 256kbp AND 2) AAC 5.1 512kbps.] (by default)
  • You now can change the 5.1 audio´s codec from AAC 512kbps to AC3* 640kbps independently of its audio´s streams order in VIDEO-STATION and DLNA MediaServer using the configurator tool embedded into the installer.sh.

*(AC3 is more compatible with legacy 5.1 devices).

ADD-ONs FROM 2.4:

  • Tested and working fine in a lot of Synology´s models.
  • Fixed a bug in the Uninstallation process. Improvements in checks in the Uninstallation for older Wrappers.
  • Added a Flag for automatic installation in the case that the Wrapper was installed previously and you don't want to write YES for uninstall the older Wrapper.
  • Save space in the Installer script in some function that mustn't be translated.
  • Fixed a bug when you are in 7.0.X the scripts doesn't take the conditional correctly in check_versions fuction.
  • Change the injectors for the new Wrapper's version.

Check It out:
Connect using SSH and then:

Enter:
sudo -i

And then:

INSTALL / UNINSTALL:

Enter:
bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s install

Or (for uninstall it...)

Enter:
bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s uninstall

CONFIGURATOR TOOL:

Enter:
bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s config

https://github.com/darknebular/Wrapper_VideoStation

...

Please give a star in my repository if you like my wrapper. Thanks...

BEST REGARDS.

@patgit78
Copy link

patgit78 commented Dec 23, 2022

error : Decoder (codec eac3) not found for input stream #0:0

As I told you, It's NORMAL. It's because the wrapper tries to use native ffmpeg (ORIG-VSMS) first of all, but this ffmpeg hasn't got eac3 codec, due to this the wrapper then tries with the ffmpeg of the community using ffmpeg from native for the video stream only, this is called PIPE V_ORIG-A_WRAP-VS.

THYERE ISN'T ANY ERROR., It's NORMAL!!!

The movie was played correctly. When you update the CodecPack, Video Station, DSM you must to reinstall the wrapper. Nothing more...

Don't worry about this "error". It's fully normal.

Regards.

previously it was working !
i have something to do ???

@darknebular
Copy link

darknebular commented Dec 23, 2022

i have something to do ???

NOT, this "error" isn't a error. Always was there. But in scpt 2.x I added some additional lines in tail command and now is showed in the log file.
I can see that you can play the movie,, the Wrapper is working fine and changing to other methods.
You always can use the Simplest wrapper, and you will not see this "error", but you will loose the 5.1 transcoding of these codecs, loose the multi-audio's streams, loose the possibility to do a configuration in the wrapper and never will be using the native ffmpeg binary.

IT'S NOT A ERROR REALLY.

Thanks,

best regards.

@patgit78
Copy link

reinstalled the Simplest wrapper, and it doesn't work

@darknebular
Copy link

reinstalled the Simplest wrapper, and it doesn't work

Please, could you tell me exactly what is not working?

@patgit78
Copy link

patgit78 commented Dec 25, 2022

reinstalled the Simplest wrapper, and it doesn't work

Please, could you tell me exactly what is not working?

try to read mkv
Audio : EAC3 6Ch
video : hevc 4K

few weeks ago, i could see this mkv

@darknebular
Copy link

darknebular commented Dec 25, 2022

Well, you told me about a "error" in the logs that tells something like that:
"error : Decoder (codec eac3) not found for input stream #0:0"
And not that you can't play a movie 4k with EAC3 5.1. I told you that this "error" isn't a error really.

Now, using a DS918+ (same model that you have), with DSM 7.1.1 (Same DSM like you), trying with a movie 4k with HEVC and EAC3 5.1.
image
image
image

Using a Browser via Video Station: (PERFECT)
image

Using a Android with MX-Player installed: (PERFECT) (the two audio's streams working perfectly)
image
image

Using a 1080p TV via Chromecast Gen.2 and launching via Video Station: (PERFECT)
image

Using a VLC as DLNA Client in a PC: (PERFECT) (the two audio's streams working perfectly using transcodification)
image

Using Sony, Samsung, LG, Panasonic using their native's DLNA Clients: (PERFECT)

In your logs that you sended to me from the Advanced Wrapper, I can see that you can play this movie. Only show a "error" that IT ISN'T A ERROR.

### All is working fine. As you can see.

Regards.

@Redcliff67
Copy link

This patch did not work for me. But the alexpresso version did. Not saying one is better that the other, just what worked for me. Running 1522+, fully up to date. I tried running the log command, cat /tmp/wrapper_ffmpeg.log. But my logs did not look like those above. Real weird. After installing, I tried the config command and the info command and it returned that I did not have it install, so I selected the option to install. Then it said I had an old version would I like to uninstall it first. Yes. And it just kept going like that.

I would be happy to try it again at a later time and provide feedback if desired. Thanks for the hard work.

@darknebular
Copy link

It's possible that you had another changes and due to this doesn't works.

If you try to re-install it. If you haven't this log file or if the config menu doesn't work It's because you haven't it installed correctly. Have you try to install the Simplest one? It's the same than Alex Presso...

Can you send me the log file?

Best regards.

@kkman466
Copy link

hi darknebular

i have a problem

====================FFMPEG WRAPPER INSTALLER FOR DSM 7.0 and above by Dark Nebular.====================
====================This Wrapper Installer is only avalaible for DSM 7.0 and above only====================

FFMPEG WRAPPER INSTALLER version: SCPT_2.9
====================FFMPEG WRAPPER INSTALLER FOR DSM 7.0 and above by Dark Nebular.====================
====================This Wrapper Installer is only avalaible for DSM 7.0 and above only====================

FFMPEG WRAPPER INSTALLER version: SCPT_2.9

==================== Wrapper for VideoStation and DLNA MediaServer for DTS, EAC3 and TrueHD with transcoding to AAC 5.1: ====================
Synology VideoStation and MediaServer ffmpeg wrapper with DTS, EAC3 and TrueHD support.
It enables hardware transcoding from Synology's ffmpeg for video and transcoding DTS, HEVC, EAC3, AAC, True HD from the ffmpeg of the SynoCommunity.

When the Wrapper needs to transcoding you will have 2 audio's streams from the SAME track:

  • In DLNA MediaServer = [1) AAC 5.1 512kbps AND 2) MP3 2.0 256kbps.] (by default)
  • In VIDEO-STATION = [1) MP3 2.0 256kbp AND 2) AAC 5.1 512kbps.] (by default)*
    *(For Chromecast or Google TV or other clients that don´t accept 5.1 AAC neither multi audio's stream support).

Now, You can change the 5.1 audio´s codec from AAC 512kbps to AC3 640kbps independently of its audio´s streams order in VIDEO-STATION and DLNA MediaServer
using the Configurator TOOL embedded into the Installer.
(AC3 is more compatible with legacy 5.1 devices).

Works fine the OffLine transcoding and the streaming of tipical extensions like: MKV, MP4, AVI... Works fine the thumbnails in VideoStation.

The latest version is 12.2.5 for DSM 7.0 and 12.3.6 for DSM 7.1 and above.
You will have full control of each Audio's codecs parameter using the Configuration TOOL for the Advanced Wrapper Mode. The only Wrapper of Internet with 5.1 AAC support and with a Configurator TOOL.

============================================================ ¡¡¡¡¡ENJOY!!!!! ============================================================

You have ALL necessary packages Installed, GOOD.
[2023-03-25 12:05:01] ERROR: YOU HAVEN'T THE LICENCE LOADED in Advanced Media Extension package. Please, LOAD this licence and try again with the Installer.

@darknebular
Copy link

darknebular commented Mar 27, 2023

You need to load the license in AME:
image

And then try to transcode something in order to activate this license.

When you have the AME license loaded and activated, you will be able to install the wrapper without errors.

Best regards.

@kkman466
Copy link

kkman466 commented Mar 27, 2023

@darknebular
Copy link

hi darknebular

i ask synology support https://kb.synology.com/en-us/DSM/tutorial/Why_cant_I_play_AAC_encoded_files

With my wrapped installed you will be able to transcode to AAC audio's streams.

Best reagards.

@darknebular
Copy link

darknebular commented Mar 27, 2023

I have one 918+ in an one LAN with this exact version and the AAC is working fine:
image

The wrapper is transcoding to AAC 5.1 format without problems.

@darknebular
Copy link

try to transcode something in order to activate this license.

Don't worry about the AAC audio codec, this will be fix with my wrapper. Please load the license in the AME and activate it playing or transcoding something in Video Station for example and then you will be able to install my wrapper.

Regards.

@kkman466
Copy link

I have one 415+ no aac

415
AME

@darknebular
Copy link

OK activate it playing a movie that needs to be transcoded and this license will be activated.
Then, try again with the installer.

@kkman466
Copy link

i try to install
bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")"

it still show
You have ALL necessary packages Installed, GOOD.
[2023-03-25 12:05:01] ERROR: YOU HAVEN'T THE LICENCE LOADED in Advanced Media Extension package. Please, LOAD this licence and try again with the Installer.

@darknebular
Copy link

Please, have you try to transcode something in order to activate the AME's license?

@kkman466
Copy link

Please, have you try to transcode something in order to activate the AME's license?

ok thanks

@darknebular
Copy link

Please, have you try to transcode something in order to activate the AME's license?

ok thanks

It means that It's working now?

@kkman466
Copy link

Please, have you try to transcode something in order to activate the AME's license?

ok thanks

It means that It's working now?

no
I open the AME package, but there is no display of asking you to log in to your Synology account
I request synology support

@darknebular
Copy link

Please, have you try to transcode something in order to activate the AME's license?

ok thanks

It means that It's working now?

no I open the AME package, but there is no display of asking you to log in to your Synology account I request synology support

Your license in AME looks like that It's loaded, but you need to activate it using the transcoding in Video Station, When you activate this, the DSM will populate the complete path in /var/packages/CodecPack/target/pack/bin

The installer checks if there is this file:

/usr/syno/etc/codec/activation.conf

And checks if there is a True there, if there is a False into this file, then It's because you haven't activated the license.

Regards.

@kkman466
Copy link

i don't have this file /usr/syno/etc/codec/activation.conf

11111111

@darknebular
Copy link

darknebular commented Mar 28, 2023

i don't have this file /usr/syno/etc/codec/activation.conf

11111111

It's not really loaded or activated your AME's license...

If I were you, I will try this, unistall the AME package and then try to install again this package. Until you haven't the license loaded and activated the path (/var/packages/CodecPack/target/pack/bin) will not be created. This is the correct path for the binary in 7.1.X

@kkman466
Copy link

i don't have this file /usr/syno/etc/codec/activation.conf
11111111

It's not really loaded or activated...

I will try, unistall the AME package and then try to install again this package. Until you haven't the license loaded and activated the path (/var/packages/CodecPack/target/pack/bin) will not create. This is the correct path for the binary in 7.1.X

I installed and removed AME, but it doesn't open AME
the files it generates
擷取

@darknebular
Copy link

@darknebular
Copy link

darknebular commented Mar 28, 2023

i don't have this file /usr/syno/etc/codec/activation.conf
11111111

It's not really loaded or activated...
I will try, unistall the AME package and then try to install again this package. Until you haven't the license loaded and activated the path (/var/packages/CodecPack/target/pack/bin) will not create. This is the correct path for the binary in 7.1.X

I installed and removed AME, but it doesn't open AME the files it generates 擷取

when you load and ACTIVATE the AME's license, the binaries will be in: /var/packages/CodecPack/target/pack/bin

@kkman466
Copy link

kkman466 commented Mar 28, 2023

@kkman466 Check it out this post on reddit: https://www.reddit.com/r/Xpenology/comments/dfhaug/cat_usrsynoetccodecactivationconf_no_such_file_or/

Regards.
I have fixed this problem
I installed synology photo, then placed the mp4 file to play
It generates activation.conf

@darknebular
Copy link

GREAT!!!

Now you will be able to install without problems my Wrapper.

Best regards.

@kkman466
Copy link

Yes, that's right
Thanks for your help

@darknebular
Copy link

@kkman466 please delete you image, the token could be used for others...

Regards.

@kkman466
Copy link

@kkman466 please delete you image, the token could be used for others...

Regards.

ok

@martvard
Copy link

First of all, thank you very much for your amazing work on this wrapper.

I do have a problem. I dont get the different audio streams as I should? I can play videos in video station with dts now (not working before i installed the wrapper) but it says it is dts. No transcoding? No transcoding in vlc over upnp either or when I connect my tv via media server.

The installation seems to have work out well though. Maybe the failure can be that AME is version 3.0.1-2004 with codec version 1.0.0-00001.

I am a real newbie into this and it can be some easy thing that i have missed.

@darknebular
Copy link

darknebular commented Apr 12, 2023

Hello,

First of all, my Wrapper only transcodes when it's 100% necessary and will do this:

  1. In Chromecast and VideoStation using a browser: 1 stream is 256Kbps MP3 2.0 and second stream It's 512kbps AAC 5.1
  2. In Media server or DLNA: 1 stream will be 5.1 AAC 512 kbps and second stream 2.0 MP3 256 kbps.

If you have DTS codecs on your PC using VLC or if your TV has DTS codec then you will be able to play DTS now but without any changes or transcoding to these two audio streams.
If your TV hasn't DTS codecs you will be receiving the 2 audio streams, then, It's perfectly normal your behavior.

Can you send me the result of this command:
tail -n 200 -f /tmp/wrapper_ffmpeg.log

Regards.

@darknebular
Copy link

You can try to force the transcoding configuring these options in Media Server:
image

Regards.

@darknebular
Copy link

I am a real newbie into this and it can be some easy thing that i have missed.

I think that in DTS, EAC3 and TrueHD the Wrapper must be activated and then having too the two audio streams. I think that if you send me the log I will can see the problem

@martvard
Copy link

This is what i get with the tail -n 200 -f /tmp/wrapper_ffmpeg.log command, using video station on PC. I checked the same command when trying to play the video on TV and nothing show up. TV says something like "video doesnt support audio"

2023-04-13 00:26:51 - FFM21611 - *** PROCESS START REV AME_12.3.6 DS220+ (gemini lake) PID 21611 ***
2023-04-13 00:26:51 - FFM21611 - MOVIE = /volume1/test/sample-Planet Earth II S01E02 HEVC 2160p UHD BluRay HDR DTSHD5.1-DDR.mkv
2023-04-13 00:26:51 - FFM21611 - VCODEC = hevc (Main 10)
2023-04-13 00:26:51 - FFM21611 - ACODEC = dts
2023-04-13 00:26:51 - FFM21611 - PARAMVS =
2023-04-13 00:26:51 - FFM21611 - = -ss 0.000 -vaapi_device /dev/dri/ren derD128 -hwaccel vaapi -hwaccel_output_format vaapi -noautorotate -i /volume1/te st/s
2023-04-13 00:26:51 - FFM21611 - = ample-Planet Earth II S01E02 HEVC 21 60p UHD BluRay HDR DTSHD5.1-DDR.mkv -r 24 -vcodec h264_vaapi -vf format=nv12|vaa pi,h
2023-04-13 00:26:51 - FFM21611 - = wupload,scale_vaapi=w=1920:h=1072,sc ale_vaapi=format=nv12 -vsync 2 -bf 0 -vb 15000000 -acodec libmp3lame -ab 128K -a c 2
2023-04-13 00:26:51 - FFM21611 - = -f ssegment -pix_fmt yuv420p -segmen t_format mpegts -segment_list_type m3u8 -hls_seek_time 0 -segment_time 5 -segmen t_ti
2023-04-13 00:26:51 - FFM21611 - = me_delta 0.000 -segment_start_number 00000 -avoid_negative_ts 0 -break_non_keyframes 1 -max_muxing_queue_size 1024 - map
2023-04-13 00:26:51 - FFM21611 - = 0:0 -map 0:1 /tmp/VideoStation/HLS/3 fcad3c5c5704ad739a236b93a6db7d3_qBb3AI0I/slice-%05d.ts
2023-04-13 00:26:51 - FFM21611 - MODE = ORIG-VSMS
2023-04-13 00:26:51 - FFM21611 - FFMPEG = /var/packages/CodecPack/target/pack/ bin/ffmpeg41.orig
2023-04-13 00:26:51 - FFM21611 - PARAMWP =
2023-04-13 00:26:51 - FFM21611 - = -ss 0.000 -vaapi_device /dev/dri/ren derD128 -hwaccel vaapi -hwaccel_output_format vaapi -noautorotate -i /volume1/te st/s
2023-04-13 00:26:51 - FFM21611 - = ample-Planet Earth II S01E02 HEVC 21 60p UHD BluRay HDR DTSHD5.1-DDR.mkv -r 24 -vcodec h264_vaapi -vf format=nv12|vaa pi,h
2023-04-13 00:26:51 - FFM21611 - = wupload,scale_vaapi=w=1920:h=1072,sc ale_vaapi=format=nv12 -vsync 2 -bf 0 -vb 15000000 -acodec libmp3lame -ab 128K -a c 2
2023-04-13 00:26:51 - FFM21611 - = -f ssegment -pix_fmt yuv420p -segmen t_format mpegts -segment_list_type m3u8 -hls_seek_time 0 -segment_time 5 -segmen t_ti
2023-04-13 00:26:51 - FFM21611 - = me_delta 0.000 -segment_start_number 00000 -avoid_negative_ts 0 -break_non_keyframes 1 -max_muxing_queue_size 1024 - map
2023-04-13 00:26:51 - FFM21611 - = 0:0 -map 0:1 /tmp/VideoStation/HLS/3 fcad3c5c5704ad739a236b93a6db7d3_qBb3AI0I/slice-%05d.ts
2023-04-13 00:26:51 - FFM21611 - CHILDPID = 21660
2023-04-13 00:26:51 - FFM21611 - *** CHILD END ***
2023-04-13 00:26:51 - FFM21611 - STDOUT =
2023-04-13 00:26:51 - FFM21611 - = BPS : 5896
2023-04-13 00:26:51 - FFM21611 - = BPS-eng : 5896
2023-04-13 00:26:51 - FFM21611 - = DURATION : 00:00:22.711 000000
2023-04-13 00:26:51 - FFM21611 - = DURATION-eng : 00:00:22.711 000000
2023-04-13 00:26:51 - FFM21611 - = NUMBER_OF_FRAMES: 4
2023-04-13 00:26:51 - FFM21611 - = NUMBER_OF_FRAMES-eng: 4
2023-04-13 00:26:51 - FFM21611 - = NUMBER_OF_BYTES : 16739
2023-04-13 00:26:51 - FFM21611 - = NUMBER_OF_BYTES-eng: 16739
2023-04-13 00:26:51 - FFM21611 - = _STATISTICS_WRITING_APP: mkvme rge v10.0.0 ('To Drown In You') 64bit
2023-04-13 00:26:51 - FFM21611 - = _STATISTICS_WRITING_APP-eng: m kvmerge v10.0.0 ('To Drown In You') 64bit
2023-04-13 00:26:51 - FFM21611 - = _STATISTICS_WRITING_DATE_UTC: 2017-04-09 02:11:12
2023-04-13 00:26:51 - FFM21611 - = _STATISTICS_WRITING_DATE_UTC-e ng: 2017-04-09 02:11:12
2023-04-13 00:26:51 - FFM21611 - = _STATISTICS_TAGS: BPS DURATION NUMBER_OF_FRAMES NUMBER_OF_BYTES
2023-04-13 00:26:51 - FFM21611 - = STATISTICS_TAGS-eng: BPS DURA TION NUMBER_OF_FRAMES NUMBER_OF_BYTES
2023-04-13 00:26:51 - FFM21611 - = Stream mapping:
2023-04-13 00:26:51 - FFM21611 - = Stream #0:0 -> #0:0 (hevc (native) -> h264 (h264_vaapi))
2023-04-13 00:26:51 - FFM21611 - = Stream #0:1 -> #0:1 (? (?) -> mp3 (libmp3lame))
2023-04-13 00:26:51 - FFM21611 - = Decoder (codec dts) not found for in put stream #0:1
2023-04-13 00:26:51 - FFM21611 - MODE = PIPE V_ORIG-A_WRAP-VS
2023-04-13 00:26:51 - FFM21611 - FFMPEG1 = /var/packages/CodecPack/target/pack/ bin/ffmpeg41.orig
2023-04-13 00:26:51 - FFM21611 - FFMPEG2 = /var/packages/ffmpeg/target/bin/ffmp eg
2023-04-13 00:26:51 - FFM21611 - PARAM1 =
2023-04-13 00:26:51 - FFM21611 - = -ss 0.000 -noaccurate_seek -vaapi_de vice /dev/dri/renderD128 -hwaccel vaapi -hwaccel_output_format vaapi -noautorota te -
2023-04-13 00:26:51 - FFM21611 - = i /volume1/test/sample-Planet Earth II S01E02 HEVC 2160p UHD BluRay HDR DTSHD5.1-DDR.mkv -r 24 -vcodec h264_vaapi -v f fo
2023-04-13 00:26:51 - FFM21611 - = rmat=nv12|vaapi,hwupload,scale_vaapi =w=1920:h=1072,scale_vaapi=format=nv12 -vsync 2 -bf 0 -vb 15000000 -acodec copy -f m
2023-04-13 00:26:51 - FFM21611 - = pegts -pix_fmt yuv420p -map 0:0 -map 0:1 -bufsize 8192k pipe:1
2023-04-13 00:26:51 - FFM21611 - PARAM2 =
2023-04-13 00:26:51 - FFM21611 - = -analyzeduration 10000000 -vaapi_dev ice /dev/dri/renderD128 -hwaccel vaapi -hwaccel_output_format vaapi -noautorotat e -i
2023-04-13 00:26:51 - FFM21611 - = pipe:0 -map 0:0 -map 0:1 -map 0:1 - r 24 -vcodec copy -vsync 2 -bf 0 -vb 15000000 -c:a:0 libmp3lame -c:a:1 libfdk_aa c -b
2023-04-13 00:26:51 - FFM21611 - = :a:0 256k -b:a:1 512k -ac:1 2 -ac:2 6 -f ssegment -pix_fmt yuv420p -segment_format mpegts -segment_list_type m3u8 -h ls_s
2023-04-13 00:26:51 - FFM21611 - = eek_time 0 -segment_time 5 -segment
time_delta 0.000 -segment_start_number 00000 -avoid_negative_ts 0 -break_non_key fram
2023-04-13 00:26:51 - FFM21611 - = es 1 -max_muxing_queue_size 1024 /tm p/VideoStation/HLS/3fcad3c5c5704ad739a236b93a6db7d3_qBb3AI0I/slice-%05d.ts
2023-04-13 00:26:51 - FFM21611 - CHILDPID = 21692
2023-04-13 00:27:16 - FFM21611 - *** CHILD END ***
2023-04-13 00:27:16 - FFM21611 - *** PROCESS END ***

@martvard
Copy link

I now tried your config in Media Server and now it seems to be working fine!

Thank you so much.

@darknebular
Copy link

Thank you so much.

Great!!!

You are welcome!!!

Bets regards and ENJOY IT!!!

@dsfans
Copy link

dsfans commented Apr 17, 2023

I am writing my opinion about the wrappers. Sorry for my English, I am italian And I am not English speaker.
I was a user of the Alex's wrapper, I had problems with the resume of the videos and I saw a bug with the same problem that me in its profile. I was waiting for a solution, but only I read that "It's not related to his wrapper".

Well, Finally, I installed the darknebular's Wrapper and all my problems with the resume go off. Now It's working perfectly.

I decided to sign Up here in GitHub for answer to the user with these problems recomending to try the darknebular's One. In This moment, Alex had a bad manners towards me, he hided my comments and marked them as abuse.

Finally He blocks my profile for commenting It.

I think that He thinks that I am darknebula but I am another Guy.

I think that Alex is the tipical person that you can't say that he is wrong...
He said too that both wrappers can be installed in the same system, but It isn't true, when I have both I am having bucles in playing movies and strange errors.

I Will never come back to use the Alex's wrapper.
I recommend stay with the darknebular's One, for me It's powerfuller and better wrapper.

Cheers.

@darknebular
Copy link

darknebular commented Apr 17, 2023

ey ey ey I am happy with my life and I don't need another war with Alex.
I don't know this guy. He is a different person than me.

And yes, you are right, He doesn't listen to people and thinks he's always right. You CAN'T have both wrappers installed, because you will have strange behaviors in the reproduction of the movies. This behavior is because Alex's wrapper patches the VideoStation folder (good in older DSM but not ideal or wrong path in newer DSM) and not the CodecPack folder (the correct path in newer DSM) and produces playback errors with the mine.

I am glad that you are working fine with my Wrapper, ENJOY IT!!

Thanks for the review and please try not to include me in your fights with Alex. He has a wrapper and I have another wrapper, you choose if you need 5.1 or not and I don't want any war with somebody.

Best regards.

@darknebular
Copy link

@dsfans stop trolling me!!!
It isn't "your" wrapper, stop saying that to people and pretending to be me. I also will blocked you.
What are you doing doing this?

@va3lim
Copy link

va3lim commented Apr 26, 2023

@darknebular To use your ffmpeg wrapper, do I need to uninstall the other wrapper (alexpresso) or can they both co-exist? Thanks.

@darknebular
Copy link

darknebular commented Apr 26, 2023

@darknebular To use your ffmpeg wrapper, do I need to uninstall the other wrapper (alexpresso) or can they both co-exist? Thanks.

NO, It's better than they don't co-exist. I tried with both in the past and I had weird problems. The Alex's one patchs VideoStation folder and then he does a permanent link into CodecPack binary and the mine only patch CodecPack binary. In DSM 7.X you must only have patched the CodecPack binary.

It's better uninstall the other and then install my Wrapper. Or you can Install my Wrapper, and then re-install it. In this moment, my script will ask you if you want to uninstall others (for example Alex's one) or a older wrapper.
image

Regards.

@kkman466
Copy link

Hi darknebular
How to use this Wrapper. [ffmpeg41-wrapper-DSM7_1-12.3.7]
tks

@darknebular
Copy link

@kkman466
When you have installed this Wrapper, you will be able to play movies with DTS, E-AC3, TrueHD audio's codecs in Video Station and Media Server (This package is Optional).
For use this Wrapper, you only need to install it and play the movies in Video Station, nothing more.

You only need to have one of them installed:

  1. Advanced (with 5.1 support and 2.0 with 256 kbps, you also could change the audio's codecs order using the Configurator Tool)
  2. Simplest (only with 2.0 support and 96 kbps, not possible to configure)

It's recommended that you only have one Wrapper installed, if you have another wrapper before, please uninstall first.

Best regards.

@Oliech-1
Copy link

Oliech-1 commented May 1, 2023

Hi @darknebular
First, Thanks for your wrapper. Really nice and useful for a dsvideo user like me. Two clicks install, and it works !

One question, when I start a video encoded in ac3, what ever configuration I try to do in your wrapper (-- -s config), it remains in stereo.
eac3 or DTS are correctly read in multi channels. Is it an issue you are aware of or did I do someting wrong ?

I used previously AlexPresso's wrapper and removed it from your installer

(using dsvideo from an appleTV 4k with DS418Play)

Many thanks for your help

@kkman466
Copy link

kkman466 commented May 1, 2023

Hi darknebular

I installed ffmpeg 6.0, then I removed your Wrapper,
I installed your Wrapper again and got an error

FFMPEG WRAPPER INSTALLER version: SCPT_2.9

==================== Wrapper for VideoStation and DLNA MediaServer for DTS, EAC3 and TrueHD with transcoding to AAC 5.1: ====================
Synology VideoStation and MediaServer ffmpeg wrapper with DTS, EAC3 and TrueHD support.
It enables hardware transcoding from Synology's ffmpeg for video and transcoding DTS, HEVC, EAC3, AAC, True HD from the ffmpeg of the SynoCommunity.

When the Wrapper needs to transcoding you will have 2 audio's streams from the SAME track:

  • In DLNA MediaServer = [1) AAC 5.1 512kbps AND 2) MP3 2.0 256kbps.] (by default)
  • In VIDEO-STATION = [1) MP3 2.0 256kbp AND 2) AAC 5.1 512kbps.] (by default)*
    *(For Chromecast or Google TV or other clients that don´t accept 5.1 AAC neither multi audio's stream support).

Now, You can change the 5.1 audio´s codec from AAC 512kbps to AC3 640kbps independently of its audio´s streams order in VIDEO-STATION and DLNA MediaServer
using the Configurator TOOL embedded into the Installer.
(AC3 is more compatible with legacy 5.1 devices).

Works fine the OffLine transcoding and the streaming of tipical extensions like: MKV, MP4, AVI... Works fine the thumbnails in VideoStation.

The latest version is 12.2.5 for DSM 7.0 and 12.3.6 for DSM 7.1 and above.
You will have full control of each Audio's codecs parameter using the Configuration TOOL for the Advanced Wrapper Mode. The only Wrapper of Internet with 5.1 AAC support and with a Configurator TOOL.

============================================================ ¡¡¡¡¡ENJOY!!!!! ============================================================

[2023-05-01 22:22:07] ERROR: MISSING ffmpeg Package.
At least you need 1 package/s to Install, please Install the dependencies and RE-RUN the Installer again.
root@DS916Plus:~#

@Oliech-1
Copy link

Oliech-1 commented May 1, 2023

Hello kkman466,
As far as I understand and as mentioned in the Readme, only ffmpeg 4.X.X is supported (For the moment VideoStation It's not compatible with 5.X and 6.X)"

@darknebular
Copy link

Hi @Oliech-1 No, you are not doing something wrong. My Wrapper is activated only with DTS, E-AC3, TrueHD and when It is activated, there will be 2 audio's streams (5.1 and 2.0 or 2.0 and 5.1 ).
When you play AC3, the flow is using the native binary (ffmpeg41.orig), all native libraries and profiles, and then you will have only 2.0. (default streaming in Video Station)

Best regards.

@darknebular
Copy link

darknebular commented May 3, 2023

I installed ffmpeg 6.0, then I removed your Wrapper,
I installed your Wrapper again and got an error

Hello,

Yes, FFMPEG 6.0 has other arguments than what the Video Station app sends.

I am making another version of the Wrapper (SCPT 3.1 beta) compatible with FFMPEG 6.0, everything works but only with the advanced Wrapper, not the simplest one, ah! and in this beta version the resume option of the movies does not work.
The rest of the options work without problems.

If you want to try it you can putting this:
bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/testing.sh")"

Best regards.

@darknebular
Copy link

darknebular commented May 3, 2023

@kkman466
I recommend you that you stay with SCPT 2.9 (stable version) and you must to have installed this FFMPEG's version:
image
bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")"

With this version you will not have any problem with Video Station or my Wrapper SCPT 2.9.

You can have both ffmpeg if you really want to use the ffmpeg 6.0.

Best Regards.

@kkman466
Copy link

kkman466 commented May 3, 2023

ok
i got it
thks

@th0ma7
Copy link

th0ma7 commented May 3, 2023

@darknebular heads-up:

  1. there is a permission issue with DSM6 that some user may be affected by using latest releases
  2. ffmpeg4 seek time patches have now being ported over to ffmpeg5-6 (needs further testing)

Associated PR handling this: SynoCommunity/spksrc#5711

@darknebular
Copy link

darknebular commented May 3, 2023

Hi @th0ma7
I have seen that the VideoStation sends -hls_seek_time, but that argument in FFMPEG 6.0 is deprecated and I am changing it in the wrapper to ("-ss" "$1""ms").

It's correct this change?

I don't support DSM 6.X, for me It's deprecated and unsecure system.

Best regards.

@th0ma7
Copy link

th0ma7 commented May 4, 2023

Actually, -hls_seek_time is a Synology based added option to ffmpeg that I've extracted from their GPL sources they provide and ported over to newer versions of ffmpeg 4.x and now to 5-6.x versions as well. My intent is to find a sort of balance beteeen latest ffmpeg version vs providing backported compatibility towards Synology custom ffmpeg when achievable.

To your question, is there another equivalent builtin default in ffmpeg (i.e. "-ss" "$1""ms")? no clue really. Although if you're interested in testing, https://github.com/SynoCommunity/spksrc/actions/runs/4870614890?pr=5711 (i.e. github-action resulting packages from my PR mentioned above) should provide packages with that functionality now.

And as I mentionned, I'm looking for testers to confirm it works as expected before publishing.

@darknebular
Copy link

Well, if this argument is loaded into the new version of FFMPEG 6.0 I don't need to change anything in my wrapper.

I will test with the new version and I will inform you.

Thanks in advance.

@darknebular
Copy link

darknebular commented May 4, 2023

@th0ma7
Look, I tested with the new version FFMPEG 6.0 without change the arguments and I had a error:
image

If I change the argument -hls_seek_time for the FFMPEG's standard argument to "-ss" "$1""ms", I can play the movie without problem using my advanced Wrapper in 3.1 Beta version with FFMPEG 6.0. The simplest doesn't work because this kind of wrapper doesn't change anything in the arguments.
image
image

All is working, subtitles, offline transcoding, etc, except the resume option, If I try to do a resume of a movie with FFMPEG 6.0 I have this:
image

image

Well, It looks like that these options aren't added to my repository. I have this version:
image

If I try to do a streaming via DLNA using FFMPEG 6.0, I can play the movie (not resume it like with VideoStation) and I have this "error" in the logs: (Can "pipe:X" work with FFMPEG 6.0? )
image

Best regards.

@darknebular
Copy link

Then I will test with 6.0.2 version.

regards.

@th0ma7
Copy link

th0ma7 commented May 4, 2023

@darknebular The first verion I published online (6.0-1) doesn't have the required patches. You need to use the version from my PR using the link I provided above (version 6.0-2) by downloading the zip file and installing manually from the package center. Patches are now also applied on version 5.1.3-2 (also part of the same PR) and it also includes an updated version 4.4.4 (which will probably be my last release for the 4.x tree). Testing with all of the above would be much appreciated.

For your awareness, in the PR I've ported the patches over: https://github.com/SynoCommunity/spksrc/pull/5711/files#diff-bb20f6eb779c59f6935caad18e02b0798467ef878403733648cbb1760ef596e7

I had to do a few minor changes so it uses the newer API but it was fairly minor and should hopefully work as good (or bad) as previously.

EDIT: Also, in extra configuration it now also creates symbolic links such as:

  • /usr/local/bin/ffmpeg4
  • /usr/local/bin/ffmpeg5
  • /usr/local/bin/ffmpeg6
  • /usr/local/bin/ffmpeg (defaults to latest version installed, so may vary depending of the order used to install)
  • /usr/local/bin/vainfo (only available on x86_64 for vaapi hardware acceleration info)

@darknebular
Copy link

@th0ma7
Hello, I just try with 6.0.2 version. Now with this version I don't need to change anything in my Wrapper like change the argument -hls_seek_time for the FFMPEG's standard argument to "-ss" "$1""ms".
image

Now without change this argument (hls_seek_time) works, and now I can resume the movies in Video Station BUT using DLNA (Media server) I can't do the resume option.
I still having PIPE errors in this version, look:
image

This PIPE's error doesn't exist in 4.4.3

Best regards.

@darknebular
Copy link

darknebular commented May 5, 2023

Forcing to use in the PARAM1 from pipe:1 to pipe:6 (this isn't necessary with 4.4.3) now I can resume the movies in DLNA.
But I have these errors:
image
I will need to change the -vsync option to fps in my Wrapper in order to avoid this error or you will put this option too in 6.0.2?

With this, I lost the two audio's channels, and only receive the native codec without transcodification:
image

Regards.

@darknebular
Copy link

darknebular commented May 5, 2023

The resume option in DLNA is erratic. Now It's working in DLNA.
If I leave pipe:1 (like with 4.4.3) I have two audio streams but with 6.0.2 I am having pipe errors: (but the movie plays and now It looks like that the resume is working via DLNA using VLC)
image
image

Regards.

@th0ma7
Copy link

th0ma7 commented May 5, 2023

@darknebular can you check if all is still working out OK with the new 4.4.4-49 (it normally should) as well as with verison 5.1.3-2 ?

In the meantime I'll check if there where any other ffmpeg 4.x custom patches needing porting over to v5-6.

@darknebular
Copy link

With 4.4.3 is perfect using DLNA:
image

@darknebular
Copy link

I will try with 4.4.4-49 asap.

Please wait for it.

@th0ma7
Copy link

th0ma7 commented May 5, 2023

There are only two remaining patches which I doubt have any impact on your use-case. Still I've managed to port them over to ffmpeg5-6. They are now added to the on-going PR. You'll be able to access the updated packages from the "Checks" tab once the build complete. Look for the summary page where updated packages will be available. Note that it normally takes around 5h to build x64 versions (it's quite of a beast to build).

Lastly, trying ffmpeg5 package you already downloaded may tell if this is a post-ffmpeg4 regression or not, which may mean :

  1. opening up a bug request to upstream ffmpeg OR
  2. need to further adjust used parameters somehow?

The good news are:

  • it ain't crashing
  • hls_seek_time now works

While we may not find a short-term workaround, still thnx for taking time to test this out :)

@darknebular
Copy link

While we may not find a short-term workaround, still thnx for taking time to test this out :)

You are welcome. I will try with the others versions asap.

Regards.

@th0ma7
Copy link

th0ma7 commented May 7, 2023

@darknebular note that I've now published new versions. Don't hesitate opening-up a github issue if you find something else going wrong part of your testing of version 5-6. Thnx again.

@darknebular
Copy link

@th0ma7
Look:
image

@darknebular
Copy link

Changing from -i pipe:0 to -i pipe: It looks like that fix the problem with the new versions.

@th0ma7
Copy link

th0ma7 commented May 9, 2023

Changing from -i pipe:0 to -i pipe: It looks like that fix the problem with the new versions.

Awesome, great finding! Hope you can then switch to the newer ffmpeg6 version instead. Note that I intend to freeze 4.4 and focus on latest only :)

EDIT: and btw, feel free to connect on Discord SynoCommunity channel.

@kkman466
Copy link

Can QNAP use Wrapper to implement DTS like SYNOLOGY?

@darknebular
Copy link

darknebular commented May 10, 2023

@th0ma7 I can't have running well the DLNA using 6.0.2. I am having these errors and I don't know how do a workaround or fixed them, look:
image

Have you any idea or a possible fix for it?
With 4.4.3-48 I haven't any error and all is working perfectly without change anything.

Best regards.

@darknebular
Copy link

darknebular commented May 11, 2023

@th0ma7 With 4.4.4-49 It's working fine, without any change in the arguments sended by VideoStation, I haven't any issue.
With 6.0.2 I am having resume problems via DLNA. And I will need to change the argument-vsync to -fps in my wrapper for compatibilize it with Video Station. And a broken pipe error and muxing errors as you can see.

Best regards.

@darknebular
Copy link

Can QNAP use Wrapper to implement DTS like SYNOLOGY?

Sure!!! you only need to know the arguments sended by your streaming QNAP's app.

Regards.

@kkman466
Copy link

kkman466 commented May 11, 2023

Can QNAP use Wrapper to implement DTS like SYNOLOGY?

Sure!!! you only need to know the arguments sended by your streaming QNAP's app.

Regards.

I only know QNAP to install Video Station 5 and ffmpeg
QQ

@darknebular
Copy link

I think that if you change the name of the binary of the ffmpeg from QNAP's Video Station to .orig extension, put my wrapper or better in this case that you don't know all arguments, the Simplest wrapper you must be able to play all, I think.

I don't know if It's necessary to add the new audio codecs into a QNAP's library and If you use my wrapper, you will need to change these two variables for the correct paths and binaries in your system and It's probable that something doesn't work fine, due to difference in arguments between Synology and Qnap.

bin1=/var/packages/CodecPack/target/pack/bin/ffmpeg41.orig
bin2=/var/packages/ffmpeg/target/bin/ffmpeg

Regards.

@darknebular
Copy link

Changing from -i pipe:0 to -i pipe: It looks like that fix the problem with the new versions.

Awesome, great finding! Hope you can then switch to the newer ffmpeg6 version instead. Note that I intend to freeze 4.4 and focus on latest only :)

EDIT: and btw, feel free to connect on Discord SynoCommunity channel.

NO, the correct syntax is puting: -i pipe:0
with pipe: I have the same problem, I will write again the pipe:0

image

@darknebular
Copy link

@th0ma7 If I change the argument from -vsync to -fps in order to compatibilize with the new version of ffmpeg 6.0.2 I have this:
image

@th0ma7
Copy link

th0ma7 commented May 14, 2023

@darknebular Honestly I have no clue, perhaps you'll can find help from upstream ffmpeg?

@darknebular
Copy link

darknebular commented May 14, 2023

@th0ma7 Finally, I found the problem with the pipes. It was a bug from Benjamín code @BenjaminPoncet. He had pipe:1 and pipe:0. I used an old argument's variable from his old wrapper ver 12.0 until now. Now, for the function with pipes I am puting pipe: in both binaries. (It's really pipe:0 in the new ffmpeg's version.)
new option called -fps (there isn't in this binary), don't worry, -vsync still working fine.

Best regards.

@darknebular
Copy link

@th0ma7 with all these changes I confirm to you that with FFMPEG 6.0.2 all is working fine.
I Will deprecate the use of FFMPEG 4.4.3 soon and I will change the requeriments for the new version to FFMPEG 6.0.2.

Regards.

@darknebular
Copy link

darknebular commented May 15, 2023

When it will be published officially the 6.0.2?
image

When this version is for all people, I will change my script to start to use the FFMPEG 6 and deprecates de 4.X.

Regards.

@th0ma7
Copy link

th0ma7 commented May 16, 2023

It's there: https://synocommunity.com/package/ffmpeg6
Your package is probably just not updated yet.

@th0ma7
Copy link

th0ma7 commented May 16, 2023

with all these changes I confirm to you that with FFMPEG 6.0.2 all is working fine. I Will deprecate the use of FFMPEG 4.4.3 soon and I will change the requeriments for the new version to FFMPEG 6.0.2.

Regards.

@darknebular Awesome :)

@darknebular
Copy link

darknebular commented May 16, 2023

The Installer´s Script version 3.9.1 Wrapper with 5.1 and Configurator Tool:

Fully tested, fully stable, fully configurable using the Advanced Wrapper.

NOW YOU WILL HAVE: (Only when It´s necessary to activate my wrapper. This means transcoding of DTS, EAC3 and TrueHD.)

  • In MediaServer DLNA = [1) AAC 5.1 512kbps AND 2) MP3 2.0 256kbps.] (by default) (If exists)
  • In VIDEO-STATION = [1) MP3 2.0 256kbp AND 2) AAC 5.1 512kbps.] (by default)
  • You now can change the 5.1 audio´s codec from AAC 512kbps to AC3* 640kbps independently of its audio´s streams order in VIDEO-STATION and DLNA MediaServer using the configurator tool embedded into the installer.sh.

*(AC3 is more compatible with legacy 5.1 devices).

ADD-ONs or FIXES FROM 2.4:

  • Tested and working fine in a lot of Synology´s models.
  • Fixed a bug in the Uninstallation process.
  • Added a Flag for automatic installation in the case that the Wrapper was installed previously and you don't want to write YES for uninstall the older Wrapper.
  • Save space in the Installer script in some function that mustn't be translated.
  • Fixed a bug when you are in 7.0.X the scripts doesn't take the conditional correctly in check_versions fuction.
  • Make the installation script compatible with the new version of DSM 7.2
  • Add compatibility to DSXXX-PLAY appliances using ffmpeg27
  • Support for the new versions of FFMPEG 6.0.X and deprecate the use of FFMPEG 4.X.X.
  • Fixed a bug in Offline Transcoding.
  • Improved the viewing of logs.
  • Improved DLNA processing to use only one binary.
  • Fixed a problem to close the process in Simplest wrapper.
  • Fixed a piping problem with the new versions of FFMPEG.
  • Improved the removing of the stderr's temporals to specific PID.
  • Fixed a bug with AVBR movies using DLNA transcoding.
  • I remove the buffer 8M for DLNA, It must be only for ChromeCast or Browsers.
  • Improvements in checking for future releases of DSM's versions.
  • Creation of installer_OffLine to avoid the 128KB limit and to be able to create more logic in the script and new fuctions.
  • Now the installer has an AME's License Crack until DSM 7.2 (BETA)
  • Added full support for DS21X-Play devices with ARMv8 using a GStreamer's Wrapper.
  • Now the installer recommends to you the Simplest or the Advanced in function of the performance of your system.
  • Fixed a bug in declaration of the variables for the licenses fix for AME.
  • Fixed a bug in the GStreamer's Wrapper installer that doesn't clear the plugin's cache in AME.
  • Fixed a VideoStation bug when the movie has HEVC 4K HDR 10bits plus TrueHD 7.1 audio codec in the Advanced Wrapper, this bug will be there in Simplest Wrapper, because VS send bad arguments and the Simplest doesn't change any arguments.
  • Added the possibility to transcode AAC codec in Video Station and Media Server.
  • Added new libraries for GStreamer 1.6.3. for this AAC decoding.

Check It out:
Connect using SSH (Maximize the window for read better the menu) and then:

Enter:
sudo -i

And then:

INSTALL / UNINSTALL:

The BASIC command (you will see the Main Menu and all options):
bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")"

...

OTHER FLAGS:
Enter for installing:
bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s autoinstall

Or (for uninstall it...)

Enter for uninstalling:
bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s uninstall

CONFIGURATOR TOOL:

Enter:
bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s config

https://github.com/darknebular/Wrapper_VideoStation

...

Please give a star in my repository if you like my wrapper or if you find It useful. Thanks...

BEST REGARDS.

@AlexPresso
Copy link

AlexPresso commented Jul 29, 2023

Hey there,
Deployed a new version of the wrapper : https://github.com/AlexPresso/VideoStation-FFMPEG-Patcher

This one adds:

  • Gstreamer wrapper : allowing HEVC transcoding with eac3, dts, truehd on architectures using GSTOmx (thanks to @nap-liu for the workaround while waiting for the Gstreamer package)
  • Adds ffmpeg version selector : you can now choose ffmpeg 4.x, ffmpeg 5.x or ffmpeg 6.x as you wish
  • Fixes a process leak : This process leak was due to child process launched in wrappers, to never be terminated after execution.

This fix saves a lot of performances on every NAS and I highly suggest you to install it.
This fix is not yet present in DarkNebular's wrapper (At least until he copy paste my wrappers code again without asking my permission 😛.).

Have a good one

@KidWar75
Copy link

Hey there!
Cheers for the update :)
Any updates on the subtitles issue in DS Video ?

@AlexPresso
Copy link

I personally don't have any issue with subtitles (both embedded and external subtitles).
I don't think it's related to any wrapper / patch, but I can have a look at it if you want to post an issue on the repo :)

@KidWar75
Copy link

I personally don't have any issue with subtitles (both embedded and external subtitles).
I don't think it's related to any wrapper / patch, but I can have a look at it if you want to post an issue on the repo :)

I already did a few months back. You said that you had a similar issue wish a Samsung or an Android phone at least.
A few weeks later you closed it saying that there was no workaround or something like that :p

@AlexPresso
Copy link

Oh yes, that's right (AlexPresso/VideoStation-FFMPEG-Patcher#49) I remember now, if the subtitles are also not working on unpatched version, then it's not an issue with the patcher, but with the DS Video app, and I can't do anything for this unfortunately :c

@darknebular
Copy link

darknebular commented Aug 7, 2023

This fix is not yet present in DarkNebular's wrapper (At least until he copy paste my wrappers code again without asking my permission 😛.).

What's happening with you?
Why are you doing this?
image

You are a liar, because this problem in my Wrapper, the Advanced one isn't exist.
Sorry but my Wrapper is working fine and the system closes fine the child process launched in wrappers.

@darknebular
Copy link

darknebular commented Aug 7, 2023

And yes, I don't take care about the Simplest one, The simplest Wrapper is a fork from your wrapper but installed in the correct path without any binary change in VideoStation folder.

Just fixed in the Simplest one, the Advanced Wrapper is working great!!!

Ah, If you play HEVC 4K + EAC3 7.1 or DTS 7.1 movies, the only Wrapper that work with this kind of movies is the Advanced, in the Simplest has this problem, because you can't change any arguments.

And please stop of mention me.

Kind regards.

@AlexPresso
Copy link

AlexPresso commented Aug 7, 2023

And yes, I don't take care about the Simplest one, The simplest Wrapper is a fork from your wrapper but installed in the correct path without any binary change in VideoStation folder.

This is not a fork. It's copy paste of my code and I would like you stop doing this (not only for the wrapper but for everything) It's working better and you know it, that's why you copy paste without using your brain that much.

Ah, If you play HEVC 4K + EAC3 7.1 or DTS 7.1 movies, the only Wrapper that work with this kind of movies is the Advanced, in the Simplest has this problem, because you can't change any arguments.

"Ah" Then why you copy paste my wrapper if it's not working with 7.1 ? just remove it ?

@AlexPresso
Copy link

About the NanoChoco screenshot, I don't know what happened but I'm glad someone is finally giving facts about you and your wrapper.

@AlexPresso
Copy link

XPenology/Redpill users should be happy about it, but did you know that having a license cracker inside your project is warranty void for every users using your wrapper ? Congratulations.

@darknebular
Copy link

darknebular commented Aug 7, 2023

With your Wrapper you can't play 7.1 movies. Yours It's not better. Let the people choose.
My installer has two Wrappers:
1) The mine It's the Advanced one and It's the correct continuation from the Benjamin one
2) The Simplest, that It's a fork from you, but installed in the correct path.

The "crack" It's an optional for those that haven't a valid license but a legit serial or in an Offline environment. I don't change the serial number. You don't need to install the patch in order to use my Wrapper. LIAR!!!

@AlexPresso
Copy link

AlexPresso commented Aug 7, 2023

The Simplest, that It's a fork from you.

I never gave you permission to use my wrapper as if it was "your" wrapper, this is not a fork, it's a copy paste (of course you don't have permission to fork my repositories because I blocked you long time ago). And if it can't play 7.1 then it's not good and you should remove it :) I really don't understand why you would want to keep such a wrapper if yours is better.

The "crack" It's an optional for those that haven't a valid license but a legit serial or in an Offline environment. I don't change the serial number. You don't need to install the patch in order to use my Wrapper. LIAR!!!

If you have a legit Synology hardware and registered account, you have a valid license :) who's lying ?

@darknebular
Copy link

darknebular commented Aug 7, 2023

I really don't understand why you would want to keep such a wrapper if yours is better.

I use it only for troubleshooting and for a low performance devices. It's the same with a little changes (the Simplest one) but installed only in the AME folder.
The Advanced is mine, It's the correct evolution from the deprecated Benjamin's wrapper with a lot of fixes and improvements, and yes, It's better than your wrapper or Simplest one. The Advanced is more powerful than yours.

You used the mine without any mention to me when I started the improvements in the Benjamin's one, You copied the 12.1 version in your installer without any mention to me, then again you copy-paste my 12.2 version again... Then you did the simplest, because you knew that you was using my Wrapper versions.

At least, I mention you into the Simplest's one.
I want have the two, because in this way I let the people choose both Wrappers using the same installer.

If you have a legit Synology hardware and registered account, you have a valid license :) who's lying ?

If you haven't an account or you have a Offline enviorement, you will not be able to license it. The patch is only a helper for this guys, not really a "serial crack". It's doesn't modify any serial.

STOP Crying Baby.

@AlexPresso
Copy link

AlexPresso commented Aug 7, 2023

If you haven't an account or you have a Offline enviorement, you will not be able to license it. The patch is only a helper for this guys, not really a "serial crack". It's doesn't modify any serial.

This is exactly what a licence cracker is... Call it what you want, everyone using this "helper" is voiding it's warranty.

I keep repeating you I was never using your wrapper, I just did small changes on the Benjamin's one.

@darknebular
Copy link

darknebular commented Aug 7, 2023

I keep repeating you I was never using your wrapper, I just did small ghanges on the Benjamin's one.

You are a liar, you can check it out in the historic. You used my Wrappers versions. I told you 2 years ago...
And well, YOU DON'T NEED TO INSTALL THIS AME LICENSE IN ORDER TO USE MY WRAPPER, IT'S AN OPTIONAL ADDONS, NOTHING MORE. And this patch or crack has a DISCLAIMER and It must be use at your own risk.
THIS ADDON IS NOT THE WRAPPER AND IT'S NOT MANDATORY TO INSTALL IT IN ORDER TO USE MY WRAPPER!!!

Please forget me, buy a friend and enjoy your life.

@darknebular
Copy link

darknebular commented Aug 7, 2023

image

### I changed the binaries order in 12.1, delete some commands, fix the logging in order to have only error output and not all output, change the names in the methods with more logical names, you Copy-Paste ALL my changes and ALL my wrapper's fixes or Versions without mention to me and now you are crying because I did a fork from your Simplest? At least I mention to you into the Simplest's wrapper.

LEFT IT'S MY INITIAL WRAPPER'S VERSION 12.1, RIGHT IT'S THE DEPRECATED BENJAMIN'S WRAPPER 12 VERSION.
image
image
image

Here "Alex's" wrapper "from" the "Benjamin's one", but It was really a Copy-Paste from MY INITIAL VERSION 12.1:

image
image
image

I know why I put this 22 there, you don't.

@darknebular
Copy link

darknebular commented Aug 7, 2023

The Installer´s Script version 3.9.2 Wrapper with 5.1 and Configurator Tool:

Fully tested, fully stable, fully configurable using the Advanced Wrapper.

NOW YOU WILL HAVE: (Only when It´s necessary to activate my wrapper. This means transcoding of DTS, EAC3 and TrueHD.)

  • In MediaServer DLNA = [1) AAC 5.1 512kbps AND 2) MP3 2.0 256kbps.] (by default) (If exists)
  • In VIDEO-STATION = [1) MP3 2.0 256kbp AND 2) AAC 5.1 512kbps.] (by default)
  • You now can change the 5.1 audio´s codec from AAC 512kbps to AC3* 640kbps independently of its audio´s streams order in VIDEO-STATION and DLNA MediaServer using the configurator tool embedded into the installer.sh.

*(AC3 is more compatible with legacy 5.1 devices).
Avoid permanent errors, unlike other Internet Installers. There are other installers on the internet that produce permanent errors on your systems even after uninstalling them. Be careful. This does not happen with my Wrapper and my installer.

ADD-ONs or FIXES FROM 3.9.1:

  • Tested and working fine in a lot of Synology´s models.
  • Homogenize the closing of processes in the Simplest Wrapper with the Advanced Wrapper, to correct a bug carried over from Alex's code (the Simplest Wrapper). The Advanced Wrapper was and is working fine and don't need fix it.

Check It out:
Connect using SSH (Maximize the window for read better the menu) and then:

Enter:
sudo -i

And then:

INSTALL / UNINSTALL:

The BASIC command (you will see the Main Menu and all options):
bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")"

...

OTHER FLAGS:
Enter for installing:
bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s autoinstall

Or (for uninstall it...)

Enter for uninstalling:
bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s uninstall

CONFIGURATOR TOOL:

Enter:
bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s config

https://github.com/darknebular/Wrapper_VideoStation

...

Please give a star in my repository if you like my wrapper or if you find It useful. Thanks...

BEST REGARDS.

@dsfans
Copy link

dsfans commented Aug 9, 2023

I will give data about you and your wrapper. @AlexPresso
I was a user of your wrapper, then over time the problems started I made an account and just because I put the darknebular link, you thought I was him, I think he is from Spain and I am Italian.
You insulted me, you treated me badly and you were rude to me.

I then found out that your installer made permanent changes and errors to my system and I had to uninstall and reinstall everything to get it clean of those changes.

Your installer is made without respect for the stability of your users' systems and made without love.
It just confirms if /var/packages/CodecPack/target/pack exists and nothing else, but you don't know that that folder isn't generated until you install the AME license. When you load and activate said license, that folder is auto-generated. When I installed your wrapper, I did not have the AME license loaded and that folder on my system did not exist, the AlexPresso installer made changes to the binaries of:
/var/packages/CodecPack/target
They were all links to the VideoStation binary (WTF?), then I installed the AME license and the folder to: /var/packages/CodecPack/target/pack/ was generated for me. When I tried to uninstall your wrapper, those links from /var/packages/CodecPack/target weren't deleted and they kept pointing wrong to the VideoStation binary and I started having a lot of problems, the movie thumbnails wouldn't load, some things they weren't working and I had to reinstall the whole AME.
At that moment I understood why the Darlnebular script checks that the AME license is loaded and activated, precisely to avoid permanent changes, as it happened to me.

The only one here who is copying ideas is you, because darknebular made the patch for devices with GStreamer in May 2023 and now you do the same, but it's worse. The GStreamer libraries that you download with the darknebular installer end up in a separate folder and thanks to that, he can do a totally clean delete, leaving nothing behind and without altering any existing files. On the contrary, your installer loads these files directly into the system folder where there are already other library files, imagine that this file exists, when someone uninstalls your wrapper, that file or library will be lost forever and the only way to recovering it will be reinstalling VideoStation and AME.

And yes, the darknebular installer and its wrapper is much better than yours Alex. The darknebular installer can patch MediaServer and VideoStation at the same time using the same wrapper and it has many control mechanisms and everything has been done with care not to make any permanent changes under any circumstances, unlike you. Your Media Server wrapper is installed using another installer and will not work if you do not have the VideoStation wrapper installed as well. Think why!!
You have always been envious and manipulative, now you are critical of an optional addition that darknebular put in his script and you said 2 weeks ago that you were going to put it too, look:

image

The only reason you have more stars, it's not because you're better, it's because darknebular took more time to present an installer for its wrapper, at that time darknebular only had a manual procedure.

Also I agree with him, your project is not a real continuation of Benjamin's, it's totally another totally different wrapper.
I suggest to Benjamin (@BenjaminPoncet ) that he thinks that the only real continuation of his project is Darknebular's and not yours, Alex.

Not only is the darknebular's wrapper better, but it also has 5.1 when activated by both VideoStation and DLNA or MediaServer.
It is also true, that your wrapper is not capable of playing HEVC movies with DTS or EAC3 7.1 and the darknebular wrapper is capable. You can also configure the wrapper and yours can't.

For all this, I hope that people get to know you and know in advance all these problems and how rude you can be.

@dsfans
Copy link

dsfans commented Aug 9, 2023

And I want to add more things about the AlexPresso's wrapper. I also experienced errors in other Synology apps (Synology Photos, Audio Station, Surveillance Station), stopped working when using the AlexPresso wrapper, and uninstalled VideoStation. That's because it makes links in all the CodecPack binaries (you only need to modify the ffmpeg41 for VideoStation), it uncontrollably and uncaringly links in all the binaries and points them to the VideoStation binary, when uninstalling VideoStation and not uninstalling its wrapper, all those apps stopped working.

These problems with the Darknebular wrapper do not occur.

Nor is it elegant that if you have Alex's wrapper previously installed that its installer tries to re-install it from scratch, that for me is a botch job.

Now I guess, Alex will copy from darknebular to check the AME license, stop linking all AME binaries pointing to the VideoStation binary and download the GStreamer libraries using a separate folder.

He has already shut his mouth here:
https://gist.github.com/BenjaminPoncet/bbef9edc1d0800528813e75c1669e57e?permalink_comment_id=4653734#gistcomment-4653734

In short, if you want permanent problems, errors, or changes to your system, install the AlexPresso wrapper.

If you want to ensure a clean install every time, zero problems or permanent changes, have more advanced features, install the one from Darnebular.

Ciao piccolo.

@darknebular
Copy link

darknebular commented Aug 9, 2023

JAJAJAJAJA

Thanks guy for your feedback. I knew those problems and other little problems not mentioned here, but I couldn't tell him.
he also copied me the checks to know if the script was being launched in root or not. Until then, his installer was trying to install things without permissions...

Another thing that my Wrapper does and not Alex's, is that it checks if the system can play AAC codec, if it can't, it adds AAC codec on those systems, then my Wrapper can play content with AAC and the AlexPresso's wrapper can't.

https://gist.github.com/BenjaminPoncet/bbef9edc1d0800528813e75c1669e57e?permalink_comment_id=4656147#gistcomment-4656147
image

https://gist.github.com/BenjaminPoncet/bbef9edc1d0800528813e75c1669e57e?permalink_comment_id=4656408#gistcomment-4656408
image

XD

@darknebular
Copy link

The Installer´s Script version 3.9.2 Wrapper with 5.1 and Configurator Tool:

Fully tested, fully stable, fully configurable using the Advanced Wrapper.

NOW YOU WILL HAVE: (Only when It´s necessary to activate my wrapper. This means transcoding of DTS, EAC3 and TrueHD.)

  • In MediaServer DLNA = [1) AAC 5.1 512kbps AND 2) MP3 2.0 256kbps.] (by default) (If exists)
  • In VIDEO-STATION = [1) MP3 2.0 256kbp AND 2) AAC 5.1 512kbps.] (by default)
  • You now can change the 5.1 audio´s codec from AAC 512kbps to AC3* 640kbps independently of its audio´s streams order in VIDEO-STATION and DLNA MediaServer using the configurator tool embedded into the installer.sh.

*(AC3 is more compatible with legacy 5.1 devices).
Avoid permanent errors, unlike other Internet Installers. There are other installers on the internet that produce permanent errors on your systems even after uninstalling them. Be careful. This does not happen with my Wrapper and my installer.

ADD-ONs or FIXES FROM 3.9.1:

  • Tested and working fine in a lot of Synology´s models.
  • Homogenize the closing of processes in the Simplest Wrapper with the Advanced Wrapper, to correct a bug carried over from Alex's code (the Simplest Wrapper). The Advanced Wrapper was and is working fine and don't need fix it.

Check It out:
Connect using SSH (Maximize the window for read better the menu) and then:

Enter:
sudo -i

And then:

INSTALL / UNINSTALL:

The BASIC command (you will see the Main Menu and all options):
bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")"

...

OTHER FLAGS:
Enter for installing:
bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s autoinstall

Or (for uninstall it...)

Enter for uninstalling:
bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s uninstall

CONFIGURATOR TOOL:

Enter:
bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s config

https://github.com/darknebular/Wrapper_VideoStation

...

Please give a star in my repository if you like my wrapper or if you find It useful. Thanks...

BEST REGARDS.

@AlexPresso
Copy link

AlexPresso commented Aug 9, 2023

Okay... It's going way too far, and it's absolutely untrue, I have to answer that.

You insulted me, you treated me badly and you were rude to me.

?! I was maybe wrong to think you are the other guy but insulting you or treat you badly, this never happened. (AlexPresso/VideoStation-FFMPEG-Patcher#65)

I then found out that your installer made permanent changes and errors to my system and I had to uninstall and reinstall everything to get it clean of those changes.

How are these "permanent changes" different from the other wrapper ? Do you know it's literally suggesting to use the "simplest" wrapper (aka my wrapper) for non advanced users ?

Your installer is made without respect for the stability of your users' systems and made without love.

Based on your message, I'm not sure you actually have any experience to judge what is "love" or what is "made with love", nor about optimization or stability... But if you feel you have, my repository is open to pull requests, you can start bringing some "love" in it... :)

When I installed your wrapper, I did not have the AME license loaded and that folder on my system did not exist

I should put it in the requirements, but my wrapper needs a real Synology hardware and a licensed AME, thanks for the feedback and sorry for the inconvenience.

The only one here who is copying ideas is you, because darknebular made the patch for devices with GStreamer in May 2023 and now you do the same, but it's worse.

That's good for him it was done before, but in my case, this workaround was gave by another user (nap-liu), in the following issue : AlexPresso/VideoStation-FFMPEG-Patcher#53 which I used to implement my own version. Yes, it took me some times, sorry for maintaining a free project and having a life/work at the same time.

[Edit:] Did you notice how similar are the DarkNebular's Gstreamer wrappers and the nap-liu wrapper ? interesting...
https://github.com/darknebular/Wrapper_VideoStation/blob/main/ffmpeg41-wrapper-DSM7_X-Simplest#L69
https://github.com/nap-liu/VideoStation-FFMPEG-Patcher/blob/rtd1296-ds6.2.4/gst-inspect-1.0-wrapper.sh#L3

Oh looks like nap-liu also uses a "/patch" directory :) ; no credits ? I'm not surprised.

The GStreamer libraries that you download with the darknebular installer end up in a separate folder and thanks to that, he can do a totally clean delete

Basically that's why I'm referencing every files in an array (do you know what is an array ?) : https://github.com/AlexPresso/VideoStation-FFMPEG-Patcher/blob/main/patcher.sh#L35 everything in this array is removed if you unpatch...

And yes, the darknebular installer and its wrapper is much better than yours Alex. The darknebular installer can patch MediaServer and VideoStation at the same time

My patcher is called VideoStation-FFMPEG-Patcher, it's only related to VideoStation and it will always be like this... I deeply think it's more clear for the users to separate these patch into different projects.

For all this, I hope that people get to know you and know in advance all these problems and how rude you can be.

Okay. I also hope people will make their own opinions about all of this.

@AlexPresso
Copy link

he also copied me the checks to know if the script was being launched in root or not. Until then, his installer was trying to install things without permissions

That's funny you think everything you do is your work when the same code is the first result on StackOverflow... which everyone (me too) uses...

Another funny thing is how similar is your patcher code and mine since it's second version... Did you get any help from me writing it ? :)

@AlexPresso
Copy link

Anyway, coming back here was a terrible mistake, I was very happy before doing it and I should do it again. Wish you all the best.

@AlexPresso
Copy link

AlexPresso commented Aug 9, 2023

And I want to add more things about the AlexPresso's wrapper. I also experienced errors in other Synology apps (Synology Photos, Audio Station, Surveillance Station)

That's lies (again) :)
The wrapper only patches specific files (ffmpeg27, ffmpeg33 and ffmpeg41) if they exists, these files are exclusively used by VideoStation.
The one used by surveillance is called : ffmpeg33-for-surveillance and remains unchanged after patch (same for audio):

root@Kloudy:/var/packages/CodecPack/target/pack/bin# ll
total 1072
drwxr-xr-x 2 root root   4096 Aug  7 17:42 .
drwxr-xr-x 6 root root   4096 Jul 16 13:03 ..
lrwxrwxrwx 1 root root     44 Aug  7 17:42 ffmpeg27 -> /var/packages/VideoStation/target/bin/ffmpeg
-rwxr-xr-x 1 root root 226040 Mar 24 03:21 ffmpeg27.orig
-rwxr-xr-x 1 root root 250896 Mar 24 03:21 ffmpeg33-for-audio
-rwxr-xr-x 1 root root 250888 Mar 24 03:21 ffmpeg33-for-surveillance
lrwxrwxrwx 1 root root     44 Aug  7 17:42 ffmpeg41 -> /var/packages/VideoStation/target/bin/ffmpeg
-rwxr-xr-x 1 root root 259024 Mar 24 03:21 ffmpeg41.orig
lrwxrwxrwx 1 root root     53 Aug  7 17:42 gst-inspect-1.0 -> /var/packages/VideoStation/target/bin/gst-inspect-1.0
-rwxr-xr-x 1 root root  44176 Mar 24 03:21 gst-inspect-1.0.orig
lrwxrwxrwx 1 root root     52 Aug  7 17:42 gst-launch-1.0 -> /var/packages/VideoStation/target/bin/gst-launch-1.0
-rwxr-xr-x 1 root root  35688 Mar 24 03:21 gst-launch-1.0.orig
-rwxr-xr-x 1 root root   6072 Mar 24 03:21 gst-plugin-scanner

@dsfans
Copy link

dsfans commented Aug 9, 2023

I should put it in the requirements, but my wrapper needs a real Synology hardware and a licensed AME, thanks for the feedback and sorry for the inconvenience

My NAS is original, when you install the AME you must to load and activate the license in AME.
THIS IS HAPPING WITH YOUR WRAPPER WITHOUT THE LICENSE IN AME, and yes It's occurring too in real synology hardware.

These files names was changed recient, because in older DSM there were ffmpeg33 and ffmpeg27 only.

Ciao!!!

@AlexPresso
Copy link

My NAS is also official and I have a license. No one ever complain about the license when using my wrapper before ¯_(ツ)_/¯.

arrivederci 👋

@darknebular
Copy link

darknebular commented Aug 9, 2023

Alex, Stop mention to me or insinuate that I copy anyone without mentioning, that only you have done with me.
And yes, dsfan is right, the very first that you install AME in original hardware, you need to download and load the license.

This issue Will occur with your installer in This case.

And I tell you again, STOP MENTION TO ME OR MY WRAPPER.

ENJOY YOUR "fantastic" LIFE!!!

@darknebular
Copy link

The one used by surveillance is called : ffmpeg33-for-surveillance and remains unchanged after patch (same for audio

And yes again, the synology photo use ffmpeg33 ...

Ummm perhaps dsfan is right here too...xD

Sayonara!!!

@darknebular
Copy link

darknebular commented Aug 9, 2023

My NAS is also official and I have a license. No one ever complain about the license when using my wrapper before

Perhaps your users is having problems and they don't Know where the problem is when they uninstall your wrapper after installation of This license in AME.

These users must re-install again the AME package for fix It.

You must to Know that This license must be loaded and activated, including in real synology hardware.

I am done with you.

@REDoxONA
Copy link

REDoxONA commented Aug 10, 2023

Good morning,

I just created this account here, this is my first post and I did it because I hate arrogant and cynical people.
(Alexpreso) You're always complaining about people copying your code, I've checked version 2 of darknebular and it looks nothing like yours. The only part that has been copied or forked is your wrapper, which he has called "Simplest Wrapper" and he did a little changes and you are mentioned in that part of his code.
I also think that Darknebular's work is fabulous and that his wrapper is better than yours.
I have read the entire thread and it is true that 2 years ago (he didn't have any install script yet at that time) darknebular told you that you were using his version in your installer and that you did not mention him and instead of apologizing, you were arrogant and rude to him, you belittled his work. He has shown you that it was this way.

You should be more humble and accept criticism from others and not seek confrontation as you have done recently.

If I were him, I wouldn't even mention you in the simplest one because of your comments...

### BUGS FROM ALEXPRESSO's WRAPPER: (NONE OF THESE BUGS ARE PRESENT IN THE DARKNEBULAR WRAPPERS)

BUG 1:

I too have suffered from permanent changes because of AlexPresso and his arrogance.
image
image

I have a legal Synology, a DS120, which when I installed for the first time, before configuring the language or anything in the system, obviously the AME license was not loaded, I did not know it and I installed the Alexpresso wrapper:
image
The path to /var/packages/CodecPack/target/pack/... doesn't exists.
image
The script patched me in /var/packages/CodecPack/target/bin:
image

Nothing worked fine and then I installed the AME license with my Synology's account:
image

Now I have the correct path to /var/packages/CodecPack/target/pack/bin and nothing worked, I reinstalled again your script, and patched well in /pack folder and I had this working, until I decided to uninstall your wrapper and many things stopped working for me. I checked that the changes in /var/packages/CodecPack/target/ were permanent. After installing the AME license, there were there all links now, not binaries, and one of them pointing to VideoStation binary. This happens when you install your wrapper before the official license in AME.
image
image

BUG 2:

Now if I forget that I had your wrapper installed and decide to uninstall VideoStation, Synology Photos won't load and videos stored in Synology Photos won't show up, Media Server (DLNA) does not work either, the movie doesn't start using DLNA.

image
Because those programs make use of the CodecPack's ffmpeg and point to a non-existent VideoStation binary.

BUG 3:

Yes, we know what an array is, that you think you're smarter than other people.
The problem is that if within that array to download the gstreamer libraries that file or library already exists on your system, when you uninstall your wrapper, that library will be lost forever. You cannot 100% ensure a 100% clean install or a 100% clean uninstall with your procedure.

It is much better to use a separate folder, for example /patch, that It's very generic name and clear.

BUG 4:

It's true, videos with 7.1 don't work well. I've tried hevc 4k + TrueHD 7.1 and EAC3 7.1 and it didn't work with your wrapper. I will open an incident on your page. (But with the Darknebular's Advanced Wrapper, I can see these movies with 7.1 without any problem)
image

Sometimes with infinite loadings:
image

BUG 5:

Your Installation script is leaving shit and junk files around the system without deleting them...even if i uninstalled your wrapper.
image

image

BUG 6:

Your script and your wrapper generate a ffmpeg.log file that grows uncontrollably to infinity and when it exceeds the barrier of many megabytes, in certain synologys everything slows down in the VideoStation or in other applications that use the CodecPack.
Because you don't delete that file when you uninstall the wrapper.

BUG 7:

It's true too, videos with AAC audio codec in system without AAC enabled, doesn't works. I have another NAS without AAC license and with your wrapper I can't see them: (But with the Darknebular's Wrappers (Simplest and the Advanced) I can see these movies with AAC)
image

image
I will open an incident on your page.

And now tell me that I am also a liar or that I don't know how you do with others...

Regards.

@darknebular
Copy link

Screenshot_20230810-160605

@darknebular
Copy link

That's funny you think everything you do is your work

Well, here you copy the idea to check the root, this verification is not necessary for you, you told us it was a bullshit feature...

@AlexPresso
Copy link

AlexPresso commented Aug 10, 2023

his verification is not necessary for you, you told us it was a bullshit feature

Where did you see me say "it's a bullshit feature" ?

@darknebular
Copy link

darknebular commented Aug 10, 2023

For you, all of my checkers was a bullshit...and you Knew It.
Screenshot_20230810-184836

@AlexPresso
Copy link

AlexPresso commented Aug 10, 2023

Good evening @REDoxONA
First of all, thank you for taking a little time to post issues on the repository, I will also make a time to investigate on that, you already said you don't have any log files but I need a little bit more information from the bug issue template.

You should be more humble and accept criticism

If you knew me in real life, I hope you could see and make a better opinion of me about being humble. But about "accept criticism", I'm very open to it.
But there's a huge difference between: Saying "this feature is not present" (which in fact is not true) and Saying "there's a better way to do it".

BUG 1 (it's not a bug)

This is expected behavior, all these symbolic links are removed when unpatching. Having a symbolic link into /var/CodecPack/target/bin pointing to VideoStation's ffmpeg has the same effect of having a symlink (ffmpegXX) pointing to symlink (../pack/ffmpegXX) pointing to the VideoStation's ffmpeg. It just removes one symlink.

BUG 2

You are also right, I'm expecting people to unpatch by themself before removing VideoStation, I will also make a fix for this.

BUG 3 (it's not a bug):
Yes, we know what an array is, that you think you're smarter than other people.
The problem is that if within that array to download the gstreamer libraries that file or library already exists on your system, when you uninstall your wrapper, that library will be lost forever. You cannot 100% ensure a 100% clean install or a 100% clean uninstall with your procedure.
It is much better to use a separate folder, for example /patch, that It's very generic name and clear.

This one is not a "bug", it's an "enhancement". Of course having /patch directory is a better idea, but the libraries and gstreamer plugins are downloaded because they're all missing in the system by default, there's actually no case where a library could be overwritten or removed by mistake.

BUG 4 (working for me):

This one is working fine on my DS218Play but thank you for opening an issue on the repository for this one, I will have a look.

BUG 5:
Your Installation script is leaving shit and junk files around the system without deleting them...even if i uninstalled your wrapper.

The tmp directory is cleaned after every reboot.
These "junk files" are actually just two files (three if you have an architecture using gstreamer).

  • tmp.wget : I use it as a temporary file to download files and check everything ok before moving it to the right directory
  • ffmpeg.log : this is the file containing ffmpeg logs (I need this when you post an issue)
  • gstreamer.log : same as ffmpeg.log but for gstreamer

But wait... If you have a ffmpeg.log file, why did you say in your issue you don't have any log file ? 🤔AlexPresso/VideoStation-FFMPEG-Patcher#81

BUG 6:

That's a real problem, you're right, I will make a fix for this, thanks for making me realize. In my case I'm rebooting my NAS every week so I never faced this issue but for people keeping their NAS in sleep state / always up that's a real problem.

BUG 7 (working fine for me too):

This one is also working fine for me but I look at it, thanks for opening an issue.

And now tell me that I am also a liar or that I don't know how you do with others...

I don't know you and you also don't know me. I really appreciate you took the time to write this extensive feedback (without being too much cynical of course, because you hate that).
I just want to say, and I'm sorry in advance if it's not true (anyway even if it could be right you'll never say it): I don't know if it's just me but I can't stop thinking your writing style / comment design is so much similar to DarkNebular/dsfans, also same language in VideoStation... I don't know... That's very curious for me and I don't believe in "by chance" after it happens two times with 2 new accounts (and another one which made a fork just to change the readme; https://github.com/djhibee/VideoStation-FFMPEG-Patcher )

Are you sure I am the one "seeking confrontation" ?

@AlexPresso
Copy link

@darknebular

What I meant by the checks is about your image comparing the wrappers side by side, the "checks" are not about the "root user", it's about every comparison you make in this image.
Most of these were absolute bullshit for me as these features were also inside my patcher

@Denton22
Copy link

@AlexPresso @darknebular yeesh you two need to get a room... and less aderal....
Both of you are talented and competition is a great thing, but this is a very very niche project and does not warrant such behaviour....
This is not the linux kernel and just because people like Torvalds do it, does not mean you should take that as inspiration for your behaviour.

Please get along, the world is a shit enough place without the two of you bashing heads. And i need to unsub from this thread asap....

@AlexPresso
Copy link

AlexPresso commented Aug 10, 2023

BUT YOU HAVE MENTIONED ME AGAIN AND INSULTED ME

Actually I was just offensive with you, but I never insulted you, you did.

STOP INSINUATING THAT I COPY YOU, THAT'S A LIE

We both know it's wrong and anyway, I don't care that much, your adaptation of my patcher.sh code seems very messy for me.

YOU SEEM TO ME A TOXIC AND MANIPULATORY PERSON

Oh really ? Okay, that's your opinion. But what are these alt accounts you create to congrats yourself in comments / issues / forks ? I have same opinion for you.

THE RESULT HAS BEEN 7 BUGS

No. The result is:

  • 2 potential ""bugs"" (let's wait for the OP to answer in the issue / here why he says he doesn't have a log file when a screenshot shows one...)
  • 1 confirmed bug (log files growing in /tmp if no reboot)
  • 3 enhancements

And for me, that my installer stops and gives you a warning that you had previously installed my Wrapper seems much more elegant than your solution.

Yeah it's very elegant way to do it I agree. I was also thinking about adding something like that when he complained about patching two times after licensing AME.

@Denton22 Yeah, sorry for all of that

I'm also unsubbing so if you want to continue talking let's do it on Discord (alexpresso).

@darknebular
Copy link

@Denton22 thanks for your words.

@KidWar75
Copy link

We both know it's wrong and anyway, I don't care that much, your adaptation of my patcher.sh code seems very messy for me

Messy? Again, STOP MENTION TO ME OR MY WRAPPER. I don't take any from yours, except your fucking wrapper aka Simplest. I am thinking to quit your mention in the Simplest, due your ofensive comments.

CAN YOU?

STOP BE OFFENSIVE WITH ME.I ONLY HAVE ONE ACCOUNT ASSH0...

STOP RIGHT NOW!!!!!

How the fuck can you be that salty?

Have you ever considered seen someone for your anger management? You seem in pain.

The only offensive person between the two of you is… you.

@REDoxONA
Copy link

BUG 1

This is expected behavior, all these symbolic links are removed when unpatching. Having a symbolic link into /var/CodecPack/target/bin pointing to VideoStation's ffmpeg has the same effect of having a symlink (ffmpegXX) pointing to symlink (../pack/ffmpegXX) pointing to the VideoStation's ffmpeg. It just removes one symlink.

Yeah, the efect is when you uninstall VideoStation, a lot of program stop working.

BUG 3

This one is not a "bug",

It has a potential bug, can you ensure 100% that these files don't be exist in the future? No, you can't.

BUG 4
I don't have a Play device, in others devices this isn't working with your wrapper.

BUG 5:

But wait... If you have a ffmpeg.log file, why did you say in your issue you don't have any log file ?
When I tried to play this kind of movies, your wrapper don't generate logs

BUG 7:
I don't have a Play device, in others devices this isn't working with your wrapper.

I don't know if it's just me but I can't stop thinking your writing style / comment design is so much similar to DarkNebular/dsfans, also same language in VideoStation

Are you saying that I am darknebular? wtf??? Well, listen, I am using Google Translate, It would explain it. But not, I am another person.

@REDoxONA
Copy link

@darknebular

Now that I have an account, you deserve my star.

You've done a fabulous job, calm down, Alex is provoking you but we know it's the result of envy.

@REDoxONA
Copy link

You quit the repository?
image

@darknebular
Copy link

Until he kicked me out of GitHub he didn't stop

@Denton22
Copy link

darknebular has been suspended from github, because his behaviour is not ok

@KidWar75
Copy link

darknebular has been suspended from github, because his behaviour is not ok

Yep, I reported him :)

@darknebular
Copy link

darknebular has been suspended from github, because his behaviour is not ok

True, I have lost my composure.
But I can't spend all day with humiliating comments or belittling my work.

I don't deserve to have my entire account censored either.

@Denton22
Copy link

darknebular has been suspended from github, because his behaviour is not ok

Yep, I reported him :)

Me too...

@darknebular
Copy link

darknebular commented Aug 11, 2023

Ok Thanks for all!!!

I don't deserve to have my entire account censored either, perhaps only the comments...

@REDoxONA
Copy link

This is very sad.
He did a great work there!!!

@dsfans
Copy link

dsfans commented Aug 11, 2023

That's lies (again) :)
The wrapper only patches specific files (ffmpeg27, ffmpeg33 and ffmpeg41) if they exists, these files are exclusively used by VideoStation.

Are you calling me a liar here? Do you know me?...You don't, Capichi?

I spent 3 weeks of my life solving a problem with the Video Cameras App because of your wrapper, Alex, yes it's true, there is a dedicated binary, but perhaps you don't know that when you store videos of recordings with rare formats, the system jumps and uses ffmpeg41 and it didn't work for me because I didn't realize that and that ffmpeg41 was pointing to a binary that no longer existed on my system.

By the way, I just tried to enter the darknebular profile and I was able to access it. It looks like good!!!

@dsfans
Copy link

dsfans commented Aug 11, 2023

I don't deserve to have my entire account censored either, perhaps only the comments...

We know what AlexPresso is trying to do with you. Do not respond to their provocations. We know that the only thing you used was its wrapper.

Don't worry and again thanks for your Wrapper, it works great.

@REDoxONA
Copy link

By the way, I just tried to enter the darknebular profile and I was able to access it. It looks like good!!!

Good news!!!!

@darknebular, don't worry, you've done a great job there and right now I'm going to give you the star you deserve.

@darknebular
Copy link

Thanks a lot guys.
image

REDoxONA si viajas a Madrid tienes una cerveza pagada por mi!!!

@darknebular
Copy link

The Installer´s Script version 3.9.3 Wrapper with 5.1 and Configurator Tool:

Fully tested, fully stable, fully configurable using the Advanced Wrapper.

NOW YOU WILL HAVE: (Only when It´s necessary to activate my wrapper. This means transcoding of DTS, EAC3 and TrueHD.)

  • In MediaServer DLNA = [1) AAC 5.1 512kbps AND 2) MP3 2.0 256kbps.] (by default) (If exists)
  • In VIDEO-STATION = [1) MP3 2.0 256kbp AND 2) AAC 5.1 512kbps.] (by default)
  • You now can change the 5.1 audio´s codec from AAC 512kbps to AC3* 640kbps independently of its audio´s streams order in VIDEO-STATION and DLNA MediaServer using the configurator tool embedded into the installer.sh.

*(AC3 is more compatible with legacy 5.1 devices).
Avoid permanent errors, unlike other Internet Installers. There are other installers on the internet that produce permanent errors on your systems even after uninstalling them. Be careful. This does not happen with my Wrapper and my installer.

ADD-ONs or FIXES FROM 3.9.1:

  • Tested and working fine in a lot of Synology´s models.
  • Homogenize the closing of processes in the Simplest Wrapper with the Advanced Wrapper, to correct a bug carried over from Alex's code (the Simplest Wrapper). The Advanced Wrapper was and is working fine and don't need fix it.
  • Fixed the possibility to enter to the Start menu if you haven't got the AME License and you want to install the patch for the license in a XPEnology system.

Check It out:
Connect using SSH (Maximize the window for read better the menu) and then:

Enter:
sudo -i

And then:

INSTALL / UNINSTALL:

The BASIC command (you will see the Main Menu and all options):
bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")"

...

OTHER FLAGS:
Enter for installing:
bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s autoinstall

Or (for uninstall it...)

Enter for uninstalling:
bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s uninstall

CONFIGURATOR TOOL:

Enter:
bash -c "$(curl "https://raw.githubusercontent.com/darknebular/Wrapper_VideoStation/main/installer.sh")" -- -s config

https://github.com/darknebular/Wrapper_VideoStation

...

Please give a star in my repository if you like my wrapper or if you find It useful. Thanks...

BEST REGARDS.

@AlexPresso
Copy link

AlexPresso commented Aug 11, 2023

@darknebular

But I can't spend all day with humiliating comments or belittling my work

I'm just answering you, you have no need to insult me.

the system jumps and uses ffmpeg41 and it didn't work for me because I didn't realize that and that ffmpeg41 was pointing to a binary that no longer existed on my system

Oh you are also patching VideoStation and removing it without unpatching... Same test as @REDoxONA ("capichi" is spanish, you didn't say you are Italian ?). Yes. I don't believe you are a legitimate account.

Of course removing VideoStation withouth unpatching creates an issue, I'm working on fixing that.

We know what AlexPresso is trying to do with you

I'm not trying to do anything with him, actually I didn't report him at the time (I said him on Discord after he added me). The only thing I want is make other people see he's actually (and was) saying a lot of wrong things about me and my wrapper. If I'm not doing that, people won't know and they would just end to believe him. That's the reason he's angry in my opinion, because I'm coming here to show everyone when he's wrong.

Github removing his work or account is not what I want because he also spent time for this project. But to be honest I would be very glad if they could prevent him from creating new accounts, using my name/talking about me or my projects, seeing my projects or contacting me in any way. It's up to them to chose the better way to do it.

@AlexPresso
Copy link

By the way, about your bugs @REDoxONA you didn't answer this part:

But wait... If you have a ffmpeg.log file, why did you say in your issue you don't have any log file ? thinkinghttps://github.com/AlexPresso/VideoStation-FFMPEG-Patcher/issues/81

@dsfans
Copy link

dsfans commented Aug 11, 2023

Capichi is the vulgar form and Capisci is the correct, in the street you can use both. And yes this is a Italian word.

He is not talking about your wrapper at any time. However, whenever you can, you do, with comments that he copies you, that he has bullshit features, curious that little by little you are copying many of those "features" too.

@Denton22
Copy link

Ok Thanks for all!!!

I don't deserve to have my entire account censored either, perhaps only the comments...

Great to have you back, hopfully a bit more composed, would be a shame to see that happening again

@AlexPresso
Copy link

AlexPresso commented Aug 11, 2023

@dsfans

Capichi is the vulgar form and Capisci is the correct, in the street you can use both. And yes this is a Italian word.

Oh okay, I didn't know that, my bad then.

He is not talking about your wrapper at any time

https://github.com/darknebular/Wrapper_VideoStation/issues?q=is%3Aissue+alex

hat he copies you, that he has bullshit features

Did you look at his Offline_installer code ? the functions for logging and how to trigger the workflow are very similar... You can actually notice it's not his code because everything else is having a complete different coding style, like : no for loops, not ordering/grouping functions together.
I'm not saying his patcher is not working, I'm just saying he has copied a lot of things from mine and he still acts like my patcher is bad or I don't know but actually he's taking a lot from it.

I'm a bit lazy so I didn't put everything but you can see where he copied and tried to mix with his own way of coding to make it appears as his own code. Do you get why he is angry when I answer his messages now ?

I never said he has bullshit features, I said this comparison image (https://github.com/darknebular/Wrapper_VideoStation#tests-installers) is bullshit, most of the places where he places a red cross are wrong and he knows it.

@AlexPresso
Copy link

AlexPresso commented Aug 11, 2023

Anyway, this PR, fixing the bugs you reported is in a beta state and looking for testers. If anyone wants to (the testing procedure is detailed in the comments): AlexPresso/VideoStation-FFMPEG-Patcher#83

  • Bug 1 : Was not a bug but removed this symlink as it was not improving performances that much.
  • Bug 2 : Fixed, everything now gets automatically unpatched if you uninstall VideoStation.
  • Bug 3 : Not a bug, it’s an enhancement, I will keep this one in my todo for now.
  • Bug 4 : Waiting for your input in the issue.
  • Bug 5 : Fixed, the tmp.wget gets removed after patching/unpatching and the wrappers are now only logging into .stderr files (which get removed after process termination).
  • Bug 6 : Fixed by the fix in Bug 5 ; For this one I also added a “issue-report.sh” script to generate a report and simplify the steps for people opening bug issues and make it more easier to include the log files.
  • Bug 7 : Waiting for your input in the issue.

(to give my patcher a little more love) I also added a linter to check for potential code issue.

@dsfans
Copy link

dsfans commented Aug 11, 2023

JAJAJAJAJAJA

You are saying that he copy you Code because he used a commented box like you for sections?
And he use a intro with a conditional and you a message of the day?

JAJAJAJA JAJAJAJA

@dsfans
Copy link

dsfans commented Aug 11, 2023

That to me is not copying code. For me, copying code is what you did, hundreds and hundreds of lines of his version 12.1 and 12.2 wrapper, up to the last comma at the end and without mentioning him. And he asked you to please (on 3 occasions) to mention him and you replied that they were changes that anyone with little knowledge could make (you again belittled his work), after they were minor changes (you again belittled his work), Many things were fixed thanks to those "small" changes in Benjamin's original Wrapper and you know it. In the image it doesn't say anything about your wrapper, it talks about other installers. Many of the things that you told him were bullshit (you put him down again) like stopping the installation if it detected the Wrapper previously installed for you were trivial and now you're copying the idea. The AME license check you said it was not necessary, that your script works fine without that check and that it was trivial and a Holy Shit and now you are copying the idea from him, we will see if it is not so well part of his code. You never stop mentioning him, in the previous message you write things like he's wrong, what exactly is wrong? (again belittling him, making it look like he's wrong and presenting yourself as the "savior" to his mistakes), now you go back to shitting on him, you mention him again, to say that he copies you and you present us with a fucking comment box and put an intro that makes it different on top? Excuse me, but I must be laughing. If people read you, they will think that all the work is yours and that is a lie. I'm going to ask you too, if you only have those "proofs" better stop saying that he copies your script and stop mentioning him every day and stop manipulating.

@txsastre
Copy link

Thanks a lot guys. image

REDoxONA si viajas a Madrid tienes una cerveza pagada por mi!!!

I already gave you a star, I want my beer to. xD

Eso, que yo también quiero birra. Ánimos @darknebular , buen trabajo.

@darknebular
Copy link

darknebular commented Aug 11, 2023

Eso, que yo también quiero birra. Ánimos @darknebular , buen trabajo.

❤❤❤❤❤❤❤❤❤❤
OEEE MUCHAS GRACIAS!! Tú también eres o hablas español?
Para ti también por su puesto... Espero que ahora no coja y diga que tu cuenta soy yo también que me auto-escribo dice jajajaja, como ha dicho de las otras 2 cuentas anteriores...xD

Sólo tengo esta cuenta y hoy casi la pierdo por entrar al trapo con él. Supongo que él lo hará y por eso lo ve factible que yo también lo haga.

Saludos.

#################

For you too, of course... I hope that now he doesn't pick up and say that your account is also me who writes myself, he says hahahaha, as he said about the other 2 previous accounts... xD

I only have this account and today I almost lost it for going to the rag with him. I suppose that he will do it and that is why he sees it feasible that I do it too.

Greetings.

@REDoxONA
Copy link

(to give my patcher a little more love) I also added a linter to check for potential code issue.
@AlexPresso

I've been thinking about it deeply and I've decided not to continue helping you to improve your wrapper, you don't deserve it.

Until I showed you the bugs you didn't know they existed. How is it possible that darknebular didn't have any of those bugs if according to you, he doesn't use his brain? Well, I'm going to answer you, because he has spent a lot of time debugging and trial and error and you haven't.

And if you keep saying that I'm darknebular (which I'm not), you should at least wash your mouth and thank him for telling you all those bugs, which you call "enhancements"...

Best regards.

@darknebular
Copy link

darknebular commented Aug 11, 2023

THESE ARE OBJECTIVE FACTS AND NOT "FEELINGS OR THE LIKE": THE TRUTH ONLY

The 12.2 was launched in April 2021: (Version 12.1 was even earlier than that date)
image

I asked you up to 3 times to at least mention me and I asked you please, you laughed at my improvements and copied all my first versions and improvements made on Benjamin's wrapper and then you said you didn't.
image

image

### I changed the binaries order in 12.1, delete some commands, fix the logging in order to have only error output and not all output, change the names in the methods with more logical names, you Copy-Paste ALL my changes and ALL my wrapper's fixes or Versions without mention to me and now you are crying because I did a fork from your Simplest? At least I mention to you into the Simplest's wrapper.

LEFT IT'S MY INITIAL WRAPPER'S VERSION 12.1, RIGHT IT'S THE DEPRECATED BENJAMIN'S WRAPPER 12 VERSION.
image
image
image

Here "Alex's" wrapper "from" the "Benjamin's one", but It was really a Copy-Paste from MY INITIAL VERSION 12.1:

image
image
image

I know why I put this 22 there, you don't.

Could you explain this 22 there? No, You can't do it. UP TO THE LAST COMMA, IT WAS AN EXACT COPY PASTE

@txsastre
Copy link

txsastre commented Aug 11, 2023

Eso, que yo también quiero birra. Ánimos @darknebular , buen trabajo.

❤❤❤❤❤❤❤❤❤❤ OEEE MUCHAS GRACIAS!! Tú también eres o hablas español? Para ti también por su puesto... Espero que ahora no coja y diga que tu cuenta soy yo también que me auto-escribo dice jajajaja, como ha dicho de las otras 2 cuentas anteriores...xD

Sólo tengo esta cuenta y hoy casi la pierdo por entrar al trapo con él. Supongo que él lo hará y por eso lo ve factible que yo también lo haga.

Saludos.

#################

For you too, of course... I hope that now he doesn't pick up and say that your account is also me who writes myself, he says hahahaha, as he said about the other 2 previous accounts... xD

I only have this account and today I almost lost it for going to the rag with him. I suppose that he will do it and that is why he sees it feasible that I do it too.

Greetings.

From Spain.
I have to say that is sort of sad to see this kind of discussion here, in a place that open source means "sharing".

I've used both and both do the trick for me, be able to see movies.

Don't waste your time fighting each other, I'm very grateful for your work and the time you have spend for developing this and sharing your knowledge.

And no, I'm not "darknebuka*, I work as system admin and networks, I left behind development.

Now I'm using @darknebular and sometimes ask if it's possible to see subtitles xD. (Yes you said the problem is Synology).

Please peace here.

@darknebular
Copy link

Peace!!!

@geoff2k
Copy link

geoff2k commented Aug 11, 2023

I wish you all could harness this energy and channel it into something productive.

This clearly is something you are both passionate about, but the negativity that this is bringing into your lives can't be worth it.

@AlexPresso
Copy link

Peace

@kalety
Copy link

kalety commented Aug 12, 2023 via email

@darknebular
Copy link

Hi guys, it will be possible “Things” like HDR, 4K, etc in our loved Sinologys?
image
image
image
image

I think that YES!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment