Skip to content

Instantly share code, notes, and snippets.

@BenjaminPoulain
Created May 8, 2013 01:38
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save BenjaminPoulain/5537575 to your computer and use it in GitHub Desktop.
Save BenjaminPoulain/5537575 to your computer and use it in GitHub Desktop.
Index: Source/WebCore/ChangeLog
===================================================================
--- Source/WebCore/ChangeLog (revision 149704)
+++ Source/WebCore/ChangeLog (working copy)
@@ -1,3 +1,13 @@
+2013-05-07 Benjamin Poulain <bpoulain@apple.com>
+
+ We should not ref() the RefPtr twice in CanvasStyle
+
+ Reviewed by NOBODY (OOPS!).
+
+ * html/canvas/CanvasStyle.cpp:
+ (WebCore::CanvasStyle::CanvasStyle):
+ We leak the ref of PassRefPtr, we should not ref() it a second time.
+
2013-05-07 Anders Carlsson <andersca@apple.com>
Begin unraveling the mess that is QuotesData
Index: Source/WebCore/html/canvas/CanvasStyle.cpp
===================================================================
--- Source/WebCore/html/canvas/CanvasStyle.cpp (revision 149696)
+++ Source/WebCore/html/canvas/CanvasStyle.cpp (working copy)
@@ -127,14 +127,12 @@
: m_type(Gradient)
, m_gradient(gradient.leakRef())
{
- m_gradient->ref();
}
CanvasStyle::CanvasStyle(PassRefPtr<CanvasPattern> pattern)
: m_type(ImagePattern)
, m_pattern(pattern.leakRef())
{
- m_pattern->ref();
}
CanvasStyle::~CanvasStyle()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment