-
-
Save BrockA/2625891 to your computer and use it in GitHub Desktop.
/*--- waitForKeyElements(): A utility function, for Greasemonkey scripts, | |
that detects and handles AJAXed content. | |
Usage example: | |
waitForKeyElements ( | |
"div.comments" | |
, commentCallbackFunction | |
); | |
//--- Page-specific function to do what we want when the node is found. | |
function commentCallbackFunction (jNode) { | |
jNode.text ("This comment changed by waitForKeyElements()."); | |
} | |
IMPORTANT: This function requires your script to have loaded jQuery. | |
*/ | |
function waitForKeyElements ( | |
selectorTxt, /* Required: The jQuery selector string that | |
specifies the desired element(s). | |
*/ | |
actionFunction, /* Required: The code to run when elements are | |
found. It is passed a jNode to the matched | |
element. | |
*/ | |
bWaitOnce, /* Optional: If false, will continue to scan for | |
new elements even after the first match is | |
found. | |
*/ | |
iframeSelector /* Optional: If set, identifies the iframe to | |
search. | |
*/ | |
) { | |
var targetNodes, btargetsFound; | |
if (typeof iframeSelector == "undefined") | |
targetNodes = $(selectorTxt); | |
else | |
targetNodes = $(iframeSelector).contents () | |
.find (selectorTxt); | |
if (targetNodes && targetNodes.length > 0) { | |
btargetsFound = true; | |
/*--- Found target node(s). Go through each and act if they | |
are new. | |
*/ | |
targetNodes.each ( function () { | |
var jThis = $(this); | |
var alreadyFound = jThis.data ('alreadyFound') || false; | |
if (!alreadyFound) { | |
//--- Call the payload function. | |
var cancelFound = actionFunction (jThis); | |
if (cancelFound) | |
btargetsFound = false; | |
else | |
jThis.data ('alreadyFound', true); | |
} | |
} ); | |
} | |
else { | |
btargetsFound = false; | |
} | |
//--- Get the timer-control variable for this selector. | |
var controlObj = waitForKeyElements.controlObj || {}; | |
var controlKey = selectorTxt.replace (/[^\w]/g, "_"); | |
var timeControl = controlObj [controlKey]; | |
//--- Now set or clear the timer as appropriate. | |
if (btargetsFound && bWaitOnce && timeControl) { | |
//--- The only condition where we need to clear the timer. | |
clearInterval (timeControl); | |
delete controlObj [controlKey] | |
} | |
else { | |
//--- Set a timer, if needed. | |
if ( ! timeControl) { | |
timeControl = setInterval ( function () { | |
waitForKeyElements ( selectorTxt, | |
actionFunction, | |
bWaitOnce, | |
iframeSelector | |
); | |
}, | |
300 | |
); | |
controlObj [controlKey] = timeControl; | |
} | |
} | |
waitForKeyElements.controlObj = controlObj; | |
} |
Hey Brock. Thanks for your help over on StackOverflow!
I'm looking to post my greasemonkey script on GreasyFork and it @includes waitForKeyElements. However, GreasyFork doesn't allow includes of GitHub scripts by default and someone else is hosting a version of your script on GreasyFork.
GreasyFork has Github sync functionality.
A GitHub webhook connected with Greasy Fork makes it so any push to your GitHub repository automatically updates your scripts on Greasy Fork in a matter of minutes.
I'd love to @include your script instead of a copy. If you aren't interested in creating a GreasyFork account let me know and I'll use the already posted script. Otherwise, point me to the GreasyFork version.
Best!
Jeremy
@GollyJer, Interesting, there appear to be at least 4 copies of waitForKeyElements on Greasy Fork:
3 out of 4 of them even credit me; I can die in peace! :D
Anywho, I've no interest in creating a Greasy Fork account at this time. Use whichever version/method that works best for you.
Seems the unacredited version is mine, fixed now, Cheers :)
@GollyJer You could also import this script as a resource, like this :
// @resource waitForKeyElements https://gist.githubusercontent.com/BrockA/2625891/raw/9c97aa67ff9c5d56be34a55ad6c18a314e5eb548/waitForKeyElements.js
then read it with GM_getResourceText("waitForKeyElements ") and inject it on page or eval it in script.
@BrockA - Apparently github is delivering notifications 11 months delayed? wtf... Anyways, many thanks for chiming in! I might still like to use it but I don't maintain disapproval plugin much these days, so not sure if I will ever get to it. Thanks for contributing to the hive mind just the same! =D
Thanks for that @panayot-zhi Updated my script to point directly at the gist.
https://greasyfork.org/en/scripts/13968-gollyjer-s-auto-expand-google-search-tools
@panayot-zhi - Even better yet, run the address through Git.io to get a shortened URL.
// @require https://git.io/vMmuf
Then use function normally.
A better link to the example is here: http://stackoverflow.com/questions/8281441/fire-greasemonkey-script-on-ajax-request/8283815#8283815
@hellonearthis And the problem itself is clearly described here: https://stackoverflow.com/questions/12897446/greasemonkey-wait-for-page-to-load-before-executing-code-techniques/12899331#12899331
Not sure if this has already been accomplished, but I couldn't find an example of this without the need for JQuery. I forked this and removed reliance on JQuery, though I had to hobble it by disabling the iframe search. Might help some though, and it works for my project. Thanks for your work @BrockA
@mjblay What a crazy coincidence. I have been re-writing it as well within this past week to no longer rely on jQuery, and I also ended up removing the iframe feature until I had more time to re-write that part in vanillajs. I had published a gist a couple of days ago, but I removed it after encountering a few bugs. I checked out your Gist/Github account and couldn't find the fork. Are you planning on publishing it on Github?
@mjblay, you're welcome.
@insanid I inadvertently deleted it. I re-added the fork here: https://gist.github.com/mjblay/18d34d861e981b7785e407c3b443b99b. I haven't tested it thoroughly, but it seems to be working on a private site I maintain and use daily.
Can this act within an iframe that is itself within an iframe?
@Gallion, not directly but it can help. If you need to, open a question about that on some place like Stack Overflow and give details and a working test case or link to the target page.
It's a very useful script but recently I met an issue. If waitForKeyElements already finds the element at the first run and the element disappears. The timer cannot be cleared since the element is not found anymore.
@EliezerWu, Even when you set bWaitOnce
to true?
Also, letting the timer keep running is not normally a problem.
Anyway, post a "Minimal, Complete, and Verifiable example" if you want me to investigate this further.
I don't know if you still want/need this, but I consider it:
Creative Commons, Attribution-NonCommercial-ShareAlike 4.0 International (CC BY-NC-SA 4.0)
I'm not going to lawyer-up in any case.
Hi =)
How can i do for commercial use?
It would be used to dynamically generate buttons with javascript codes to automate tasks in my work =)
thanks.
@josepelupi, And anyone else who wants to use this commercially...
Consider this free to use commercially until your install base exceeds twenty-thousand users. At which point, any fee would probably consist of a modest (3 digits or less) donation to EFF or similar.
You could add a comment to your code: "Used by permission of github.com/BrockA until install base exceeds twenty-thousand users."
How can i do for commercial use?
It would be used to dynamically generate buttons with javascript codes to automate tasks in my work =)
Many thanks for the reply. But i believe i was not clear enough in my question.
I have no intention of creating scripts to sell.
Im creating a script to share with my co-workers that automates parts of the activities we exercise while working (eg select options from a dropdown menu, fill out forms). So, my intention is to use waitForKeyElements to facilitate and allow the creation of dynamic buttons according to the elements that exist on the page.
So, i would like to know if it is allowed to include your code in my greasemonkey script to use it , "indirectly", for the purpose of commercial use.
thanks =)
Consider this free to use commercially until your install base exceeds twenty-thousand users. At which point, any fee would probably consist of a modest (3 digits or less) donation to EFF or similar.
@josepelupi, I did understand you. What you propose is still commercial use. If you get 20K people who use this, then let me know and we'll hash out a tiny donation, not to exceed $100, unless you cause me to incur costs in time or money.
But, I might suggest that if your script does approach 20K users, then some intranet team has not done their job well.
Until you get 20K people using the script, just comment in the code that you are legally covered.
This is a great script! I have modified it with what I feel are some important improvements (not requiring jQuery, not using setInterval()
, allowing a selector function instead of a string).
That's good, @CoeJoder. You might also consider one of the other forks (almost 100 on Gist alone) that uses MutationObserver
.
Yes, there are some quite fancy implementations among the forks. I would personally avoid using MutationObserver
unless needed, and also wanted to get the script into a regular github repo so it can be used with common CDNs (for some reason they tend not to work with gists).
I want to move the function into an object in a separate file that I call libraries.js. The object is called singleton as in
singleton.waitForTargetElements()
However, it throws an undefined error for waitForTargetElements at this line:
let controlObj = waitForTargetElements.controlObj || {};
If I add waitForTargetElements to the list of parameters, then controlObj throws an undefined error.
So my question is how do I decouple the scope so that the function can be placed in another file but can still be called?
This is a great script! I have modified it with what I feel are some important improvements (not requiring jQuery, not using
setInterval()
, allowing a selector function instead of a string).
THANKS EXACTALY WHAT I NEEDED.
BrockA Version , doesn't work when userscript //@run-at is set to document-start
@BrockA I have a few scripts that modify YouTube and I use your function to detect new elements. They are small, non-commercial and have around 200-300 installs each.
Today they were all reported on GreasyFork as "unauthorized copy of https://gist.github.com/BrockA/2625891" with description being: "On 10 Nov 2015, the original author said that the license is Creative Commons, Attribution-NonCommercial-ShareAlike 4.0 International (CC BY-NC-SA 4.0)."
I didn't know you can @include
a git io link so all of my scripts have a verbatim copy of yours at the bottom (I'd probably prefer to do that even if I knew, in case you ever took the gist down), with phrase "From: https://git.io/vMmuf" added in the top comment describing what they are. This is how the top two lines of your code look after this addition:
/*--- waitForKeyElements(): A utility function, for Greasemonkey scripts,
that detects and handles AJAXed content. From: https://git.io/vMmuf
My questions:
- have you reported all my YT scripts?
- are you okay or not with this usage (copy paste + link to your gist)?
I've decided not to wait anymore and submitted a rebuttal to all the reports saying you didn't ever mind or report small, non-commercial and credited use or forks on GreasyFork when learning of them in the past and that my script is small, non-commercial and links to your gist. Please confirm that this is okay with you.
All my scripts that used this gist were were deleted by a moderator. The message I've received:
I consider https://gist.github.com/BrockA/2625891#gistcomment-1617026 the most clear statement by the author. Please comply with the terms of that license.
That wasn't me and I don't see how it applies to you, unless you are somehow selling your scripts.
I wonder if it was a YT bot; they're really going sick over there.
Anywho, I have now released this utility to the public domain.
Thank you for the help. I've submitted even more appeals. I will update here if they are accepted or rejected. I will also make a complaint about this on GreasyFork forum.
I wonder if it was a YT bot; they're really going sick over there.
I don't know what a YT bot means in this context. The reports all linked to your comment about CC-BY-SA-NC and it was upheld by a GreasyFork moderator who ignored my wall of text about how you didn't disapprove/attack copies and forks of your gist.
Update 2021-10-17:
I now consider this utility as Public Domain:
Below is obsolete:
@terabyte,
I don't know if you still want/need this, but I consider it:
I'm not going to lawyer-up in any case.