Skip to content

Instantly share code, notes, and snippets.

@CameronWills
Last active May 30, 2019 13:11
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 1 You must be signed in to fork a gist
  • Save CameronWills/8f8ac455f34495c2ec2db76756b25c9a to your computer and use it in GitHub Desktop.
Save CameronWills/8f8ac455f34495c2ec2db76756b25c9a to your computer and use it in GitHub Desktop.

Pull Request Checklist

Mark [x] to those completed. Delete sections that don't apply.

Linting
[] Fixed CSS errors? [] Fixed JS errors?

Browsers
Have you tested this in: [] Chrome? [] Firefox? [] Safari? [] Edge? [] IE 11? [] Safari on iOS? [] Chrome on Android?

Responsive
Have you tested this at the following breakpoints: [] 320px? [] 360px? [] 375px? [] 600px? [] 768px? [] 960px? [] 1024px? [] 1280px? [] 1400px? [] 1600px?

Markup
[] Validated the markup? [] Used a sensible heading hierarchy without skipping levels? [] Provided visually-hidden, meaningful text for non-sighted users?

Backend cshtml [] Updated the relevant cshtml file/s?

Accessibility
[] Ensured all interactive elements have appropriate :hover & :focus states? [] Added appropriate aria, alt, for and id attributes? [] Ensured all interactive elements are reachable & usable with the keyboard? [] Tested in a screen-reader (VoiceOver, ChromeVox, NVDA or Lynx)?

SVG
[] Visually centered it on a 100x100 canvas? [] Simplified and consolidated paths?

Optimisation
[] Minified public/images? [] Minified public/svg? [] Minified public/logos? [] Minified public/favicons?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment