Skip to content

Instantly share code, notes, and snippets.

@CvH
Created July 14, 2017 10:14
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save CvH/ad2b6a330b73fae4feaf44233f18ccd1 to your computer and use it in GitHub Desktop.
Save CvH/ad2b6a330b73fae4feaf44233f18ccd1 to your computer and use it in GitHub Desktop.
Subject: [media] lirc: LIRC_GET_REC_RESOLUTION should return microseconds
From: Sean Young <sean@mess.org>
Date: Tue, 11 Jul 2017 10:47:37 +0100
Since commit e8f4818895b3 ("[media] lirc: advertise
LIRC_CAN_GET_REC_RESOLUTION and improve") lircd uses the ioctl
LIRC_GET_REC_RESOLUTION to determine the shortest pulse or space that
the hardware can detect. This breaks decoding in lirc because lircd
expects the answer in microseconds, but nanoseconds is returned.
---
drivers/media/rc/ir-lirc-codec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/rc/ir-lirc-codec.c b/drivers/media/rc/ir-lirc-codec.c
index a30af91..d2223c0 100644
--- a/drivers/media/rc/ir-lirc-codec.c
+++ b/drivers/media/rc/ir-lirc-codec.c
@@ -266,7 +266,7 @@ static long ir_lirc_ioctl(struct file *filep, unsigned int cmd,
if (!dev->rx_resolution)
return -ENOTTY;
- val = dev->rx_resolution;
+ val = dev->rx_resolution / 1000;
break;
case LIRC_SET_WIDEBAND_RECEIVER:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment