gistfile1.txt

DB/Object: Add missing Dirt mound spawn
DB/Creature: Forlorn SoulAdd missing spawns

DB/Conditions: Judgment Day Comes!This optional breadcrumb quest should not be takable if player has already started quest chain it leads to.
Build: Added 1.60 Boost version to FindBoost
DB/Creature_text: Fix probability inside a groupCloses #16093

Core/Objects: Fix typo in 19cab2c50857045788bd80e202ed661e49ed8bba
DB/Event: Add all remaining Feast of Winter Veil spawns in whole Outland and Dalaran
Auth/Login: Rename config key usageRelated: 193dd505

Config/AuthServer: Rename Wrong.Password.Login.Logging to WronPass.Logging and move to correct section.
Merge pull request #16066 from Treeston/3.3.5-penanceSpells/Penance: Fix erroneous cooldown on misplaced hostile target
Merge pull request #15995 from ShinDarth/mmrCore/Arena: more arena configs
Spells/Penance: If hostile target is not in front, now fails in the initial cast rather than the triggered cast, thus not erroneously causing a cooldown.
DB/Quest: Quest: The Air Stands StillCloses #16032

DB/SAI: Fix some Spamming spells on health pctBy: @Treeston
Closes #16034

DB/Creature: Remove a duplicate spawn for Lovely LiddiaCloses #16036

DB/Creature: Add Magic immunity to Mana FeedersCloses #16050

DB/Creature: Remove Hover mode for Agent KearnenCloses #16057

DB/SAI: Fix a target typo in a previous commit
DB/Conditions: Fix a levelling Exploit (3.3.5 only)Fix a levelling exploit with http://www.wowhead.com/quest=254/digging-through-the-dirt and http://www.wowhead.com/quest=253/deprecated-bride-of-the-embalmer where multiple http://www.wowhead.com/npc=45801/eliza could be summoned and aoed down.
DB/Misc: Completion script for Delivery to KrennaCloses #15982
Merge pull request #15956 from ShinDarth/questdefCore/Quest: code style
DB/Creature: Sulaa Waypointscriptcloses #16009

Merge pull request #15852 from Golrag/icc_boss_aggro
Merge pull request #16006 from rockz1152/3.3.5Core/Player: Fix Weapon Skillup on low level mobs

Remove check for skill up on grey level mobs
Core/Player: Fixed Weapon Skillup on low level mobsCloses #15998

Removed block for skill up on grey level mobs.
DB/creature_text: Add sounds for the quest Last RitesTexts need synchronization and some issues must be fixed.

DB/String: improved output of .ticket view command
DB/Creature: Remove wrong spawns
Merge pull request #15919 from Treeston/3.3.5-razuvious
Scripts/Naxxramas: Instructor Razuvious rework:- Fix missing yells
- Rearrange existing yells to match live
- Sniffed positions for adds
- Improve add respawn handling
- Make adds not fight the player for control (don't use their spells on their own etc.)
- Update adds' hotbar keys to match live (this will affect other creatures with nonsequential possess keys as well)
- Fix adds' movement when mind controlled, they no longer move automatically when right-clicking (this affects all mind-controlled creatures)
- Blizzlike timers

Core/Arena: create more arena configs - made rating modifiers configurable - made arena points rate configurable
Improved Auction house deposit handling.Including the weird quirks.

Changes:
* Deposit caculated according to same rule as client. (detailed below). Should always match client deposit now
* Deposit for multiple auctions now only collected once. Deferred calculation of deposit until all auctions listed.

Deposit calculation is as follows:

Base deposit calculation = MSV x 15/75% (depending on AH). However this is not rounded. Case to int is used (so always round down)
The remainder is held in a float.
The base is then multiplied by number of items, and the time multiplier (x2 for 24 hour, x4 for 48 hour)
The nearest (no of items or lower) no of items when multiplied by the remainder that creates a whole number is then multiplied by the time multiplier (x1/x2/x4) and then added to deposit.

Example:

Item sell price 1s25. Deposit 18.75c (15% of 1s25). So base deposit = 18, remainder 0.75. Time 24h (x2) Item count 1 = 36c. Remainder = 0.75 (n) Min = 1s. Deposit 1s
Item sell price 1s25. Deposit 18.75c (15% of 1s25). So base deposit = 18, remainder 0.75. Time 24h (x2) Item count 2 = 72c. Remainder = 1.50 (n) Min = 1s. Deposit 1s
Item sell price 1s25. Deposit 18.75c (15% of 1s25). So base deposit = 18, remainder 0.75. Time 24h (x2) Item count 3 = 108c. Remainder = 2.25 (n) Min = 1s. Deposit 1s08c
Item sell price 1s25. Deposit 18.75c (15% of 1s25). So base deposit = 18, remainder 0.75. Time 24h (x2) Item count 4 = 144c. Remainder = 3.00 (n) Min = 1s. Deposit 1s50c (144c + (3c * 2))

Horrible kludge, to re-create a very weird deposit method.

Closes #15674 (PR)
Closes #15643 (Issue)

Scripts/Pets: Fixed non pch build part 3 ...
Scripts/Pets: Fixed non pch build part 2
Scripts/Pets: Fixed non pch build
Merge pull request #14896 from Ofinka/dupl
Removed unneeded loop from previous commit, copypaste fail from 6.x
Core/Creatures: Implemented automatic detection of trigger models, their order in creature_template no longer matters(cherry picked from commit c488fb219ab080031488593a0b86ac785a7d2cae)

DB: Fix a Typo
DB/Quest: Return to the EarthAdd a despawn action when the item is used
Fix some creature_addon
Add some missing spawns
Add unit_flags immune to npc for dead drakes
Closes #15984

Core/Quest: code style: - Removed 11 useless for iterations (for each quest loaded)
Merge pull request #15402 from chaodhib/taunt_player
DB/Creature: Grizzly BearCloses #15965

DB: New line
DB/SAI: Fix Arena Treasure Chest spawning positionCloses #15580

Core/Items: Fixed a possible crash with soulbound tradable itemsCloses #15700

(cherry picked from commit 094f505e404b5a4e4846657031f89ac44626a1f8)

Dep/CppFormat: Update cppformat to cppformat/cppformat@5c76d107cbaf(cherry picked from commit aa3020c26d54fa63fde16c5a765b1d72649c7e30)

Merge pull request #15910 from Treeston/3.3.5-maexxna
DB/SAI: Reduce the LOS for snow mounds from 15 to 7 yards
DB/Creature: Gubber BlumpAdd gossip option to learn fishing if the quest 1141 is taken an fishing is not learned
Closes #15954

Core/Player: Fix crash related to vehiclesFix assertion triggered when entering a vehicle while channelling a shared vision spell.
Fix #15953

Core/Quest: Fix issues reported by static analysis
Core/Unit: Add Unit::KillSelf() overloadAdd Unit::KillSelf() function as overload of Unit::Kill(this) . Use KillSelf() whenever the killer and the victim are the same to clearly state the Unit is going to kill itself.

Merge pull request #15933 from Asterc/3.3.5Core/Spells: Fix Misdirection exploit
Core/Quest: Fix issues reported by static analysis
Core/Quest: Fix issues reported by static analysis
Core/Quest: Fix issues reported by static analysis
DB/Quest: Great Bear SpiritCloses #15950

Merge pull request #15947 from ShinDarth/duel-exploitCore/Spell: Fix exploit in duel cooldown reset handling
Core/Spell: fixed possible exploit in Duel Reset script- thanks @Runico for reporting it

DB/Quest: Restore deleted sql for Anatoly Will Talk
DB: Fix a Typo
DB/Quest: Gorgrom the Dragon-EaterCloses #6326

Core/Conditions: extended CONDITION_NEAR_CREATURE, condition value 3 is now used to check for dead creature entries (0 - alive, 1 - dead) * I used 0 for alive to avoid touching all conditions with this type(cherry picked from commit cdb5bd3eb78ea40fbd927c5662e1dad778bf12d5)

Correctly reset the redirected threat of the hunter's spell Misdirection in cases when it has RemoveMode AURA_REMOVE_BY_DEFAULTCloses #15930

Scripts/Icecrown Citadel: Professor Putricide - fixed Expunged Gas damage formulaCloses #6396

Rename 2015_11_15_3574_world.sql to 2015_12_01_00_world.sql
Merge pull request #15864 from tkrokli/hallowed_wandsScripts/Spells: Hallow's End item Hallowed Wand
Merge pull request #15920 from Treeston/3.3.5-MCHotkeyPosUnit/PossessBar: Fix spell ordering on possess bar
Scripts/Naxxramas: Maexxna cleanup: - Improved Web Wrap target selection - Added missing text - Cleanup of web wrap positioning - two players will never be flung to the same position (25-man) - Further improvement to web wrap spawn behavior - targetable web wrap now only spawns after the player has finished being flung to the respective position (blizzlike) - Add additional web wrap positions (sniff)
DB/Quest: Fel Reavers, No Thanks!By @Gargarensis
Closes #3965

DB/Quest: Creatures of the Eco-DomesCloses #3025

Unit/PossessBar: Fix spell ordering on possess bar to reflect spell position in DB. Fixes Razuvious adds et al.
Core/Spells: Fixed passibe talent auras targeting pets instead of playerCloses #1543
Closes #15918

Merge pull request #15912 from Treeston/3.3.5-urandmsCore/Util: Add urandms(minMS, maxMS) helper
Core/Util: Add a urandms(min,max) helper to make urand(min*IN_MILLISECONDS, max*IN_MILLISECONDS) shorter to write for random time intervals (boss scripts).
Merge pull request #15907 from ShinDarth/fixCore/Spells: Fix Arcane Missiles
Merge pull request #15904 from 'ForesterDev/instance_login_cleanup'
DB/Quest: Prisoner of the BladespireCloses #15913

Core/Spells fix Arcane Missiles - close #15902
Core/Players: Fixed warning
Core/Players: Use constant gender from PLAYER_BYTES_3 where appropriate.Closes #15895

DB/SAI: Underbog Colossushttp://www.wowhead.com/npc=21251/underbog-colossus#comments

Add missing on death events, previously when killed these always cast toxic pool

When killed now one of the following will happen

* Nothing
* Spawn Toxic Pool
* Spawn 2 Colossus Lurker http://www.wowhead.com/npc=22347/colossus-lurker#comments
* Spawn around 10 of Colossus Rager http://www.wowhead.com/npc=22352/colossus-rager#comments
Merge pull request #15903 from tkrokli/remove_script_npc_anchorite_truuenCore/Scripts: Remove deprecated script npc_anchorite_truuen

Remove deprecated script npc_anchorite_truuen replaced by SAI in 2cecc7b1f7b846d24f25e0f5acb957c4c4b4484d


Core/Player: cleanup function CheckInstanceLoginValid
Core/Scripts: remove redundant script npc_anchorite_truuenThe cpp script npc_anchorite_truuen has become redundant
because it has been replaced by a SAI script in commit 2cecc7b.

This script currently causes an error line in DBErrors.log:
```
Script named 'npc_anchorite_truuen' does not have a script name assigned in database.
```

Core/Player: Always allow accounts with RBAC_PERM_COMMAND_GM to enter instances on loginAlways allow accounts with RBAC_PERM_COMMAND_GM to enter instances on login even if player had .gm off .
Send an ingame message to notify the user about the avoided kick.

Scripts/EyeOfEternity: Fix crashFix crash happening when a player would kill a Melee npc on the disks during Malygos fight and mount it before it ended the waypoint path.
Close #15900

Core/Misc: fix warning and misc codestyle fixes
Merge pull request #15899 from Treeston/3.3.5-thaddiusScripts/Naxxramas: Thaddius follow-up
Scripts/Naxxramas: Thaddius follow-up:- Reduce initial spawn timer on the encounter from 30 seconds to 5 seconds
- Rearrange respawn logic to fix the "petrified" visual from not showing properly
- Fix a potential infinite respawn loop that could prevent the encounter from initializing properly (fixes and closes #15898)

Tools/MMapGenerator: Fix an edge case of infinite loopFix a (pseudo) infinite loop happening when generating mmaps for single tile maps (like 249) but with vmaps not present in the correct folder. This would trigger a 18446744065119600000 (uint32 max ^ 2) iterations loop.

Merge pull request #15763 from ShinDarth/channeled[3.3.5] Fix conflicts between duration and cast time of channeled spells
Core/Spells: fix conflicts between duration and cast time of channeled spells
Dep/SFMT: Add diff fordd55e41c8158fe1f60e120b0b89469d4112158d2
Dep/SFMT: Fix a strict-aliasing warning reported by GCC 4.9
Tools/MMapGenerator: Fix some warnings reported by GCC 4.9 and MSVC 14 with W4* /var/lib/jenkins/jobs/tc_335_release_gcc49/workspace/src/tools/mmaps_generator/MapBuilder.cpp: In member function ‘void MMAP::MapBuilder::WorkerThread()’:
/var/lib/jenkins/jobs/tc_335_release_gcc49/workspace/src/tools/mmaps_generator/MapBuilder.cpp:174:28: error: ‘mapId’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
buildMap(mapId);

* variable redefinition warning
* remove 2 "using namespace std"

*NO reextraction of mmaps needed*

DB: Fix an incorrect Text range in creature_text
Tools/MapExtractor: Fix a warning reported by gcc 4.9/var/lib/jenkins/jobs/tc_335_release_gcc49/workspace/src/tools/map_extractor/System.cpp:113:25: error: ignoring return value of ‘int chdir(const char*)’, declared with attribute warn_unused_result [-Werror=unused-result]
chdir("../");

*NO reextraction of dbcs/maps needed*
Binary compatibility is ensured

DB/Quest: Hot and Cold
DB/Quest: The Might of KalimdorBy @sirikfoll
Closes #15830

DB/Loot: Fix Skinning Loot for Mottled Boar and Scorpid WorkerBy @tkrokli
Closes #15773
Closes #15772

DB: Add comments on skinning loot template tableBy @tkrokli
Closes #15760

DB: Remove skinloot from CrittersBy @tkrokli
Closes #15871

DB/Quest : Tomb of the LightbringerCloses #14733
By @Gargarensis

Clean required: https://github.com/TrinityCore/TrinityCore/blob/ab90f744866d761a302380e12ed7b0dee23697f0/src/server/scripts/EasternKingdoms/zone_western_plaguelands.cpp#L280

Fix file name
DB/Quest: Fix Seal of Ascension (quest chain for Upper Blackrock Spire)by @Gargarensis Closes #15021

Merge pull request #15884 from tkrokli/re-enable_flying_vehiclesCore/Creature: Flying vehicles able to fly again
Core/Creature: Flying vehicles able to fly againby @sirikfoll, closes #15861

Flying vehicles could no longer leave the ground after commit 52692c3.
This is a modification of commit 52692c3 to make flying vehicles work again.

Merge PR #14824 'tkrokli/spell_mod_stealth_stand_state' into 3.3.5
DB/Misc: Fix typo in 'OdesyusLanding'By tkrokli, closes #15725
DB/Creature: Delete duplicate spawnBy tkrokli, closes #15874
Update UnixInstall.txt
Update UnixInstall.txt
Update UnixInstall.txt
DB/Quest: The Dead Rise!
Core/Items: Fix crashFix crash happening if item_template.StatsCount field in the database was higher than 10.
Fixes #15868

Core/Spells: Fixed typo in ecbbcc8972f43376c65cb726c37cf777ee968f66
Scripts/Spells: Hallow's End item Hallowed WandHallowed Wand items should cast a transformation on party members.

by @DevRival, closes #3574

Before this patch, the following spells do not have any effect at all:
- 24717, Pirate Costume
- 24718, Ninja Costume
- 24719, Leper Gnome Costume
- 24720, Random Costume
- 24737, Ghost Costume

Details from testing on the current 3.3.5 branch (commit ecbbcc8):
- 24724 (Skeleton Costume) seems to work as intended
- 24733 (Bat Costume) only lasts 10 seconds instead of 60 minutes
- 24741 (Wisp Costume) also seems to work as intended

All the spells listed above are included in this PR.

Scripts/ICC: * Bosses now enter when in aggro range.* Removed some of the MoveInLineOfSight calls
* Added more AreaTriggerScripts

Core/Misc: Fixed memory leak in trade handler(cherry picked from commit fc852181c578e2ab8644bebfef13199a7897ebe9)

CID 1339313
CID 1339312

Core/Quest: Fix issues reported by static analysisCoverity defect IDs: 1339309, 1339310

Core/Player: Fix issue reported by static analysisCoverity defect IDs: 1010154

Core/Spells: Fixed Raise Dead cooldownCloses #15862

Script/Naxxramas: Fix a -Winconsistent-missing-override warning reported by clang 3.6
Core/Battleground: Fix issue reported by static analysisCoverity defect ID: 1339311

Core/Worldserver: Enable the database updater by default. * Seems like this feature is stable enough to enable it by default since the last missing bugs were fixed some months ago. * The database updater is the preferred method to update the databases as described in the wiki: http://collab.kpsn.org/display/tc/Databases+Installation(cherry picked from commit 25185967e8df949e0f13ec0a7ff45b14ba977c76)

Core/Player: Move KillRewarder to its own file(cherry picked from commit 4e76974ce5ba3f6ebd73d6dd96860b60d50a19f4)

Conflicts:
src/server/game/Entities/Player/Player.cpp
src/server/game/Entities/Player/Player.h

Core/DBLayer: Improve error message from 0a27f8bce264b8f6d8c55efa8ebc97f6e9cb7d11(cherry picked from commit d31706b07e5e4a4d632f5deea7076e864b467bbe)

Core/Player: Move TradeData to its own file(cherry picked from commit 2d7d6f505c6e4e08b5fbbd0bc88b46753191c7aa)

Conflicts:
src/server/game/Entities/Item/Item.cpp
src/server/game/Entities/Player/Player.cpp
src/server/game/Entities/Player/Player.h
src/server/game/Handlers/TradeHandler.cpp
src/server/game/Spells/Spell.cpp

Merge pull request #15859 from tkrokli/coverity_defectsScripts/Thaddius: Coverity scan Control flow issues (MISSING_BREAK)
Scripts/Thaddius: Coverity scan Control flow issues (MISSING_BREAK)Coverity scan defects CID 1339315, 1339316 and 1339317:
- CID 1339315: boss_thaddius.cpp: 542
- CID 1339316: boss_thaddius.cpp: 811
- CID 1339317: boss_thaddius.cpp: 398

Added missing break; statements.

Core: Fix warning
Core/Condition: Fix issue reported by static analysisCoverity defect ID: 1339314

Core: Fix non pch build
Fix build for mysql versions older than 5.7(cherry picked from commit 5604aed5f130a48a660fa2a2f957489f6a3024ea)
Rename 2015_10_PR15523_world.sql to 2015_11_12_01_world.sql
Merge pull request #15523 from Treeston/3.3.5-thaddiusScripts/Naxxramas: Thaddius: Complete rewrite
Merge pull request #15732 from ShinDarth/reset-health-manaScripts/Duel: implement duel reset of health and mana and improve duel reset
Core/DBLayer: Ensure that MySQL version used when compiling is the same as libmysql.dll version used for running the server.Ref #15848

(cherry picked from commit 0a27f8bce264b8f6d8c55efa8ebc97f6e9cb7d11)

Buildsystem: Fixed building on windows 10 with cmake 3.4(cherry picked from commit b5fbf773a5071fc4c88f8e0112ffe8a9f2f760e3)

DB/Event: Add all Hallow's End spawns in Northrend!- removed all old spawns and reinserted new valid spawns.

DB/Event: Add all Hallow's End spawns in Northrend!
DB/Object: Add general spawns missing in Northrend
Core/Creature: Remove duplicate call to LoadCreatureAddons in Creature::Create* Add error log for duplicated aura entries in creature_(template_)addon

DB/Object: Fix 2 objects in The Eye
Core/Commands: Fix NULL dereference crashCloses #15833

DB: Fix a DB error
Rename 2015_11_8_00_world.sql to 2015_11_08_00_world.sql
DB/SAI: Add missing text for Lore Keeper of Norgannon
[3.3.5] Core/Spells: break Stealth and modify Stand Stateby @robinsch; closes #14819

Currently (562da2e), only harmful CC spells will break stealth and modify the unit stand state.
This behaviour is wrong. Any harmful spell hit should break stealth and modify the stand state.

There are a few exceptions for this mechanic, such as:
- Mass Dispel (priest spell ID 32375, 32592, 39897)
- Earthbind Totem (Pulse) (spell ID 3600)
- Distract (rogue spell ID 1725)

Merge pull request #15835 from ariel-/entryCreature Addon should be updated when entry is changed.
Core/Player: Improve a log message(cherry picked from commit 7eb314fcd16c2265daf0948c6744a9f206da3150)

Core/ObjectMgr: Disable not linked graveyard error log for zoneId == 0
Rename 2015_11_09_02_world.sql to 2015_11_09_02_world335.sql
DB/Misc: Fix errorsCloses #15842
DB/Misc: Add missing gossip option text for Brassbolt Mechawrench and Reginald ArcfireReplace vendor of the brewfest condition by achievement instead of quest

DB/Quest: AberrationsCloses #8492

Move file to correct location
correct typo
DB/Misc: Commoners (Day of the Dead)* Spawn commoners for this event
* Add Gossip for event

http://www.wowhead.com/spell=65529/gossip-npc-appearance-day-of-the-dead-dotd does not appear to work, this aura should give npcs the same model (if not very similar to) the one which players get when they /dance with Catrina.
DB/Event: Day of the Dead* spawn all event creatures and gos.

Respawn creature spawns as some of these where found to be incorrect positions
Spawn all the missing gos for this event.

Ghostly cooking fires are meant to also require orange marigolds to be visible but atm is visible while event is active
The spell 30628 http://www.wowhead.com/spell=30628/arcane-invisibility is not sniffed (in fact in sniff there appears to be no invisibility spell used on these npcs, this is the spell we was already using on these npcs but is not from sniff)

Npcs/gos missing from stormwind as dont have valid sniff for those.
Reload creature addons on UpdateEntry.
Merge pull request #15022 from robinsch/GOdespawnSmartAI: Possibility to despawn object with SMART_ACTION_FORCE_DESPAWN
Scripts/Naxxramas: Complete rewrite of the Thaddius encounter.
Scripts/DuelReset: - do not reset when duel is fled - minor improvement to SpellHistory::RestoreCooldonStateAfter duel method
Core: Whitespace cleanup
Updated url for tc wiki(cherry picked from commit 6d01960448d3d2f53cd532acafb707e517e23dd5)

TDB 335.60 - 2015/11/07
Core/CreatureGroups: Don't set positionZ to ground for flying creatures.(cherry picked from commit df4c856360a56c3abe1c231ed37cd3673515c090)

Core/ScriptMgr: Improve commit 155a289f052b3a48caade(cherry picked from commit 30c421bf57c8d4c1000f8690d439283b858d485d)

Core/ScriptMgr: Fix "conditional expression is constant" warning. * introduced in commit 12d1993994b11785(cherry picked from commit 155a289f052b3a48caadebafe587c0e66685857f)

Core/Globals: Use std::string rather than char* to pass script names around.(cherry picked from commit b7b49fe35f87e83813466cb302ff17381792e607)

Conflicts:
src/server/game/Battlegrounds/BattlegroundMgr.cpp
src/server/game/Globals/ObjectMgr.cpp

Core/ScriptMgr: Replace IsDatabaseBound() methods through traits.(cherry picked from commit 12d1993994b11785174c7caa7d7f9b5aa87d8411)

DB/Creature: Apexis FlayerCloses #15761

DB/Page text: Saga of the Sin'dorei
Core/Corpses: Fixed a possible crash adding bones to gridCloses #15808

(cherry picked from commit ec1583df67605b7253a34dc5f153cdad5b16969e)

DB/Misc: Fix a runtime error
Dep/g3d: Removed std::shared_ptr, std::weak_ptr, std::dynamic_pointer_cast, std::static_pointer_cast and std::enable_shared_from_this from global namespace(cherry picked from commit 2c23a686e30cd23dbfa18f2fdfac0282052731ab)

Core/Commands: Added assertion checking if command name is not null(cherry picked from commit 56959697257aba3537af2273d9d30114bfd6bd5c)

Core/Accounts: Fixed ban check after 517a30d7c189b0530711f78508f9731e31fe5a53
Merge pull request #15804 from Tonghost/3.3.5Core/Misc: Remove unneeded files
DB/SAI: Fix a DB errorOrigin: https://github.com/TrinityCore/TrinityCore/commit/91de0322bba3ef071338ce5a71f512369486eb1f

DB/Creature: Remove wrong spawns and add triggers npcs for future events on Icecrown Airships
Merge pull request #15720 from Tonghost/3.3.5Core/Items: Fix a trading spoof exploit.
DB/CORE Minor change in quest Kick, What Kick? and some codestyleRemove the line that despawns the 'Apple' npc, this despawn is non-blizzlike and breaks the quest.
Thx Killyana for sql and valuable information

Closes #15480

Core/Ticket improved ticket system - Safely close ticket before character deletion - Allow to keep trace of delete characters tickets (configurable) - Closes #15655Closes #15699

DB/Instance: The Eye instance updates- Pathing for Phoenix-Hawk, Crystalcore Devastator, Astromancer Lord, Nether Scryer
- Delete & Correcting some npc's locations, formations..

Update 2015_11_02_00_world.sql
Rename 2015_10_25_anubrekhan_world.sql to 2015_11_02_00_world.sql
Merge pull request #15658 from Treeston/3.3.5-anubrekhanScripts/Naxxramas: Anub'rekhan encounter cleanup.
Core/Misc: Remove unneeded filesThese 3 BlackRock Mountain scripts can be removed from source:

- boss_anubshiah.cpp
- boss_gorosh_the_dervish.cpp
- boss_grizzle.cpp

They already removed from the creatures in DB, and are currently causing
DBErrors.

Scripts/Naxxramas: Anub'rekhan encounter cleanup. - Cleaned up events behavior to use phases instead of weird checks for auras. - Cleaned up Crypt Guard despawn behavior, they should no longer despawn instantly upon death. - Moved initial greeting from MoveInLineOfSight hack to proper areatrigger script. - Fixed Crypt Guard respawn behaviour to prevent pulling them before Anub'rekhan has fully reset. - Fixed Crypt Guard aggro behaviour to call for help on aggro. This prevents pulling the initial pair of Crypt Guards without engaging the boss. - Added missing boss emotes. - Code style cleanup.
DB/Event: Day of the Dead spawn addon fixesSpirit's & Celebrant's should be invisible, only visible with [Orange Marigold] and [Bouquet of Orange Marigolds]

Rename 2015_10_08_faerlina.sql to 2015_11_01_03_world.sql
Merge pull request #15681 from Treeston/3.3.5-faerlinaScripts/Naxxramas: Faerlina cleanup
Scripts/Naxxramax: Fix clang warning
DB: Fix a type
DB/Objects: Fix Objects IDs on a previous commit
Core/Items: Corrected all spellid checks from item_template to also check -1Closes #15797

Core/AI: Cleanup in CreatureAISelector(cherry picked from commit 6fa45881914e0961c6c971d2c5e78fa3c712c5fb)

Core/AI: Convert the hardcoded variadic RAND functions into one C++11 variadic template version.(cherry picked from commit 0b6f7845911c41dcc175996816abc2e06f7dadbd)

DB/Event: Add missing Hallow's End event spawns on Eversong WoodsThanks to @kittnz for the sniffs

DB/Misc: Commoners (Hallow's End)Adds more texts and gossip for Hallows End
Core/Accounts: Check active column when determining if account is banned or not
Rename 2015_10_31_02_world_2015_08_01_01.sql to 2015_10_31_03_world_2015_08_01_01.sql
Core/Misc: Update game creature template locale in simple system(cherry picked from commit 8aa55a0b570cfee0445cd841f86baa5ca433a803)

DB/Creature: Fix movement type for Thomas Yance
Core/Conditions: Optimizations part 3 changed ConditionStore to a simple array(cherry picked from commit db0c48c17fdf61b8816cc229dcfec907354326cd)

Core/Conditions: Optimizations part 3 removed copying condition containers all over the place(cherry picked from commit b09e63e9debfab49e635a591339294dd96b09d95)

Core/Conditions: Add const to methods not modifying ConditionMgr(cherry picked from commit 2cce998e905bed0873fbf0b3da981857c139e5d5)

Core/Conditions: Optimizations part 2 removed unneeded code(cherry picked from commit e5c1e7d71c3460a39317bacbc432adc3307c63ca)

Core/Conditions: Optimizations part 1 - use containers more suited for their role(cherry picked from commit 9fa938f3e0df2ca6b9ff4f800a5b41ba18cdd214)

Core/Conditions: Type renaming(cherry picked from commit 5e0cee85ddd67188365ead3f18206df088e1f0c7)

DB/Conditions: Dead Mage HunterDead Mage Hunters should not be interactable without the quest 'rifle the bodies'
Core: fixed warning introduced in last commit(cherry picked from commit fe0c07a6fe4dea8772e69ec8ad491bdda7f61746)

Core/Misc: removed some useless map checks(cherry picked from commit cf1e80e3d09067ca4d0078a8113a09227a9f91ae)

DB/Text: Real texts and sounds ids for Headless Horseman
Core/Players: Fixed automatic learning skills gained from learning spells when levelingCloses #15391

(cherry picked from commit 3fceabfa113983549b5784dfd3f42259a53c258b)

Scripts/Ulduar/Algalon: fixed achievement "He Feeds On Your Tears"Ref #6157

(cherry picked from commit d68e3325d5a09328425b8ae9855f3f5936ff24f9)

Core/Misc: Added a few stl header includes to Common.h(cherry picked from commit 89b902b4e0d0016accd9540ca133519995a0b123)

Core/DBLayer: Allowed using GetDouble for SUM results instead of requiring string conversions(cherry picked from commit 3109ab2da08d094df97724355bff681d7951e576)

Removed unneeded nullptr check(cherry picked from commit 20215a8c421fd93d00233213966399a0c76e626a)

Fixed boss evade and doors closed by cr4st. Should close #6377 and #15239(cherry picked from commit e430f3f61ae45ca0e8e251f96a1605bdb9299eb1)

Core/Spells: Extended spell required shapeshift masks to 64 bits and defined a new spell attribute(cherry picked from commit 191d2c7262d3680776579055a063a433add54277)

Core/Spells: Fixed gcc-4.7.x compile(cherry picked from commit 595bb841a9f9b71bae0fcbcdfb0eb0c38143c7fc)

Script/Commands: Add some sanity checks to cast commandsCloses #15061

(cherry picked from commit 15dec9a76ca56930c6764e8483cbf4ce8aae4f90)

Core/PacketIO: fixed instance binding of gamemasters(cherry picked from commit 231fb1d322bc1c91f9227d43d3ef672605232154)

Dep: Silenced build warning in G3D header(cherry picked from commit 22653c99f874e189bda6670c42be38151b58e52b)
(cherry picked from commit cce7f1adf2b76c59d8a07f080f23d4b125ed8f15)
(cherry picked from commit d2795c98ddf37ab3a74752ecf54ad65af8541c25)

Buildsystem: Added dependency on revision_data to common project. Simply including the header in GitRevision.cpp is not enough to rebuild that file after updating sourcesFixes having to build twice before GitRevision returns accurate info.

(cherry picked from commit 65999801d3085387a00d7bf0a172be77571123c5)

Core/Players: Implemented serverside validation of reserved/profane namesCloses #15357

New library dependency: Boost.Regex

(cherry picked from commit b564c10b13effed63c7b7dae25117e2e0a2c64e4)

Core/Networking: Fixed possible crashes happening if async query retrieving account data takes too longCloses #14944

(cherry picked from commit 590c6e399d778db459fc8417322c80549081440a)

Core/Threading: Fixed possible data races after making auth queries async by moving their processing to boost::asio::io_service::run threads(cherry picked from commit f6bc87fe5df8b60ca0bf3a35f61305fd780a7e7d)

Core/Threading: Significantly reduced the severity of possible data race during player login* This commit changes a data race on a pointer value to data race on integers (guid)

(cherry picked from commit dbe20510569e6bd4a26892be84289b5864350ea6)

Core/DBLayer: Sprinkle some async magic on worldserver auth/session load process(cherry picked from commit 0e49eefe85790ac365c90202a2e22ce6b266ac31)

Core/PlayerDump: cherry picked refactoring from commit e49462fc1e7b5515977da03dbc3806ef639b983b)Fixed reguiding items in character_equipmentsets on pdump load

Core/Players: Fixed saving players with incorrect gender
Core/Player: Fixed tab issues
Core/Player: Set correct Gender by ModelidAn example: You are a blood elf female, you use [Iron Boot Flask], you turn into a male dwarf, you use [Orb of the Sin'dorei] and it will turn you into a blood elf male. This is the correct behavior like retail.

DB/Creature: Fix some wrong modelsCloses #15371
Closes #15770

Travis: Upgrade clang to 3.5
Core/Misc: Warning fix
Travis: Added -k flag to make call so as many errors as possible are displayed instead of failing after the first one
Core/Misc: Warning fix
Travis fix.
DB/Creature: Fix Spell Click for Dead Mage HunterReplace ride spell for Flamebringer by the correct one
Closes #15783

Core/Corpses: Fixed a crash happening when a corpse is added to a grid that was not yet fully loadedCloses #15684

Core/Corpses: Prevent deleting corpses by ObjectGridUnloader, fixes accessing freed memory in multiple places due to the corpse still being registered in Map containersCloses #15775
Closes #15781

SQL: syntax fix in characters_database.sql
DB/Creature: Fix wrong Dynamicflag for Winterskorn Rune-SeerFix a DB error
Closes #15774

DB/Quest: The Thane of VoldruneCloses #1006

Core/World: Store account id in CharacterInfo to reduce the amount of database queries(cherry picked from commit aaaa1c34410c160c7b0382f5ecdb39fa01ba007c)

Core/Crash reporting: Fixed windows version detection for 8.1 and newer(cherry picked from commit 4c866a0af0ffe1828c5694de7ef7007cefb46966)

Core/Players: Check if player can enter the instance during login before trying to add him to map* Fixes name displaying as "Unknown"

(cherry picked from commit 45994a177c128dc83ea01b0697377f7b74b5c4ba)

Warning fixes(cherry picked from commit 82db416b5d4825f24da1ad92e771d6567750f649)

Core/Tools: Fix brutal linking in mmaps extractor. * caused warnings with shared linking * ref #15671(cherry picked from commit 13654bac2c41b2971915e706b5304a3ce6089a47)

Core/Build: Never overwrite the msvc cxx flags in the cache * Setting all compiler flags in the cache led to circular bloating of msvc cxx parameters (was visible in console) which caused MSVC to rebuild the whole solution even on a small CMake change. It's not neccessary anyway to set the cxx parameters to the cache to take effect. * I'm not sure if the workarround is still needed for MSVC 12+. * Cleaning the CMake cache is recommended! * ref #15671(cherry picked from commit 0946fcf2aa35ebe0b8db07813315e3d6546b9d31)

Core/Misc: Removed manually defined ObjectGuid copy/move constructors. This will cause the compiler to automatically generate trivial constructors allowing them to be treated as simple integers(cherry picked from commit 3fd15ed22a23af1c5bb2cf037f93c1bce5f1e243)

Core/Player: remove unused method prototypes(cherry picked from commit 9617da72492953fcbbc6f100079c3241e0c3a096)

Core/Corpses: Fixed map crash happening during map unload when there are corpses inside
Core/Spells: Improved spell category cooldown handling* Category cooldown is stored with the spell that started the cooldown (and only resetting cooldown on that spell will clear cooldowns on entire category - this fully mirrors client behavior)
* This significantly reduces the amount of data saved to database for cooldowns
* Spell casts from items that have a different category specified than on spell will now check for cooldown during the cast

(cherry picked from commit 1efb3f08e278530f59d681f676b031a7fc6db3ac)

Closes #15766
Closes #15137
Closes #14837

DB/Objects: Add some missing objects on Eversong Woods
Core/Corpses: Fixed leaking corpsesCloses #15765

(cherry picked from commit bd16520ecc91d827abae7f0447cc292fe9e843e9)

Merge pull request #15736 from ShinDarth/desertersBG Deserters tracking system
Core/Battleground: implement deserters tracker feature
DB/Event: Fix for Dalaran & Shattrath Hallow's End spawns
Scripts/DuelReset: - fixed druid mana restoration - fixed bug when a player accepts duel with a spel on onHold true (like when stealth of rogue/druid is active)
Scripts/DuelReset: - impemented health and mana reset - do not reset anything when duel is interrupted
Rename 2015_10_27_01_world.sql to 2015_10_27_01_world.sql
DB/Event: Add missing Hallow's End event spawns in ShattrathThanks to @Kittnz

DB/Misc: Fallen Hero's SpiritScript http://www.wowhead.com/npc=32149/fallen-heros-spirit#comments
DB/Misc: Knot ThimblejackOnly valid for 3.3.5 as since catacylsm recipe is learnt and mats for suit reduced to one ogre tanin

* gordok ogre suit learned using gossip option instead of on gossip hello
* Script for Free Knot including making it so quest can only be returned once per run
Core/Player: Fix copy/paste mistake in 1ef1d42d145c18579a7e7ca15cebb38485bc0cff
Scripts/Naxxramas: Faerlina cleanup: - Move greeting to areatrigger instead of MoveInLineOfSight hack - Clean up add spawn handling to prevent various glitching with combinations of evade state and add aggro - Ensure all adds are always pulled alongside the boss and vice versa - Add missing texts. - Fix a bug in the core that prevents castable-while-dead spells (such as Widow's Embrace) from appearing on possess bars.
DB/Event: Add missing Hallow's End event spawns in DalaranBy @Kittnz & @Kilyana

Core/Player: Fix not being able to do seasonal quests(if already done in the past)
Core/Quests: Fix a CMSG injection abuse.closes #15709

DB/Pathing: Azuremyst Isle Updates* by @Grz3s

DB/Creature: Cenarion Circle Reputationcloses #15759

DB/Creature: Zul'Farrak - Disable Movement for Trolls after Death* else the corescript moves the dead creatures

Core/Commands: Fixed merge error
Merge pull request #15755 from ShinDarth/reset-stealthFixed some rare stealth/prowl visual bugs after duel cd reset
Merge pull request #15753 from Rushor/bloodScripts/IcecrownCitadel: Quest 'Blood Quickening' - Add Killcredit in 25ManRaid
Core/Spells: fixed some rare stealth/prowl visual bugs after duel cd reset
DB/Path: Pathing for few rats in Dalaran
Core/Commands: Refactored chat command script hook, fixes a crash when building with gcc 5Closes #15616
Closes #15740

(cherry picked from commit 2d942ddcc528cc9fe718ebbd5903318fcbdab817)

# Conflicts:
# src/server/scripts/Commands/cs_battlenet_account.cpp
# src/server/scripts/Commands/cs_cast.cpp
# src/server/scripts/Commands/cs_debug.cpp
# src/server/scripts/Commands/cs_go.cpp
# src/server/scripts/Commands/cs_misc.cpp
# src/server/scripts/Commands/cs_mmaps.cpp
# src/server/scripts/Commands/cs_modify.cpp
# src/server/scripts/Commands/cs_npc.cpp
# src/server/scripts/Commands/cs_reload.cpp
# src/server/scripts/Commands/cs_ticket.cpp

Scripts/IcecrownCitadel: Quest 'Blood Quickening' - Add Killcredit in 25ManRaidcloses #15733

DB/Gossip: Orbaz Bloodbane - Gossip optionby @tkrokli + @Pitcrawler , closes #15737

DB/Creature: Grethok the Controller - Add text on Death
DB/Pathing: Onyxia's Lair
Merge pull request #15746 from Rushor/VenomCore/Spells: Reduce Duration for EffectEnchantHeldItem-Spells
Core/Spells: Reduce Duration for EffectEnchantHeldItem-Spells
DB/Creature: Thistle Boar - Skinning Loot* closes #15744

DB/Creature: Small Crag Boar - Remove invalid skinning Loot* closes #15742

DB/Creature: Young Thistle Boar - Skinning Loot* closes #15743

DB/Creature: Gryphoneer Leafbeard - Gossip* closes #15745

Update UnixInstall.txt
Merge pull request #15731 from ShinDarth/toscriConvert the Duel Cooldown Reset feature to scripts
Core/Scripts: convert the Duel Cooldown Reset feature to scripts
Merge pull request #15727 from ShinDarth/duel-cdCore/SpellHistory: Improved Cooldown Duel Reset
Core/SpellHistory: Improved Cooldown Duel Reset - Do not send useless data to the client - Fixed a rare visual bug
DB/Creature: Add missing npcs in Dalaran
Merge pull request #15697 from ShinDarth/cdCore/Player rewritten duel CD reset system
Core/Player rewritten duel CD reset system
DB/Creature: Fix spawnMask for Spire Frostwyrm
Core/Items: Fix a trading spoof exploit.
DB/SAI: Dalaran Mages - Add Emotescripts
DB/Misc: Updates for Argent Tournament Quests* add visual for The Light's Mercy
* On Agro text for Mistcaller Yngcar
* Correct Defend spell for Boneguard Lieutenant

Thanks to @killyana for updates to script for the Light's Mercy
Update CONTRIBUTING.md
Update README.md
DB/Misc: More AQ40 fixesBy Malcrom.
Merge pull request #15716 from ShinDarth/bg-expCore/Misc split Rate.XP.Kill and Rate.XP.BattlegroundKill settings
Core/Misc split Rate.XP.Kill and Rate.XP.BattlegroundKill settings
DB/Creature: AQ20 Full respawn and waypointsBy Malcrom
DB/Quest: The Nightmare ManifestsFix some issues: InhabitType, Hover during the combat, and Eranikus will no longer be attackable before the phase 2

DB/Item: Meteorite Crystal TrinketBy @treak
Closes #8669

DB/Creature: Fix spawns/pathing in AQ40By malcrom

Core/Auras: Fixed auras limited to a single target not being removed in all cases as expected* Fixes possible assertion failure in Aura::UnregisterSingleTarget
Closes #15696
Ref #15668

Cherry picked (manually) from b808910a89822f741d35d4b90e6c4bcf101cd9ef

DB: Fix up some errors in Vekniss Hive CrawlerBy Malcrom

DB/Misc: Fix 2 runtime errorsBy Malcrom
DB/Creature: Pathing for Lava SurgerBy Malcrom
Update 2015_10_14_00_world.sql
DB/Creature: Fix spawns/pathing in AQ40By malcrom

DB/Creature: Reguid for future commitBy Malcrom.
Merge pull request #15711 from ShinDarth/bg-leaveCore/BG: Improved Battleground.InvitationType = 2
Core/BG: Improved https://github.com/TrinityCore/TrinityCore/commit/d7cb84f6cddb56bc818b2bf30d3318d052039540 - Handle case when some players leave or InvitationType changes while running - Add some comments
Core/Pch - Fix non PCH build.Issue introduced in https://github.com/TrinityCore/TrinityCore/commit/b1032ed6203a5839906fab7137484b0ef8f0e58f

Change many uint32 to ObjectGuid::LowType in line with 6.x changes.
Merge pull request #15676 from ShinDarth/bg2Core/Battlegrounds: implement even BG teams configuration
Merge pull request #15707 from ShinDarth/pvpstatsCore/BG fix .character changefaction pvpstats victories amount
Core/Battlegrounds: implment even BG teams configuration
Core/BG fix .character changefaction pvpstats victories amount
Update 2015_10_12_00_world.sql
DB/Misc: Fix startup errors
DB/Misc: Fix guid
DB/SAI: Fix teleport to Molten coreBy Malcrom
Resolve coverity #1023086Correctly destroy AH pointer and return error to user in unlikely event
auctioneer is invalid

DB/Creature: Pathing for Molten CoreBy Malcrom, closes #15662
DB/Gameobject: Add few missing Molten Core GameobjectsBy Malcrom
Renamed sql
Merge pull request #15495 from Treeston/3.3.5-gemperfectionCore/Spell: Implement "Gem Perfection" (and framework for similar spells in the future)
Gem Perfection implemented:- Add new DB table `skill_perfect_item_template` that holds information about "perfect" crafts that replace the normal result
- Implement this new DB table into core (SkillExtraItems.cpp, SkillExtraItems.h, SpellEffects.cpp)
- Add data about perfect crafts to new DB table (2015_09_11_00_world.sql)
- Add reload capability to this new table (latch onto skill_extra_item_template to avoid changing command IDs)

Random other change because I stumbled across it and it annoyed me:
- npc_professions.cpp no longer uses magic numbers for quest IDs and creature IDs.

Merge pull request #15698 from Treeston/3.3.5-loathebScripts/Naxxramas: Loatheb follow-up
Scripts/Naxxramas: Loatheb follow-up:- Fix Deathbloom (for real this time)

Merge pull request #15680 from tkrokli/dk_initiates_creature_sayCore/Scripts: The Endless Hunger & Death's Challenge, creature text
Merge pull request #15695 from tkrokli/contrib_check_updatescontrib/script: error text corrections in check_updates.sh
contrib/script: error text corrections in check_updates.shFix a factual error in the /contrib/check_updates.sh error message text,
Best shown in an example from the latest travis build error:
```
$ ./contrib/check_updates.sh auth auth
Database Updater check script:
Checking database 'auth' for missing filenames in tables...

- "sql/updates/2015_10_09_00_auth.sql" is missing in table 'auth'.'updates'

Fatal error:
The Database Updater is broken for database 'auth
due to applied update which are missing in the 'auth'.'updates' table.

How to fix:
Insert the missing names of sql updates which were applied already to
the 'updates' table of the 'auth' base dump ('sql/base/auth_database.sql').

The command "./contrib/check_updates.sh auth auth" exited with 1.
```
Main fix: `\"sql/updates/${file}\"` -> `\"sql/updates/${name}/${file}\"`

Before this change, the error message claims that the updated SQL file was placed
directly in the `/sql/updates/` directory and not in the subdirectory based on its DB name.

All the other changes are improvements in English grammar and more precise description.

Merge pull request #15692 from ShinDarth/instanceScripts/Commands: enhanced .instance get/setbossstate commands
Core/Scripts: The Endless Hunger & Death's Challenge, creature textThis PR solves the following say text issues:
In quest ID 12733, Death's Challenge, the creature script npc_death_knight_initiate is supposed to target the player and refer to the player character's name in the following 2 lines from `creature_text`.`entry` 28406:

- "You don't stand a chance, $n." (`BroadcastTextId` 29267)
- "Remember this day, $n, for it is the day that you will be thoroughly owned." (`BroadcastTextId` 29270)

In quest ID 12848, The Endless Hunger, the creature script npc_unworthy_initiate is supposed to target the player and refer to the player character's race in the following 2 lines from `creature_text`.`entry` 29519, 29520, 29565, 29566 and 29567:

- "You are hopelessly outmatched, $r." (`BroadcastTextId` 30212)
- "Sate your hunger on cold steel, $r!" (`BroadcastTextId` 30214)

The untargeted variables $r and $n appear in the say lines because the existing script assigns the text to the player character instead of the creatures. This does not produce any race or name information in /say or chat.

This Pull Request closes issue #14700 and replaces PR #15678.

Scripts/Commands: enhanced .instance get/setbossstate commands
DB/Gossip: Innkeeper Boorand PlainswindCloses #15672

DB/Locales: Kobold Camp CleanupBy @DanielMo1603
Closes #15690

Merge pull request #15689 from sirikfoll/FriendOrFowlCore/Scripts: Friend or Fowl Achievement
Merge branch 'Treeston-3.3.5-loatheb' into 3.3.5
Rename sql
Merge branch 'Treeston-3.3.5-heigan' into 3.3.5
Rename sql
Merge branch '3.3.5-noth' into 3.3.5
Rename sql
Merge pull request #15504 from Treeston/3.3.5-bosscombatpulseCore/Creature: Add default-disabled periodic zone combat pulse (and have base AI enable it for bosses)
Merge pull request #15501 from Treeston/3.3.5-proximitycombatCreature/SmartAI: Fix creature aggression behavior
Core/Scripts: Friend or Fowl AchievementChange AURA_EFFECT_HANDLE_REAL to AURA_EFFECT_HANDLE_REAL_OR_REAPPLY_MASK, the hook needs to be called on every apply/reapply to keep tracking the stack amount.

Scripts/Naxxramas: Bugfixes to the Noth encounter.- Added missing raid boss emotes
- Fixed an issue where Noth would stand idly after blinking if his current target stood still
- Fixed some reset edge cases
- Prevent Noth from dying during Balcony phase
- Fix targeting of 25-man Curse of the Plaguebringer (now has 8 targets, down from 10)
- Fix balcony/ground phase durations to be blizzlike
- Fix an issue where summoned mobs would sometimes not be aggroed automatically
- Get rid of ugly millisecond values in favor of seconds times constant
- Moved the chance to yell on kill to the database
- Prevent AoE abilities from hitting Noth during the balcony phase
- General cleanup of events handling
- Generally make @Nayd happy

DB/Gameobject: Fix Gordok Courtyard Door
DB/Creature: Anub'ar Warrior pathingBy @Malcrom

And final change to include table hash in updatesNot actually needed for this change, but it upset travis

Also update character base create for pet_aura commit
Add caster guid to pet_aura table.This prevents duplicate key and transaction completion fail on pet save, if pet has same aura from two different casters present.

This closes (already closed) issue https://github.com/TrinityCore/TrinityCore/issues/10529

DB/Creature: Sheddle Glossgleam EventShiny Shoes

Rooted vehicle movement (#13342 for example)Corrects issue where certain combinations of actions would cause vehicles (usually cannons/artillary) that should be rooted, to be fully movable

Rename SQL after PR merge
Merge pull request #15654 from ShinDarth/resolvedByCore/Ticket keep always trace of GM who resolves the ticket
Core/Ticket keep always trace of GM who resolves the ticket
DB/Creature: Spire FrostwyrmAdd Spire Frostwyrm spawns and scripts in Icecrown Citadel

DB/Auth: Add missing update 2015_08_21_00_auth.sql to the auth base.
Travis: Add check for update entries not listed in base dumps. * Will mark the travis build as failed when the database updater is broken.
DB/Creature: Nerub'ar BroodkeeperAdd visual Web Beam on aggro
Fix creature addon for 25 mode
Fix InhabitType issue after landing

Core/Updater: fixed host parameter is being ignored(cherry picked from commit e51b6601779050837fcc87f27579b86c50446fc3)

CMake: Fix bad generation of "revision_data.h" not including MYSQL_EXECUTABLE. * was caused through invoking "FindMySQL" after using ${MYSQL_EXECUTABLE}. * better re-run CMake if you are affected by the mysql exe wasn't found issue.
Core/Updater: Fix mysql in path check/search.
Core/Updater: Pipe mysql process output into worldserver log(cherry picked from commit 2d109b63e2f1d03a961dd58947598f73e4e43ba0)

Merge pull request #15646 from ShinDarth/ticketCore/Player: implement ResetCoolDownAfterDuel configurable feature
Core/Player: implement ResetCoolDownAfterDuel configurable feature
DB/Quest: Fix a typo on CompletionText for Dark StormsBy @Espionage724
Closes #15652

DB/Creature: Hrothgar Landing FixupsBy @Malcrom

DB/Creature: Fix Champion go to bunny movements
DB/gossip: Add missing gossips to Garrosh Hellscream
DB/Creature: Fix Npcflag for High Overlord Saurfang and Muradin Bronzebeard
Scripts/ICC: moved saurfang gossips to dbCloses #14904

Core/Misc: renamed sGossipSelect parameters
Core/Scripts: Salanar the Horseman, Into the Realm of Shadows- Show gossip_menu_option 9739 only if quest 12687 is accepted & not completed
- Cast spell 52693, SPELL_REALM_OF_SHADOWS, when gossip option is selected

Core script by @CreshandKesh (with some modifications)
SQL part by @CreshandKesh and @tkrokli, condition adjustment by @Killyana.

Closes #15603
Closes #15657

Merge pull request #15533 from Tomatodev/3.3.5Core/AuctionHouse: fix config value RATE_AUCTION_DEPOSIT < 1 ignored by deposit formula
DB/Creature: Spirit of OlumMove the script to the DB
Fix conditions for the teleportation
Add the missing teleportation to the Chamber of Command
Fix gossip text

DB/Misc: Multiple DB Fixes
DB/SAI: RazormawBy @pete318
Update #8988

DB/Gossip Menu: Add missing gossips for Karazhan's npcsMove npc_berthold script to the DB
Add missing gossips
Closes #15564
Thanks to @Riztazz and @xjose93

Heigan cleanup:- NearTeleportTo hack -> proper spell with DB coordinates
- Add boss emotes
- Some code streamlining using event phases and IN_MILLISECONDS instead of large constants
- Improvement to eruption hitbox and delimiters to match retail layout more closely
- Spell timers adjusted from sniffs

DB/Creature: Murloc ScoutCloses #15612

DB/Event: Argent Confessor Paletresshttp://wow.gamepedia.com/Argent_Confessor_Paletress

DB/Creature: Azuremyst Isle pathingBy Malcrom
DB/Waypoints: Fix Artificer Daelo pathUpdates #15630

Core/Transports: Fixed accessing deleted instance transportsThanks @jackpoz for valgrind log and @pete318 for reproduction steps

Closes #15633

(cherry picked from commit 8745e08be020471db886e11a3a7512a751141562)

Merge pull request #15637 from Tonghost/3.3.5Core/Misc: Fix a typo
Merge pull request #15628 from Espionage724/patch-1Update authserver.conf.dist
Core/Misc: Fix a typo
DB/Npc: Niffelem Frost Giant and FrostworgRemove wrong spawns and add vehicle accessories

DB/Creature: Fix some Npcs in The Storm PeaksFix Brunnhildar Prisoner react state.
Add missing aura to Dead Frost Giant and Frostworg Carcass, and remove random movements
Fix react state for Brunnhildar Warbear, Frostworg and Niffelem Frost Giant, and add SAI scripts.
Fix inhabittype for some npcs trigger.
Closes #15635
Closes #15634

Core/Maps: Moved corpse management to map level(cherry picked from commit cd27fd38b93884797c094a82dc7beb0498e2f124)

# Conflicts:
# src/server/database/Database/Implementation/CharacterDatabase.cpp
# src/server/database/Database/Implementation/CharacterDatabase.h
# src/server/game/Entities/Corpse/Corpse.cpp
# src/server/game/Entities/Creature/GossipDef.cpp
# src/server/game/Entities/Player/Player.cpp
# src/server/game/Entities/Player/Player.h
# src/server/game/Globals/ObjectAccessor.cpp
# src/server/game/Globals/ObjectAccessor.h
# src/server/game/Globals/ObjectMgr.cpp
# src/server/game/Globals/ObjectMgr.h
# src/server/game/Grids/ObjectGridLoader.cpp
# src/server/game/Handlers/AuctionHouseHandler.cpp
# src/server/game/Handlers/CharacterHandler.cpp
# src/server/game/Handlers/ChatHandler.cpp
# src/server/game/Handlers/QueryHandler.cpp
# src/server/game/Maps/Map.cpp
# src/server/game/Server/Packets/CharacterPackets.cpp
# src/server/game/World/World.cpp
# src/server/scripts/Commands/cs_reload.cpp

DB/Quest: Anatoly Will TalkCloses #15618

DB/Quest: BlackoutCloses #15617

Update authserver.conf.dist- Added new line for consistency
DB/Characters: Updated character create for update hashUpdated hash for 2015_08_26_00_characters_335.sql for map local guids commit

Closes https://github.com/TrinityCore/TrinityCore/issues/15601

Merge pull request #15619 from pete318/ah_spawnid(3.3.5/Core/Auctions) - Changes to Auction House (use of guids)
Auction house changes: - Stop storing guid for auctioneer. - Store instead house ID - No separate ID for various houses. Only Horde, Alliance and Neutral. - Removed non-needed faction checks. - Use enum for auction house IDsNOTE: This will expire all current auctions and return item to player (or
award to high bidder) in order to prepare database for the changes.

Scripts/Naxxramas: Adjustments to the Loatheb encounter- Adjusted doom cast timings as per boss mod timers.
- Add Deathbloom's final tick using spellscript
- Move Spores' Fungal Creep cast handling to Loatheb's cpp instead of handling it in SmartAI
- Fungal Creep should also be cast if the spore expires (important for Spore Loser achievement)
- Remove Fungal Creep from players on reset to avoid cheesy strats

Core/DBLayer: Build fix in addition to 25c03039768fefa79dd75d491997c28e451a09a7
Core/DBLayer: Allocate a single buffer for entire prepared result set instead of separate ones for each field(cherry picked from commit 8652f4b4de5ed02c89f9db91367125a04ce52dd4)

Core/DBLayer: Added compile time validation for prepared statement indexes passed to DatabaseWorkerPool::GetPreparedStatement turning mistakes like the one fixed in 0327927fa61434d432f9749fd9242ae5dce9a5cd into compiler errors.(cherry picked from commit 7c75160f590812f0c5d70fd9c68441068e2ded48)

Conflicts:
src/server/database/Database/Implementation/HotfixDatabase.h
src/server/shared/DataStores/DB2StorageLoader.cpp
src/server/shared/DataStores/DB2StorageLoader.h
src/server/shared/DataStores/DB2Store.h

Core/DBLayer: Optimized prepared statement query results by eliminating unneeded buffer copies* Improved error logs for using incorrect Field getters to also include table name, field name and field index.

(cherry picked from commit 65dbc7082a60b67b76966259130aedc337af3eca)

Conflicts:
src/server/database/Database/Field.h
src/server/game/Globals/ObjectMgr.cpp

Core/Misc: Fixed macro redefinition warnings when building for running under helgrind(cherry picked from commit ec5700c2a25e64842a9d3f81b48535b349a9d466)

Buildsystem/MSVC: Added missed change (cherry picked from commit 7732ad5153783ca31d32c6812f21c2b723fd589a)
Buildsystem/MSVC: Enabled /Zc:throwingNew for Visual Studio 2015 buildsMore info here: http://blogs.msdn.com/b/vcblog/archive/2015/08/06/new-in-vs-2015-zc-throwingnew.aspx

Closes #15230

(cherry picked from commit dcb1990e93bb879c88f1b43eb13292afa6baac86)

Merge pull request #15191 from Rushor/actionCore/SAI: Add SMART_ACTION_RISE_UP for Z Axis
(cherry picked from commit ba6da26e5db8cd6c3418d2a401e84d8701ac89f1)

Server/Game/AuctionHouseFixes world config value of less than 1 being ignored by deposit formula.

Had problems with the last commits and pr, sorry

Update AuctionHouseMgr.cpp

Adds another check to config to handle values over 1 and properly adjust the minimum higher. Thanks jackpoz!

DB: Fix a Typo on trinity stringBy @galathil
Closes #15567

DB/Creature: Add channeling cosmetic spell for Shadow ChannelerAdd 2 missing spawns
Add emote for Cult Researcher

DB/Creature: Iceskin SentryAdd missing aura
Fix movements and react

DB/Creature: Eversong RangerSAI fix
Closes #15602

DB/Misc: Fix some Unit flagsAdd Sai for Released Soul
Add some missing auras

DB/Item: Sylvanas Music BoxCloses #7865

Merge pull request #15473 from Treeston/3.3.5-fixplayerdamagereqCore/Unit: Player-summoned creature damage counts towards quest credit
Core/Commands: Fixed .gobject move and turn(cherry picked from commit 7eb25f1af6b74d3559b541d45da6cce50e657ba4)

Closes #3802
Closes #15598

Core/Commands: Fixed .gobject add command(cherry picked from commit b4d044aa13b06ae50b4e468d6647bd7a9eb1cc3e)

Custom logic for putting people in combat instead of relying on CreatureAI or Creature methods.
Clean up SmartAI::MoveInLineOfSight. Remove tons of duplicate logic and forward to CreatureAI::MoveInLineOfSight instead of using its own (incorrect) implementation. Move the removal of the 'distracted' state from SmartAI to UnitAI.cpp.Fixes and closes #7197 and #15482.

Core/Creature: Add facilities to the Creature class to allow setting an automated, periodic pulse that puts every player in the zone in combat and on the creature's threat list. Scripts/BossAI: Set the BossAI parent class to make use of this in its _EnterCombat and _Reset methods. Combat pulses happen every 5 seconds.
Merge pull request #15590 from unknown-8H3D/patch-1Fix TYPO in config file
DB/Creature: Some formations fixesBy Malcrom
Core/Creature: Better formations implementationBy Malcrom
DB/Misc: Multiple DB FixesAdd SAI to Drakuru Raptor to fix vehicle behavior
Add animation for Steam Burst
Add Equipments for 7th Legion Infantryman
Add a missing aura for Risen Gryphon Rider
Fix a DB error

DB/Creature: More Naxx pathing updateBy Malcrom
DB/Creature: More Naxx pathing updateBy Malcrom.
Build: Fix non-pch build after dcb7082277447c21b11c4a1d59f105fa342c172e
Merge pull request #15587 from Pirricli/patch-1minor typo
minor typo
DB/Creature: Misc formations fixesBy Malcrom.
Merge pull request #15538 from pete318/combat_bugCombat with distant creatures (Mk II)
Combat with distant creaturesIterate creatures in combat with players during map update, and also visit
their cells if greater than player visibility distance away.

Fix typo
DB/Loot: Netherwing RelicNetherwing Relic should have 100% chance to drop from dragonmaw transporter if player is on quest.
Merge pull request #15313 from pete318/map_local_guid_335[3.3.5/Core/Map] map local guids 6.x -> 3.3.5
DB/Creature: Scripts for Ring of the law encounter in Black Rock DepthsCloses #8158
Closes #14598

DB/Path: Add Dragonmaw Transporter pathsAnd Remove wrong spawns
Thanks to @Kittnz

DB/Path: Dragonmaw Subjugator & Dragonmaw Shaman- Also delete some npc's that shouldn't be there.

Merge pull request #15582 from mthsena/3.3.5Config: Typo/Cosmetic changes
Config: Typo/Cosmetic changes
Merge pull request #15579 from M-Pan/3.3.5Config ; Minor Typo
DB/Creature: More Naxx pathing updateBy Malcrom
Config ; Minor Typo# Updates.SourcePath > # Updates.MySqlCLIPath

Merge pull request #15577 from M-Pan/3.3.5Revise MaxPrimaryTradeSkill comment

Closes #15575
Revise MaxPrimaryTradeSkill commentsee https://github.com/TrinityCore/TrinityCore/issues/15575

Map local guids 6.x -> 3.3.35:Implemented:
https://github.com/TrinityCore/TrinityCore/commit/ca83e14f8b141fab0a13e08f48fca6c1ace0c4c7
https://github.com/TrinityCore/TrinityCore/commit/ee1c1b97be4492ecabe8b15ea6323fc37e4eaa8c
https://github.com/TrinityCore/TrinityCore/commit/18e4ab6911468b829b0fc768e532a770263c3717
https://github.com/TrinityCore/TrinityCore/commit/bf37446b3c2ed73b4d3aa9e227d3eff5c53b378b
https://github.com/TrinityCore/TrinityCore/commit/cb854a2b7bb7bd96cf9c4d1daf3789f797bf4db8

* This adds separate (per map) guid sequences depending on object type
* Ported map object container from cmangos/mangos-wotlk@a2d396e
* Added type container visitor for TypeUnorderedMapContainer
* Implemented helper function to erase unique pairs from multimap containers
* Moved object storage of all objects except players and transports to map level
* Added containers linking database spawn id with creature/gameobject in world
* Renamed DBTableGuid to spawnId
* Added a separate spawn id sequence generator for creatures and gameobjects - this will be used in db tables
* Moved building SMSG_UPDATE_OBJECT - updatefields changes broadcast to map update
* Added new function to return but not increment guid
* Adjusted .debug loadcells to show low guid in map before/after load
* Added debug messages for creature spawn/destroy, for map guid debugging
* Store all Gameobjects and Creatures added to OutdoorPvP, so the callback script can be removed when OutdoorPvP instance is destroyed.

DB/Misc: Fix some 3.3.5a leftoversBy Malcrom
Db/Creature: Update naxx pathingBy Malcrom
Core/Creature: Fixes Issue with Formations with 2 waypointsBy Malcrom
Partially revert "Core/Build: Added missing abort() calls on error handlers"This reverts commit 8ea17647e6bced9d4d027c94ecdc63369cb4c6df.

DB/Misc: Additional texts
Merge pull request #15554 from MrSmite/AHBot_BuyerFix AHBot Buyer to stop counting own auctions
Fix AHBot Buyer to stop counting own auctions
DB/Creature: Fix HoS formationsBy Malcrom
DB/NPC: Stable MastersCloses #15505

DB/Creature: Fix some formationsBy Malcrom.
Core/Creature: Fix formations to prevent crossoverBy Malcrom
DB/Quest: Take Down Tethyr!This will turn the kraken active once summoned until the waypoint is ended.

DB/Npc: North Sea KrakenA blizzlike script, only condition for the spell Flaming Spear and Tooth Explosion must be done once the condition (In Taxi) is implemented.

DB/Misc: Sha'tari Skyguard TextsMissing texts for a number of npcs for players exhalted wit the Sha'tari skyguard also texts for return of bombing run / bomb them again

Texts copied from parsed sniff as even though is set to output them creature texts are ommited from sql output.
DB/Misc: Naxxramas pathingBy @Malcrom

DB/Spell: Link Fear to Charge used by Spectral Chargers in KarazhanCloses #15488

DB/SAI: Fixing some creatures spamming "calling for help"Closes #15526
By @Malcrom

DB/Npc: Fix Thomas Miller's textCloses #15530

Core: Added ABORT() macro to prevent the usage of ASSERT(false) as a quick hack to crash the core misusing assert
DB/Creature: Remove a wrong spawn of "[DND]Esprit 1"Closes #15555

Merge pull request #15551 from Treeston/3.3.5-patchwerkScripts/Naxxramas: Patchwerk - quick bugfix (incorrect SpellID)
Scripts/Naxxramas: Fixed an incorrect spellid for Naxx10 Hateful Strike.
DB/Misc: Fix typo in a tele command for Royal ExchangeBy MrSmite, closes #15531
Core/ObjectMgr: Fix loading quest's RewardSpells(spells rewarded on quest completion)

DB/Creature: Fix 2 exploits more
DB/Creature: Fix another exploit on UP
DB/Gameobject: Fix doors being clickable in the Tempest Keep.Faction and flags are from sniffs.

Core/Unit: Fixed incorrect value sent in highest threat unit update
DB/Creature: Fix one big exploit on UP
Rename 2015_09_14_00_world_335.sql to 2015_09_15_00_world_335.sql
Rename 2015_12_09_00_world.sql to 2015_09_12_00_world.sql
Merge pull request #15497 from ShinDarth/335-misc[3.3.5] Low priority changes after latest backports
Merge pull request #15514 from ShinDarth/ticketScripts/Commands enhance .ticket complete command
Core/Misc: rename some variables after latest backports
Scripts/Commands enhance .ticket complete command
Merge pull request #15503 from Treeston/3.3.5-patchwerkCreature/BossAI/Patchwerk: Fix Hateful Strike behavior
Scripts/Naxxramas: Fixes to Patchwerk AI: - Hateful Strike can only target the highest 1 (10m)/ 2 (25m) threat targets that aren't the current target. Out of these targets, Hateful Strike hits the highest current HP target. - Hateful Strike now properly adds threat to all targets eligible for it, plus the current target if it is in melee range. Actual threat amount is not from sniffs - please update this if you have conclusive retail data. - Cleaned up some millisecond constants and variable names.
Merge pull request #15502 from Treeston/3.3.5-sapphironScripts/Naxxramas: Fixed minor bugs/quirks with Sapphiron
Scripts/Naxxramas: Fixed bugs with Sapphiron encounter: - Sapphiron will now properly re-engage if the previous attempt ended while he was in flight. - Sapphiron will now properly be hovering while in the air phase instead of standing idly on the ground. - Move Frost Resistance achievement check from custom script to spell 60539 (Sapphiron Achievement Check), thanks to @Shauren for the heads up.
Removed wip leftovers
Default initialize i_path instead of using NULL
Core/Players: Changed multi-segment taxi paths to fly nearby flight masters along the way, not directly through them* Taxi cost on multi-segment paths is now charged per segment when it is started

Core/Scripts: fixed startup errorsCloses #14730

Scripts/Ulduar: Fix issue reported by static analysisCoverity defect ID: 1316690

Core/Quests: Fix issue reported by static analysisCoverity defect ID: 1323839

DB/World: add VerifiedBuild field to creature/gameobject_questitem
Merge pull request #15483 from ShinDarth/335_quest_templateDB/World schema backport: updated quest_template table
DB/World schema backport: updated quest_template table
Merge pull request #15459 from ShinDarth/quest_template_backportDB/World schema backport: updated quest_template table
DB/World schema backport: updated quest_template table
Allow player-created temporary summons (quest "helper" NPCs summoned by item etc.) to contribute to the 50% player damage requirement.Fixes quests such as "Valduran the Stormborn" (12984) or "The Air Stands Still" (13125) which previously required the player to out-damage the "helper" NPC to get credit.

Merge pull request #15452 from Treeston/3.3.5Core/Unit: Allow mounting for certain transformations
Update 2015_09_09_00_world.sqlcopy&paste is evil.
DB/Misc: Fix startup errors
DB/Gossip: Fix gossip menus with only one special option
Merge pull request #15466 from M-Pan/3.3.5Config: Minor Typo
Config: Minor Typo# Updates.SourcePath > # Updates.MySqlCLIPath

DB/Gossip: Fix some weapon masters gossip menusAuthor: @tkrokli
Closes #15464

DB/Quest: Generosity AboundsAdd condition for the spell Iron Chain
Add cosmetic Exploding Abomination and fix visual issues.
Closes #15461

DB/NPC: Argent CannonAdd the regen mana on spell casted, and set initial mana to 0.
Closes #15460

DB/Misc: CorrectionA correction as pointed out by Killyana, reversing faction update do peons with defiant and enraged change hostile rather then the peons with the other 2 buffs turn friendly, Ye I forgot about the dragonmaw illusion buff when testing.
DB/Quest: "Where Kings Walk" and "Warchief's Blessing"By: @Rushor @xfurry @Grz3s
Closes #15246

Allow mounting while under transformations that can be cast while mounted.Closes #12042.

Credit to @SeTM for base code used.

Quest: Threat from AboveFix double credit.
By: @Saben65
Clloses #15457

DB/Quest: The Booterang: A Cure For The Common Worthless PeonMore updates,

1) remove random movement and spawn dist from creature as only peons with dazed & confused should have random movement
2) Peons with Lazy and Good for nothing and Dazed and Confused are friendly to players only peons which are defiant and enraged are hostile and attackable by players.
DB/Quest: Forging a HeadAttempts to salvage Stormforged Eyes from an Iron Giant's corpse will provide 2 Stormforged Eyes or will spawn 3 Iron Dwarfs.

DB/Quest: The Booterang: A Cure For The Common Worthless Peon* Update original script for this adding missing auras also the spell so booterang gets returned to player (visual only).
* Add more Disobedient Dragonmaw Peon, we now have 45 including the 10 which we already had in db.
Core/Spells: Fix crash happening when using items to cast spellsFix a crash happening when using items casting spells like Item ID 37198
Fix #14900

Core/Dungeon Finder: Fix groups queuing broken by 1e71aba2ee656a8407dec63a69d0879e16a070e2Fix queuing in LFG with 5-men groups leaving the party in queue forever, caused by group GUID being added to list of party members.

DB/Quest: Freedom for all creaturesCloses #4823

DB/Quest: Fix credit for Infiltrating Dragonmaw FortressCloses #15432

DB/NPC: Add Lady Medley CrewCloses #13911

Core/Dungeon Finder: Improve ".lfg queue debug" commandLog roles of every combinations in ".lfg queue debug" output

Core/Chat: Allow to sanitize | characters when sending messages to clientsAdd an optional parameter "escapeCharacters" to ChatHandler::SendSysMessage() to properly escape | character, otherwise it might freeze the client.

Core/SmartScripts: SMART_ACTION_TALK - added action param 3 to set target as talk target (used for $vars in texts and whisper target) * by default (action param 3 is 0), it will try to trigger talk of the target(cherry picked from commit 7b491046e94af498b2428ebe7decf6353cbb61a2)

DB/Creature: Delete duplicated spawns
DB/Creature: Delete duplicate spawn
DB/Creature: Delete duplicate spawn
DB/Creature: Delete duplicate spawn
DB/Quest: TheryluneFix npc behavior
Thanks to @Rushor and @CreshandKesh
Closes #14763

DB/Item: Comet's TrailFIx internal cooldown
By @Keader
Closes #15096

DB/NPC: Skyguard ScoutAdd cosmetic mount
Closes #15305

DB/Item: Girdle of the Warrior MagiFix socket bonus
By: @Rochet2
Closes #15311

DB/NPC: Blue Crashin' Thrashin' Racer and Crashin' Thrashin' RacerAdd missing auras and a spell.
By: @sirikfoll
Closes #15407

DB/Quest: Magic Carpet RideRemove a wrong spell used to ride the carpet
Closes #15418

Core/Spells: Make players immune to the taunt aura.
Merge pull request #15413 from ShinDarth/sort_quest_templateDB/World: fix bad field rename introduced in 6b43e72f019b6a91be812f4e4da58a4dae7c21a6
DB/World: fix bad field rename introduced in 6b43e72f019b6a91be812f4e4da58a4dae7c21a6
DB/Misc: Delete another duplicate spawn
DB/Misc: Delete another duplicate spawn
DB/Misc: Delete more duplicated spawns
DB/Misc: Delete another duplicate spawn
DB/Misc: Delete duplicate spawn
DB/Creature: Remove a Duplicate spawn for Overseer DeathgazeAdd a cosmetic channeling spell for Decrepit Necromancer and remove a wrong emote.
Closes #15404

SQL renames after PR merge
Merge pull request #15384 from ShinDarth/quest_backports2DB/World schema backport: sort some quest_template fields using 6.x style
Merge pull request #15356 from ShinDarth/quest_backportsDB/World schema backport: quest_details, _request_items and _offer_reward
DB/Spell: Add missing visual spell in Gortok Palehoof encounterCosmetic channeling spell casted by the red Orb to wake up the npcs

Script/BoreanTundra: Fix dialog and final waypoint for quest 11570: "Escape from the Winterfin Caverns"This fixes the following bugs:

Escortee NPC quotes are out of order (see #15396 (comment))
Final escort waypoint is located incorrectly and causes the escorted NPC to drop all the way to the bottom of the ocean before quest completion is awarded.

Closes #15396

Signed-off-by: DDuarte <dnpd.dd@gmail.com>

Core/Dungeon Finder: Remove disconnected players from LFG queueFix LFG queue issues by removing disconnected players from LFG queue and their party with them.

DB/Misc: Fix some phasemask
Core/Dungeon Finder: Add LFG roles of group members in LFG logsThis changes logs like "(1|18)" to "(1 Healer, Dps|18 Tank, Healer, Dps)"

DB/Creature: Kvaldir RaiderCloses #15390

DB/Misc: Move some wotlk spawns to proper range
Merge pull request #15385 from Tonghost/3.3.5Core/Scripts: Remove duplicate code
Core/Scripts: Remove duplicate code
DB/Conditions: Fix conditions for Mortar and Fire CannonAuthor: @joschiwald
Closes #15080

DB/Misc: Fix Rookery Whelp unit flagFix Crazed Mana Surge casting Loose Mana on death
Fix PrevQuest for Replenishing the Healing Crystals
Add some missing spawns to Ghostlands
Fix some issues on Utgarde Pinnacle
Disable health regen for Guard Roberts
Closes #15276
Closes #15286
Closes #15343
Closes #15348
Update #15362
Closes #15355
Thanks to @Pirricli @KiHeij @jududdar @pete318 @Tauriella @MrSmite

DB/Quest: The Brothers BronzebeardCloses #9889
Thanks to @StormBytePP for fixing the Vehicle issue on https://github.com/TrinityCore/TrinityCore/commit/ac2845ee77d0f3e838267ad424fbcf4894040333

DB/World schema backport: quest_details, quest_request_items and quest_offer_reward tables
Scripts/BWL: cleanup instancescript
DB/Misc: Add missing spawns on Howling FjordImprove some vehicles behavior
Improve some SAI
Thanks to @Pitcrawler for the scripts

DB/World schema backport: sort quest_template fields 6.x style
Scripts/Ulduar: fixed sara get killed by guardians of yogg saron
Core/Unit: Prevent AoE damage to have effect in some cases when faction is unfriendly but they don't attack you and you don't have at war enabled (Example, Sporaggar faction)Fixes #15374
DB/quest: The Ancient Armor of the Kvaldircloses #11154
Vehicle issue fixed on #15376 By @StormBytePP

Core/Vehicles: Fix CanEnterOrExit by implying that if a vehicle seat have anim for enter/ride means it can be entered/exited even in cases where it lacks VEHICLE_SEAT_FLAG_CAN_ENTER_OR_EXIT flagFixes issues #13298, #8195, #7468, #1290

DB/Conditions: Simplify the conditions for Kael'thas Ressurection spellSorry for the oversight, thanks @joschiwald

DB/Conditions: Missing spell target conditions for Kael'thas advisor Ressurection spell
Core/Spells: Skip spell category additional cooldown check added in 43e8c841f5357a6cf41cdb8ed5e496019f14a16a for SPELL_CATEGORY_FOOD.Workaround for #15278 till spell cooldown system properly supports spells with spell category triggering spells with same spell category.
Fixes #15278.

Merge pull request #15347 from StormBytePP/3.3.5_fix_dismounting_when_over_waterCore/Unit: Do not remove aura with interrupt flag AURA_INTERRUPT_FLAG_NOT_UNDERWATER when already flying
Core/Battleground: Fix issue reported by static analysisCoverity defect IDs: 1193415

Core/Battleground: Fix "Call to Arms: Isle of Conquest!" not giving Holiday Weekend honor
Scripts/Commands: Add taxinodes cheat status to* Some cleanup

Closes #15065

DB/Misc: Enable achievement The Culling of TimeBy sirikfoll.
DB/Creature: Ulduar - Seeping Essence does not deal damage on 10man difficultyBy LuqJensen, closes #15165
Scripts/VioletHold: Fix correct boss erekem repeat time intervalUpdates coverity issue #1318019

Scripts/VioletHold: Fix issue reported by static analysisCoverity defect IDs: 1318019

Core/Unit: Do not remove aura with interrupt flag AURA_INTERRUPT_FLAG_NOT_UNDERWATER when already flying
Scripts/VioletHold: Fix crash in Xevozz boss fightFix crash happening during Xevozz boss fight caused by passing a local list by reference to a lambda expression
Closes #15345

Core/BuildSystem: Merged crypto and gitrevision into common, cleaned include directory lists (to mimic 6.x buildsystem)
Merge pull request #15327 from Trisjdc/fix_rest_stateCore/Players: Improve rest state handling, allow several rest states to be active
Scripts/Build: Fixed noPCH compile
Scripts/VioletHold: rewrote the whole instancethanks @MitchesD for help

Core/Players: Improve rest state handling, allow several rest states to be activeFixes https://github.com/TrinityCore/TrinityCore/issues/15325

Core/Scripts: Fix noPCH compile
Scripts/OnyxiasLair: Force Onyxia to enter evade mode if pulled out of her room
DB/Misc: Typo fix
Scripts\MoltenCore: Disable Ragnaros' combat movement
Scripts/TheEye: Update Kael'thas Sunstrider's scriptCloses #4180
Closes #4181
Closes #8479
Updates #1885

Merge pull request #15318 from StormBytePP/3.3.5_fix_possible_nullpointer_dereferenceCore/Misc: Added checks for procSpell nullptr cases
Script/Commands: Add new "debug loadcells" commandCloses #15292

DB/Misc: Add a missing item to loot of Bag of Fishing Treasureshttp://www.wowhead.com/item=54469/blank-slate#contained-in-item
Build fixesConflicts:
src/server/game/Handlers/ItemHandler.cpp

Core/Misc: Added checks for procSpell nullptr cases Fixes Coverity Defect ID: 1023036
Merge pull request #15314 from StormBytePP/3.3.5_bitshift_undefined_behaviour_fixCore/Build: Fixed bitshift undefined behavior
Core/Misc: Fix issues reported by static analysisCoverity defect IDs: 1316687, 1316688

Core/Build: Fixed bitshift undefined behavior Coverity defect ID: 1193414
Scripts/Ulduar: fixed hodir kill creditCloses #15303

Build/Cmake: Fix a typo in common's CMakeLists.txt
Merge pull request #15297 from StormBytePP/3.3.5_rename_Revision.hCore/Build: Renamed Revision.h to GitRevision.h to avoid compile failure when old revision.h file is present
Core/Build: Renamed Revision.h to GitRevision.h to avoid compile failure when old revision.h file is present
Scripts/Misc: Replace some unsafe WorldObject* class members in scripts with ObjectGuidReplace some unsafe WorldObject* class members and derived types in scripts with ObjectGuid.
Code cleanup.

Merge pull request #15283 from StormBytePP/3.3.5_split_shared_componentsCore/BuildSystem: Merge collision, debugging, logging, threading and utils into "common" library, and split database from shared
Core/BuildSystem: Merge collision, debugging, threading, utilities and configuration into "common" which does not depend on shared anymore and moved database out of shared library These changes enables to build tools only without even having MySQL installed
Build fix for WheatyExceptionReport, c++ exceptions must not be thrown in SEH handlers
Core/Build: Removed obsolete SystemConfig.h and made genrev be part of shared library, which allows cache hits to happen more likely
Add a missing include of d5cf594bfe91ff22175c6e344b23b95cdbcc8a3c
Fix build warnings addded in d5cf594bfe91ff22175c6e344b23b95cdbcc8a3c
Core/Logging: Refactored appender creation to allow using logging without mysql dependency in tools (future task)Conflicts:
src/server/bnetserver/Main.cpp
src/server/worldserver/Main.cpp

Merge pull request #15156 from LuqJensen/Ice-barrierCore/Spells: Fix Shattered Barrier triggering on dispel
Core/Achievement: Fix Save The DayCloses #15202
Closes #15211

Core/Object: Add changes to ObjectGuid from 6.xcopy and move cctor
assignment and assig move operators

Ref 81abfe93bb96e5a769dc855f06fdc7578b352b39 and 89a8a7e1a4bdc22d2da17b1a3bf34fd52bf87e85

Build: Add 1.59 Boost version to FindBoost
Buildsystem: Fix Boost not found targeting VS2015 with pre-built binariesFix Boost libraries not being found by CMake when targeting Visual Studio 2015 with Boost installed using the binaries.
Fixes #15277

DB/Quest: Mystery of the Infinite, ReduxClose #10871

DB/Pathing: Stratholme - The Gauntlet
DB/Pathing: Stratholme - Hall of Light
DB/Pathing: Stratholme - Patchwork Horror
DB/Pathing: Stratholme - King's Square* Patchwerk + Ghouls
* Emote for 'Mangled Cadaver'

Core/Spells: Fix potions exploitFix an exploit that allowed to consume different potions even if they share the same cooldown.
Closes #15265

Merge pull request #15267 from Tonghost/3.3.5Core/Misc: Add a few consts to methods
Core/Misc: Add a few consts to methods
Core/Misc: Remove unneeded ToCreature() castsRemove some ToCreature() casts not needed anymore after 1ee90e1022a235859316e55356ea8a3d2f456c9b changes that moved IsPet(), IsTotem(), IsSummon(), IsGuardian(), IsHunterPet() and IsVehicle() from Creature to Unit

Core/Misc: Remove unneeded ToCreature() castsRemove some ToCreature() casts not needed anymore after 1ee90e1022a235859316e55356ea8a3d2f456c9b changes that moved IsPet() from Creature to Unit

Scripts/Misc: Fix possible crashFix possible NULL-dereference exception happening in PlayerOrPet checks used in Ulduar and Temple Of Ahn Qiraj

Merge pull request #15255 from StormBytePP/3.3.5_override_warning_fixesCore/Misc: Added some missing overrides
Core/Misc: Added some missing overrides
Core/RestState: Check area trigger radius instead of 1.0f distanceCloses #15016
Closes #15052

Signed-off-by: jackpoz <giacomopoz@gmail.com>

Merge pull request #15058 from Golrag/rorfaceScripts/Rotface: Fix Ooze flood targets.

Fixes #15031
DB/Quests: Restore pre-cataclysm spanish translations.Added updates to translations, in the try to remove cataclysm changes that got merged in the translations (only the spanish ones).
At least, this is an attempt to not be confused anymore for the changed quests, changed locations, and so, as many of the quests changed also the finish location it tells under its
objectives.
See notes in the beginning of the archive.
Closes #15076

Signed-off-by: jackpoz <giacomopoz@gmail.com>

[3.3.5] Core/Spells: Fix Shattered Barrier triggering on dispelPrevents Shattered Barrier talent from triggering when Ice Barrier is dispelled. It should only trigger when Ice Barrier is removed by damage(destroyed).
Closes #14555
Closes #14605

Merge pull request #15119 from robinsch/groundingCore/Spells: Grounding totem fix

Fixes #15108
Scripts/Kalimdor: Remove unused scriptRemove unused C++ script replaced by d69a31d238122ab1ceb998908ebf218299792a16

Core/Gameobjects: Move a log from FATAL to DEBUGThe log is triggered when a mage creates a portal to another map, uses it and then the portal despawns.

DB/Quest: MistClose #15218

DB/Npc: Skettis EvisceratorClose #15217

DB/Quest: Ulathek the TraitorBy @tkrokli
Close #8216

DB/Npc: Warbringer ConstructClose #15232

DB/Quest: Imp Deliveryclose #15236

Core/Battlegrounds: Move a log from ERROR to DEBUGThe "error" is a false positive happening every time a player in a Battleground logs out because WorldSession::LogoutPlayer() notifies the bg twice

Merge pull request #15219 from SeTM/patch-2Core/Spells: Fix some taxi paths not being available to players.

This allows players to use the taxi paths used already by spells 29376, 29377, 31752, 34578, 47851.
Fixes https://github.com/TrinityCore/TrinityCore/issues/12832
Core/AHBot: Add missing AHBot quality price ratio to configSigned-off-by: jackpoz <giacomopoz@gmail.com>

Core/Spells: Fix damage done by SPELL_EFFECT_NORMALIZED_WEAPON_DMGFix a rare case that would cause SPELL_EFFECT_NORMALIZED_WEAPON_DMG to do 4 billions damage or to trigger an assertion in Unit::CalculateDamage() depending by Unit base damage.
To reproduce the issue cast spell 25816 on a level 1-14 warrior, then make the warrior cast spell 694 on a Creature.

Core/SmartScript: removed initial timer of SMART_EVENT_IC_LOS and SMART_EVENT_OOC_LOS Closes https://github.com/TrinityCore/TrinityCore/issues/14516(cherry picked from commit e83a1c6b350575f784bd26c84b78d07b0bc2edbb)

Fixed load taxi nodes.Spell nodes not have prices.
to #12832
DB/Quest: Hints of a New Plague?(4)close #14519
By @CreshandKesh
3.3.5 only

DB/Quest: Elemental War - Complete Quest gossip
DB/Item: Crudely-Written Log - Dropconditions* again closes #2380

Merge pull request #15205 from Rushor/magicCore/Spells: Magic Suppression - Set ProcCharges
Core/Spells: Magic Suppression - Set ProcCharges* closes #15194

Core/AHBot: Adjust AHBot bid and buyout chancesApply an exponential formula to define the chance to bid/buyout an auction depending on auction price and item price ratio. The formula can be adjusted changing the new AuctionHouseBot.Buyer.ChanceFactor config parameter
Chance = 100 ^ (1 + (1 - (auction_price / item_price) / k)
k is the config parameter AuctionHouseBot.Buyer.ChanceFactor, the higher the number the higher chance to buy overpriced auctions.

Scripts/Spells: Fix Rapid RecuperationCloses #15180

Core/Script: Fix Corporal Keeshan
Core/Script: Set Faction at start of escort for Corporal KeeshanRequest by DRJ

DB/Quest: Fix sql update name
Fix SpellAurasEffects build on GCC 5.1Closes #14655

(cherry picked from commit 57ced3ccbd44c8d4955da645522c6cd85c001c6c)

DB/Quest: Dark heartFrom #15189

DB/Quest: Wandering ShayBy DRJ
Closes #5156

Scripts/RubySanctum: Widen random angles for meteor flames.Don't QQ because "OMG you're not testing any of your stuff", I can't build TC atm.

Memo: Meteor Flames have
```
[12] UNIT_CREATED_BY_SPELL: 74689/1.046616E-40
```

which isn't in DBCs, exists, but is not seen in sniffs.
(cherry picked from commit 0dc6ea161dce755a702f2e26d93ca2a1f46a903f)

Core/Spells: Fix Charge "no path" error with even bigger targetsAddition to a328a119784252c6d514436f4ceffa693ac65453 , clamp object size to [0,4] in case of very huge Creatures like Lord Marrowgar entry 36612

Core/Config: Describe better Wintergrasp.Enable option in worldserver.conf
Core/Threading: Handle CMSG_BATTLEFIELD_MGR_ENTRY_INVITE_RESPONSE only in WorldSession update because it removes the Player from his Group which is not thread-safe
Merge pull request #15168 from jameyboor/3.3.5Core/Creature: Fix Creature::UpdateMovementFlags() ignoring DynamicTree height

Fix Creature::UpdateMovementFlags() checking only maps/vmaps height and skipping GameObject height stored in DynamicTree
DB/Conditions: corrected loot conditions after 8a9f1b871ac7a3c165d00f1404eaf3d91e3c5060
Scripts/RubySanctum: Fixed Meteor Flames(cherry picked from commit 982b59d2ec280fa4eebfc95aa526b5d0b9f8675e)

Update boss_halion.cpp
(cherry picked from commit 50c23bbcb869f52d6102f3bb0192bada9da521a1)

DB/Misc: Fix startup errorsUpdates #14730
Build: Add missing include to MapScripts.cppFixes linker error in GCC/Clang

Build/CMake: Partially revert recent changes to FindMySQL.cmakeLooking for folders like ".../MySQL/*/include" matches the MySQL Connector C libs which caused some problems.
Related #15072, #15068

P.S ".../MySQL/MySQL Server*/include" doesn't work

(cherry picked from commit e2fb3bbd466641c794438933e636d63ebf19432e)

Travis build fix(cherry picked from commit a7d9c4e720c6546089123e301e31af1583628e4e)

DB/Pathing: Finish Dragonblight
SQL: Fix bad sql
Fix UpdateMovementFlags ignoring DynamicTree height.
Merge pull request #15164 from LuqJensen/mimironScripts/Ulduar: Fix a visual issue with Mimirons Rocket Strike and Fix Mimiron DB target attacking players
Scripts/Ulduar: Fix a visual issue with Mimirons Rocket StrikeIn p2 he should fire left or right rocket at random, not always left one. ref https://www.youtube.com/watch?v=oY-nZ0EjDRw

Fix Mimiron DB target attacking players.

Core/Misc: Added new error logs for gameobject_questitem / creature_questitem tables(cherry picked from commit 2fcab335df301a98269e427c955418fd98c3fd86)

DB/Ulduar: Fix Mimirons Rocket Strike not dealing damage in 25man mode(cherry picked from commit acd3fe5807e6f81c6d49037b4e38d819d94d6166)

Core/Misc: Update helgrind suppressions
Core: Fix non pch build
Core: Header cleanup in game/*/*.cpp(cherry picked from commit 2e586bc520e7eda2387e850c3c0049e6daa880de)

Conflicts:
src/server/game/Battlegrounds/Battleground.cpp
src/server/game/Battlegrounds/BattlegroundMgr.cpp
src/server/game/Battlegrounds/Zones/BattlegroundBFG.cpp
src/server/game/Battlegrounds/Zones/BattlegroundEY.cpp
src/server/game/Battlegrounds/Zones/BattlegroundTP.cpp
src/server/game/Chat/Chat.cpp
src/server/game/Combat/ThreatManager.cpp
src/server/game/DataStores/DB2Stores.cpp
src/server/game/DataStores/DBCStores.cpp
src/server/game/Entities/Creature/Creature.cpp
src/server/game/Entities/Creature/GossipDef.cpp
src/server/game/Entities/Object/Object.cpp
src/server/game/Entities/Object/ObjectGuid.cpp
src/server/game/Entities/Object/Updates/UpdateData.cpp
src/server/game/Entities/Pet/Pet.cpp
src/server/game/Entities/Player/Player.cpp
src/server/game/Entities/Player/Player.h
src/server/game/Globals/ObjectAccessor.cpp
src/server/game/Handlers/BankHandler.cpp
src/server/game/Handlers/CombatHandler.cpp
src/server/game/Handlers/GroupHandler.cpp
src/server/game/Handlers/GuildHandler.cpp
src/server/game/Handlers/ItemHandler.cpp
src/server/game/Handlers/MiscHandler.cpp
src/server/game/Handlers/MovementHandler.cpp
src/server/game/Handlers/PetitionsHandler.cpp
src/server/game/Handlers/QueryHandler.cpp
src/server/game/Handlers/SpellHandler.cpp
src/server/game/Handlers/TokenHandler.cpp
src/server/game/Handlers/VoiceChatHandler.cpp
src/server/game/Maps/Map.cpp
src/server/game/Movement/Spline/MoveSplineInit.cpp
src/server/game/Quests/QuestDef.cpp
src/server/game/Server/Packet.cpp
src/server/game/Server/Packets/SpellPackets.cpp
src/server/game/Server/WorldSession.cpp
src/server/game/Server/WorldSocket.cpp
src/server/game/Spells/Auras/SpellAuraEffects.cpp
src/server/game/Spells/Spell.cpp
src/server/game/Spells/SpellEffects.cpp
src/server/game/Spells/SpellScript.cpp
src/server/game/Warden/Warden.cpp
src/server/game/Warden/WardenWin.cpp
src/server/game/Weather/WeatherMgr.cpp

Buildsystem/MSVC: Enabled /bigobj for all x64 build types(cherry picked from commit 52127197ec3ab3c77397867a9ab674fe6c0d8aeb)

Core/Collision: Removed direct GameObject references from collision project(cherry picked from commit a029f97c8231f7be188663d63f95f34dd1b4f9e1)

Conflicts:
src/server/collision/Models/GameObjectModel.cpp

Core/SmartScripts: added new action SMART_ACTION_COMBAT_STOP * this avoid using hacks like evade, faction change or rooting. I wonder how SAI could be without this(cherry picked from commit d68df33c7689d62e27787f75820fd5b5be94005f)

Scripts/Ulduar: fixed freya loot and added missing conditionsthanks @Keader

Closes #15098

DB/Quest: A Flawless Plan* closes #12190
* thanks to @Pitcrawler + @Killyana for missing Spawns

Update 2015_07_24_07_world.sql
DB/NPC/Quest: Grizzly Hills Giant and Rallying the TroopsClose #14781

DB/Spawn: Dark Iron Brewer
DB/Quest: Into the Soulgrinder* much thanks to @Killyana for all the Updates
* updates issue #3178

DB/NPC: Dark Iron Brewercloses #15047

DB/SAI: Update Feralas for 3.3.5* closes #15126
* updated by @Killyana

DB/Item: Sack of Ulduar Spoils / Large Sack of Ulduar Spoils * closes #15059
DB/Misc: Fixup evading Creatures closes #15094
DB/Point of Interests: Locales points of interest closes #15110
DB/Pages: Locales for page text * closes #15105
DB/Misc: Grim Guzzler Area Events closes #15138
DB/Misc: Stable Master Xon'cha - Flags * closes #15117
Scripts/RubySanctum: Halion: Correctly spawn X-shaped flames.
Fix non pch build for Visual Studio 2015 compiler(cherry picked from commit df1f4969d844ee913149e1fd93ab79d3e0754b5c)

Misc: Removed tabs(cherry picked from commit 4e83094354551b2b7efe40053cb57286b96c861b)

Core/Misc: Add a few consts to methods(cherry picked from commit 7d9843c380cf00f38ad0c5bc75fd387e50ee11da)

Conflicts:
src/server/bnetserver/Packets/ConnectionPackets.h
src/server/game/AI/SmartScripts/SmartAI.h
src/server/game/Battlefield/Battlefield.h
src/server/game/Battlegrounds/Battleground.h
src/server/game/Entities/Object/Object.h
src/server/game/Entities/Player/Player.h
src/server/game/Guilds/Guild.h
src/server/game/Instances/InstanceSaveMgr.h
src/server/game/Support/SupportMgr.h

Fix non pch build.(cherry picked from commit 49a6f7b7bd9fb87ece479636e9aaccf3ea02e6da)

Core/Misc: Fixing warnings detected by Visual Studio 2015 compiler(cherry picked from commit a22e4e121a1e54b2f4154d59623ee4a94a449176)

Conflicts:
cmake/compiler/msvc/settings.cmake
src/server/game/DataStores/DBCStores.cpp
src/server/game/Entities/GameObject/GameObject.cpp
src/server/game/Entities/Object/Object.cpp
src/server/game/Entities/Object/Object.h
src/server/game/Entities/Pet/Pet.cpp
src/server/game/Entities/Player/Player.cpp
src/server/game/Entities/Unit/Unit.cpp
src/server/game/Garrison/Garrison.cpp
src/server/game/Garrison/GarrisonMgr.cpp
src/server/game/Globals/ObjectMgr.cpp
src/server/game/Globals/ObjectMgr.h
src/server/game/Guilds/GuildMgr.cpp
src/server/game/Handlers/CharacterHandler.cpp
src/server/game/Handlers/QueryHandler.cpp
src/server/game/Handlers/QuestHandler.cpp
src/server/game/Handlers/SpellHandler.cpp
src/server/game/Server/Packets/ChannelPackets.h
src/server/game/Server/Packets/PartyPackets.cpp
src/server/game/Server/WorldSession.h
src/server/game/Spells/Spell.cpp
src/server/game/Spells/SpellInfo.cpp
src/server/game/Spells/SpellScript.cpp
src/server/scripts/Commands/cs_list.cpp

Fix non pch.(cherry picked from commit 5987391073b0a7a257658ecef51f1df4f0f38842)

Core: Remove whitespaces(cherry picked from commit 5705555f1f9a259f2d4d52980ccb68d1b909b7a2)

Conflicts:
src/server/game/Server/Packets/TicketPackets.h

Merge pull request #15116 from pete318/runeforging[3.3.5] Core/Spell: Learn DK runeforging skill, when receving the spell book ability.
Core/AuctionHouse: Fix misleading log
Core/Utilities: Add std::chrono::duration overloads to EventMap. * makes it possible to write: ```c++ events.ScheduleEvent(1, Seconds(10)); // ... or ... events.ScheduleEvent(2, Minutes(1) + Seconds(20)); // ... or with C++14 support: events.ScheduleEvent(2, 45s); ```(cherry picked from commit e4e55a3dcbd846fd583b4fc86344d88ca63588d7)

Core/Database: Enable perfect forwarding for chat format calls.(cherry picked from commit 4904318c43567277f2d32c758724e82874f29849)

Core/Database: Enable perfect forwarding for database format calls.(cherry picked from commit ca16dc8c1b8da86f55a790a5f8cc6913dd005fcc)

Core/Logging: Enable perfect forwarding for logging format and args. * Handle timestamp parsing though cppformat. * Change a wrong forward -> move(cherry picked from commit 026ceb85b9e0e870d95cea42895e867198c156dd)

Core/Logging: Partial cherry-pick from commit c6ab951025b0be3b0f6 * solves differences 3.3.5 <-> 6.x because of make_unique workarround.(cherry picked from commit c6ab951025b0be3b0f64dc8bb0703d4aa8bdb003)

Signed-off-by: Naios <naios-dev@live.de>

Core/Utilities: Move EventMap into its own source file. * Move implementation details to .cpp.(cherry picked from commit 11bfead40b431cf7bb8e86c4cada059ed614344b)

Conflicts:
src/server/game/Battlegrounds/Battleground.h
src/server/shared/Utilities/Util.cpp

Core/Utilities: Forward parameters of StringFormat correctly to fmt::sprintf.(cherry picked from commit 11dfd9e7d4967aaa2dcecc6d4f7a8ac21b4013fd)

Core/Utilities: Remove global using of std::chrono namespace. * never use "using namespace" in header files!(cherry picked from commit 6bf10c2b83063147737aee68d3b40a6d67e49d53)

Core/Utilities: Seperate std::chrono::duration typedefs into its own file. * add std::chrono_literals using decl. comment for future usage.(cherry picked from commit 6e4a1b3e1e5a735f26284c560b1463cdd527b2fe)

DB/Misc: Fixup 2 Runtimeerrors
Core/Collision: Fix race conditions in mmapsFix a race condition in MMapManager happening whenever a map was unloaded. GridUnload enabled was required to trigger the race condition.

Scripts/ScarletEnclave: Add weapons to Unworthy InitiateCloses #14954
Closes #14955

(cherry picked from commit 673648ee6507597837bd2c8a7a78f425d139baea)

Core/SAI: Fix some weird code in SmartAIMgr::IsTextValidAdditions to cb0e6cac63638fd229cce16c341c6d3d2d77d0d9

(cherry picked from commit 57da378dea2b13c092dab71b181c859790e41b99)

Conflicts:
src/server/game/AI/SmartScripts/SmartScriptMgr.cpp

DB/Pathing: Dragonblight - Lights Trust + Jintha'kalar + Border Zone to Zul'Drak* also spawn missing Creatures for Border Zone to Zul'Drak

Core/Collision: Fix race conditions in vmapsFix a race condition in VMapManager2 happening whenever a map was unloaded. GridUnload enabled was required to trigger the race condition.

DB/Pathing: Dragonblight - Scarlet Point
Core/Spells: Renewed Hope also affects Flash HealCloses #15037

DB/SAI: Frigid Necromancer* some creatures near the Shrine should always cast this channel

DB/Pathing: Dragonblight - Jortun
DB/Creature: Crystalline Ice Giant - Add missing 'Boulder Miss'-Emotes
Scripts/VioletHold: Fix build warnings
Core/Misc: Update game object template locale in simple system(cherry picked from commit f4536f38123c536d90733d047e1072b4dd88e910)

Conflicts:
src/server/game/Globals/ObjectMgr.cpp
src/server/game/Handlers/QueryHandler.cpp

Learn death knight runeforging skill, when receving the spell book ability. (#13882)
Core/Threading: Clarified comment on ProducerConsumerQueue::WaitAndPop(cherry picked from commit 08316552b5b176e8209d7e8f15c53053d049743d)

Core/Globals: Rename AddCreData -> AddCreatureData and MoveCreData -> MoveCreatureData
DB/Pathing: Dragonblight - Coldwind Heights + The Crystal Vice* also Fixup startuperror from previous commit

DB/SAI: Wastes Digger* add missing Attackemote

#15108
DB/Pathing: Dragonblight - Icemist Village (West) + Azjol Nerub + Agmars Hammer Area + Obsidian Dragonshrine
DB/Creature: Smoldering Skeleton Visual* add missing burn visual

DB/SAI: Anub'ar Cultist* Add missing ' Empower' visual - this will be casted all the time on 'Anub'ar Blightbeast'

DB/Pathing: Dragonblight - Moonrest Gardens (West) + Dragonblight (Spider Corner) + Westwind Refugee Camp + Icemist Village
DB/SAI: Anub'ar Ambusher*update Comments, range of spell 'rush', add visual 'Digging through Snow'

DB/Pathing: Dragonblight - Stars' Rest
Merge pull request #15036 from tkrokli/dk_wandering_plagueCore/Spells: remove incorrect PvP combat state
Merge pull request #14974 from pete318/stealth_workStealth changes (Player stealthed vs NPCs) - 3.3.5
Merge pull request #14883 from tkrokli/omen_of_clarity[3.3.5] Core/Spells: Avoid losing spell mod auras when check on spellcast fails
DB/Pathing: Drgaonblight - Woods of Lothalor + Indu'le Village + Moonrest Gardens
Merge pull request #15092 from robinsch/shamanT10enhancementCore/Spells: Enhancement Shaman T10 4P bonus set
closes #15090
DB/Pathing: Dragonblight Pathing - Moa'ki Harbor + Azure Dragonshrine
Core/Spells: Enhancement Shaman T10 4P bonus set #15090
DB/Pathing: Dragonblight - New Hearthglen + Dragon Wastes
DB/SAI: Bloodpaw Warrior + Bloodpaw Marauder
DB/SAI: Deathless Watcher - Add 'Submerged' Emote
DB/Spell: Invisibility - Reducing threatcloses #15044 - by @robinsch

Merge pull request #14986 from robinsch/chimeraShotScripts/Spells: Hunter's Chimera Shot - Serpent damage
Merge pull request #14987 from robinsch/fixupSpellModDOTCore/Spells: Revert changes to Unit.cpp done in 198ffba
DB/Pathing: Howling Fjord - Gjalerbron* this completes the movement for the Fjord

Core/Spells: remove incorrect PvP combat stateby @P-Kito; retrieved from #15027

Neither Vampiric Embrace nor Wandering Plague
should keep PvP players in combat state.

Players can't drink for extended periods of time in arena
debuffed with Death Knight's Wandering Plague + diseases
or when the counterpart is buffed with Vampiric Embrace.
Every tick keeps them in combat. This PR should fix the issue.

Scripts/Commands: Allow .maxskill to be used with self or selected playerCloses #15064

DB/Quest: Well Watcher SolanianFix quest givers and locales as for wow 3.3.5a.
By Killyana, closes #15069
TDB 335.59 - 2015/07/14
DB/Pathing: Howling Ford - Baleheim
DB/Pathing: Howling Fjord - Wyrmskol
Script/Rotface: Fixed Ooze flood targets.
DB/Misc: Fix startup errorBy Killyana, updates #14730
Update 2015_07_12_02_world.sql
DB/Creature: Fixing some spawns on The Frozen Halls entranceBy Killyana, closes #15014
DB/Creature: Senani Thunderheart gossipBy tkrokli, closes #14861
DB/Misc: The Grim Guzzler fightBy Killyana, closes #14631
DB/Quest: The ChallengeBy Killyana, closes #4802
DB/Quest: Slaves to SaroniteBy Killyana, closes #7318
DB/Gameobject: Dark Keeper NameplateBy Killyana, closes #6915
DB/Quest Hellfire FortificationsBy Killyana, closes #15051
DB/Misc: Fix a runtime errorBy Killyana, updates #14730
Scripts/FoS/Bronjahm: fixed corrupted soul fragmentCloses #5215

Spell Script for quests Among the Champions and The Grand MeleeSolves issues with the credit spells hitting the mount instead of the player itself.

Update .gitattributes to prevent CRLF issues
CRLF to LFSeriously....

Merge pull request #15023 from robinsch/combatMovementSmartAI: Incorrect removal of movement at SetCombatMove
Core/Instances: Fix some Instance Lock chat messagesAlways send a Welcome type Instance Lock chat message when entering an instance instead of changing type based on remaining time.
Fix scheduled warning message to always send "Your instance lock for ... will expire in 0 minutes." even if there are hours left, issue added in 4193806dba4de81f0e24c94bc470faaaa0e717cf , closes #11519 .
Update warning messages based on remaining time so that the most meaning is always used (6 hours left, 59 minutes left, etc).

SmartAI: Added the possibility to despawn object with action 41 (SMART_ACTION_FORCE_DESPAWN)
SmartAI: Fixed a bug where creatures would clear movement flags when they shouldn't at SetCombatMove.
Core/PacketIO: Removed timezone adjustments from ReadPackedTime - player's session timezone offset should be used there, not server offset(cherry picked from commit aa3b05c312626d903228aa7a768a069bce5fe526)

SQL: Quickfix a typo
DB/Misc: Spawn several missing gameobjects and creatures in The Eye- Several pack of mobs and triggers spawned
- Spawned doors at Kael's room
- Corrected spawn coords for Kael'thas and his advisors from sniffs
- Removed improper spawns of Ember of Alar

Scripts/Ulduar: Fix Flame Leviathan instance lockFix Flame Leviathan instance lock not being granted to players because they were ejected from the vehicles as soon as boss died.
Players are now ejected some seconds later.
Close https://github.com/TrinityCore/TrinityCore/issues/15005

Core/Spells: Normalize Z for last point in a charge pathNormalize the new point that 124398feefc64fe77ab01f469fbde645edbeb80f adds to a charge path.

Core/Misc: Fix build warningsFix build warning reported by clang 3.6

Merge pull request #15006 from Kaev/3.3.5Updated BattlegroundWS.cpp 15. minute timer check
Update BattlegroundWS.cppChanged timer check from 900000 to 15*MINUTE*IN_MILLISECONDS for better readability.
Core/Executables: Add --version and -v to worldserver and authserver argumentsCloses #14993

(cherry picked from commit 0f082e8f925f17e585fd221b901f55581d2d68ab)

Conflicts:
src/server/bnetserver/Main.cpp

Buildsystem: Fixed disabling compiler warnings in dep for clang/icc(cherry picked from commit c24787f6665b5ea2b696bdfa7134a19ab5a3c331)

(reverts 77f7f562683753a15bd2d3f80e65385f88383566)

Conflicts:
dep/CascLib/CMakeLists.txt
dep/zmqpp/CMakeLists.txt

Core/ObjectMgr: Fix 3 -Wunused-private-field warnings in TempSummonGroupKeyReplace a memcmp by a lexicographical comparison with std::tie

(cherry picked from commit 1df20a2134dbb84d1eb30024171ccd7e8b103e47)

Scripts/Commands: ".mmap path line" now uses raycast pathfindingAdd "line" optional parameter to ".mmap path" command to use raycast implementation of recast, useful to simulate charge paths.

Core/Spells: Fix Charge "no path" error with huge targetsFix Charge returning "no path found" error when targeting targets with Object Size of 8 like Festergut by changing how the target Z coordinate is set, using only half object size.
It is unclear why the CalculatePath() call in Charge handler is using target object size, maybe for corner cases where the target is slightly below the ground.

Scripts/EoE: fixed crash- removed some useless code (and some other random changes)

The following stealth changes are implemented. - Combat no longer removes stealth, only damage does - Creatures will pursue a stealthed unit they cannot see if they're already in combat with them - When a player is ~~3 yards~~ 8% + 1.5 yards away from the usual stealth detection distance, the creature will perform the "alerted" effect. - When sitting/sleeping creatures are distracted or alerted, they will stand up - Idle movement creatures will return to their original (spawn) orientation after distract/alert - When entering combat with a distracted/alerted creature, distract state is removed - NPC no longer have a limit to stealth visibility (granted by stealth modifier spells/buffs) - If alert visibility is greater than aggro range, no alert sent
Scripts/EyeOfEternity: Fix crash added in d1853f693b2c1a60134603d946e31f71f26535c0Close https://github.com/TrinityCore/TrinityCore/issues/14984#issuecomment-118044904

Dep/G3D: Backport fix from G3D10
CI/Travis: Report travis build as broken if new build warnings get added to the sources
Merge pull request #14797 from czw/3.3.5Core/Spells: Fix DK Death rune selection
DB/World schema backport: split quest_template and quest_template_addonCloses #14982

Signed-off-by: DDuarte <dnpd.dd@gmail.com>

DB/Misc: Brewfest - Wrong item in vendorsBy sirikfoll, closes #14989
DB/Creature: Fixing some auras set with a wrong eventBy Killyana, closes #14875
DB/Misc: Fix a runtime errorBy Killyana, updates #14730
Dep/gsoap: Turn off build warningsDisable -Wunused-parameter warnings in gsoap library to have a 0-warning build till the library gets updated

Dep/CppFormat: Update cppformat to cppformat/cppformat@7859f8123311c1b8f698 * clean up our custom CMakeList.txt
Core/Misc: Fix build warnings
Core/Unit: Fix issue with Divine Shield immunities Closes #14910
Core/Spells: Revert changes to Unit.cpp done in https://github.com/TrinityCore/TrinityCore/commit/198ffba5ee3b64852b3b090ebdeebd87494cc9f6. This will fix issues with direct damage spells dealing wrong damage that are based on percentage of existing HOT or DOT auras due to missing SPELLMOD_DOT apply.
Scripts/Spells: Hunter's Chimera Shot - Serpent (ID: 53353) damage should be increase by Improved Stings talent.
[3.3.5] Core/Spells: Omen of Clarityby @robinsch; closes #3088.

Purpose: make the Omen of Clarity druid buff (http://wotlk.openwow.com/spell=16864) work as intended.

This change is an addition to @Shauren's commit 37145b6.
Before this change, spell mod auras lose charges when they are unable to be cast
as mentioned in the issue. As an example: Omen of Clarity loses its charge
when Shred can not be used, because it requires the caster to behind the target.

This change will restore the spell mod if CheckCast returns false for the initial cast.

Cleanup duplicated names from contributors list. * ref 1a7a9619d87e95ecdc75fe01
Core/Updater: Fix mysql cli password prompt when password is empty. * ref: http://community.trinitycore.org/topic/11510-world-server-bug-enter-password-to-update/
Core/Utilities: Fix callback invokation when there are no tasks present. * thx @joschiwald for noticing.
Spell/Script: Mirror Image fix - solves #14877
Scripts/RubySanctum: Fix build warnings
Merge pull request #14979 from ShinDarth/gitignoreAdd nbproject/* to gitignore
(cherry picked from commit a0f9cadb18f1e1cfd2879a49b2dc66566652dbae)

Merge pull request #14898 from tkrokli/improved_devouring_plague[3.3.5] Core/Spells: Improved Devouring Plague spell direct damage
Core/Spells: Implemented CAST_FLAG_IMMUNITY
Buildsystem/Clang: Suppress warningSuppress -Wmismatched-tags warnings on clang to avoid false positive warnings reported using gcc 4.8

Merge pull request #14941 from ShinDarth/db_backports3DB/World schema backport: move questItem* fields to *_questitem tables
Merge pull request #14969 from chaodhib/taunt_threat_fixes[Spell] Fix bugged amount of threat given by Taunt
Merge pull request #14976 from robinsch/wgTimerCore/WorldState: WG Interface timer
Closes issue #14913
DB/World schema backport: move questItem* fields to *_questitem tables
[SpellEffect] Fix bugged amount of threat given by Taunt1) doAddThreat call instead of AddThreat. ThreatCalcHelper shouldnt be called. Otherwise, the value of the threat that will be added to the caster will be multiplied by a threatModifier (about 1.6)
2) Taunt should give the caster the same threat as the one in the top of the list. If player A has aggro with 1000 threat, player B has 1050 threat and if player C taunts, player C should have 1050 threat after the taunt and not 1000 (the difference can be much bigger with ranged players).

Build/CMake: Fix finding MySQL install(cherry picked from commit d4deb17a2f94d06b7eab232b90e874fa58675b36)

Core/WorldState: Send BATTLEFIELD_WG_WORLD_STATE_ACTIVE when sending initial world states for Wintergrasp. This will fix issue #14913
Merge pull request #14971 from ShinDarth/fix_char_updDB/Characters fix auto updater
DB/Characters fix auto updater
Core/Dependencies: Fix some warnings in G3D
Tools/Misc: Fix build warnings
Core/Dependencies: Update recastUpdate recast to https://github.com/memononen/recastnavigation/commit/1dd5cf1883d61e723fef3d4957cf758c50e7a52b
Fix 2 warnings.

These changes have no effect on MMAPs and it's not needed to re-extact them.

Update 2015_06_28_02_world.sql
DB/Gameobject: Silithyst MoundBy Killyana, closes #14637
DB/Quest: Master the StormBy Killyana, closes #1883
DB/Quest: A Race Against TimeBy Killyana, closes #1074
DB/Quest: The Perfect DissemblanceBy Killyana, closes #12439
DB/Creature: Innkeeper KeldamyrBy MrSmite, closes #12474
DB/Misc: Fix startup errorsBy Killyana, updates #14730
DB/Oculus: typo in sql
DB/Oculus: mob missing spells / visuals
DB/Quest: I've Got a Flying MachineCloses https://github.com/TrinityCore/TrinityCore/issues/14965

By Killyana

Scripts/VioletHold: fix a crash during Ichoron encounter Closes #14962
Core/Creature: Fix UNIT_FLAG_IMMUNE_TO_PC validity for player pets related to #14780 and #14744
Scripts/Oculus: Implemented Drake GPS system
Fix build after recent cherry picks (v2.0)
Fix build after recent cherry picks
Fix build and SQL import after recent cherry picks
Scripts/RubySanctum: Updates to Halion.* Fixed Living Embers not spawning.
* Meteor Strike is now randomized.

(cherry picked from 1447875cac0fefd58ae3ad27e6b3fa2134a714c0)

Scripts/RubySanctum: Fix a mathematical mistake.
SQL: Do not use MAX(Id), hardcode it.

(cherry picked from 7a5bc9e1fe457f0c77cdfecefa5bd42525105c3e)

Scripts/RubySanctum: Correctly spawn Living Embers.

(cherry picked from 7c4b8b0e826fd1cdab8a635225123aebd1b950c6)

Scripts/RubySanctum: Remove duplicate code.

(cherry picked from 1d29328769d505caf4541b0d712972195dda8b70)

Core/Misc: Warning fixes

(cherry picked from dc53dad8a44292bcb555db9fdc07eb255a838cac)

Merge pull request #14920 from Exodius/Exodius-readmeUpdate README.md
(cherry picked from commit 4093eee19b511864f1049c8d2e9c34ab897f619c)

Core/Units: Changed SPELL_AURA_MOD_MINIMUM_SPEED to always be applied, not only if under a slow aura (SPELL_AURA_MOD_MINIMUM_SPEED can set the minimum speed higher than base speed)(cherry picked from commit d2142ac380863716ecea6f4aa44f7e556e44dfd9)

Core/BattlegroundIC: Removed 1 hack:* Parachute spell is now blizzlike
* Also restored "The battle will begin in 2 minutes."

(cherry picked from commit 8a4afad63ac97b39f6746d466f3166eeef62e711)

Conflicts:
sql/updates/world/2015_05_01_00_world.sql
src/server/game/Miscellaneous/Language.h

Rename 2015_05_01_00_world.sql to 2015_06_13_00_world.sql

(cherry picked from commit 74eeefa5be163a55489f91c05d7dfd1cb624c78d)

Core/GameObject: Removed unneeded argument from GameObjectModel::Relocate and renamed it to UpdatePosition(cherry picked from commit 6e9ab38fcc9d2859393e452ef8630ee420783e47)

Merge pull request #14723 from TrinityCore/findmysql-updateUpdate FindMySQL.cmake
(cherry picked from commit fb4a9823c41b31158f6b5d68fc2ffc1608051984)

Core/LootMgr: Remove dead validation code from LoadLootTableCID 1288389 Operands don't affect result

(cherry picked from commit 47a119e4fa617319b283e7c3824241bc0b6775fb)

Core: Fix multiple Coverity issues(cherry picked from commit b8c681c776d7918e7b3f2a89422509a87bcb5da2)

Conflicts:
src/server/game/Garrison/Garrison.cpp
src/server/game/Server/Packets/CharacterPackets.h
src/server/game/Server/Packets/MovementPackets.h
src/server/game/Spells/SpellInfo.cpp

DB/Characters: Backport schema changes from 6.x branch (renames)Closes #14951

Scripts/VioletHold: Fix codestyle and unwanted crash in Violet/Hold closes #14952 and #14953
Scripts/VioletHold: fixed non-pch build and codestyle
Rename 2015_06_08_01_world.sql to 2015_06_25_00_world.sql
Merge pull request #14860 from mik1893/violetholdCore/Scripts: Violet Hold, full rework
Core/Instances: Make achievements and loot rolls instance-wideMake achievements, loot rolls, master loot at money loot instance-wide, removing the previous limit for 74.f yards

Scripts/Spells: fix codestylethanks @whoami

DB/Quest: Fix 2 swapped values of midsummer event
Core/Scripts: Rework Violet Hold bosses adding missing spells/mechanics: - Cyanigosa, Arcane Vacuum - Ichoron, globules mechanic - Moragg, optic link visuals - Lavanthor, minor changes - Zuramat, correctly implement void sentries - Erekem, implement Windfury and correct management of Erekem Guards - Script for the pre-event Thx @ManuFe
Game/GameObject: Fix Spellcast for 'Silithyst'by @Whoami
updates #14637

Rename 2015_08_29_00_world.sql to 2015_06_23_01_world.sql
Merge pull request #14776 from sirikfoll/SpellMidsummerCore/Spells Add support for quest Torch Tossing/More Torch Tossing
DB/World: Backport schema changes from 6.x branch (renames)Closes #14899

Core/Misc: Update helgrind suppressions
Core/Utilities: TaskScheduler: add a task validator and on update success callback. * makes it possible to block tasks if there is an active spellcast. * requested by @joschiwald
Core/Updater: Fix a wrong formatter introduced in 0d095109eec31 * thanks @Aokromes for noticing
Core/Creature: fixed loading of creature auras on respawn, deathState needs to be set to ALIVE before trying to AddAuras (which fails with different deathState than ALIVE)Closes https://github.com/TrinityCore/TrinityCore/issues/4150

(cherry picked from commit 530074f453c568dc4065994ad908d3bfc7388534)

Fix file name
Core/Misc: Add valgrind support for jemallocSet CMake option VALGRIND to add valgrind support to jemalloc. Set CMake parameter VALGRIND_INCLUDE_DIR to the valgrind include directory.

DB/Path: Gundrak Savage pathing
Scripts/Commands: Fix memory leak in ".reload command"Free commandTableCache object before assigning it the result of malloc()

Core/Updater: Add some info about the count of applied updates. * some minor improvements * add a log message when database updates are disabled.
Scripts/Zul'farrak: Fixed summoning Gahz'rillaFixes #5782 regression

(cherry picked from commit cec05ff07d1751649b6eecff07f23f52ca5443cd)

[3.3.5] Core/Spells: Improved Devouring Plague spell direct damageby @robinsch; closes #14869 (Improved Devouring Plague error in direct damage)

Pct damage bonus is not applied because in SpellDamageBonusDone,
it just returns 1.0f for DamageType DoT. Because Improved Devouring Plague direct damage
is based on DoT damage from plague, it should also be modified when DoT damage is.

Core/Players: Fix converting quests on faction changeFix quests not being converted on faction change due to table world.player_factionchange_quests not loaded on startup

Core/Spells: Fix Charge pathingFix charge allowing to run to unreachable places
Close #13847

Core/ChatCommands: Allow to use "tele" command inside of a battlegroundAllow GameMasters with ".gm on" tag to use ".tele" command inside of a battleground to tele around.

DB/Quest: Hellfire FortificationsBy tkrokli, closes #14887
Merge pull request #14728 from kelno/fixesCore/SAI: Fixed a math error overflow in SmartScript:ecPhase(int32)
Merge pull request #14611 from ariel-/spellsCore/Spell: Spell logging corrections
Merge pull request #14250 from xjose93/SPELL_AURA_USE_NORMAL_MOVEMENT_SPEEDCore/Unit: Fix snare/daze immunities versus SPELL_AURA_USE_NORMAL_MOVEMENT_SPEED

Fix SPELL_AURA_USE_NORMAL_MOVEMENT_SPEED modifying speeds of bosses that are immune to changes of speeds.
Scripts/VioletHold: picked some things from pull request #11399 (thx MitchedD for initial work)
Core/Unit: Fix snare/daze immunities versus SPELL_AURA_USE_NORMAL_MOVEMENT_SPEED.
Fix file name
DB/Misc: Various fixes* Quest rewards for Kael'thas and the Verdant Sphere - Closes #14452
* Quest rewards for The Cipher of Damnation - Closes #14879
* VOA Meeting stone - Closes #10502
* Fix a db error
Dep/libmpq: Update libmpq to https://github.com/mbroemme/libmpq/commit/d59b4cf1d107b5f6a0f67d6bc545c6c6ebef3d74Update libmpq to https://github.com/mbroemme/libmpq/commit/d59b4cf1d107b5f6a0f67d6bc545c6c6ebef3d74 and add some custom change to fix additional build warnings, diff is included.

Extracting dbcs, maps, vmaps and mmaps is not required.

DB/Path: Silver Covenant Horseman in Crystalsong Forest/Windrunner's Overlook
Core/Texts: Fix race conditions in CreatureTextMgr repeat groupFix race conditions in CreatureTextMgr repeat group happening with MapThreads > 1 reported by helgrind by moving Creature-GUID-base data from CreatureTextMgr to Creature.
Issues added in bbf86641a1c35fcc66de30d7a79175c31effde88

Update contributors list (THANKS file) * See https://gist.github.com/Naios/25810829e66b7ddd8b82 for the full procedure & sources. * Most names were taken from commits (3.3.5 & 6.x branch) * Also contributors who were mentioned in commits were included (@, thx, thanks, Author:, author(cherry picked from commit 5b64df1a26d8b521282ffa41a17ad49a2e99558c)

Sorted contributors list of THANKS file and converted to utf-8(cherry picked from commit dc403149ebe4151330a5bd5974fe9952c4f9f37e)

DB: Fix date for file
DB/Path: Sunreaver Hawkrider in Crystalsong Forest
DB/Misc: Megzeg NukklebustBy @tkrokli

Closes #14863
Merge pull request #14838 from Rushor/stopScripts/SmartScripts: Clear Movement on Death
Scripts/TheEye: Clean up instance script
Core/Auth: Fixed authserver not shutting down correctly when started as windows service
Core/Misc: Update helgrind suppressions
Core/Misc: Disable G3D buffer pools if jemalloc is enabled
DB/Text: Fix wrong broadcast text id
DB/Creature: Demon trainersBy Killyana, closes #12559
DB/Quest: Rivenwood CaptivesBy Killyana, closes #3648
DB/Quest: The New HordeBy Killyana, closes #14814
DB/Creature: Thrallmar gruntBy Killyana, closes #14844
DB/npc_text: Add missing Broadcast_textBy Killyana, closes #14810
DB/Creature_text: Add missing Broadcast_textBy Killyana, closes #14808
DB/Quest: Reclusive Rune MasterBy Killyana, closes #14829
DB/Quest: Finish Me!By Killyana, closes #6814
DB/Creature: Delete 2 duplicate spawned mobsBy Killyana, closes #14834
DB/Quest: On Spirit WingsBy Killyana, closes #5057
DB/Misc: Delete few incorrectly spawned creaturesBy Killyana, closes #12564
DB/Creature: Deeprun DiverBy Killyana, closes #12432
DB/Creature: William and DonnaBy Killyana, updates #14775
DB/Quest: Help TavaraBy Killyana closes #2744
Core/Auth: Implemented starting authserver as a windows service
DB/Spell: Mark of the Fallen Champion - Heal - Targetconditions* closes #12308

DB/Quest: Test at Sea* thanks for the spell_custom coresupport from @pete318
* closes #11880

Core/Spells: Support for targetting spells onto in flight units * This adds support to spell_custom_attr to allow a spell to be cast upon a unit on a taxi/in flight. * This will allow the Issue #11880 with Horde quest Test At Sea (11170) to be corrected. * closes #14235Signed-off-by: Naios <naios-dev@live.de>

Core/Player: Don't allow to join bg/lfg when frozen by a GM
DB/Misc: Updates/Bug fixes to my recent commits1) Also add heroic difficulty spells for Negaton Screamer and assign existing to normal mode only
2) Re-do Slip'kiks waypoints (yes originally used wrong wp from sniff or position instead of points as wp format was different
3) Add Fengus's WP I missed these originally as did not look right but reason why not right was same as above
4) Remove SAI to add buffs to players on death of bosses this is from original script and is incorrect as buff must be cast from gossip as I already scripted
5) Fix the faction/quest issue with Captain Kromcrush
6) Cho'Rush the Observer can once again be killed that line to add invincibility hp was not meant to be in final.
Scripts/Auchindoun: Fix distance check in boss ShirrakIssue added in 88137c07b932ab5199c79a1d4f9d6246dac21e9e

Core/Shared: Hide the internal shared_ptr of the TaskContext * use . operator instead of -> to access the TaskContext now. * Add TaskContext::IsExpired to check whether the owner has expired.
DB/Creature: Howling Fjord - Movement - Whisper Gulch
Scripts/SmartScripts: Clear Movement on Death
Core/Matchmaking: Fix Discard Time overflow on server startDescription:

When server starts and RatingDiscardTimer config is set to some value, discardTime being unsigned int overflows for the time of RatingDiscardTimer value and causing all rated arena matches ignore matchmaking rating for that time.

DB/Creature: Negaton ScreamerScript http://www.wowhead.com/npc=20875/negaton-screamer
Core/Creature Fix compiler warning
Core/Player: Fix resurrection exploitFix an exploit that allowed to resurrect even if corpse was not in range (teleport hack was required too)

Merge pull request #14811 from tkrokli/Knockback_flying_mountCore/Movement: Knockback Effect on Flying Mount
Merge pull request #14780 from mik1893/immune_to_npc_flagCore/Creature: UNIT_FLAG_IMMUNE_TO_NPC check only vs non-player targets
Core/Movement: Knockback Effect on Flying Mountby @robinsch; closes #6099

Keep the mounted player flying after the knockback effect cast on mounted player.

Before these changes, the flying mount behaves like a ground mount after the knockback.
From large enough heights, the fall causes damage or death to the falling (mounted) character.

DB/Creature: Reinsert wrongly deleted Creatures
Core/CrashHandler: Make crashhandler tread-safeHandle only 1 exception in the whole process lifetime and create only 1 crash report.

Core/Auras: Fixed SPELLMOD_DOT not being appliedCloses #14817

Signed-off-by: Shauren <shauren.trinity@gmail.com>

Core/GOs: Correct type of lowGuid when loading gameobject_addonsCoverity IDs: 1302436 1302437 1302438

Issue introduced in 95b5e357451985fbc350bf1321ce96d6c02f9d44

Core/Scripts: Corrected argument types in GetCreatureEntry/GetGameObjectEntry ZoneScript hooks(cherry picked from commit b0c4268a6b0ed1fffeb51c7542c7991399b18284)

Conflicts:
src/server/game/Entities/GameObject/GameObject.cpp

Core/Misc: Removed some old unused enums(cherry picked from commit 2f0c293266837eca217d2bff1df8b78ac6e12867)

Merge pull request #14782 from doctaweeks/fixes-for-6.xMinor fixes for 6.x
(cherry picked from commit 0cf02097414ddf7a370bd2efef5b892616e8de93)

Conflicts:
src/server/bnetserver/Main.cpp
src/server/game/Battlegrounds/Zones/BattlegroundBFG.h
src/server/game/Battlegrounds/Zones/BattlegroundTP.h
src/server/game/Chat/Channels/Channel.h
src/server/game/Entities/Player/Player.h
src/server/game/Quests/QuestDef.h
src/server/scripts/OutdoorPvP/OutdoorPvPNA.h
src/server/shared/Cryptography/SHA256.h

Buildsystem: Removed handling for -DPREFIX shortcut for -DCMAKE_INSTALL_PREFIX cmake option, it an internal cmake variable since version 3.2(cherry picked from commit 1987d3187d1f14cf6dfcaf4f63861db806ad06cc)

Update worldserver.conf.distFix typo in ClientCacheVersion
(cherry picked from commit fc85f0e30fed383515f3d519dcef2cb87e3ee854)

DB/Creature: Winterskorn Hunter - Add 2 Missing Spawns
DB/Creature: Howling Fjord - Movement - Bealgun + Agamand - Part VI
Shared/Util: Introduce a task scheduler which schedules task with c++11 techniques. * Use std::function as callback (methods, lamdas & std::bind). * Uses std::chrono::duration as duration type (Milliseconds, Seconds...) - With c++11 user defined literals we could just write "11s" for example (MSVS 2015, gcc & clang). * Provides a lot of overloads for easier usage: - Static durations or random durations between min and max. - Named (with group ids - group id 0 is possible) or anonymous tasks. - Asynchronous tasks. * Is adapted to the current needs of scripting: - Repeat tasks through the TaskContext - Schedule new tasks from the context. - Provides access to the times repeat counter of a task, this will help to schedule multi step events (dialogs for example).See https://gist.github.com/Naios/6d143538abdc3d32fd2b for usage examples.

DB/Creature: Howling Fjord - Movement - Niffelvar - Part V
DB/Creature: Howling Fjord - Movement - Ivalds Ruin - Part IV
DB/Creature: Howling Fjord - Movement - Giants Run - Part III
DB/Creature: Howling Fjord - Movement - Dereleict Strand - Part II
Core/Misc: Fix build warningFix build warning

Core/Misc: Fix issues reported by static analysisCoverity defect IDs: 1023115

Core/Misc: Fix issues reported by static analysisCoverity defect IDs: 1022861, 1022862, 1022863, 1302435, 1302439, 1302440

DB/Creature: Remy "Two Times"By Killyana, closes #12616
DB/Misc: Add a ton of BroadcastTextIDsBy Killyana, closes #14793
DB/Misc: Add a ton of missing gossipsBy Killyana, updates #14793
DB/Quest: Kroshius' Infernal Core - Endevent* Death by chicken!

Core/Spell Add Spell Script Needed for quest Torch Tossing/More Torch TossingUpdated

Rename 2015_08_03_world.sql to 2015_05_29_01_world.sql
Merge pull request #14753 from Rushor/IhaveadreamDB/Quest: No Mere Dream
DB/Quest: No Mere Dreamcloses #11252

Core/Spells: Fix DK Death rune selection
DB/Misc: Fix a runtime error
DB/Creature: Howling Fjord - Movement - Part I
DB/Creature: UP - Add all Rndmemotes
Engrish to english CONTRIBUTING.mdBy thumsoul
and clarify some things.
Core/Updater: Fix issues when connecting through unix sockets.* closes #14766
* closes #14759

Signed-off-by: Naios <naios-dev@live.de>

Core/Creature: Remove not needed flag for UNIT_FLAG_IMMUNE_TO_NPC closes 14744
DB/Misc: Dire Maul Tribute stuffstill needs core support for instance script so boss states can be checked.

* Script Mizzle the Crafty / Cho'Rush the Observer
* Add missing texts and gossips to more npcs
* Script Guard Mol'Dar, Guard Fengus and Guard Slipkik to give there buffs to a player has king of the gordoc buff
* Script Captain Kromcrush event to allow skipping with Gordoc Ogre Suit (WP not complete)
Merge pull request #14777 from tkrokli/putricide_ooze_eruption[3.3.5a][ICC/Professor Putricide] Volatile Ooze Eruption fix
DB/Misc: Guard Slip'kik & Broken TrapScript event for when quest A Broken Trap is turned in to allow by passing of Guard Slip kik without having to kill him,

Does not fix issue but is required by https://github.com/TrinityCore/TrinityCore/issues/6429
DB/Quest: Midsummer Fire FestivalBy sirikfoll, closes #1517
[3.3.5a][ICC/Professor Putricide] Volatile Ooze Eruption fixby @ManuFe and @Rushor; closes #12336

In the existing source, the rooting aura is removed after the explosion,
therefore the knockback effect does not work because the player is still rooted.
By swapping these 2 lines, the aura is removed, then the explosion happens.

Result: rooting is removed before the knockback effect is cast on the player.

DB/Creature: Add Stranglethorn SAIscloses #12570

Rename 2015_MM_DD_NN_world.sql to 2015_05_26_05_world.sql
Merge pull request #14613 from ariel-/shathallsFixed some issues with PR #14157
DB/Quest: Protecting our Own (horde)By Killyana, closes #10184
DB/Item: Rumsey's alcoholsBy Killyana, closes #13036
DB/Misc: Hex of Jammal'anBy Killyana, closes #12705
DB/Creature: Kodo Calf + Kodo MatriarchBy Killyana, closes #12547
DB/Creature: Remy "Two Times"By Killyana, closes #12616
Core/SpellHistory: Fix school lockout not being sent to clientCloses #14762

DB/Creature: Forsaken Crossbowman* Enable Shootvisual in all phases

DB/Creature: Complete UP Movement
DB/Creature: Dragonflayer Fanatic* Add Emotescript for Dragonflayer in the Startroom of UP

DB/Quest: Escape from the Staging Groundscloses #3724

DB/Creature: Scarlet Houndby @Killyana
closes #14743

DB/Creature: Finish Grizzlyhills Movement
DB/Creature: Grizzly Hills Giant - Visual* Add Stonevisual which will be thrown periodically towards to Dummies

Core/Movement: Fix a typo in FlightPathMovementGenerator::InitEndGridInfo()Added in 916ce6f4f348f789e85df57000b94672afe692c1
Thanks @Rochet2 for finding it

DB/Creature: The Farstrider Lodge - Flavor textscloses

Merge pull request #14748 from Rushor/druidScripts/Spells: Curing the Sick - Add Questcredit
Scripts/Spells: Curing the Sick - Add Questcreditcloses #14688

DB/Quest: Ammo for Rumbleshot* one remaining problem: the shootanimation of the cannon, tempfix will be http://pastebin.com/ZbwUg41v
* closes #12582

DB/Creature: Gnomeregan Scriptscloses #12697

Core/CrashHandler: Log STACK_OVERFLOW crashesTry to log STACK_OVERFLOW crashes by allocating log buffer on the heap which should still be in a valid state with a stack overflow exception.
This will probably still not produce a complete crash report with details about all stackframes.

Fix non pch build.I'm thinking about creating an bash alias for this message...

DB/Creature: Marshal DughanBy Killyana, closes #12615
DB/Creature: Mountaineer StormpikeBy Killyana, closes #12711
DB/Creature: Gnome EngineerBy Killyana, closes #12619
DB/Creature: Sten StoutarmBy Killyana, closes #12541
DB/Quest: The Echo of YmironBy Killyana, closes #6843
DB/Quest: The test of Righteousness/Whitestone oak lumberBy Killyana, closes #12377
DB/Creature: Nestlewood OwlkinBy Killyana, closes #12507
DB/Creature: Surveyor CandressBy Killyana, closes #12528
DB/Creature: Overlord RunthakBy Killyana, closes #12257
DB/Creature: Nancy and Grandpa VishasBy Killyana, closes #12263
DB/Misc: Event mount of dirtBy Killyana, closes #12288
DB/Creature: StinglasherBy Killyana, closes #12296
DB/Creature: Sah'rheeBy Killyana, closes #12316
DB/Creature: Groundbound Soaring RazorbeaksBy Killyana, closes #12326
DB/Creature: Syndicate WatchmanBy Killyana, closes #12262
DB/Creature: Naga SirenBy Killyana, closes #12429
DB/Creature: NessyBy Killyana, closes #12431
DB/Creature: Witch Doctor Zum'rahBy Killyana, closes #12335
DB/Creature: ZixilBy Killyana, closes #12479
Merge pull request #14735 from Rushor/InsightGame/Spells: Spellmgr - Insight - Add ProcCharges
Merge pull request #14741 from Rushor/ForceGame/Spell: Spellmgr - Force Cast - Fix Typo
Game/Spell: Spellmgr - Force Cast - Fix Typo* introduced in https://github.com/TrinityCore/TrinityCore/commit/9d12df69ca77a6c5522a0803d6aa5b8328575a13#diff-f82ab5d79483dd6e1f5bd8c4d94299d3R2958

Game/Spells: Spellmgr - Insight - Add ProcChargescloses #14734

DB/Quest: Hellscream's Championcloses #9061

DB/Quest: The Earthbindercloses #14690

Core/BG/SOA: fixed interaction with flags and titan relicCloses #13091

DB/Misc: Fix startup errorsBy Killyana, updates #13707
Scripts/Icecrown Citadel: Fixed Ice Tomb during phase 3 of Sindragosa encounter(cherry picked from commit f85605b5f78f73c53a56874161155416b64ec078)

DB/Creature: Misc SAI aditionsBy Killyana, closes #12236
DB/Creature: Defenders at Bloodmyst IsleBy Killyana, closes #11243
Scripts/Commands: Fix LANG_PINFO_MUTED in HandlePInfoCommandCloses #14560
Thanks @Mack36

(cherry picked from commit 6d12297ffa4ce33db5513937852d151917085d23)

DB/Quest: add prerequisites to some quests.By Killyana, closes #11450
DB/Creature: add gossips to ShenthulBy Killyana, closes #11498
DB/NPC: Fix and add gossip stuff to avoid learning spells from different classs trainersBy Killyana, closes #14716
DB/Quest: Troll Patrol: Done to DeathBy Killyana, closes #14708
DB/Creature: Creeping SludgesBy Killyana, closes #11688
DB/Creature: Curgle CranklehopBy Killyana, closes #12249
DB/Creature: Elemental SlaveBy Killyana, closes #11742
DB/Quest: The Valiant's ChallengeBy Killyana, closes #8718
Core/Spells: fixed creatures stucks at 1 hp when a health increasing aura gets removedCloses #13639

Removed useless calculation in last commit
Fixed a math error in SmartScript:ecPhase(int32)
Core/Spells: Fix summon position of Argent ValiantRef #8718

Scripts/Icecrown: Move Squire David to SmartAI
Core/Misc: Removed gcc specific packing pragma syntax - only unsupported (now) versions required it(cherry picked from commit 4c7c2abf03b692e67a89d2ba0856aec1553c8ae1)

Conflicts:
src/server/bnetserver/Packets/BitStream.h
src/server/shared/Common.h

Core/Misc: Moved Position to its own file(cherry picked from commit 48ee1f003347910a48183f768501c1080fc40269)

Conflicts:
src/server/game/Entities/Object/Object.cpp
src/server/game/Entities/Object/Object.h
src/server/game/Spells/Spell.cpp

Restore C++ as main project language(cherry picked from commit 48a1358f5067ef564f51e86cf52140b2cd8620b1)

Merge pull request #14674 from jaredjones/patch-1CMake OS X: Fixed Debug Mode for Xcode
(cherry picked from commit b96e70af71a1cc87a33a79c71618697cd8f7ca9f)

Merge pull request #14454 from ariel-/cdPort Core/Spells: Cooldown updates (6.x branch)
Core/GameObjects: fixed build in gcc(cherry picked from commit c5bbc9287d1e8ae9335598780ebd7db47b522fb2)

Fix build after recent cherry-picks- Rename fields in TaxiPathNodeEntry to match 6.x names
- Add LowType to ObjectGuid

Core/GameObjects: Implemented gameobject_addon table, you can now set invisibility for gameobjects for quests(cherry picked from commit 9d59d038f8b09ed036448e755cb0b102396a4ca1)

Conflicts:
sql/updates/world/2015_04_05_07_world.sql
src/server/game/Globals/ObjectMgr.cpp
src/server/game/Globals/ObjectMgr.h

Core/GameObjects: fixed typo and logic (0 is a valid invisibility type)

(cherry picked from commit 23e8a3ce2928458649d94408d5deffb67339b1d6)

Core/Transports: Moved teleporting transports to Map:elayedUpdate(cherry picked from commit 5c5cb3e555da279b45ccff19b5ab4fc2656c75e2)

Core/Networking: Fixed possible msvc debug assertions in vector(cherry picked from commit e4abbc09266d5878d0a03b04f3d72ea68549997f)

DB/Misc: Fix startup errorBy Killyana, updates #13707
Scripts/Commands: Change few commands to target current Player by default
Scripts/ToC: Fix doors opening/closing during Dreadscale fightFix doors opening/closing during Dreadscale fight by sending a CloseDoor command instead of toggling the door state when Dreadscale resets its movement.
Note that bounding the door state to boss movement makes poor sense and should be changed. Other bosses in ToC have this logic and should be updated if they show the same bug.

DB/Misc: Fix a runtime error
DB/Quest: Teron Gorefiend, I am...Closes #14643

* In order to see Karsius the Ancient watcher player must have spectrecles T2 equipped (these can be equipped after quest event started but must be equipped to be able to see him
* In event of fail Karsius and/or Teron Gorefiend will despawn, in this case player needs to abandon and retake quest.
Core/NetworkIO: Adjust more packet throttling valuesAdjust more packet throttling values by increasing some limits, this might fix some random kicks.
Close #14659

DB/Creature: Grizzlyhills - Movement Part 2
Scripts/Ulduar: Fix a comple of issues with Flame Leviathan's towers* Fix tower count being set to 0 once the first tower is destroyed due to bad logic
* Prevent towers from reducing counter twice (caused by event being sent twice by the gameobject when destroyed)

DB/Creature: Grizzlyhills Pathing/Events - Part 1* some emotes for envolved creatures
* Pathing
* Drak'Tharon-Entrance-Event

DB/Misc: Dire Maul Cosmetic StuffFix Dire Maul North Door, issue was caused by flag 1 (in use) flag or a bad flag, also adding flag 2 as this door is meant to need key to open and with just flags 32 door can be opened without key
Fix faction of last 2 pylons so they dont appear to be clickable or display tooltip to player

Closes #14684
Makes all pylons non clickable as last 2 (by immo'thar) had bad faction resulting in these appearing to be clickable and showing tooltip to player.
DB/Creature: Conquest Hold Legionnaire - Movement
DB/SAI: Pit-Fighting Spectator - Emotes
DB/Object: Mysterious Deadmines Chest/Mysterious Wailing Caverns ChestBy @Killyana
Closes #14644
DB/Quest: Get Me Out of Here!* closes #4918
* thanks 2 @Trista 4 report

DB/Gameobject: Razormaw Matriarch's Nest* closes #7424
* thanks 2 @nelegalno 4 report + provided datas

DB/Quest: Assault by Air (A/H)* closes #6180
* thanks 2 @Miroslav1993 4 report

DB/Creature: Refurbished Steam Tank* closes #11024
* thanks 2 @MrSmite 4 report

DB/Creature: Okla + Kranal* apply Movement & Talksequences
* by UDB-Team + Killyana
* closes #12447

DB/Misc: Fix startup errorsBy Killyana, updates #13707
Rename 2015_05_09_00_world.sql to 2015_05_09_12_world.sql
Merge pull request #14664 from tkrokli/Exorcism_of_Colonel_Jules[Core/DB] Quest: The Exorcism of Colonel Jules
DB/Quest: Among the ChampionsBy Killyana, closes #3844
DB/Creature: Priestess TyrionaBy Killyana, closes #10457
DB/Creature: Voidwalker MinionBy Killyana, closes #10369
DB/Quest: In Strict ConfidenceBy Killyana, closes #10231
DB/Quest: Divination: Gorefiend's TruncheonBy Killyana, closes #8899
DB/Quest: Engineering a DisasterBy Killyana, closes #11004
DB/Misc: The Grand MeleeBy Killyana, closes #14603
DB/Misc: Remove Midsummer Double SpawnsBy sirikfoll, closes #14623
DB/Misc: Fix startup errorsBy Killyana, updates #13707
DB/Creature: Fix InhabitType for Sapphire Hive WaspBy Killyana, closes #14656
DB/Gameobject: Add missing Mysterious Wailing Caverns Chest templateBy Killyana updates #14644
DB/Creature: Fix Watch Commander Zalaphil equipmentBy Killyana, closes #14636
Fixed some issues with PR #14157, kudos to @Nyeriah @Warpten:* Moved scripts to other source file instead of having them on the instance cpp
* Removed magic number, use of DoAction instead of SetData to do the yelling
* Added spellscript for Remove Kargath's Executioner
* Saved victim GUIDs in instance script instead of checking nearby area
* Returning position as const-reference (by Naios)

[Core/DB] Quest: The Exorcism of Colonel Julesby @danlapps; closes #1524

Thanks to WoW-Studio@0aa81ca for doing most of the work
Thank to @Killyana for SQL walkthrough
Thanks to @Rushor for doing most of the converting work,
Thanks to @Nyeriah for pointers to solutions for all the errors
Thanks to @MitchesD for pointing out missing codestyle and errors
Thanks to @ccrs for supplying the ObjectAccessor lines
Thanks to @DDuarte for making me understand the changes

Merge pull request #14641 from tkrokli/Fix_cast_on_fear_while_rootedCore/Spells: Fix being able to cast while feared and rooted at same time

Disallow to cast if feared and rooted at same time
Scripts/Eye of Eternity: Provide players with drakes when entering instance after Malygos' demise
DB/Misc: Minimum Level requirement for Runescroll of Fortitudehttp://www.wowhead.com/item=49632/runescroll-of-fortitude#comments unlike Prayer of Fortitude this item does not scale down on lower level players and does not work on players under level 70.

Previously on TC this item could be used by a level 80 player to buff level 19 twinks while in party which should not be possible as players under level 70 should not receive buff.
Scripts/VioletHold: Fix crashFix crash in Violet Hold happening when crystals were activated without killing trash mobs.
Crash added in cba6515acb5820af5df6b77855464c29062b8c44 and f4531c5a582cae24d4d136035074d8da7e5bdad7 .
Closes #14629

fix typo
Fix: Can cast on fear if rooted [3.3.5a]by @Xiledria; closes #13964

Removes the ability to cast while in fear and rooted.
Tested and found working by @Raydor and @Xiledria

DB/Quest: Exorcising the TreesBy @Killyana
Closes #6327
DB/Misc: Extra-Dimensional Ghost RevealerBy @Killyana
Closes #3052
Core/SAI: SMART_ACTION_SET_COUNTER now can be used for all targets, not just for self(cherry picked from commit feabc6dff18cfcd00647e885133d066fcbab0724)

DB/Quest: The Heart of the MountainBy @Killyana
Closes #6914
DB/Text: Corki's Gone Missing Again!By @ Killyana
Closes #6281
DB/Conditions: Sealed ChestBy @Killyana
Closes #14113
DB/Misc: Orgrim's Hammer and The Skybreaker marker npcsBy @Killyana
Fixes part #6186
Core/Misc: Fix issues reported by static analysis Coverity defect IDs: 1296295, 1296294
DB/Misc: Apexis Emanation area requirementBy @Killyana
Closes #7764
DB/Conditions: SAI (Infinite Hunter)By @Killyana
Closes #7900
DB/Misc: Razormane HunterBy @Killyana
Closes #8003
DB/Creature: Shadowpine CatlordBy @Killyana
Closes #8002
Delete 2015_05_01_01_world.sql
DB/Creature: Shadowpine CatlordAdds SAI to summon Pet
By @Killyana
Closes #8002
DB/Quest: Chug and Chuck!By @sirikfoll
Closes #3130
DB/Quest: Fix bad required raceshttp://www.wowhead.com/quest=915/you-scream-i-scream is horde quest but required races where set to 255 which made it so Bloodelf characters could not take this quest and thus could not complete Ogrimmar childrens week chain.

255 was the below even though this is horde only quest.

1 | 1 Human
2 | 2 Orc
4 | 3 Dwarf
8 | 4 Night Elf
16 | 5 Undead
32 | 6 Tauren
64 | 7 Gnome
128 | 8 Troll
Core/Spells: Fix typo
Core: Fix build
DB/Misc: Fix startup errorsUpdates #13707
Core/Socket: Removed unused synchronous read method(cherry picked from commit 59e9bcf0bf44d89397f5a182e2ef21f7e3a3635d)

Conflicts:
src/server/game/Server/WorldSocket.cpp

Core/GameObjects: Removed the possibility to spawn transports wih gm commands (such objects did not have any transport mechanics but could still cause crashes)Closes #14542

(cherry picked from commit 149ff8da879a8286a01081d4ffb1f200a67ddefd)

Conflicts:
src/server/game/Entities/GameObject/GameObject.cpp
src/server/game/Entities/GameObject/GameObject.h
src/server/game/Globals/ObjectMgr.cpp

DB/Gossip: Orchish OrphanAs with shattrath one alliance (human orphan) already has gossip was just missing from orchish one.
DB/Gossip: Bloodelf OrphanAdd gossip menu and set for Bloodelf Orphan, Dreanei Orphan already has it was just the gossip for horde npc which was missing
DB/Misc: Quest rewards for Northrend Children's Week chainQuest rewards for http://www.wowhead.com/quest=13959/back-to-the-orphanage and http://www.wowhead.com/quest=13960/back-to-the-orphanage

Mail will be delivered 15 mins after quest turned in containing the reward (pet) for which ever chain you completed

http://postimg.org/image/ukyloata3/
http://postimg.org/image/fdim3y1ff/
DB/Gossip: Wolver/Oracle OprhanAdd gossip menu to Wolver and Oracle Orphan, gossip was already in db just not assigned.
Update .travis.yml
DB/Quest: Counterattack! Script improvements* Correct gossip menu for http://www.wowhead.com/npc=3389/regthar-deathgate instead of gossip menu which actually belonged to http://www.wowhead.com/npc=18715/private-weeks
* Event will now reset after 5 mins or when quest returned rather than only working once per server restart
* Event will now start either on quest accept or on select of gossip option if player has quest taken
Core/Script: Make 2 remaining bridge parts active in Serpent Shrine
DB/Gameobject: Serpentshrine CavernMissing GO spawns from Serpentshrine Cavern

Including the objects for Vjash's bridge, @Kittnz will push fix to cpp script to make this work properly as even though this was already scripted (but no gos, there was still slight issue with existing cpp script (ie activating same part of bridge 3 times instead of all 3 parts.
Core/Corpses: Fixed corpses loaded from database not being visible after server restart
Buildsystem: Updated FindBoost macro, now finds versions 1.57 and 1.58 as well(cherry picked from commit 5acc4b14aa81a5e9a946d11cfa9034d334ea7144)

Conflicts:
cmake/macros/FindBoost.cmake

Signed-off-by: Naios <naios-dev@live.de>

Spell logging corrections
DB/Quest: What Do You Feed a Yeti, Anyway?By Killyana, closes #7019
DB/Creature: Eranikus the ChainedBy Kilyana, closes #3756
DB/Creature: Thomas YanceBy Killyana, closes #3905
DB/Item: Dragon's CallBy Killyana, closes #4522
DB/Spell: Shadow Sight must be debuffBy Killyana, closes #4532
DB/Creature: EcheyakeeBy Killyana, closes #5143
DB/Creature: MangletoothBy Killyana, closes #5144
DB/Item: Halaa bombsBy Killyana, closes #6649
DB/Creature: Fix Kalecgos eventBy sirikfoll, closes #11276
DB/Quest: The Black Knight's OrdersBy Kilyana.
Scripts: trying to fix non-pch
Scripts/Uldaman: Fix build & fix some movement suggested by josch
Scripts/Uldaman: Instance update- Fixup Boss Ironaya
- Add the freeze animation for minions and archaedas
- Fix attack target for minions who wake up

Scripts: finally (I hope) fixed nonpch build, damn you @ariel-
Scripts: non-pch fix again
Scripts: fixed non-pch build
Rename 2015_MM_DD_NN_world.sql to 2015_04_24_00_world.sql
Merge pull request #14157 from ariel-/shathallsShattered Halls: Revamped instance script
Core/Log: Fix newlines when using dynamic log names * thanks @Aokromes for reporting * also removes an unnecessary std::move
Core/Misc: Ported relevant barbershop fixes from 4208c0d8396e10dc806939e1d17885d16ff7b84e
Scripts/HallsOfStone: Set the Tribunal of Ages encounter state to IN_PROGRESS once it starts, instead of when Brann's escort starts
Scripts/HallsOfStone: Brann Spankin' New achievement should only fail if damage is taken during event
DB/Quest: The Plume of Alystros* Event script for when quest item used
* Update SAI on Alystros the Verdant Keeper so becomes attackable, sets emote state, plays sound and attacks
* Move spellfocus so that is not on the top of the rock with Alystros so only players with fly mount could even get up there to try and use quest item, have moved to the bit of land closest to the rock as spellfocus object positions cant be sniffed
Fix build.
Core/LFG: Move code to a better place.(the case where the last player left inside a dungeon would not be removed from lfg&group when he ports outside)

Core/LFG: Fix crash in ".lfg group <playername>" in case of offline player andextend the output to display the offline members of the group also.Atm if members are offline no info is displayed.

Note: all the new code is mostly copy/paste from ".group list <playername>" command.

DB/Misc: Fix conditions delete error on 210e45e303bBy Killyana
Core/CMake: Fix line endings
DB/Path: Added group Highland Mustang pathing
Rename 2015_04_19_01_world.sql to 2015_04_19_01_world.sql
Core/Misc: Fix issues reported by static analysisCoverity defect IDs: 1023036, 1022620

DB/Quest: Vision Guide (Credit)Give quest credit via spell instead of using areaexploredoreventhappens
Core/Creatures: remove virtual mounts from creatures on deathCloses https://github.com/TrinityCore/TrinityCore/pull/14396

(cherry picked from commit b5393d4b9b5428279e245cabbf35041fb4a8c70a)

Core/Unit: fixed removing UNIT_FLAG_PET_IN_COMBAT from guardians Closes https://github.com/TrinityCore/TrinityCore/issues/14566(cherry picked from commit 8096edec15dc2c51d2c9f57b618cd0ced569f793)

DB/Misc: Fix startup errorsBy Killyana, updates #13707
Tidy up whitespace
DB/Misc: Change guids from previous commit
DB/Achievement: Zombiefest!* Spawn all http://www.wowhead.com/npc=27737/risen-zombie from sniff (also spawning the missing http://www.wowhead.com/npc=27731/acolyte)
* Script http://www.wowhead.com/npc=27737/risen-zombie in 1st half of instance (each guid individual so it does not effect zombies in second half: -

1) Zombies become visible to player once Arthas is started or exactly at the time the first wave spawns
2) Zombies in first half will then respawn until http://www.wowhead.com/npc=26530/salramm-the-fleshcrafter after which they will stop respawning (achieved by becoming invisible + immune at respawn) this does not effect zombies in 2nd half of instance
Scripts/CoS: Chrono Lord Epoch converted to BossAI(cherry picked from commit d74e0d823d96df02822005e7165139b2bf1709de)

Core/Misc: Fix issues reported by static analysisProperly fix Coverity defect ID 1227434

DB/Misc: Delete duplicated gameobjectRemove an alliance bonfire from Silithus

There were 3 of gameobject http://www.wowhead.com/object=187943/alliance-bonfire stacked on top of each other in Silithus the other 2 guids for this object 50679 and 50680 the removed one is the only one which was not added in game_event_gameobject resulting in this object been visible and quest offered even though midsummer is not running
Core/Condition: Add In Water ConditionUpdates #7019

DB/Quest: The Horse HollorerFix http://www.wowhead.com/quest=12415/the-horse-hollerer again after script for this quest was removed when http://www.wowhead.com/quest=12414/mounting-up was fixed in https://github.com/TrinityCore/TrinityCore/commit/2c6500a2319abef5cf46dbe227143c9df476aadf this commit removed script for this quest which had previously been fixed prior to this commit.
DB/Creature: Loaned Wind RiderBy Kilyana, updates #4484
DB/Item: Fix Bobbing appleBy Kilyana, closes #11142
DB/Item: Fix Nevermelting Ice CrystalBy Kilyana, closes #10026
DB/Misc: Fix Storm Peaks minefieldBy Killyana, closes #965
DB/Creature: Script Time KeeperBy Killyana, closes #2465
DB/Quest: Fix multiples spawn for A Taste of FlameBy Killyana, closes #2752
DB/Creature: Some npcs don't respond to aggro if player is in waterBy Killyana, closes #5405
Core/LFGMgr: One more addition to fix the crash on logout.
Add missing newline(cherry picked from commit f48b86fd8ad734855744e766109a543208fce454)

Use std::sqrt(cherry picked from commit 9c197e82a3b6742a7d2b521efe9cd9232e9ab8f1)

Fix indentation in unix cmake settings(cherry picked from commit 71ba35a6cd4446d7f2a39c7eb41fa17aac4e6c5c)

Remove unnecessary semicolons(cherry picked from commit 27923b8d8fc10b46f86a2419cf27e9c9f1a96be8)

Fix documentation(cherry picked from commit 62ff887236ad835f1353c415ae6baca6ac6b94b8)

Prevent collisions in GCC attribute definitions(cherry picked from commit 64848856002a796e30b822d70a31087495084bfa)

Scripts: Shattered Halls: Revamped instance script, support for quests 10884, 9524, 9525
DB/Spells: Blood elf paladin's mount visual
Core/LFGMgr: Attempt to leave LFG the right way...i think...
Port commit 56186319bdd41dd26b6cc14f84e6e41eef5d953b (6.x branch)Core/Spells: Cooldown updates

Updates #14418

Merge pull request #14540 from tkrokli/npc_mootoo_the_youngerFix $n bug in NPC text for quest 11664 Escaping the Mist
Fix $n bug in NPC text for quest 11664 Escaping the MistMake quest NPC target player character to say the actual name instead of $n

Idea by @DDuarte
Final solution found in similar escort quests.
(Example script: npc_kayra_longmane in zone_zangarmarsh.cpp)

DB/Waypoints: Pathing for Forsaken Courier and her guardsby @MrSmite
Closes #14500

DB/Waypoints: Pathing for Lieutenant Valorcall and his guardsby @MrSmite

DB/Faction: Correction to creature template for 11466 Highbourne Summoner (Shen'dralar)
Merge pull request #14536 from FireEmerald/patch-2Update README.md
Update README.md- Added Markdown Tables for better readability
Rename 2015_03_31_00_world.sql to 2015_04_11_03_world.sql
Merge pull request #14497 from tkrokli/Kodo_Roundup[Quest] Kodo Roundup
DB/Quest: Fixing War is Hell and Monitoring the Rift: Cleftcliff Anomalyby @Killyana

DB/Zone: Netherwing Ledge Part 4- Add Gug
- Add missing Dragonmaw Enforcer spawns and corrected positions
- Add and change in the mines, Mine Car, Murkblood Miner, Nethermine Flayer, Nethermine Ravager, Murkblood Overseer, Crazed Murkblood Miner, Crazed Murkblood Foreman.
- Add missing SAI for Crazed Murkblood Miner, Crazed Murkblood Foreman, Mine Car, Dragonmaw Foreman
- Add waypoints for Nethermine Burster, Nethermine Ravager, Mine Car

DB/Misc: Last Fix startup errors
DB/Misc: Fix startup errors
DB/NPC: Update guid for creatue spawn
Merge pull request #14530 from Exodius/bloodmaul_brutesCore/Scripts: Remove Bloodmaul Brutes script
Core/Scripts: Remove Bloodmaul Brutes scriptAs explained by @dr-j in 6b846a4e290097cde39f02a2f9a5be34cd06a65d
DB/Quest: Bladespire Kegger / Getting the Bladespire TankedWith previous cpp script when Bloodmaul Brutebane Keg used Bladespire Brute would run to keg and then nothing else would happen the ogre would remain standing on spot and not even be agressive (although could still be attacked.

CPP on http://www.wowhead.com/npc=21241/bloodmaul-brutebane-stout-trigger needs removing, ogre already had sai.
DB/Misc: L70 ETC ConcertBy Foldor, closes #14492
Core: Follow codingstyle guidelines (CamelCase for functions, lowerCamel for vars and local stuff)
Core: Whitespace/tab2spaces cleanup
Update LFGMgr.cppCore/LFGMgr: Fix crash in e743f4a479ce7ddd3f13d51ca1c19a591c803fc0
DB/Creature: Guard Untula
DB/Creature: Deathbound WardBy Nyeriah, closes #14482
DB/Creature: Warden of the ChamberBy Foldor, closes #14509

P.s. checked on 12340 sniff the coords, that's why i use VerifiedBuild 12340 instead 19831 of original fix.
DB/Quest: The Forgotten TaleBy Killyana, closes #14514
DB/Zone: Netherwing Ledge Part 3- Dragonmaw Tower Controller should yell MULVERICK! everytime when Dragonmaw Skybreaker flys over!

by Kilyana

DB/Misc: Fix startup errors
Core/Spells: Reinstate helperfunction removed in commit 0e3607df (with a new functionname to make more sense out of it), and adjust the remaining code slightly to accomodate that.
DB/Zone: Netherwing Ledge Part 2- Cleanup on the Dragonmaw Ascendant spawns
- Updated Dragonmaw Ascendant positions
- Added waypoints too Dragonmaw Ascendant

DB/NPC: Goblin Merc spawn and some adjustment on Dragonmaw Base Campby @Killyana

Closes #14453

Core/Spells: Allow non-skill-based flying mounts to be used in designated areas. - Flying mounts that are not in the "SKILL_MOUNT"-tree and area-restricted can now be used properly (ex. 64749 - Loaned Gryphon). - Remove isKnowHowFlyIn()-function (useless and deprecated since this is handled properly in the spellsystem). Massive thanks to rat for extremely good help and support on fixing this (most of this is his work).
DB/Gossip: Add some missing gossipsAdd missing Gossips from Diremaul North
Core/Command: Sanitize input for .account set gmlevel <username> handling
DB/Quest: Steamtank SurpriseBy @Killyana, Initial work by @Kirkhammett

Closes #1866
Merge pull request #14511 from Exodius/thunderspikeCore/Scripts: Remove The Thunderspike script
Core/Scripts: Remove The Thunderspike scriptAs explained by @Killyana in https://github.com/TrinityCore/TrinityCore/issues/4458#issuecomment-90061073
DB/Object: Nether Drake EggBy @Killyana

Closes #6284
DB/Quest: The ThunderspikeBy @Killyana

Closes #4458
DB/Misc: Silvermoon Guardians emote responsesBy @Nyeriah

Closes #14471
DB/Item: Brazie's Black Book of SecretsBy @Foldor

Closes #14502
DB/Zone: Shadowmoon Valley/ Netherwing Ledge- Add waypoints for Barash the Den Mother, Arvoar the Rapacious, 2x Dragonmaw Transporter.
- Reposition Ja'y Nosliw <Skybreaker General> and Taskmaster Varkule Dragonbreath
- Changed the movement speed for flying Dragonmaw Skybreakers

DB/Waypoint: Add several waypoints to Shadowmoon Village
Dep/CppFormat: Update cppformat to cppformat/cppformat@fd53bb6fb88a23e3 * fixes /W4 warning spamming.
Core/LFGMgr: Fix the case where the last player left in a lfg group would be stuck in party when porting out of the instance.If you find a better way or think this is wrong feel free to remove it or improve it.

Update 2015_04_05_06_world_335.sql
DB/Game event: Fix Noblegarden start date
DB/Creature: Anub'ar VenomancerScript Anub'ar Venomancer to use poison bolt

Even though wowhead lists two spells for these creatures (poison bolt & poison bolt volley) in sniff only appears to use poison bolt ie 0 casts of the volley spell.
DB/Quest: When Smokey Sings, I Get ViolentCloses #2621

The other spell effect must target scourge structure in order for the damage to player to work when using item.
Build fix for GCC 4.7 (cherry picked from commit e7deae947c94eab04370b5bdaab059ac425d697d)
Scripts/Kalimdor: Ashenvale - add missing enum
DB/Misc: Fix startup errors
Scripts/Kalimdor: Ashenvale - Remove Torek C++ Script
DB/Quest: Teron Gorefiend, I am...By gecko32, closes #3214
DB/Quest: Torek's AssaultCPP > SAI Conversation to overcome some problems

* Guards now follow Torek and will also attack enemy mobs
* Torek will now attack enemy npcs instead of walking straight past them

Closes #7299
DB/Misc: Old Hillsbrad Asbringer Event
Core/Misc: Warning fixes(cherry picked from commit cc4d79495f98006f77c68792b946a412f5e86714)

Partial cherry-picked.

Signed-off-by: Naios <naios-dev@live.de>

Switch abs to std::abs(cherry picked from commit 8476c2ac5a3cad03bc26b12fcc8b3f4f32854b65)

Add missing override keyword in scripts(cherry picked from commit b948a4275e90c59db2599a1961937d62f17736ce)

Conflicts:
src/server/scripts/Kalimdor/Firelands/boss_alysrazor.cpp
src/server/scripts/Kalimdor/zone_tanaris.cpp
src/server/scripts/Maelstrom/Stonecore/boss_slabhide.cpp
src/server/scripts/OutdoorPvP/OutdoorPvPZM.h
src/server/scripts/Spells/spell_mage.cpp
src/server/scripts/Spells/spell_paladin.cpp

Rename variables to fix C++11 keyword collision(cherry picked from commit 573cda7b524ee4d7d23cefd026b056181f451a8b)

Remove old ACE reference(cherry picked from commit 18acb9914a2ea8660b34bac13ea81b13a5ee9fe1)

Core/DBUpdater: Exit clean if a query failed to apply. * Fix some \W4 warnings about constructors.
Core/Log: Remove some unnecessary std::move's. * This are r-value references already. * Thanks @Shauren for noticing
Update README.md(cherry picked from commit a6247102fdaf94469981f299f504d20de0d72abe)

Merge pull request #13862 from ariel-/pr_tmpImplement CharSections.dbc and Serverside Checks.
Core/Networking: Fixed unsafe access to _worldSession member in WorldSocket(cherry picked from commit bed88e0dd475af5b73cea03821f7fb7cb9ddce9d)

Core/Networking: Fixed deadlock in HandlePing if the client is about to be kicked for overspeed pings

(cherry picked from commit 3da0f7e40920b652d2222fa88dbb4b516d24725d)

Core/Networking: Cleanup CloseSocket calls from read failures in WorldSocket

(cherry picked from commit 18343a7309fbf53a3509749c0a5ca1f8ea273c57)

Conflicts:
src/server/game/Server/WorldSocket.cpp

Ref #14474

DB/Creature: Valiance Keep Riflemancloses #14339

DB/Creature: Scarlet Crusade in DeathknellBy pete318, closes #14387
DB/Quest: Are we there, yeti?By Killyana, closes #10972
DB/Creature: Vhel'kur WaypointsBy danlapps, closes #13054
DB/Quest: Blightbeats be Damned!By Killyana, closes #10203
Core/Misc: Fix issues reported by static analysisCoverity defect IDs: 1227510, 1227434, 1023036, 1062426, 1062425, 1062424, 1062423, 1062422

DB/Misc: Dire MaulSpawn quiet a few missing gos in diremaul including the 5 pylons in Dire

Respawn www.wowhead.com/npc=11480/arcane-aberration and http://www.wowhead.com/npc=11483/mana-remnant as this where missing ie none spawned at all at 2 of the pylon.

Also respawning www.wowhead.com/npc=13160/carrion-swarmer
DB/Creature: Lil Timmyconvert by @Killyana, closes #10802

Core: Comment out unused parameter in DBCStructure.h (removes a warning)
Core/Misc: Fix issues reported by static analysisCoverity defect IDs: 1267938, 1267937, 1267933, 1267932, 1267929

[Quest] Kodo Roundupby @pete318, closes #12811

Fixes the remaining bugs in the "Kodo Roundup" quest in Desolace:
- removes combat status from creature 11627, Tamed Kodo
- sets normal walking speed as the creature's follow speed
- makes the Tamed Kodo stop at Scrabblescrew's Camp
- enables quest objective count 0/5 -> 5/5, quest complete
- SQL (by @tkrokli) links the missing gossip text in the DB

Core/Misc: Fix issues reported by static analysisCoverity defect IDs: 1292769, 1292768, 1292765, 1292763, 1267939

Core/Dungeon Finder: Add additional logs for SMSG_LFG_QUEUE_STATUSLog the current LfgState of the target player when sending SMSG_LFG_QUEUE_STATUS packet.

Core/Misc: Fix issues reported by static analysisCoverity defect IDs: 1292760, 1292761, 1292762, 1292771, 1292770

Scripts/Misc: Fix warning
DB/Creature: Baelmon the Hound-MasterBy malcrom, updated by Killyana closes #6606
Revert "Merge pull request #14424 from Rushor/Rampart"This reverts commit 22c0007b42e80fecd81eee53f856fd10decd5c05, reversing
changes made to 20bc2c51f668db245d6e360486ea8743c1887fac.

DB/Quest: The Journey Has Just BegunBy Killyana, closes #12253
DB/Quest: Elekks Are Serious BusinessBy Killyana, closes #12518
DB/Creature: Time WatcherBy Killyana, closes #4167
DB/Quest: Killing Two Scourge With One SkeletonBy Kilyana, closes #10475
Merge pull request #14424 from Rushor/RampartScripts/HellfireRamparts: Vazruden the Herald - Improve Reset-/ Aggrobehaviour
Merge pull request #14083 from Gooyeth/3.3.5_sample_satisfactionCore/Spells: Fixed Sample satisfaction not entering combat
DB/Misc: Depreciated QuestsDisable some quests which had not been takable on retail since patch 1.8 when Korrak was removed from Alterac Valley, these quests later became completable after patch 3.0.2 but only if player still had quest in log from before was removed

* The Legend of Korrak
* Korrak the Bloodrager
* The Return of Korrak
* Korrak the Everliving
Core/Script: Remove script for Overlord Mor'ghor - converted to SAI in commit 16179f8
DB/Misc: Fix startup errors
DB/NPC: Legion Hold scripts and eventBy @Killyana

Closes #14488
DB/Misc: Missing Spawns & GossipMissing spawns and gossip menus for Karazhan Chess (note this encounter still is not scripted) this adds the missing npcs and gossip menus for these npcs,

Adds missing data for https://github.com/TrinityCore/TrinityCore/issues/7938 but does not close it.
Core/SAI: fix typo(cherry picked from commit 9ed21eb5b176986dd73c2a467e665fe449499155)

Core/Database: Remove va_list from PreparedStatement::PAppend.
Core/World: Remove va_list from World::RecordTimeDiff. * also split it in ResetTimeDiffRecord() and RecordTimeDiff() to avoid passing of null values.
Core/Database: Remove va_args from DatabaseWorker::Execute methods. * Also delegate SQLQueryHolder::SetPQuery into SetQuery.
Dep/CppFormat: Update cppformat to cppformat/cppformat@aab64b55a4c5db5 * fixes argument limit, argument count is unlimited now.
Core/SAI: fix merge conflict it's good to use CTRL + S
Core/SmartScripts: added SMART_ACTION_SET_COUNTER and SMART_EVENT_COUNTER_SET as per request of DB developers(cherry picked from commit 23b1c042adbe3a460457aa11f017c90e6600bfa2)

Conflicts:
src/server/game/AI/SmartScripts/SmartScript.h

Core/Packet: Correction to packetsize for SMSG_WEATHER
DB/Waypoint: Add missing paths for Silvermoon GuardiansCloses #14484

DB/Quest: Thirst Unending as DKBy Killyana, closes #10389
Rename sql/updates/2015_03_30_03_world.sql to sql/updates/world/2015_03_30_03_world.sql
DB/Quest: Unsealed ChestBy @Foldor

Closes #14416
DB/Misc: Winter Jormungar / snow moundby @Killyana

closes #14428
DB/Creature: SinestraBy @Killyana

Closes #14467
DB/Quest: Lord Illidan StormrageBy @Killyana

Closes #467
Core/Misc: Remove unused headers
Core/Entities: Add player name and ID to GetXPrestBonus calculation-log
Core/Dungeon Finder: Allow to execute "lfg" commands from console
Fix non-pch build.
Core/Logger: Add basic account-info to addon-scans to make them a little bit more useful (@Aokromes, you can stop asking for this now...)
Core/Dungeon Finder: Restore ".lfg queue debug" logging additional informationRestore ".lfg queue" behavior to print additional debug informations when an additional argument is passed (any character/word will work).

CMake: Use source_groups to represent the source tree * It let ide's (like vs) display the source tree. * Disabled by default. * Soft requirement is cmake >= 2.8.12 . * Offers 2 modes: flat & hierarchical. * For detailed description see #14471 * Thanks @click for help and advises. * Closes #14471
Core/Database: Return an unknown error code instead of false (0) if mysql_init failed. * Thanks @et65 for noticing. * ref #14139(cherry picked from commit 83bbe00785a7ee7c8141d83bfe94a1415466c64d)

Core/Database: Fix a mistake in 54ee5267244acac16 * Also use proper errno instead of 0 when reconnecting. * Thanks @et65 for reporting * ref #14139(cherry picked from commit 47410157b1d1e51062732696ad5f457a69019ef4)

Core/Log: Improve creation of log prefixes. * this also fixes non whitespace seperated timestamps in logs after 95ebe4f31cba6b4772cfd19 @Aokromes * remove an unnecessary stringstream in Log:utCommand * delete copy constructor of LogMessage to prevent unwanted copies(cherry picked from commit a2e280c8a8478bbe0652c1850b1a435abba79f93)

Core/Log: Fix linker errors that occur on msvc 12 lower then update 4 * http://stackoverflow.com/questions/4891067/weird-undefined-symbols-of-static-constants-inside-a-struct-class * http://www-01.ibm.com/support/knowledgecenter/SSGH3R_8.0.0/com.ibm.xlcpp8a.doc/language/ref/cplr038.htm%23cplr038 * closes #14463 * ref #14317(cherry picked from commit 9b0b1185e4f9eb48cd16237f7622204687b9c01a)

Conflicts:
src/server/game/Server/WorldSocketMgr.cpp

Core/Database Improve commit 39bdd06446dc * found a better way where no cast is needed. * ref #14430(cherry picked from commit 54ee5267244acac16e4b56342e64c0235ee0599b)

DB/Creature: Fixing a minor error on Elrodan and Aurosalia eventBy Killyana, closes #14465
DB/Misc: Fix startup errorsBy Killyana, updates #13707
Core/Script: Fix non-PCH build
Core/Database: Prepare statements at reconnect. * Closes #14430(cherry picked from commit 39bdd06446dc8ae6f19e017e4390bd2aa7834d03)

DB/Misc: Slight update to commitThis does not make any difference but fixes a error with a bad delete statement when trying to re-apply.
DB/Misc: Quest end scriptsScript quest complete scripts for: -

* Kael'thas and the Verdant Sphere
* The Fall of Magtheridon (Horde and Alliance)
Rename 2015_02_15_14149.sql to 2015_03_26_01_world.sql
Merge pull request #14149 from Rushor/EndingScripts/Bloodmyst Isle: Script Quest: Ending Their World
DB/Instance: Waypoints and corrections in UldamanBy Kittnz, closes #14447
DB/Creature: Spawn some 'Shakers' (3.3.5)* by @Aokromes

DB/Quest: The Secret CompromisedScript turn in event
Scripts/Spells: implement some eject passenger spells(cherry picked from commit 766eb599ea5e7629ac7a98cf914d2877093a14fd)

Core/Creature: fixed trigger visibility of vehicles(cherry picked from commit 5cee106524d8d7e0048270042be9fd02ce399a21)

Rename 2015_02_06_14_world.sql to 2015_03_25_01_world.sql
Merge pull request #14048 from Rushor/WorgenScripts/Grizzlyhills: Spell: Infected Worgen Bite - Apply Spellscript and Transformation
Update 2015_03_25_00_world.sql
DB/Misc: Fix startup errors
DB/Creature: Make Clockwork Mechanic ride ArachnopodBy Malcrom.
Core/DBUpdater: Use correct formatter for size_t * thanks @DDuarte pointing this out.(cherry picked from commit b2b8de5786364d81fbce643e8f00bcc0129ed760)

DB/Misc: Fix startup errorsUpdates #13707
Code is welcome to fix the remaining core errors.
DB/Misc: Fix startup errorsBy Kilyana, updates #13707
DB/Misc: More error fixes
Core/DBUpdater: Add the possibility to limit the remove of orphaned entries. * This will save you from loosing your update history if you use a repository in bad state (revision or branch) by mistake. * Also turned 1 error message into a warning(cherry picked from commit 966282fbed24a0d0cf8cb3e05b1849c3e6a0d1d6)
(cherry picked from commit 3ad7776d5061308d3e2b4ff9e3cbf67d48bffdd6)

DB/Misc: Another errorAs Aokromes suggested when I originally committed fix for Teleport This! I must have accidentally searched for creature guid instead of go guid.
DB/Misc: Fix error
DB/Misc: Avoid friendly fire on UlduarBy @Trista, Closes #3292 if anyone have a better solution for this, you are free to share it.
DB/Creature: Emissary of Hate* Add Conditions for Emissary of Hate - Spawn, increade Despawntimer, remove unneeded actions from Irespeakers

DB/Creature: Akama (21700)Script quest turn in cut scenes for: -
Scripts quests in first part of chain

* http://www.wowhead.com/quest=10628/akama
* http://www.wowhead.com/quest=10707/the-atamal-terrace

I dont have sniffs of second part of chain, know of http://www.wowhead.com/quest=10944/the-secret-compromised#comments
DB/Quest: Lohn'goron, Bow of the Torn-hearBy Kilyana
DB/Creature: Altruis the SuffererAdd a few missing texts for this npc
DB/Creature: Tobias the Filth GorgerScript event for return of turn in of http://www.wowhead.com/quest=10547/of-thistleheads-and-eggs and taking of http://www.wowhead.com/quest=10550/the-bundle-of-bloodthistle
DB/Quest: The Cipher of Damnation - Ar'tor's Charge
DB/Quest: Vision GuideBy Killyana, closes #10309
DB/Creature: Guard RobertsBy Killyana, closes #13676
DB/Quest Veil Lithic: Preemptive StrikeBy Killyana, closes #12564
DB/Item: Fix Item D.I.S.C.O.By Killyana, closes #4214
DB/Quest: Into the Pit / Back to the PitBy Killyana closes #14345
DB/Item: Fix Bloodthistle WithdrawalBy Killyana, closes #9343
DB/Creature: Paladin Mounts - Holy visualBy itslovelol, closes #14427
Merge pull request #14426 from tkrokli/SetQuestSlotState[Core/Quest] Update quest Objective status Client side
DB/Creature: More Ulduar pathingBy Malcrom
DB/Creature: Pathing for Guardians of LifeBy Malcrom
Update world_database.sql
DB/Creature: Pathing for FreyaBy Malcrom
DB/Creature: Pathing for Winter RevenantBy Malcrom, closes #2070
DB/Quest: Teleport This!By @Killyana

Closes #4878
DB/Misc: Fix runtime error, delete incorrectly spawned mobUpdates #2070
DB/Quest: Take Down Tethyr!By @Killyana, Initial work by @tkrokli

Closes #14294
DB/Quest: The Cipher of DamnationFinished unless I find anything else that is missing or anything else that is needed in script.

Closes #14422
[Core/Quest] Update quest Objective status Client sideby @untaught; closes #12172

AreaExploredOrEventHappens does not update client side, only server side.
Before adding this fix, it is necessary to complete the required number of kills
to receive the "discovery" Quest Objective Credit in player's Quest Log and on screen.

Core/DBUpdater: Use correct uint64 to store timestamps. * Thanks @Shauren for pointing out. * Also removes an invalid argument thanks @jackpoz for noticing.(cherry picked from commit 8e48ef7863c5018aa185913ce6a616e46ef5b17e)

Scripts/HellfireRamparts: Vazruden the Herald - Improve Reset-/ Aggrobehaviourby @CDawg

Core/DBUpdater: Fixed compile errors with boost 1.55 and VS 2013(cherry picked from commit 495af75b7e21a2a84231b0540a6f2b9ed349ea58)

Core/Database: Fix some warnings on gcc * warning: when initialized here [-Wreorder] * thanks to @Vincent-Michael(cherry picked from commit cff3910ec82b9f5ebc462a756ce39cc062120cfa)

Scripts/Ulduar: Fix some Flame Leviathan issuesFix some Flame Leviathan issues:
- Fix boss evading all the time due to bad Doors check
- Opened "Lightning Door" to other bosses only after boss dies
- Eject players from the vehicles when boss dies, make them untargetable and despawn them after 5 minutes (adjust the time to the blizzlike time of choice)

SQLs: Re-add two sql files (236e43443c644a9 & 0f6515750dc)
TDB 335.58 - 2015/03/21
Rename SQL filesPreparations for TDB release

Core/Updates: Add an automatic database update system. Automatically detects new and edited sql updates through file lists and hashing. Detects renames, deletes and is able to create and auto import full databases. * cleanups in main.cpp of world & bnetserver * refactoring in DatabaseWorkerPool.h & MySQLConnection.cppMake sure you re-run cmake, because boost::iostreams was added as dependency.
Maybe you need to install libboost-iostreams1.55-dev on unix as well.

Import every update manual until (included) those INSERT IGNORE updates for each database.

Thanks DDuarte and Shauren for your amazing ideas, help and advises.

In hope that nobody gets a "Your database structure is not up to date..." anymore ,-)

(cherry picked from commit 352012e53173372ebc82898e1b6854c983b01b25)
(cherry picked from commit 1f7f9feafc3f5017d617634ae993d2cdf4430920)

For 3.3.5:
* Synchronized ConfigureBoost.cmake with 6.x, libboost-filesystem1.55-dev also added as dependency!

Signed-off-by: Naios <naios-dev@live.de>
Signed-off-by: Nayd <dnpd.dd@gmail.com>

DB/Spell: Dreadsteed - Flame visualBy @Killyana

Closes #14413
DB/Quest: Lohn'goron, Bow of the Torn-heartBy @Killyana

Closes #2692
Update 2015_03_20_01_world.sql
DB/Misc: Fix startup errorBy Malcrom (no, he is not back)
Scripts: remove whitespaces
Rename 2015_03_15_15_world.sql to 2015_03_20_00_world.sql
Merge pull request #14388 from Rushor/SpellScripts/Spells: Hand of Reins - Questsupport for 'Mounting Up'
Scripts/ToC: The Lich King event should only be started by the announcer
DB/Misc: Rename an pr update to match its merged date
Merge pull request #14405 from ariel-/gpsfixCrash fix in .gps command
Split up LANG_MAP_POSITION to fix a crash when issuing .gps command
Core/Spells: Implement HasAttribute() helper for SpellInfo for easier readabilityOriginal code by @Shocker (6.x branch)

Core/Misc: Fix some issues detected by static analysis * Assignment of function parameter has no effect outside the function. Did you forget dereferencing it? -> This argument is passed by value, it makes no sence so set it to null here.* Member variable 'instance_violet_hold_InstanceMapScript::bWiped' is not initialized in the constructor.

(cherry picked from commit 433bc289c2c82b7377ad0189e415a3ca070d220f)

Dep/CppFormat: Update cppformat to cppformat/cppformat@bf8636c9596fbfddd * fixes detecting support of <initializer_list> * fixes build on solaris(cherry picked from commit e40a5bf0b1483ce4275464a0a75a3d99035ca71c)

Core/RemoteAccess: Remove an unused define in RASession * probably fixes gcc compile after adding cppformat(cherry picked from commit a610dea85c77da9ce6c2be5b10f8259e3f315227)

Core/Log: Readd include of <stdarg.h> to fix compile issues under gcc(cherry picked from commit d64e6ffade392be32f634b32658a6e0353f369c1)

Scripts/Spells: Hand of Reins - Questsupport for 'Mounting Up'by @untaught closes #3977

Scripts/Bloodmyst Isle: Script Quest: Ending Their Worldcloses #1815

* Add missing Waypoint
* Improve Aggrobehaviour
* Add BroascasttextIDs
* Update to current GUID-Handling

Original Patch by @trickerer

Build fix
Dep/CppFormat: Fix cmake error when using GCC(cherry picked from commit 3eaace1508e818c4f651eaaf8792cc60a766890f)

Core/Authserver: Include cppformat
Merge pull request #14317 from Naios/typesafelogType safe logging
(cherry picked from commit cc0c9add5a3f3a17e19029ddcaa7e711040f4fc5)

Conflicts:
src/server/bnetserver/CMakeLists.txt
src/server/game/Server/WorldSocketMgr.cpp
src/server/shared/Logging/AppenderDB.cpp
src/server/worldserver/CMakeLists.txt

Core/Game: Fix some issues detected by static analysis.* Possible inefficient checking for 'list' emptiness.

* Variable '_scheduledScripts' is assigned in constructor body.
Consider performing initialization in initialization list.

* Variable 'Text' is assigned in constructor body.
Consider performing initialization in initialization list.

* Possible inefficient checking for 'm_loadedScripts' emptiness.

(cherry picked from commit 9a61049f88835fd6bdb75905f042583d038d0667)

Conflicts:
src/server/game/Server/Packets/TicketPackets.cpp

Core/Log: Fix some issues detected by static analysis.* Either inefficient or wrong usage of string::find(). string::compare() will
be faster if string::find's result is compared with 0, because it will not scan the whole string.
If your intention is to check that there are no findings in the string,
you should compare with std::string::npos.

* C-style pointer casting detected. C++ offers four different kinds of casts as replacements:
static_cast, const_cast, dynamic_cast and reinterpret_cast.

(cherry picked from commit 8882a6ca78e90d2980a3cd8d53acea9d2137f8b8)

Scripts/Undercity: Update Lady Sylvanas' script and also implement few missing things to Journey to Undercity's quest end eventCloses https://github.com/TrinityCore/TrinityCore/pull/14094
Thans to @Killyana @Rushor @jaredjones and all others who helped with this

Rename 2015_03_17_01_world.sql to 2015_03_17_01_world.sql
DB/Object: Dedication of Honor* Fordring statue will only be visible on a realm where the realm first is rewarded for http://www.wowhead.com/achievement=4576/realm-first-fall-of-the-lich-king otherwise this is replaced with fountain
* Dedication of honor will play lich king video to a player who has killed the lich king
* Correct flags for fountain object.
Merge pull request #14370 from Kittnz/realm_achievementCore/Condition: Realm Achievement condition
DB/Creature: Misc SAI updatesBy Malcrom (no, he is not back)
Scripts/Borean Tundra: Enable Texts for 'Nesingwary Trapper'by @Killyana + @danlapps
closes #10234

update guidThis was already fixed with updates but changing here so this wont cause problems if people try to commit later.
DB/Creature: Misc SAI updatesBy Malcrom (no, he is not back)
DB/Creature: Misc SAI updatesBy Malcrom (no, he is not back)
Core/Condition: Added Realm Achievement condition- Partly Fixes https://github.com/TrinityCore/TrinityCore/issues/5754
@DRJ has SQL examples

DB/Creature: Misc SAI updatesBy Malcrom (no, he is not back)
DB/Creature: Misc SAI updatesBy Malcrom (no he is not back)
Core: silence broadcasttext startup errors
DB/Creature: Fix faction of 8564 Ranger
DB/Misc: Fix startup errorsBy Killyana, updates #13707
Merge pull request #14371 from Kittnz/movecirclepath_003Core: Move FillCirclePath function to MotionMaster
Closes #14371
DB/Creature: Kurenai Captivecloses #6702

Core/AHBot: Remove a lingering warning that annoyed me for all too long
Core/DBLayer: Remove references to table character_currency (6.x only)Ref 170bc318b34d393ea08e1607b6a4de87fcb2e6d7

DB/Quest: A Crew Under Firecloses #1678

DB/Quest: Take the letter#closes 12775

DB/SAI: Scarlet Initiateby pete318 closes #14355

DB/Object: Stone of Remembrance* thx @Kittnz for providing the datas
closes #14363

DB/Creature: Susan Tillinghastcloses #14356

DB/Creature: Expedition Warden* Events for Creatures on the 'Wyrmskull Bridge'
closes #14358

DB/Quest: Disrupt Their Reinforcements* Flameevent for Portals
closes #14359

DB/Creature: Spirit of Sathrahcloses #14360

DB/Creature: Dread Tacticiancloses #14361

DB/Creature: Senetil Selarincloses #14364

DB/SAI: Tortured Skeletoncloses #14367

DB/Quest: The Escape + Collecting Kelp
DB/SQL: Rename SQL to 2015_03_15_01_world.sql
Merge pull request #13997 from Rushor/malfurionScripts/SunkenTemple: Add Eventsupport for NPC: Malfurion Stormrage
DB/Quest: The Delicate Sound of Thunder / Lightning Infused RelicsBy @Killyana

Closes #14269
SpellAuras.cpp: typo fix
FindOpenSSL: fix detection of OpenSSL 1.0.2 Closes #14284(cherry picked from commit 9ffeb58d094ddba9bffb33a79b33ade9af9f5c00)

Core/Player: fixed some leftovers in db after player delete* character_arena_stats
* character_battleground_random
* character_cuf_profiles
* character_currency
* character_stats
* character_void_storage

(cherry picked from commit 2955a1f595be8ba510260e5a84b53663f2300fff)

Conflicts:
src/server/game/Entities/Player/Player.cpp
src/server/shared/Database/Implementation/CharacterDatabase.cpp
src/server/shared/Database/Implementation/CharacterDatabase.h

Core/Auras: Fixed possible crash in Aura::RefreshDuration - Aura::GetCaster can return NULL(cherry picked from commit 8cd1c9514f336da3d3d9436be554fc80edb6e761)

Conflicts:
src/server/game/Spells/Auras/SpellAuras.cpp

Core: Move FillCirclePath function to MotionMaster
fix typo
DB/Misc: Change guids from previous commit
DB/Quest: Prayer to EluneCloses #5513
DB/Quest: Ghost-o-plasm Round UpBy @Killyana Closes #1656
Revert "*Do not allow players to use vehicles to go further than 1st boss in Ulduar."This reverts commit a009e53049da27966cb3c32e7b0a3094ea320aef.
Remove hackfix for Ulduar vehicles, it should be handled in Ulduar script

DB/Misc: Wildhammer Flare GunAnd same for alliance version even though less sql here as already had gossip menu unlike horde counterpart.
DB/Misc: Kor'Kron Flare GunScript replacement of item if player had destroyed item since doing initial quest in chain.
Revert "Core/Server: Catch exceptions in int main()"This reverts commit 958999ff5cc779e81b9a23789f84c292d79d1341.

Closes #14329

DB/Quest: Parts for the JobBy Killyana, closes #3854
DB/Quest: RazormawBy Killyana, closes #8988
DB/Creature: Tyrion flavor textBy Killyana, closes #12702
DB/Quest: The Essence of EnmityBy Killyana, closes #12702
DB/Creature: High Tinker MekkatorqueBy Killyana closes #10604
DB/Quest: wing commander gryphongarBy Killyana, closes #14182
DB/Quest: The LodestoneBy Killyana closes #6861
DB/Quest: Tooga's_QuestBy Rushor, closes #12322
DB/Creature: Fix trainer training train spell instead proper skill spellCloses #14337
DB/Creature: Fix 2 factions and 1 spawn coordsCloses #14335
DB/Misc: Updates* Sigrid Iceborne Closes #14287
* Wrong broadcasttextid for a text
Core/Dungeon Finder: Fix Vote Kick breaking LFG queueFix Vote Kick started with party in queue breaking the whole LFG queue. The status of Vote Kick is now storing in a bool variable in LfgGroupData, separated from LfgState of the group/members.
If a Vote Kick started with party in queue, the members were not removed from queue correctly and would cause LFG matching system to match these "broken" players but not allowing to start a dungeon.

Closes #10191

CMake: Remove unused source reference
DB/Creature: Gordunni ProxyRemoving spawns of http://www.wowhead.com/npc=23450/gordunni-proxy from Feralas

1) In sniffs from 3.3.5/3.3.0 these npcs are not present at all in Feralas and we have no sniffs of spawns for these creatures what soever
2) These are level 71-72 which makes it look like dont belong here
2) These are marked as been credit npc for http://www.wowhead.com/quest=11096/threat-from-above which is level 70 tbc quest and the other Gordunni Ogres which give credit for this quest have killcredit1 set to this entry

Closes #12297
DB/Quest: Saving YennikuFix http://www.wowhead.com/spell=3607/yennikus-release so that if player is higher level using http://www.wowhead.com/item=3912/soul-gem for http://www.wowhead.com/quest=592/saving-yenniku it does not insta kill Yenniku
Core: Change a few 'stupid' log-messages down to DEBUG-level
Core: INFO->ERROR level adjustment in ObjectMgr.cppSuggest everyone attempt to remember this:
TC_LOG_TRACE = extreme debugging (debuginfo with packetstructures/data)
TC_LOG_DEBUG = debugging (detailed activity of functions and activites inside core)
TC_LOG_INFO = normal runstate (regular info like logins/logouts/levelups/passwordchanges etc)
TC_LOG_WARN = possible issue with config/data etc - things that are not how they should be)
TC_LOG_ERROR = actual error that has been either caought or must be fixed at some point
TC_LOG_FATAL = crash or data corruption imminent
Using the right logmech also helps distinguishing between 'regular runtime info' and stuff that might lead to a pissy situation later on...

Core/Script: INFO->DEBUG notification changes in ToC
Core/Scripts: INFO-DEBUG changes in scripts (gawd)
Core: INFO->DEBUG level changes - forgot one in Map.cpp
Core: More INFO -> DEBUG changes
Core: WARN instead of INFO - this is actually something we'd want to be informed of...
Core: And yet more INFO->DEBUG logging
Core: Pet.cpp - INFO -> DEBUG level notifications...
Core: More INFO -> DEBUG (Unit.cpp this time)
Core: INFO->DEBUG cleanups in Player.cpp
Core: More INFO -> DEBUG/WARN/ERROR mangling
Core: More INFO -> DEBUG changes (WorldSession/WorldSocket)
Core: Move LOG_INFO -> LOG_DEBUG level for achievements
Core: Move some MMAPS-related INFO-messages to DEBUG
Core: Change some map-specific INFO-messages over to to DEBUG or ERROR
Core: Move some more INFO-level logentries to DEBUG
Merge pull request #14012 from Rushor/ArcaScripts/Arcatraz: Harbinger Skyriss Adds - Remove Unattackable Flag on Spawn
Scripts/The Lich King: Defile should not grow when player grabbed by Val'kyr is moves acrossCloses #14131

Fixed typo in dea095a84bb0ecd3814069f6a8894e66f1fc21a7
Scripts/Nexus: commanders converted from SAI to C++
DB/Creature: Fix 2 runtime errors
Merge pull request #14303 from danlapps/3.3.5remove king jotum vehicule of code as per Killyana request
fix build
DB/Spells: assign spellscript to some clone spells (also fixes an startup error)(cherry picked from commit 1e8b2ae52796b26589909770d2216269bb1bafa9)

Scripts/Rotface: moved mutated infection removal handling to spellscripts to fix an startup error(cherry picked from commit 1dc60e8717bddab2a6bc39779a53e83c9fa3b339)

remove king jotum vehicule of code as per Killyana request
Core/PacketLog: Avoid unneeded calls with disabled packet logsAvoid calling GetOpcodeNameForLogging() when packet logs are disabled.

Shared/Logs: Add support to .server set loglevel command after 003d67708b9a279da3d37e5ef06eb32ceab53964Update the lowest log level when using ".server set loglevel" command.

Shared/Logs: Improve log performancesImprove Log::ShouldLog() performances by saving the lowest log level across all loggers and discarding any log with lower level than that.

DB/Quest: The Tome of DivinityBy Killyana, closes #14240
DB/Quest: Rescuing EvanorEvent script by @Rushor and small part by @Killyana

closes #5308
Fix conflicting guidNo idea why this guid was free for me
Iron Rune Constructs and You: Rocket JumpingBy @Frytiks / @Killyana Closes #3732
DB/Quest: Iron Rune Constructs and You: The BluffBy @Killyana Closes #14265
DB/Quest: Iron Rune Constructs and You: Collecting DataBy @Killyana closes #14264
DB/Quest: On Nethery WingsBy Killyana, closes #6210
DB/Conditions: Fix Taking of Mind Tricks for Alliance PlayersFix taking of http://www.wowhead.com/quest=13308/mind-tricks for alliance players previously this has previous quest set to Orgrims Hammer resulting in that quest was only available to horde players even though this quest should be available to both factions as long as Orgrims Hammer or The skybreaker is taken.
DB/Creature: Fix floating stealth creaturesBy Killyana, closes #14252
Core/Player: Optimize Player::HaveAtClient() performanceChange m_clientGUIDs from std::set to std::unordered_set to reduce by 2.7x times the cpu usage in Player::HaveAtClient()

CMake: Allow specifying the mysql location by environment variable.
Core/Crypto: Fixed output of BigNumber::AsByteArray when generated array is shorter than requested size
Core/Collision: Fix crash when loading invalid vmap dataFix array overflow when loading Models from vmap tiles with wrong/outdated/bad data.
Try extracting again vmaps if you see this error.
Closes #14255

Core/CrashHandler: Fix char[] without '\0' handlingFix char[] without a NULL character '\0' in the array reading over the char[] bounds

DB/Quest: A Rough RideBy Killyana, closes #14248
DB/Quest: Basic ChemistryBy Killyana, closes #14249
DB/Creature: Conditions for king jokkumBy ccrs, closes #14251
Core/Networking: Fixed IOCP define for linux(cherry-picked from commit 518c744336fe7306a034beb46289d5009b959e7d)

DB/Creature: Add some missing gossipsBy Killyana, closes #12659 closes #12743 closes #12742 closes #12614 closes #12620 closes #12649 closes
Buildsystem/Genrev: Fixed revision generator not reading existing cmake cache variables
DB/Quest: Measuring Warp EnergiesDisable los on Warp Measurement otherwise provided quest item only gives credit when literally standing right on top of spell focus object
DB/Conditions: Battered Storm HammerBattered storm hammer can only be used on The Iron Watcher wowhead comments state this will not work on any other target.
DB/Quest: A Distraction for AkamaBy @Killyana closes #14166
DB/Item: Bountiful FeastBy @Killyana Part solves #3991
DB/Quest: The Battle of Darrowshire (3.3.5)By @Killyana closes #14172
DB/Creature: Northsea KrakenBy @killyana / @dr-j Closes #1596
DB/Misc: Crusader's Pinnacle PhasingBy @ccrs Closes #14125
DB/Quest: Krolmir, Hammer of StormsBy @ Killyana closes #6102
DB/Achievement: Flirt with Disaster (Faction change issue)By @Rohlik Closes 14201
DB/Spell: Elixir of Minor AccuracyBy @Killyana closes #13206
DB/Quest: Wanted: MurkdeepBy @Killyana Closes #1675
DB/Item: The Egg of Mortal EssenceBy @Killyana Closes #4485
Core/Achievements: pick more changes from 4.3.4/6.x branch, required after abee9046a6d92e2f0ba9de9c97ce6304c2fcb883
DB/Creature: Skettis Waypoints 1By Kittnz, closes #14203
Core/Spells: Fix a float division issue in EffectLeapBackRef Coverity CID 1227511

(cherry picked from commit 709275eecbbe073cd9b9170debfcef476ef66a6c)

Conflicts:
src/server/game/Spells/SpellEffects.cpp

Core/Server: Catch exceptions in int main()The exceptions is rethrown on debug mode.

Ref Coverity CID 1010213, 1022574, 1227501, 1227502,
1227503, 1227504, 1227505, 1254536 and 1254612

(cherry picked from commit e68ca82d4d039a401d03de145111b0a738bb9dd7)

Conflicts:
src/server/bnetserver/Main.cpp

Merge pull request #14103 from Epicurus4/6.xAdded a player searcher
(cherry picked from commit b7052d2ed735dca233b91c32f762b4156543aa97)

Core/Log: Move a few PetHandler INFO-notifications over to DEBUG-level
Core/Log: Change periodic spell notificiations to DEBUG-level and set it as a unique logging-mechanism named "spell.periodic"
DB/Achivement: Dinner ImpossibleThanks to @Joshiwald for fixing core to check db criteria for this achievement type to make this work properly, now achievement is only rewarded when a great feast has been laid in all 5 specified battlegrounds by player.
Core/Achievements: check db criteria data for all achievements
Core/Logs: Throw a little more sensible textoutput when missing maps/vmaps (the old text was a tad confusing mixing maps and vmaps etc).
Core/Config: Force SaveRespawnTimeImmediately config to EnabledForce SaveRespawnTimeImmediately config to Enabled to avoid assertions triggered at runtime when Disabled. It will be possible to Disable this config again only when all issues will be fixed.

DB/Creature: Hyldsmeet WarbearBy Killyana, closes #12043
Core/Movement: Clarify log meaning(cherry picked from commit 6ff1764084d9234f35609a227567875cd95561a1)

Rename 2015_02_18_04_world.sql to 2015_02_20_03_world.sql
Merge pull request #14117 from Rushor/ZuramatScripts/Violet Hold: Zuramat the Obliterator - Improve Summonbehaviour of Void Sentry
DB/Quest: Seeds of Chaoscloses #1941

DB/Quest: A Hearty Thanks!By Rushor & Kilyana, closes #14092
DB/Misc: Fix startup errorsBy Kilyana, updates #13707
DB/Creature: Complete Borean Tundra Movement
Scripts/Violet Hold: Zuramat the Obliterator - Improve Summonbehaviour of Void Sentrycloses #12175

Rename 2014_02_11_06_world.sql to 2015_02_18_03_world.sql
Merge pull request #14111 from Rushor/VolkhanScripts/HallsOfLightning: Boss Volkhan - Add OOC Forgecast
Merge pull request #14053 from Rushor/MelliScripts/Arcatraz: Warden Mellichar - Set summoned Units in Combat
DB/Creature: Coprous the Defiled and Plagued FiendBy Killyana, closes #14174
DB/Quest: Vyletongue CorruptionBy Killyana, closes #4905
DB/Creature: Mug'gokBy Kittnz, closes #14175
DB/Misc: Correct gossip menuCorrect a mistake from earlier commit
DB/Quest: The reckoningBy DR-J and Killyana, closes #5022
DB/Misc: Adition to Fervor of the FrostbornBy Killyana
DB/SAI: Remove one unneeded SAI
Core/LFG: Fix assertion triggeredFix assertion triggered since 9582b32d22ef9c842349a5be012bdcae4674d6c9

Scripts/BlackTemple: Shade of Akama* Updated to BossAI
* Solved issue with door not closing when event starts
* Solved issue with gossip flag being reset after event is done
* Misc code clean ups

Updates #10430

DB/Creature: Hai'shulud, Mature Bone Sifter and TunnelerBy Killyana, closes #14170 closes #11418
DB/Misc: Luna Festival (Commoner texts & Gossip)
DB/Creature: Utgarde Keep - Pathing and Emotes* This adds movement and emotes for all creatures in that instance

DB/Quest: Learning to Communicatecloses #2250

Thanks to @Rhyme for the Bugreport

DB/Quest: The Howling Valecloses #12287

* and remove unneeded SAIs

DB/Misc: Fix startup error from DTKupdates #13707

DB/Gameobject: Add 2 missing gameobjectsCloses #6366
DB/Misc: Fix startup errorBy Kilyana, updates #13707
DB/SAI: Durnan Furcuttercloses #10596 Thanks to @Crysicle for report

DB/Misc: Fix a few startup errors from recent Updates
DB/Creature: Drak'Tharon Keep start sequenceBy Rushor, closes #14070
DB/Creature: KeristraszaBy MENZ411 and Rushor, closes #8767
DB/Quest: Fury of the Frostborn KingBy Killyana, closes #8587
DB/Quest: Stop the PlagueBy Rushor, closes #10224
DB/Creature: Cyrus TherepentousBy Rushor, closes #12337
DB/Quest: Nothing But The TruthBy Rushor, closes #12213
DB/Creature: Skorn WhiteCloudeBy kldxzzhc2, closes #12812
DB/Quest: Special Delivery to Shattrath CityBy ariel-, closes #14147
DB/Quest: Escape through forceBy Rushor, closes #10515
Merge pull request #14156 from Rushor/robotScripts/The Barrens: Add missing Text for Q: 'The Escape'
Core/LFG: Fix LFG issue when player was teleportingFix a LFG issue that would kick a player out of a just-formed LFG party if player was being teleported.
Fix a log warning "Player: GUID Full: 0x0000000000000001 Type: Player Low: 1 not ingame while retrieving his LockedDungeons" if player was being teleported.

Refers to #14039 , #10191

Scripts/The Barrens: Add missing Text for 'The Escape'closes #12259

Rename 2015_01_30_01_world.sql to 2015_02_15_04_world.sql
Merge pull request #13989 from Rushor/LeavesScripts/Areatrigger: Assign Script to 'Ancient Leaves' Trigger
DB/Creature: Plagueborn HorroBy Rushor, closes #12789
DB/Creature: Nexus-King SalhadaarBy Wylath and Rushor, closes #10373
DB/Creature: Darnassian ScoutsBy Rushor, closes #8503
DB/Creature: Hellfire Peninsula - Waypoints 5By Kittnz, closes #14153
Remove CPP script for Blueleaf tubers
DB/Quest: Blueleaf Tubers
DB/Quest: Fervor of the FrostbornBy Rushor & Killyana, closes #10367
DB/Misc: Love is in the air itemsLove Rocket, Lovely Rose, Handful of Rose Petals, Silver Shafted Arrow and perfumes and colognes are meant to be sold in stacks of 5 not singally, ie love rocket is meant to be 5 tokens for 5 rockets not 5 tokens each.
DB/Quest: Death from belowBy Killyana, closes #2122
DB/Creature: Thrallmar - WaypointsBy Kittzn, closes #14148
DB/Misc: Fix startup errorsBy Rushor, updates #13707
Core/AHBot: Fix AHBot bidding and correct logged AH typeCorrect AuctionHouseType definition to log the right AH type.
Handle auctions without bidder but with a bid as bought by the AH Bot
Closes #14124

Merge pull request #14144 from Rushor/ZulAmanScripts/ZulAman: Enable Script for Gazakroth
Scripts/ZulAman: Enable Script for Gazakroth*removes one more startuperror from #13707

Scripts/FoS: improved bronjahm encounter, thanks @Grimton1337, @tkrokliCloses #14130

DB/Misc: Fix startup errorsBy Kilyana, updates #13707
DB/Creature: Zuluhed the WhackedBy Kilyana, closes #10039
DB/Misc: Fix startup errorsBy Kilyana, updates #13707
Merge pull request #14138 from Rushor/mulgoreScripts/Kalimdor: Remove Mulgorescripts
Scripts/Kalimdor: Remove Mulgorescripts
Delete zone_mulgore.cpp
DB/Creature: Kyle - Move Corescript to SAIBy Rushor and Kilyana
DB/Misc: Fix 3 startup errorsUpdates #13707
DB/Quest: Root samplesBy Rushor, closes #14137
DB/Misc: Startup errorsBy Rushor & Killyana, updates #13707
DB/Quest: Whispers of the Raven GodBy Killyana, closes #3234
DB/Quest: The Black Knight's FallBy Killyana, closes #11043
Scripts/ForgeOfSouls: Fix an indentation issue on Bronham's script
Merge pull request #14129 from Rushor/GhostScripts/Mulgore: The Plains Vision - Move Corescript to SAI
Scripts/Mulgore: The Plains Vision - Move Corescrript to SAI
Shared/Database: Improve dead-lock error handlingImprove dead-lock error handling by making sure only 1 thread at time retries to execute a transaction so they don't keep dead-locking each other.

DB/Creature: Magrin RivermaneBy Rushor, closes #14121
DB/Quest: Delivering the MessageBy Killyana, closes #1484
DB/NPC: Isle of Quel'Danas - MovementBy Rushor, closes #14061
DB/Quest: Will of the TitansBy Rushor, closes #14040
DB/Quest: Street "Cred"By Rushor, closes #11881
DB/Quest: Becoming a Shadoweave TailorBy Ariel-, closes #13806
DB/Quest: By Fire Be PurgedBy Fearless18 and Rushor, closes #10223
DB/Quest: Gammothra the TormentorBy Rushor, closes #10228
DB/Misc: Wintergrasp teleporter in dalaranBy Gooyeth, closes #13719
DB/Creature: Fix SAI target_type for Scarlet PeasantBy Noeliel, closes #14108
Scripts/Areatrigger: Assign Script to 'Ancient Leaves' Trigger
Scripts/HallsOfLightning: Boss Volkhan - Add OOC Forgecastcloses #14066

Merge pull request #14098 from ariel-/arenacdArena Spells Reset Cooldown micro correction
Scripts/Grizzlyhills: Spell: Infected Worgen Bite - Apply Spellscript and Transformationcloses #12165

Merge pull request #14080 from Rushor/ActionScripts/Redridge Mountains: Corporal Keeshan - Complete Escortquest for all Groupmember
Merge pull request #14106 from Noeliel/3.3.5Scripts/ScarletEnclave: Add missing WorldObject parameter for Talk() ove...
Merge pull request #13963 from tkrokli/3.3.5Fix Cooldown for Raise Dead (Ghoul)
Scripts/ScarletEnclave: Add missing WorldObject parameter for Talk() overload (player race contained in some spoken texts)
DB/Misc: Sealed Vial of PoisonAdd condition to bag of fishing treasures to prevent Vialed Seal of Poison from dropping if player has already completed the quest it starts since it this item which was responsible for the bag bugging out and remaining in inventory but unclickable after player removed all visible items.

Also slight update for Mission Plague This as with previous update was failing to display gossip menu options and was just behaving as flight master.
DB/Quest: Finding the PhylacteryBy Rushor, closes #10777
DB/Quest: Crushing the CrownBy Rushor, closes #14105
DB/Creature: Terokkar waypoints 1By Kittnz,closes #14102
DB/Creature: Stonebreaker - Waypoints and Keb'ezil's tweakBy Kittnz, closes #14100
DB/Creature: Scavenge-bot 004-A8By Rushor, closes #14095
Arena shouldn't reset 10 min or longer CDsCloses #13449

DB/Quest: Fix Aces High!By Rushor, closes #14090
Also fix startup errors by Killyana.
DB/Creature: Fix startup and runtime errorsBy Rushor.
DB/Creature: Fix few startup errorsBy Rushor
DB/Creature: LunchboxBy Rushor & Killyana, closes #14074
DB/Creature: Borean Tundra pathingBy Rushor, closes #14075
DB/Quest: Mission: Plague ThisBy Rushor, closes #14077
DB/Creature: Fireguard DestroyerBy Rushor, closes #14081
DB/Creature: Kvaldir Mist LordBy Rushor, closes #14082
DB/Creature: Beryl Treasure HunterBy Rushor, closes #14087
DB/Creature: Magmoth Shaman / TotemBy Rushor, closes #14088
DB/Misc: Remove Eternal Might from NR Alchemy ResearchRemove ability to learn transmute: eternal might when doing Northrend Alchemy Research since even though this spell and item exists in database could never actually be learnt on retail
Core/Spells: Fixed Sample satisfaction not entering combatFixes: 14047
Scripts/Redridge Mountains: Corporal Keeshan - Complete Escortquest for all Groupmembercloses #13711

Update 2015_02_09_09_world.sql
DB/Misc: Fix one startup errorBy joschiwald, updates #13707
DB/Quest: A Hearty Thanks!By Rushor and Killyana, closes #13738
DB/Quest: Tree's CompanyBy Rushor, closes #13736
DB/Creature: Theradrim Shardling/Theradrim GuardianBy cala, converted by Rushor, closes #13994
DB/Item: Banish CharmsBy Rushor, closes #14020
DB/Creature: Ru'zahBy Kittnz, closes #14052
DB/Creature: MellicharBy Rushor, closes #14051
DB/Creature: Halls of Lighting pathingBy Rushor, closes #14065
DB/Creature: Drak'Tharon Keep pathingBy Rushor, closes #14072
DB/Creature: Drak'Tharon Keep pathingBy Rushor, closes #14071
DB/Creature: Halls of Stone visualsBy Rushor, closes #14068
DB/Creature: Gundrak pathingBy Rushor, closes #14073
DB/Quest: Ready for PickupBy Rushor, closes #14046
DB/Creature: Millhouse ManastormBy Rushor, closes #14050
DB/Creature: IrespeakerBy Rushor, closes #14060
Scripts/SunwellPlateau: Fix a typo that caused M'uru's phase transition to fail on some rare cases
Merge PR #14059 from 'Rochet2/ahbot_buyer' into 3.3.5
DB/Creature: Remove incorrect trigger flag
Fix AHBot Buyer buyin, bidding and enhance logic
DB/Quest: A Friendly ChatBy nelegalno, closes #5262
Scripts/Arcatraz: Warden Mellichar - Set summoned Units in Combat
Fix Cooldown for Raise Dead (Ghoul)@joschiwald: Fix written on 31 Jan 2014.
@Nyeriah: suggested null pointer check.
@ariel-: supplied code for null pointer check.
@ccrs: supplied code (cat && spellInfo->CategoryRecoveryTime) to replace (cat && catRec)
@Dduarte: cleanup of bad edit based on my misinterpretation

Fixes issue #11538
Replaces #13941 and #13924

DB/Item: 3.3.5a locales_item has some Cataclysm translationsBy ariel-, closes #13750
DB/Gameobject: Fix some Scholomance doors
DB/Misc: Disable mmaps for Argent tournament instancesIf anyone can do a proper fix (allow creatures to walk over gameobjects) it will be welcome.
DB/Creature: Fix immunity Herald VolazjBy Rushor
DB/Creature: Thousand Needle's SilithidsBy Rushor
DB/Quest: Digging for Prayer BeadsBy Trisjdc
DB/Creature: Tiny SnowmanBy Rushor
DB/Quest: Respite for a Tormented Soul
DB/Quest: Honor the FallenBy Rushor.
DB/Creature: Antu'sulBy Rushor
DB/Creature: Caretaker Dilandrus
DB/Quest: Minshina's SkullBy Rushor
DB/Creature: Emissary of HateBy Rushor
DB: fixed The Brewmaiden SAI(cherry picked from commit de3d20a9458370df36de4387f53325a5e3dd7d2e)

DB/Misc: Fix a runtime error
Fix build
Shared/Database: Fix transactions not being recommitted on dead-lock errorFix transactions not being recommitted on dead-lock error (error code 1213) because of calling http://dev.mysql.com/doc/refman/5.0/en/mysql-errno.html after sending the ROLLBACK command. This way the returned error code was related to the ROLLBACK command, not the failed transaction.

Scripts/Arcatraz: Harbinger Skyriss Adds - Remove Unattackable Flag on Spawn
Merge pull request #14007 from Rushor/AOESpellsGame/Spells: 'AoD Specials' should only target one Unit
Rename 2015_02_02_00_Word to 2015_02_02_00_world.sql
DB/Misc: Fix some run-time errorsSolve issues with sai generating errors in Dalaran through sai triggering on non player characters
Core/Build: Use std namespace in getline calls(cherry picked from commit 86f7f47b58e4e044cd9a9171d83863dd8f99d91c)

Core/Misc: Fix static analysis issuesFix some static analysis issues reported by Coverity

(cherry picked from commit c8999449816d4fd4f72c7cdb3b1515e8e244ba5f)

Conflicts:
src/server/game/Entities/Player/Player.cpp
src/server/scripts/Northrend/IcecrownCitadel/boss_professor_putricide.cpp

Core/Misc: Fix static analysis issuesFix some static analysis issues reported by Coverity

(cherry picked from commit 89c535cf2a960ccc03cd1a032310984f9b4e1d47)

Conflicts:
src/server/game/Entities/Player/Player.cpp

Core/Scripts: Fix missing include
Game/Spells: AoD Specials should only target one Unit
Merge pull request #14002 from Rushor/WebbsScripts/Bloodmyst Isle: Disable CreatureAttack for NPC: Webbed Creature
Scripts/Bloodmyst Isle: Disable CreatureAttack for NPC: Webbed Creature
Core/Misc: Properly sanitize ReputationSpillover dataFix an issue added in 024b57bb74a664cd515cf0822d4b8e939a91fe03 that didn't properly skip ReputationSpillover rows with invalid data.
Fix also a static analysis issue reported by Coverity.

(cherry picked from commit 95b1204798d3ab2a141f81b294b064255c335b8a)

Conflicts:
src/server/game/Globals/ObjectMgr.cpp

Core/VMaps: Fix debug assert caused by invalid vmapsFix debug assert thrown by G3D caused by models with empty bounding box being exported by vmap4assembler and imported by worldserver. This change will skip those models, proper investigation on the issue of why the bounding box is empty is still required.

(cherry picked from commit a7ca78b2fe12c68e561782416bf5726410a3c01b)

Core/Spells: Renamed SPELL_ATTR4_TRIGGERED to SPELL_ATTR4_CAN_CAST_WHILE_CASTING and adjusted trigger flags accordingly(cherry picked from commit 6d70acbbd66959f7b6896a19ce3f2a25ccf94f2e)

Conflicts:
src/server/game/Spells/Spell.cpp

Update README.mdAdd labels for how long in average it takes for an issue or PR to be merged.

http://www.issuestats.com/github/TrinityCore/TrinityCore
(cherry picked from commit d874bf0c740af000475ed5b5c7b44d879196fe3e)

Core/Players: Fixed loading and saving skill data PK violations(cherry picked from commit 2dfd1594cd3cc7fdba4131d2e825885cac2bcc17)

Conflicts:
src/server/game/Entities/Player/Player.cpp

Core/Quests: Fixed WPE exploit that allowed to accept any quest(cherry picked from commit 6b10271891d2cbafbad1446051fcf3866ea728e3)

Merge pull request #13996 from Rushor/GymerGO Scripts/Zul'Drak: GO Scourge Enclosure - Delay Despawn of Dummy to ensure Explosion
Scripts/SunkenTemple: Add Eventsupport for NPC: Malfurion Stormrage
Scripts/Zul'Drak: GO Scourge Enclosure - Delay Despawn of Dummy to ensure Explosion
DB/Gameobject: Add a missing gameobject
Scripts/HoR: fix warning
Scripts/HoR: implement Quel'Delar quest * support for quest 24480, 24561 * there may be some visual problems but quest should work as intendedCloses https://github.com/TrinityCore/TrinityCore/issues/838

Implement CharSections.dbc and Serverside Checks.
DB/Misc: TrayaniseScript http://www.wowhead.com/npc=18230/trayanise from sniff

Only the Tiny Arcane Construct appears to have fixed WP ie same waypoints repeat in sniff over and over while trayanise waypoints are different each time,

Also adds the texts to this npc
Core/Creatures: No gray aggro config(Custom) Adds option to disable aggro from gray creatures when the players are above/below certain levels.

Closes #13919

Merge pull request #13893 from Unholychick/3.3.5Core/Spells: Use BonusAmount for periodic damage
Fix typo in CMakeLists.txt
Tools: Remove mesh_extractormesh_extractor is not ready for production and it will be developed
in a different branch

(cherry picked from commit a87442be68da4e2ea51a10e3bd8a07ef7b9765b2)

Conflicts:
src/tools/mesh_extractor/ContinentBuilder.h
src/tools/mesh_extractor/DBC.cpp

DB/Quest: Adding Injury to InsultFix http://www.wowhead.com/quest=12481/adding-injury-to-insult so it works as on retail

* Bjorn Halgurdsson unattackable until the Vrykul Insult is used on him, by setting passive + flags 2 unattackable since unlike using immune to pc this still allows the insult to be cast without getting invalid target
* It is now possible to get Bjorn Halgurdsson to Lydias Ambush without him evading as previously you could only get him as far as the water
* ensuring this resets correctly in event of evade.
DB/Misc: Fix startup errorAdd a missing NPC text which was causing startup error
DB/Spells: Fix one startup error
Scripts/SunwellPlateau: Correct a summon group entry and misc clean up
Scripts/HellfireRamparts: Add a missing reset call and correct spawn masks for Reinforced Fel Iron ChestsThanks to @ariel- for noticing the missing _Reset();

Closes #13747

Core: Make core build without PCH enabled.
Rename 2015_01_17_00_world.sql to sql/updates/world/2015_01_17_00_world.sql
Rename sql/updates/world/2015_01_17_00_world.sql to 2015_01_17_00_world.sql
DB/Misc: Lights Vengeance (Again)Since I scripted this a second sniff surfaced with more data on units which where missing from original sniff
Update and rename 2015_01_16_00_world.sql to 2015_01_16_00_world.sql
DB/Misc: Tabard VendorsReplicate script on Elizabeth Ross to other tabard vendors as previously only Elizabeth Ross would replace lost tabards.
Core/Spells: Use BonusAmount for periodic damageCloses #13887

DB/Creature: Add Corvax & Rook spawns and waypointsBy Kittnz, closes #13826
DB/Waypoint: Update several npc's move_type for running npc'sBy Kittnz, closes #13888
DB/Misc: The Sacred and the Corrupt Turn in eventalso a few tweaks for light's vengeance script.
DB/Misc: Additions to https://github.com/TrinityCore/TrinityCore/commit/fb1b7f66a5d959e4b080a8b25cd697c9764a098f* Prevent event from restarting if theres already an instance of either the Lich King, any of the 2 versions of vegard or the first 2 light's vengence objects already spawned
* Prevent further ghouls from being summoned by same npc if there is already ghoul summoned by that npc
DB/Misc: Lights VengenceCloses #13856

Script working, there are some issues with spell targeting for aod spells used by Lich King and Vegard to summon ghouls but this is fixed by applying the dbc hack by Rushor from original issue to limit spell targets.
Core/Spells: fixed Shatter crit chance modifierCloses #13885

Scripts/Misc: some random changes after recent commits and cleanup
Scripts/Stratholme: Move Maleki the Pallid to EventmapsCloses #13871

Scripts/HellfireRamparts: Clean up a forgotten no longer used variable
Scripts/BlackfathomDepths: Convert bosses to EventMaps/BossAI and clean up instance script
Scripts/HellfireRamparts: Remove the spawning of the Reinforced Fel Iron chest from scriptsUpdates #13747

DB/Quest: Change default RewardHonorMultiplier to 0
DB/Creature: Toc binding must start at Icehowl not at Gormok
Core/Aura: Replace assert with logged error for invalid AuraRemoveModeFix AuraScript::Remove() triggering an assert with default parameter and log an error when Aura is removed with invalid mode AURA_REMOVE_NONE instead of triggering an assert deep down in the call tree.
Fix https://github.com/TrinityCore/TrinityCore/issues/714 , triggered by spell 50240 "Evasive Maneuvers" script

DB/Misc: Revert a few factionsRevert faction of Alliance Corpse and Forsaken Corpse to 35 as this is what it is in sniff not 1899/1900 and this was making these "corpse" npcs attack players and other npcs. Closes #13865

Revert faction of Lord Banehollow since with faction 90 using the Shadowy Potion which should make him friendly to turn in quest of npc name into him but with faction 90 remains hostile even after drinking shadowy potion, this works as should with the original faction of 1434.
Update README.mdDead links for installation.
(cherry picked from commit ac67f276ceaa517801b6abc9f0edc30d7e8ce604)

Closes #13858