Skip to content

Instantly share code, notes, and snippets.

Embed
What would you like to do?
php7.4-serializer-bug-reproducer
<?php
class Node
{
public $childs = [];
public function __serialize()
{
return [$this->childs];
}
public function __unserialize(array $data)
{
list($this->childs) = $data;
}
}
function createTree ($width, $depth) {
$root = new Node();
$nextLevel = [$root];
for ($level=1; $level<$depth; $level++) {
$levelRoots = $nextLevel;
$nextLevel = [];
while (count($levelRoots) > 0) {
$levelRoot = array_shift($levelRoots);
for ($w = 0; $w < $width; $w++) {
$tester = new Node();
$levelRoot->childs[] = $tester;
$nextLevel[] = $tester;
}
}
}
return $root;
}
$width = 3;
ob_implicit_flush();
foreach (range(1, 100) as $depth) {
$tree = createTree($width, $depth);
echo "Testcase tree $width x $depth".PHP_EOL;
echo "> Serializing now".PHP_EOL;
$serialized = serialize($tree);
echo "> Unserializing now".PHP_EOL;
$tree = unserialize($serialized);
// Lets test whether all is ok!
$expectedSize = ($width**$depth - 1)/($width-1);
$nodes = [$tree];
$count = 0;
while (count($nodes) > 0) {
$count++;
$node = array_shift($nodes);
foreach ($node->childs as $node) {
$nodes[] = $node;
}
}
echo "> Unserialized total node count was $count, expected $expectedSize: ".($expectedSize === $count ? 'CORRECT!' : 'INCORRECT');
echo PHP_EOL;
echo PHP_EOL;
}
@Devristo

This comment has been minimized.

Copy link
Owner Author

@Devristo Devristo commented Aug 21, 2019

Small reproducer for bug report https://bugs.php.net/bug.php?id=78438 and the issue encountered in symfony/symfony#33214.

Sample output on PHP 7.4 beta 4, see for yourself at https://3v4l.org/C9dJE .

Testcase tree 3 x 1
> Serializing now
> Unserializing now
> Unserialized total node count was 1, expected 1: CORRECT!

Testcase tree 3 x 2
> Serializing now
> Unserializing now
> Unserialized total node count was 4, expected 4: CORRECT!

Testcase tree 3 x 3
> Serializing now
> Unserializing now
> Unserialized total node count was 13, expected 13: CORRECT!

Testcase tree 3 x 4
> Serializing now
> Unserializing now
> Unserialized total node count was 40, expected 40: CORRECT!

Testcase tree 3 x 5
> Serializing now
> Unserializing now
> Unserialized total node count was 121, expected 121: CORRECT!

Testcase tree 3 x 6
> Serializing now
> Unserializing now
PHP Fatal error:  Uncaught TypeError: Argument 1 passed to Node::__unserialize() must be of the type array, int given in /home/chris/Projects/php7.4-serializer-bug-reproducer/reproducer.php:12
Stack trace:
#0 [internal function]: Node->__unserialize()
#1 /home/chris/Projects/php7.4-serializer-bug-reproducer/reproducer.php(56): unserialize()
#2 {main}
  thrown in /home/chris/Projects/php7.4-serializer-bug-reproducer/reproducer.php on line 12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment