Skip to content

Instantly share code, notes, and snippets.

@Dil3mm4
Created November 26, 2020 17:16
Show Gist options
  • Save Dil3mm4/89316d77ea3235c58157b0b465f6725d to your computer and use it in GitHub Desktop.
Save Dil3mm4/89316d77ea3235c58157b0b465f6725d to your computer and use it in GitHub Desktop.
commit decb8e5582fcd27fe3cdeda4f3af2c3953ff6678
Author: Dil3mm4 <dil3mm4.dev@gmail.com>
Date: Thu Nov 26 03:48:17 2020 +0000
FODCircleView: various improvements.
Added fade-out to FOD view, before going to View.GONE
Tests executed:
- Ensured animation executes correctly
- Ensured interaction with FOD (or any other biometric method) wouldn't compromise animation execution or with FOD functionality itself
- Ensured that alpha values triggered with the animation, are correct over different lockscreen states
Handled more visibility cases
Tests executed:
- Added a Bluetooth device as Trusted Device via Smart Lock, ensured FOD wasn't visible
- Used other biometric methods to unlock the device, ensured FOD wasn't visible
- Enabled On-body detection, ensured FOD wasn't visible
- Enabled Trusted places, ensured FOD wasn't visible
- Triggered biometric failure with too many unrecognized attempts, ensured FOD wasn't visible while transitioning back and forth from AOD.
- Triggered floating biometric dialog and ensured its functionality
Change GlobalActionsDialog window type to TYPE_DISPLAY_OVERLAY (same as FOD view), so that whoever gets called last, will go on-top
Tests executed:
- On a secured lockscreen, triggered GlobalActionsDialog via power menu, ensured FOD was in foreground instead of on-top
commit b62695b0c542a4a7cf1c8d45496fc817e6d483e1
Author: TheScarastic <warabhishek@gmail.com>
Date: Fri Sep 18 16:10:57 2020 +0000
FODCircleView: Only reset brightness if brightness boost is enabled
Change-Id: Icddd29b1279e648d884e19bc917381981d9b97b3
commit eb31154ddf9fb49c507c396e6322eb5ba6513511
Author: TheScarastic <warabhishek@gmail.com>
Date: Tue Sep 10 11:07:39 2019 +0530
FODCircleView: Add support for custom FP pressed icon
* For those devices which were calibrated to use
non-solid color icons, add the icon in overlay.
Change-Id: If357b8eb0da17b1ea97a2ab5ca880d465c33adc9
commit 569cd9a669c400ac8d44c949888d3c2c91de5748
Author: TheScarastic <warabhishek@gmail.com>
Date: Sun May 24 07:12:17 2020 +0000
FODCircleView: Add support for pressed fod layer
Change-Id: Ic2a91ce6d6bcd03e5ac8d4d898a85f5d808c8776
commit 6e8700ffe1777016f1a0976830591d7652bd16ef
Author: Demon000 <demonsingur@gmail.com>
Date: Wed Feb 19 16:30:48 2020 -0500
Revert "FODCircleView: dispatch onPress to HAL only after dimming is applied"
This break the behavior for people returning 0 as dim amount, which is the
case when using in-kernel dimming.
This reverts commit 7ebd24f3bf28580489063e8266501cb6514a4091.
Change-Id: Iefab260334d3232a41d59cc07b5f83f5136e8cec
commit aee556f7278ccd6bc6aaecdfdf558cf449d0ddce
Author: LuK1337 <priv.luk@gmail.com>
Date: Thu Apr 30 21:16:32 2020 +0200
FODCircleView: Let us call show() when mIsBouncer() && !isPinOrPattern()
* Fixes missing fod circle when direct unlock is enabled.
Change-Id: Ib4f8d97a50685cfc9e3a24c243352c7b1af736d0
commit 7d43b0e467addb4f2aa4d4ce28f8565467dd7aff
Author: TheScarastic <warabhishek@gmail.com>
Date: Wed Mar 25 16:13:51 2020 +0530
FODCircleView: Show while bouncer is requesting Pattern or PIN
Also allow devices to overlay the minimum bottom padding of the
keyguard security container so that they may shift the pattern/pin input
and the emergency call button up until the FOD icon does not obscure the
view.
Change-Id: Ie9652afc0d105199bf1e660221c82266ac8cf30a
commit 6a942475a0bdb7ee177fd952570bf82932264e8e
Author: Demon000 <demonsingur@gmail.com>
Date: Wed Feb 19 18:53:59 2020 -0500
FODCircleView: update position of icon before show
FOD icon can appear in the wrong position when locking
the device while in landscape.
Fix it by updating the position before showing.
Change-Id: I812aa07357eadf8ff371761c041e44f5aab48046
commit 4e8ff1223fb87c315572bc38db564d6e3930df36
Author: Demon000 <demonsingur@gmail.com>
Date: Mon Feb 3 18:25:24 2020 +0000
FODCircleView: disable touch detection on screen off
Change-Id: Icfc46823028edb15473aee71992551ae9f7d21b8
commit 53cfba8cf9ed3875b8e663fac40062c1e1c0afbd
Author: XiNGRZ <chenxingyu92@gmail.com>
Date: Tue Jan 14 19:42:55 2020 +0800
FODCircleView: dispatch onPress to HAL only after dimming is applied
Change-Id: Iecdbe3bb38f003f5a7cda86b6bf3082691fd33f5
commit d004bd791fa143867942253d10c4a595b617163d
Author: XiNGRZ <chenxingyu92@gmail.com>
Date: Wed Jan 15 01:37:33 2020 +0800
FODCircleView: invert default icon path and add #20000000 bg
Change-Id: I320cfbe40c9ec24a2c65e403556cca5559ea2772
commit 77d518460ad25e54fc003ce29e5ef715b4320960
Author: Demon000 <demonsingur@gmail.com>
Date: Sun Dec 29 13:17:22 2019 +0100
FODCircleView: rewrite and simplify implementation
Change-Id: Ie0859cc0e5b558b9446db5ec915c1f9f6608adad
commit 4be8fb7b35933e732ab431a7cd23ccec3078369e
Author: Demon000 <demonsingur@gmail.com>
Date: Sun Dec 29 12:51:34 2019 +0100
FODCircleView: place above other UI elements
The navigation bar used to appear brighter because
TYPE_VOLUME_OVERLAY is behind TYPE_NAVIGATION_BAR.
Move the FOD overlay to TYPE_DISPLAY_OVERLAY
to be above other UI elements.
Change-Id: I3cd29d87fd31c817095a7327774d4dc931d54d30
commit c1fbdb638a4a6f342483fcb2b1cee6fb7fdcec6f
Author: Peter Cai <peter@typeblog.net>
Date: Sat Sep 7 11:01:39 2019 +0800
FODCircleView: defer removal to next re-layout
* Originally, when hide() is called, it removes the dim layer and then
removes the view immediately, then calls the hide event in HAL. This
causes severe flickering because the HAL is expected to restore the
brightness immediately, but the dim layer will not be removed until
the next repaint cycle.
* Since it is not easy to listen for a redraw after the view itself has
been removed, we can defer removal after the next time onLayout() is
called. When tested on my OnePlus 7 Pro, this reduces flickering on
successful fp authentication drastically.
* There are some cases where show() is called so quickly after hide()
that the view hasn't been actually removed due to this change (which
is actually another cause of flickering). This is handled by checking
the removal flag in show() and removing it immediately if the view is
yet to be removed, and also by moving calls to HAL show / hide events
to the actual attached / detached event handlers.
* For consistency in semantics, also move calls related to the dim
layer that were originally in onDraw for similar reasons to the
onLayout function.
Change-Id: I9b0cfe5c4d572a64b918ce7d3c130a659fd25a30
commit 9448021ae17e8dd739df3b383231a8e57b52ecfe
Author: Peter Cai <peter@typeblog.net>
Date: Fri Apr 5 16:44:18 2019 +0200
fwb: Initial support for in-display fingerprint sensors
* Initially based upon phh's Mi9 implementation,
however a lot of changes have been made since.
* All device specific stuff has been moved to
IFingerprintInscreen HIDL interface and most
of code has been improved and refactored.
[TheScarastic]: Adapt for Android R Dagger Injection
[daniml3 - arrowos]:
- adapt for non lineage-sdk platform based on PixelExperience/frameworks_base/commit/baa8cb602b2f31036584a62c888c10f04879f4bb
Change-Id: I52beaf6492b9daa012b5d42b858d552d1e378a2c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment