Skip to content

Instantly share code, notes, and snippets.

@EclipseGc
Created June 6, 2014 17:09
Show Gist options
  • Save EclipseGc/618b84fc6f6b7d2f85fd to your computer and use it in GitHub Desktop.
Save EclipseGc/618b84fc6f6b7d2f85fd to your computer and use it in GitHub Desktop.
Existing Rules ContextInterface -> Merge into Drupal\Core\Plugin\Context
Determine if ContextDefinitionInterface is still necessary (instead of DataDefinitionInterface) (hopefully not neccessary).
Form Widget Definitions are not part of Context, Fago will make a separate method for when he needs this at the plugin level.
Allowed values are part of contexts, Kris would prefer a addConstraint() approach to this usage.
Context validation will not happen on setContextValue().
Static methods for plugin context definitions is an implementation detail, Kris doesn't like it but w/e.
Fago wants a ContextException to actually get used & documented.
Fago wants getContext() to return Context objects even if a value has not been set for that context. Kris agrees in principle.
Fago & Kris both support a ContextDefinition Annotation class.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment