Created
February 6, 2020 16:23
-
-
Save Elaniobro/19e7e22785dac6bd3d20480c0b419d50 to your computer and use it in GitHub Desktop.
Clean up your code by removing if/else
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
// https://medium.com/javascript-in-plain-english/clean-up-your-code-by-removing-if-else-statements-31102fe3b083 | |
/** | |
* Button click event | |
* @param {number} status | |
* Activity status: 1 in progress, 2 in failure, 3 out of stock, 4 in success, 5 system cancelled | |
*/ | |
const onButtonClick = (status)=>{ | |
if(status == 1){ | |
sendLog('processing') | |
jumpTo('IndexPage') | |
}else if(status == 2){ | |
sendLog('fail') | |
jumpTo('FailPage') | |
}else if(status == 3){ | |
sendLog('fail') | |
jumpTo('FailPage') | |
}else if(status == 4){ | |
sendLog('success') | |
jumpTo('SuccessPage') | |
}else if(status == 5){ | |
sendLog('cancel') | |
jumpTo('CancelPage') | |
}else { | |
sendLog('other') | |
jumpTo('Index') | |
} | |
} | |
// convert it to a switch | |
const onButtonClick = (status)=>{ | |
switch (status){ | |
case 1: | |
sendLog('processing') | |
jumpTo('IndexPage') | |
break | |
case 2: | |
case 3: | |
sendLog('fail') | |
jumpTo('FailPage') | |
break | |
case 4: | |
sendLog('success') | |
jumpTo('SuccessPage') | |
break | |
case 5: | |
sendLog('cancel') | |
jumpTo('CancelPage') | |
break | |
default: | |
sendLog('other') | |
jumpTo('Index') | |
break | |
} | |
} | |
// simplify it | |
const actions = { | |
'1': ['processing','IndexPage'], | |
'2': ['fail','FailPage'], | |
'3': ['fail','FailPage'], | |
'4': ['success','SuccessPage'], | |
'5': ['cancel','CancelPage'], | |
'default': ['other','Index'], | |
} | |
const onButtonClick = (status)=>{ | |
let action = actions[status] || actions['default'], | |
logName = action[0], | |
pageName = action[1] | |
sendLog(logName) | |
jumpTo(pageName) | |
} | |
// further simplification | |
const actions = new Map([ | |
[1, ['processing','IndexPage']], | |
[2, ['fail','FailPage']], | |
[3, ['fail','FailPage']], | |
[4, ['success','SuccessPage']], | |
[5, ['cancel','CancelPage']], | |
['default', ['other','Index']] | |
]) | |
const onButtonClick = (status)=>{ | |
let action = actions.get(status) || actions.get('default') | |
sendLog(action[0]) | |
jumpTo(action[1]) | |
} | |
// check the article at the top for more indepth analysis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment