Skip to content

Instantly share code, notes, and snippets.

@FagnerMartinsBrack
Created November 22, 2018 10:43
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save FagnerMartinsBrack/f5c85286c7b8bb50e757ab51d475b67b to your computer and use it in GitHub Desktop.
Save FagnerMartinsBrack/f5c85286c7b8bb50e757ab51d475b67b to your computer and use it in GitHub Desktop.
(Medium) - How TDD Can Prevent Over-Engineering
const greaterThan5000 = { endOfRange: Money('$5000.00'), interestPerDollar: Money('$0.14'), previousInterestPerDollar: Money('$0.09') };
const greaterThan10000 = { endOfRange: Money('$10000.00'), interestPerDollar: Money('$0.21'), previousInterestPerDollar: Money('$0.14') };
+ // You can move this into a configuration file so that changes
+ // in the behavior doesn't require code changes
+ const ranges = [greaterThan2000, greaterThan5000, greaterThan10000];
+
let interestAmount = Money('$0.00');
- if (loanAmount.greaterThan(Money('$2000.00'))) {
- interestAmount = interestAmount.plus(calculateInterest(loanAmount, greaterThan2000));
+ if (loanAmount.greaterThan(ranges[0].endOfRange)) {
+ interestAmount = interestAmount.plus(calculateInterest(loanAmount, ranges[0]));
}
- if (loanAmount.greaterThan(Money('$5000.00'))) {
- interestAmount = interestAmount.plus(calculateInterest(loanAmount, greaterThan5000));
+ if (loanAmount.greaterThan(ranges[1].endOfRange)) {
+ interestAmount = interestAmount.plus(calculateInterest(loanAmount, ranges[1]));
}
- if (loanAmount.greaterThan(Money('$10000.00'))) {
- interestAmount = interestAmount.plus(calculateInterest(loanAmount, greaterThan10000));
+ if (loanAmount.greaterThan(ranges[2].endOfRange)) {
+ interestAmount = interestAmount.plus(calculateInterest(loanAmount, ranges[2]));
}
return interestAmount;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment