Skip to content

Instantly share code, notes, and snippets.

@FiloSottile
Created September 28, 2012 17:58
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save FiloSottile/3801281 to your computer and use it in GitHub Desktop.
Save FiloSottile/3801281 to your computer and use it in GitHub Desktop.
Makefile diff
diff --git a/Makefile b/Makefile
index 21b3469..c960bfa 100644
--- a/Makefile
+++ b/Makefile
@@ -1,4 +1,9 @@
-all: youtube-dl youtube-dl.exe README.md youtube-dl.1 youtube-dl.bash-completion LATEST_VERSION
+all: youtube-dl README.md youtube-dl.1 youtube-dl.bash-completion LATEST_VERSION
+
+# TODO: re-add youtube-dl.exe, and make sure it's 1. safe and 2. doesn't need sudo
+
+clean:
+ rm -f youtube-dl youtube-dl.exe youtube-dl.1 LATEST_VERSION
PREFIX=/usr/local
install: youtube-dl youtube-dl.1 youtube-dl.bash-completion
@@ -6,19 +11,21 @@ install: youtube-dl youtube-dl.1 youtube-dl.bash-completion
install -m 644 --owner root --group root youtube-dl.1 $(PREFIX)/man/man1
install -m 644 --owner root --group root youtube-dl.bash-completion /etc/bash_completion.d/youtube-dl
-.PHONY: all install
+.PHONY: all clean install README.md youtube-dl.bash-completion
+# TODO un-phony README.md and youtube-dl.bash_completion by reading from .in files and generating from them
youtube-dl: youtube_dl/*.py
zip --quiet --junk-paths youtube-dl youtube_dl/*.py
echo '#!/usr/bin/env python' > youtube-dl
cat youtube-dl.zip >> youtube-dl
rm youtube-dl.zip
+ chmod a+x youtube-dl
youtube-dl.exe: youtube_dl/*.py
bash devscripts/wine-py2exe.sh build_exe.py
-README.md: youtube-dl
- @options=$$(COLUMNS=80 ./youtube-dl --help | sed -e '1,/.*General Options.*/ d' -e 's/^\W\{2\}\(\w\)/## \1/') && \
+README.md:
+ @options=$$(COLUMNS=80 python -m youtube_dl --help | sed -e '1,/.*General Options.*/ d' -e 's/^\W\{2\}\(\w\)/## \1/') && \
header=$$(sed -e '/.*# OPTIONS/,$$ d' README.md) && \
footer=$$(sed -e '1,/.*# FAQ/ d' README.md) && \
echo "$${header}" > README.md && \
@@ -37,5 +44,5 @@ youtube-dl.bash-completion: README.md
content=`sed "s/opts=\"[^\"]*\"/opts=\"$${options}\"/g" youtube-dl.bash-completion` && \
echo "$${content}" > youtube-dl.bash-completion
-LATEST_VERSION: youtube-dl
- ./youtube-dl --version > LATEST_VERSION
+LATEST_VERSION:
+ python -m youtube_dl --version > LATEST_VERSION
@FiloSottile
Copy link
Author

@phihag
Hi, sorry but I had to generate a diff to list the changes introduced by the merge commit (GH doesn't offer a tool to do so, right?).
I understand and appreciate all the changes, but I don't get README.md and youtube-dl.bash-completion being .PHONY (what are .in files?) and README.md and LATEST_VERSION not depending on youtube_dl/*.py or youtube_dl/__init__.py.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment