Skip to content

Instantly share code, notes, and snippets.

@FinalAngel
Last active August 29, 2015 14:23
Show Gist options
  • Save FinalAngel/86cd197ec796cd1880be to your computer and use it in GitHub Desktop.
Save FinalAngel/86cd197ec796cd1880be to your computer and use it in GitHub Desktop.
Aldryn Code Review

Setup

  • create github repository: aldryn/project-{NAME}
  • pick a folder and sync your project locally
  • cd into the project
  • run git remote add upstream git@github.com:aldryn/project-{NAME}.git
  • run git push upstream
  • now you should see the data within your repository on GitHub
  • create a master branch
  1. git checkout -b master
  2. git push upstream master
  3. git checkout develop
  4. git branch -d master
  • now we have a master branch setup on remote, you don't need it locally!
  • go to GitHub > Settings and choose "master" as your "Default branch"
  • add the link to the aldryn site to the repos Website section (http://grab.by/Ifw8)

Process

You need to run regularily git push upstream develop in order to update the GitHub repository. Once you are ready with your code, create a pull request from develop to master and get a review.

You should ONLY deploy to live if all code has been reviewed.

The nice catch is, that you will also push changes from other members that are working on the project. So over longer distances all code gets reviewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment