Here was what I think would be a good season of mountaineering for us. High level details on the trips is below, plus some open questions at the bottom.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/main/java/com/pinterest/secor/common/KafkaClient.java:109: throw new RuntimeException("Error fetching offset data. Reason: " + | |
src/main/java/com/pinterest/secor/common/KafkaClient.java:130: throw new RuntimeException("Error fetching offset data. Reason: " + | |
src/main/java/com/pinterest/secor/common/KafkaClient.java:178: throw new RuntimeException("Expected one metadata for topic " + topic + " found " + | |
src/main/java/com/pinterest/secor/common/LogFilePath.java:83: throw new RuntimeException("Unable to find mdt digest.", e); | |
src/main/java/com/pinterest/secor/common/LogFilePath.java:184: throw new RuntimeException(e); | |
src/main/java/com/pinterest/secor/common/SecorConfig.java:50: throw new RuntimeException("Error loading configuration from " + configProperty); | |
src/main/java/com/pinterest/secor/common/SecorConfig.java:440: throw new RuntimeException("secor.file.reader.Delimiter length can not be greater than 1 character"); | |
src/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diff --git a/src/main/java/com/pinterest/secor/common/KafkaClient.java b/src/main/java/com/pinterest/secor/common/KafkaClient.java | |
index 3fe96a2..d7061dc 100644 | |
--- a/src/main/java/com/pinterest/secor/common/KafkaClient.java | |
+++ b/src/main/java/com/pinterest/secor/common/KafkaClient.java | |
@@ -131,8 +131,11 @@ public class KafkaClient { | |
ByteBuffer payload = messageAndOffset.message().payload(); | |
byte[] payloadBytes = new byte[payload.limit()]; | |
payload.get(payloadBytes); | |
+ ByteBuffer key = messageAndOffset.message().key(); | |
+ byte[] keyBytes = new byte[key.limit()]; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
class Foo(object): | |
def bar(func): | |
def inner(self): | |
return func(self) | |
return inner | |
@bar | |
def baz(self): | |
print 'baz' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_______________ | |
< PLATFORM TEAM > | |
--------------- | |
\ ,+*^^*+___+++_ | |
\ ,*^^^^ ) | |
\ _+* ^**+_ | |
\ +^ _ _++*+_+++_, ) | |
_+^^*+_ ( ,+*^ ^ \+_ ) | |
{ ) ( ,( ,_+--+--, ^) ^\ | |
{ (@) } f ,( ,+-^ __*_*_ ^^\_ ^\ ) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from datetime import datetime | |
class Person(object): | |
pass | |
person = Person() | |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
############################################################################### | |
# Needless local variables | |
############################################################################### | |
# bad | |
def foo(): | |
bar = 1 | |
return bar | |
# good |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# bad | |
def foo(): | |
bar = 1 | |
return bar | |
# good | |
def foo(): | |
return 1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How did this get here, I'm no good with computers |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# <pre> | |
# This file is in the public domain, so clarified as of | |
# 2009-05-17 by Arthur David Olson. | |
# This data is by no means authoritative; if you think you know better, | |
# go ahead and edit the file (and please send any changes to | |
# tz@iana.org for general use in the future). | |
# From Paul Eggert (2006-03-22): | |
# A good source for time zone historical data outside the U.S. is |
NewerOlder