Skip to content

Instantly share code, notes, and snippets.

@Haroenv
Last active May 13, 2019 15:21
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save Haroenv/78cee67ca0a32f684c6258ca8f48f038 to your computer and use it in GitHub Desktop.
Save Haroenv/78cee67ca0a32f684c6258ca8f48f038 to your computer and use it in GitHub Desktop.
lodash removal notes: React InstantSearch
  • omit

    • called on searchState
    • likely can use the babel version or spread instead
  • isEqual

    • only three usages
    • deep equal on props
    • used in maps too
  • isEmpty

    • always called on objects
    • can be replaced by objectHasKeys?
  • zipWith

    • used only in server
    • combines arrays grouping per id
    • replaceable by forEach on first array likely
    • similar to merge implem in helper
  • pick

    • done: #2432
    • used in three component
    • can be replaced with destructuring
  • has

    • PR: #2434
    • used only on non-paths
    • can be replaced with && everywhere
    • indexUtils usage already replaced in #2350
  • range

    • only used in pagination
    • easy to make replacement with Array.from or for loop
  • find

    • only called on arrays
    • no native find used yet
    • can be replaced by native find
    • or "polyfill" from the helper
  • fill

    • only used in RatingMenu
    • replaced by native .fill
  • get

    • used in highlight with real path
    • maybe use the version from Vue InstantSearch v1 or InstantSearch.js?
    • indexUtils usage already replaced in #2350
  • isPlainObject

    • only used in util
    • removeEmptyKey
  • difference

    • only used in Configure
    • replace by a filter of the first array
  • isFinite

    • polyfill Number.isFinite instead
    • or use real isFinite, but always pass a number
  • orderBy

    • only used in connectMenu
    • We likely can drop this feature altogether, it seems inconsistent?
    • use version of helper otherwise
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment