-
-
Save IllIllI000/42a8a50cf15476ab64dccc771e3e7326 to your computer and use it in GitHub Desktop.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Raw URL data | |
### [M-01] `block.number` means different things on different L2s | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L139-L139 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L215-L215 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L225-L225 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L266-L266 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L313-L313 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L645-L645 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L646-L646 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L659-L659 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L824-L824 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L892-L892### | |
### [L-01] Missing checks for `address(0)` when assigning values to address state variables | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L134-L134 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L25-L25 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/RegistriesManager.sol#L16-L16 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/RegistriesManager.sol#L17-L17 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L38-L38 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L39-L39 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L315-L315 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L480-L480 | |
### [L-02] Array lengths not checked | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/GovernorOLAS.sol#L45-L51 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/Timelock.sol#L10-L12 | |
### [L-03] For loops in public or external functions should be avoided due to high gas costs and possible DOS | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L98-L108 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L107-L125 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L107-L153 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L105-L125 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L105-L153 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L441-L458 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L495-L511 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L49-L98 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L85-L139 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L85-L113 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L244-L255 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L244-L274 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L356-L357 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L396-L402 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L396-L413 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L435-L448 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L435-L468 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L56-L67 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L788-L808 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L880-L978 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1085-L1104 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1085-L1110 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1085-L1132 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1160-L1174 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1160-L1180 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1160-L1202 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L30-L55 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L66-L92 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L257-L276 | |
### [L-04] External call `recipient` may consume all transaction gas (gas griefing) | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L160-L160 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L160-L160 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L118-L118 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L339-L339 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L406-L406 | |
### [L-05] Missing checks in constructor | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L132-L133 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L20-L23 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/ComponentRegistry.sol#L16-L19 | |
### [L-06] Division before multiplication can lead to precision errors | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L231-L231 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L433-L433 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L487-L487 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L692-L692 | |
### [L-07] Double type casts create complexity within the code | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L194-L194 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L478-L478 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L586-L586 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L190-L190 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L194-L194 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L245-L245 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L599-L599 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L680-L680 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L682-L682 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L713-L713 | |
### [L-08] `external` calls in an un-bounded loop may result in a DOS | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L262-L262 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L708-L708 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L709-L709 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L710-L710 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L716-L716 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L717-L717 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L765-L765 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L810-L810 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1105-L1105 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1123-L1123 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1175-L1175 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1193-L1193 | |
### [L-09] Constant decimal values | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L225-L225 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L225-L225 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L258-L258 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/GenericBondCalculator.sol#L89-L89 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/GenericBondCalculator.sol#L89-L89 | |
### [L-10] `image_data` should be used for raw svg | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L135-L135 | |
### [L-11] Initialization can be front-run | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L264-L264 | |
### [L-12] `internal` Function calls within for loops | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L244-L244 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L373-L373 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L376-L376 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L213-L213 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L739-L739 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L739-L739 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L739-L739 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1139-L1139 | |
### [L-13] Loss of precision | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L101-L101 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L189-L189 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L193-L193 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L225-L225 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L231-L231 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L433-L433 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L487-L487 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L692-L692 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L329-L329 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L675-L675 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1224-L1224 | |
### [L-14] Missing contract-existence checks before low-level calls | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L160-L161 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L160-L161 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L118-L119 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsProxy.sol#L48-L49 | |
### [L-15] NFT doesn't handle hard forks | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L135-L135 | |
### [L-16] Consider using OpenZeppelin’s SafeCast library to prevent unexpected overflows when casting from various type int/uint values | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L364-L364 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L603-L603 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L321-L321 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L350-L350 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L353-L353 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L361-L361 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L528-L528 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L597-L597 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L680-L680 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L704-L704 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L740-L740 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L755-L755 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L60-L60 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L62-L62 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/ComponentRegistry.sol#L44-L44 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L75-L75 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L102-L102 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L185-L185 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L232-L232 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L232-L232 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L232-L232 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L329-L329 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L333-L333 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L333-L333 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L333-L333 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L296-L296 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L301-L301 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L311-L311 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L330-L330 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L331-L331 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L361-L361 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L368-L368 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L369-L369 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L511-L511 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L512-L512 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L519-L519 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L520-L520 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L530-L530 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L536-L536 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L536-L536 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L537-L537 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L543-L543 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L544-L544 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L589-L589 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L590-L590 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L594-L594 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L595-L595 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L596-L596 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L621-L621 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L642-L642 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L660-L660 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L676-L676 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L733-L733 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L741-L741 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L818-L818 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L939-L939 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L940-L940 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L950-L950 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L991-L991 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1025-L1025 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1032-L1032 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1038-L1038 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1044-L1044 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L131-L131 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L198-L198 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L294-L294 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L336-L336 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L404-L404 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L450-L450 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L451-L451 | |
### [L-17] Setters should have initial value check | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L170-L170 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L171-L171 | |
### [L-18] Int casting `block.timestamp` can reduce the lifespan of a contract | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L139-L139 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L190-L190 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L194-L194 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L215-L215 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L241-L241 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L312-L312 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L634-L634 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L334-L334 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1005-L1005 | |
### [L-19] Unsafe downcast | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L139-L139 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L215-L215 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L266-L266 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L313-L313 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L321-L321 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L361-L361 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L528-L528 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L680-L680 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L740-L740 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L755-L755 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L75-L75 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L102-L102 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L203-L203 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L214-L214 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L333-L333 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L296-L296 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L301-L301 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L311-L311 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L330-L330 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L331-L331 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L361-L361 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L368-L368 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L369-L369 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L511-L511 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L512-L512 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L519-L519 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L520-L520 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L536-L536 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L536-L536 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L537-L537 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L543-L543 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L544-L544 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L589-L589 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L590-L590 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L594-L594 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L595-L595 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L596-L596 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L818-L818 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L824-L824 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L939-L939 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L950-L950 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1044-L1044 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L112-L112 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L131-L131 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L294-L294 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L450-L450 | |
### [L-20] Unsafe conversion from unsigned to signed values | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L597-L597 | |
### [L-21] Consider implementing two-step procedure for updating protocol addresses | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L43-L46 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L58-L61 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/BridgedERC20.sol#L30-L34 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L81-L86 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L81-L86 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L154-L157 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericManager.sol#L20-L24 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L37-L41 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L54-L57 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L123-L127 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L143-L147 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L163-L167 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L46-L50 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L64-L68 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L36-L40 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L404-L408 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L423-L427 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L450-L454 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L474-L478 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L137-L141 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L156-L160 | |
### [L-22] Consider using descriptive `constant`s when passing zero as a function argument | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L213-L213 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L233-L233 | |
### [L-23] Functions calling contracts/addresses with transfer hooks are missing reentrancy guards | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L79-L79 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L102-L102 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L98-L98 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L364-L364 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L534-L534 | |
### [L-24] Code does not follow the best practice of check-effects-interaction | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L270-L270 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L303-L303 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L308-L308 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L523-L523 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L264-L264 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L341-L341 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L379-L379 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L300-L300 | |
### [L-25] prevent re-setting a state variable with the same value | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L170-L170 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L171-L171 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L143-L143 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L163-L163 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L64-L64 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L423-L423 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L450-L450 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L474-L474 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L497-L497 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L562-L562 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L156-L156 | |
### [L-26] Missing contract-existence checks before yul `call()` | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsProxy.sol#L56-L58### | |
### [G-01] State variable read in a loop | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L255-L262 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L702-L708 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L702-L716 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L702-L709 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L702-L710 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L702-L709 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L702-L710 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L714-L716 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L808-L810 | |
### [G-02] Multiple accesses of a mapping/array should use a local variable cache | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L319-L319 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L373-L373 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L376-L376 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L476-L476 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L478-L478 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L480-L480 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L525-L525 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L528-L528 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L148-L148 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L212-L212 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L270-L270 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L571-L571 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L585-L585 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L596-L596 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L41-L41 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L41-L41 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L42-L42 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/ComponentRegistry.sol#L30-L30 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/ComponentRegistry.sol#L30-L30 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/ComponentRegistry.sol#L31-L31 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L214-L214 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L215-L215 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L236-L236 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L236-L236 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L237-L237 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L237-L237 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L239-L239 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L239-L239 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L240-L240 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L240-L240 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L141-L141 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L263-L263 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L264-L264 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L266-L266 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L341-L341 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L359-L359 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L360-L360 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L364-L364 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L368-L368 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L369-L369 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L376-L376 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L379-L379 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L404-L404 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L405-L405 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L455-L455 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L457-L457 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L460-L460 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L484-L484 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L73-L73 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L74-L74 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L74-L74 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L657-L657 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L659-L659 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L660-L660 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L662-L662 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L666-L666 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L673-L673 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L674-L674 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L675-L675 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L676-L676 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L678-L678 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L695-L695 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L696-L696 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L697-L697 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L717-L717 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L721-L721 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L730-L730 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L733-L733 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L733-L733 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L739-L739 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L741-L741 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L741-L741 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L744-L744 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L745-L745 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L745-L745 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L751-L751 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L751-L751 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L752-L752 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L761-L761 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L761-L761 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L762-L762 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L765-L765 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L767-L767 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L768-L768 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L811-L811 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L818-L818 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1113-L1113 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1117-L1117 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1117-L1117 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1117-L1117 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1117-L1117 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1118-L1118 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1118-L1118 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1120-L1120 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1123-L1123 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1123-L1123 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1134-L1134 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1134-L1134 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1139-L1139 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1139-L1139 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1141-L1141 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1141-L1141 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1145-L1145 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1145-L1145 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1146-L1146 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1146-L1146 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1148-L1148 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1148-L1148 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1149-L1149 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1149-L1149 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1183-L1183 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1187-L1187 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1187-L1187 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1187-L1187 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1187-L1187 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1188-L1188 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1188-L1188 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1190-L1190 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1193-L1193 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1193-L1193 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1204-L1204 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1204-L1204 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1209-L1209 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1209-L1209 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1211-L1211 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1211-L1211 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1216-L1216 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1216-L1216 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1221-L1221 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1221-L1221 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1222-L1222 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1222-L1222 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1229-L1229 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1229-L1229 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1231-L1231 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1231-L1231 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L225-L225 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L280-L280 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L356-L356 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L500-L500 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L518-L518 | |
### [G-03] Use assembly to calculate hashes to save gas | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L97-L97 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L99-L99 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L101-L101 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L103-L103 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L105-L105 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L103-L103 | |
### [G-04] Use assembly to check for `address(0)` | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L48-L48 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L63-L63 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/BridgedERC20.sol#L37-L37 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L39-L39 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L39-L39 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L39-L39 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L59-L59 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L42-L42 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L42-L42 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L42-L42 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L43-L43 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L63-L63 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L64-L64 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L64-L64 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L89-L89 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L143-L143 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L64-L64 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L64-L64 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L89-L89 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L143-L143 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L144-L144 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L144-L144 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L144-L144 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L160-L160 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L226-L226 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L367-L367 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L460-L460 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L465-L465 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L513-L513 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L513-L513 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L185-L185 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L278-L278 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L293-L293 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L413-L413 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L547-L547 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L568-L568 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L582-L582 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L147-L147 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L147-L147 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericManager.sol#L27-L27 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L44-L44 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L60-L60 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L64-L64 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L61-L61 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L111-L111 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L111-L111 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L111-L111 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L111-L111 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L130-L130 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L150-L150 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L155-L155 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L169-L169 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L439-L439 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L36-L36 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L36-L36 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L53-L53 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L71-L71 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L76-L76 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L43-L43 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L69-L69 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/GenericBondCalculator.sol#L31-L31 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/GenericBondCalculator.sol#L31-L31 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L278-L278 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L283-L283 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L283-L283 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L283-L283 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L283-L283 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L284-L284 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L284-L284 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L284-L284 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L285-L285 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L391-L391 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L411-L411 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L430-L430 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L435-L435 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L440-L440 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L457-L457 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L461-L461 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L465-L465 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L801-L801 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L887-L887 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsProxy.sol#L35-L35 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L100-L100 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L100-L100 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L100-L100 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L100-L100 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L144-L144 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L163-L163 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L168-L168 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L173-L173 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L494-L494 | |
### [G-05] Use assembly in place of `abi.decode` to extract `calldata` values more efficiently | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L278-L278 | |
### [G-06] Optimize Address Storage Value Management with `assembly` | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L36-L36 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L37-L37 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L52-L52 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L67-L67 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/BridgedERC20.sol#L25-L25 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/BridgedERC20.sol#L41-L41 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L43-L43 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L44-L44 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L47-L47 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L48-L48 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L68-L68 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L69-L69 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L93-L93 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L68-L68 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L69-L69 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L93-L93 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L147-L147 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L148-L148 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L150-L150 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L151-L151 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L25-L25 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L48-L48 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L64-L64 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/RegistriesManager.sol#L16-L16 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/RegistriesManager.sol#L17-L17 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L38-L38 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L114-L114 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L115-L115 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L116-L116 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L151-L151 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L156-L156 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L40-L40 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L41-L41 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L72-L72 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L77-L77 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/GenericBondCalculator.sol#L35-L35 | |
### [G-07] Use assembly to emit events | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L53-L53 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L68-L68 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L134-L134 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L150-L150 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/BridgedERC20.sol#L42-L42 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L84-L84 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L107-L107 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L79-L79 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L106-L106 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L74-L74 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L94-L94 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L167-L167 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L74-L74 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L94-L94 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L167-L167 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L165-L165 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L181-L181 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L486-L486 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L531-L531 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L556-L556 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L568-L568 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L367-L367 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L368-L368 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L530-L530 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L531-L531 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericManager.sol#L32-L32 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericManager.sol#L43-L43 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericManager.sol#L54-L54 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L49-L49 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L65-L65 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L90-L90 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L112-L112 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L146-L146 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L135-L135 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L152-L152 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L157-L157 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L171-L171 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L235-L235 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L268-L268 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L342-L342 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L345-L345 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L380-L380 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L58-L58 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L73-L73 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L78-L78 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L112-L112 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L48-L48 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L74-L74 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L399-L399 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L416-L416 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L432-L432 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L437-L437 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L442-L442 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L459-L459 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L463-L463 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L467-L467 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L481-L481 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L551-L551 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L600-L600 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L623-L623 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L643-L643 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L975-L975 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1002-L1002 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1045-L1045 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1065-L1065 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L132-L132 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L149-L149 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L165-L165 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L170-L170 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L175-L175 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L199-L199 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L244-L244 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L295-L295 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L337-L337 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L358-L358 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L405-L405 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L418-L418 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L452-L452 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L501-L501 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L519-L519 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L538-L538 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L549-L549 | |
### [G-08] Avoid contract existence checks by using low level calls | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L79-L79 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L102-L102 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L77-L77 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L98-L98 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L104-L104 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L113-L113 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L545-L545 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L364-L364 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L534-L534 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L157-L157 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L164-L164 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L171-L171 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L178-L178 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L185-L185 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L195-L195 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L197-L197 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L204-L204 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L216-L216 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L224-L224 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L236-L236 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L244-L244 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L250-L250 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L257-L257 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L265-L265 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L266-L266 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L269-L269 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L278-L278 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L286-L286 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L293-L293 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L38-L38 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L60-L60 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/RegistriesManager.sol#L39-L39 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/RegistriesManager.sol#L41-L41 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/RegistriesManager.sol#L52-L52 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/RegistriesManager.sol#L54-L54 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L106-L106 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L221-L221 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L226-L226 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L227-L227 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L262-L262 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L320-L320 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L337-L337 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L390-L390 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L492-L492 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L99-L99 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L104-L104 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/GenericBondCalculator.sol#L64-L64 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L708-L708 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L709-L709 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L710-L710 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L716-L716 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L810-L810 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1063-L1063 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L242-L242 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L298-L298 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L416-L416 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L473-L473 | |
### [G-09] Using bools for storage incurs overhead | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L130-L130 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericManager.sol#L16-L16 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L27-L27 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L225-L225 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L227-L227 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L88-L88 | |
### [G-10] Use byte32 in place of string | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L139-L140 | |
### [G-11] Cache array length outside of loop | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L212-L212 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L273-L273 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L292-L292 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L318-L318 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L340-L340 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L360-L360 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L458-L458 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L511-L511 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L40-L40 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/ComponentRegistry.sol#L29-L29 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L357-L357 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L67-L67 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1110-L1110 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1132-L1132 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1180-L1180 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1202-L1202 | |
### [G-12] State variables should be cached in stack variables rather than re-reading them from storage | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L549-L549 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L710-L710 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L418-L418 | |
### [G-13] Use calldata instead of memory for function arguments that do not get mutated | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L6-L6 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IRegistry.sol#L19-L19 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IRegistry.sol#L38-L38 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L12-L12 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L86-L86 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L88-L88 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L244-L244 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L356-L356 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L56-L56 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L56-L56 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1085-L1085 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1085-L1085 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1160-L1160 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1160-L1160 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/ITokenomics.sol#L21-L21 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/ITokenomics.sol#L22-L22 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/ITokenomics.sol#L42-L42 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/ITokenomics.sol#L42-L42 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/ITreasury.sol#L16-L16 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/ITreasury.sol#L16-L16 | |
### [G-14] With assembly, `.call (bool success)` transfer can be done gas-optimized | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L160-L160 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L160-L160 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L339-L339 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L406-L406 | |
### [G-15] Add `unchecked {}` for subtractions where the operands cannot underflow because of a previous `require()` or `if`-statement | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L77-L77 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L111-L111 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L140-L140 | |
### [G-16] Divisions which do not divide by -X cannot overflow or overflow so such operations can be unchecked to save gas | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L101-L101 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L109-L109 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L225-L225 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L231-L231 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L258-L258 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L433-L433 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L487-L487 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L565-L565 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L664-L664 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L692-L692 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/GenericBondCalculator.sol#L64-L64 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/GenericBondCalculator.sol#L89-L89 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L329-L329 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L367-L367 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L659-L659 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L675-L675 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L726-L726 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L915-L915 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L917-L917 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L918-L918 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L925-L925 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L935-L935 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L951-L951 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1010-L1010 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1019-L1019 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1023-L1023 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1030-L1030 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1054-L1054 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1056-L1056 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1213-L1213 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1224-L1224 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L56-L56 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L93-L93 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L97-L97 | |
### [G-17] Do not calculate constants | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L22-L22 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L101-L101 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L103-L103 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L16-L16 | |
### [G-18] Stack variable cost less while used in emiting event | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L167-L167 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L235-L235 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L268-L268 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L342-L342 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L551-L552 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L418-L418 | |
### [G-19] Superfluous event fields | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L367-L367 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L530-L530 | |
### [G-20] Events should be emitted outside of loops | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L255-L268 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L357-L380 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L67-L74 | |
### [G-21] Empty blocks should be removed or emit something | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L572-L572 | |
### [G-22] Use `ERC721A` instead `ERC721` | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L4-L4 | |
### [G-23] `internal` functions only called once can be inlined to save gas | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L252-L257 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L337-L337 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L593-L593 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L129-L135 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L42-L51 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L193-L202 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L200-L202 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L45-L48 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L687-L687 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L831-L834 | |
### [G-24] Consider merging sequential for loops | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L273-L292 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L340-L360 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L211-L234 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L402-L413 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L448-L468 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L758-L728 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1104-L1110 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1174-L1180 | |
### [G-25] Reduce gas usage by moving to Solidity 0.8.19 or later | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/interfaces/IErrors.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/ComponentRegistry.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericManager.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/RegistriesManager.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IErrorsRegistries.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IRegistry.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/GenericBondCalculator.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsProxy.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IDonatorBlacklist.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IErrorsTokenomics.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IGenericBondCalculator.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IOLAS.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IServiceRegistry.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IToken.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/ITokenomics.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/ITreasury.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IUniswapV2Pair.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IVotingEscrow.sol#L2-L2 | |
### [G-26] Multiple `address`/ID mappings can be combined into a single `mapping` of an `address`/ID to a `struct`, where appropriate | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L112-L112 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L119-L119 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L219-L219 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L221-L221 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L227-L227 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L86-L86 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L88-L88 | |
### [G-27] Optimize names to save gas | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L17-L17 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/BridgedERC20.sol#L18-L18 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L24-L24 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L24-L24 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L5-L5 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L46-L46 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L5-L5 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L46-L46 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/interfaces/IERC20.sol#L5-L5 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L6-L6 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L88-L88 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L86-L86 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L13-L13 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L130-L130 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L9-L9 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericManager.sol#L8-L8 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L9-L9 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L8-L8 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IRegistry.sol#L5-L5 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L5-L5 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L24-L24 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L5-L5 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L50-L50 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L62-L62 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L11-L11 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L20-L20 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/GenericBondCalculator.sol#L20-L20 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L118-L118 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L9-L9 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L39-L39 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IDonatorBlacklist.sol#L5-L5 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IGenericBondCalculator.sol#L5-L5 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IOLAS.sol#L4-L4 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IServiceRegistry.sol#L5-L5 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IToken.sol#L5-L5 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/ITokenomics.sol#L5-L5 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/ITreasury.sol#L5-L5 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IUniswapV2Pair.sol#L5-L5 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IVotingEscrow.sol#L5-L5 | |
### [G-28] Not using the named return variables anywhere in the function is confusing | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L160-L160 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L171-L171 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L491-L491 | |
### [G-29] Constructors can be marked `payable` | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/GovernorOLAS.sol#L16-L29 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L35-L36 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/Timelock.sol#L10-L12 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/BridgedERC20.sol#L24-L25 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L37-L38 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L38-L40 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L62-L63 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L62-L63 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L138-L142 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L132-L133 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L145-L146 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L20-L23 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/ComponentRegistry.sol#L16-L19 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/RegistriesManager.sol#L15-L16 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L35-L36 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L37-L38 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L60-L61 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L106-L107 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L30-L31 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L30-L31 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/GenericBondCalculator.sol#L29-L30 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L232-L234 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsProxy.sol#L33-L34 | |
### [G-30] Using `private` rather than `public` for constants, saves gas | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L22-L22 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L24-L24 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L26-L26 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L53-L53 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L53-L53 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L97-L97 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L99-L99 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L101-L101 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L103-L103 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L105-L105 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L111-L111 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L113-L113 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L115-L115 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L117-L117 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L105-L105 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L136-L136 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L138-L138 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L140-L140 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L13-L13 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/ComponentRegistry.sol#L10-L10 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L33-L33 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L26-L26 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L28-L28 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L53-L53 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L75-L75 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L77-L77 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L11-L11 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L14-L14 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L16-L16 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L18-L18 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L20-L20 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsProxy.sol#L28-L28 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L56-L56 | |
### [G-31] Remove or replace unused state variables | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L217-L217 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L219-L219 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L221-L221 | |
### [G-32] Avoid updating storage when the value hasn't changed to save gas | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L170-L170 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L171-L171 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L143-L143 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L163-L163 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L64-L64 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L423-L423 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L450-L450 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L474-L474 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L497-L497 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L562-L562 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L156-L156 | |
### [G-33] Use shift Right instead of division if possible to save gas | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L565-L565 | |
### [G-34] Use shift Left instead of multiplication if possible to save gas | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L101-L101 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L103-L103 | |
### [G-35] Usage of `uints`/`ints` smaller than 32 bytes (256 bits) incurs overhead | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/BridgedERC20.sol#L24-L24 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L127-L127 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L128-L128 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L127-L127 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L128-L128 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L214-L214 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L177-L177 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L181-L181 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L182-L182 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L217-L217 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L231-L231 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L239-L239 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L593-L593 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L690-L690 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L692-L692 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L698-L698 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L800-L800 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L26-L26 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L26-L26 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L170-L170 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L170-L170 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L328-L328 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L31-L31 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L38-L38 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L39-L39 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L54-L54 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/ComponentRegistry.sol#L27-L27 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/ComponentRegistry.sol#L28-L28 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/ComponentRegistry.sol#L41-L41 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L42-L42 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L193-L193 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L203-L203 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L210-L210 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L211-L211 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L223-L223 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L225-L225 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L229-L229 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L231-L231 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L232-L232 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L234-L234 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L262-L262 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L726-L726 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IUniswapV2Pair.sol#L9-L9 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IUniswapV2Pair.sol#L9-L9 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IUniswapV2Pair.sol#L9-L9 | |
### [G-36] The use of a logical AND in place of double if is slightly less gas efficient in instances where there isn't a corresponding else statement for the given if statement | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L519-L520 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L188-L189 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L192-L193 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L306-L307 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L215-L216 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L235-L236 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L750-L751 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L801-L802 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1138-L1139 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1206-L1209 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L402-L403 | |
### [G-37] State variables only set in the constructor should be declared `immutable` | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L135-L135 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L136-L136 | |
### [G-38] Stack variable used as a cheaper cache for a state variable is only used once | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L739-L739 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1130-L1130 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1200-L1200 | |
### [G-39] Cache state variables outside of loop to avoid reading storage on every iteration | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L262-L262 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L708-L708 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L709-L709 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L709-L709 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L710-L710 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L710-L710 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L716-L716 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L716-L716 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L810-L810 | |
### [G-40] Using `storage` instead of `memory` for structs/arrays saves gas | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L655-L655 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L33-L33 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L70-L70 | |
### [G-41] `>=`/`<=` costs="" less="" gas="" than="" `="">`/`</=`> | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L105-L105 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L120-L120 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L147-L147 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L120-L120 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L147-L147 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L231-L231 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L267-L267 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L312-L312 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L410-L410 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L421-L421 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L147-L147 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L188-L188 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L188-L188 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L192-L192 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L192-L192 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L201-L201 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L211-L211 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L222-L222 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L240-L240 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L247-L247 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L251-L251 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L282-L282 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L285-L285 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L297-L297 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L306-L306 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L306-L306 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L352-L352 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L362-L362 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L387-L387 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L392-L392 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L437-L437 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L441-L441 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L445-L445 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L449-L449 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L469-L469 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L474-L474 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L494-L494 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L498-L498 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L502-L502 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L512-L512 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L562-L562 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L574-L574 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L595-L595 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L598-L598 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L626-L626 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L645-L645 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L654-L654 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L663-L663 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L681-L681 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L699-L699 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L712-L712 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L730-L730 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L196-L196 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L215-L215 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L235-L235 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L41-L41 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L41-L41 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/ComponentRegistry.sol#L30-L30 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/ComponentRegistry.sol#L30-L30 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L73-L73 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L73-L73 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L99-L99 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L53-L53 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L237-L237 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L239-L239 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L252-L252 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L50-L50 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L52-L52 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L76-L76 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L93-L93 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L110-L110 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L195-L195 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L205-L205 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L210-L210 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L216-L216 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L260-L260 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L311-L311 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L323-L323 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L404-L404 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L425-L425 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L483-L483 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L93-L93 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L103-L103 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/GenericBondCalculator.sol#L59-L59 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/GenericBondCalculator.sol#L74-L74 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L296-L296 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L301-L301 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L511-L511 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L519-L519 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L529-L529 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L543-L543 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L576-L576 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L581-L581 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L639-L639 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L656-L656 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L669-L669 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L694-L694 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L695-L695 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L696-L696 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L697-L697 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L734-L734 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L857-L857 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L902-L902 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L902-L902 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L928-L928 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L963-L963 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L989-L989 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L996-L996 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1012-L1012 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1028-L1028 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1041-L1041 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1112-L1112 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1117-L1117 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1138-L1138 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1138-L1138 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1182-L1182 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1187-L1187 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1206-L1206 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1206-L1206 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1210-L1210 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1217-L1217 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L32-L32 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L68-L68 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L121-L121 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L128-L128 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L194-L194 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L228-L228 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L259-L259 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L265-L265 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L291-L291 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L402-L402 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L413-L413 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L441-L441 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L477-L477 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L515-L515 | |
### [G-42] Ternary unnecessary | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L709-L709 | |
### [G-43] Use assembly to validate `msg.sender` | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L44-L44 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L59-L59 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L77-L77 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/BridgedERC20.sol#L32-L32 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/BridgedERC20.sol#L50-L50 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/BridgedERC20.sol#L61-L61 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L84-L84 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L109-L109 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L84-L84 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L107-L107 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L155-L155 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L171-L171 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L448-L448 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L501-L501 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L540-L540 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L543-L543 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L543-L543 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L562-L562 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericManager.sol#L22-L22 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericManager.sol#L38-L38 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericManager.sol#L49-L49 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L39-L39 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L55-L55 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L80-L80 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L59-L59 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L125-L125 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L125-L125 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L145-L145 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L165-L165 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L185-L185 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L246-L246 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L368-L368 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L48-L48 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L66-L66 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L38-L38 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L58-L58 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L386-L386 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L406-L406 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L425-L425 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L452-L452 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L476-L476 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L506-L506 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L571-L571 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L611-L611 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L632-L632 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L795-L795 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1089-L1089 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L139-L139 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L158-L158 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L184-L184 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L214-L214 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L315-L315 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L396-L396 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L435-L435 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L468-L468 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L489-L489 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L509-L509 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L533-L533 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L544-L544 | |
### [G-44] Can make the variable outside the loop to save gas | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L126-L126 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L127-L127 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L128-L128 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L152-L152 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L153-L153 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L160-L160 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L126-L126 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L127-L127 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L128-L128 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L152-L152 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L153-L153 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L160-L160 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L213-L213 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L214-L214 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L236-L236 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L237-L237 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L362-L362 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L364-L364 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L370-L370 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L476-L476 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L518-L518 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L525-L525 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L239-L239 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L565-L565 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L698-L698 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L229-L229 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L231-L231 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L232-L232 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L234-L234 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L256-L256 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L258-L258 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L263-L263 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L359-L359 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L360-L360 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L376-L376 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L706-L706 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L708-L708 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L714-L714 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L716-L716 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L716-L716 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L716-L716 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L716-L716 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L726-L726 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L726-L726 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L728-L728 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L728-L728 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L730-L730 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L730-L730 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L730-L730 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L758-L758 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L758-L758 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L765-L765 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L765-L765 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L765-L765 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1123-L1123 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1134-L1134 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1193-L1193 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1204-L1204 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1209-L1209 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1222-L1222 | |
### [G-45] Consider activating via-ir for deploying | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//hardhat.config.ts#L1-L1 | |
### [G-46] `++i` costs less gas than `i++`, especially when it's used in `for`-loops (`--i`/`i--` too) | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L78-L78 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L244-L244 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L254-L254 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L762-L762 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L768-L768 | |
### [G-47] Unnecessary casting as variable is already of the same type | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L185-L185 | |
### [G-48] Using mappings instead of arrays to avoid length checks save gas | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L119-L119 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L29-L29 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L31-L31 | |
### [G-49] Use `do while` loops instead of `for` loops | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L108-L108 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L125-L125 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L153-L153 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L125-L125 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L153-L153 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L212-L212 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L237-L237 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L273-L273 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L292-L292 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L318-L318 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L340-L340 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L360-L360 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L458-L458 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L511-L511 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L232-L232 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L561-L561 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L693-L693 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L40-L40 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/ComponentRegistry.sol#L29-L29 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L98-L98 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L211-L211 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L227-L227 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L234-L234 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L236-L236 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L262-L262 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L79-L79 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L113-L113 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L139-L139 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L255-L255 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L274-L274 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L357-L357 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L402-L402 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L413-L413 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L448-L448 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L468-L468 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L67-L67 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L702-L702 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L714-L714 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L728-L728 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L758-L758 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L808-L808 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L978-L978 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1104-L1104 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1110-L1110 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1132-L1132 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1174-L1174 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1180-L1180 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1202-L1202 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L55-L55 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L92-L92 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L276-L276 | |
### [G-50] Avoid transferring amounts of zero in order to save gas | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L79-L79 | |
### [G-51] Simple checks for zero `uint` can be done using assembly to save gas | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L92-L92 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L88-L88 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L176-L176 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L470-L470 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L379-L379 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L383-L383 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L427-L427 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L461-L461 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L465-L465 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L490-L490 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L551-L551 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L33-L33 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L85-L85 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L190-L190 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L200-L200 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L295-L295 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L304-L304 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L340-L340 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L363-L363 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L384-L384 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L404-L404 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L720-L720 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L732-L732 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1063-L1063 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1255-L1255 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1265-L1265 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsProxy.sol#L40-L40 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L189-L189 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L277-L277 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L325-L325 | |
### [G-52] `++i`/`i++` should be `unchecked{++i}`/`unchecked{i++}` when it is not possible for them to overflow, as is the case when used in `for`- and `while`-loops | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L108-L108 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L153-L153 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L153-L153 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L237-L237 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L273-L273 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L292-L292 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L318-L318 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L340-L340 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L360-L360 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L458-L458 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L511-L511 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L232-L232 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L561-L561 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L693-L693 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L40-L40 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/ComponentRegistry.sol#L29-L29 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L98-L98 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L211-L211 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L227-L227 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L234-L234 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L236-L236 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L262-L262 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L79-L79 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L113-L113 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L139-L139 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L255-L255 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L274-L274 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L357-L357 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L402-L402 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L413-L413 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L448-L448 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L468-L468 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L67-L67 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L702-L702 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L714-L714 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L728-L728 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L758-L758 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L808-L808 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L978-L978 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1104-L1104 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1110-L1110 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1132-L1132 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1174-L1174 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1180-L1180 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1202-L1202 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L55-L55 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L92-L92 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L276-L276 | |
### [G-53] Do not cache constants to save gas | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L103-L103 | |
### [G-54] Using `private` for constants saves gas | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L22-L22 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L24-L24 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L26-L26 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L28-L28 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L29-L29 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L31-L31 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L29-L29 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L31-L31 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L53-L53 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L55-L55 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L53-L53 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L55-L55 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L97-L97 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L99-L99 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L101-L101 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L103-L103 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L105-L105 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L111-L111 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L113-L113 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L115-L115 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L117-L117 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L120-L120 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L122-L122 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L105-L105 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L108-L108 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L132-L132 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L134-L134 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L136-L136 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L138-L138 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L140-L140 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L11-L11 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L13-L13 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/ComponentRegistry.sol#L10-L10 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L33-L33 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/RegistriesManager.sol#L11-L11 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/RegistriesManager.sol#L13-L13 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L27-L27 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L26-L26 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L28-L28 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L30-L30 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L32-L32 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L53-L53 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L56-L56 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L75-L75 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L77-L77 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L89-L89 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/GenericBondCalculator.sol#L22-L22 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/GenericBondCalculator.sol#L24-L24 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L11-L11 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L14-L14 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L16-L16 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L18-L18 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L20-L20 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsProxy.sol#L28-L28 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L56-L56 | |
### [G-55] Use `s.x = s.x + y` instead of `s.x += y` for memory structs | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L245-L245 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L246-L246 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L280-L280 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L281-L281 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L350-L350 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L597-L597 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L680-L680 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L704-L704 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L708-L708 | |
### [G-56] Redundant state variable getters | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L719-L721 | |
### [G-57] Using `constant`s instead of `enum` can save gas | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L11-L20 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L87-L92 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L12-L15 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IRegistry.sol#L6-L9 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IServiceRegistry.sol#L6-L9 | |
### [G-58] Gas savings can be achieved by changing the model for assigning value to the structure ***123 gas*** | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L139-L139 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L215-L215 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L517-L517 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L232-L232 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L333-L333 | |
### [G-59] address(this) should be cached | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L104-L104 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L100-L100 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L85-L85 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L148-L148 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L85-L85 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L148-L148 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L228-L228 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L321-L321 | |
### [G-60] Use `solady` library where possible to save gas | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L4-L4 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/BridgedERC20.sol#L4-L4 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L4-L4### | |
### [N-01] State variables declarations should have NatSpec descriptions | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L22-L22 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L24-L24 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L26-L26 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L28-L28 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L31-L31 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L33-L33 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L99-L99 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L101-L101 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L103-L103 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L105-L105 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L108-L108 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L110-L110 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L112-L112 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L115-L115 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L117-L117 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L119-L119 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L121-L121 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L124-L124 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L126-L126 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L132-L132 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L134-L134 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L136-L136 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L138-L138 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L140-L140 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L97-L97 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L99-L99 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L101-L101 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L103-L103 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L105-L105 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L108-L108 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L111-L111 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L113-L113 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L115-L115 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L117-L117 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L120-L120 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L122-L122 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L125-L125 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L127-L127 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L130-L130 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L132-L132 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L53-L53 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L55-L55 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L57-L57 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L53-L53 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L55-L55 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L57-L57 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/BridgedERC20.sol#L22-L22 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L29-L29 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L31-L31 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L29-L29 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L31-L31 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L15-L15 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L17-L17 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L19-L19 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L21-L21 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L23-L23 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L33-L33 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L27-L27 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L29-L29 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L31-L31 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L33-L33 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/ComponentRegistry.sol#L10-L10 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L11-L11 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L13-L13 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericManager.sol#L14-L14 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericManager.sol#L16-L16 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/RegistriesManager.sol#L11-L11 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/RegistriesManager.sol#L13-L13 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L26-L26 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L28-L28 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L30-L30 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L32-L32 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L53-L53 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L56-L56 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L75-L75 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L77-L77 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L80-L80 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L83-L83 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L86-L86 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L89-L89 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L91-L91 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L93-L93 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L95-L95 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L98-L98 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L100-L100 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L18-L18 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L20-L20 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L23-L23 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L25-L25 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L25-L25 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L27-L27 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/GenericBondCalculator.sol#L22-L22 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/GenericBondCalculator.sol#L24-L24 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L140-L140 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L143-L143 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L146-L146 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L148-L148 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L151-L151 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L154-L154 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L157-L157 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L161-L161 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L164-L164 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L167-L167 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L170-L170 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L172-L172 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L174-L174 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L177-L177 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L181-L181 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L184-L184 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L187-L187 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L190-L190 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L193-L193 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L196-L196 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L199-L199 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L202-L202 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L205-L205 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L208-L208 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L211-L211 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L214-L214 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L217-L217 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L219-L219 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L221-L221 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L223-L223 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L225-L225 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L227-L227 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L229-L229 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L11-L11 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L14-L14 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L16-L16 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L18-L18 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L20-L20 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsProxy.sol#L28-L28 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L56-L56 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L59-L59 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L62-L62 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L65-L65 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L68-L68 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L71-L71 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L73-L73 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L76-L76 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L78-L78 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L80-L80 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L83-L83 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L86-L86 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L88-L88 | |
### [N-02] Large or complicated code bases should implement invariant tests | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/GovernorOLAS.sol#L1-L1 | |
### [N-03] Assembly blocks should have extensive comments | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L216-L216 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L130-L130 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L130-L130 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L57-L57 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L98-L98 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L375-L375 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L396-L396 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L883-L883 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsProxy.sol#L44-L44 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsProxy.sol#L56-L56 | |
### [N-04] Contract declarations should have NatSpec `@author` annotations | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L85-L86 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L13-L13 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L6-L6 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L4-L5 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L4-L5 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/BridgedERC20.sol#L15-L18 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/interfaces/IERC20.sol#L4-L5 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/interfaces/IErrors.sol#L4-L5 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L5-L5 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L5-L5 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IErrorsRegistries.sol#L4-L5 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IRegistry.sol#L4-L5 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IDonatorBlacklist.sol#L4-L5 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IErrorsTokenomics.sol#L4-L5 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IGenericBondCalculator.sol#L4-L5 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IOLAS.sol#L4-L4 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IServiceRegistry.sol#L4-L5 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IToken.sol#L4-L5 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/ITokenomics.sol#L4-L5 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/ITreasury.sol#L4-L5 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IUniswapV2Pair.sol#L5-L5 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IVotingEscrow.sol#L4-L5 | |
### [N-05] Avoid the use of sensitive terms | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L21-L21 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IErrorsRegistries.sol#L93-L93 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L17-L17 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L20-L20 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L22-L22 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L26-L26 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L27-L27 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L29-L29 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L51-L51 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L52-L52 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L54-L54 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L72-L72 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L73-L73 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L74-L74 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L79-L79 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L81-L81 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L82-L82 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L83-L83 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L5-L5 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L135-L135 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L210-L210 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L211-L211 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L247-L247 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L259-L259 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L274-L274 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L315-L315 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L471-L471 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L472-L472 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L473-L473 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L474-L474 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L480-L480 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L481-L481 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L799-L799 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L800-L800 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L801-L801 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L802-L802 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsProxy.sol#L7-L7 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IDonatorBlacklist.sol#L4-L4 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IDonatorBlacklist.sol#L5-L5 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IDonatorBlacklist.sol#L6-L6 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IDonatorBlacklist.sol#L8-L8 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IDonatorBlacklist.sol#L9-L9 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IErrorsTokenomics.sol#L43-L43 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IErrorsTokenomics.sol#L114-L114 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IErrorsTokenomics.sol#L116-L116 | |
### [N-06] Common functions should be refactored to a common base contract | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L64-L80 | |
### [N-07] Overly complicated arithmetic | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L120-L123 | |
### [N-08] Constant redefined elsewhere | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L134-L134 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L140-L140 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L53-L53 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L29-L29 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L31-L31 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L13-L13 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/RegistriesManager.sol#L11-L11 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L28-L28 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L53-L53 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L77-L77 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/GenericBondCalculator.sol#L22-L22 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L11-L11 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsProxy.sol#L28-L28 | |
### [N-09] Constants in comparisons should appear on the left side | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L105-L105 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L147-L147 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L211-L211 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L232-L232 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L201-L201 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L282-L282 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L285-L285 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L188-L188 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L192-L192 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L247-L247 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L251-L251 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L352-L352 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L362-L362 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L379-L379 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L383-L383 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L427-L427 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L437-L437 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L461-L461 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L465-L465 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L490-L490 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L561-L561 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L551-L551 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L595-L595 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L598-L598 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L663-L663 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L681-L681 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L693-L693 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L712-L712 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L196-L196 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L215-L215 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L235-L235 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L176-L176 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L231-L231 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L259-L259 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L259-L259 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L304-L304 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L304-L304 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L262-L262 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L267-L267 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L286-L286 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L307-L307 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L312-L312 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L347-L347 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L401-L401 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L410-L410 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L418-L418 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L418-L418 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L421-L421 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L470-L470 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L519-L519 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L519-L519 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L519-L519 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L519-L519 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L120-L120 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L120-L120 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L92-L92 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L88-L88 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L73-L73 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L85-L85 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L53-L53 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L69-L69 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L139-L139 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L252-L252 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L33-L33 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L50-L50 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L52-L52 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L76-L76 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L93-L93 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L110-L110 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L190-L190 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L200-L200 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L210-L210 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L260-L260 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L295-L295 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L304-L304 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L340-L340 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L384-L384 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L363-L363 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L404-L404 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L404-L404 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L425-L425 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L483-L483 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L93-L93 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L103-L103 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/GenericBondCalculator.sol#L74-L74 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L543-L543 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L529-L529 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L529-L529 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L576-L576 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L581-L581 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L656-L656 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L669-L669 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L694-L694 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L695-L695 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L696-L696 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L697-L697 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L714-L714 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L720-L720 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L732-L732 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L973-L973 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L987-L987 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1041-L1041 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1028-L1028 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1063-L1063 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L978-L978 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L989-L989 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L996-L996 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1104-L1104 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1112-L1112 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1138-L1138 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1174-L1174 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1182-L1182 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1206-L1206 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1210-L1210 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1217-L1217 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1255-L1255 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1265-L1265 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L32-L32 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L68-L68 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsProxy.sol#L40-L40 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L189-L189 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L259-L259 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L277-L277 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L325-L325 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L330-L330 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L391-L391 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L413-L413 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L402-L402 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L430-L430 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L441-L441 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L515-L515 | |
### [N-10] `const` Variable names don\'t follow the Solidity style guide | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L22-L22 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L24-L24 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L26-L26 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L105-L105 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L136-L136 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L138-L138 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L140-L140 | |
### [N-11] NatSpec documentation for `contract` is missing | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L13-L13 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L6-L6 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L5-L5 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L5-L5 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IOLAS.sol#L4-L4 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IUniswapV2Pair.sol#L5-L5 | |
### [N-12] Contract does not follow the Solidity style guide's suggested layout ordering | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L22-L22 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L99-L99 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L97-L97 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L53-L53 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L53-L53 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/BridgedERC20.sol#L22-L22 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L29-L29 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L29-L29 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L15-L15 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L18-L18 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L27-L27 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericManager.sol#L14-L14 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L75-L75 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L18-L18 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L25-L25 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L140-L140 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L56-L56 | |
### [N-13] Contracts containing only utility functions should be made into libraries | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L9-L9 | |
### [N-14] Control structures do not follow the Solidity Style Guide | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/GovernorOLAS.sol#L45-L45 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/GovernorOLAS.sol#L68-L68 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/GovernorOLAS.sol#L85-L85 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L173-L173 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L330-L330 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L252-L252 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L387-L387 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L441-L441 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L495-L495 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L70-L70 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/RegistriesManager.sol#L27-L27 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L10-L10 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L91-L91 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L85-L85 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IRegistry.sol#L16-L16 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L453-L453 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L264-L264 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L497-L497 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L562-L562 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L788-L788 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L831-L831 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/ITokenomics.sol#L19-L19 | |
### [N-15] Custom error has no error details | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L12-L12 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L108-L108 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L33-L33 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L36-L36 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L55-L55 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L58-L58 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L10-L10 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L10-L10 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/BridgedERC20.sol#L12-L12 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L8-L8 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L11-L11 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L8-L8 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L11-L11 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/interfaces/IErrors.sol#L12-L12 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/interfaces/IErrors.sol#L15-L15 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/interfaces/IErrors.sol#L18-L18 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L16-L16 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L19-L19 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IErrorsRegistries.sol#L17-L17 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IErrorsRegistries.sol#L20-L20 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IErrorsRegistries.sol#L64-L64 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IErrorsRegistries.sol#L67-L67 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IErrorsRegistries.sol#L117-L117 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L10-L10 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/GenericBondCalculator.sol#L14-L14 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsProxy.sol#L5-L5 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsProxy.sol#L8-L8 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsProxy.sol#L11-L11 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IErrorsTokenomics.sol#L17-L17 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IErrorsTokenomics.sol#L29-L29 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IErrorsTokenomics.sol#L32-L32 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IErrorsTokenomics.sol#L103-L103 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IErrorsTokenomics.sol#L119-L119 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IErrorsTokenomics.sol#L122-L122 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IErrorsTokenomics.sol#L125-L125 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IErrorsTokenomics.sol#L128-L128 | |
### [N-16] Consider using `delete` rather than assigning `zero` to clear values | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L283-L283 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L286-L286 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L249-L249 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L253-L253 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L227-L227 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L662-L662 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L678-L678 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1027-L1027 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1146-L1146 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1149-L1149 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1034-L1034 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L992-L992 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L998-L998 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1141-L1141 | |
### [N-17] Dependence on external protocols | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/GenericBondCalculator.sol#L6-L6 | |
### [N-18] `else`-block not required | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L547-L547 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L32-L32 | |
### [N-19] Empty Function Body - Consider commenting why | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L572-L573 | |
### [N-20] Empty bytes check is missing | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/GovernorOLAS.sol#L68-L75 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/GovernorOLAS.sol#L85-L91 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/GovernorOLAS.sol#L105-L107 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L800-L802 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L98-L130 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L292-L293 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L189-L190 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L337-L338 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L579-L581 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L6-L46 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L107-L108 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L105-L106 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L70-L74 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L72-L73 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L109-L110 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/RegistriesManager.sol#L27-L33 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/RegistriesManager.sol#L50-L51 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L10-L24 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L45-L48 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L91-L96 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L85-L90 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IRegistry.sol#L16-L50 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IRegistry.sol#L27-L50 | |
### [N-21] Events are missing sender information | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L53-L53 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L68-L68 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L367-L367 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L368-L368 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L531-L531 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L165-L165 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L181-L181 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L486-L486 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L531-L531 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L568-L568 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L94-L94 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L167-L167 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L94-L94 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L167-L167 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/BridgedERC20.sol#L42-L42 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L84-L84 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L79-L79 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L49-L49 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L65-L65 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L90-L90 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L112-L112 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L146-L146 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericManager.sol#L32-L32 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L135-L135 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L152-L152 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L157-L157 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L171-L171 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L235-L235 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L268-L268 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L342-L342 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L58-L58 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L73-L73 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L78-L78 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L48-L48 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L74-L74 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L399-L399 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L416-L416 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L432-L432 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L437-L437 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L442-L442 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L459-L459 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L463-L463 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L467-L467 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L481-L481 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L551-L552 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L600-L601 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L623-L623 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L643-L643 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L975-L975 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1002-L1002 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1045-L1045 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1065-L1065 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L149-L149 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L165-L165 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L170-L170 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L175-L175 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L199-L199 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L244-L244 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L358-L358 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L337-L337 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L405-L405 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L418-L418 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L452-L452 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L501-L501 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L519-L519 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L538-L538 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L549-L549 | |
### [N-22] Events may be emitted out of order due to reentrancy | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L79-L79 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L106-L106 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L146-L146 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L268-L268 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L345-L345 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L112-L112 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L244-L244 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L418-L418 | |
### [N-23] Defining All External/Public Functions in Contract Interfaces | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L43-L44 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L58-L59 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L91-L92 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L98-L99 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L128-L129 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L145-L146 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L376-L377 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L402-L403 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L411-L412 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L458-L459 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L483-L484 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L510-L511 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L154-L155 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L170-L171 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L387-L399 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L441-L446 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L495-L499 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L539-L540 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L560-L561 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L572-L573 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L579-L581 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L597-L599 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L81-L82 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L81-L82 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L105-L106 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/BridgedERC20.sol#L30-L31 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L50-L51 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L57-L58 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L54-L55 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L61-L62 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L37-L38 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L54-L55 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L78-L79 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L97-L98 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L152-L153 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L160-L162 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericManager.sol#L20-L21 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericManager.sol#L36-L37 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericManager.sol#L47-L48 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L123-L124 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L143-L144 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L163-L164 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L244-L245 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L291-L293 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L356-L357 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L396-L397 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L424-L425 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L435-L437 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L480-L481 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L46-L47 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L64-L65 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L89-L91 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L36-L37 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L56-L57 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L264-L276 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L374-L375 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L384-L385 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L404-L405 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L423-L424 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L450-L451 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L474-L475 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L497-L504 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L562-L569 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1160-L1162 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1237-L1238 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1245-L1246 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1252-L1253 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L30-L31 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L66-L67 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L137-L138 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L156-L157 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L182-L183 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L313-L314 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L466-L467 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L487-L488 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L507-L508 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L531-L532 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L542-L543 | |
### [N-24] Fixed Compiler Version Required for Non-Library/Interface Files | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/GovernorOLAS.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/Timelock.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/BridgedERC20.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/ComponentRegistry.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericManager.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/RegistriesManager.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/GenericBondCalculator.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsProxy.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L2-L2 | |
### [N-25] Floating pragma should be avoided | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/GovernorOLAS.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/Timelock.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/BridgedERC20.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/ComponentRegistry.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericManager.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/RegistriesManager.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/GenericBondCalculator.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsProxy.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L2-L2 | |
### [N-26] NatSpec documentation for `function` is missing | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/GovernorOLAS.sol#L16-L16 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/Timelock.sol#L10-L10 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L35-L35 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L7-L7 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L6-L6 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L6-L6 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/BridgedERC20.sol#L24-L24 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L35-L35 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/RegistriesManager.sol#L15-L15 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IUniswapV2Pair.sol#L6-L6 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IUniswapV2Pair.sol#L7-L7 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IUniswapV2Pair.sol#L8-L8 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IUniswapV2Pair.sol#L9-L9 | |
### [N-27] Function ordering does not follow the Solidity style guide | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/GovernorOLAS.sol#L105-L105 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L118-L118 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L320-L320 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L203-L203 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L7-L7 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L387-L387 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L135-L135 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L49-L49 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L70-L70 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L91-L91 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L788-L788 | |
### [N-28] `address`s shouldn't be hard-coded | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L56-L56 | |
### [N-29] Array indicies should be referenced via `enum`s rather than via numeric literals | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L139-L139 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L351-L351 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L351-L351 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L338-L338 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L694-L694 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L695-L695 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L696-L696 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L697-L697 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L914-L914 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L915-L915 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L917-L917 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L918-L918 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L951-L951 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L963-L963 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1041-L1041 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1052-L1052 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1052-L1052 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1054-L1054 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1056-L1056 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1060-L1060 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1060-L1060 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L690-L690 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L690-L690 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1063-L1063 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1063-L1063 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1100-L1100 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1100-L1100 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1170-L1170 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1170-L1170 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L334-L334 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L707-L707 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L707-L707 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L965-L965 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1043-L1043 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1065-L1065 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L915-L915 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L917-L917 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L918-L918 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L966-L966 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L965-L965 | |
### [N-30] Some if-statement can be converted to a ternary | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L147-L149 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L211-L213 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L222-L226 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L352-L354 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L582-L584 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L626-L628 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L663-L665 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L681-L683 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L712-L714 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L730-L732 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L282-L284 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L285-L287 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L568-L570 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L574-L576 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L598-L600 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L699-L701 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L240-L242 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L247-L250 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L251-L254 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L202-L204 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L300-L302 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L196-L198 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L215-L217 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L235-L237 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L59-L61 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/RegistriesManager.sol#L38-L40 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/RegistriesManager.sol#L51-L53 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L483-L485 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L103-L105 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/GenericBondCalculator.sol#L84-L86 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L511-L513 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L519-L521 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L529-L531 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L536-L538 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L543-L545 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L857-L859 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1255-L1257 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1265-L1267 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L744-L746 | |
### [N-31] Imports could be organized more systematically | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L5-L5 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L5-L5 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L5-L5 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L5-L5 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/RegistriesManager.sol#L5-L5 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L5-L5 | |
### [N-32] Import declarations should import specific identifiers, rather than the whole file | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/Timelock.sol#L4-L4 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L4-L4 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L4-L4 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L5-L5 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L6-L6 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L7-L7 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L4-L4 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L5-L5 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L4-L4 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/ComponentRegistry.sol#L4-L4 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L4-L4 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L5-L5 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericManager.sol#L4-L4 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/RegistriesManager.sol#L4-L4 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/RegistriesManager.sol#L5-L5 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L4-L4 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L5-L5 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L6-L6 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/GenericBondCalculator.sol#L5-L5 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/GenericBondCalculator.sol#L6-L6 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L4-L4 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L5-L5 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L6-L6 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L7-L7 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L8-L8 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L9-L9 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L10-L10 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L11-L11 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L4-L4 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L4-L4 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L5-L5 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L6-L6 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L7-L7 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L8-L8 | |
### [N-33] Interfaces should be defined in separate files from their usage | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L195-L195 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L545-L545 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L113-L113 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L106-L106 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L125-L125 | |
### [N-34] Large numeric literals should use underscores for readability | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L101-L101 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L103-L103 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L108-L108 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L259-L259 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L304-L304 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L519-L519 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L519-L519 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L73-L73 | |
### [N-35] Long functions should be refactored into multiple, smaller, functions | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L173-L173 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L330-L330 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L542-L542 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L252-L252 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L337-L337 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L387-L387 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L441-L441 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L107-L107 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L105-L105 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L49-L49 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L200-L200 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L45-L45 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L85-L85 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L183-L183 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L244-L244 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L291-L291 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L435-L435 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L264-L264 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L497-L497 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L562-L562 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L687-L687 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L831-L831 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L880-L880 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1085-L1085 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1160-L1160 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L257-L257 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L313-L313 | |
### [N-36] Long lines of code | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/GovernorOLAS.sol#L7-L7 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/GovernorOLAS.sol#L9-L9 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/GovernorOLAS.sol#L10-L10 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/GovernorOLAS.sol#L15-L15 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/GovernorOLAS.sol#L42-L42 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L72-L72 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L225-L225 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L258-L258 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L279-L279 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L90-L90 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L91-L91 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L97-L97 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L99-L99 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L101-L101 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L108-L108 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L277-L277 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L453-L453 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L507-L507 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L25-L25 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L26-L26 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L25-L25 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L26-L26 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L25-L25 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L26-L26 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L132-L132 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L86-L86 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L91-L91 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L243-L243 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L49-L49 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L67-L67 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L4-L4 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L9-L9 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L4-L4 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L48-L48 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L83-L83 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IRegistry.sol#L33-L33 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L111-L111 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L162-L162 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L182-L182 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L183-L183 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L243-L243 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L286-L286 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L287-L287 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L289-L289 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L290-L290 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L352-L352 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L353-L353 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L83-L83 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L84-L84 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/GenericBondCalculator.sol#L51-L51 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/GenericBondCalculator.sol#L53-L53 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/GenericBondCalculator.sol#L54-L54 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/GenericBondCalculator.sol#L55-L55 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/GenericBondCalculator.sol#L63-L63 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/GenericBondCalculator.sol#L88-L88 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L115-L115 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L130-L130 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L136-L136 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L166-L166 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L207-L207 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L237-L237 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L251-L251 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L252-L252 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L253-L253 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L255-L255 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L256-L256 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L257-L257 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L258-L258 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L260-L260 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L262-L262 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L324-L324 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L326-L326 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L327-L327 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L328-L328 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L354-L354 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L491-L491 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L492-L492 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L493-L493 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L494-L494 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L496-L496 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L551-L551 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L561-L561 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L608-L608 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L629-L629 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L674-L674 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L687-L687 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L783-L783 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L784-L784 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L785-L785 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L786-L786 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L787-L787 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L866-L866 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L870-L870 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L871-L871 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L872-L872 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L874-L874 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L875-L875 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L879-L879 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L941-L941 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L962-L962 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L971-L971 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1222-L1222 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L67-L67 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsProxy.sol#L27-L27 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L44-L44 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L117-L117 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L210-L210 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L211-L211 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L227-L227 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L248-L248 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L250-L250 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L254-L254 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L290-L290 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L310-L310 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L311-L311 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L382-L382 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L383-L383 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L384-L384 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L462-L462 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L464-L464 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/ITreasury.sol#L31-L31 | |
### [N-37] Missing event and or timelock for critical parameter change | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L26-L26 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L171-L176 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IRegistry.sol#L27-L27 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IRegistry.sol#L44-L44 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/ITreasury.sol#L16-L16 | |
### [N-38] File is missing NatSpec | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IUniswapV2Pair.sol#L0-L0 | |
### [N-39] Mixed usage of `int`/`uint` with `int256`/`uint256` | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L360-L360 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IUniswapV2Pair.sol#L6-L6 | |
### [N-40] Consider using named mappings | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L112-L112 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L117-L117 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L119-L119 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L121-L121 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L130-L130 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L132-L132 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L29-L29 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L31-L31 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L33-L33 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L98-L98 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L100-L100 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L27-L27 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L93-L93 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L217-L217 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L219-L219 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L221-L221 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L223-L223 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L225-L225 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L225-L225 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L227-L227 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L229-L229 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L229-L229 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L86-L86 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L88-L88 | |
### [N-41] Consider using later versions of solidity for more cappabilities | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L2-L2 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/interfaces/IErrors.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/ComponentRegistry.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericManager.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/RegistriesManager.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L2-L2 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IErrorsRegistries.sol#L2-L2 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IRegistry.sol#L2-L2 | |
### [N-42] Events that mark critical parameter changes should contain both the old and the new value | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L18-L18 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L19-L19 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L89-L89 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L90-L90 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L91-L91 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L92-L92 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L48-L48 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L48-L48 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/BridgedERC20.sol#L19-L19 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L10-L10 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L11-L11 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L12-L12 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L10-L10 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericManager.sol#L9-L9 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L63-L63 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L64-L64 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L65-L65 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L66-L66 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L12-L12 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L13-L13 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L14-L14 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L15-L15 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L21-L21 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L119-L119 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L120-L120 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L121-L121 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L122-L122 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L123-L123 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L124-L124 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L125-L125 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L128-L128 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L129-L130 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L131-L131 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L132-L132 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L133-L133 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L134-L134 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L135-L135 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L136-L136 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L137-L137 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L40-L40 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L41-L41 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L42-L42 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L43-L43 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L45-L45 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L50-L50 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L51-L51 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L52-L52 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L53-L53 | |
### [N-43] `override` function arguments that are unused should have the variable name removed or commented out to avoid compiler warnings | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L767-L767 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L772-L772 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L777-L777 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L782-L782 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L788-L788 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L794-L794 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L800-L800 | |
### [N-44] Use of `override` is unnecessary | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L633-L633 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L672-L672 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L752-L752 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L761-L761 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L788-L788 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L794-L794 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L800-L801 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L70-L74 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L72-L72 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L135-L135 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L270-L270 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/ComponentRegistry.sol#L27-L27 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/ComponentRegistry.sol#L41-L41 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L31-L31 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L54-L54 | |
### [N-45] NatSpec `@param` is missing | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L767-L1 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L772-L1 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L777-L1 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L782-L1 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L788-L1 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L794-L1 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L800-L1 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L101-L1 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L104-L1 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L297-L1 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L302-L1 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L307-L1 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L312-L1 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L317-L1 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L322-L1 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L328-L1 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L572-L1 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L106-L1 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L163-L1 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L497-L1 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IServiceRegistry.sol#L21-L1 | |
### [N-46] Functions which are either private or internal should have a preceding _ in their name | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L35-L35 | |
### [N-47] `public` functions not called by the contract should be declared `external` instead | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L745-L745 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L30-L30 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L66-L66 | |
### [N-48] Adding a `return` statement when the function defines a named return variable, is redundant | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L59-L59 | |
### [N-49] Redundant inheritance specifier | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/GovernorOLAS.sol#L15-L15 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/GovernorOLAS.sol#L15-L15 | |
### [N-50] Setters should prevent re-setting of the same value | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L43-L52 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L58-L67 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L154-L164 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L170-L180 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L81-L93 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L81-L93 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/BridgedERC20.sol#L30-L41 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L37-L48 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L54-L64 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L78-L89 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericManager.sol#L20-L31 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L123-L134 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L143-L151 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L143-L156 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L163-L170 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L46-L57 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L64-L72 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L64-L77 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L36-L47 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L404-L415 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L423-L431 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L423-L436 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L423-L441 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L450-L458 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L450-L462 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L450-L466 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L474-L480 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L137-L148 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L156-L164 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L156-L169 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L156-L174 | |
### [N-51] NatSpec `@return` argument is missing | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/GovernorOLAS.sol#L33-L1 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L633-L1 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L767-L1 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L772-L1 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L777-L1 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L782-L1 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L788-L1 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L101-L1 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L104-L1 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L203-L1 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L297-L1 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L302-L1 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L307-L1 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L312-L1 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L317-L1 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L10-L1 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L45-L1 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/ITokenomics.sol#L11-L1 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IVotingEscrow.sol#L8-L1 | |
### [N-52] Consider using `SafeTransferLib.safeTransferETH()` or `Address.sendValue()` for clearer semantic meaning | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L160-L160 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L160-L160 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L118-L118 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L406-L406 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L339-L339 | |
### [N-53] Polymorphic functions make security audits more time-consuming and error-prone | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L156-L156 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L163-L163 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L170-L170 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L177-L177 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L184-L184 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L193-L193 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L203-L203 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L211-L211 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L223-L223 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L231-L231 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L243-L243 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L249-L249 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L256-L256 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L263-L263 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L277-L277 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L285-L285 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L292-L292 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L312-L312 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L317-L317 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L107-L107 | |
### [N-54] State variables should have `Natspec` comments | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L22-L22 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L24-L24 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L26-L26 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L28-L28 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L31-L31 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L33-L33 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L99-L99 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L101-L101 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L103-L103 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L105-L105 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L108-L108 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L110-L110 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L112-L112 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L115-L115 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L117-L117 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L119-L119 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L121-L121 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L124-L124 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L126-L126 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L132-L132 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L134-L134 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L136-L136 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L138-L138 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L140-L140 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L97-L97 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L99-L99 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L101-L101 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L103-L103 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L105-L105 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L108-L108 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L111-L111 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L113-L113 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L115-L115 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L117-L117 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L120-L120 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L122-L122 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L125-L125 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L127-L127 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L130-L130 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L132-L132 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L53-L53 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L55-L55 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L57-L57 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L53-L53 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L55-L55 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L57-L57 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/BridgedERC20.sol#L22-L22 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L29-L29 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L31-L31 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L29-L29 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L31-L31 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L15-L15 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L17-L17 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L19-L19 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L21-L21 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L23-L23 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L33-L33 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L27-L27 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L29-L29 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L31-L31 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L33-L33 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/ComponentRegistry.sol#L10-L10 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L11-L11 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L13-L13 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericManager.sol#L14-L14 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericManager.sol#L16-L16 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/RegistriesManager.sol#L11-L11 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/RegistriesManager.sol#L13-L13 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L26-L26 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L28-L28 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L30-L30 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L32-L32 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L53-L53 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L56-L56 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L75-L75 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L77-L77 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L80-L80 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L83-L83 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L86-L86 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L89-L89 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L91-L91 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L93-L93 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L95-L95 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L98-L98 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L100-L100 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L18-L18 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L20-L20 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L23-L23 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L25-L25 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L25-L25 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L27-L27 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/GenericBondCalculator.sol#L22-L22 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/GenericBondCalculator.sol#L24-L24 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L140-L140 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L143-L143 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L146-L146 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L148-L148 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L151-L151 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L154-L154 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L157-L157 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L161-L161 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L164-L164 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L167-L167 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L170-L170 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L172-L172 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L174-L174 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L177-L177 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L181-L181 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L184-L184 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L187-L187 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L190-L190 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L193-L193 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L196-L196 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L199-L199 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L202-L202 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L205-L205 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L208-L208 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L211-L211 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L214-L214 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L217-L217 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L219-L219 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L221-L221 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L223-L223 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L225-L225 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L227-L227 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L229-L229 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L11-L11 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L14-L14 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L16-L16 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L18-L18 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L20-L20 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsProxy.sol#L28-L28 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L56-L56 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L59-L59 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L62-L62 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L65-L65 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L68-L68 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L71-L71 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L73-L73 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L76-L76 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L78-L78 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L80-L80 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L83-L83 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L86-L86 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L88-L88 | |
### [N-55] Numeric values having to do with time should use time units for readability | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L101-L101 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L103-L103 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L433-L433 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L487-L487 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L664-L664 | |
### [N-56] Contract declarations should have NatSpec `@title` annotations | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L85-L86 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L13-L13 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L6-L6 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L4-L5 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L4-L5 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/interfaces/IERC20.sol#L4-L5 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/interfaces/IErrors.sol#L4-L5 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L5-L5 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L5-L5 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IErrorsRegistries.sol#L4-L5 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IRegistry.sol#L4-L5 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IDonatorBlacklist.sol#L4-L5 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IErrorsTokenomics.sol#L4-L5 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IGenericBondCalculator.sol#L4-L5 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IOLAS.sol#L4-L4 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IServiceRegistry.sol#L4-L5 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IToken.sol#L4-L5 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/ITokenomics.sol#L4-L5 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/ITreasury.sol#L4-L5 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IUniswapV2Pair.sol#L5-L5 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IVotingEscrow.sol#L4-L5 | |
### [N-57] Top level pragma declarations should be separated by two blank lines | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/GovernorOLAS.sol#L2-L4 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/Timelock.sol#L2-L4 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L2-L4 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L2-L4 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L2-L4 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L4-L6 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/BridgedERC20.sol#L2-L4 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L2-L4 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L2-L4 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L2-L4 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L2-L4 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/ComponentRegistry.sol#L2-L4 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L2-L4 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericManager.sol#L2-L4 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/RegistriesManager.sol#L2-L4 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L2-L4 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L2-L4 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/GenericBondCalculator.sol#L2-L4 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L2-L4 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L2-L4 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L2-L4 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IOLAS.sol#L2-L4 | |
### [N-58] uint variables should have the bit size defined explicitly | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IUniswapV2Pair.sol#L6-L6 | |
### [N-59] Uncommented fields in a struct | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L61-L67 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L5-L11 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L43-L56 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L60-L86 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L99-L113 | |
### [N-60] Event is missing `indexed` fields | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L94-L94 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L95-L95 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L96-L96 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L90-L90 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L91-L91 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L47-L47 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L49-L49 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L47-L47 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L49-L49 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L12-L12 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L9-L9 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L10-L10 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L69-L69 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L70-L70 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L72-L72 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L15-L15 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L22-L22 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L123-L123 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L124-L124 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L125-L125 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L126-L126 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L129-L129 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L136-L136 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L44-L44 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L45-L45 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L46-L46 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L49-L49 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L50-L50 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L53-L53 | |
### [N-61] Unused `error` definition | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L47-L47 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IErrorsRegistries.sol#L17-L17 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IErrorsRegistries.sol#L24-L24 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IErrorsRegistries.sol#L47-L47 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IErrorsRegistries.sol#L51-L51 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IErrorsRegistries.sol#L56-L56 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IErrorsRegistries.sol#L61-L61 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IErrorsRegistries.sol#L76-L76 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IErrorsRegistries.sol#L80-L80 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IErrorsRegistries.sol#L85-L85 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IErrorsRegistries.sol#L91-L91 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IErrorsRegistries.sol#L101-L101 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IErrorsRegistries.sol#L107-L107 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IErrorsTokenomics.sol#L50-L50 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IErrorsTokenomics.sol#L61-L61 | |
### [N-62] Unused `event` definition | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L123-L123 | |
### [N-63] Unused Import | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L4-L4 | |
### [N-64] Missing upgradability functionality | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/GovernorOLAS.sol#L1-L1 | |
### [N-65] Use `abi.encodeCall()` instead of `abi.encodeSignature()`/`abi.encodeSelector()` | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L102-L102 | |
### [N-66] Use `string.concat()` on strings instead of `abi.encodePacked()` for clearer semantic meaning | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L139-L139 | |
### [N-67] Constants should be defined rather than using magic numbers | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L35-L35 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L105-L105 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L107-L107 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L109-L109 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L232-L232 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L561-L561 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L693-L693 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L194-L194 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L196-L196 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L259-L259 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L259-L259 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L304-L304 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L304-L304 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L274-L274 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L341-L341 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L370-L370 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L478-L478 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L480-L480 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L519-L519 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L527-L527 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L519-L519 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L519-L519 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L519-L519 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L586-L586 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L588-L588 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L605-L605 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L110-L110 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L111-L111 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L112-L112 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L113-L113 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L114-L114 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L115-L115 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L116-L116 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L117-L117 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L118-L118 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L119-L119 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L120-L120 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L123-L123 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L111-L111 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L113-L113 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L115-L115 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L117-L117 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L118-L118 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L119-L119 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L123-L123 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L122-L122 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L122-L122 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L140-L140 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L360-L360 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L293-L293 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L348-L348 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L349-L349 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L362-L362 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L363-L363 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L367-L367 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L529-L529 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L576-L576 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L581-L581 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L577-L577 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L582-L582 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L592-L592 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L674-L674 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L659-L659 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L693-L693 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L852-L852 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L913-L913 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L915-L915 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L917-L917 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L918-L918 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L951-L951 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1054-L1054 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1056-L1056 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L942-L942 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1023-L1023 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1030-L1030 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1222-L1222 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1213-L1213 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L32-L32 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L48-L48 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L34-L34 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L35-L35 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L36-L36 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L37-L37 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L38-L38 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L39-L39 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L40-L40 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L41-L41 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L42-L42 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L56-L56 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L68-L68 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L85-L85 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L71-L71 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L72-L72 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L73-L73 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L74-L74 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L75-L75 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L76-L76 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L77-L77 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L78-L78 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L79-L79 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L80-L80 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L97-L97 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L93-L93 | |
### [N-68] Use the latest solidity (prior to 0.8.20 if on L2s) for deployment | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L2-L2 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L2-L2 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L2-L2 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L2-L2 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/interfaces/IErrors.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/ComponentRegistry.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericManager.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/RegistriesManager.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L2-L2 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IErrorsRegistries.sol#L2-L2 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IRegistry.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/GenericBondCalculator.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsProxy.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L2-L2 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IDonatorBlacklist.sol#L2-L2 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IErrorsTokenomics.sol#L2-L2 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IGenericBondCalculator.sol#L2-L2 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IOLAS.sol#L2-L2 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IServiceRegistry.sol#L2-L2 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IToken.sol#L2-L2 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/ITokenomics.sol#L2-L2 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/ITreasury.sol#L2-L2 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IUniswapV2Pair.sol#L2-L2 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IVotingEscrow.sol#L2-L2 | |
### [N-69] Use a single file for system wide constants | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L22-L22 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L99-L99 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L136-L136 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L97-L97 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L53-L53 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L53-L53 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L33-L33 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/ComponentRegistry.sol#L10-L10 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L13-L13 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L26-L26 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L53-L53 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L75-L75 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L11-L11 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsProxy.sol#L28-L28 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L56-L56 | |
### [N-70] Consider using SMTChecker | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/GovernorOLAS.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/Timelock.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/BridgedERC20.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/interfaces/IERC20.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/interfaces/IErrors.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/ComponentRegistry.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericManager.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/RegistriesManager.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IErrorsRegistries.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IRegistry.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/GenericBondCalculator.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsProxy.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IDonatorBlacklist.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IErrorsTokenomics.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IGenericBondCalculator.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IOLAS.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IServiceRegistry.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IToken.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/ITokenomics.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/ITreasury.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IUniswapV2Pair.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IVotingEscrow.sol#L2-L2 | |
### [N-71] Variable name must be in mixedCase | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L221-L221 | |
### [N-72] Whitespace in Expressions | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L624-L625 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L674-L675 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L728-L729 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L278-L279 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L351-L352 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L351-L352 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L355-L356 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L355-L356 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L160-L161 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L160-L161 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L60-L61 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L118-L119 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/GenericBondCalculator.sol#L80-L81 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsProxy.sol#L48-L49 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L339-L340 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L406-L407 | |
### [N-73] Complex function controle flow | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L173-L317 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L542-L587 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L252-L332 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L387-L432 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L107-L168 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L105-L168 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L85-L144 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L183-L236 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L497-L553 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L687-L774 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L880-L1074 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1085-L1151 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1160-L1233 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L257-L301 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L313-L371 | |
### [N-74] Consider bounding input array length | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L441-L487 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L441-L487 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L441-L487 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L441-L487 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L495-L532 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L495-L532 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L495-L532 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L85-L144 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L244-L277 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L356-L391 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L56-L77 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L56-L77 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L788-L825 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1085-L1151 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1085-L1151 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1160-L1233 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1160-L1233 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L257-L301 | |
### [N-75] A function which defines named returns in it's declaration doesn't need to use return | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L160-L165 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L171-L176 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L491-L493 | |
### [N-76] Contract declarations should have NatSpec `@dev` annotations | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L14-L17 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L85-L86 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L13-L13 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L127-L130 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L6-L6 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L85-L88 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L43-L46 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L43-L46 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L20-L24 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L20-L24 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L7-L9 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L6-L8 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/ComponentRegistry.sol#L6-L8 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L7-L9 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericManager.sol#L6-L8 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/RegistriesManager.sol#L7-L9 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L5-L5 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L22-L24 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L5-L5 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L48-L50 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L59-L62 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L8-L11 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L17-L20 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L115-L118 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L6-L9 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsProxy.sol#L23-L26 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L33-L39 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IOLAS.sol#L4-L4 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IUniswapV2Pair.sol#L5-L5 | |
### [N-77] Contract should expose an `interface` | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L43-L43 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L58-L58 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L91-L91 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L98-L98 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L128-L128 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L145-L145 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L376-L376 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L402-L402 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L411-L411 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L458-L458 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L483-L483 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L510-L510 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L154-L154 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L170-L170 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L387-L387 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L441-L441 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L495-L495 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L539-L539 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L560-L560 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L572-L572 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L579-L579 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L597-L597 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L81-L81 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L81-L81 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L105-L105 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/BridgedERC20.sol#L30-L30 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L50-L50 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L57-L57 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L54-L54 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L61-L61 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L37-L37 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L54-L54 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L78-L78 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L97-L97 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L152-L152 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L160-L160 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericManager.sol#L20-L20 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericManager.sol#L36-L36 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericManager.sol#L47-L47 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L123-L123 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L143-L143 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L163-L163 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L244-L244 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L291-L291 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L356-L356 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L396-L396 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L424-L424 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L435-L435 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L480-L480 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L46-L46 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L64-L64 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L89-L89 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L36-L36 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L56-L56 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L264-L264 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L374-L374 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L384-L384 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L404-L404 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L423-L423 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L450-L450 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L474-L474 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L497-L497 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L562-L562 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1160-L1160 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1237-L1237 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1245-L1245 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1252-L1252 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L30-L30 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L66-L66 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L137-L137 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L156-L156 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L182-L182 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L313-L313 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L466-L466 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L487-L487 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L507-L507 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L531-L531 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L542-L542 | |
### [N-78] Named imports of parent contracts are missing | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L46-L46 | |
### [N-79] Contract declarations should have NatSpec `@notice` annotations | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/GovernorOLAS.sol#L12-L15 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/Timelock.sol#L6-L9 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L14-L17 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L13-L13 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L127-L130 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L6-L6 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L85-L88 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L4-L5 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L43-L46 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L4-L5 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L43-L46 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/BridgedERC20.sol#L15-L18 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L20-L24 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L20-L24 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/interfaces/IERC20.sol#L4-L5 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/interfaces/IErrors.sol#L4-L5 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L7-L9 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L6-L8 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/ComponentRegistry.sol#L6-L8 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L7-L9 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericManager.sol#L6-L8 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/RegistriesManager.sol#L7-L9 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L5-L5 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L22-L24 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L5-L5 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L48-L50 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IErrorsRegistries.sol#L4-L5 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IRegistry.sol#L4-L5 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L59-L62 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L8-L11 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L17-L20 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/GenericBondCalculator.sol#L16-L20 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L115-L118 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L6-L9 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsProxy.sol#L23-L26 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L33-L39 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IDonatorBlacklist.sol#L4-L5 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IErrorsTokenomics.sol#L4-L5 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IGenericBondCalculator.sol#L4-L5 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IOLAS.sol#L4-L4 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IServiceRegistry.sol#L4-L5 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IToken.sol#L4-L5 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/ITokenomics.sol#L4-L5 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/ITreasury.sol#L4-L5 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IUniswapV2Pair.sol#L5-L5 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IVotingEscrow.sol#L4-L5 | |
### [N-80] Do not use UNDERSCORE in `struct` elements names | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/ComponentRegistry.sol#L29-L34 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L40-L45 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L714-L772 | |
### [N-81] `contract` names should use CamelCase | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L86-L86 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L130-L130 | |
### [N-82] `event` declarations should have NatSpec descriptions | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L18-L18 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L19-L19 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L94-L94 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L95-L95 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L96-L96 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L89-L89 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L90-L90 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L91-L91 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L92-L92 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L93-L93 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L94-L94 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L47-L47 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L48-L48 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L49-L49 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L47-L47 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L48-L48 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L49-L49 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/BridgedERC20.sol#L19-L19 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L25-L25 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L26-L26 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L25-L25 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L26-L26 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L10-L10 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L11-L11 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L12-L12 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L9-L9 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L10-L10 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericManager.sol#L9-L9 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericManager.sol#L10-L10 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericManager.sol#L11-L11 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L63-L63 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L64-L64 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L65-L65 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L66-L66 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L67-L67 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L69-L69 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L70-L70 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L72-L72 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L12-L12 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L13-L13 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L14-L14 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L15-L15 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L21-L21 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L22-L22 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L119-L119 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L120-L120 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L121-L121 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L122-L122 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L123-L123 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L124-L124 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L125-L125 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L126-L126 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L128-L128 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L129-L129 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L131-L131 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L132-L132 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L133-L133 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L134-L134 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L135-L135 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L136-L136 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L137-L137 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L40-L40 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L41-L41 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L42-L42 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L43-L43 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L44-L44 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L45-L45 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L46-L46 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L47-L47 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L48-L48 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L49-L49 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L50-L50 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L51-L51 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L52-L52 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L53-L53 | |
### [N-83] Events should use parameters to convey information | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L94-L94 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L51-L51 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L52-L52 | |
### [N-84] `function` names should use lowerCamelCase | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/GovernorOLAS.sol#L16-L16 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/Timelock.sol#L10-L10 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L35-L35 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L132-L132 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L145-L145 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L334-L334 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L138-L138 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L62-L62 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L73-L73 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L62-L62 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L73-L73 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/BridgedERC20.sol#L24-L24 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L37-L37 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L38-L38 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/ComponentRegistry.sol#L16-L16 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L20-L20 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/RegistriesManager.sol#L15-L15 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L37-L37 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L60-L60 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L106-L106 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L30-L30 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L30-L30 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/GenericBondCalculator.sol#L29-L29 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L232-L232 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsProxy.sol#L33-L33 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsProxy.sol#L55-L55 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L95-L95 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L120-L120 | |
### [N-85] Expressions for constant values should use `immutable` rather than `constant` | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L22-L22 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L101-L101 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L103-L103 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L97-L97 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L99-L99 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L101-L101 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L103-L103 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L105-L105 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L16-L16 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L56-L56 | |
### [N-86] Consider splitting long calculations | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L225-L225 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L258-L258 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L120-L123 | |
### [N-87] Consider using `AccessControlDefaultAdminRules` rather than `AccessControl` | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/Timelock.sol#L9-L9 | |
### [N-88] `immutable` variable names don\'t follow the Solidity style guide | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L28-L28 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L108-L108 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L132-L132 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L134-L134 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L120-L120 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L122-L122 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L55-L55 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L55-L55 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L29-L29 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L31-L31 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L29-L29 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L31-L31 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L27-L27 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L11-L11 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/RegistriesManager.sol#L11-L11 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/RegistriesManager.sol#L13-L13 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L30-L30 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L32-L32 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L56-L56 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L89-L89 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/GenericBondCalculator.sol#L22-L22 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/GenericBondCalculator.sol#L24-L24 | |
### [N-89] `private`/`public` function name should start with underscore | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L35-L35 | |
### [N-90] Assembly block creates dirty bits | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L216-L223 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L130-L140 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L130-L140 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L57-L73 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L98-L100 | |
### [N-91] Add inline comments for unnamed parameters | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L297-L297 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L302-L302 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L307-L307 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L312-L312 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L317-L317 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L322-L322 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L328-L328 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L387-L387 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L572-L572 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/ComponentRegistry.sol#L41-L41 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L31-L31 | |
### [N-92] Function state mutability can be restricted to pure | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L572-L572 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L374-L374 | |
### [N-93] Use the latest Solidity version for better security | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/GovernorOLAS.sol#L2-L2 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/Timelock.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L2-L2 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L2-L2 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L2-L2 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L2-L2 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/interfaces/IErrors.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/ComponentRegistry.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericManager.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/RegistriesManager.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L2-L2 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IErrorsRegistries.sol#L2-L2 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IRegistry.sol#L2-L2 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/GenericBondCalculator.sol#L2-L2 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L2-L2 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsProxy.sol#L2-L2 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L2-L2 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IDonatorBlacklist.sol#L2-L2 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IErrorsTokenomics.sol#L2-L2 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IGenericBondCalculator.sol#L2-L2 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IOLAS.sol#L2-L2 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IServiceRegistry.sol#L2-L2 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IToken.sol#L2-L2 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/ITokenomics.sol#L2-L2 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/ITreasury.sol#L2-L2 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IUniswapV2Pair.sol#L2-L2 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IVotingEscrow.sol#L2-L2 | |
### [N-94] Consider adding formal verification proofs | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/GovernorOLAS.sol#L1-L1 | |
### [N-95] Missing zero address check in functions with address parameters | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L128-L129 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L145-L146 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L132-L133 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L164-L165 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L173-L178 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L767-L768 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L772-L773 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L777-L778 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L800-L802 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L21-L130 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L26-L130 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L43-L130 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L49-L130 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L60-L130 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L79-L130 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L84-L130 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L93-L130 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L98-L130 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L297-L298 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L302-L303 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L307-L308 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L328-L329 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L7-L11 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L387-L399 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L572-L573 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L6-L46 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L70-L74 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/interfaces/IERC20.sol#L25-L49 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/interfaces/IERC20.sol#L31-L49 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/interfaces/IERC20.sol#L38-L49 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/interfaces/IERC20.sol#L43-L49 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/interfaces/IERC20.sol#L47-L49 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L129-L135 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L42-L51 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L152-L153 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L160-L162 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L171-L173 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L193-L202 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L270-L271 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/ComponentRegistry.sol#L16-L19 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L20-L23 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L31-L32 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L10-L24 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L45-L48 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IRegistry.sol#L16-L50 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IRegistry.sol#L27-L50 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IRegistry.sol#L33-L50 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IRegistry.sol#L38-L50 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IRegistry.sol#L44-L50 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L244-L245 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1245-L1246 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1252-L1253 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IGenericBondCalculator.sol#L10-L18 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IOLAS.sol#L8-L14 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IServiceRegistry.sol#L14-L32 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IServiceRegistry.sol#L21-L32 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IToken.sol#L14-L45 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IToken.sol#L24-L45 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IToken.sol#L36-L45 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IToken.sol#L43-L45 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/ITokenomics.sol#L19-L53 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/ITokenomics.sol#L30-L53 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/ITokenomics.sol#L34-L53 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/ITokenomics.sol#L42-L53 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/ITreasury.sol#L11-L38 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/ITreasury.sol#L16-L38 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/ITreasury.sol#L31-L38 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/ITreasury.sol#L36-L38 | |
### [N-96] Use a struct to encapsulate multiple function parameters | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/GovernorOLAS.sol#L16-L29 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L800-L804 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L328-L331 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L387-L432 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L264-L370 | |
### [N-97] Do not cache `constants` | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L103-L103 | |
### [N-98] Function state mutability can be restricted to `view` | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L572-L572 | |
### [N-99] Do not cache `immutable` | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L103-L103 | |
### [N-100] Missing NatSpec `@dev` from event declaration | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L18-L18 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L19-L19 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L94-L94 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L95-L95 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L96-L96 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L89-L89 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L90-L90 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L91-L91 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L92-L92 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L93-L93 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L94-L94 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L47-L47 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L48-L48 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L49-L49 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L47-L47 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L48-L48 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L49-L49 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/BridgedERC20.sol#L19-L19 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L25-L25 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L26-L26 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L25-L25 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L26-L26 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L10-L10 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L11-L11 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L12-L12 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L9-L9 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L10-L10 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericManager.sol#L9-L9 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericManager.sol#L10-L10 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericManager.sol#L11-L11 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L63-L63 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L64-L64 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L65-L65 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L66-L66 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L67-L67 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L69-L69 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L70-L70 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L72-L72 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L12-L12 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L13-L13 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L14-L14 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L15-L15 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L21-L21 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L22-L22 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L119-L119 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L120-L120 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L121-L121 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L122-L122 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L123-L123 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L124-L124 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L125-L125 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L126-L126 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L128-L128 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L129-L129 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L131-L131 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L132-L132 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L133-L133 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L134-L134 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L135-L135 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L136-L136 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L137-L137 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L40-L40 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L41-L41 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L42-L42 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L43-L43 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L44-L44 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L45-L45 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L46-L46 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L47-L47 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L48-L48 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L49-L49 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L50-L50 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L51-L51 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L52-L52 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L53-L53 | |
### [N-101] Missing NatSpec `@notice` from event declaration | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L18-L18 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L19-L19 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L94-L94 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L95-L95 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L96-L96 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L89-L89 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L90-L90 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L91-L91 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L92-L92 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L93-L93 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L94-L94 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L47-L47 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L48-L48 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L49-L49 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L47-L47 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L48-L48 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L49-L49 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/BridgedERC20.sol#L19-L19 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L25-L25 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L26-L26 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L25-L25 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L26-L26 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L10-L10 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L11-L11 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L12-L12 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L9-L9 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L10-L10 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericManager.sol#L9-L9 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericManager.sol#L10-L10 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericManager.sol#L11-L11 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L63-L63 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L64-L64 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L65-L65 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L66-L66 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L67-L67 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L69-L69 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L70-L70 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L72-L72 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L12-L12 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L13-L13 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L14-L14 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L15-L15 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L21-L21 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L22-L22 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L119-L119 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L120-L120 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L121-L121 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L122-L122 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L123-L123 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L124-L124 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L125-L125 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L126-L126 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L128-L128 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L129-L129 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L131-L131 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L132-L132 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L133-L133 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L134-L134 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L135-L135 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L136-L136 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L137-L137 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L40-L40 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L41-L41 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L42-L42 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L43-L43 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L44-L44 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L45-L45 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L46-L46 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L47-L47 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L48-L48 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L49-L49 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L50-L50 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L51-L51 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L52-L52 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L53-L53 | |
### [N-102] Missing NatSpec `@notice` from function declaration | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/GovernorOLAS.sol#L16-L16 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/GovernorOLAS.sol#L31-L32 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/GovernorOLAS.sol#L39-L44 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/GovernorOLAS.sol#L55-L56 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/GovernorOLAS.sol#L62-L67 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/GovernorOLAS.sol#L79-L84 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/GovernorOLAS.sol#L95-L96 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/GovernorOLAS.sol#L102-L104 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/Timelock.sol#L10-L10 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L35-L35 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L41-L42 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L56-L57 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L96-L97 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L116-L117 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L128-L131 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L142-L144 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L152-L154 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L168-L172 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L319-L319 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L324-L329 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L371-L375 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L399-L401 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L456-L457 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L481-L482 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L509-L509 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L537-L541 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L589-L592 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L604-L606 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L611-L613 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L618-L621 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L631-L632 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L668-L671 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L686-L689 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L717-L718 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L723-L725 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L735-L737 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L743-L744 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L749-L751 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L758-L760 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L766-L766 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L771-L771 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L776-L776 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L781-L781 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L787-L787 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L793-L793 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L799-L799 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L14-L15 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L18-L20 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L23-L25 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L28-L30 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L33-L35 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L45-L48 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L51-L53 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L56-L59 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L62-L64 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L67-L69 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L72-L73 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L76-L78 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L81-L83 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L86-L87 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L90-L92 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L95-L97 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L100-L100 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L103-L103 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L142-L144 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L154-L155 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L160-L162 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L167-L169 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L174-L176 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L181-L183 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L201-L202 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L207-L210 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L220-L222 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L227-L230 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L240-L242 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L247-L248 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L253-L255 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L260-L262 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L275-L276 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L289-L291 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L296-L296 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L301-L301 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L306-L306 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L311-L311 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L316-L316 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L321-L321 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L327-L327 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L333-L333 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L7-L7 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L134-L137 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L152-L153 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L168-L169 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L248-L251 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L334-L336 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L559-L559 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L571-L571 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L574-L578 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L593-L596 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L6-L6 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L59-L61 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L72-L72 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L6-L6 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L59-L61 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L72-L72 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/BridgedERC20.sol#L24-L24 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/BridgedERC20.sol#L28-L29 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/BridgedERC20.sol#L45-L47 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/BridgedERC20.sol#L57-L58 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L33-L36 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L54-L56 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L87-L89 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L33-L37 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L58-L60 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L70-L71 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/interfaces/IERC20.sol#L6-L8 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/interfaces/IERC20.sol#L11-L12 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/interfaces/IERC20.sol#L15-L18 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/interfaces/IERC20.sol#L21-L24 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/interfaces/IERC20.sol#L27-L30 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/interfaces/IERC20.sol#L33-L37 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/interfaces/IERC20.sol#L40-L42 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/interfaces/IERC20.sol#L45-L46 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L35-L36 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L52-L53 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L76-L77 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L126-L128 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L35-L35 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L39-L41 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L44-L48 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L116-L120 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L149-L151 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L156-L159 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L167-L170 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L178-L181 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L189-L192 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L196-L199 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L267-L269 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/ComponentRegistry.sol#L12-L15 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/ComponentRegistry.sol#L24-L26 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L15-L19 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L29-L30 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericManager.sol#L18-L19 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericManager.sol#L35-L35 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericManager.sol#L46-L46 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/RegistriesManager.sol#L15-L15 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/RegistriesManager.sol#L21-L26 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/RegistriesManager.sol#L45-L49 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L6-L9 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L34-L36 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L86-L90 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L6-L7 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L10-L11 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L58-L59 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IRegistry.sol#L11-L15 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IRegistry.sol#L22-L26 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IRegistry.sol#L29-L32 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IRegistry.sol#L35-L37 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IRegistry.sol#L40-L43 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IRegistry.sol#L46-L47 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L102-L105 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L120-L122 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L138-L142 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L161-L162 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L175-L182 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L279-L290 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L348-L355 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L393-L395 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L421-L423 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L428-L434 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L476-L479 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L488-L490 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L27-L29 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L44-L45 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L61-L63 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L29-L29 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L34-L35 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L79-L81 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/GenericBondCalculator.sol#L26-L28 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/GenericBondCalculator.sol#L67-L69 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L231-L231 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L372-L373 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L402-L403 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L419-L422 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L446-L449 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L555-L561 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L627-L629 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L646-L649 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L682-L686 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L827-L830 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1235-L1236 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1241-L1244 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1249-L1251 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L1260-L1261 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L22-L29 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L63-L65 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsProxy.sol#L30-L32 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsProxy.sol#L54-L54 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L90-L94 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L115-L119 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L135-L136 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L152-L155 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L179-L181 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L303-L312 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L422-L427 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L460-L465 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L485-L486 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L505-L506 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L523-L525 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L530-L530 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L541-L541 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IDonatorBlacklist.sol#L6-L8 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IGenericBondCalculator.sol#L6-L9 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IGenericBondCalculator.sol#L13-L15 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IOLAS.sol#L5-L7 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IOLAS.sol#L10-L11 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IServiceRegistry.sol#L11-L13 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IServiceRegistry.sol#L24-L25 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IServiceRegistry.sol#L28-L29 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IToken.sol#L6-L8 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IToken.sol#L11-L13 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IToken.sol#L16-L17 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IToken.sol#L20-L23 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IToken.sol#L26-L29 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IToken.sol#L32-L35 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IToken.sol#L38-L42 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/ITokenomics.sol#L6-L7 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/ITokenomics.sol#L10-L10 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/ITokenomics.sol#L32-L33 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/ITokenomics.sol#L36-L41 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/ITokenomics.sol#L45-L46 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/ITokenomics.sol#L49-L50 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/ITreasury.sol#L6-L10 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/ITreasury.sol#L13-L15 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/ITreasury.sol#L18-L20 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/ITreasury.sol#L33-L35 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IUniswapV2Pair.sol#L6-L6 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IUniswapV2Pair.sol#L7-L7 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IUniswapV2Pair.sol#L8-L8 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IUniswapV2Pair.sol#L9-L9 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IVotingEscrow.sol#L6-L7 | |
### [N-103] Missing NatSpec `@dev` from function declaration | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/GovernorOLAS.sol#L16-L16 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/Timelock.sol#L10-L10 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L35-L35 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L7-L7 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L6-L6 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L6-L6 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/BridgedERC20.sol#L24-L24 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L35-L35 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/RegistriesManager.sol#L15-L15 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IUniswapV2Pair.sol#L6-L6 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IUniswapV2Pair.sol#L7-L7 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IUniswapV2Pair.sol#L8-L8 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IUniswapV2Pair.sol#L9-L9 | |
### [N-104] Use `@inheritdoc` for overridden functions | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/GovernorOLAS.sol#L31-L32 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/GovernorOLAS.sol#L39-L44 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/GovernorOLAS.sol#L55-L56 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/GovernorOLAS.sol#L62-L67 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/GovernorOLAS.sol#L79-L84 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/GovernorOLAS.sol#L95-L96 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/GovernorOLAS.sol#L102-L104 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L604-L606 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L631-L632 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L668-L671 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L717-L718 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L749-L751 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L758-L760 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L766-L766 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L771-L771 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L776-L776 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L781-L781 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L787-L787 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L793-L793 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L799-L799 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L97-L106 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L66-L69 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L70-L71 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L131-L134 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L267-L269 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/ComponentRegistry.sol#L24-L26 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/ComponentRegistry.sol#L37-L40 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L29-L30 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L48-L53 | |
### [N-105] Multiple mappings with same keys can be combined into a single struct mapping for readability | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L112-L112 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L119-L119 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L219-L219 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L221-L221 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L227-L227 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L86-L86 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L88-L88 | |
### [N-106] constructor should emit an event | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/GovernorOLAS.sol#L16-L29 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/Timelock.sol#L10-L12 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L35-L39 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L132-L140 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L145-L152 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/multisigs/GuardCM.sol#L138-L150 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L62-L70 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L62-L70 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/BridgedERC20.sol#L24-L26 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20ChildTunnel.sol#L37-L45 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxERC20RootTunnel.sol#L38-L49 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L35-L37 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/ComponentRegistry.sol#L16-L22 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L20-L27 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/RegistriesManager.sol#L15-L19 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L37-L40 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L60-L67 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L106-L118 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L30-L42 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L30-L32 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/GenericBondCalculator.sol#L29-L37 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L232-L234 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsProxy.sol#L33-L52 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L95-L113 | |
### [N-107] Use `ERC1155Holder` over `ERC1155Receiver` | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/GovernorOLAS.sol#L15-L15 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/Timelock.sol#L9-L9 | |
### [N-108] Use a `struct` instead of returning multiple values | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L45-L45 | |
t https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L291-L291 | |
? https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IUniswapV2Pair.sol#L9-L9 | |
### [N-109] [Solidity]: Bug in Legacy Code Generation When Accessing the .selector Member on Expressions with Side Effects | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/GovernorOLAS.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/Timelock.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/interfaces/IErrors.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/ComponentRegistry.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericManager.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/RegistriesManager.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IErrorsRegistries.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IRegistry.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/GenericBondCalculator.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsProxy.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IDonatorBlacklist.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IErrorsTokenomics.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IGenericBondCalculator.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IOLAS.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IServiceRegistry.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IToken.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/ITokenomics.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/ITreasury.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IUniswapV2Pair.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IVotingEscrow.sol#L2-L2 | |
### [N-110] [Solidity]: All `verbatim` blocks are considered identical by deduplicator and can incorrectly be unified | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/GovernorOLAS.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/Timelock.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/OLAS.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/veOLAS.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/wveOLAS.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/FxGovernorTunnel.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/bridges/HomeMediator.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/interfaces/IERC20.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//governance/contracts/interfaces/IErrors.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericRegistry.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/UnitRegistry.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/ComponentRegistry.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/AgentRegistry.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/GenericManager.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/RegistriesManager.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeMultisig.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/multisigs/GnosisSafeSameAddressMultisig.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IErrorsRegistries.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//registries/contracts/interfaces/IRegistry.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Depository.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Dispenser.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/DonatorBlacklist.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/GenericBondCalculator.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Tokenomics.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsConstants.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/TokenomicsProxy.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/Treasury.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IDonatorBlacklist.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IErrorsTokenomics.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IGenericBondCalculator.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IOLAS.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IServiceRegistry.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IToken.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/ITokenomics.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/ITreasury.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IUniswapV2Pair.sol#L2-L2 | |
f https://github.com/code-423n4/2023-12-autonolas/blob/main//tokenomics/contracts/interfaces/IVotingEscrow.sol#L2-L2 | |
# Summary | |
## All correct (92 / 197; 46%) | |
10 [M-01] `block.number` means different things on different L2s | |
8 [L-01] Missing checks for `address(0)` when assigning values to address state variables | |
5 [L-04] External call `recipient` may consume all transaction gas (gas griefing) | |
3 [L-05] Missing checks in constructor | |
10 [L-07] Double type casts create complexity within the code | |
12 [L-08] `external` calls in an un-bounded loop may result in a DOS | |
1 [L-11] Initialization can be front-run | |
4 [L-14] Missing contract-existence checks before low-level calls | |
1 [L-15] NFT doesn't handle hard forks | |
9 [L-18] Int casting `block.timestamp` can reduce the lifespan of a contract | |
46 [L-19] Unsafe downcast | |
1 [L-20] Unsafe conversion from unsigned to signed values | |
21 [L-21] Consider implementing two-step procedure for updating protocol addresses | |
2 [L-22] Consider using descriptive `constant`s when passing zero as a function argument | |
9 [G-01] State variable read in a loop | |
6 [G-09] Using bools for storage incurs overhead | |
16 [G-11] Cache array length outside of loop | |
3 [G-12] State variables should be cached in stack variables rather than re-reading them from storage | |
4 [G-14] With assembly, `.call (bool success)` transfer can be done gas-optimized | |
2 [G-19] Superfluous event fields | |
3 [G-20] Events should be emitted outside of loops | |
1 [G-22] Use `ERC721A` instead `ERC721` | |
27 [G-25] Reduce gas usage by moving to Solidity 0.8.19 or later | |
23 [G-29] Constructors can be marked `payable` | |
3 [G-31] Remove or replace unused state variables | |
1 [G-33] Use shift Right instead of division if possible to save gas | |
11 [G-36] The use of a logical AND in place of double if is slightly less gas efficient in instances where there isn't a corresponding else statement for the given if statement | |
2 [G-37] State variables only set in the constructor should be declared `immutable` | |
9 [G-39] Cache state variables outside of loop to avoid reading storage on every iteration | |
135 [G-41] `>=`/`<=` costs="" less="" gas="" than="" `="">`/`</=`> | |
1 [G-42] Ternary unnecessary | |
59 [G-43] Use assembly to validate `msg.sender` | |
1 [G-45] Consider activating via-ir for deploying | |
5 [G-46] `++i` costs less gas than `i++`, especially when it's used in `for`-loops (`--i`/`i--` too) | |
1 [G-50] Avoid transferring amounts of zero in order to save gas | |
48 [G-52] `++i`/`i++` should be `unchecked{++i}`/`unchecked{i++}` when it is not possible for them to overflow, as is the case when used in `for`- and `while`-loops | |
5 [G-57] Using `constant`s instead of `enum` can save gas | |
3 [G-60] Use `solady` library where possible to save gas | |
145 [N-01] State variables declarations should have NatSpec descriptions | |
1 [N-02] Large or complicated code bases should implement invariant tests | |
22 [N-04] Contract declarations should have NatSpec `@author` annotations | |
1 [N-06] Common functions should be refactored to a common base contract | |
1 [N-07] Overly complicated arithmetic | |
131 [N-09] Constants in comparisons should appear on the left side | |
7 [N-10] `const` Variable names don\'t follow the Solidity style guide | |
6 [N-11] NatSpec documentation for `contract` is missing | |
1 [N-13] Contracts containing only utility functions should be made into libraries | |
36 [N-15] Custom error has no error details | |
14 [N-16] Consider using `delete` rather than assigning `zero` to clear values | |
1 [N-19] Empty Function Body - Consider commenting why | |
27 [N-24] Fixed Compiler Version Required for Non-Library/Interface Files | |
27 [N-25] Floating pragma should be avoided | |
13 [N-26] NatSpec documentation for `function` is missing | |
1 [N-28] `address`s shouldn't be hard-coded | |
40 [N-29] Array indicies should be referenced via `enum`s rather than via numeric literals | |
34 [N-32] Import declarations should import specific identifiers, rather than the whole file | |
5 [N-33] Interfaces should be defined in separate files from their usage | |
121 [N-36] Long lines of code | |
1 [N-38] File is missing NatSpec | |
2 [N-39] Mixed usage of `int`/`uint` with `int256`/`uint256` | |
24 [N-40] Consider using named mappings | |
7 [N-43] `override` function arguments that are unused should have the variable name removed or commented out to avoid compiler warnings | |
15 [N-44] Use of `override` is unnecessary | |
1 [N-48] Adding a `return` statement when the function defines a named return variable, is redundant | |
19 [N-51] NatSpec `@return` argument is missing | |
145 [N-54] State variables should have `Natspec` comments | |
21 [N-56] Contract declarations should have NatSpec `@title` annotations | |
1 [N-58] uint variables should have the bit size defined explicitly | |
15 [N-61] Unused `error` definition | |
1 [N-62] Unused `event` definition | |
1 [N-63] Unused Import | |
1 [N-64] Missing upgradability functionality | |
1 [N-65] Use `abi.encodeCall()` instead of `abi.encodeSignature()`/`abi.encodeSelector()` | |
41 [N-70] Consider using SMTChecker | |
1 [N-71] Variable name must be in mixedCase | |
15 [N-73] Complex function controle flow | |
29 [N-76] Contract declarations should have NatSpec `@dev` annotations | |
1 [N-78] Named imports of parent contracts are missing | |
2 [N-81] `contract` names should use CamelCase | |
75 [N-82] `event` declarations should have NatSpec descriptions | |
3 [N-83] Events should use parameters to convey information | |
10 [N-85] Expressions for constant values should use `immutable` rather than `constant` | |
3 [N-86] Consider splitting long calculations | |
1 [N-87] Consider using `AccessControlDefaultAdminRules` rather than `AccessControl` | |
22 [N-88] `immutable` variable names don\'t follow the Solidity style guide | |
11 [N-91] Add inline comments for unnamed parameters | |
1 [N-94] Consider adding formal verification proofs | |
1 [N-98] Function state mutability can be restricted to `view` | |
75 [N-100] Missing NatSpec `@dev` from event declaration | |
75 [N-101] Missing NatSpec `@notice` from event declaration | |
13 [N-103] Missing NatSpec `@dev` from function declaration | |
24 [N-106] constructor should emit an event | |
## All incorrect (31 / 197; 15%) | |
4 [L-06] Division before multiplication can lead to precision errors | |
5 [L-09] Constant decimal values | |
1 [L-10] `image_data` should be used for raw svg | |
2 [L-17] Setters should have initial value check | |
6 [G-03] Use assembly to calculate hashes to save gas | |
57 [G-08] Avoid contract existence checks by using low level calls | |
1 [G-10] Use byte32 in place of string | |
1 [G-21] Empty blocks should be removed or emit something | |
3 [G-28] Not using the named return variables anywhere in the function is confusing | |
2 [G-34] Use shift Left instead of multiplication if possible to save gas | |
1 [G-47] Unnecessary casting as variable is already of the same type | |
30 [G-51] Simple checks for zero `uint` can be done using assembly to save gas | |
1 [G-53] Do not cache constants to save gas | |
9 [G-55] Use `s.x = s.x + y` instead of `s.x += y` for memory structs | |
1 [G-56] Redundant state variable getters | |
8 [G-59] address(this) should be cached | |
1 [N-17] Dependence on external protocols | |
2 [N-18] `else`-block not required | |
1 [N-46] Functions which are either private or internal should have a preceding _ in their name | |
2 [N-49] Redundant inheritance specifier | |
22 [N-57] Top level pragma declarations should be separated by two blank lines | |
1 [N-66] Use `string.concat()` on strings instead of `abi.encodePacked()` for clearer semantic meaning | |
3 [N-75] A function which defines named returns in it's declaration doesn't need to use return | |
1 [N-89] `private`/`public` function name should start with underscore | |
5 [N-90] Assembly block creates dirty bits | |
1 [N-97] Do not cache `constants` | |
1 [N-99] Do not cache `immutable` | |
29 [N-104] Use `@inheritdoc` for overridden functions | |
2 [N-107] Use `ERC1155Holder` over `ERC1155Receiver` | |
35 [N-109] [Solidity]: Bug in Legacy Code Generation When Accessing the .selector Member on Expressions with Side Effects | |
37 [N-110] [Solidity]: All `verbatim` blocks are considered identical by deduplicator and can incorrectly be unified | |
## All unknown (8 / 197; 4%) | |
2 [L-02] Array lengths not checked | |
1 [L-26] Missing contract-existence checks before yul `call()` | |
1 [G-05] Use assembly in place of `abi.decode` to extract `calldata` values more efficiently | |
4 [G-17] Do not calculate constants | |
60 [G-44] Can make the variable outside the loop to save gas | |
6 [N-31] Imports could be organized more systematically | |
5 [N-59] Uncommented fields in a struct | |
3 [N-80] Do not use UNDERSCORE in `struct` elements names | |
## Majority correct (34 / 197; 17%) | |
8 [L-12] `internal` Function calls within for loops | |
70 [L-16] Consider using OpenZeppelin’s SafeCast library to prevent unexpected overflows when casting from various type int/uint values | |
5 [L-23] Functions calling contracts/addresses with transfer hooks are missing reentrancy guards | |
11 [L-25] prevent re-setting a state variable with the same value | |
91 [G-04] Use assembly to check for `address(0)` | |
3 [G-15] Add `unchecked {}` for subtractions where the operands cannot underflow because of a previous `require()` or `if`-statement | |
34 [G-16] Divisions which do not divide by -X cannot overflow or overflow so such operations can be unchecked to save gas | |
10 [G-23] `internal` functions only called once can be inlined to save gas | |
8 [G-24] Consider merging sequential for loops | |
33 [G-30] Using `private` rather than `public` for constants, saves gas | |
11 [G-32] Avoid updating storage when the value hasn't changed to save gas | |
51 [G-49] Use `do while` loops instead of `for` loops | |
55 [G-54] Using `private` for constants saves gas | |
5 [G-58] Gas savings can be achieved by changing the model for assigning value to the structure ***123 gas*** | |
10 [N-03] Assembly blocks should have extensive comments | |
45 [N-05] Avoid the use of sensitive terms | |
17 [N-12] Contract does not follow the Solidity style guide's suggested layout ordering | |
67 [N-21] Events are missing sender information | |
8 [N-22] Events may be emitted out of order due to reentrancy | |
78 [N-23] Defining All External/Public Functions in Contract Interfaces | |
11 [N-27] Function ordering does not follow the Solidity style guide | |
8 [N-34] Large numeric literals should use underscores for readability | |
27 [N-35] Long functions should be refactored into multiple, smaller, functions | |
12 [N-41] Consider using later versions of solidity for more cappabilities | |
48 [N-42] Events that mark critical parameter changes should contain both the old and the new value | |
21 [N-45] NatSpec `@param` is missing | |
3 [N-47] `public` functions not called by the contract should be declared `external` instead | |
31 [N-50] Setters should prevent re-setting of the same value | |
103 [N-67] Constants should be defined rather than using magic numbers | |
15 [N-69] Use a single file for system wide constants | |
16 [N-72] Whitespace in Expressions | |
78 [N-77] Contract should expose an `interface` | |
5 [N-96] Use a struct to encapsulate multiple function parameters | |
3 [N-108] Use a `struct` instead of returning multiple values | |
## Majority incorrect (17 / 197; 8%) | |
36 [G-06] Optimize Address Storage Value Management with `assembly` | |
82 [G-07] Use assembly to emit events | |
20 [G-13] Use calldata instead of memory for function arguments that do not get mutated | |
6 [G-18] Stack variable cost less while used in emiting event | |
7 [G-26] Multiple `address`/ID mappings can be combined into a single `mapping` of an `address`/ID to a `struct`, where appropriate | |
3 [G-38] Stack variable used as a cheaper cache for a state variable is only used once | |
3 [G-40] Using `storage` instead of `memory` for structs/arrays saves gas | |
3 [G-48] Using mappings instead of arrays to avoid length checks save gas | |
22 [N-14] Control structures do not follow the Solidity Style Guide | |
39 [N-30] Some if-statement can be converted to a ternary | |
5 [N-52] Consider using `SafeTransferLib.safeTransferETH()` or `Address.sendValue()` for clearer semantic meaning | |
20 [N-53] Polymorphic functions make security audits more time-consuming and error-prone | |
46 [N-79] Contract declarations should have NatSpec `@notice` annotations | |
28 [N-84] `function` names should use lowerCamelCase | |
2 [N-92] Function state mutability can be restricted to pure | |
68 [N-95] Missing zero address check in functions with address parameters | |
240 [N-102] Missing NatSpec `@notice` from function declaration | |
## Majority unknown or other (15 / 197; 7%) | |
29 [L-03] For loops in public or external functions should be avoided due to high gas costs and possible DOS | |
11 [L-13] Loss of precision | |
8 [L-24] Code does not follow the best practice of check-effects-interaction | |
141 [G-02] Multiple accesses of a mapping/array should use a local variable cache | |
39 [G-27] Optimize names to save gas | |
45 [G-35] Usage of `uints`/`ints` smaller than 32 bytes (256 bits) incurs overhead | |
13 [N-08] Constant redefined elsewhere | |
23 [N-20] Empty bytes check is missing | |
5 [N-37] Missing event and or timelock for critical parameter change | |
5 [N-55] Numeric values having to do with time should use time units for readability | |
29 [N-60] Event is missing `indexed` fields | |
30 [N-68] Use the latest solidity (prior to 0.8.20 if on L2s) for deployment | |
18 [N-74] Consider bounding input array length | |
35 [N-93] Use the latest Solidity version for better security | |
7 [N-105] Multiple mappings with same keys can be combined into a single struct mapping for readability | |
## No URLs (0 / 197; 0%) | |
## All known (138 / 197; 70%) | |
10 [M-01] `block.number` means different things on different L2s | |
8 [L-01] Missing checks for `address(0)` when assigning values to address state variables | |
5 [L-04] External call `recipient` may consume all transaction gas (gas griefing) | |
3 [L-05] Missing checks in constructor | |
4 [L-06] Division before multiplication can lead to precision errors | |
10 [L-07] Double type casts create complexity within the code | |
12 [L-08] `external` calls in an un-bounded loop may result in a DOS | |
5 [L-09] Constant decimal values | |
1 [L-10] `image_data` should be used for raw svg | |
1 [L-11] Initialization can be front-run | |
4 [L-14] Missing contract-existence checks before low-level calls | |
1 [L-15] NFT doesn't handle hard forks | |
2 [L-17] Setters should have initial value check | |
9 [L-18] Int casting `block.timestamp` can reduce the lifespan of a contract | |
46 [L-19] Unsafe downcast | |
1 [L-20] Unsafe conversion from unsigned to signed values | |
21 [L-21] Consider implementing two-step procedure for updating protocol addresses | |
2 [L-22] Consider using descriptive `constant`s when passing zero as a function argument | |
9 [G-01] State variable read in a loop | |
6 [G-03] Use assembly to calculate hashes to save gas | |
91 [G-04] Use assembly to check for `address(0)` | |
57 [G-08] Avoid contract existence checks by using low level calls | |
6 [G-09] Using bools for storage incurs overhead | |
1 [G-10] Use byte32 in place of string | |
16 [G-11] Cache array length outside of loop | |
3 [G-12] State variables should be cached in stack variables rather than re-reading them from storage | |
20 [G-13] Use calldata instead of memory for function arguments that do not get mutated | |
4 [G-14] With assembly, `.call (bool success)` transfer can be done gas-optimized | |
34 [G-16] Divisions which do not divide by -X cannot overflow or overflow so such operations can be unchecked to save gas | |
6 [G-18] Stack variable cost less while used in emiting event | |
2 [G-19] Superfluous event fields | |
3 [G-20] Events should be emitted outside of loops | |
1 [G-21] Empty blocks should be removed or emit something | |
1 [G-22] Use `ERC721A` instead `ERC721` | |
10 [G-23] `internal` functions only called once can be inlined to save gas | |
27 [G-25] Reduce gas usage by moving to Solidity 0.8.19 or later | |
7 [G-26] Multiple `address`/ID mappings can be combined into a single `mapping` of an `address`/ID to a `struct`, where appropriate | |
3 [G-28] Not using the named return variables anywhere in the function is confusing | |
23 [G-29] Constructors can be marked `payable` | |
3 [G-31] Remove or replace unused state variables | |
1 [G-33] Use shift Right instead of division if possible to save gas | |
2 [G-34] Use shift Left instead of multiplication if possible to save gas | |
11 [G-36] The use of a logical AND in place of double if is slightly less gas efficient in instances where there isn't a corresponding else statement for the given if statement | |
2 [G-37] State variables only set in the constructor should be declared `immutable` | |
3 [G-38] Stack variable used as a cheaper cache for a state variable is only used once | |
9 [G-39] Cache state variables outside of loop to avoid reading storage on every iteration | |
3 [G-40] Using `storage` instead of `memory` for structs/arrays saves gas | |
135 [G-41] `>=`/`<=` costs="" less="" gas="" than="" `="">`/`</=`> | |
1 [G-42] Ternary unnecessary | |
59 [G-43] Use assembly to validate `msg.sender` | |
1 [G-45] Consider activating via-ir for deploying | |
5 [G-46] `++i` costs less gas than `i++`, especially when it's used in `for`-loops (`--i`/`i--` too) | |
1 [G-47] Unnecessary casting as variable is already of the same type | |
3 [G-48] Using mappings instead of arrays to avoid length checks save gas | |
1 [G-50] Avoid transferring amounts of zero in order to save gas | |
30 [G-51] Simple checks for zero `uint` can be done using assembly to save gas | |
48 [G-52] `++i`/`i++` should be `unchecked{++i}`/`unchecked{i++}` when it is not possible for them to overflow, as is the case when used in `for`- and `while`-loops | |
1 [G-53] Do not cache constants to save gas | |
9 [G-55] Use `s.x = s.x + y` instead of `s.x += y` for memory structs | |
1 [G-56] Redundant state variable getters | |
5 [G-57] Using `constant`s instead of `enum` can save gas | |
5 [G-58] Gas savings can be achieved by changing the model for assigning value to the structure ***123 gas*** | |
8 [G-59] address(this) should be cached | |
3 [G-60] Use `solady` library where possible to save gas | |
145 [N-01] State variables declarations should have NatSpec descriptions | |
1 [N-02] Large or complicated code bases should implement invariant tests | |
10 [N-03] Assembly blocks should have extensive comments | |
22 [N-04] Contract declarations should have NatSpec `@author` annotations | |
1 [N-06] Common functions should be refactored to a common base contract | |
1 [N-07] Overly complicated arithmetic | |
131 [N-09] Constants in comparisons should appear on the left side | |
7 [N-10] `const` Variable names don\'t follow the Solidity style guide | |
6 [N-11] NatSpec documentation for `contract` is missing | |
1 [N-13] Contracts containing only utility functions should be made into libraries | |
36 [N-15] Custom error has no error details | |
14 [N-16] Consider using `delete` rather than assigning `zero` to clear values | |
1 [N-17] Dependence on external protocols | |
2 [N-18] `else`-block not required | |
1 [N-19] Empty Function Body - Consider commenting why | |
27 [N-24] Fixed Compiler Version Required for Non-Library/Interface Files | |
27 [N-25] Floating pragma should be avoided | |
13 [N-26] NatSpec documentation for `function` is missing | |
1 [N-28] `address`s shouldn't be hard-coded | |
40 [N-29] Array indicies should be referenced via `enum`s rather than via numeric literals | |
34 [N-32] Import declarations should import specific identifiers, rather than the whole file | |
5 [N-33] Interfaces should be defined in separate files from their usage | |
121 [N-36] Long lines of code | |
1 [N-38] File is missing NatSpec | |
2 [N-39] Mixed usage of `int`/`uint` with `int256`/`uint256` | |
24 [N-40] Consider using named mappings | |
7 [N-43] `override` function arguments that are unused should have the variable name removed or commented out to avoid compiler warnings | |
15 [N-44] Use of `override` is unnecessary | |
1 [N-46] Functions which are either private or internal should have a preceding _ in their name | |
1 [N-48] Adding a `return` statement when the function defines a named return variable, is redundant | |
2 [N-49] Redundant inheritance specifier | |
19 [N-51] NatSpec `@return` argument is missing | |
5 [N-52] Consider using `SafeTransferLib.safeTransferETH()` or `Address.sendValue()` for clearer semantic meaning | |
145 [N-54] State variables should have `Natspec` comments | |
21 [N-56] Contract declarations should have NatSpec `@title` annotations | |
22 [N-57] Top level pragma declarations should be separated by two blank lines | |
1 [N-58] uint variables should have the bit size defined explicitly | |
15 [N-61] Unused `error` definition | |
1 [N-62] Unused `event` definition | |
1 [N-63] Unused Import | |
1 [N-64] Missing upgradability functionality | |
1 [N-65] Use `abi.encodeCall()` instead of `abi.encodeSignature()`/`abi.encodeSelector()` | |
1 [N-66] Use `string.concat()` on strings instead of `abi.encodePacked()` for clearer semantic meaning | |
41 [N-70] Consider using SMTChecker | |
1 [N-71] Variable name must be in mixedCase | |
15 [N-73] Complex function controle flow | |
3 [N-75] A function which defines named returns in it's declaration doesn't need to use return | |
29 [N-76] Contract declarations should have NatSpec `@dev` annotations | |
1 [N-78] Named imports of parent contracts are missing | |
46 [N-79] Contract declarations should have NatSpec `@notice` annotations | |
2 [N-81] `contract` names should use CamelCase | |
75 [N-82] `event` declarations should have NatSpec descriptions | |
3 [N-83] Events should use parameters to convey information | |
10 [N-85] Expressions for constant values should use `immutable` rather than `constant` | |
3 [N-86] Consider splitting long calculations | |
1 [N-87] Consider using `AccessControlDefaultAdminRules` rather than `AccessControl` | |
22 [N-88] `immutable` variable names don\'t follow the Solidity style guide | |
1 [N-89] `private`/`public` function name should start with underscore | |
5 [N-90] Assembly block creates dirty bits | |
11 [N-91] Add inline comments for unnamed parameters | |
2 [N-92] Function state mutability can be restricted to pure | |
1 [N-94] Consider adding formal verification proofs | |
1 [N-97] Do not cache `constants` | |
1 [N-98] Function state mutability can be restricted to `view` | |
1 [N-99] Do not cache `immutable` | |
75 [N-100] Missing NatSpec `@dev` from event declaration | |
75 [N-101] Missing NatSpec `@notice` from event declaration | |
240 [N-102] Missing NatSpec `@notice` from function declaration | |
13 [N-103] Missing NatSpec `@dev` from function declaration | |
29 [N-104] Use `@inheritdoc` for overridden functions | |
24 [N-106] constructor should emit an event | |
2 [N-107] Use `ERC1155Holder` over `ERC1155Receiver` | |
35 [N-109] [Solidity]: Bug in Legacy Code Generation When Accessing the .selector Member on Expressions with Side Effects | |
37 [N-110] [Solidity]: All `verbatim` blocks are considered identical by deduplicator and can incorrectly be unified | |
## All or majority known (174 / 197; 88%) | |
10 [M-01] `block.number` means different things on different L2s | |
8 [L-01] Missing checks for `address(0)` when assigning values to address state variables | |
5 [L-04] External call `recipient` may consume all transaction gas (gas griefing) | |
3 [L-05] Missing checks in constructor | |
4 [L-06] Division before multiplication can lead to precision errors | |
10 [L-07] Double type casts create complexity within the code | |
12 [L-08] `external` calls in an un-bounded loop may result in a DOS | |
5 [L-09] Constant decimal values | |
1 [L-10] `image_data` should be used for raw svg | |
1 [L-11] Initialization can be front-run | |
4 [L-14] Missing contract-existence checks before low-level calls | |
1 [L-15] NFT doesn't handle hard forks | |
2 [L-17] Setters should have initial value check | |
9 [L-18] Int casting `block.timestamp` can reduce the lifespan of a contract | |
46 [L-19] Unsafe downcast | |
1 [L-20] Unsafe conversion from unsigned to signed values | |
21 [L-21] Consider implementing two-step procedure for updating protocol addresses | |
2 [L-22] Consider using descriptive `constant`s when passing zero as a function argument | |
9 [G-01] State variable read in a loop | |
6 [G-03] Use assembly to calculate hashes to save gas | |
91 [G-04] Use assembly to check for `address(0)` | |
57 [G-08] Avoid contract existence checks by using low level calls | |
6 [G-09] Using bools for storage incurs overhead | |
1 [G-10] Use byte32 in place of string | |
16 [G-11] Cache array length outside of loop | |
3 [G-12] State variables should be cached in stack variables rather than re-reading them from storage | |
20 [G-13] Use calldata instead of memory for function arguments that do not get mutated | |
4 [G-14] With assembly, `.call (bool success)` transfer can be done gas-optimized | |
34 [G-16] Divisions which do not divide by -X cannot overflow or overflow so such operations can be unchecked to save gas | |
6 [G-18] Stack variable cost less while used in emiting event | |
2 [G-19] Superfluous event fields | |
3 [G-20] Events should be emitted outside of loops | |
1 [G-21] Empty blocks should be removed or emit something | |
1 [G-22] Use `ERC721A` instead `ERC721` | |
10 [G-23] `internal` functions only called once can be inlined to save gas | |
27 [G-25] Reduce gas usage by moving to Solidity 0.8.19 or later | |
7 [G-26] Multiple `address`/ID mappings can be combined into a single `mapping` of an `address`/ID to a `struct`, where appropriate | |
3 [G-28] Not using the named return variables anywhere in the function is confusing | |
23 [G-29] Constructors can be marked `payable` | |
3 [G-31] Remove or replace unused state variables | |
1 [G-33] Use shift Right instead of division if possible to save gas | |
2 [G-34] Use shift Left instead of multiplication if possible to save gas | |
11 [G-36] The use of a logical AND in place of double if is slightly less gas efficient in instances where there isn't a corresponding else statement for the given if statement | |
2 [G-37] State variables only set in the constructor should be declared `immutable` | |
3 [G-38] Stack variable used as a cheaper cache for a state variable is only used once | |
9 [G-39] Cache state variables outside of loop to avoid reading storage on every iteration | |
3 [G-40] Using `storage` instead of `memory` for structs/arrays saves gas | |
135 [G-41] `>=`/`<=` costs="" less="" gas="" than="" `="">`/`</=`> | |
1 [G-42] Ternary unnecessary | |
59 [G-43] Use assembly to validate `msg.sender` | |
1 [G-45] Consider activating via-ir for deploying | |
5 [G-46] `++i` costs less gas than `i++`, especially when it's used in `for`-loops (`--i`/`i--` too) | |
1 [G-47] Unnecessary casting as variable is already of the same type | |
3 [G-48] Using mappings instead of arrays to avoid length checks save gas | |
1 [G-50] Avoid transferring amounts of zero in order to save gas | |
30 [G-51] Simple checks for zero `uint` can be done using assembly to save gas | |
48 [G-52] `++i`/`i++` should be `unchecked{++i}`/`unchecked{i++}` when it is not possible for them to overflow, as is the case when used in `for`- and `while`-loops | |
1 [G-53] Do not cache constants to save gas | |
9 [G-55] Use `s.x = s.x + y` instead of `s.x += y` for memory structs | |
1 [G-56] Redundant state variable getters | |
5 [G-57] Using `constant`s instead of `enum` can save gas | |
5 [G-58] Gas savings can be achieved by changing the model for assigning value to the structure ***123 gas*** | |
8 [G-59] address(this) should be cached | |
3 [G-60] Use `solady` library where possible to save gas | |
145 [N-01] State variables declarations should have NatSpec descriptions | |
1 [N-02] Large or complicated code bases should implement invariant tests | |
10 [N-03] Assembly blocks should have extensive comments | |
22 [N-04] Contract declarations should have NatSpec `@author` annotations | |
1 [N-06] Common functions should be refactored to a common base contract | |
1 [N-07] Overly complicated arithmetic | |
131 [N-09] Constants in comparisons should appear on the left side | |
7 [N-10] `const` Variable names don\'t follow the Solidity style guide | |
6 [N-11] NatSpec documentation for `contract` is missing | |
1 [N-13] Contracts containing only utility functions should be made into libraries | |
36 [N-15] Custom error has no error details | |
14 [N-16] Consider using `delete` rather than assigning `zero` to clear values | |
1 [N-17] Dependence on external protocols | |
2 [N-18] `else`-block not required | |
1 [N-19] Empty Function Body - Consider commenting why | |
27 [N-24] Fixed Compiler Version Required for Non-Library/Interface Files | |
27 [N-25] Floating pragma should be avoided | |
13 [N-26] NatSpec documentation for `function` is missing | |
1 [N-28] `address`s shouldn't be hard-coded | |
40 [N-29] Array indicies should be referenced via `enum`s rather than via numeric literals | |
34 [N-32] Import declarations should import specific identifiers, rather than the whole file | |
5 [N-33] Interfaces should be defined in separate files from their usage | |
121 [N-36] Long lines of code | |
1 [N-38] File is missing NatSpec | |
2 [N-39] Mixed usage of `int`/`uint` with `int256`/`uint256` | |
24 [N-40] Consider using named mappings | |
7 [N-43] `override` function arguments that are unused should have the variable name removed or commented out to avoid compiler warnings | |
15 [N-44] Use of `override` is unnecessary | |
1 [N-46] Functions which are either private or internal should have a preceding _ in their name | |
1 [N-48] Adding a `return` statement when the function defines a named return variable, is redundant | |
2 [N-49] Redundant inheritance specifier | |
19 [N-51] NatSpec `@return` argument is missing | |
5 [N-52] Consider using `SafeTransferLib.safeTransferETH()` or `Address.sendValue()` for clearer semantic meaning | |
145 [N-54] State variables should have `Natspec` comments | |
21 [N-56] Contract declarations should have NatSpec `@title` annotations | |
22 [N-57] Top level pragma declarations should be separated by two blank lines | |
1 [N-58] uint variables should have the bit size defined explicitly | |
15 [N-61] Unused `error` definition | |
1 [N-62] Unused `event` definition | |
1 [N-63] Unused Import | |
1 [N-64] Missing upgradability functionality | |
1 [N-65] Use `abi.encodeCall()` instead of `abi.encodeSignature()`/`abi.encodeSelector()` | |
1 [N-66] Use `string.concat()` on strings instead of `abi.encodePacked()` for clearer semantic meaning | |
41 [N-70] Consider using SMTChecker | |
1 [N-71] Variable name must be in mixedCase | |
15 [N-73] Complex function controle flow | |
3 [N-75] A function which defines named returns in it's declaration doesn't need to use return | |
29 [N-76] Contract declarations should have NatSpec `@dev` annotations | |
1 [N-78] Named imports of parent contracts are missing | |
46 [N-79] Contract declarations should have NatSpec `@notice` annotations | |
2 [N-81] `contract` names should use CamelCase | |
75 [N-82] `event` declarations should have NatSpec descriptions | |
3 [N-83] Events should use parameters to convey information | |
10 [N-85] Expressions for constant values should use `immutable` rather than `constant` | |
3 [N-86] Consider splitting long calculations | |
1 [N-87] Consider using `AccessControlDefaultAdminRules` rather than `AccessControl` | |
22 [N-88] `immutable` variable names don\'t follow the Solidity style guide | |
1 [N-89] `private`/`public` function name should start with underscore | |
5 [N-90] Assembly block creates dirty bits | |
11 [N-91] Add inline comments for unnamed parameters | |
2 [N-92] Function state mutability can be restricted to pure | |
1 [N-94] Consider adding formal verification proofs | |
1 [N-97] Do not cache `constants` | |
1 [N-98] Function state mutability can be restricted to `view` | |
1 [N-99] Do not cache `immutable` | |
75 [N-100] Missing NatSpec `@dev` from event declaration | |
75 [N-101] Missing NatSpec `@notice` from event declaration | |
240 [N-102] Missing NatSpec `@notice` from function declaration | |
13 [N-103] Missing NatSpec `@dev` from function declaration | |
29 [N-104] Use `@inheritdoc` for overridden functions | |
24 [N-106] constructor should emit an event | |
2 [N-107] Use `ERC1155Holder` over `ERC1155Receiver` | |
35 [N-109] [Solidity]: Bug in Legacy Code Generation When Accessing the .selector Member on Expressions with Side Effects | |
37 [N-110] [Solidity]: All `verbatim` blocks are considered identical by deduplicator and can incorrectly be unified | |
8 [L-12] `internal` Function calls within for loops | |
70 [L-16] Consider using OpenZeppelin’s SafeCast library to prevent unexpected overflows when casting from various type int/uint values | |
5 [L-23] Functions calling contracts/addresses with transfer hooks are missing reentrancy guards | |
11 [L-25] prevent re-setting a state variable with the same value | |
91 [G-04] Use assembly to check for `address(0)` | |
3 [G-15] Add `unchecked {}` for subtractions where the operands cannot underflow because of a previous `require()` or `if`-statement | |
34 [G-16] Divisions which do not divide by -X cannot overflow or overflow so such operations can be unchecked to save gas | |
10 [G-23] `internal` functions only called once can be inlined to save gas | |
8 [G-24] Consider merging sequential for loops | |
33 [G-30] Using `private` rather than `public` for constants, saves gas | |
11 [G-32] Avoid updating storage when the value hasn't changed to save gas | |
51 [G-49] Use `do while` loops instead of `for` loops | |
55 [G-54] Using `private` for constants saves gas | |
5 [G-58] Gas savings can be achieved by changing the model for assigning value to the structure ***123 gas*** | |
10 [N-03] Assembly blocks should have extensive comments | |
45 [N-05] Avoid the use of sensitive terms | |
17 [N-12] Contract does not follow the Solidity style guide's suggested layout ordering | |
67 [N-21] Events are missing sender information | |
8 [N-22] Events may be emitted out of order due to reentrancy | |
78 [N-23] Defining All External/Public Functions in Contract Interfaces | |
11 [N-27] Function ordering does not follow the Solidity style guide | |
8 [N-34] Large numeric literals should use underscores for readability | |
27 [N-35] Long functions should be refactored into multiple, smaller, functions | |
12 [N-41] Consider using later versions of solidity for more cappabilities | |
48 [N-42] Events that mark critical parameter changes should contain both the old and the new value | |
21 [N-45] NatSpec `@param` is missing | |
3 [N-47] `public` functions not called by the contract should be declared `external` instead | |
31 [N-50] Setters should prevent re-setting of the same value | |
103 [N-67] Constants should be defined rather than using magic numbers | |
15 [N-69] Use a single file for system wide constants | |
16 [N-72] Whitespace in Expressions | |
78 [N-77] Contract should expose an `interface` | |
5 [N-96] Use a struct to encapsulate multiple function parameters | |
3 [N-108] Use a `struct` instead of returning multiple values | |
36 [G-06] Optimize Address Storage Value Management with `assembly` | |
82 [G-07] Use assembly to emit events | |
20 [G-13] Use calldata instead of memory for function arguments that do not get mutated | |
6 [G-18] Stack variable cost less while used in emiting event | |
7 [G-26] Multiple `address`/ID mappings can be combined into a single `mapping` of an `address`/ID to a `struct`, where appropriate | |
3 [G-38] Stack variable used as a cheaper cache for a state variable is only used once | |
3 [G-40] Using `storage` instead of `memory` for structs/arrays saves gas | |
3 [G-48] Using mappings instead of arrays to avoid length checks save gas | |
22 [N-14] Control structures do not follow the Solidity Style Guide | |
39 [N-30] Some if-statement can be converted to a ternary | |
5 [N-52] Consider using `SafeTransferLib.safeTransferETH()` or `Address.sendValue()` for clearer semantic meaning | |
20 [N-53] Polymorphic functions make security audits more time-consuming and error-prone | |
46 [N-79] Contract declarations should have NatSpec `@notice` annotations | |
28 [N-84] `function` names should use lowerCamelCase | |
2 [N-92] Function state mutability can be restricted to pure | |
68 [N-95] Missing zero address check in functions with address parameters | |
240 [N-102] Missing NatSpec `@notice` from function declaration | |
## All or majority correct (126 / 197; 63%) | |
10 [M-01] `block.number` means different things on different L2s | |
8 [L-01] Missing checks for `address(0)` when assigning values to address state variables | |
5 [L-04] External call `recipient` may consume all transaction gas (gas griefing) | |
3 [L-05] Missing checks in constructor | |
10 [L-07] Double type casts create complexity within the code | |
12 [L-08] `external` calls in an un-bounded loop may result in a DOS | |
1 [L-11] Initialization can be front-run | |
4 [L-14] Missing contract-existence checks before low-level calls | |
1 [L-15] NFT doesn't handle hard forks | |
9 [L-18] Int casting `block.timestamp` can reduce the lifespan of a contract | |
46 [L-19] Unsafe downcast | |
1 [L-20] Unsafe conversion from unsigned to signed values | |
21 [L-21] Consider implementing two-step procedure for updating protocol addresses | |
2 [L-22] Consider using descriptive `constant`s when passing zero as a function argument | |
9 [G-01] State variable read in a loop | |
6 [G-09] Using bools for storage incurs overhead | |
16 [G-11] Cache array length outside of loop | |
3 [G-12] State variables should be cached in stack variables rather than re-reading them from storage | |
4 [G-14] With assembly, `.call (bool success)` transfer can be done gas-optimized | |
2 [G-19] Superfluous event fields | |
3 [G-20] Events should be emitted outside of loops | |
1 [G-22] Use `ERC721A` instead `ERC721` | |
27 [G-25] Reduce gas usage by moving to Solidity 0.8.19 or later | |
23 [G-29] Constructors can be marked `payable` | |
3 [G-31] Remove or replace unused state variables | |
1 [G-33] Use shift Right instead of division if possible to save gas | |
11 [G-36] The use of a logical AND in place of double if is slightly less gas efficient in instances where there isn't a corresponding else statement for the given if statement | |
2 [G-37] State variables only set in the constructor should be declared `immutable` | |
9 [G-39] Cache state variables outside of loop to avoid reading storage on every iteration | |
135 [G-41] `>=`/`<=` costs="" less="" gas="" than="" `="">`/`</=`> | |
1 [G-42] Ternary unnecessary | |
59 [G-43] Use assembly to validate `msg.sender` | |
1 [G-45] Consider activating via-ir for deploying | |
5 [G-46] `++i` costs less gas than `i++`, especially when it's used in `for`-loops (`--i`/`i--` too) | |
1 [G-50] Avoid transferring amounts of zero in order to save gas | |
48 [G-52] `++i`/`i++` should be `unchecked{++i}`/`unchecked{i++}` when it is not possible for them to overflow, as is the case when used in `for`- and `while`-loops | |
5 [G-57] Using `constant`s instead of `enum` can save gas | |
3 [G-60] Use `solady` library where possible to save gas | |
145 [N-01] State variables declarations should have NatSpec descriptions | |
1 [N-02] Large or complicated code bases should implement invariant tests | |
22 [N-04] Contract declarations should have NatSpec `@author` annotations | |
1 [N-06] Common functions should be refactored to a common base contract | |
1 [N-07] Overly complicated arithmetic | |
131 [N-09] Constants in comparisons should appear on the left side | |
7 [N-10] `const` Variable names don\'t follow the Solidity style guide | |
6 [N-11] NatSpec documentation for `contract` is missing | |
1 [N-13] Contracts containing only utility functions should be made into libraries | |
36 [N-15] Custom error has no error details | |
14 [N-16] Consider using `delete` rather than assigning `zero` to clear values | |
1 [N-19] Empty Function Body - Consider commenting why | |
27 [N-24] Fixed Compiler Version Required for Non-Library/Interface Files | |
27 [N-25] Floating pragma should be avoided | |
13 [N-26] NatSpec documentation for `function` is missing | |
1 [N-28] `address`s shouldn't be hard-coded | |
40 [N-29] Array indicies should be referenced via `enum`s rather than via numeric literals | |
34 [N-32] Import declarations should import specific identifiers, rather than the whole file | |
5 [N-33] Interfaces should be defined in separate files from their usage | |
121 [N-36] Long lines of code | |
1 [N-38] File is missing NatSpec | |
2 [N-39] Mixed usage of `int`/`uint` with `int256`/`uint256` | |
24 [N-40] Consider using named mappings | |
7 [N-43] `override` function arguments that are unused should have the variable name removed or commented out to avoid compiler warnings | |
15 [N-44] Use of `override` is unnecessary | |
1 [N-48] Adding a `return` statement when the function defines a named return variable, is redundant | |
19 [N-51] NatSpec `@return` argument is missing | |
145 [N-54] State variables should have `Natspec` comments | |
21 [N-56] Contract declarations should have NatSpec `@title` annotations | |
1 [N-58] uint variables should have the bit size defined explicitly | |
15 [N-61] Unused `error` definition | |
1 [N-62] Unused `event` definition | |
1 [N-63] Unused Import | |
1 [N-64] Missing upgradability functionality | |
1 [N-65] Use `abi.encodeCall()` instead of `abi.encodeSignature()`/`abi.encodeSelector()` | |
41 [N-70] Consider using SMTChecker | |
1 [N-71] Variable name must be in mixedCase | |
15 [N-73] Complex function controle flow | |
29 [N-76] Contract declarations should have NatSpec `@dev` annotations | |
1 [N-78] Named imports of parent contracts are missing | |
2 [N-81] `contract` names should use CamelCase | |
75 [N-82] `event` declarations should have NatSpec descriptions | |
3 [N-83] Events should use parameters to convey information | |
10 [N-85] Expressions for constant values should use `immutable` rather than `constant` | |
3 [N-86] Consider splitting long calculations | |
1 [N-87] Consider using `AccessControlDefaultAdminRules` rather than `AccessControl` | |
22 [N-88] `immutable` variable names don\'t follow the Solidity style guide | |
11 [N-91] Add inline comments for unnamed parameters | |
1 [N-94] Consider adding formal verification proofs | |
1 [N-98] Function state mutability can be restricted to `view` | |
75 [N-100] Missing NatSpec `@dev` from event declaration | |
75 [N-101] Missing NatSpec `@notice` from event declaration | |
13 [N-103] Missing NatSpec `@dev` from function declaration | |
24 [N-106] constructor should emit an event | |
8 [L-12] `internal` Function calls within for loops | |
70 [L-16] Consider using OpenZeppelin’s SafeCast library to prevent unexpected overflows when casting from various type int/uint values | |
5 [L-23] Functions calling contracts/addresses with transfer hooks are missing reentrancy guards | |
11 [L-25] prevent re-setting a state variable with the same value | |
91 [G-04] Use assembly to check for `address(0)` | |
3 [G-15] Add `unchecked {}` for subtractions where the operands cannot underflow because of a previous `require()` or `if`-statement | |
34 [G-16] Divisions which do not divide by -X cannot overflow or overflow so such operations can be unchecked to save gas | |
10 [G-23] `internal` functions only called once can be inlined to save gas | |
8 [G-24] Consider merging sequential for loops | |
33 [G-30] Using `private` rather than `public` for constants, saves gas | |
11 [G-32] Avoid updating storage when the value hasn't changed to save gas | |
51 [G-49] Use `do while` loops instead of `for` loops | |
55 [G-54] Using `private` for constants saves gas | |
5 [G-58] Gas savings can be achieved by changing the model for assigning value to the structure ***123 gas*** | |
10 [N-03] Assembly blocks should have extensive comments | |
45 [N-05] Avoid the use of sensitive terms | |
17 [N-12] Contract does not follow the Solidity style guide's suggested layout ordering | |
67 [N-21] Events are missing sender information | |
8 [N-22] Events may be emitted out of order due to reentrancy | |
78 [N-23] Defining All External/Public Functions in Contract Interfaces | |
11 [N-27] Function ordering does not follow the Solidity style guide | |
8 [N-34] Large numeric literals should use underscores for readability | |
27 [N-35] Long functions should be refactored into multiple, smaller, functions | |
12 [N-41] Consider using later versions of solidity for more cappabilities | |
48 [N-42] Events that mark critical parameter changes should contain both the old and the new value | |
21 [N-45] NatSpec `@param` is missing | |
3 [N-47] `public` functions not called by the contract should be declared `external` instead | |
31 [N-50] Setters should prevent re-setting of the same value | |
103 [N-67] Constants should be defined rather than using magic numbers | |
15 [N-69] Use a single file for system wide constants | |
16 [N-72] Whitespace in Expressions | |
78 [N-77] Contract should expose an `interface` | |
5 [N-96] Use a struct to encapsulate multiple function parameters | |
3 [N-108] Use a `struct` instead of returning multiple values | |
## All or majority incorrect (48 / 197; 24%) | |
4 [L-06] Division before multiplication can lead to precision errors | |
5 [L-09] Constant decimal values | |
1 [L-10] `image_data` should be used for raw svg | |
2 [L-17] Setters should have initial value check | |
6 [G-03] Use assembly to calculate hashes to save gas | |
57 [G-08] Avoid contract existence checks by using low level calls | |
1 [G-10] Use byte32 in place of string | |
1 [G-21] Empty blocks should be removed or emit something | |
3 [G-28] Not using the named return variables anywhere in the function is confusing | |
2 [G-34] Use shift Left instead of multiplication if possible to save gas | |
1 [G-47] Unnecessary casting as variable is already of the same type | |
30 [G-51] Simple checks for zero `uint` can be done using assembly to save gas | |
1 [G-53] Do not cache constants to save gas | |
9 [G-55] Use `s.x = s.x + y` instead of `s.x += y` for memory structs | |
1 [G-56] Redundant state variable getters | |
8 [G-59] address(this) should be cached | |
1 [N-17] Dependence on external protocols | |
2 [N-18] `else`-block not required | |
1 [N-46] Functions which are either private or internal should have a preceding _ in their name | |
2 [N-49] Redundant inheritance specifier | |
22 [N-57] Top level pragma declarations should be separated by two blank lines | |
1 [N-66] Use `string.concat()` on strings instead of `abi.encodePacked()` for clearer semantic meaning | |
3 [N-75] A function which defines named returns in it's declaration doesn't need to use return | |
1 [N-89] `private`/`public` function name should start with underscore | |
5 [N-90] Assembly block creates dirty bits | |
1 [N-97] Do not cache `constants` | |
1 [N-99] Do not cache `immutable` | |
29 [N-104] Use `@inheritdoc` for overridden functions | |
2 [N-107] Use `ERC1155Holder` over `ERC1155Receiver` | |
35 [N-109] [Solidity]: Bug in Legacy Code Generation When Accessing the .selector Member on Expressions with Side Effects | |
37 [N-110] [Solidity]: All `verbatim` blocks are considered identical by deduplicator and can incorrectly be unified | |
36 [G-06] Optimize Address Storage Value Management with `assembly` | |
82 [G-07] Use assembly to emit events | |
20 [G-13] Use calldata instead of memory for function arguments that do not get mutated | |
6 [G-18] Stack variable cost less while used in emiting event | |
7 [G-26] Multiple `address`/ID mappings can be combined into a single `mapping` of an `address`/ID to a `struct`, where appropriate | |
3 [G-38] Stack variable used as a cheaper cache for a state variable is only used once | |
3 [G-40] Using `storage` instead of `memory` for structs/arrays saves gas | |
3 [G-48] Using mappings instead of arrays to avoid length checks save gas | |
22 [N-14] Control structures do not follow the Solidity Style Guide | |
39 [N-30] Some if-statement can be converted to a ternary | |
5 [N-52] Consider using `SafeTransferLib.safeTransferETH()` or `Address.sendValue()` for clearer semantic meaning | |
20 [N-53] Polymorphic functions make security audits more time-consuming and error-prone | |
46 [N-79] Contract declarations should have NatSpec `@notice` annotations | |
28 [N-84] `function` names should use lowerCamelCase | |
2 [N-92] Function state mutability can be restricted to pure | |
68 [N-95] Missing zero address check in functions with address parameters | |
240 [N-102] Missing NatSpec `@notice` from function declaration | |
## All or majority unknown or other (23 / 197; 11%) | |
2 [L-02] Array lengths not checked | |
1 [L-26] Missing contract-existence checks before yul `call()` | |
1 [G-05] Use assembly in place of `abi.decode` to extract `calldata` values more efficiently | |
4 [G-17] Do not calculate constants | |
60 [G-44] Can make the variable outside the loop to save gas | |
6 [N-31] Imports could be organized more systematically | |
5 [N-59] Uncommented fields in a struct | |
3 [N-80] Do not use UNDERSCORE in `struct` elements names | |
29 [L-03] For loops in public or external functions should be avoided due to high gas costs and possible DOS | |
11 [L-13] Loss of precision | |
8 [L-24] Code does not follow the best practice of check-effects-interaction | |
141 [G-02] Multiple accesses of a mapping/array should use a local variable cache | |
39 [G-27] Optimize names to save gas | |
45 [G-35] Usage of `uints`/`ints` smaller than 32 bytes (256 bits) incurs overhead | |
13 [N-08] Constant redefined elsewhere | |
23 [N-20] Empty bytes check is missing | |
5 [N-37] Missing event and or timelock for critical parameter change | |
5 [N-55] Numeric values having to do with time should use time units for readability | |
29 [N-60] Event is missing `indexed` fields | |
30 [N-68] Use the latest solidity (prior to 0.8.20 if on L2s) for deployment | |
18 [N-74] Consider bounding input array length | |
35 [N-93] Use the latest Solidity version for better security | |
7 [N-105] Multiple mappings with same keys can be combined into a single struct mapping for readability | |
## Instance coverage (3700 / 4229; 87%) | |
# Summary: | |
## All correct (92 / 197; 46%) | |
## All incorrect (31 / 197; 15%) | |
## All unknown (8 / 197; 4%) | |
## Majority correct (34 / 197; 17%) | |
## Majority incorrect (17 / 197; 8%) | |
## Majority unknown or other (15 / 197; 7%) | |
## No URLs (0 / 197; 0%) | |
## All known (138 / 197; 70%) | |
## All or majority known (174 / 197; 88%) | |
## All or majority correct (126 / 197; 63%) | |
## All or majority incorrect (48 / 197; 24%) | |
## All or majority unknown or other (23 / 197; 11%) | |
## Instance coverage (3700 / 4229; 87%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment