-
-
Save IllIllI000/e5d324783a00b2d4d7586dd8ef98a9a1 to your computer and use it in GitHub Desktop.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IllIllI — Today at 12:52 PM | |
hey, if there are going to be score changes, will you also be changing my score? | |
the sponsor basically confirmed the finding: Code4rena | |
ladboy233 — Today at 1:13 PM | |
will get back to you | |
in an hour | |
ladboy233 — Today at 1:47 PM | |
yeah I think I will only change your medium finding from 10 to 11,such change will not change your first place ranking and the report is public so your second oracle related finding is a known issue anyway | |
👍 | |
IllIllI — Today at 1:47 PM | |
ok, so even including the other changes to other people's scores, nobody new changes into A rank? | |
since nobody else would be gaining 8 points, I believe | |
and I believe one of the current As will be downgraded to B | |
IllIllI — Today at 2:02 PM | |
I did put in the work to find and write the rule, so if you agree it's valid, I should get credit for it, and shouldn't get penalized if others are negatively affected by it | |
ladboy233 — Today at 2:04 PM | |
checkinggggg | |
ladboy233 — Today at 2:23 PM | |
I did not expect changing the top best score and change everything | |
IllIllI — Today at 2:23 PM | |
lol | |
ladboy233 — Today at 2:24 PM | |
🤔 | |
IllIllI — Today at 2:24 PM | |
Alex The Entreprenerd — 10/20/2022 | |
Judge making decisions based on payout is called corruption | |
Code4rena | |
😁 | |
ladboy233 — Today at 2:36 PM | |
🤔 | |
Let me briefly explain the pricing of each vault's collateral. It is done through the getAssetPrice() function, which retrieves the USD price of the respective LST. The internal logic of the function involves using the LUSD oracle to fetch the ETH-USD price, and then using the ETH exchange rate provided by each LST contract to calculate the price of each LST. | |
IllIllI — Today at 2:37 PM | |
I'm pretty sure if you ask the sponsor they'll agree it's a high | |
ladboy233 — Today at 2:37 PM | |
function getAssetPrice() public override returns (uint256) { | |
return (_etherPrice() * IWstETH(address(collateralAsset)).stEthPerToken()) / 1e18; | |
} | |
ladboy233 — Today at 2:37 PM | |
Yeah I am asking | |
IllIllI — Today at 2:37 PM | |
shall we just ask them? | |
k | |
if they say it's a high and not a med, I hope you take that into account as well | |
ladboy233 — Today at 2:38 PM | |
I think this is exactly what the sponsor's described | |
"Fetch the ETH-USD price" | |
is | |
_etherPrice() | |
IllIllI — Today at 2:39 PM | |
yes | |
ladboy233 — Today at 2:39 PM | |
and then using the ETH exchange rate provided by each LST contract to calculate the price of each LST. | |
IllIllI — Today at 2:39 PM | |
and stEthPerToken() is stEth, not Eth | |
ladboy233 — Today at 2:41 PM | |
IWstETH(address(collateralAsset)).stEthPerToken()) | |
IllIllI — Today at 2:41 PM | |
stEth per wstEth | |
https://docs.lido.fi/contracts/wsteth/#stethpertoken Returns the amount of wstETH tokens corresponding to one stETH | |
that's why I was surprised when you didn't count it | |
do you agree it's a high now? | |
ladboy233 — Today at 2:51 PM | |
I am just looking into | |
IWBETH(address(collateralAsset)).exchangeRatio() | |
what is the exchange ratio one of this | |
IllIllI — Today at 2:52 PM | |
not sure what that has to do with my finding | |
in general, we go by what's available in the time alloted, and it sounds like you agree that on the face of it, the finding is valid | |
I can wait for you to find all of the answers that you're looking for, but the fact is, they're using the wrong exchange rate | |
ladboy233 — Today at 3:04 PM | |
https://docs.google.com/spreadsheets/d/1XgS0rCUynedYecTj1nMqJp_TT7Og-7mpLsrqBcG_MO0/edit#gid=1809999941 | |
Google Docs | |
Llama - 2023-06 - Bot race | |
Sheet1 | |
Bot,GAS,NC,L,M,Format (/5),Malus,Total,%,Score | |
IllIllI,224,119.7,71,30,5,872.7,109.0875,BEST | |
MrsHudson,120,125,75,30,4,789,98.625,A | |
Hound,124,119.5,66.4,30,5,754.1,94.2625,A | |
Gas-Optimzeer,261,36,23,40,2,711,88.875,A | |
c4lanky,123,119.3,34,40,5,703.3,87.9125,A | |
zz_plus_ultra,174,165.8,24,30,5... | |
Image | |
there were 109% lolll | |
ladboy233 — Today at 3:05 PM | |
I agree, there can be false positive as well | |
I think the only two change I make will be giving you the medium points of the oracle finding + bump the "hound", NC score | |
IllIllI — Today at 3:06 PM | |
sock indicated that there shouldn't have been a cutoff for that one: Code4rena | |
ladboy233 — Today at 3:06 PM | |
emmm | |
IllIllI — Today at 3:06 PM | |
why is it not a high? | |
I submitted it as a high, and the evidence says high | |
you're essentially saying the work I did is not worth its worth, just because others didn't do as well as I did | |
that's not how bot races are supposed to work | |
ladboy233 — Today at 3:13 PM | |
don't think there are sufficient evidence to make it as a high finding, | |
https://github.com/code-423n4/org/issues/103#issue-1736274052 | |
GitHub | |
Bot race judging standardization proposal · Issue #103 · code-423n4... | |
It is really important to have a coherent standard between bot races, and this proposal is an attempt to define some guidelines for the judges. Reports are starting to be very long, and so it is st... | |
Bot race judging standardization proposal · Issue #103 · code-423n4... | |
yeap this is an going discussion | |
Agree there are a lot of room for standardization 🙂 | |
IllIllI — Today at 3:14 PM | |
so you're not downgrading anyone, even though you agree that my finding is at least a medium? | |
ladboy233 — Today at 3:18 PM | |
I think the goal of the bot racing is to find the best report with highest number of the known issue, which I already did, in terms of the fairly evaluating and reward every issue and standardized, this is an going process, emm I will raise a points about this later in the judging channel later and the issue 103 thread later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment