Last active
August 27, 2021 16:04
-
-
Save JakeUrban/fdf441509c530839751d090ec9f5e76a to your computer and use it in GitHub Desktop.
SEP-10 Manage Data Op Changes
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**This gist is an example, and the content should not be taken to be up-to-date. | |
The following [changes](https://github.com/stellar/stellar-protocol/commit/28c636b4ef5074ca0c3d46bbe9bf0f3f38095233#diff-72480d0894ae2d1a31c229b64ad4c37b) were recently merged to [SEP-10](https://github.com/stellar/stellar-protocol/blob/master/ecosystem/sep-0010.md): | |
- [ ] the Manage Data operation's key includes a `homeDomain` [FQDN](https://en.wikipedia.org/wiki/Fully_qualified_domain_name) instead of the `anchorName` string | |
- [ ] a `SIGNING_KEY` attribute in the [stellar.toml](https://github.com/stellar/stellar-protocol/blob/master/ecosystem/sep-0001.md) of the service implementing SEP-10 is required | |
- [ ] client applications _must_ match the value of the Manage Data operation's key with the home domain used in the request for the service's TOML file | |
- [ ] client applications _must_ verify that the service's `SIGNING_KEY` keypair was used to sign the challenge transaction | |
Each SDK must update to enable the _first_ and ideally _third_ item in this list. | |
The SDF's JavaScript SDK released [v5.0.5](https://github.com/stellar/js-stellar-sdk/releases/tag/v5.0.5) recently including these changes. | |
The Go SDK may not support verifying the home domain from the Manage Data op key because it would require breaking changes to `ReadChallengeTx()` and other functions, compared to the strictly additive changes made to the JS SDK. If your SDK would also require breaking changes to implement this check, comment on this issue and we discuss the viability of different options. | |
If your SDK has implemented and released these changes, reference the release in a closing comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment