CRM-19966 PR 9948 test results from Pradeep

PR9948 results.txt

1. Contribution Receipts 
Test Case:
1. Added contribution for $100 using contribution form. Checked Contribution receipt - looks good
2. Updated contribution #1 using contribution form. Checked Contribution receipt - looks good
3. Added contribution for $100 using contribution form with Sales Tax enabled. Checked Contribution receipt - looks good
4. Updated contribution #3 using contribution form with Sales Tax enabled. Checked Contribution receipt - looks good
5. Added contribution using contribution form using priceset having Checkbox, Radio, Text and Select field. Checked Contribution receipt - looks good
6. Updated contribution #5 using contribution form. Checked Contribution receipt - looks good
7. Added contribution using contribution form using priceset having Checkbox, Radio, Text and Select field with Sales Tax enabled. Checked Contribution receipt - looks good. Attached CreateContributionReceipt.png
**8. Updated contribution #7 using contribution form with Sales Tax enabled. Checked Contribution receipt - some tax info missing. Attached UpdateContributionReceipt.png
    -- Total amount is shown wrong 
    -- Sales Tax section is missing 
    -- Amount before tax section missing
Change to code at line 1804 has caused the regression.

2. Validation Error for Net Amount
Test Case: 
1. Added contribution for $100 using contribution form. No Validation error
2. Updated contribution #1 using contribution form. Validation Error (The sum of fee amount and net amount must be equal to total amount)
3. Added contribution for $100 using contribution form with Sales Tax enabled. No Validation error
4. Updated contribution #3 using contribution form with Sales Tax enabled. No Validation error
5. Added contribution using contribution form using priceset having Checkbox, Radio, Text and Select field. No Validation error
6. Updated contribution #5 using contribution form. Checked Contribution receipt - No Validation error
7. Added contribution using contribution form using priceset having Checkbox, Radio, Text and Select field with Sales Tax enabled. No Validation error
8. Updated contribution #7 using contribution form with Sales Tax enabled. No Validation error

3. Update to Contribution via Contribution Form
Test Case: 
1. Added contribution for $100 using contribution form. Updated contribution using contribution form. 
    Result: Contribution Total, Financial Trxn entry, Financial Item, Line Item entries - Correct
2. Added contribution for $100 using contribution form with Sales Tax enabled. Updated contribution using contribution form with Sales Tax enabled.
    Result: Contribution Total, Financial Trxn entry, Financial Item, Line Item entries - Correct
3. Added contribution using contribution form using priceset having Checkbox, Radio, Text and Select field. Updated contribution using contribution form.
    Result: Contribution Total, Financial Trxn entry, Financial Item, Line Item entries - Correct
4. Added contribution using contribution form using priceset having Checkbox, Radio, Text and Select field with Sales Tax enabled. Updated contribution using contribution form with Sales Tax enabled.
    Result: Contribution Total, Financial Trxn, Financial Item - Correct
**            Line Item(tax_amount) entries - InCorrect (Have attached image AddContributionLineItem.png(before update) and UpdateContributionLineItem.png(after update))

4. Update to Contribution via api
Test Case: 
1. Added contribution for $100 using contribution form. Updated contribution using api.
   civicrm_api3('Contribution', 'create', array(
      'id' => 1,
      'financial_type_id' => "Donation",
    ));
    Result: Contribution Total, Financial Trxn entry, Financial Item, Line Item entries - Correct
2. Added contribution for $100 using contribution form with Sales Tax enabled. Updated contribution using  api with Sales Tax enabled.
    civicrm_api3('Contribution', 'create', array(
      'id' => 1,
      'financial_type_id' => "Donation",
    ));
    Result: Contribution Total, Financial Trxn entry, Financial Item, Line Item entries - Correct
3. Added contribution using contribution form using priceset having Checkbox, Radio, Text and Select field. Updated contribution using api.
    civicrm_api3('Contribution', 'create', array(
      'id' => 1,
      'financial_type_id' => "Donation",
    ));
    Result: Contribution Total, Financial Trxn entry, Financial Item, Line Item entries - Correct
4. Added contribution using contribution form using priceset having Checkbox, Radio, Text and Select field with Sales Tax enabled. Updated contribution using api with Sales Tax enabled.
    civicrm_api3('Contribution', 'create', array(
      'id' => 1,
      'financial_type_id' => "Donation",
    ));
    Result: Contribution Total, Financial Trxn, Financial Item - Correct
            Line Item(tax_amount) entries - InCorrect (Have attached image AddContrbutionLineItemAPI.png(before update) and UpdateContributionLineItemAPIOnlyFT.png(after update))

5. Added contribution using contribution form using priceset having Checkbox, Radio, Text and Select field with Sales Tax enabled. Updated contribution using api(different api params compared to #4) with Sales Tax enabled.
    civicrm_api3('Contribution', 'create', array(
      'sequential' => 1,
      'id' => 1,
      'financial_type_id' => "Donation",
      'total_amount' => 336.60
    ));
**  Result: Contribution Total - Incorrect (amount changed)
**  Financial Trxn, Financial Item - Additional Entries for amount change
**  Line Item(tax_amount) entries - InCorrect (Have attached image AddContrbutionLineItemAPI.png(before update) and UpdateContributionLineItemAPITotalAmount&FT.png(after update))

I will do some more QA regarding Net amount where i feel its stored incorrectly but i am not sure if its because of current PR change. I will post the result soon if i find any.