xaviershay

Hello Github,

Pull requests are not serving me well on large reviews. Here are some problems and suggested enhancements that would make me happy.

• Mark comment as "resolved" (see google docs for an example). As code changes, comments get lost or made redundant, and it is not clear (to either the author or reviewers) which are still relevant and which have been addressed. Resolving a comment doesn't need to make it dissappear, but I need to be able to see "which comments have not been addressed" somehow. This feature would be the most useful to me.
• Reply to a comment. This can be done in effect on line comments (assuming there is only one), but cannot on PR comments. Particularly with many threads, the lack of this makes a review hard to follow.
• Explicit "approve/block" life cycle. The block is actually more important to me ... often on a PR that has been incrementally improved I want to "block" final merge of it until I get a chance to rebase/squash and generally pretty it up. The block can be over

janko

require "benchmark/ips"

File.write "minitest_test.rb", <<-EOS
require "minitest/autorun"
require "minitest/pride"

class MintestTest < Minitest::Test
  def test_foo
    assert true
  end

ajosanchez

class Hack
  
  def initialize words
    @words = words.downcase.split(/\/|\s|,\s|\,/)
    @splitwords = []
    @words.each { |w| @splitwords << w.split('') }
    show_likely
  end
  
  def deduct

chrismccord

If you want a run-down of the 1.3 changes and the design decisions behidn those changes, check out the LonestarElixir Phoenix 1.3 keynote: https://www.youtube.com/watch?v=tMO28ar0lW8

To use the new phx.new project generator, you can install the archive with the following command:

$ mix archive.install https://github.com/phoenixframework/archives/raw/master/phx_new.ez

Bump your phoenix dep

Phoenix v1.3.0 is a backwards compatible release with v1.2.x. To upgrade your existing 1.2.x project, simply bump your phoenix dependency in mix.exs:

stefancocora

Introduction

The purpose of this short howto is to show you how to:

• use openconnect [1] to connect to an enterprise cisco anyconnect endpoint
• whilst minimizing the amount of traffic that your route through the vpn connection

Usually VPN administrators will puth the default route to the users, so that all user traffic is routed through the vpn connection. This is to address the various security concerns around compromised user computers bridging external internet traffic into the secure VPN network.

While the VPN administrator can push routes to the clients, the client can ignore these default routes and establish client side routing so that only the required A.B.C.D/E network is routed through the VPN. All other traffic will still use the clients default route and default outbound internet connection.

munificent

#include <time.h> //  Robert Nystrom
#include <stdio.h> // @munificentbob
#include <stdlib.h> //     for Ginny
#define  r return    //    2008-2019
#define  l(a, b, c, d) for (i y=a;y\
<b; y++) for (int x = c; x < d; x++)
typedef int i;const i H=40;const i W
=80;i m[40][80];i g(i x){r rand()%x;
}void cave(i s){i w=g(10)+5;i h=g(6)
+3;i t=g(W-w-2)+1;i u=g(H-h-2)+1;l(u

evadne

defmodule StreamIterator.Messages do
  @moduledoc """
  The Stream Iterator can be used to consume items from an Elixir Stream incrementally.

  ## Examples
  
  ### Infinite Streams

  When used on infinite streams such as the ones returned by `Stream.cycle/1`, the Stream
  Iterator will always return the next item.

derekkraan

defmodule Opentelemetry.CodeCodeShipSampler do              
  @behaviour :otel_sampler                                                                                                                                                                                                                         
                                                            
  @impl :otel_sampler
  def setup(_sampler_opts) do
    []          
  end               
                                                            
  @impl :otel_sampler                
  def description(_sampler_config) do