-
-
Save KevM/6554377 to your computer and use it in GitHub Desktop.
**on** equals vs. contains compromise?
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
let on (u: string) = | |
try | |
wait pageTimeout (fun _ -> browser.Url = u) | |
with | |
| ex -> if browser.Url.Contains(u) = false then raise (CanopyOnException(sprintf "on check failed, expected expression '%s' got %s" u browser.Url)); |
How about this:
url "http://localhost/path/action?id=1234"
on "http://localhost/path/action?id=1234" //should succeed
on "http://localhost/path/action" //should succeed
on "http://localhost/path/action/subaction" //should fail (currently succeeds)
let on expected =
let url = _browser.Url
if url = expected then true else whackQuerystring(url) = expected
I am suggesting that if the url does not match that on
would whack the query string and compare again.
I see, your suggestion seems totally reasonable
Cool I'll get you a PR when I get a chance sadly my laptop charger is busted so that means Monday.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Can you give an example. Not sure what would break compatibility.