bad_names.cpp

vector<pair<int, int>> getThem() {
  vector<pair<int, int>> v;

  for (pair<int, int> x : theList) {
    if (x.second == 4) {
      v.push(x);
    }
  }

  return v;
}

best_names.cpp

typdef std::pair<int, int> Cell;
const int FLAGGED_VALUE = 4;

vector<Cell> findFlaggedCells() {
  vector<Cell> flaggedCells;

  for(Cell cell : gameBoard) {
    if (cell.second == FLAGGED_VALUE) {
      flaggedCells.push_back(cell);
    }
  }
  
  return flaggedCells;
}

good_names.cpp

vector<pair<int, int>> findFlaggedCells() {
  vector<pair<int, int>> flaggedCells;

  const int FLAGGED = 4;
  for (pair<int, int> cell : gameBoard) {
    if (cell.second == FLAGGED) {
      flaggedCells.push_back(cell);
    }
  }

  return flaggedCells;
}