Skip to content

Instantly share code, notes, and snippets.

@LaurMo
Created July 6, 2015 21:22
Show Gist options
  • Save LaurMo/f06df4e66ca85abe7e95 to your computer and use it in GitHub Desktop.
Save LaurMo/f06df4e66ca85abe7e95 to your computer and use it in GitHub Desktop.
Glassbreakers' Team Process for Contributing Code
How to Contribute Code to the Glassbreakers App
---------------
1. Create new local branch
2. Push to origin/branch
3. Add a clean title that includes Trello card number and mark label as in_progress
4. Add a description
- what was accomplished
- why it was needed
- anything else that will help with code reviews
5. Make a pull request and mark label as ready_for_review
- Hound will automatically give feedback
6. Post your PR into Slack's channel "Hacker Updates"
7. ALWAYS have at least one person review your PR before merging into master
- If it's good to go the other dev should label it as ready_to_merge_to_master
- If it's not, the other dev should label it as edits_needed and return to #4
8. Once you get the thumbs up from another dev, check CircleCI and Code Climate to make sure everything is passing
9. Merge to Master and check CircleCI and Code Climate again
10. Push to staging
- Check staging manually while tailing your logs
11. Ask Courtney to QA across browsers
12. If there are concerns with Courtney start at 1 and repeat
- Never make edits directly on Master
13. When given the clear from Courtney, push to production!
- Check production manually while tailing your logs
- Have Courtney QA across browsers
Debugging Tools
----------
* [Airbrake](https://airbrake.io)
* [Papertrail](https://papertrailapp.com)
* [New Relic](https://rpm.newrelic.com)
* [Skylight](https://www.skylight.io)
Analytics & Customer Service
----------
* [Segment](https://segment.com)
* [Mixpanel](https://mixpanel.com)
* [ Google Analytics](http://www.google.com/analytics)
* [Intercom.io](https://intercom.io)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment