cppcheck.txt

[src/3rdparty/squirrel/squirrel/sqclass.h:10]: (performance) Variable 'val' is assigned in constructor body. Consider performing initialization in initialization list.
[src/3rdparty/squirrel/squirrel/sqclass.h:11]: (performance) Variable 'attrs' is assigned in constructor body. Consider performing initialization in initialization list.
[src/3rdparty/squirrel/squirrel/sqclosure.h:10]: (performance) Variable '_function' is assigned in constructor body. Consider performing initialization in initialization list.
[src/3rdparty/squirrel/squirrel/sqclosure.h:48]: (performance) Variable '_closure' is assigned in constructor body. Consider performing initialization in initialization list.
[src/3rdparty/squirrel/squirrel/sqcompiler.cpp:664]: (portability) Casting from float* to integer* is not portable due to different binary data representations on different platforms.
[src/3rdparty/squirrel/squirrel/sqcompiler.cpp:710]: (portability) Casting from float* to integer* is not portable due to different binary data representations on different platforms.
[src/3rdparty/squirrel/squirrel/sqcompiler.cpp:63]: (performance) Variable '_sourcename' is assigned in constructor body. Consider performing initialization in initialization list.
[src/3rdparty/squirrel/squirrel/sqfuncproto.h:19]: (performance) Variable '_name' is assigned in constructor body. Consider performing initialization in initialization list.
[src/3rdparty/squirrel/squirrel/sqfuncproto.h:20]: (performance) Variable '_src' is assigned in constructor body. Consider performing initialization in initialization list.
[src/3rdparty/squirrel/squirrel/sqfuncproto.h:26]: (performance) Variable '_src' is assigned in constructor body. Consider performing initialization in initialization list.
[src/3rdparty/squirrel/squirrel/sqfuncproto.h:27]: (performance) Variable '_name' is assigned in constructor body. Consider performing initialization in initialization list.
[src/3rdparty/squirrel/squirrel/sqfuncproto.h:39]: (performance) Variable '_name' is assigned in constructor body. Consider performing initialization in initialization list.
[src/3rdparty/squirrel/squirrel/sqfuncstate.cpp:97]: (performance) Variable '_literals' is assigned in constructor body. Consider performing initialization in initialization list.
[src/3rdparty/squirrel/squirrel/sqobject.h:345] -> [src/3rdparty/squirrel/squirrel/sqvm.h:162]: (warning) The struct 'SQVM' defines member variable with name '_sharedstate' also defined in its parent struct 'SQCollectable'.
[src/3rdparty/squirrel/squirrel/sqvm.cpp:382]: (portability) Using memset() on union which contains a floating point number.
[src/3rdparty/squirrel/squirrel/sqvm.cpp:1163]: (portability) Using memset() on union which contains a floating point number.
[src/3rdparty/squirrel/squirrel/sqvm.cpp:761]: (portability) Casting between integer* and const float* which have an incompatible binary data representation.
[src/3rdparty/squirrel/squirrel/sqvm.cpp:112]: (performance) Variable '_lasterror' is assigned in constructor body. Consider performing initialization in initialization list.
[src/3rdparty/squirrel/squirrel/sqvm.cpp:113]: (performance) Variable '_errorhandler' is assigned in constructor body. Consider performing initialization in initialization list.
[src/3rdparty/squirrel/squirrel/sqvm.cpp:114]: (performance) Variable '_debughook' is assigned in constructor body. Consider performing initialization in initialization list.
[src/aircraft_cmd.cpp:848] -> [src/aircraft_cmd.cpp:859]: (warning) Either the condition 'st!=NULL' is redundant or there is possible null pointer dereference: st.
[src/blitter/32bpp_anim.hpp:33]: (performance) Variable 'palette' is assigned in constructor body. Consider performing initialization in initialization list.
[src/blitter/32bpp_anim_sse4.hpp:32]: (information) The code 'class Blitter_32bppSSE4_Anim sealed :' is not handled. You can use -I or --include to add handling of this code.
[src/blitter/8bpp_optimized.hpp:19]: (information) The code 'class Blitter_8bppOptimized sealed :' is not handled. You can use -I or --include to add handling of this code.
[src/blitter/8bpp_simple.hpp:19]: (information) The code 'class Blitter_8bppSimple sealed :' is not handled. You can use -I or --include to add handling of this code.
[src/cargopacket.cpp:79]: (error) Member variable 'loaded_at_xy' is initialized by itself.
[src/cargopacket.cpp:222] -> [src/cargopacket.h:247]: (warning) Function 'TryMerge' argument order different: declaration 'cp, icp' definition 'icp, cp'
[src/company_cmd.cpp:212]: (performance) Function parameter 'cost' should be passed by reference.
[src/company_cmd.cpp:241]: (performance) Function parameter 'cost' should be passed by reference.
[src/company_cmd.cpp:252]: (performance) Function parameter 'cst' should be passed by reference.
[src/company_gui.cpp:772] -> [src/company_gui.cpp:773]: (warning) Either the condition 'scheme>=LS_END' is redundant or the array '_livery_class[23]' is accessed at index 23, which is out of bounds.
[src/company_gui.cpp:600]: (performance) Variable 'square' is assigned in constructor body. Consider performing initialization in initialization list.
[src/core/pool_func.hpp:116]: (error) Using 'memset' on struct that contains a virtual method.
[src/core/pool_func.hpp:116]: (error) Using 'memset' on struct that contains a 'std::list'.
[src/core/pool_func.hpp:116]: (error) Using 'memset' on class that contains a virtual method.
[src/core/pool_type.hpp:89] -> [src/group.h:67]: (warning) The struct 'Group' defines member variable with name 'name' also defined in its parent struct 'Pool'.
[src/base_station_base.h:59] -> [src/core/pool_type.hpp:89]: (warning) The struct 'BaseStation' defines member variable with name 'name' also defined in its parent struct 'Pool'.
[src/core/pool_type.hpp:89] -> [src/depot_base.h:23]: (warning) The struct 'Depot' defines member variable with name 'name' also defined in its parent struct 'Pool'.
[src/core/pool_type.hpp:89] -> [src/town.h:64]: (warning) The struct 'Town' defines member variable with name 'name' also defined in its parent struct 'Pool'.
[src/core/pool_type.hpp:89] -> [src/engine_base.h:24]: (warning) The struct 'Engine' defines member variable with name 'name' also defined in its parent struct 'Pool'.
[src/core/pool_type.hpp:89] -> [src/signs_base.h:24]: (warning) The struct 'Sign' defines member variable with name 'name' also defined in its parent struct 'Pool'.
[src/depot_gui.cpp:1012] -> [src/depot_gui.cpp:533]: (warning) Possible null pointer dereference: d
[src/disaster_vehicle.cpp:464]: (warning) Suspicious code: sign conversion of ? in calculation, even though ? can have a negative value
[src/engine.cpp:83]: (performance) Variable 'preview_company' is assigned in constructor body. Consider performing initialization in initialization list.
[src/group_cmd.cpp:261]: (performance) Variable 'owner' is assigned in constructor body. Consider performing initialization in initialization list.
[src/highscore.cpp:68]: (warning) Division by result of sizeof(). memmove() expects a size in bytes, did you intend to multiply instead?
[src/map_func.h:404]: (error) syntax error
[src/misc/hashtable.hpp:215]: (error) Boolean value assigned to pointer.
[src/network/network_admin.cpp:422]: (warning) Comparison of a boolean expression with an integer other than 0 or 1.
[src/network/network_content_gui.cpp:534]: (performance) Variable 'checkbox_size' is assigned in constructor body. Consider performing initialization in initialization list.
[src/newgrf.cpp:2775]: (error) Uninitialized struct member: map.plural_form
[src/newgrf.cpp:2782]: (error) Uninitialized struct member: map.plural_form
[src/saveload/oldloader.cpp:268]: (warning) Assignment of function parameter has no effect outside the function. Did you forget dereferencing it?
[src/script/api/script_object.hpp:25]: (error) Internal error. Token::astOperand2() cyclic dependency.
[src/script/api/script_road.cpp:376]: (warning) Division by result of sizeof(). alloca() expects a size in bytes, did you intend to multiply instead?
[src/script/squirrel.cpp:171]: (performance) Function parameter 'instance' should be passed by reference.
[src/script/squirrel.cpp:217]: (performance) Function parameter 'instance' should be passed by reference.
[src/script/squirrel_helper.hpp:94]: (performance) Function parameter 'res' should be passed by reference.
[src/signs.cpp:32]: (performance) Variable 'owner' is assigned in constructor body. Consider performing initialization in initialization list.
[src/station_gui.cpp:1014]: (error) Member variable 'cargo' is initialized by itself.
[src/station_gui.cpp:1022]: (error) Member variable 'station' is initialized by itself.
[src/station_gui.cpp:1030]: (error) Member variable 'station' is initialized by itself.
[src/station_gui.cpp:1038]: (error) Member variable 'cargo' is initialized by itself.
[src/strgen/strgen_base.cpp:970]: (warning) Redundant assignment of '_lang.missing' to itself.
[src/strgen/strgen_base.cpp:971]: (warning) Redundant assignment of '_lang.winlangid' to itself.
[src/strings.cpp:1904]: (warning) Redundant assignment of 'hdr->missing' to itself.
[src/strings.cpp:1905]: (warning) Redundant assignment of 'hdr->winlangid' to itself.
[src/strings_func.h:83]: (error) Member variable 'data' is initialized by itself.
[src/table/sprites.h:1525]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour
[src/table/sprites.h:1528]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour
[src/thread/thread.h:116]: (warning) Member variable 'ThreadMutexLocker::mutex' is not assigned a value in 'ThreadMutexLocker::operator='.
[src/toolbar_gui.cpp:125]: (performance) Variable 'icon_size' is assigned in constructor body. Consider performing initialization in initialization list.
[src/tree_map.h:169]: (portability) Shifting a negative value is technically undefined behaviour
[src/viewport.cpp:261]: (warning) Redundant assignment of 'w' to itself.
[src/widget.cpp:530]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour
[src/misc_gui.cpp:944] -> [src/window_gui.h:305]: (warning) The struct 'QueryStringWindow' defines member variable with name 'flags' also defined in its parent struct 'Window'.
[src/zoom_func.h:27]: (portability) Shifting a negative value is technically undefined behaviour