Skip to content

Instantly share code, notes, and snippets.

@MKorostoff
Created February 17, 2012 19:29
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save MKorostoff/1855026 to your computer and use it in GitHub Desktop.
Save MKorostoff/1855026 to your computer and use it in GitHub Desktop.
Chat Log
[2:04:42 PM] *** Gary Truax added Matt Korostoff ***
[2:04:45 PM] Ed Hanna: hey
[2:04:52 PM] Matt Korostoff: hi ed
[2:04:55 PM] Gary Truax: Matt
[2:05:15 PM] Matt Korostoff: there are illegal characters in the taxonomy terms that are not being escaped
[2:05:18 PM] Matt Korostoff: [2:04 PM] Matt Korostoff:
<<< Good characters: period, comma, space
Bad characters: dash, slash
[2:05:44 PM] Matt Korostoff: it can be fixed by renaming the term, but you have to do it after the last content import is run
[2:05:58 PM] Ed Hanna: hey
[2:06:09 PM] Ed Hanna: we got one this AM
[2:06:12 PM] Ed Hanna: content import
[2:06:23 PM] Ed Hanna: if we changed now and did another one wed
[2:06:25 PM] Ed Hanna: would it bust things?
[2:06:52 PM] Matt Korostoff: nothing would break, but you would end up with two taxonomy terms
[2:06:58 PM] Ed Hanna: ah
[2:06:59 PM] Ed Hanna: ok
[2:07:04 PM] Ed Hanna: cuz of the import
[2:07:05 PM] Ed Hanna: again
[2:07:08 PM] Matt Korostoff: right
[2:07:31 PM] Ed Hanna: hmmm
[2:07:33 PM] Ed Hanna: k
[2:07:40 PM] Ed Hanna: is it a quick change?
[2:07:52 PM] Matt Korostoff: which, renaming the term?
[2:07:54 PM] Matt Korostoff: it's nothing
[2:07:58 PM] Ed Hanna: yea
[2:08:02 PM] Ed Hanna: k
[2:08:15 PM] Matt Korostoff: I can do it right now, it'll take eleven seconds
[2:08:25 PM] Ed Hanna: i almost want to sayyea
[2:08:27 PM] Ed Hanna: yea*
[2:08:37 PM] Ed Hanna: we're prob not going to do another content ingest for this one
[2:08:41 PM] Matt Korostoff: k
[2:08:42 PM] Ed Hanna: we just got one this morning
[2:08:48 PM] Ed Hanna: if we did we'd just have to clean it up
[2:08:51 PM] Ed Hanna: sounds like
[2:08:56 PM] Matt Korostoff: if you do, it's not the end of the world to just retag 3 or 4 photos
[2:09:00 PM] Ed Hanna: right
[2:09:04 PM] Ed Hanna: then let's do it pls
[2:09:07 PM] Matt Korostoff: k
[2:09:10 PM] Ed Hanna: thanks
[2:09:48 PM] Matt Korostoff: it's done
[2:09:55 PM] Ed Hanna: checking
[2:09:57 PM] Matt Korostoff: my estimate was high
[2:10:04 PM] Ed Hanna: lol
[2:10:09 PM] Ed Hanna: bingo
[2:10:09 PM] Ed Hanna: worked
[2:10:14 PM] Matt Korostoff: cool
[2:10:14 PM] Gary Truax: so we are good?
[2:10:17 PM] Ed Hanna: good!
[2:10:22 PM] Gary Truax: great thx matt
[2:10:26 PM] Matt Korostoff: any time
[2:10:40 PM] Matt Korostoff: one thing though: this uncovers a global issue on all the sites
[2:10:56 PM] Ed Hanna: ?
[2:11:04 PM] Matt Korostoff: dash, slash break photo categories
[2:11:15 PM] Matt Korostoff: but CMs are able to use them
[2:12:05 PM] Matt Korostoff: so we have to either escape those characters in the URL or perform form validation to prevent them from being entered int he first place
[2:12:15 PM] Matt Korostoff: (that would be acquia side)
[2:12:22 PM] Matt Korostoff: and that's true for all sites
[2:12:36 PM] Ed Hanna: i guess we must be addressing those tho
[2:12:40 PM] Ed Hanna: in the sites we launched
[2:12:47 PM] Ed Hanna: otherwise we'd see issues
[2:13:03 PM] Matt Korostoff: I just don't think we've seen a site with those characters in taxonomy terms
[2:13:14 PM] Matt Korostoff: I can't think of one off hand anyway
[2:13:16 PM] Ed Hanna: oh ok
[2:13:26 PM] Ed Hanna: so we have to keep an eye out for those
[2:13:53 PM] Matt Korostoff: yeah—that's the other solution, just follow a process where those characters are not used
[2:14:19 PM] Matt Korostoff: and train CMs on that process
[2:14:36 PM] Ed Hanna: right
[2:14:43 PM] Matt Korostoff: brb, but I think you're good now :)
[2:14:51 PM] Ed Hanna: thx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment