Skip to content

Instantly share code, notes, and snippets.

@MajesticPotatoe
Created January 11, 2019 03:03
Show Gist options
  • Save MajesticPotatoe/a0e9e69b83a0208491fff6b37bd4fd54 to your computer and use it in GitHub Desktop.
Save MajesticPotatoe/a0e9e69b83a0208491fff6b37bd4fd54 to your computer and use it in GitHub Desktop.
Commit/PR Gsuideline
General Info
what do we use to determine to be acceptable feature?
Default Checklist:
* make sure its functionally good and not breaking other things
* make sure theres an updated test
* make sure documentation is updated (if needed)
* e2e (when rolled out)
Pull Requests
fix -> pr/commit to master
* go through checklist
* merged if good
fix -> pr/commit to dev
* requires a change that messes something up
* changes that affect a lot of things
* backwards compatible api change
bug/enchance -> pr to master/dev
* case by case depending on what its actually doing/fixing
* if to dev, should be heavily scrutinized
* must have a test
feat/enhance -> pr to dev
* for minor releases
* once it looks good, tested, passes checklist can be merged
* Create Branch -> PR -> Test -> Release
feat/enhance -> pr to next
* for major releases
* breaking changes
- Something that will not work when they upgrade
- Only major can be breaking
* once it looks good, tested, passes checklist can be merged
* Create Branch -> PR -> Test -> Release
New Features/Requests
Minimum Criteria to accept
Vote?
When one comes in
* Determine if pass criteria
* Vote if should be accepted?
If Fails/Denied -> generic response, close issue
If Pass - Normal methods
Create Branch -> PR -> Test -> Release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment