process of adding validator test
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The process of adding a validator test | |
When a validator has a problem, someone (Jorge probably) files a bug with the error message. | |
Matt isolates the bug and writes a unit test for it. | |
A functional test also needs to be written. The functional test runs the addon through the validator and checks that the same error messages does not show up. | |
Example: | |
Here is a bug: https://bugzilla.mozilla.org/show_bug.cgi?id=659330 | |
"Don't show "missing type" warning for dictionary add-ons in validator" | |
Sometimes there is a link to a specific xpi file/addon. This one doesn't have one but since it's for any dictionary, chose the smallest dictionary file available "chichewa" | |
Download the xpi file to test-amo-validator/addons | |
Edit the file test_amo_validator/test_validator.py | |
There are a few categories of tests, pick one and add a check for the file that was just downloaded. | |
git push marlena master for github | |
pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment