Testing Plan / How I Tested
- Wrote a test
- Tested locally (running SHA)
- Tested on staging (running SHA)
- Will test in production
Database
- Indexes are added for new tables, or new data access patterns
- Does my code make assumptions about the state of the database? If so, could these assumptions be enforced by the database or the database assumption checker?
Documentation
- All new SQL tables are documented
- New core data types are documented
- Generally documented
Monitoring Plan
- Does my code need to emit any data/logs to debug it later?
- Could a recurring check be created to ensure continual correctness?
Informing the rest of the team
- Consider the possible impacts to users
- Inform people in #product
- Notify @engineers about any changes in settings.yml