Skip to content

Instantly share code, notes, and snippets.

@MichalPaszkiewicz
Last active August 29, 2015 14:16
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save MichalPaszkiewicz/fc4435b8eb0a9271d9c8 to your computer and use it in GitHub Desktop.
Save MichalPaszkiewicz/fc4435b8eb0a9271d9c8 to your computer and use it in GitHub Desktop.
PR for dashboard extension
var localStorageFunctions = function(){
this.GetRecognitions = function(){
var result = {};
try{
var recognitionsString = localStorage.getItem("recognitions")
result = JSON.parse(recognitionsString) || {};
}
catch(err){
console.error("The format of localStorage's recognitions is bad. SO bad.");
console.error(err.message);
}
return result;
};
this.SaveRecognitions = function(recognitions){
if(recognitions == null){
recognitions = {};
}
localStorage.setItem("recognitions", JSON.stringify(recognitions) );
return recognitions;
};
}
var Database = new localStorageFunctions();
var addRecognition = function(name){
var recognitions = Database.GetRecognitions();
if(recognitions[name] === undefined){
recognitions[name] = 0;
}
recognitions[name]++;
var date = new Date();
recognitions["latest-day"] = {day: date.getDate(), hours: date.getHours(), minutes: date.getMinutes()};
Database.SaveRecognitions(recognitions);
}
@dcarles
Copy link

dcarles commented Mar 11, 2015

recognitions.push({name: 0}); should be recognitions.push({name: 1});

@AbubakerB
Copy link

if(result == null){
            result = {};
        }

can be removed if you change
result = JSON.parse(recognitionsString);
to
result = JSON.parse(recognitionsString) || {};

@AbubakerB
Copy link

if(recognitions[name] === undefined){
        recognitions.push({name: 0});
    }

should be

if(recognitions[name] === undefined){
        recognitions[name] = 0;
    }

'push' doesn't exist in an object

@dcarles
Copy link

dcarles commented Mar 11, 2015

you dont even needd the save function just do all in add recognition and move that to the object
i mean combining save and add recognition

@AbubakerB
Copy link

console.log should be console.error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment