Skip to content

Instantly share code, notes, and snippets.

Miguel Castillo MiguelCastillo

Block or report user

Report or block MiguelCastillo

Hide content and notifications from this user.

Learn more about blocking users

Contact Support about this user’s behavior.

Learn more about reporting abuse

Report abuse
View GitHub Profile
@ebidel
ebidel / feature_detect_es_modules.js
Last active Dec 3, 2019
Feature detect ES modules: both static import and dynamic import()
View feature_detect_es_modules.js
<!--
Complete feature detection for ES modules. Covers:
1. Static import: import * from './foo.js';
2. Dynamic import(): import('./foo.js').then(module => {...});
Demo: http://jsbin.com/tilisaledu/1/edit?html,output
Thanks to @_gsathya, @kevincennis, @rauschma, @malyw for the help.
-->
View Code Reviews: A Controversial Policy.md

Code Reviews: A Controversial Policy

How I Will Perform Code Reviews
  • We Code Review after each story, and I use them as a place to have discussions where we have the opportunity to learn from one another.

  • I trust the other developers on my team, especially since they will have more context on their own work, so anything I suggest is merely a suggestion, and so I always "Approve" my github review. I give them the benefit of the doubt that if I point out something, it is more than likely I misunderstood.

  • It is entirely reasonable for people to use their discretion to disagree with or defer my suggestions for improvement.

You can’t perform that action at this time.