Skip to content

Instantly share code, notes, and snippets.

@MrCrambo
Last active June 21, 2023 21:36
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save MrCrambo/0e1e527980b6bc790ad3301fd56687da to your computer and use it in GitHub Desktop.
Save MrCrambo/0e1e527980b6bc790ad3301fd56687da to your computer and use it in GitHub Desktop.

Summary

This is the report from a security audit performed on SmartSwap by MrCrambo.

The audit focused primarily on the security of SmartSwap smart contracts.

In scope

  1. https://github.com/ezo-network/SmartSwap/blob/f2b3d82c8ed0d61cfd99621fea8cca6a798c9ead/BNBETH/TransferHelper.sol
  2. https://github.com/ezo-network/SmartSwap/blob/f2b3d82c8ed0d61cfd99621fea8cca6a798c9ead/BNBETH/Ownable.sol
  3. https://github.com/ezo-network/SmartSwap/blob/f2b3d82c8ed0d61cfd99621fea8cca6a798c9ead/BNBETH/SafeMath.sol
  4. https://github.com/ezo-network/SmartSwap/blob/f2b3d82c8ed0d61cfd99621fea8cca6a798c9ead/BNBETH/Validator.sol
  5. https://github.com/ezo-network/SmartSwap/blob/f2b3d82c8ed0d61cfd99621fea8cca6a798c9ead/BNBETH/SwapFactory.sol
  6. https://github.com/ezo-network/SmartSwap/blob/f2b3d82c8ed0d61cfd99621fea8cca6a798c9ead/BNBETH/SwapPair.sol

Findings

In total, 1 issue was reported including:

  • 0 high severity issues.

  • 0 medium severity issues.

  • 0 low severity issues.

  • 1 owner privilegies issues.

Security issues

1. Owner privileges

Severity: owner privileges

Description

  • Owner can change company fee.
  • Owner can change factory contract to the new contract.
  • Owner can change validator contract.
  • Owner can change Oracle contract.

Since tokens swapping correctness completely relies on the Validator response and the Validator contract relies on the Oracle response the owner may change those contracts to make swapping unfair (or steal money).

The developer said that the voting contract will be used as an owner to reduce fraud risks and remove key ownership manipulation.

Conclusion

Smart contract contains only low severity issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment