Skip to content

Instantly share code, notes, and snippets.

@MrCrambo
Last active July 31, 2019 13:13
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 1 You must be signed in to fork a gist
  • Save MrCrambo/302b99485af9d28d9b946592ac2c865f to your computer and use it in GitHub Desktop.
Save MrCrambo/302b99485af9d28d9b946592ac2c865f to your computer and use it in GitHub Desktop.

1.Summary

This is the report from a security audit performed on Lucky Strike v7 by MrCrambo.

The audit focused primarily on the security of Lucky Strike v6 smart contracts.

2.In scope

  1. https://ropsten.etherscan.io/address/0x71a92934c32f1c6cdf776fe411728c164c473309#code
  2. https://ropsten.etherscan.io/address/0xc0f92e31070460d310c81689199c9b496fc4a84e#code

3.Findings

In total, 4 issues were reported including:

  • 0 high severity issues.

  • 1 medium severity issues.

  • 2 owner privilegies issues.

  • 0 low severity issues.

  • 1 notes.

Security issues

3.1. Truncated Value (Invest & Play)

Severity: medium

Description

Truncated value issue still doesn't fixed even after changes in line 1853, truncation will happens in line 1859 (no more than one token).

uint256 tokensToMint = sumToMarketingFund / tokenPriceInWei;

3.2. Owner privilegies

Severity: owner privilegies

Description

  • adjustAllocation function allows the owner to reset the rates of the different jackpots and income rate as wished.
  • 70M tokens are first distributed by the owner that represent 10500 ether, the token sale hardcap is 4500 ether, meaning that the developers allow them self more than a third of the total income of the bet game, investors have to be aware of such usage.

3.3. No event call

Severity: note

Description

In function takeIncome(uint256 valueInTokens) in line 181 in token contract there is no event call, that funds burned or transfered to zero address.

Recommendation

Add event.

Transfer(msg.sender, address(0), valueInTokens);

4.Conclusion

Smart contract contains medium severity issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment