Skip to content

Instantly share code, notes, and snippets.

@MrCrambo
Created May 6, 2019 10:03
Show Gist options
  • Save MrCrambo/94868ef055b7a52b7604e156cc82230e to your computer and use it in GitHub Desktop.
Save MrCrambo/94868ef055b7a52b7604e156cc82230e to your computer and use it in GitHub Desktop.

Summary

This is the report from a security audit performed on EtherBots by MrCrambo.

The audit focused primarily on the security of EtherBots smart contracts.

In scope

  1. https://github.com/EtherBots/NonFungibleToken/blob/master/contracts/DetailedERC721.sol
  2. https://github.com/EtherBots/NonFungibleToken/blob/master/contracts/ERC721.sol
  3. https://github.com/EtherBots/NonFungibleToken/blob/master/contracts/MintableNonFungibleToken.sol
  4. https://github.com/EtherBots/NonFungibleToken/blob/master/contracts/NonFungibleToken.sol

Findings

In total, 1 issue were reported including:

  • 0 high severity issues.

  • 0 medium severity issues.

  • 0 owner privilegies issues.

  • 1 low severity issues.

Security issues

1. Wrong return value name

Severity: low

Description

In functions name, symbol, totalSupply, balanceOf, ownerOf, tokenMetadata there are return value name is different from return value.

Recommendation

Change the return value name in brackets or delete it.

Conclusion

Smart contracts are free of critical issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment