Skip to content

Instantly share code, notes, and snippets.

@MrCrambo

MrCrambo/Bnb.md Secret

Created March 17, 2019 12:52
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 1 You must be signed in to fork a gist
  • Save MrCrambo/fc9e1cc9ca69b4d7910db5c91c3a0beb to your computer and use it in GitHub Desktop.
Save MrCrambo/fc9e1cc9ca69b4d7910db5c91c3a0beb to your computer and use it in GitHub Desktop.

Summary

This is the report from a security audit performed on Bnb by MrCrambo.

The audit focused primarily on the security of Bnb smart contract.

In scope

  1. https://gist.github.com/yuriy77k/7612e9b1f915f169542e711dd6a29166

Findings

In total, 2 issues was reported including:

  • 0 critical severity issues.

  • 0 high severity issues.

  • 0 medium severity issues.

  • 2 low severity issues.

1. Known vulnerabilities of ERC-20 token

Severity: low

Description

  1. It is possible to double withdrawal attack. More details here
  2. Lack of transaction handling mechanism issue. More details here

Recommendation

Add into a function transfer(address _to, ... ) following code:

require( _to != address(this) );

2. Old solidity version

Severity: low

Description

Used solidity version is old.

Conclusion

Smart contract contains only low severity issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment