Skip to content

Instantly share code, notes, and snippets.

@NewAlexandria

NewAlexandria/pr-template.md

Last active January 20, 2016 01:14
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save NewAlexandria/da399b21fde821515d3f to your computer and use it in GitHub Desktop.
Save NewAlexandria/da399b21fde821515d3f to your computer and use it in GitHub Desktop.
Download ZIP
test dupe from sprintly's culture repo
Raw
pr-template.md

z

What's this PR do?

Where should the reviewer start?

How should this be manually tested?

Any background context you want to provide?

What are the relevant tickets?

Screenshots (if appropriate)

What gif best describes this PR or how it makes you feel?

Definition of Done:

  • Is there appropriate test coverage? (e.g. ChefSpec, Mocha/Chai, Python, etc.)

  • Does this PR require a Selenium test? (e.g. Browser-specific bugs or complicated UI bugs)

  • Does this PR require a regression test? All fixes require a regression test.

  • Does this PR require a blog post? If so, ensure marketing has signed off on content.

  • Does the knowledge base need to be updated?

  • Does this add new dependencies? If so, does Chef, M4, or PIP requirements need to be updated?

  • Will this feature require a new piece of infrastructure be implemented?

  • Are any new services fully automated in Chef?

  • Are there ChefSpec tests for the new Chef recipes/cookbooks?

  • Does this PR require new Mixpanel or GA events?

  • Is there appropriate logging included?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment