Created
April 20, 2024 16:15
-
-
Save PerchunPak/a9eda19fcc3531cbc1dc77268611c715 to your computer and use it in GitHub Desktop.
WIP VLC nightly overlay; see https://github.com/NixOS/nixpkgs/issues/305581
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
final: prev: { | |
vlc-nightly = let | |
revision = "2a58b2bf9263b33538bca88ab4e5e6a04e73c88e"; | |
vlc-without-qt5 = prev.vlc.override {withQt5 = false;}; | |
in | |
vlc-without-qt5.overrideAttrs (old: { | |
version = "nightly"; | |
src = final.fetchFromGitLab { | |
domain = "code.videolan.org"; | |
owner = "videolan"; | |
repo = "vlc"; | |
rev = revision; | |
hash = "sha256-B7e13jaenvnYtBjrmjuFdTE28DZxfYFsQlrsOU9r4G4="; | |
}; | |
nativeBuildInputs = | |
old.nativeBuildInputs | |
++ [ | |
prev.qt6.wrapQtAppsHook | |
prev.bison | |
]; | |
buildInputs = | |
old.buildInputs | |
++ (with prev.qt6; [ | |
qtwayland | |
qtbase | |
qtsvg | |
# qtx11extras | |
]); | |
postFixup = | |
old.postFixup | |
+ '' | |
remove-references-to -t "${prev.qt6.qtbase.dev}" $out/lib/vlc/plugins/gui/libqt_plugin.so | |
''; | |
preConfigure = '' | |
echo ${revision} > src/revision.txt | |
''; | |
configureFlags = | |
old.configureFlags | |
++ [ | |
"--disable-skins2" | |
]; | |
}); | |
} |
Line #19: You are adding qt6 wrapping but not removing qt5 wrapping. this might cause issues.
@LordGrimmauld, I remove qt5 things on line 4, see https://github.com/NixOS/nixpkgs/blob/9edb990e0e175a2f165ba1fb74cc02073b5327b2/pkgs/by-name/vl/vlc/package.nix#L118.
Also look at NixOS/nixpkgs#305581.
Ah true, didn't see that. Interesting overlay, will have to give that a shot then!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Line #19: You are adding qt6 wrapping but not removing qt5 wrapping. this might cause issues.