Skip to content

Instantly share code, notes, and snippets.

View PeterStegnar's full-sized avatar

Peter Stegnar PeterStegnar

3 followers · 3 following
View GitHub Profile
@PeterStegnar
PeterStegnar / code-review-checklist.md
Created November 2, 2013 15:05 — forked from haacked/code-review-checklist.md

General

  1. Unit tests: Review unit tests first. Unit tests are a fantastic way to grasp how code is meant to be used by others and to learn what the expected behavior is. Are there any test gaps that should be there?
  2. Method arguments" Make sure arguments to methods make sense and are validated.
  3. Null References" (Yah yah, we know. Use F# and this goes away. We get it already.) Null references are a bitch and it’s worth looking out for them specifically.
  4. Conventions Consistency" Make sure naming, formatting, etc. follow our conventions and are consistent. I like a codebase that’s fairly consistent so you know what to expect.
  5. Disposables: Make sure disposable things are disposed. Look for usages of resources that should be disposed but are not.
  6. Security: There is a whole threat and mitigation review process that falls under this bucket.

WPF + ReactiveUI