Skip to content

Instantly share code, notes, and snippets.

@ProgramCrafter
Created March 25, 2024 18:54
Show Gist options
  • Save ProgramCrafter/2b56bb38f502ed1bfdb660a1e0ef3009 to your computer and use it in GitHub Desktop.
Save ProgramCrafter/2b56bb38f502ed1bfdb660a1e0ef3009 to your computer and use it in GitHub Desktop.
/d/Rust/webrtc (master)
$ cargo clippy --fix --lib --all --allow-dirty
Checking webrtc-util v0.8.1 (D:\Rust\webrtc\util)
Checking sdp v0.6.1 (D:\Rust\webrtc\sdp)
Checking examples v0.5.0 (D:\Rust\webrtc\examples)
Checking webrtc-constraints v0.1.0 (D:\Rust\webrtc\constraints)
Checking signal v0.1.0 (D:\Rust\webrtc\examples\examples\signal)
Fixed util\src\ifaces\ffi\windows\mod.rs (4 fixes)
Fixed util\src\vnet\nat.rs (2 fixes)
warning: variant name starts with the enum's name
--> util\src\ifaces\ffi\windows\mod.rs:186:5
|
186 | IpPrefixOriginOther = 0,
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
= note: `#[warn(clippy::enum_variant_names)]` on by default
warning: variant name starts with the enum's name
--> util\src\ifaces\ffi\windows\mod.rs:187:5
|
187 | IpPrefixOriginManual,
| ^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
warning: variant name starts with the enum's name
--> util\src\ifaces\ffi\windows\mod.rs:188:5
|
188 | IpPrefixOriginWellKnown,
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
warning: variant name starts with the enum's name
--> util\src\ifaces\ffi\windows\mod.rs:189:5
|
189 | IpPrefixOriginDhcp,
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
warning: variant name starts with the enum's name
--> util\src\ifaces\ffi\windows\mod.rs:190:5
|
190 | IpPrefixOriginRouterAdvertisement,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
warning: variant name starts with the enum's name
--> util\src\ifaces\ffi\windows\mod.rs:191:5
|
191 | IpPrefixOriginUnchanged = 16,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
warning: all variants have the same prefix: `IpPrefixOrigin`
--> util\src\ifaces\ffi\windows\mod.rs:185:1
|
185 | / pub enum IpPrefixOrigin {
186 | | IpPrefixOriginOther = 0,
187 | | IpPrefixOriginManual,
188 | | IpPrefixOriginWellKnown,
... |
191 | | IpPrefixOriginUnchanged = 16,
192 | | }
| |_^
|
= help: remove the prefixes and use full paths to the variants instead of glob imports
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
warning: variant name starts with the enum's name
--> util\src\ifaces\ffi\windows\mod.rs:196:5
|
196 | IpSuffixOriginOther = 0,
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
warning: variant name starts with the enum's name
--> util\src\ifaces\ffi\windows\mod.rs:197:5
|
197 | IpSuffixOriginManual,
| ^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
warning: variant name starts with the enum's name
--> util\src\ifaces\ffi\windows\mod.rs:198:5
|
198 | IpSuffixOriginWellKnown,
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
warning: variant name starts with the enum's name
--> util\src\ifaces\ffi\windows\mod.rs:199:5
|
199 | IpSuffixOriginDhcp,
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
warning: variant name starts with the enum's name
--> util\src\ifaces\ffi\windows\mod.rs:200:5
|
200 | IpSuffixOriginLinkLayerAddress,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
warning: variant name starts with the enum's name
--> util\src\ifaces\ffi\windows\mod.rs:201:5
|
201 | IpSuffixOriginRandom,
| ^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
warning: variant name starts with the enum's name
--> util\src\ifaces\ffi\windows\mod.rs:202:5
|
202 | IpSuffixOriginUnchanged = 16,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
warning: all variants have the same prefix: `IpSuffixOrigin`
--> util\src\ifaces\ffi\windows\mod.rs:195:1
|
195 | / pub enum IpSuffixOrigin {
196 | | IpSuffixOriginOther = 0,
197 | | IpSuffixOriginManual,
198 | | IpSuffixOriginWellKnown,
... |
202 | | IpSuffixOriginUnchanged = 16,
203 | | }
| |_^
|
= help: remove the prefixes and use full paths to the variants instead of glob imports
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
warning: variant name starts with the enum's name
--> util\src\ifaces\ffi\windows\mod.rs:208:5
|
208 | IpDadStateInvalid = 0,
| ^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
warning: variant name starts with the enum's name
--> util\src\ifaces\ffi\windows\mod.rs:209:5
|
209 | IpDadStateTentative,
| ^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
warning: variant name starts with the enum's name
--> util\src\ifaces\ffi\windows\mod.rs:210:5
|
210 | IpDadStateDuplicate,
| ^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
warning: variant name starts with the enum's name
--> util\src\ifaces\ffi\windows\mod.rs:211:5
|
211 | IpDadStateDeprecated,
| ^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
warning: variant name starts with the enum's name
--> util\src\ifaces\ffi\windows\mod.rs:212:5
|
212 | IpDadStatePreferred,
| ^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
warning: all variants have the same prefix: `IpDadState`
--> util\src\ifaces\ffi\windows\mod.rs:207:1
|
207 | / pub enum IpDadState {
208 | | IpDadStateInvalid = 0,
209 | | IpDadStateTentative,
210 | | IpDadStateDuplicate,
211 | | IpDadStateDeprecated,
212 | | IpDadStatePreferred,
213 | | }
| |_^
|
= help: remove the prefixes and use full paths to the variants instead of glob imports
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
warning: variant name starts with the enum's name
--> util\src\ifaces\ffi\windows\mod.rs:217:5
|
217 | IfOperStatusUp = 1,
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
warning: variant name starts with the enum's name
--> util\src\ifaces\ffi\windows\mod.rs:218:5
|
218 | IfOperStatusDown = 2,
| ^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
warning: variant name starts with the enum's name
--> util\src\ifaces\ffi\windows\mod.rs:219:5
|
219 | IfOperStatusTesting = 3,
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
warning: variant name starts with the enum's name
--> util\src\ifaces\ffi\windows\mod.rs:220:5
|
220 | IfOperStatusUnknown = 4,
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
warning: variant name starts with the enum's name
--> util\src\ifaces\ffi\windows\mod.rs:221:5
|
221 | IfOperStatusDormant = 5,
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
warning: variant name starts with the enum's name
--> util\src\ifaces\ffi\windows\mod.rs:222:5
|
222 | IfOperStatusNotPresent = 6,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
warning: variant name starts with the enum's name
--> util\src\ifaces\ffi\windows\mod.rs:223:5
|
223 | IfOperStatusLowerLayerDown = 7,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
warning: all variants have the same prefix: `IfOperStatus`
--> util\src\ifaces\ffi\windows\mod.rs:216:1
|
216 | / pub enum IfOperStatus {
217 | | IfOperStatusUp = 1,
218 | | IfOperStatusDown = 2,
219 | | IfOperStatusTesting = 3,
... |
223 | | IfOperStatusLowerLayerDown = 7,
224 | | }
| |_^
|
= help: remove the prefixes and use full paths to the variants instead of glob imports
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
warning: all variants have the same prefix: `NetIfConnection`
--> util\src\ifaces\ffi\windows\mod.rs:227:1
|
227 | / pub enum NetIfConnectionType {
228 | | NetIfConnectionDedicated = 1,
229 | | NetIfConnectionPassive = 2,
230 | | NetIfConnectionDemand = 3,
231 | | NetIfConnectionMaximum = 4,
232 | | }
| |_^
|
= help: remove the prefixes and use full paths to the variants instead of glob imports
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
warning: variant name starts with the enum's name
--> util\src\ifaces\ffi\windows\mod.rs:236:5
|
236 | TunnelTypeNone = 0,
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
warning: variant name starts with the enum's name
--> util\src\ifaces\ffi\windows\mod.rs:237:5
|
237 | TunnelTypeOther = 1,
| ^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
warning: variant name starts with the enum's name
--> util\src\ifaces\ffi\windows\mod.rs:238:5
|
238 | TunnelTypeDirect = 2,
| ^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
warning: variant name starts with the enum's name
--> util\src\ifaces\ffi\windows\mod.rs:239:5
|
239 | TunnelType6To4 = 11,
| ^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
warning: variant name starts with the enum's name
--> util\src\ifaces\ffi\windows\mod.rs:240:5
|
240 | TunnelTypeIsatap = 13,
| ^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
warning: variant name starts with the enum's name
--> util\src\ifaces\ffi\windows\mod.rs:241:5
|
241 | TunnelTypeTeredo = 14,
| ^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
warning: variant name starts with the enum's name
--> util\src\ifaces\ffi\windows\mod.rs:242:5
|
242 | TunnelTypeIpHttps = 15,
| ^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
warning: `webrtc-util` (lib) generated 37 warnings
Checking rtp v0.10.0 (D:\Rust\webrtc\rtp)
Checking rtcp v0.10.1 (D:\Rust\webrtc\rtcp)
Checking stun v0.5.1 (D:\Rust\webrtc\stun)
Checking webrtc-dtls v0.9.0 (D:\Rust\webrtc\dtls)
Checking webrtc-sctp v0.9.1 (D:\Rust\webrtc\sctp)
Checking webrtc-mdns v0.6.1 (D:\Rust\webrtc\mdns)
Fixed sdp\src\description\media.rs (1 fix)
Checking webrtc-media v0.7.1 (D:\Rust\webrtc\media)
Checking webrtc-srtp v0.12.0 (D:\Rust\webrtc\srtp)
Checking turn v0.7.1 (D:\Rust\webrtc\turn)
Fixed dtls\src\handshake\handshake_message_client_hello.rs (1 fix)
Fixed dtls\src\handshake\handshake_message_server_hello.rs (1 fix)
Checking hub v0.1.0 (D:\Rust\webrtc\dtls\examples\hub)
Checking webrtc-data v0.8.1 (D:\Rust\webrtc\data)
Checking interceptor v0.11.0 (D:\Rust\webrtc\interceptor)
Fixed turn\src\allocation\allocation_manager.rs (1 fix)
Checking webrtc-ice v0.10.1 (D:\Rust\webrtc\ice)
Fixed ice\src\udp_mux\mod.rs (2 fixes)
Checking webrtc v0.10.1 (D:\Rust\webrtc\webrtc)
warning: failed to automatically apply fixes suggested by rustc to crate `webrtc`
after fixes were automatically applied the compiler reported errors within these files:
* webrtc\src\rtp_transceiver\rtp_receiver\mod.rs
This likely indicates a bug in either rustc or cargo itself,
and we would appreciate a bug report! You're likely to see
a number of compiler warnings after this message which cargo
attempted to fix but failed. If you could open an issue at
https://github.com/rust-lang/rust-clippy/issues
quoting the full output of this command we'd be very appreciative!
Note that you may be able to make some more progress in the near-term
fixing code with the `--broken-code` flag
The following errors were reported:
error[E0308]: mismatched types
--> webrtc\src\rtp_transceiver\rtp_receiver\mod.rs:496:13
|
496 | tracks.first().cloned()
| ^^^^^^^^^^^^^^^^^^^^^^^ expected `Option<Arc<TrackRemote>>`, found `Option<TrackStreams>`
|
= note: expected enum `std::option::Option<std::sync::Arc<track::track_remote::TrackRemote>>`
found enum `std::option::Option<track::TrackStreams>`
error: aborting due to 1 previous error
For more information about this error, try `rustc --explain E0308`.
Original diagnostics will follow.
warning: you are explicitly cloning with `.map()`
--> webrtc\src\rtp_transceiver\rtp_receiver\mod.rs:496:13
|
496 | tracks.first().map(|t| Arc::clone(&t.track))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `tracks.first().cloned()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
= note: `#[warn(clippy::map_clone)]` on by default
warning: you are explicitly cloning with `.map()`
--> webrtc\src\rtp_transceiver\mod.rs:304:9
|
304 | self.mid.get().map(Clone::clone)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `self.mid.get().cloned()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
warning: `webrtc` (lib) generated 2 warnings (run `cargo clippy --fix --lib -p webrtc` to apply 2 suggestions)
Finished dev [unoptimized + debuginfo] target(s) in 18.22s
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment