Skip to content

Instantly share code, notes, and snippets.

@Rahkeen
Last active August 7, 2017 22:10
Show Gist options
  • Save Rahkeen/7e06ccb2e2fbccd21ec0313385321a04 to your computer and use it in GitHub Desktop.
Save Rahkeen/7e06ccb2e2fbccd21ec0313385321a04 to your computer and use it in GitHub Desktop.
AppCompat Spike

Screens + Flows Looked At

  • Account Settings
  • Profile / Performance
  • Featured
  • Class Library
  • Live Schedule
  • Scenic
  • In Class
  • Login / Activation / Registration

Side Effects / UX Defects

  • [Account Settings] Widget Accent Colors
  • [Class Library] Spinner Dropdown position / shadow
  • [Live Schedule] Spinner Dropdown position / shadow + Encore Toggle
  • [Live Class] Loading spinner color when starting
  • There is a default accent color being added on most widgets (Checkbox, EditText)
  • Some rendering issues seem to be Ruby specific
  • Dropdown offset for Spinner Dropdown renders differently for Quartz and Ruby

Takeaways / Effort to Migrate

During this spike I did try to fix some of these issues. The accent color ones should be easily solved by just overriding the correct theme attribute. This color can be the same as the current 'accentColor' that we are using already. The difficult one might be the Spinner rendering issues and potentially the Encore toggle custom view. For the Spinners it seems like a shadow is trying to be applied to the dropdown, and it starts to look weird on the custom 9-patch that we are using. Though on quartz this is a non-issue (since shadows are most likely not supports / added). Overall I think the effort to migrate isn't terrible. It will take some effort to get some widgets to behave properly on both Quartz and Ruby (mainly spinners), but everything else seems to look normal and not effect our UX. This will of course require a thorough e2e walkthrough of the app and make sure everything looks fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment