Skip to content

Instantly share code, notes, and snippets.

Last active May 28, 2024 13:06
Show Gist options
  • Save RobinMalfait/490a0560a7cfde985d435ad93f8094c5 to your computer and use it in GitHub Desktop.
Save RobinMalfait/490a0560a7cfde985d435ad93f8094c5 to your computer and use it in GitHub Desktop.
import React, { ReactNode } from "react";
import { classNames } from "../utils/class-names";
enum Variant {
type Props = {
variant: Variant;
children?: ReactNode;
const VARIANT_MAPS: Record<Variant, string> = {
[Variant.GRAY]: "bg-gray-100 text-gray-800",
[Variant.RED]: "bg-red-100 text-red-800",
[Variant.ORANGE]: "bg-orange-100 text-orange-800",
[Variant.YELLOW]: "bg-yellow-100 text-yellow-800",
[Variant.GREEN]: "bg-green-100 text-green-800",
[Variant.TEAL]: "bg-teal-100 text-teal-800",
[Variant.BLUE]: "bg-blue-100 text-blue-800",
[Variant.INDIGO]: "bg-indigo-100 text-indigo-800",
[Variant.PURPLE]: "bg-purple-100 text-purple-800",
[Variant.PINK]: "bg-pink-100 text-pink-800"
export function Badge(props: Props) {
const { children, variant } = props;
return (
"inline-flex items-center px-2.5 py-0.5 rounded-full text-xs font-medium leading-4 whitespace-no-wrap",
Badge.defaultProps = {
variant: Variant.GRAY
Badge.variant = Variant;
<Badge />
<Badge variant={Badge.variant.GRAY} />

Why this is bad (you might think)

  1. The file is big
  2. The file might look unmaintainable:
  • You have to update the class map & the enum (spoiler: TypeScript will ensure this is in sync)
  • There is a lot of duplicate code (the classNames per variant are almost the same except for the color)

Why this is good

  1. You know the exact states your component can be in
  2. There is no cleverness / dynamic classes going on -> More maintable
  3. There is no className prop, this means that we know what states / variants our component can be in, we don't introduce new implicit states (a large badge if we add className="text-xl")
  4. If one of the values need an extra class, you can add it, no need for clever tricks. (E.g.: Let's say a yellow color needs a darker text color)
  5. PurgeCSS can easily remove non-used css classes

Here is a bad example:

Copy link

dpschen commented Jan 24, 2024

In case someone stumbles over this again:

Is there anything wrong with using doing it like this, now that we have satisfies?

const VARIANT_MAPS = {
  gray: "bg-gray-100 text-gray-800",
  red: "bg-red-100 text-red-800",
  orange: "bg-orange-100 text-orange-800",
  // [...]
} satisfies Record<string, string>

export type ButtonProps = {
  variant: keyof typeof VARIANT_MAPS;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment